Block a user
Write rclone uploads under a temporary name and move them into place
internal/storage/rclone.go:261moves the finished upload onto its key with the remote's own move, and on several rclone backends that move does not replace an object already at the key:…
Exit 130 and say so when a command is interrupted
- Fixed in
internal/cli/app.go: the comment before the flags are read now saysRunWithAppreturns only afterOnStophas waited for the goroutine to return, and that ifOnStoptimed out it…
DNS blocklists asked in the background, verdicts kept
Exit 130 and say so when a command is interrupted
internal/cli/app.go:303-306: the comment says the flags are safe to read because the goroutine sets them before triggering the shutdown that letsRunWithAppreturn. That is false for…
Write rclone uploads under a temporary name and move them into place
Rework delta:
- Fixed: the temporary name and move are now used on every remote with a server-side move, without the
PartialUploadscondition, so hdfs is covered. The README now says rclone…
A blob upload to an rclone destination cut off by a hard kill leaves a partial object that the next backup trusts
Amending the definition of done after the review of sneak/vaultik#274. The repo's own docs decide this.
- Item 1 is dropped (upload again when the stored size…
Exit 130 and say so when a command is interrupted
- Fixed in
internal/cli/entry_interrupt_test.go: the sender now emptiescaughtbefore each SIGINT and waits for that SIGINT to arrive oncaughtbefore it sends again or returns, so none is…
Write rclone uploads under a temporary name and move them into place
README.md:437says every other rclone remote shows an object only once its upload has completed. That is false for rclone's hdfs backend, which writes straight to the final name and is not…
Blocklists and an AS percentage file fetched by URL
Blocklists and an AS percentage file fetched by URL
Review passed.
Judgement call: a list fetched whole just as smallwebwaf stops is kept, as fetch in internal/reputation/reputation.go does, but no test covers it; accepted, since a stop has…
Exit 130 and say so when a command is interrupted
internal/cli/entry_interrupt_test.go:97-101: the cleanup stops catching SIGINT as soon as the sender goroutine has returned, but the sender's last SIGINT may not have been delivered yet. A…