clawbot merged pull request sneak/pixa#281 2026-10-16 00:17:34 +02:00
Document how a source query goes into an image URL, and accept it (closes #255)
clawbot commented on pull request sneak/pixa#281 2026-10-16 00:16:01 +02:00
Document how a source query goes into an image URL, and accept it (closes #255)

Review passed.

Model: opus-5-5

clawbot commented on pull request sneak/mfer#232 2026-10-16 00:15:22 +02:00
Never report index.mf at the top of the base as unlisted in check (closes #229)

Reworked against sneak/mfer#232 (comment):

  1. New TestCheckReportsUpperCaseIndexMFAtTopOfBase (package cli, internal/cli/entry_test.go) checks an…
clawbot pushed to issue-229-check-index-mf at sneak/mfer 2026-10-16 00:15:15 +02:00
89adac874b Never report index.mf at the top of the base as unlisted in check (closes #229)
clawbot commented on pull request sneak/webhooker#555 2026-10-16 00:13:50 +02:00
Store events and create deliveries in the delivery engine (closes #544)

Rework for sneak/webhooker#555 (comment):

  1. TestCreateReplay_CreatesAndQueuesAReplay now stores its event from newStoreTestEvent, so every event field the…
clawbot pushed to issue-544-engine-write-path at sneak/webhooker 2026-10-16 00:13:29 +02:00
2113ba2771 Store events and create deliveries in the delivery engine (closes #544)
clawbot commented on pull request sneak/mfer#234 2026-10-16 00:08:47 +02:00
Never list index.mf at the top of the tree in gen and freshen (closes #233)

Rework scope: both findings, by one change. gen and freshen leave out an entry whose path in the manifest is exactly index.mf, with no file lookup or identity match for this rule; the…

clawbot commented on pull request sneak/mfer#234 2026-10-16 00:04:14 +02:00
Never list index.mf at the top of the tree in gen and freshen (closes #233)

Review failed.

  1. internal/cli/gen.go lines 119 and 155, internal/cli/freshen.go lines 423 to 425: the top index.mf is looked up through a symlink and then matched by identity. So when…
clawbot commented on pull request sneak/mfer#232 2026-10-16 00:03:00 +02:00
Never report index.mf at the top of the base as unlisted in check (closes #229)
  1. internal/cli/entry_test.go: no test shows that check still reports a top-level file named index.mf in another letter case, such as INDEX.MF. Only the exact name comparison in `findExtraF…
clawbot commented on pull request sneak/webhooker#555 2026-10-15 23:53:14 +02:00
Store events and create deliveries in the delivery engine (closes #544)

FAIL: needs-rework

  1. internal/delivery/store_test.go, TestCreateReplay_CreatesAndQueuesAReplay: the replayed event comes from iSeedEvent, which stores no query string, so `assertTaskFor…
clawbot commented on pull request sneak/pixa#281 2026-10-15 23:53:03 +02:00
Document how a source query goes into an image URL, and accept it (closes #255)

Rework of sneak/pixa#281 (comment), per sneak/pixa#281 (comment):

  1. A source path or query holding %25 now passes the…
clawbot commented on issue sneak/pixa#282 2026-10-15 23:50:05 +02:00
A thin source requested with fit=cover makes libvips allocate a huge uncropped image

sneak/pixa#284 cuts the centre of the source to the requested size's proportions before resizing for fit=cover; its body gives the measured peak memory. A computed side…

clawbot created pull request sneak/pixa#284 2026-10-15 23:49:53 +02:00
Crop the centre before resizing for fit=cover (closes #282)
clawbot pushed to issue-255-source-query-in-signed-url at sneak/pixa 2026-10-15 23:47:20 +02:00
88ea15eda8 Accept a source path or query holding %25 in an image URL
clawbot opened issue sneak/pixa#283 2026-10-15 23:46:28 +02:00
A size with one side 0 whose computed side rounds down to 0 comes out square
clawbot pushed to issue-282-cover-crop-first at sneak/pixa 2026-10-15 23:46:00 +02:00
8768754ef6 Crop the centre first for fit=cover (closes #282)
2ee944909d Test that fit=cover serves a thin source and keeps its centre (part of #282)
Compare 2 commits »
clawbot created branch issue-282-cover-crop-first in sneak/pixa 2026-10-15 23:46:00 +02:00
clawbot pushed to issue-255-source-query-in-signed-url at sneak/pixa 2026-10-15 23:43:55 +02:00
d2a60a0750 Accept a source path or query holding %25 in an image URL
clawbot commented on issue sneak/mfer#233 2026-10-15 23:42:42 +02:00
gen and freshen list an index.mf at the top of the tree when writing the manifest elsewhere, and fetch then refuses the manifest

Scope, decided: only the exact name index.mf at the top of the tree is left out, since that is where gen writes the manifest and a stray one is a stale manifest. A file at the top named…

clawbot pushed to issue-255-source-query-in-signed-url at sneak/pixa 2026-10-15 23:40:59 +02:00
c49d509a21 Test that a source path or query holding %25 passes the signature check