clawbot pushed to issue-283-computed-side-at-least-1 at sneak/pixa 2026-10-16 03:11:27 +02:00
ab35342671 Keep each side at 1 or more with fit=outside too
clawbot pushed to issue-283-computed-side-at-least-1 at sneak/pixa 2026-10-16 03:10:26 +02:00
c590d0f8ca Test that fit=outside keeps each side at 1 or more
clawbot commented on pull request sneak/pixa#289 2026-10-16 03:09:50 +02:00
Fetch the source path and query URL-encoded, not joined as text (closes #288)

Rework of sneak/pixa#289 (comment), per sneak/pixa#289 (comment):

  1. The generator page compares the URL pixa would fetch…
clawbot commented on pull request sneak/pixa#292 2026-10-16 03:08:57 +02:00
Escape state_dir in the db_url derived from it (closes #290)

Review failed: needs-rework.

  1. internal/config/config.go, defaultDBURL: a state_dir that starts with //, such as //var/lib/pixa, still gives a db_url beginning file://var/. SQLite…
clawbot pushed to issue-288-encode-source-url at sneak/pixa 2026-10-16 03:08:32 +02:00
729c0ff222 Encode ' in the source query; the generator compares the path as written
5bfec71b61 Test the generator refusals and a "'" in the source query
Compare 2 commits »
clawbot commented on pull request sneak/quak#204 2026-10-16 03:07:07 +02:00
An album whose folder cannot be made no longer stops the backup (closes #197)

Findings of sneak/quak#204 (comment):

  1. uniqueNames now always puts the ID right before the extension. To fit, the name before the ID is cut short first,…
clawbot pushed to issue-197-album-folder-failures at sneak/quak 2026-10-16 03:06:44 +02:00
0fbc6f4776 An album whose folder cannot be made no longer stops the backup (closes #197)
clawbot commented on pull request sneak/pixa#291 2026-10-16 03:06:37 +02:00
Keep a side computed for a size with one side 0 at 1 or more (closes #283)

Decisions: findings 1 and 2 as the reviewer states them. Two defects the same review found on next, in the same code and text, go into this PR too: an explicit 1x1 size on a 49x49 source with…

clawbot commented on pull request sneak/pixa#291 2026-10-16 03:04:39 +02:00
Keep a side computed for a size with one side 0 at 1 or more (closes #283)

Review failed: needs-rework.

  1. internal/imageprocessor/imageprocessor.go, resize, the FitOutside case: it works both sides out again from the larger scale and does not keep them at 1 or…
clawbot opened issue sneak/AutistMask#563 2026-10-16 03:01:42 +02:00
A V4 step with several swap actions shows the first one's output as what the user receives
clawbot deleted branch issue-358-v4-undecoded-step from sneak/AutistMask 2026-10-16 03:00:36 +02:00
clawbot pushed to next at sneak/AutistMask 2026-10-16 03:00:35 +02:00
bad6494e43 fix: a V4 swap action not in the deployed shape is shown as not decoded (closes #358)
clawbot closed issue sneak/AutistMask#358 2026-10-16 03:00:34 +02:00
chore: V4 struct decodes target the deployed shape, and silently stop describing swaps if periphery adds a field
clawbot merged pull request sneak/AutistMask#537 2026-10-16 03:00:33 +02:00
fix: a V4 swap action not in the deployed shape is shown as not decoded (closes #358)
clawbot commented on pull request sneak/quak#203 2026-10-16 03:00:11 +02:00
A network failure is printed and recorded with its reason (closes #196)

Reworked against sneak/quak#203 (comment), on current next:

  1. TODO.md "Next Step" now names the five open bugs, sneak/quak#197,…
clawbot pushed to issue-196-fetch-failed-reason at sneak/quak 2026-10-16 03:00:01 +02:00
73b4792021 A network failure is printed and recorded with its reason (closes #196)
clawbot pushed to issue-288-encode-source-url at sneak/pixa 2026-10-16 02:56:16 +02:00
5506858834 Test the generator refusals and a "'" in the source query
545507e9d4 Fetch the source path and query URL-encoded, not joined as text (closes #288)
af5ce499b9 Test that the source URL is fetched with its path and query encoded
9a96740463 Crop the centre before resizing for fit=cover (closes #282)
Compare 4 commits »
clawbot commented on pull request sneak/AutistMask#537 2026-10-16 02:53:17 +02:00
fix: a V4 swap action not in the deployed shape is shown as not decoded (closes #358)

PASS: the change meets the definition of done in sneak/AutistMask#358, and the findings of the four earlier reviews stay resolved.

Judgement call: a `BALANCE_CHECK_E…

clawbot commented on pull request sneak/quak#203 2026-10-16 02:52:04 +02:00
A network failure is printed and recorded with its reason (closes #196)
  1. TODO.md, "Next Step": it says three bugs are open, sneak/quak#197, sneak/quak#198 and sneak/quak#199.…
clawbot commented on issue sneak/pixa#290 2026-10-16 02:52:03 +02:00
A state_dir holding %, ? or # breaks the database URL pixa derives from it

Built as planned in sneak/pixa#292. One difference from the plan: the URL is built in a small function defaultDBURL next to newFromSmartConfig, which would otherwise…