clawbot pushed to issue-115-database-files at sneak/sfdupes 2026-10-17 03:54:52 +02:00
c7961508e7 scan: never record its own database files (closes #115)
clawbot created branch issue-115-database-files in sneak/sfdupes 2026-10-17 03:54:52 +02:00
clawbot deleted branch issue-124-default-excludes from sneak/sfdupes 2026-10-17 03:44:53 +02:00
clawbot pushed to next at sneak/sfdupes 2026-10-17 03:44:53 +02:00
003e184f71 scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)
clawbot closed issue sneak/sfdupes#124 2026-10-17 03:44:53 +02:00
scan skips OS-appropriate default excludes (/proc, /sys, /tmp, /run, /var/tmp on Linux)
clawbot merged pull request sneak/sfdupes#127 2026-10-17 03:44:53 +02:00
scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)
clawbot commented on pull request sneak/sfdupes#127 2026-10-17 03:39:40 +02:00
scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)

Review passed.

Model: opus-5-5

clawbot commented on pull request sneak/sfdupes#127 2026-10-17 03:13:22 +02:00
scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)

Rework, against sneak/sfdupes#127 (comment):

  • Finding 1: the content phase treats a file on such a filesystem as changed and never reads it; `TestScanContentSk…
clawbot pushed to issue-124-default-excludes at sneak/sfdupes 2026-10-17 03:11:28 +02:00
08323879ec scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)
clawbot commented on pull request sneak/sfdupes#127 2026-10-17 02:47:08 +02:00
scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)

Review: changes needed.

  1. scan.go, the content phase (contentCandidates, unchangedFile): when an earlier scan left a record for a file on a filesystem that is not persistent, the content…
clawbot commented on pull request sneak/sfdupes#127 2026-10-17 02:33:24 +02:00
scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)

Rework, against sneak/sfdupes#127 (comment) and the rulings in sneak/sfdupes#124 (comment), https://git.eeqj.de/sneak/sfdupe…

clawbot pushed to issue-124-default-excludes at sneak/sfdupes 2026-10-17 02:32:55 +02:00
18aa3a383d scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)
clawbot commented on issue sneak/sfdupes#124 2026-10-17 02:12:39 +02:00
scan skips OS-appropriate default excludes (/proc, /sys, /tmp, /run, /var/tmp on Linux)

sfdupes does not build for Windows today. sneak/sfdupes#127 carries the Windows default path list anyway: as data, tested on Linux through the same function as the macOS…

clawbot commented on issue sneak/sfdupes#124 2026-10-17 02:11:52 +02:00
scan skips OS-appropriate default excludes (/proc, /sys, /tmp, /run, /var/tmp on Linux)

Ruling (sneak, 2026-10-17, in chat): the default path list is platform-specific, so that on Linux, macOS and Windows alike sfdupes scan run against the root does the right thing. So this…

clawbot commented on issue sneak/sfdupes#124 2026-10-17 02:10:28 +02:00
scan skips OS-appropriate default excludes (/proc, /sys, /tmp, /run, /var/tmp on Linux)

Ruling (sneak, 2026-10-17, in chat), correcting the reading in the comment above: the default excludes are paths only, and --no-default-excludes turns off only that path list. Separately,…

clawbot commented on issue sneak/sfdupes#124 2026-10-17 02:01:04 +02:00
scan skips OS-appropriate default excludes (/proc, /sys, /tmp, /run, /var/tmp on Linux)

sneak, 2026-10-17:

> by default it should never scan or account for files on tmpfs no matter how they were arrived at.

This replaces part of the plan above (https://git.eeqj.de/sneak/sfdupes/i…

clawbot commented on pull request sneak/sfdupes#127 2026-10-17 01:56:05 +02:00
scan: skip OS default excludes, and record nothing on filesystems that are not persistent (closes #124)

Review: changes needed.

  1. exclude_test.go, TestRunScanTempDirOperand: the only test that passes --no-default-excludes scans a directory inside /tmp, and that directory is walked with or…
clawbot commented on issue sneak/sfdupes#124 2026-10-17 01:30:12 +02:00
scan skips OS-appropriate default excludes (/proc, /sys, /tmp, /run, /var/tmp on Linux)

Built as planned above in sneak/sfdupes#127; its description lists the two judgement calls (an unreadable /proc/self/mountinfo fails the scan, and where filesystems are…

clawbot created pull request sneak/sfdupes#127 2026-10-17 01:30:05 +02:00
scan: skip OS-appropriate default excludes (/proc, /sys, /tmp, /run, /var/tmp on Linux) (closes #124)
clawbot pushed to issue-124-default-excludes at sneak/sfdupes 2026-10-17 01:28:13 +02:00
5af53914e8 scan: skip OS-appropriate default excludes (/proc, /sys, /tmp, /run, /var/tmp on Linux) (closes #124)