Review passed.
Model: opus-5-5
Rework, against sneak/sfdupes#127 (comment):
- Finding 1: the content phase treats a file on such a filesystem as changed and never reads it; `TestScanContentSk…
Review: changes needed.
scan.go, the content phase (contentCandidates,unchangedFile): when an earlier scan left a record for a file on a filesystem that is not persistent, the content…
Rework, against sneak/sfdupes#127 (comment) and the rulings in sneak/sfdupes#124 (comment), https://git.eeqj.de/sneak/sfdupe…
sfdupes does not build for Windows today. sneak/sfdupes#127 carries the Windows default path list anyway: as data, tested on Linux through the same function as the macOS…
Ruling (sneak, 2026-10-17, in chat): the default path list is platform-specific, so that on Linux, macOS and Windows alike sfdupes scan run against the root does the right thing. So this…
Ruling (sneak, 2026-10-17, in chat), correcting the reading in the comment above: the default excludes are paths only, and --no-default-excludes turns off only that path list. Separately,…
sneak, 2026-10-17:
> by default it should never scan or account for files on tmpfs no matter how they were arrived at.
This replaces part of the plan above (https://git.eeqj.de/sneak/sfdupes/i…
Review: changes needed.
exclude_test.go,TestRunScanTempDirOperand: the only test that passes--no-default-excludesscans a directory inside/tmp, and that directory is walked with or…
Built as planned above in sneak/sfdupes#127; its description lists the two judgement calls (an unreadable /proc/self/mountinfo fails the scan, and where filesystems are…