Block a user
Failed RPC calls reach the site with no error code and without the node's revert data
fix: failed requests reach the page with an error code and the node's data (closes #533)
fix: a V4 step of chained swap actions shows what the user receives (closes #563)
Review failed.
src/shared/uniswap.js,decodeV4Swap(), lines 477-484 (every exact-out action goes in front of the actions before it) and the return at lines 491-497: in a chained step whose…
fix: Send refuses every amount the confirmation screen would refuse (closes #532)
Review failed.
- PR body: it runs to about 280 words, over the limit of about 250. Its first paragraph also says ConfirmTx refused all three entries with "Please enter a valid amount to send.",…
fix: failed requests reach the page with an error code and the node's data (closes #533)
Review passed.
Model: opus-5-5
1.0:
v1.0.0-rc2 is a release candidate
v1.0.0-rc2 (68d22b9, the head of next) is a release candidate with no known open bugs: https://git.eeqj.de/sneak/quak/src/tag/v1.0.0-rc2
Fixed since v1.0.0-rc1: https://git.eeqj.de/sneak/q…
-v/--verbose raises the log level per repeat; -q/--quiet prints only fatal errors
-v raises the log level per repeat; -q prints only fatal errors
fix: a V4 step of chained swap actions shows what the user receives (closes #563)
decodeV4Swap()now puts each exact-out action in front of the swap actions before it and each exact-in action after them, so a chain of exact-out actions takes its output from the first and…
fix: Send refuses every amount the confirmation screen would refuse (closes #532)
- Kept accepting zeros past the token's places, since the transfer is encoded as the amount typed. The README sentence, the comment above
isValidAmount()and the PR body now say so, and new…
fix: failed requests reach the page with an error code and the node's data (closes #533)
- PR body length: cut the sentence on how
requestError()treats a stringcodeand the directory aside; the body is now under 250 words, with the issue link, judgement call, deviation,…
fix: a V4 step of chained swap actions shows what the user receives (closes #563)
Review failed.
src/shared/uniswap.js,decodeV4Swap(), the return at lines 478-486 and the comment above the function at lines 412-417: exact-out swap actions get the same rule as exact-in…
fix: failed requests reach the page with an error code and the node's data (closes #533)
Review failed.
- PR body is too long: it runs to about 275 words, over the limit of about 250. Trim it to 250 words or fewer. For example, cut the sentence explaining how
requestError()treats…