• Joined on 2026-02-08
clawbot commented on issue sneak/neoirc#52 2026-03-10 00:54:30 +01:00
please identify a list of all IRC numeric c2s and s2c codes that exist in common/standard irc usage, and identify which we have implemented and which we have not

Closing: completed by PR #59 (IRC numerics batch 2 — internal/irc/ package with 60+ named constants, command constants, reply format with code/command…

clawbot commented on pull request sneak/neoirc#61 2026-03-09 23:54:47 +01:00
fix: replay channel state on SPA reconnect

Review: PASS

Reviewed all changes in PR #61 against issue #60.

Checklist

  • **Server replays…
clawbot commented on pull request sneak/neoirc#59 2026-03-09 23:54:27 +01:00
feat: implement IRC numerics batch 2 — connection registration, channel ops, user queries

Review: PASS

Reviewed PR #59 (IRC numerics batch 2, closing issue #52). This is the final review after…

clawbot commented on pull request sneak/neoirc#59 2026-03-09 23:50:07 +01:00
feat: implement IRC numerics batch 2 — connection registration, channel ops, user queries

Rework: IRC Numerics Package + Reply Format + Dead Code Fix + Constant Deduplication

All FOUR issues addressed in a single commit.

1. New internal/irc/ Package (BLOCKING #1 + sneak's…

clawbot pushed to feature/irc-numerics-batch2 at sneak/neoirc 2026-03-09 23:49:40 +01:00
7bbd6de73a feat: add irc numerics package, deduplicate constants, fix dead code
clawbot pushed to fix/spa-reconnect-channel-tabs at sneak/neoirc 2026-03-09 23:49:11 +01:00
122968d7c4 docs: document ?replay=1 query parameter for GET /state
clawbot created pull request sneak/neoirc#61 2026-03-09 23:48:23 +01:00
fix: replay channel state on SPA reconnect
clawbot pushed to fix/spa-reconnect-channel-tabs at sneak/neoirc 2026-03-09 23:48:09 +01:00
785e557b87 fix: replay channel state on SPA reconnect
clawbot created branch fix/spa-reconnect-channel-tabs in sneak/neoirc 2026-03-09 23:48:09 +01:00
clawbot commented on pull request sneak/neoirc#59 2026-03-09 23:30:41 +01:00
feat: implement IRC numerics batch 2 — connection registration, channel ops, user queries

Review: FAIL

Reviewed PR #59 (IRC numerics batch 2), specifically the rework cycle addressing constants consistency ([comment](https://git.eeqj.de/…

clawbot commented on pull request sneak/neoirc#59 2026-03-09 23:24:50 +01:00
feat: implement IRC numerics batch 2 — connection registration, channel ops, user queries

Rework: Consistent Command Constants

Fixed the inconsistency where some IRC command strings used named constants while others were bare string literals.

Constants Added

**`internal/handle…

clawbot pushed to feature/irc-numerics-batch2 at sneak/neoirc 2026-03-09 23:24:21 +01:00
5efb4b6949 refactor: replace all bare command string literals with named constants
clawbot commented on pull request sneak/neoirc#59 2026-03-09 23:20:03 +01:00
feat: implement IRC numerics batch 2 — connection registration, channel ops, user queries

Rework agent is already in flight — fixing all inconsistent command string literals to use named constants. Should be done shortly.

clawbot commented on pull request sneak/neoirc#59 2026-03-09 23:09:12 +01:00
feat: implement IRC numerics batch 2 — connection registration, channel ops, user queries

PR #59 Review: feature/irc-numerics-batch2

clawbot commented on pull request sneak/neoirc#58 2026-03-09 23:08:24 +01:00
fix: IRC SPA cleanup — /motd, /query, Firefox / key, default MOTD

Post-Merge Review: PR #58 — IRC SPA Cleanup (2nd review cycle)

Note: This PR was merged by sneak before this review completed. Findings are…

clawbot commented on pull request sneak/neoirc#59 2026-03-09 23:07:14 +01:00
feat: implement IRC numerics batch 2 — connection registration, channel ops, user queries

CI Fix

The goconst linter flagged repeated IRC command string literals (LIST, WHO, WHOIS, QUIT, JOIN, NICK, PART, TOPIC) in internal/handlers/api.go.

Fix: Extracted…

clawbot pushed to feature/irc-numerics-batch2 at sneak/neoirc 2026-03-09 23:07:05 +01:00
a193831ed4 fix: extract repeated IRC command string literals to constants (goconst)
8d26df60db feat: implement IRC numerics batch 2 — connection registration, channel ops, user queries
Compare 2 commits »
clawbot opened issue sneak/neoirc#60 2026-03-09 23:04:04 +01:00
[bug] SPA reconnect does not restore channel tabs
clawbot commented on pull request sneak/neoirc#58 2026-03-09 22:59:53 +01:00
fix: IRC SPA cleanup — /motd, /query, Firefox / key, default MOTD

Rework: Added /list, /who, /whois commands + CLI parity

Addressed all review findings and sneak's feedback:

Server-side (internal/handlers/api.go)

  • Added LIST command handler —…
clawbot pushed to fix/irc-spa-cleanup at sneak/neoirc 2026-03-09 22:59:35 +01:00
a48c7f562c feat: add /list, /who, /whois commands + CLI parity