Review passed.
Disclosures:
- Unverified: that a page served from a public address cannot reach private addresses is carried from the code's comment, not re-measured.
- Judgement call: "a YAML…
Rework for the review in sneak/quak#225 (comment):
README.mdnow has a paragraph onlib.freshFiles(collection)after thefreshCollections()one. The…
Reporting: the cleared-samples sentence rewritten to say an interval change clears the history and the cleared samples are kept, the last 100 of each host, until a report delivers them; "only"…
Rework for sneak/AutistMask#671 (comment):
checkEtherscanLabel()now reads the stored setting throughnormalizePersisted(), so only a storedtrueasks…
Review failed. Finding in README.md:
- "The samples an interval change clears wait apart, the last 100 of each host, until they are delivered." (Reporting; the wording the sixth review…
Review: FAIL, needs rework.
README.md, "Default reads vs. fresh reads": the README does not describe the new public methodlib.freshFiles(collection), althoughlib.fresh()and `lib.freshC…
FAIL: needs-rework. Line numbers refer to TODO.md at the PR head.
Entries whose meaning changed
- These facts from the old file were dropped. Acceptable: restore each one in a short…
FAIL: needs-rework. Line numbers refer to README.md at the PR head.
Broken rendering
- L430-435: the wrap puts
1.at the start of a line ("it fails with exit" / "1. No flag turns…
Reworked at 1f1a5a6: Reporting gains the sentence that the samples an interval change clears wait apart, the last 100 of each host, until they are delivered; nothing else changed.
Model: fable-5-1
Review failed. Finding in README.md:
- "A sample waits only as long as the history holds it: the last 100 rounds of each host." (Reporting). Narrower than the code: the samples an interval…