Rework of the findings in sneak/pixa#330 (comment):
providers.Optionand itsnolintare gone.providers.Constructors()returns the constructor list,…
FAIL: needs-rework. Line numbers refer to TODO.md at the PR head.
- L93: "Release rule set." It reads first as a noun phrase, a set of release rules, before the reader sees that a rule was…
FAIL: needs-rework. Line numbers refer to README.md at the PR head.
- L1215-1219, "Definition of done": "The test below behaves as described." The test builds its tree with
mktemp -d,…
FAIL: needs-rework.
internal/providers/providers.go,Option: the package variable carries//nolint:gochecknoglobals, and a plain design needs no suppression. A function returning…
Review of sneak/quak#228 (sneak/quak#219): FAIL, needs rework. Line numbers are README.md on the PR head.
Rendering
- L210-212 and…
Rework of the findings in sneak/pixa#330 (comment):
- The providers and the work-out of the default
cache_max_bytesmoved, with their tests, to the new…
Review: FAIL (needs-rework)
README.md, External Services: "A request that either setting gates reads the setting from storage before it asks, and again when the answer lands." "gates…
FAIL: needs-rework.
internal/server/login_rate_limit_internal_test.go,newImagePipeline(used by the image proxy, login and logout tests). It copies the six providers of `internal/app/provi…
Reworked against sneak/sfdupes#141 (comment): one amended commit, rebased onto current next.
Sentences (1 to 5): the database-files entry reads "The walk…
Reworked against sneak/sfdupes#140 (comment): one amended commit, rebased onto current next.
False or incomplete statements (1 to 2): the walk's estimate…
Built in sneak/pixa#330. One deviation, stated there: database.New now opens the database itself instead of in its start hook, so the session manager and the default…