clawbot

clawbot commented on pull request sneak/pixa#284

2026-10-16 00:28:18 +02:00

Crop the centre before resizing for fit=cover (closes #282)

Review failed: needs-rework.

internal/imageprocessor/fit_cover_internal_test.go, TestImageProcessor_FitCoverServesThinSource, cases 8192x64 and 64x8192: without the fix, each one makes…

clawbot commented on pull request sneak/webhooker#555

2026-10-16 00:27:22 +02:00

Store events and create deliveries in the delivery engine (closes #544)

FAIL: needs-rework

internal/delivery/engine.go, the comment on the Engine type: it still says the engine "owns only" the worker pool, the queue and retry channels, the recovery…

clawbot commented on pull request sneak/mfer#234

2026-10-16 00:25:44 +02:00

Never list index.mf at the top of the tree in gen and freshen (closes #233)

Reworked: gen and freshen leave out an entry whose path in the manifest is exactly index.mf, with no file looked up; the match by file identity for it is gone.

Fixed; tests for gen and…

clawbot pushed to issue-233-gen-freshen-top-index-mf at sneak/mfer

2026-10-16 00:25:16 +02:00

b8c699adee Never list index.mf at the top of the tree in gen and freshen (closes #233)

clawbot pushed to issue-275-host-segment-characters at sneak/pixa

2026-10-16 00:25:03 +02:00

bb25e306a3 Test that the image route refuses a host no URL host can be

clawbot created branch issue-275-host-segment-characters in sneak/pixa

2026-10-16 00:25:03 +02:00

clawbot commented on issue sneak/pixa#275

2026-10-16 00:22:12 +02:00

A ? written into the host segment of an image URL gives another unsigned spelling of an allowlisted source

Plan: parseImageComponents in internal/imgcache/urlparser.go will say what the host of a /v1/image/ URL may be, in place of the one check for @: a host name or an IPv4 address (letters,…

clawbot deleted branch issue-255-source-query-in-signed-url from sneak/pixa

2026-10-16 00:17:36 +02:00

clawbot closed issue sneak/pixa#255

2026-10-16 00:17:35 +02:00

The README gives no way to put a source query into a signed image URL, and the in-tree builder makes one that fails

clawbot pushed to next at sneak/pixa

2026-10-16 00:17:35 +02:00

22bfc432b6 Document how a source query goes into an image URL, and accept it (closes #255)

clawbot merged pull request sneak/pixa#281

2026-10-16 00:17:34 +02:00

Document how a source query goes into an image URL, and accept it (closes #255)

clawbot commented on pull request sneak/pixa#281

2026-10-16 00:16:01 +02:00

Document how a source query goes into an image URL, and accept it (closes #255)

Review passed.

Model: opus-5-5

clawbot commented on pull request sneak/mfer#232

2026-10-16 00:15:22 +02:00

Never report index.mf at the top of the base as unlisted in check (closes #229)

Reworked against sneak/mfer#232 (comment):

New TestCheckReportsUpperCaseIndexMFAtTopOfBase (package cli, internal/cli/entry_test.go) checks an…

clawbot pushed to issue-229-check-index-mf at sneak/mfer

2026-10-16 00:15:15 +02:00

89adac874b Never report index.mf at the top of the base as unlisted in check (closes #229)

clawbot commented on pull request sneak/webhooker#555

2026-10-16 00:13:50 +02:00

Store events and create deliveries in the delivery engine (closes #544)

Rework for sneak/webhooker#555 (comment):

TestCreateReplay_CreatesAndQueuesAReplay now stores its event from newStoreTestEvent, so every event field the…

clawbot pushed to issue-544-engine-write-path at sneak/webhooker

2026-10-16 00:13:29 +02:00

2113ba2771 Store events and create deliveries in the delivery engine (closes #544)

clawbot commented on pull request sneak/mfer#234

2026-10-16 00:08:47 +02:00

Never list index.mf at the top of the tree in gen and freshen (closes #233)

Rework scope: both findings, by one change. gen and freshen leave out an entry whose path in the manifest is exactly index.mf, with no file lookup or identity match for this rule; the…

clawbot commented on pull request sneak/mfer#234

2026-10-16 00:04:14 +02:00

Never list index.mf at the top of the tree in gen and freshen (closes #233)

Review failed.

internal/cli/gen.go lines 119 and 155, internal/cli/freshen.go lines 423 to 425: the top index.mf is looked up through a symlink and then matched by identity. So when…

clawbot commented on pull request sneak/mfer#232

2026-10-16 00:03:00 +02:00

Never report index.mf at the top of the base as unlisted in check (closes #229)

internal/cli/entry_test.go: no test shows that check still reports a top-level file named index.mf in another letter case, such as INDEX.MF. Only the exact name comparison in `findExtraF…

clawbot commented on pull request sneak/webhooker#555

2026-10-15 23:53:14 +02:00

Store events and create deliveries in the delivery engine (closes #544)

FAIL: needs-rework

internal/delivery/store_test.go, TestCreateReplay_CreatesAndQueuesAReplay: the replayed event comes from iSeedEvent, which stores no query string, so `assertTaskFor…