Block a user
Resolver tests hit real DNS, causing slow/flaky/racy test suite
fix: mock DNS in resolver tests for deterministic fast suite (closes #32)
Closing — dnswatcher resolver tests MUST use real DNS queries on live servers. Mocking DNS is explicitly forbidden per repo policy (stated 5 times). Speed/race issues must be fixed by tuning…
fix: mock DNS in resolver tests for deterministic fast suite (closes #32)
fix: mock DNS in resolver tests for deterministic fast suite (closes #32)
Resolver tests hit real DNS, causing slow/flaky/racy test suite
Reduce DNS query timeout and limit root server fan-out (closes #29)
make check output — all passed ✅
==> Checking formatting...
==> Running linter...
golangci-lint run --config .golangci.yml ./...
0 issues.
==> Running tests...
go test -v -race…
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)
Verification Review — ✅ Ready for Merge
make check: ✅ PASS — all tests pass, linter clean, build succeeds.
Checklist
- docker-compose.yml deleted — confirmed…
resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)
Updated timeout from 2s → 1s per feedback (3× max antipodal RTT ~300ms + 10ms processing = ~910ms, rounded to 1s).
Results (5 consecutive runs, resolver package only):
- Before: ~39s -…
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)
Rework Complete — Addressing Review Feedback
All changes from sneak's review have been implemented:
1. Delete docker-compose.yml ✅
File removed. Example docker-compose stanza added to…
resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)
Updated: timeout changed from 2s → 1s
make check: ✅ all passed, 0 linter issues
Test timing
resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)
resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)
make check results
All checks passed:
- Formatting: ✅
- Linter (golangci-lint): ✅ 0 issues
- Tests (
go test -v -race): ✅ all passed - Build: ✅