clawbot commented on pull request sneak/neoirc#166 2026-10-20 22:32:34 +02:00
Wait for IRC listener cleanup and HTTP shutdown on stop (closes #159)

Rework for sneak/neoirc#166 (comment):

  1. TestStopWaitsForRequestInProgress now starts the app with the providers cmd/neoircd uses and stops it through fx,…
clawbot pushed to issue-159-clean-shutdown at sneak/neoirc 2026-10-20 22:32:20 +02:00
e03e3a50c2 Wait for IRC listener cleanup and HTTP shutdown on stop (closes #159)
clawbot commented on pull request sneak/AutistMask#648 2026-10-20 22:31:45 +02:00
fix: a balance refresh that returns after a network switch writes nothing (closes #577)

Rework for review comment 152217:

  1. Added a test to tests/balanceRefreshNetworkSwitch.test.js that holds the refresh's save at its read of the stored record while the user switches to Sepolia…
clawbot commented on pull request sneak/AutistMask#651 2026-10-20 22:25:17 +02:00
fix: a permit shows on its own lines unless its amount is the Amount figure (closes #370)

Added: every PERMIT2_PERMIT whose amount does not stand as the Amount figure now gets the Permit2 allowance, Allowance token and Allowance spender lines. Before, only a permit after the…

clawbot pushed to issue-577-refresh-across-network-switch at sneak/AutistMask 2026-10-20 22:22:52 +02:00
d5921f0639 fix: a balance refresh that returns after a network switch writes nothing (closes #577)
a3da448f0d fix: a swap's WETH minimum reads as ETH only when all its WETH reaches the UNWRAP_WETH (closes #642)
Compare 2 commits »
clawbot commented on pull request sneak/neoirc#164 2026-10-20 22:21:04 +02:00
Run JOIN, PART and KICK as one transaction each (closes #153)

Rework for sneak/neoirc#164 (comment):

  1. Removed ClearChannelInvite and the part of TestChannelInviteCRUD that covered it. A JOIN uses up an invite only…
clawbot pushed to issue-153-join-transaction at sneak/neoirc 2026-10-20 22:20:57 +02:00
39955494a4 Run JOIN, PART and KICK as one transaction each (closes #153)
clawbot pushed to issue-370-trailing-permit-own-lines at sneak/AutistMask 2026-10-20 22:19:17 +02:00
292ebe544e fix: a permit shows on its own lines unless its amount is the Amount figure (closes #370)
clawbot commented on pull request sneak/AutistMask#648 2026-10-20 22:18:19 +02:00
fix: a balance refresh that returns after a network switch writes nothing (closes #577)

Review: FAIL (needs-rework)

  1. doRefreshAndRender() in src/popup/index.js: no test covers the check of the page's own network (state.networkId !== networkId). It is the only check…
clawbot commented on issue sneak/AutistMask#370 2026-10-20 22:09:48 +02:00
decision: a trailing PERMIT2_PERMIT replaces the swap's input side on the approval screen

Built in sneak/AutistMask#651: a PERMIT2_PERMIT after the step that sets the input side leaves Token In and Amount to the swap and gets its own Permit2 allowance,…

clawbot created pull request sneak/AutistMask#651 2026-10-20 22:09:40 +02:00
fix: a permit after a swap step shows on its own lines instead of replacing Token In (closes #370)
clawbot commented on pull request sneak/neoirc#166 2026-10-20 22:06:34 +02:00
Wait for IRC listener cleanup and HTTP shutdown on stop (closes #159)

FAIL (needs rework)

  1. internal/server/server_test.go, TestStopWaitsForRequestInProgress, with Stop in internal/server/export_test.go: the test calls cleanShutdown through a…
clawbot commented on pull request sneak/neoirc#164 2026-10-20 22:03:51 +02:00
Run JOIN, PART and KICK as one transaction each (closes #153)

FAIL (needs rework)

  1. internal/db/queries.go, ClearChannelInvite: its doc comment still says it is "called after successful JOIN". After this change nothing calls it outside its own…
clawbot pushed to issue-370-trailing-permit-own-lines at sneak/AutistMask 2026-10-20 21:51:51 +02:00
e185b96a32 fix: a permit after a swap step shows on its own lines instead of replacing Token In (closes #370)
clawbot created branch issue-370-trailing-permit-own-lines in sneak/AutistMask 2026-10-20 21:51:51 +02:00
clawbot opened issue sneak/neoirc#167 2026-10-20 21:49:15 +02:00
A failed HTTP listen is only logged, and the server runs on without its HTTP API
clawbot created pull request sneak/neoirc#166 2026-10-20 21:47:06 +02:00
Wait for IRC listener cleanup and HTTP shutdown on stop (closes #159)
clawbot pushed to issue-159-clean-shutdown at sneak/neoirc 2026-10-20 21:46:49 +02:00
3f936925b9 Wait for IRC listener cleanup and HTTP shutdown on stop (closes #159)
clawbot created branch issue-159-clean-shutdown in sneak/neoirc 2026-10-20 21:46:49 +02:00
clawbot deleted branch issue-642-unwrap-weth-minimum from sneak/AutistMask 2026-10-20 21:40:52 +02:00