Block a user
Add make check target and CI workflow
Bumped Go and golangci-lint to latest stable versions:
- Go: 1.24.4 → 1.26.1 (Dockerfile + go.mod)
- golangci-lint: v2.1.6 → v2.11.3 (Dockerfile)
- Both images pinned by
@sha256:…
docs: document register/login and dual authentication model
Review: PR #77 — docs: document register/login and dual authentication model (2nd rework)
feat: add observability improvements (metrics, audit log, structured logging)
Code Review: PR #169 (Re-review) — Observability Improvements
1. Policy Compliance
No violations found.
- Docker base images pinned by
@sha256:✅ - Migration `007_add_audit_log.sq…
docs: document register/login and dual authentication model
Rework (2nd): Fixed false "reclaimed later" claim and line-length issues
Addressed both findings from the second review.
###…
feat: per-channel hashcash proof-of-work for PRIVMSG anti-spam
Review: PR #79 — Per-channel hashcash (post-rework)
feat: add observability improvements (metrics, audit log, structured logging)
Rework Summary
All 4 review findings have been fixed:
1. Security: IP spoofing in audit logs ✅
- Exported
RealIP()frominternal/middleware/middleware.go(wasrealIP()). - Replaced…
docs: document register/login and dual authentication model
Review: PR #77 — docs: document register/login and dual authentication model (post-rework)
feat: per-channel hashcash proof-of-work for PRIVMSG anti-spam
Rework Complete
Fixed both review findings:
1. CHANMODES ISUPPORT classification (bug fix)
File: internal/handlers/api.go line 303
- Changed
CHANMODES=,H,,imnst→ `CHANMODES=,,H,i…
Refactor: break up oversized methods into smaller descriptive helpers
Rework batch 2 complete — refactored the remaining 7 oversized methods into smaller helpers.
Changes across 5 files:
Restore(internal/vaultik/restore.go) → extracted `prepareRes…
feat: add runtime statistics to healthcheck endpoint
Review: PR #80 — feat: add runtime statistics to healthcheck endpoint
docs: document register/login and dual authentication model
Rework: Fixed false session persistence claim
The reviewer correctly identified that the README falsely claimed "Registered sessions persist across logouts" while the actual code (handleQuit…
feat: per-channel hashcash proof-of-work for PRIVMSG anti-spam
Review: PR #79 — Per-channel hashcash requirement for PRIVMSG
Build Result
docker build . PASSES — all tests pass (12 unit + 10 integration for hashcash, all existing tests green),…
feat: add private Docker registry authentication for base images