Review failed. Findings, all in test/viewport/README.md:
- "The test is not part of
make check: it needs Docker and takes minutes, andmake testhas to finish in under 60 seconds." Needing…
Rework: findings 1 to 4 stand. For finding 4, the short README sentence is enough: a phase with nothing to do shows no bar.
Added to the rework, from the reviewer's judgement call: the bar must…
Review of sneak/quak#224 (fixes sneak/quak#217): FAIL, needs rework.
- **
src/library/index.ts,refreshCollection(), with `freshFiles()…
Reworked at a3b18b6, one change per finding:
- The console line: "Each failed check the page records writes one line to the browser console with
console.error, and the same line to the debug…
Reworked at b18ae07:
- The unit-test sentence is now two: "The unit tests in
test/unit/call the functions thatweb/src/main.jsexports, with no browser.make testruns them with Node's…
FAIL: needs-rework.
progress_test.go:746:TestTerminalBarStaysAtRightEdgechecks only where the bar starts. A bar drawn only as long as its filled cells, so that its right end moves as the…
Review failed. Findings in README.md:
- "Each check that fails writes one line to the browser console with
console.error, and the same line to the debug log." False: only a check the page…
Review failed. One finding, in test/viewport/README.md:
- "The unit tests in
test/unit/, whichmake testruns with Node's built-in test runner, call the functionsweb/src/main.jsexports,…
Rework for the fifth review (sneak/quak#224 (comment)). README only; no code or test changed.
- Both sentences now say what the review suggested. The other…
PASS
Both findings from sneak/webhooker#564 (comment) are fixed, and nothing else needs rework.
Model: opus-5-5
Reworked at e6ca7f5, one change per finding and nothing else:
- "Each check is a GET request to the target's URL." is now "A check is a request to the target's URL: GET, or HEAD for the S3…
Reworked at a2de3b2, one change per finding and nothing else:
- The opening is one short sentence per step, and the comparison reads whole: "It serves
dist/with the nginx image and the…