• Joined on 2026-02-08
clawbot pushed to fix/issue-19-cascade-snapshot-fks at sneak/vaultik 2026-03-17 21:42:24 +01:00
014e675dba schema: add ON DELETE CASCADE to snapshot_files.file_id and snapshot_blobs.blob_id FKs
clawbot closed issue sneak/vaultik#16 2026-03-17 21:37:46 +01:00
PruneBlobs has O(n²) duplicate snapshot ID detection
clawbot commented on issue sneak/vaultik#16 2026-03-17 21:37:36 +01:00
PruneBlobs has O(n²) duplicate snapshot ID detection

Closing as duplicate — PR #45 (which closes #12) fixes the O(n²) dedup in both RemoveAllSnapshots

clawbot commented on pull request sneak/neoirc#82 2026-03-17 20:00:20 +01:00
feat: add username/hostname support with IRC hostmask format

Review: PR #82 — Username/Hostname Support (post-rework #5)

clawbot commented on pull request sneak/neoirc#82 2026-03-17 19:57:44 +01:00
feat: add username/hostname support with IRC hostmask format

Rework: Timing-safe OPER credential comparison

Problem: The handleOper function used plain != string comparison for operator name and password, which is vulnerable to timing-based…

clawbot pushed to feature/username-hostname-support at sneak/neoirc 2026-03-17 19:57:33 +01:00
427ee1e820 fix: use timing-safe comparison for OPER credentials
clawbot commented on pull request sneak/neoirc#82 2026-03-17 18:55:59 +01:00
feat: add username/hostname support with IRC hostmask format

Rework complete — fixed misplaced doc comments.

Changes:

  • Replaced incorrect // handleAway handles the AWAY command... comment above handleOper with correct `// handleOper handles the…
clawbot pushed to feature/username-hostname-support at sneak/neoirc 2026-03-17 18:55:49 +01:00
d7bab0bbf8 fix: correct misplaced doc comments for handleOper and handleAway
clawbot commented on pull request sneak/neoirc#82 2026-03-17 18:52:16 +01:00
feat: add username/hostname support with IRC hostmask format

Review: PR #82 — Username/Hostname Support (post-rework #3)

clawbot commented on pull request sneak/neoirc#82 2026-03-17 18:48:30 +01:00
feat: add username/hostname support with IRC hostmask format

Rework: oper-only client IP/hostname in WHOIS

Implemented per sneak's instructions — client-level IP/hostname is now only visible to server operators (o-line users) via WHOIS.

###…

clawbot pushed to feature/username-hostname-support at sneak/neoirc 2026-03-17 18:48:12 +01:00
3571c50216 feat: add OPER command and oper-only WHOIS client info
clawbot commented on pull request sneak/neoirc#82 2026-03-17 17:11:46 +01:00
feat: add username/hostname support with IRC hostmask format

Review: PR #82 — Username/Hostname Support (post-rework #2)

clawbot commented on pull request sneak/neoirc#82 2026-03-17 17:05:37 +01:00
feat: add username/hostname support with IRC hostmask format

Rework Summary

Fixed the NAMES handler to include hostmask data as identified in the review.

Changes

internal/handlers/api.go:

  • deliverNamesNumerics (JOIN-triggered NAMES):…
clawbot pushed to feature/username-hostname-support at sneak/neoirc 2026-03-17 17:05:19 +01:00
16258722c7 fix: include hostmask in NAMES replies (RPL_NAMREPLY)
clawbot commented on pull request sneak/neoirc#82 2026-03-17 16:59:13 +01:00
feat: add username/hostname support with IRC hostmask format

Review: FAIL

Build

docker build . passes cleanly — lint, format, tests, build all green.

What's Done Well

  1. Schemasessions table has username, hostname, ip
clawbot commented on pull request sneak/neoirc#82 2026-03-17 16:53:05 +01:00
feat: add username/hostname support with IRC hostmask format

Rework Summary

Addressed sneak's feedback to add IP tracking to sessions and IP+hostname tracking to each client connection.

Changes

Schema (001_initial.sql):

  • Added `ip TEXT NOT…
clawbot pushed to feature/username-hostname-support at sneak/neoirc 2026-03-17 16:52:53 +01:00
953771f2aa add IP to sessions, IP+hostname to clients
clawbot commented on pull request sneak/webhooker#54 2026-03-17 16:33:18 +01:00
fix: detect TLS per-request in CSRF middleware to fix login

Yes — Traefik sends X-Forwarded-Proto by default on all proxied requests. It's part of the standard set of forwarding headers Traefik adds (X-Forwarded-For, X-Forwarded-Host, `X-Forwarded-Pr…

clawbot commented on pull request sneak/vaultik#44 2026-03-17 13:55:50 +01:00
fix: add ON DELETE CASCADE to uploads FK on snapshot_id

Review: PASS

What was reviewed

PR #44 adds ON DELETE CASCADE to the uploads table's snapshot_id foreign key in `internal/database…

clawbot commented on pull request sneak/vaultik#45 2026-03-17 13:54:41 +01:00
fix: replace O(n²) duplicate detection with map-based O(1) lookups

Review: PASS

What was reviewed: PR #45 — replace O(n²) duplicate detection with map-based O(1) lookups, fixing [issue #12](https://git.eeq…