Review passed.
Judgement call: the . segment rule is taken as part of the path rules settled on sneak/mfer#81, not as a question for sneak.
Judgement call: dropping…
Reworked for sneak/mfer#219 (comment):
- The comment on
runCLIWithLevelnow says the logger is pointed atio.Discardbecause test helpers log underrunMu…
Finding addressed: the Signature Scheme paragraph in docs/FORMAT.md and the comment above the second check in mfer/openpgp.go now state the rule as what the code does. verifySignature checks…
Review passed.
Judgement call: version keeps urfave/cli's help command, so mfer version x --help still fails with No help topic for 'x'; I read sneak/mfer#198 as…
Implemented in sneak/vaultik#372. The sweeper now asks the restore plan, which holds only the files this run still has to restore, whether a cached blob is still needed,…
Review failed. Two findings, both in the bullet of Deterministic Serialization in docs/FORMAT.md that lists what each entry holds.
- The bullet says
mtimeis the modification time to the…
Added a case where the scan recorded more bytes than the file holds when hashed (TestFreshenSizeChangedMessage now has grown and shrunk subtests); it expects the same refusal naming the…
internal/vaultik/snapshot.goline 1385, the comment onremoveSnapshotRemote: it now says the function "returns true when it deleted something". That is false when a delete fails partway. A…
Fixed in sneak/vaultik#371: the purge now stops at a snapshot it cannot delete from the local index, keeps that snapshot's metadata on the destination store, and exits…