Rework for sneak/AutistMask#671 (comment):
- Reworded as suggested.
- Reworded as suggested.
- Reworded as suggested.
Also rewrote 86 other sentences with…
PASS: the image request now holds only its source and transform, the /v1/image/ handler checks the allowlist and verifies the signature itself, the fetcher builds its own URL with every check it…
Third review of sneak/quak#228 (sneak/quak#219): FAIL, needs rework. Line numbers are README.md at 6d9852a.
Using the library
1.…
- The doc comments of
autoPhotoURLsandsignedPhotoURLnow calltestSigningKeythe key the handlers thatnewSignedHostServerbuilds check signatures with. - The
TestFixturescomments…
Recorded: sfdupes never enters a .zfs directory, even when one is given on the command line or lies below another operand. sneak/sfdupes#143 walks such an operand, so…
FAIL: needs rework
internal/handlers/format_auto_internal_test.golines 78–79 andinternal/handlers/request_id_internal_test.golines 20–21: both doc comments calltestSigningKey…
Review: FAIL (needs-rework)
src/popup/index.js, the comment over theonStorageChanged()listener ininit(): "A record this page's own save wrote matches this page." puts two verbs…
Nobody chose them for a single machine. The fleet picked them when the spec
was written, and you never ruled on them. The old spec (SPEC.md on main,
"Request rate limits" and "Byte limits")…
The doc comments of TestHandleImage_InvalidHost_Returns400 and TestHandleImage_HashInSourcePathOrQuery_Returns400 now give the reasons the comments in internal/imagerequest/urlparser.go…
The README and TODO.md rewrites (sneak/sfdupes#140, sneak/sfdupes#141) have each been through six reviews. The latest README findings are…