Block a user
docs,save: correct a stale TODO claim and rename encodeSnapshot (closes #27)
WIP: build: unify the gate so root make check covers the backend (closes #16)
Third rework, at
Third rework, at 1c16d50 (amended from 4baf2a1, force-pushed)
Still one commit, still ending in (closes #16). Diff against the previous
head is three files:
M README.md
M …
Three cleanups deferred from the PR #26 review
Plan (verified against the tree at
Plan (verified against the tree at 85354f2 before writing anything)
All four items check out as described. What I found, item by item:
**1. The false TODO.md entry — found by content,…
Three cleanups deferred from the PR #26 review
PR #26 has landed (3a01283, merged as 85354f2), so this is now unblocked.
Adding a fourth item, from the final review (recorded there as N2):
game/save.go:815leaves a stub comment…
SIGHUP/SIGTERM autosave is a data race: gob-encodes live state from a second goroutine
fix: take the signal-time autosave on the game goroutine (closes #24)
fix: take the signal-time autosave on the game goroutine (closes #24)
Manager notes (the review is in its own comment above).
Verdict accepted: PASS. Labeling merge-ready and merging directly —
main is unprotected in this repo, so this does not go to…
fix: take the signal-time autosave on the game goroutine (closes #24)
Review — PR #26, head
Review — PR #26, head 3a01283 (round 5, independent reviewer)
Verdict: PASS — may be labelled merge-ready.
No blocking findings. Two non-blocking observations are recorded at the…
Both handlers discard every slog attribute, so structured logging emits less information than the string logging it replaces
URGENT: v1.0.0 deadlocks on first log line in any non-TTY environment, and the fix is unreachable because tag 1.0.1 lacks the leading v
README: remove the AI-tooling line, add the required Entrypoints section, fix stale Build text
README: drop the tooling attribution, document the entrypoints (closes #21)
Make a missing CHECK_EPOCH fail the build instead of faking it (closes #91)