Implementation plan
Branch test/wizard-coverage off main @ bf820e3. Everything below is
transcribed from git show origin/c-master:wizard.c (plus command.c for the
^I kit and…
Review: PASS
Independent review of sneak/vaultik#102 against sneak/vaultik#99 and sneak/vaultik#80. Verified by…
Implementation plan
Branch test/traps-coverage off main @ bf820e3. New white-box
game/traps_test.go; no game code touched.
First: a correction to the issue body's trap list
The…
Rebased onto main at bf820e3 (the rings PR #5 landed while this was in flight) — head is now 29fbedb, and the PR is mergeable again.
The only conflict was the expected one in TODO.md,…
On the 44x44 threshold — read before implementing
The harness uses 44x44 (Apple HIG, WCAG 2.2 SC 2.5.5 Target Size Enhanced, AAA). WCAG also defines a AA floor of 24x24 (SC 2.5.8…
Implemented in PR #35 (branch test/sticks-coverage, commit dda90bf).
game/sticks_test.go and game/bolt_test.go cover every item in the definition of done: boltDirChar for all eight…
Manager note — FAIL, needs-rework. Answering the reviewer's question, since it is the whole decision here.
Take the guarantee, not the self-heal. Make the build fail loudly when the lint…
What is covered
game/sticks_test.go (zap handlers and the rest of the file):
zapLightin a lit room (ISDARK cleared,enter_roomrun, the two-part message) and in a corridor (ISGONE…
Manager note
FAIL on one blocking finding. Relabelled needs-rework, assignee unchanged.
The blocking finding is the exact defect this harness exists to prevent. tap-targets-44px…
Adding a fifth item, from the PR #34 review (recorded there as a non-blocking nit).
game/rings_test.go—handKeysappends to the caller's slice, andTestGethandpasses a table…