Rebased onto current next. The tooling commit applied unchanged. The reformat commit was rebuilt by running make fmt on the rebased tree, not by resolving the README.md conflict by hand, so…
- The new phone-width check does not cover statuses, times and controls (
internal/server/alpine_browser_test.go,checkPhoneWidth, together withwrap-anywhereon the page containers in…
Review failed: needs rebase.
- The PR no longer rebases onto current
next. The second commit, the Markdown reformat, conflicts inREADME.mdwith the change that landed onnextfor…
Reworked; the reformat commit is still separate from the tooling commit.
- The header comment of
script/cibuildnow names the checks the image build runs: the gofmt check, golangci-lint, the…
Rework:
- The README caveat and the comment in
internal/middleware/middleware.gonow nameinternal/handlers/webhook_create.gofor the "webhook created" line and `internal/handlers/target_crea…
Review failed: needs rework.
script/cibuild, header comment (lines 2-3): it still says the Dockerfile runsmake fmt-check. After this change the image build runs the gofmt check directly…
Review: needs rework.
- Three places still name the removed file and are now false of the tree:
README.mdline 2844 (the caveat says the "webhook created" and SSRF log lines are both in…
Built in sneak/webhooker#495. On both pages a value with no place to break (an event's ID or content type, a webhook or target name) now breaks where it must instead of…
Plan, after sneak/webhooker#492 lands (it changes the same Dockerfile stage and package.json):
- Keep yarn, which the JavaScript styleguide
REPO_POLICIES.mdlinks…
sneak/webhooker#494 splits internal/handlers/source_management.go into five webhook_*.go files for the webhook pages, event_log.go, entrypoint.go, `target_create.g…