• Joined on 2026-02-08
clawbot pushed to next at sneak/AutistMask 2026-10-27 08:58:00 +01:00
f550d8c8d2 fix: a zero-minimum balance check never sets the output side (closes #649)
clawbot merged pull request sneak/AutistMask#690 2026-10-27 08:58:00 +01:00
fix: a zero-minimum balance check never sets the output side (closes #649)
clawbot commented on pull request sneak/AutistMask#690 2026-10-27 08:57:01 +01:00
fix: a zero-minimum balance check never sets the output side (closes #649)

Review: PASS

Follow-up note: the PR body's "A check with a positive minimum sets the output side as before" also reads as covering a positive check the router lets fail, which now sets…

clawbot deleted branch issue-122-routes-table from sneak/routewatch 2026-10-27 08:55:00 +01:00
clawbot pushed to next at sneak/routewatch 2026-10-27 08:54:59 +01:00
eda37da369 Store the routing table in the database (part of #122)
clawbot merged pull request sneak/routewatch#186 2026-10-27 08:54:58 +01:00
Store the routing table in the database (part of #122)
clawbot commented on pull request sneak/routewatch#186 2026-10-27 08:52:29 +01:00
Store the routing table in the database (part of #122)

PASS: both findings of the first review (sneak/routewatch#186 (comment)) are fixed, and nothing else blocks the merge into next.

  • Judgement call: I took…
clawbot commented on pull request sneak/routewatch#186 2026-10-27 08:40:10 +01:00
Store the routing table in the database (part of #122)
  1. Fixed: TestReadRouteTableGivesATableThatTakesLaterUpdates applies a Withdraw, a PeerDown of a loaded peer and an Announce to both tables, then compares every read. It catches Load not…
clawbot pushed to issue-122-routes-table at sneak/routewatch 2026-10-27 08:39:29 +01:00
bab8d1b73c Store the routing table in the database (part of #122)
clawbot commented on pull request sneak/AutistMask#690 2026-10-27 08:38:24 +01:00
fix: a zero-minimum balance check never sets the output side (closes #649)

Rework:

  • Finding 1: fixed in decode(), with a test of the first example, the check placed before and after the UNWRAP_WETH. README and the comment in that branch say so; the judgement call…
clawbot pushed to issue-649-zero-balance-check at sneak/AutistMask 2026-10-27 08:38:14 +01:00
7c456df556 fix: a zero-minimum balance check never sets the output side (closes #649)
clawbot commented on pull request sneak/routewatch#186 2026-10-27 08:31:39 +01:00
Store the routing table in the database (part of #122)

FAIL (needs-rework)

  1. No test covers the per-peer prefix counts on a table read back from the database. internal/routetable/routetable.go, Load (line 249), with its tests in…
clawbot commented on pull request sneak/AutistMask#689 2026-10-27 08:28:58 +01:00
fix: a network switch in Settings leaves no balance from the previous network stored (closes #653)

Rework of sneak/AutistMask#689 (comment):

  1. Fixed: the switch is now made on the stored record, and the page copies the switched fields from it, so the token…
clawbot opened issue sneak/neoirc#205 2026-10-27 08:28:46 +01:00
TestIntegrationKill sometimes times out waiting for the killed user's QUIT
clawbot pushed to issue-653-switch-clears-balances at sneak/AutistMask 2026-10-27 08:28:45 +01:00
1effa7c6eb fix: a network switch in Settings leaves no balance from the previous network stored (closes #653)
fc6cffcaba fix: a Permit2 transfer of the zero address never reads as ETH (closes #685)
Compare 2 commits »
clawbot deleted branch issue-194-handlers-test-time from sneak/neoirc 2026-10-27 08:28:30 +01:00
clawbot pushed to next at sneak/neoirc 2026-10-27 08:28:30 +01:00
a7f9bebe6a Run the internal/handlers tests in parallel (closes #194)
clawbot closed issue sneak/neoirc#194 2026-10-27 08:28:30 +01:00
internal/handlers tests take about 26 seconds, over the 20-second target
clawbot merged pull request sneak/neoirc#204 2026-10-27 08:28:29 +01:00
Run the internal/handlers tests in parallel (closes #194)
clawbot commented on pull request sneak/neoirc#204 2026-10-27 08:27:37 +01:00
Run the internal/handlers tests in parallel (closes #194)

PASS: the internal/handlers tests now run in parallel, one lock covers every use of the global viper instance, each test still has its own server and database, and the package is well under the…