Block a user
Refuse fetch writes through a symlink in the destination (closes #86)
Reject invalid secret names before any command builds a path (closes #33)
MoveSecretnow checks both names before it selects a vault (the checks inmoveSecretCrossVaultmoved there); addedwork:.. work:xandwork:x work:..withdefaultcurrent, which the…
Refuse fetch writes through a symlink in the destination (closes #86)
Review passed.
- Judgement call: a hard link already sitting at the temp file's name and linked to a file outside the destination still gets that outside file overwritten, because the temp file…
Entrypoint acts as root on nothing outside /data (closes #80)
Review: FAIL (needs-rework)
backend/internal/reportbuf/datadir.goline 81:root.Chmod(rel, dirPerms)does not hold against a link swapped in during the start. Go's own documentation…
Wipe memguard buffers on every exit and restore echo (closes #35)
FAIL (needs-rework)
internal/cli/root.go, the function passed tomemguard.CatchSignal: it restores the terminal whenever the signal is SIGINT, on the assumption that SIGINT means…
Look up IP addresses by prefix at each mask length
Looking up an IPv6 address reads every IPv6 route, so it times out on a production-sized database
Go tests run with -race and -cover under Go's own timeout (closes #88)
Rework for sneak/netwatch#89 (comment):
- Rebased onto
next;TODO.mdkeeps both Completed Steps entries, this one on top. script/bootstrapinstalls…
Create new databases with auto_vacuum incremental (closes #43)
Vacuumininternal/database/database.gostill frees only one page per call. It runsPRAGMA incremental_vacuum(1000)withExecContext, which steps the statement once, and SQLite frees…
Lock the state directory and write vault files atomically (closes #34)
FAIL (needs-rework)
- Unlockers rewritten in place are not recorded (
internal/secret/pgpunlocker.go,keychainunlocker.go,seunlocker_darwin.go): PGP, keychain and Secure Enclave…
Each target's result shows as soon as its check ends, not when the round's slowest check ends
Built in sneak/netwatch#92: each check draws its own row as it ends, and the steps that need the whole round still run once, after its last check. One judgement call is…
Each target's row shows its result as soon as its check ends (closes #91)