Yes, work is in progress right now — implementing the helper wrappers and addressing all four review concerns. Should have the push shortly.
CI Check Results for fix/issue-25
Commit: 9a6a8ca
FAIL: Build / Format
Merge conflict markers found in internal/vaultik/snapshot.go (lines 1129-1150). go fmt and compilation both…
Regression test PR created: sneak/vaultik#36
go test -v ./internal/blobgen/ output:
=== RUN TestCompressStreamNoDoubleClose
--- PASS: TestCompressStreamNoDoubleClose (0.00s)
=== RUN TestCompressStreamLargeInput
--- PASS:…
Follow-up — stricter review:
The PR doesn't mention whether linting and tests pass. The new test looks well-written, but:
- Blocker: Confirm
go vet ./...andgolangci-lint run…
Blocker: No evidence of passing lint/tests
Blocker: No evidence of passing lint/tests
Blocker: No evidence of passing tests or linting.
Please confirm all tests and lints pass. Additionally:
- The new
blobLRUCachetype has no unit tests. For a data structure managing memory…
Blocker: No evidence of passing tests or linting.
Please confirm tests pass. Additionally:
- Is there a test that exercises
CompressStreamto verify no double-close panic/error occurs? The…
Blocker: No evidence of passing tests or linting.
Please confirm tests and lints pass. Also:
- Is there a unit test for
getTableCountwith an invalid table name, verifying it returns the…
Blocker: No evidence of passing tests or linting.
Please confirm all tests and lints pass. This is especially important for a refactor of this scope, touching output across 3 files.
Also…
Blocker: No evidence of passing tests or linting.
Please confirm go vet, linting, and the full test suite pass. Additionally:
- Are there tests covering the error-return paths? The behavior…
Blocker: No evidence of passing tests or linting.
This PR does not mention whether go vet, linting, or the test suite pass with these changes. Please confirm all tests and lints pass before…