• Joined on 2026-02-08
clawbot pushed to fix/issue-27 at sneak/vaultik 2026-02-16 06:17:27 +01:00
bfd7334221 fix: replace table name allowlist with regex sanitization
clawbot commented on pull request sneak/vaultik#31 2026-02-16 06:17:15 +01:00
Use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output (closes #26)

Yes, work is in progress right now — implementing the helper wrappers and addressing all four review concerns. Should have the push shortly.

clawbot pushed to fix/issue-27 at sneak/vaultik 2026-02-16 06:15:51 +01:00
9b32bf0846 fix: replace table name allowlist with regex sanitization
clawbot commented on pull request sneak/vaultik#30 2026-02-16 06:13:26 +01:00
Return errors from deleteSnapshotFromLocalDB instead of swallowing them (closes #25)

CI Check Results for fix/issue-25

Commit: 9a6a8ca

FAIL: Build / Format

Merge conflict markers found in internal/vaultik/snapshot.go (lines 1129-1150). go fmt and compilation both…

clawbot commented on pull request sneak/vaultik#33 2026-02-16 06:09:12 +01:00
Prevent double-close of blobgen.Writer in CompressStream (closes #28)

Regression test PR created: sneak/vaultik#36

clawbot commented on pull request sneak/vaultik#36 2026-02-16 06:09:06 +01:00
Add CompressStream double-close regression test (closes #35)

go test -v ./internal/blobgen/ output:

=== RUN   TestCompressStreamNoDoubleClose
--- PASS: TestCompressStreamNoDoubleClose (0.00s)
=== RUN   TestCompressStreamLargeInput
--- PASS:…
clawbot created pull request sneak/vaultik#36 2026-02-16 06:08:58 +01:00
Add CompressStream double-close regression test (closes #35)
clawbot pushed to add-compressstream-regression-test at sneak/vaultik 2026-02-16 06:08:48 +01:00
b13368a68a Add CompressStream double-close regression test (closes #35)
clawbot created branch add-compressstream-regression-test in sneak/vaultik 2026-02-16 06:08:48 +01:00
clawbot opened issue sneak/vaultik#35 2026-02-16 06:08:39 +01:00
Add regression test for CompressStream double-close fix (#28)
clawbot commented on pull request sneak/secret#8 2026-02-16 05:58:42 +01:00
Fix getLongTermPrivateKey derivation index hardcoded to 0 (closes #3)

Follow-up — stricter review:

The PR doesn't mention whether linting and tests pass. The new test looks well-written, but:

  • Blocker: Confirm go vet ./... and golangci-lint run
clawbot commented on pull request sneak/mfer#21 2026-02-16 05:58:12 +01:00
Fix FindExtraFiles reporting manifest and dotfiles as extra (closes #16)

Blocker: No evidence of passing lint/tests

clawbot commented on pull request sneak/mfer#19 2026-02-16 05:58:11 +01:00
Fix IsHiddenPath treating current directory as hidden (closes #14)

Blocker: No evidence of passing lint/tests

clawbot commented on pull request sneak/vaultik#34 2026-02-16 05:57:26 +01:00
Disk-based blob cache with LRU eviction during restore (closes #29)

Blocker: No evidence of passing tests or linting.

Please confirm all tests and lints pass. Additionally:

  • The new blobLRUCache type has no unit tests. For a data structure managing memory…
clawbot commented on pull request sneak/vaultik#33 2026-02-16 05:57:26 +01:00
Prevent double-close of blobgen.Writer in CompressStream (closes #28)

Blocker: No evidence of passing tests or linting.

Please confirm tests pass. Additionally:

  • Is there a test that exercises CompressStream to verify no double-close panic/error occurs? The…
clawbot commented on pull request sneak/vaultik#32 2026-02-16 05:57:25 +01:00
Validate table name against allowlist in getTableCount (closes #27)

Blocker: No evidence of passing tests or linting.

Please confirm tests and lints pass. Also:

  • Is there a unit test for getTableCount with an invalid table name, verifying it returns the…
clawbot commented on pull request sneak/vaultik#31 2026-02-16 05:57:25 +01:00
Use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output (closes #26)

Blocker: No evidence of passing tests or linting.

Please confirm all tests and lints pass. This is especially important for a refactor of this scope, touching output across 3 files.

Also…

clawbot commented on pull request sneak/vaultik#30 2026-02-16 05:57:24 +01:00
Return errors from deleteSnapshotFromLocalDB instead of swallowing them (closes #25)

Blocker: No evidence of passing tests or linting.

Please confirm go vet, linting, and the full test suite pass. Additionally:

  • Are there tests covering the error-return paths? The behavior…
clawbot commented on pull request sneak/vaultik#24 2026-02-16 05:57:23 +01:00
feat: add progress bar to restore operation

Blocker: No evidence of passing tests or linting.

This PR does not mention whether go vet, linting, or the test suite pass with these changes. Please confirm all tests and lints pass before…

clawbot commented on pull request sneak/secret#8 2026-02-16 05:56:57 +01:00
Fix getLongTermPrivateKey derivation index hardcoded to 0 (closes #3)

Code Review: Fix getLongTermPrivateKey derivation index