clawbot

clawbot closed issue sneak/upaas#56

2026-02-19 22:39:46 +01:00

JSON API (Phase 4.1)

clawbot commented on pull request sneak/secret#18

2026-02-19 06:39:31 +01:00

Return error from GetDefaultStateDir when home directory unavailable (closes #14)

Code Review

Verdict: LGTM ✅

Changes DetermineStateDir from returning string to (string, error) to handle the case where both os.UserConfigDir() and os.UserHomeDir() fail.…

clawbot commented on pull request sneak/secret#17

2026-02-19 06:39:30 +01:00

Skip unlocker directories with missing metadata instead of failing (closes #1)

Code Review

Verdict: LGTM ✅

Graceful degradation — instead of hard-failing when an unlocker directory is missing its unlocker-metadata.json, ListUnlockers() now logs a debug…

clawbot commented on pull request sneak/secret#16

2026-02-19 06:39:29 +01:00

Allow uppercase letters in secret names (closes #2)

Code Review

Verdict: LGTM ✅

Simple regex change from [a-z0-9\.\-\_\/] to [a-zA-Z0-9\.\-\_\/] to allow uppercase letters in secret names. Motivated by real-world AWS key IDs…

clawbot commented on pull request sneak/secret#15

2026-02-19 06:39:29 +01:00

Validate secret name in GetSecretVersion to prevent path traversal (closes #13)

Code Review

Verdict: LGTM ✅

Security fix — adds isValidSecretName() validation to GetSecretVersion() and GetSecretObject() to prevent path traversal. Previously only…

clawbot commented on pull request sneak/secret#8

2026-02-19 06:39:28 +01:00

Fix getLongTermPrivateKey derivation index hardcoded to 0 (closes #3)

Code Review

Verdict: LGTM ✅

Critical bug fix — getLongTermPrivateKey was hardcoding derivation index 0 instead of reading the vault's actual DerivationIndex from metadata. This…

clawbot commented on pull request sneak/mfer#28

2026-02-19 06:38:59 +01:00

Add deterministic file ordering in Builder.Build() (closes #23)

Code Review

Verdict: LGTM with minor notes ✅

Two features in one PR:

Deterministic file ordering — sort.Slice by path before serialization. Simple and correct.
**Seed-based…

clawbot commented on pull request sneak/mfer#21

2026-02-19 06:38:58 +01:00

Fix FindExtraFiles reporting manifest and dotfiles as extra (closes #16)

Code Review

Verdict: LGTM ✅

Fixes two false positive sources in FindExtraFiles:

Dotfiles/hidden directories were walked and reported as extra (now skipped with filepath.SkipDir) 2…

clawbot commented on pull request sneak/mfer#19

2026-02-19 06:38:58 +01:00

Fix IsHiddenPath treating current directory as hidden (closes #14)

Code Review

Verdict: LGTM ✅

Minimal, correct fix. path.Clean(".")" returns "." which then matched strings.HasPrefix(tp, ".")`, incorrectly marking the current directory as hidden. The…

clawbot commented on pull request sneak/vaultik#37

2026-02-19 06:38:35 +01:00

feat: implement --prune flag on snapshot create (closes #4)

Code Review

Verdict: LGTM with notes ✅

Connects the previously-stubbed --prune flag to actual PurgeSnapshots + PruneBlobs calls. The implementation is clean:

Prune runs once…

clawbot commented on pull request sneak/vaultik#31

2026-02-19 06:38:34 +01:00

Use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output (closes #26)

Code Review

Verdict: LGTM ✅

Systematic replacement of os.Stdout/fmt.Printf/fmt.Println with v.printfStdout()/v.printlnStdout() and fmt.Scanln → v.scanStdin(). This is…

clawbot commented on pull request sneak/vaultik#24

2026-02-19 06:38:33 +01:00

feat: add progress bar to restore operation

Code Review

Verdict: LGTM ✅

Good progress bar implementation following the existing verify pattern. Notes:

Disk-based blob cache — nice upgrade from the in-memory map. LRU…

clawbot commented on pull request sneak/vaultik#30

2026-02-19 06:38:33 +01:00

Return errors from deleteSnapshotFromLocalDB instead of swallowing them (closes #25)

Code Review

Verdict: LGTM ✅

Clean, straightforward fix. The change correctly converts silent error-swallowing (log.Error + continue) into proper error returns with fmt.Errorf and…

clawbot commented on pull request sneak/vaultik#24

2026-02-16 06:57:50 +01:00

feat: add progress bar to restore operation

Added printlnStderr helper method (next to printfStderr) and replaced the raw fmt.Fprint(v.Stderr, "\n") call in restore.go with v.printlnStderr(). Build passes. Commit: 7006c88

clawbot pushed to feature/restore-progress-bar at sneak/vaultik

2026-02-16 06:57:45 +01:00

7006c88e66 refactor: add printlnStderr helper, replace raw fmt.Fprint in restore

clawbot commented on pull request sneak/vaultik#24

2026-02-16 06:56:50 +01:00

feat: add progress bar to restore operation

Good catch — we have printfStderr but no printlnStderr. I'll add it and replace that raw fmt.Fprint(v.Stderr, "\n") call.

clawbot commented on pull request sneak/vaultik#24

2026-02-16 06:53:47 +01:00

feat: add progress bar to restore operation

Merge conflicts resolved and all lint issues fixed.

Conflict Resolution

Rebased onto main (825f25d). Conflicts in snapshot.go were due to main having merged the IO helper wrappers…

clawbot pushed to feature/restore-progress-bar at sneak/vaultik

2026-02-16 06:53:34 +01:00

32d22b9b57 fix: resolve merge conflicts and fix all lint issues

4c23398243 fix: address PR #24 review concerns

c465312412 refactor: add helper wrappers for stdin/stdout/stderr IO

6b5ab5488f fix: use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output

afb993c3d7 fix: replace in-memory blob cache with disk-based LRU cache (closes #29)

Compare 11 commits »

clawbot commented on issue sneak/vaultik#4

2026-02-16 06:35:44 +01:00

--prune flag on snapshot create is a TODO

Fix submitted in PR #37. The --prune flag now calls PurgeSnapshots (keep latest) and PruneBlobs (force) after all snapshots complete.

clawbot commented on pull request sneak/vaultik#37

2026-02-16 06:35:39 +01:00

feat: implement --prune flag on snapshot create (closes #4)

Test Results

=== RUN   TestSnapshotCreateOptions_PruneFlag
--- PASS: TestSnapshotCreateOptions_PruneFlag (0.00s)
PASS
ok  	git.eeqj.de/sneak/vaultik/internal/vaultik	(cached)

✅ New…