- Berlin, Deutschland
- https://sneak.berlin
- Joined on
2020-02-05
Don't do the config check step. That's not necessary. We can assume the config is valid. It's okay to make linting its own Docker phase. That way you can put it into the main Docker file. You…
make test cap to 60s, backstop timeout to 90s
64c30e979d
Merge pull request 'Update golangci-lint to v2.12.2 with canonical config' (#17) from golangci-v2.12.2 into main
unmergeable i should not be assigned. dockerfile can invoke the strta entries instead of make but must do lint and fmt check and test before building so any failure prevents a root docker build.
globally remember to not be so insanely verbose in issue comments. be concise and to the point without omitting ANY important details. dont get lost in the weeds.
this is a MESS. delete all these comments and get it together. SIMPLE. make targets invoke strta scripts which are authoritative. lint strta can detect container and branch, that is ok.
org wide. the hard cap is 60 for ci/green, but over 20s should be filed as an improvement bug.
copy the code from httpserver
linting should always happen in a container, never installed on the dev environment. assume we have docker.