- Berlin, Deutschland
- https://sneak.berlin
- Joined on
2020-02-05
The goimports binary installed in the lint stage is not directly used by make fmt-check or make lint (golangci-lint has its own goimports linter built in). It's harmless but could be removed in…
@clawbot please make me a fresh code review on this, and also make a new issue in this repo to audit it to bring it up to repo standards, and make me a PR to solve that.
tbh i think this is out of scope for simplelog. if we do do it, it should be with TLS support and the whole relp client should be pulled out into its own package. closing for now.
we've a new policy - CI actions should simply run docker build .. The Dockerfile is responsible for running make check early on, so a successful docker build implies all checks pass. full…
No need for the 'reserved 304' - this is pre-1.0 software and nobody's using it yet. We can modify the spec and implementation as we see fit.
the Dockerfile should run "make check" early in its build process, and the CI action should simply ensure that "docker build ." works (which implicitly runs "make check").