clawbot
bcdd4791ec
check / check (push) Waiting to run
In the event log and on an event's page, every attempt by a `database` or `log` target read "success Status: — (no response)". Those targets make no HTTP request, so there is no response to have, and "no response" reads like a failed connection, which is what it means for an `http` target. A successful `database` attempt now reads "archived" and a successful `log` attempt "written to the log", with no status shown; a failed one keeps "failure" and its error line, also with no status. `http` and `slack` attempts are unchanged. The change is in the one shared attempt template. Model: opus-5-5
90 lines
2.3 KiB
Go
90 lines
2.3 KiB
Go
package handlers_test
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"gorm.io/gorm/clause"
|
|
"sneak.berlin/go/webhooker/internal/database"
|
|
)
|
|
|
|
// TestDeliveryAttempts_ReadInTheTargetTypesOwnTerms proves, on the
|
|
// event's page and in the event log, that an http or slack attempt
|
|
// shows its status as before, while a database or log attempt, which
|
|
// sends no HTTP request, says what it did and shows no status.
|
|
func TestDeliveryAttempts_ReadInTheTargetTypesOwnTerms(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cases := []struct {
|
|
targetType database.TargetType
|
|
success bool
|
|
statusCode int
|
|
errText string
|
|
outcome string
|
|
status string // "" when the attempt must show no status
|
|
}{
|
|
{
|
|
database.TargetTypeHTTP, false, 0, "",
|
|
"failure", "Status: — (no response)",
|
|
},
|
|
{
|
|
database.TargetTypeSlack, true, http.StatusOK, "",
|
|
"success", "Status: 200",
|
|
},
|
|
{database.TargetTypeDatabase, true, 0, "", "archived", ""},
|
|
{
|
|
database.TargetTypeDatabase, false, 0,
|
|
"opening archive database: disk full", "failure", "",
|
|
},
|
|
{database.TargetTypeLog, true, 0, "", "written to the log", ""},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(string(tc.targetType), func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
f := newRecentEventsFixture(t)
|
|
target := seedTarget(t, f.db, f.webhook.ID, tc.targetType)
|
|
event := f.event(t, contentTypeJSON, "{}", time.Now())
|
|
dlv := f.delivery(
|
|
t, event, target.ID, database.DeliveryStatusDelivered,
|
|
)
|
|
|
|
require.NoError(t, f.webhookDB.Omit(clause.Associations).Create(
|
|
&database.DeliveryResult{
|
|
DeliveryID: dlv.ID,
|
|
AttemptNum: 1,
|
|
Success: tc.success,
|
|
StatusCode: tc.statusCode,
|
|
Error: tc.errText,
|
|
},
|
|
).Error)
|
|
|
|
w := serveEventPage(t, f.h, f.sess, f.webhook.ID, event.ID)
|
|
require.Equal(t, http.StatusOK, w.Code)
|
|
|
|
pages := []string{
|
|
w.Body.String(),
|
|
renderSourceLogsPage(t, f.h, f.sess, f.webhook.ID),
|
|
}
|
|
|
|
for _, page := range pages {
|
|
assert.Contains(t, page, ">"+tc.outcome+"</span>")
|
|
|
|
if tc.errText != "" {
|
|
assert.Contains(t, page, "Error: "+tc.errText)
|
|
}
|
|
|
|
if tc.status == "" {
|
|
assert.NotContains(t, page, "Status:")
|
|
} else {
|
|
assert.Contains(t, page, tc.status)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|