clawbot
8406c77949
check / check (push) Waiting to run
A target's settings move from the per-type JSON string in targets.config to columns: url, headers, timeout_seconds, forward_query, archive_expiry and archive_rotation. A column a type does not use stays empty. headers holds the header map as JSON text through GORM's JSON serializer, and archive_expiry holds a time.Duration, 0 meaning never. The forms check each setting once, with the same refusals and messages, and the edit form is filled from the columns, so the per-type config structs, their parsers and the "could not be read" branches are gone. A delivery task carries the six settings in place of the JSON string; tests check that each copy into a task, and back out of one, keeps all six. Model: opus-5-5
86 lines
2.3 KiB
Go
86 lines
2.3 KiB
Go
package delivery_test
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/netip"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/fx/fxtest"
|
|
"sneak.berlin/go/webhooker/internal/database"
|
|
"sneak.berlin/go/webhooker/internal/delivery"
|
|
"sneak.berlin/go/webhooker/internal/globals"
|
|
"sneak.berlin/go/webhooker/internal/logger"
|
|
"sneak.berlin/go/webhooker/internal/metrics"
|
|
)
|
|
|
|
// Both the http and the slack target send webhooker/ and the version
|
|
// in Globals, the value the web UI footer shows. A User-Agent
|
|
// configured on the target or carried in by the sender does not
|
|
// replace it.
|
|
func TestUserAgent_IsTheBuildVersion(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
const want = "webhooker/1.2.3-test"
|
|
|
|
userAgents := make(chan string, 1)
|
|
|
|
ts := httptest.NewServer(http.HandlerFunc(
|
|
func(w http.ResponseWriter, r *http.Request) {
|
|
userAgents <- r.Header.Get("User-Agent")
|
|
|
|
w.WriteHeader(http.StatusOK)
|
|
},
|
|
))
|
|
defer ts.Close()
|
|
|
|
g := &globals.Globals{Version: "1.2.3-test"}
|
|
lc := fxtest.NewLifecycle(t)
|
|
|
|
log, err := logger.New(lc, logger.LoggerParams{Globals: g})
|
|
require.NoError(t, err)
|
|
|
|
e := delivery.New(lc, delivery.EngineParams{
|
|
Globals: g,
|
|
Logger: log,
|
|
// httptest listens on loopback, which the default guard
|
|
// refuses.
|
|
SSRFGuard: delivery.NewTestGuard(
|
|
netip.MustParsePrefix("127.0.0.0/8"),
|
|
),
|
|
Metrics: metrics.New(prometheus.NewRegistry()),
|
|
})
|
|
|
|
statusCode, _, _, err := e.ExportDoHTTPRequest(
|
|
context.Background(),
|
|
&database.Target{
|
|
URL: ts.URL,
|
|
Headers: map[string]string{headerUserAgent: "configured/1"},
|
|
},
|
|
&database.Event{Headers: `{"User-Agent":["curl/8"]}`},
|
|
)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, statusCode)
|
|
require.Len(t, userAgents, 1, "the http target sent no request")
|
|
assert.Equal(t, want, <-userAgents, "http target")
|
|
|
|
db := testWebhookDB(t)
|
|
targetID := uuid.New().String()
|
|
|
|
event := seedEvent(t, db, `{"action":"test"}`)
|
|
dlv := seedDelivery(
|
|
t, db, event.ID, targetID, database.DeliveryStatusPending,
|
|
)
|
|
|
|
e.ExportDeliverSlack(context.Background(), db, buildSlackDelivery(
|
|
dlv, event, targetID, "test-slack", ts.URL,
|
|
))
|
|
require.Len(t, userAgents, 1, "the slack target sent no request")
|
|
assert.Equal(t, want, <-userAgents, "slack target")
|
|
}
|