All checks were successful
check / check (push) Successful in 8s
## Summary This PR brings the webhooker repo into full REPO_POLICIES compliance, addressing both [issue #1](#1) and [issue #2](#2). ## Changes ### New files - **`cmd/webhooker/main.go`** — The missing application entry point. Uses Uber fx to wire together all internal packages (config, database, logger, server, handlers, middleware, healthcheck, globals, session). Minimal glue code. - **`REPO_POLICIES.md`** — Fetched from authoritative source (`sneak/prompts`) - **`.editorconfig`** — Fetched from authoritative source - **`.dockerignore`** — Sensible Go project exclusions - **`.gitea/workflows/check.yml`** — CI workflow that runs `docker build .` on push to any branch (Gitea Actions format, actions/checkout pinned by sha256) - **`configs/config.yaml.example`** — Moved from root `config.yaml` ### Modified files - **`Makefile`** — Complete rewrite with all REPO_POLICIES required targets: `test`, `lint`, `fmt`, `fmt-check`, `check`, `build`, `hooks`, `docker`, `clean`, plus `dev`, `run`, `deps` - **`Dockerfile`** — Complete rewrite: - Builder: `golang:1.24` (Debian-based, pinned by `sha256:d2d2bc1c84f7...`). Debian needed because `gorm.io/driver/sqlite` pulls `mattn/go-sqlite3` (CGO) which fails on Alpine musl. - golangci-lint v1.64.8 installed from GitHub release archive with sha256 verification (v1.x because `.golangci.yml` uses v1 config format) - Runs `make check` (fmt-check + lint + test + build) as build step - Final stage: `alpine:3.21` (pinned by `sha256:c3f8e73fdb79...`) with non-root user, healthcheck, port 8080 - **`README.md`** — Rewritten with all required REPO_POLICIES sections: description line with name/purpose/category/license/author, Getting Started, Rationale, Design, TODO (integrated from TODO.md), License, Author - **`.gitignore`** — Fixed `webhooker` pattern to `/webhooker` (was blocking `cmd/webhooker/`), added `config.yaml` to prevent committing runtime config with secrets - **`static/static.go`** — Removed `vendor` from embed directive (directory was empty/missing) - **`internal/database/database_test.go`** — Fixed to use in-memory config via `afero.MemMapFs` instead of depending on `config.yaml` on disk. Test is now properly isolated. - **`go.mod`/`go.sum`** — `go mod tidy` ### Removed files - **`TODO.md`** — Content integrated into README.md TODO section - **`config.yaml`** — Moved to `configs/config.yaml.example` ## Verification - `docker build .` passes (lint ✅, test ✅, build ✅) - All existing tests pass with no modifications to assertions or test logic - `.golangci.yml` untouched closes #1 closes #2 Co-authored-by: clawbot <clawbot@noreply.git.eeqj.de> Reviewed-on: #6 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
147 lines
3.4 KiB
Go
147 lines
3.4 KiB
Go
package config_test
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/spf13/afero"
|
|
"sneak.berlin/go/webhooker/pkg/config"
|
|
)
|
|
|
|
// ExampleSetFs demonstrates how to use an in-memory filesystem for testing
|
|
func ExampleSetFs() {
|
|
// Create an in-memory filesystem
|
|
fs := afero.NewMemMapFs()
|
|
|
|
// Create a test configuration file
|
|
configYAML := `
|
|
environments:
|
|
test:
|
|
config:
|
|
baseURL: https://test.example.com
|
|
debugMode: true
|
|
secrets:
|
|
apiKey: test-key-12345
|
|
production:
|
|
config:
|
|
baseURL: https://api.example.com
|
|
debugMode: false
|
|
configDefaults:
|
|
appName: Test Application
|
|
timeout: 30
|
|
`
|
|
|
|
// Write the config to the in-memory filesystem
|
|
if err := afero.WriteFile(fs, "config.yaml", []byte(configYAML), 0644); err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
// Use the in-memory filesystem
|
|
config.SetFs(fs)
|
|
config.SetEnvironment("test")
|
|
|
|
// Now all config operations use the in-memory filesystem
|
|
fmt.Printf("Base URL: %s\n", config.GetString("baseURL"))
|
|
fmt.Printf("Debug Mode: %v\n", config.GetBool("debugMode"))
|
|
fmt.Printf("App Name: %s\n", config.GetString("appName"))
|
|
|
|
// Output:
|
|
// Base URL: https://test.example.com
|
|
// Debug Mode: true
|
|
// App Name: Test Application
|
|
}
|
|
|
|
// TestWithAferoFilesystem shows how to test with different filesystem implementations
|
|
func TestWithAferoFilesystem(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
setupFs func() afero.Fs
|
|
environment string
|
|
key string
|
|
expected string
|
|
}{
|
|
{
|
|
name: "in-memory filesystem",
|
|
setupFs: func() afero.Fs {
|
|
fs := afero.NewMemMapFs()
|
|
config := `
|
|
environments:
|
|
dev:
|
|
config:
|
|
apiURL: http://localhost:8080
|
|
`
|
|
afero.WriteFile(fs, "config.yaml", []byte(config), 0644)
|
|
return fs
|
|
},
|
|
environment: "dev",
|
|
key: "apiURL",
|
|
expected: "http://localhost:8080",
|
|
},
|
|
{
|
|
name: "readonly filesystem",
|
|
setupFs: func() afero.Fs {
|
|
memFs := afero.NewMemMapFs()
|
|
config := `
|
|
environments:
|
|
staging:
|
|
config:
|
|
apiURL: https://staging.example.com
|
|
`
|
|
afero.WriteFile(memFs, "config.yaml", []byte(config), 0644)
|
|
// Wrap in a read-only filesystem
|
|
return afero.NewReadOnlyFs(memFs)
|
|
},
|
|
environment: "staging",
|
|
key: "apiURL",
|
|
expected: "https://staging.example.com",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
// Create a new manager for each test to ensure isolation
|
|
manager := config.NewManager()
|
|
manager.SetFs(tt.setupFs())
|
|
manager.SetEnvironment(tt.environment)
|
|
|
|
result := manager.Get(tt.key, "")
|
|
if result != tt.expected {
|
|
t.Errorf("Expected %s, got %v", tt.expected, result)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestFileResolution shows how $FILE: resolution works with afero
|
|
func TestFileResolution(t *testing.T) {
|
|
// Create an in-memory filesystem
|
|
fs := afero.NewMemMapFs()
|
|
|
|
// Create a secret file
|
|
secretContent := "super-secret-api-key"
|
|
if err := afero.WriteFile(fs, "/secrets/api-key.txt", []byte(secretContent), 0600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create a config that references the file
|
|
configYAML := `
|
|
environments:
|
|
prod:
|
|
secrets:
|
|
apiKey: $FILE:/secrets/api-key.txt
|
|
`
|
|
if err := afero.WriteFile(fs, "config.yaml", []byte(configYAML), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Use the filesystem
|
|
config.SetFs(fs)
|
|
config.SetEnvironment("prod")
|
|
|
|
// Get the secret - it should resolve from the file
|
|
apiKey := config.GetSecretString("apiKey")
|
|
if apiKey != secretContent {
|
|
t.Errorf("Expected %s, got %s", secretContent, apiKey)
|
|
}
|
|
}
|