sneak
45d541526f
check / check (push) Successful in 2m52s
Re-align the json tag column in DeliveryResult after the wider DeliveryID gorm tag, and move the test's index table out of package scope into the test function. Model: opus-5-5
73 lines
2.1 KiB
Go
73 lines
2.1 KiB
Go
package database_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"sneak.berlin/go/webhooker/internal/database"
|
|
)
|
|
|
|
// indexedColumn names a secondary index by the model and struct field
|
|
// GORM derives the index name from.
|
|
type indexedColumn struct {
|
|
model any
|
|
field string
|
|
}
|
|
|
|
// TestWebhookDBManager_OpenAddsEventTierIndexes verifies that opening a
|
|
// per-webhook database that predates these indexes creates them, so the
|
|
// queries that read by those columns stop scanning whole tables. It
|
|
// stands in for an older database file by dropping the indexes
|
|
// AutoMigrate just created, then reopening the same file.
|
|
func TestWebhookDBManager_OpenAddsEventTierIndexes(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// The columns the background work reads by: the recovery and sweep
|
|
// queries (status), the event log (event_id and delivery_id) and
|
|
// retention (created_at).
|
|
eventTierIndexes := []indexedColumn{
|
|
{&database.Delivery{}, "Status"},
|
|
{&database.Delivery{}, "EventID"},
|
|
{&database.DeliveryResult{}, "DeliveryID"},
|
|
{&database.Event{}, "CreatedAt"},
|
|
}
|
|
|
|
mgr, lc := setupTestWebhookDBManager(t)
|
|
ctx := context.Background()
|
|
require.NoError(t, lc.Start(ctx))
|
|
|
|
defer func() { require.NoError(t, lc.Stop(ctx)) }()
|
|
|
|
webhookID := uuid.New().String()
|
|
|
|
db, err := mgr.GetDB(webhookID)
|
|
require.NoError(t, err)
|
|
|
|
// A fresh database has them.
|
|
for _, ix := range eventTierIndexes {
|
|
require.True(t, db.Migrator().HasIndex(ix.model, ix.field))
|
|
}
|
|
|
|
// Stand in for a database file created before the indexes existed.
|
|
for _, ix := range eventTierIndexes {
|
|
require.NoError(t, db.Migrator().DropIndex(ix.model, ix.field))
|
|
require.False(t, db.Migrator().HasIndex(ix.model, ix.field))
|
|
}
|
|
|
|
// Drop the cached connection so the next open reopens the file and
|
|
// runs AutoMigrate against it, as a restart would.
|
|
require.NoError(t, mgr.CloseAll())
|
|
|
|
db, err = mgr.GetDB(webhookID)
|
|
require.NoError(t, err)
|
|
|
|
for _, ix := range eventTierIndexes {
|
|
assert.True(t, db.Migrator().HasIndex(ix.model, ix.field),
|
|
"opening the existing database should create the index on %s",
|
|
ix.field)
|
|
}
|
|
}
|