All checks were successful
check / check (push) Successful in 1m50s
Split data storage into main application DB (config only) and
per-webhook event databases (one SQLite file per webhook).
Architecture changes:
- New WebhookDBManager component manages per-webhook DB lifecycle
(create, open, cache, delete) with lazy connection pooling via sync.Map
- Main DB (DBURL) stores only config: Users, Webhooks, Entrypoints,
Targets, APIKeys
- Per-webhook DBs (DATA_DIR) store Events, Deliveries, DeliveryResults
in files named events-{webhook_uuid}.db
- New DATA_DIR env var (default: ./data dev, /data/events prod)
Behavioral changes:
- Webhook creation creates per-webhook DB file
- Webhook deletion hard-deletes per-webhook DB file (config soft-deleted)
- Event ingestion writes to per-webhook DB, not main DB
- Delivery engine polls all per-webhook DBs for pending deliveries
- Database target type marks delivery as immediately successful (events
are already in the dedicated per-webhook DB)
- Event log UI reads from per-webhook DBs with targets from main DB
- Existing webhooks without DB files get them created lazily
Removed:
- ArchivedEvent model (was a half-measure, replaced by per-webhook DBs)
- Event/Delivery/DeliveryResult removed from main DB migrations
Added:
- Comprehensive tests for WebhookDBManager (create, delete, lazy
creation, delivery workflow, multiple webhooks, close all)
- Dockerfile creates /data/events directory
README updates:
- Per-webhook event databases documented as implemented (was Phase 2)
- DATA_DIR added to configuration table
- Docker instructions updated with data volume mount
- Data model diagram updated
- TODO updated (database separation moved to completed)
Closes #15
136 lines
3.0 KiB
Go
136 lines
3.0 KiB
Go
package handlers
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/fx"
|
|
"go.uber.org/fx/fxtest"
|
|
"sneak.berlin/go/webhooker/internal/config"
|
|
"sneak.berlin/go/webhooker/internal/database"
|
|
"sneak.berlin/go/webhooker/internal/globals"
|
|
"sneak.berlin/go/webhooker/internal/healthcheck"
|
|
"sneak.berlin/go/webhooker/internal/logger"
|
|
"sneak.berlin/go/webhooker/internal/session"
|
|
)
|
|
|
|
func TestHandleIndex(t *testing.T) {
|
|
var h *Handlers
|
|
|
|
app := fxtest.New(
|
|
t,
|
|
fx.Provide(
|
|
globals.New,
|
|
logger.New,
|
|
func() *config.Config {
|
|
return &config.Config{
|
|
// This is a base64 encoded 32-byte key: "test-session-key-32-bytes-long!!"
|
|
SessionKey: "dGVzdC1zZXNzaW9uLWtleS0zMi1ieXRlcy1sb25nISE=",
|
|
DataDir: t.TempDir(),
|
|
}
|
|
},
|
|
func() *database.Database {
|
|
// Mock database with a mock DB method
|
|
db := &database.Database{}
|
|
return db
|
|
},
|
|
database.NewWebhookDBManager,
|
|
healthcheck.New,
|
|
session.New,
|
|
New,
|
|
),
|
|
fx.Populate(&h),
|
|
)
|
|
app.RequireStart()
|
|
defer app.RequireStop()
|
|
|
|
// Since we can't test actual template rendering without templates,
|
|
// let's test that the handler is created and doesn't panic
|
|
handler := h.HandleIndex()
|
|
assert.NotNil(t, handler)
|
|
}
|
|
|
|
func TestRenderTemplate(t *testing.T) {
|
|
var h *Handlers
|
|
|
|
app := fxtest.New(
|
|
t,
|
|
fx.Provide(
|
|
globals.New,
|
|
logger.New,
|
|
func() *config.Config {
|
|
return &config.Config{
|
|
// This is a base64 encoded 32-byte key: "test-session-key-32-bytes-long!!"
|
|
SessionKey: "dGVzdC1zZXNzaW9uLWtleS0zMi1ieXRlcy1sb25nISE=",
|
|
DataDir: t.TempDir(),
|
|
}
|
|
},
|
|
func() *database.Database {
|
|
// Mock database
|
|
return &database.Database{}
|
|
},
|
|
database.NewWebhookDBManager,
|
|
healthcheck.New,
|
|
session.New,
|
|
New,
|
|
),
|
|
fx.Populate(&h),
|
|
)
|
|
app.RequireStart()
|
|
defer app.RequireStop()
|
|
|
|
t.Run("handles missing templates gracefully", func(t *testing.T) {
|
|
req := httptest.NewRequest(http.MethodGet, "/", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
data := map[string]interface{}{
|
|
"Version": "1.0.0",
|
|
}
|
|
|
|
// When a non-existent template name is requested, renderTemplate
|
|
// should return an internal server error
|
|
h.renderTemplate(w, req, "nonexistent.html", data)
|
|
|
|
// Should return internal server error when template is not found
|
|
assert.Equal(t, http.StatusInternalServerError, w.Code)
|
|
})
|
|
}
|
|
|
|
func TestFormatUptime(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
duration string
|
|
expected string
|
|
}{
|
|
{
|
|
name: "minutes only",
|
|
duration: "45m",
|
|
expected: "45m",
|
|
},
|
|
{
|
|
name: "hours and minutes",
|
|
duration: "2h30m",
|
|
expected: "2h 30m",
|
|
},
|
|
{
|
|
name: "days, hours and minutes",
|
|
duration: "25h45m",
|
|
expected: "1d 1h 45m",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
d, err := time.ParseDuration(tt.duration)
|
|
require.NoError(t, err)
|
|
|
|
result := formatUptime(d)
|
|
assert.Equal(t, tt.expected, result)
|
|
})
|
|
}
|
|
}
|