Templates should use go:embed instead of filesystem parsing at request time #7

New Issue

clawbot · 2026-03-01T19:07:26+01:00

clawbot commented

2026-03-01 19:07:26 +01:00

Per GO_HTTP_SERVER_CONVENTIONS §12, templates should be embedded using //go:embed and parsed once via template.Must(template.ParseFS(...)). Currently, internal/handlers/handlers.go calls template.ParseFiles() on every request in renderTemplate(), which:

Reads from the filesystem at request time (not embedded)
Re-parses templates on every request (performance cost)
Does not work correctly in Docker containers if the templates directory is not in the expected location relative to the working directory

The static/ package already correctly uses //go:embed. Templates should follow the same pattern:

// templates/templates.go
package templates

import (
    "embed"
    "text/template"
)

//go:embed *.html
var TemplatesRaw embed.FS
var TemplatesParsed *template.Template

func GetParsed() *template.Template {
    if TemplatesParsed == nil {
        TemplatesParsed = template.Must(template.ParseFS(TemplatesRaw, "*"))
    }
    return TemplatesParsed
}

Per GO_HTTP_SERVER_CONVENTIONS §12, templates should be embedded using `//go:embed` and parsed once via `template.Must(template.ParseFS(...))`. Currently, `internal/handlers/handlers.go` calls `template.ParseFiles()` on every request in `renderTemplate()`, which: 1. Reads from the filesystem at request time (not embedded) 2. Re-parses templates on every request (performance cost) 3. Does not work correctly in Docker containers if the templates directory is not in the expected location relative to the working directory The `static/` package already correctly uses `//go:embed`. Templates should follow the same pattern: ```go // templates/templates.go package templates import ( "embed" "text/template" ) //go:embed *.html var TemplatesRaw embed.FS var TemplatesParsed *template.Template func GetParsed() *template.Template { if TemplatesParsed == nil { TemplatesParsed = template.Must(template.ParseFS(TemplatesRaw, "*")) } return TemplatesParsed } ```

clawbot added the

bot

label 2026-03-01 19:07:26 +01:00

clawbot referenced this issue

2026-03-01 19:12:13 +01:00

docs: comprehensive README rewrite with complete service specification #13

clawbot referenced this issue

2026-03-02 00:38:37 +01:00

1.0/mvp #15

sneak referenced this issue from a commit

2026-03-02 00:43:56 +01:00

docs: comprehensive README rewrite with complete service specification (#13)