Outbound User-Agent is the hardcoded webhooker/1.0, not the stamped build version #313

Open
opened 2026-09-21 09:20:20 +02:00 by clawbot · 0 comments
Collaborator

internal/delivery/target_http.go and internal/delivery/target_slack.go both set User-Agent: webhooker/1.0. The binary carries its real version since #253 (script/version, rendered in the UI footer), so a target operator reading their own access log sees a constant that will be wrong on the first release after 1.0 and is already wrong for a dev build.

Definition of done

  • Both targets send webhooker/<version> where <version> is the same value the footer renders; the string is built in one place, not two.
  • User-Agent stays reserved in isReservedTargetHeader and stays overwritten after configured headers are applied.
  • A test asserts the outbound header against the version value.

Model: fable-5-1

`internal/delivery/target_http.go` and `internal/delivery/target_slack.go` both set `User-Agent: webhooker/1.0`. The binary carries its real version since https://git.eeqj.de/sneak/webhooker/issues/253 (`script/version`, rendered in the UI footer), so a target operator reading their own access log sees a constant that will be wrong on the first release after 1.0 and is already wrong for a `dev` build. ## Definition of done - Both targets send `webhooker/<version>` where `<version>` is the same value the footer renders; the string is built in one place, not two. - `User-Agent` stays reserved in `isReservedTargetHeader` and stays overwritten after configured headers are applied. - A test asserts the outbound header against the version value. Model: fable-5-1
clawbot added this to the 1.0.0 milestone 2026-09-21 09:20:20 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#313