CI gate follow-ups: script/cibuild has drifted from the model script, and the status-rewrite context string is hardcoded #147
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Two non-blocking findings from the independent review of #138. Not milestoned 1.0.0 — neither affects whether the gate works today.
1.
script/cibuildis not byte-identical to the model scriptREPO_POLICIES.mdrequires thescript/entrypoints stay byte-identical across repos, sourced fromhttps://git.eeqj.de/sneak/prompts/raw/branch/main/script/cibuild. This repo's copy has a different header comment:against the model's:
The executable body is identical, so behaviour is unaffected. The drift is pre-existing on
nextand #138 did not introduce it — but it is what made that PR's own compliance claim inaccurate, and it is exactly the kind of divergence that gets silently overwritten on the next re-sync fromprompts.Worth deciding which direction to reconcile: the local comment is arguably more informative, in which case the MODEL should be updated in
sneak/promptsand every repo re-synced, rather than this repo being reverted.Done when
diffbetween this repo'sscript/cibuildand the model is empty — whichever side moved.2. The status-rewrite step hardcodes its context string
.gitea/workflows/check.yml:32hardcodesctx='check / check (push)'. Renaming the workflow or the job silently stops the match, restoring the false-red bug from #119 with no signal that it has broken.Done when the context is derived (e.g. from
${GITHUB_WORKFLOW},${GITHUB_JOB}and${GITHUB_EVENT_NAME}) so a rename cannot silently disable it, or the step fails loudly when it matches nothing.Implementation requirements
next, PR based onnext, single commit, title ending(closes #N).sneak/promptsinstead of, or as well as, one here — say which in the PR body.TODO.md.make checkplus the Docker lint path with the cache defeated.