Escape the database path in the SQLite connection string (closes #518)

SQLite reads a file: URI's path only up to the first ? or #, and
decodes %XX escapes in it. With a data directory such as
/srv/hooks#1, every database opened the one file /srv/hooks. The
connection string is now built with url.URL, which escapes the path,
and OmitHost keeps a relative path relative.

Tests open databases in a directory whose name holds #, ? and %, and
at a relative path, and check through PRAGMA database_list that each
opened the file asked for. A handlers test comment that blamed # in
the temporary directory's path is dropped, as that is no longer true.

Model: opus-5-5

Dockerfile

@@ -76,6 +76,8 @@ RUN --network=none node_modules/.bin/prettier --check '**/*.md'
 # depends on it.
 #
 # golangci/golangci-lint:v2.14.0 (Debian-based), 2026-09-24
+# Using Debian-based image because mattn/go-sqlite3 (CGO) does not
+# compile on Alpine musl (off64_t is a glibc type).
 FROM golangci/golangci-lint:v2.14.0@sha256:ad862ba6b3798cbe0fd9fd7408d498fd74fbd2623a92406b2fd3898faf0bf98f AS lint
 
 WORKDIR /src
@@ -165,7 +167,9 @@ RUN --mount=type=tmpfs,target=/tmp/tests,size=512m \
 
 # Build stage
 # golang:1.26.1-bookworm (Debian-based), 2026-03-17
-# The image ships git and make, which the version step below uses.
+# Using Debian-based image because gorm.io/driver/sqlite pulls in
+# mattn/go-sqlite3 (CGO), which does not compile on Alpine musl. The image
+# ships git and make, which the version step below uses.
 FROM golang:1.26.1-bookworm@sha256:4465644228bc2857a954b092167e12aa59c006a3492282a6c820bf4755fd64a4 AS builder
 
 # Nothing is wanted from the lint and test phases or from the stylesheet and
@@ -207,11 +211,20 @@ RUN version="$(make version VERSION="$VERSION")"; \
     fi
 
 # Builds through the Makefile's build target, which runs script/assets
-# (Alpine.js, extracted from its tarball in 3p/) first. The target builds
+# (Alpine.js, extracted from its tarball in 3p/) first.
-# with cgo off, so the binary is statically linked and runs on the Alpine
-# runtime image below as it is.
 RUN make build VERSION="$VERSION"
 
+# Rebuild with static linking for Alpine runtime.
+# make build already verified compilation.
+# The CGO binary from `make build` is dynamically linked against glibc,
+# which doesn't exist on Alpine (musl). Rebuild with static linking so
+# the binary runs on Alpine without glibc.
+#
+# The static flags go in through GO_LDFLAGS rather than a -ldflags of
+# their own: the build target composes them with the -X that stamps the
+# version, so this relink cannot silently drop the stamp.
+RUN CGO_ENABLED=1 make build VERSION="$VERSION" GO_LDFLAGS='-extldflags "-static"'
+
 # Runtime stage
 # alpine:3.21, 2026-03-17
 FROM alpine:3.21@sha256:c3f8e73fdb79deaebaa2037150150191b9dcbfba68b4a46d70103204c53f4709
@@ -255,17 +268,8 @@ EXPOSE 8080
 # port.
 ENV BIND_ADDRESS=0.0.0.0
 
-# The probe requests the container's own address, not loopback, so a
-# listener that answers only on loopback (an empty or loopback
-# BIND_ADDRESS) fails it. On a network with IPv4, hostname -i prints the
-# container's IPv4 address, which 0.0.0.0 and :: both answer. On an
-# IPv6-only network it prints none, and the probe requests the IPv6
-# address /etc/hosts lists under the container's hostname instead, which
-# only :: answers.
 HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
-    CMD addr="$(hostname -i 2>/dev/null | cut -d ' ' -f 1)"; \
+    CMD wget --no-verbose --tries=1 --spider http://localhost:8080/.well-known/healthcheck || exit 1
-        [ -n "$addr" ] || addr="[$(getent hosts "$(hostname)" | cut -d ' ' -f 1)]"; \
-        wget --no-verbose --tries=1 --spider "http://$addr:8080/.well-known/healthcheck" || exit 1
 
 ENTRYPOINT ["/usr/local/bin/docker-entrypoint.sh"]
 CMD ["/app/webhooker"]

Makefile

@@ -16,6 +16,15 @@ VERSION ?= $(shell script/version)
 # exists to correct.
 override VERSION := $(or $(strip $(VERSION)),$(shell script/version))
 
+# Extra linker flags for the build target. The static relink in the
+# Dockerfile adds -extldflags here rather than passing its own -ldflags,
+# so composing flags cannot drop the version stamp.
+#
+# The build target itself always passes -trimpath and -s -w, as the Go
+# Dockerfile in REPO_POLICIES.md does: no build paths, symbol table or
+# debug information in the binary.
+GO_LDFLAGS ?=
+
 bootstrap:
 	@script/bootstrap
 
@@ -43,12 +52,8 @@ fmt-check:
 check:
 	@script/check
 
-# Built with cgo off, -trimpath and -s -w, as the Go Dockerfile in
-# REPO_POLICIES.md does: the binary carries no build paths, symbol table or
-# debug information, and on Linux, the image's included, it is statically
-# linked.
 build: assets
-	CGO_ENABLED=0 go build -trimpath -ldflags '-s -w -X main.version=$(VERSION)' -o bin/webhooker ./cmd/webhooker
+	go build -trimpath -ldflags '$(strip -s -w -X main.version=$(VERSION) $(GO_LDFLAGS))' -o bin/webhooker ./cmd/webhooker
 
 run: build
 	./bin/webhooker

README.md

@@ -310,17 +310,16 @@ the namespace, whatever the process bound. Exposure is decided at the publish
 flag instead — `-p 127.0.0.1:8080:8080` rather than `-p 8080:8080` — which is
 the operator's to choose and is what [Running with Docker](#running-with-docker)
 shows. A loopback bind inside a container buys nothing and makes the process
-unreachable through its own published port. A container on an IPv6-only Docker
+unreachable through its own published port.
-network has no IPv4 address for `0.0.0.0` to answer on, so there it needs
-`BIND_ADDRESS=::`.
 
 The value must be an IP address literal:
 
 - `127.0.0.1` — loopback only (the binary's default). Use this with a reverse
   proxy on the same host.
-- `0.0.0.0` — every IPv4 address and no IPv6 address. The image's default; on a
+- `0.0.0.0` — every IPv4 address. The image's default; on a bare host, only
-  bare host, only behind a firewall on the port.
+  behind a firewall on the port.
-- `::` — every IPv6 address and every IPv4 address.
+- `::` — every address, IPv6 and (on Linux, with the default
+  `net.ipv6.bindv6only=0`) IPv4 as well.
 - A specific address such as `10.0.0.5` — that interface only.
 
 An **empty** value is treated as unset, as everywhere else here, and takes the
@@ -341,8 +340,7 @@ machine that has no such interface — is a valid literal, so it reaches the
 listener and fails there. The process logs the bind error and exits non-zero
 rather than staying up with nothing listening. The effective value is in the
 `bindAddress` field of the startup log line, which is the way to check what a
-running deployment actually bound. On a bare host, `ss -ltn` lists the socket
+running deployment actually bound.
-itself as `0.0.0.0:8080` for a `0.0.0.0` bind and as `*:8080` for `::`.
 
 #### Metrics credentials
 
@@ -670,9 +668,9 @@ Either set a literal or leave the variable out entirely.
 Overriding `BIND_ADDRESS` to a loopback address in a container — by that route
 or deliberately — makes the container unreachable from outside its namespace
 even with `-p`. The published port answers nothing, and the health check fails
-too: it requests the container's own address (its IPv4 address, or its IPv6
+too: it requests `http://localhost:8080`, `localhost` resolves to `::1` first,
-address on an IPv6-only network), where a loopback bind is not listening. The
+and a `127.0.0.1` bind is not listening there. The container then goes
-container then goes `unhealthy` about **65 seconds** after start — from
+`unhealthy` about **65 seconds** after start — from
 `HEALTHCHECK --start-period=5s --interval=30s --retries=3`, so failing probes at
 5s, 35s and 65s, and `unhealthy` on the third. (Docker's probe cadence during
 the start period has changed between versions; re-derive from those three values
@@ -728,8 +726,8 @@ the credentials.
       address (directly, or through anything that can rewrite source addresses,
       such as NAT or a published container port). The `remoteIP` field of the
       `http request` log line for a request that came through the proxy shows
-      that address; the health check's own lines show the container's own
+      that address; the health check's own lines show `::1`. See
-      address. See [Trusted proxies](#trusted-proxies).
+      [Trusted proxies](#trusted-proxies).
     - Leave `BIND_ADDRESS` and `DATA_DIR` unset: the image sets `BIND_ADDRESS`
       to `0.0.0.0`, and `DATA_DIR` defaults to `/var/lib/webhooker`.
     - Everything else is optional; see [Configuration](#configuration).
@@ -804,12 +802,7 @@ comes up, serves pages, and is broken in a way nothing reports.
    proxy's log names it regardless. nginx's default `combined` format already
    logs `$remote_addr`; do not replace it with one that drops the client
    address, and retain those logs as long as you would want to answer a question
-   about traffic. That log also records the full request path, so it holds the
+   about traffic.
-   entrypoint UUID of every event a sender posts. webhooker's own log does not,
-   apart from the line a `log` target writes. Protect the proxy's log as you
-   would the entrypoint URLs themselves: anyone who can read it can post events
-   to every entrypoint in it (see
-   [The entrypoint URL is the authentication secret](#the-entrypoint-url-is-the-authentication-secret)).
 
 ### nginx
 
@@ -835,9 +828,7 @@ server {
     client_max_body_size 1m;
 
     # $remote_addr is the client. webhooker's own log names it, as
-    # clientIP, only while TRUSTED_PROXIES covers this proxy. The
+    # clientIP, only while TRUSTED_PROXIES covers this proxy.
-    # request path in this log holds the entrypoint UUID, so protect
-    # the file like the entrypoint URL itself.
     access_log /var/log/nginx/webhooker.access.log combined;
 
     location / {
@@ -1169,16 +1160,7 @@ What that means for an operator:
 
 - **The URL is a capability, so treat it as a secret.** Keep it out of logs,
   ticket bodies, chat messages and screenshots. Anyone who reads it anywhere can
-  post events as that sender. Apart from a `log` target's line, webhooker's own
+  post events as that sender.
-  log lines never carry the UUID: they name a request to the receiver by the
-  route pattern `/h/{uuid}`, the `webhook request received` line names the
-  entrypoint by its `entrypoint_id`, and the access log keeps only the scheme
-  and host of a `Referer`. A `log` target writes the request's headers as
-  received, so a `Referer` naming the entrypoint URL appears in its line, as it
-  does when a sender has followed a redirect from `http://` to `https://`. The
-  reverse proxy's access log does carry the UUID, in the request path, so it
-  must be protected like the URL itself (see
-  [Deployment behind a reverse proxy](#deployment-behind-a-reverse-proxy)).
 - **Rotating means minting a new entrypoint, not changing a key.** There is no
   way to rotate the UUID in place. To retire one, delete the entrypoint (or
   deactivate it, which answers `410`) and create a new one, then point the
@@ -1253,37 +1235,34 @@ markup. The CSP build runs no expressions, so every Alpine directive in
 `static/js/app.js`: `x-data="collapsible"` and `@click="toggle"`, never
 `x-data="{ open: false }"` or `@click="open = !open"`.
 
-A browser test in `internal/server` loads the sign-in page, the webhook page,
+A browser test in `internal/server` loads the webhook page, its edit pages and
-its edit pages, the event log, the webhook list, the settings page, the profile
+the event log under the real policy and checks that: the add entrypoint form
-page and the `404` error page shown for a path that does not exist, under the
+stays hidden until Add is clicked; for every target type, the targets section's
-real policy and checks that: the add entrypoint form stays hidden until Add is
+Add shows only a choice of type with Next and Cancel, Next shows only that
-clicked; for every target type, the targets section's Add shows only a choice of
+type's fields (no url field for `database` or `log`), Cancel at either step
-type with Next and Cancel, Next shows only that type's fields (no url field for
+closes the form, and saving adds the target; a refused target comes back with
-`database` or `log`), Cancel at either step closes the form, and saving adds the
+its form open, the values entered and the reason, and after Cancel the next Add
-target; a refused target comes back with its form open, the values entered and
+starts with an empty form and no reason; a refused save on the target edit page
-the reason, and after Cancel the next Add starts with an empty form and no
+and on the webhook edit page comes back with the reason and every value entered;
-reason; a refused save on the target edit page and on the webhook edit page
+the Copy button beside an entrypoint URL reads "Copied" once clicked; an
-comes back with the reason and every value entered; the Copy button beside an
+entrypoint's Edit button shows its edit form in place of its description and
-entrypoint URL reads "Copied" once clicked; an entrypoint's Edit button shows
+hides until the form closes, Cancel hides the form and drops what was typed, as
-its edit form in place of its description and hides until the form closes,
+does leaving the page and going back to it, and Save changes the description; of
-Cancel hides the form and drops what was typed, as does leaving the page and
+the recent events on the webhook page only the newest starts expanded, each
-going back to it, and Save changes the description; of the recent events on the
+expands and collapses, and Open leads to the event's own page; of the events in
-webhook page only the newest starts expanded, each expands and collapses, and
+the event log only the newest starts expanded, and an event there expands and
-Open leads to the event's own page; of the events in the event log only the
+collapses when its row's caret or its ID is clicked, and from the keyboard, but
-newest starts expanded, and an event there expands and collapses when its row's
+not when its ID is selected with the mouse, and a delivery's attempts inside it
-caret or its ID is clicked, and from the keyboard, but not when its ID is
+expand and collapse; and at phone width the menu button opens and closes the
-selected with the mouse, and a delivery's attempts inside it expand and
+mobile menu, and neither the webhook page nor the event log, with a delivery's
-collapse; at phone width the menu button opens and closes the mobile menu, and
+attempts open, scrolls sideways or cuts anything off at the page's or a card's
-neither the webhook page nor the event log, with a delivery's attempts open,
+edge. It also fails if the browser reports a console warning or error, an
-scrolls sideways or cuts anything off at the page's or a card's edge; and a
+uncaught exception, or anything the policy refused. `make check` and the image
-target's Delete asks first, naming the target, sends nothing when the answer is
+build lint it but do not run it, and `make test` leaves it out (its file is
-no and deletes the target when it is yes. It also fails if the browser reports a
+built only with the `browser` build tag). Run it with `make test-browser` after
-console warning or error, an uncaught exception, or anything the policy refused.
+changing `templates/` or `static/js/`: that builds `Dockerfile.browser`, which
-`make check` and the image build lint it but do not run it, and `make test`
+runs the test in a digest-pinned headless browser image, so the host needs no
-leaves it out (its file is built only with the `browser` build tag). Run it with
+browser.
-`make test-browser` after changing `templates/` or `static/js/`: that builds
-`Dockerfile.browser`, which runs the test in a digest-pinned headless browser
-image, so the host needs no browser.
 
 The package's tarball is committed as `3p/alpinejs-csp-3.14.9.tgz`, byte for
 byte as the npm registry publishes it. It is a dependency, not this repo's build
@@ -1316,9 +1295,7 @@ and commit the regenerated file with the change. Tailwind takes classes only
 from the files that `input.css` names in its `@source` lines; a class written in
 any other file is not generated until that file is named there too. `make check`
 and the image build fail when the committed file differs from what `make css`
-generates. `static/css/style.css` is hand-written and is not generated. The
+generates. `static/css/style.css` is hand-written and is not generated.
-pages' Content-Security-Policy refuses inline styles, so a template styles an
-element with a class, never a `style` attribute.
 
 `make css` runs the Tailwind standalone CLI in Docker, at the version and sha256
 pinned in the Dockerfile's stylesheet stages; it is never installed on the host.
@@ -1340,22 +1317,20 @@ webhooker solves this by acting as a durable intermediary:
    nothing is lost if downstream targets are unavailable.
 
 2. **Guaranteed delivery** — Events are queued for delivery to each configured
-   target. Failed deliveries are retried with configurable backoff. Delivery
+   target. Failed deliveries are retried with configurable backoff. Every
-   attempts are logged with status codes, response bodies, and timing.
+   delivery attempt is logged with status codes, response bodies, and timing.
 
     **That guarantee is at-least-once, not exactly-once.** When a send reaches
     its target but the write recording that outcome fails, the delivery is
     deliberately left in a recoverable state rather than marked done — losing a
-    delivery is the worse failure — so the sweep picks it up about fifteen
+    delivery is the worse failure — so the pending sweep picks it up about
-    minutes later, or the next restart does, and the target receives a payload
+    fifteen minutes later, or the next restart does, and the target receives a
-    it already got. A send still in flight when the service stops is left the
+    payload it already got. webhooker adds no delivery identifier of its own to
-    same way: its attempt is not recorded, and the next start sends it again
+    an outbound request, so **make your receiver idempotent** against whatever
-    (see Shutdown). webhooker adds no delivery identifier of its own to an
+    the payload itself carries.
-    outbound request, so **make your receiver idempotent** against whatever the
-    payload itself carries.
 
 3. **Observability** — Full request/response logging for every webhook received
-   and for delivery attempts. Prometheus metrics expose volume, latency, and
+   and every delivery attempted. Prometheus metrics expose volume, latency, and
    error rates. The web UI provides real-time visibility into event flow.
 
 4. **Fan-out** — A single incoming webhook can be delivered to multiple targets
@@ -1393,10 +1368,10 @@ It uses:
   management
 - **[go-chi](https://github.com/go-chi/chi)** for HTTP routing
 - **[GORM](https://gorm.io)** for database access with
-  **[modernc.org/sqlite](https://pkg.go.dev/modernc.org/sqlite)**, which is pure
+  **[modernc.org/sqlite](https://pkg.go.dev/modernc.org/sqlite)** as the runtime
-  Go, as the SQLite driver. `gorm.io/driver/sqlite` also imports
+  SQLite driver. Note: `gorm.io/driver/sqlite` transitively depends on
-  `mattn/go-sqlite3`, whose stub for builds without cgo is linked into the
+  `mattn/go-sqlite3`, which requires CGO at build time (see [Docker](#docker)
-  binary but never used
+  section)
 - **[slog](https://pkg.go.dev/log/slog)** (stdlib) for structured logging with
   TTY detection (text for dev, JSON for prod)
 - **[gorilla/sessions](https://github.com/gorilla/sessions)** for encrypted
@@ -1519,35 +1494,47 @@ the rotation chosen below that (none, monthly, daily or hourly). Both are
 validated as on the add target form, and the webhook and its targets are created
 together or not at all.
 
-| Field            | Type    | Description                                   |
+| Field            | Type    | Description                                                 |
-| ---------------- | ------- | --------------------------------------------- |
+| ---------------- | ------- | ----------------------------------------------------------- |
-| `id`             | UUID    | Primary key                                   |
+| `id`             | UUID    | Primary key                                                 |
-| `user_id`        | UUID    | Foreign key → User                            |
+| `user_id`        | UUID    | Foreign key → User                                          |
-| `name`           | string  | Human-readable name                           |
+| `name`           | string  | Human-readable name                                         |
-| `description`    | string  | Optional description                          |
+| `description`    | string  | Optional description                                        |
-| `retention_days` | integer | Days to retain events; 0 means retain forever |
+| `retention_days` | integer | Days to retain events (default: 30; 0 means retain forever) |
 
 **Relations:** Belongs to User. Has many Entrypoints. Has many Targets.
 
 The `retention_days` field controls how long event data is kept in the webhook's
 dedicated database before automatic cleanup.
 
-The value is stored as entered. Setting `retention_days` to `0` means "retain
+Setting `retention_days` to `0` means "retain events forever". Because the
-events forever": the retention reaper skips the webhook entirely, and the web UI
+column carries a default of 30, a literal zero cannot survive an insert, so a
-displays its retention as "forever" rather than as a day count.
+zero is rewritten on save to a sentinel of `365 * 1000` days
+(`database.RetentionForeverDays`). The retention reaper recognises that sentinel
+and skips the webhook entirely, and the web UI displays such a webhook's
+retention as "forever" rather than as a day count.
 
-The new webhook and edit forms accept `0`, or a whole number of days from `1` up
+Submitted `retention_days` values therefore fall into three bands, not two:
-to `database.MaxFiniteRetentionDays` (106751 days, about 292 years). Anything
+
-else, a negative value or one above that cap included, is rejected with a 400. A
+- `1` up to `database.MaxFiniteRetentionDays` (106751 days, about 292 years) is
-blank field gives the default of 30 days (`database.DefaultRetentionDays`) on
+  accepted as a finite retention.
-the new webhook form, and leaves the stored value unchanged on the edit form.
+- Above that ceiling but below the retain-forever sentinel of 365000
+  (`database.RetentionForeverDays`) is rejected with a 400. This is the band the
+  cap exists for.
+- `0`, and `365000` or above, are accepted and mean retain forever, collapsing
+  to the sentinel — `0` in `Webhook.BeforeSave`, the large values in
+  `parseRetentionDays`. The large values are not out of range: the edit form
+  pre-fills the sentinel for a retain-forever webhook, so submitting that form
+  back unchanged has to keep meaning "forever".
+
+A negative value is in none of the three: `parseRetentionDays` rejects it with a
+400 before `BeforeSave` ever sees it.
 
 The cap is not arbitrary: the reaper computes its cutoff as a `time.Duration`,
 an int64 nanosecond count, and a longer period overflows it. An overflowed
 cutoff lands in the future, where it matches every row, so the sweep would
 delete every event the webhook has instead of none. The reaper also clamps the
-value it reads to the cap, and reads a negative value as forever, so no stored
+value it reads to the cap, so no stored value can trigger that either.
-value can trigger that either.
 
 #### Entrypoint
 
@@ -1579,34 +1566,31 @@ did not arrive on the URL and counts in neither.
 A delivery destination for events. Each target defines where and how events
 should be forwarded.
 
-| Field              | Type       | Description                                                                                                                                                                             |
+| Field         | Type       | Description                                                                                                                                                                                                                                                                                                                                                 |
-| ------------------ | ---------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| ------------- | ---------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `id`               | UUID       | Primary key                                                                                                                                                                             |
+| `id`          | UUID       | Primary key                                                                                                                                                                                                                                                                                                                                                 |
-| `webhook_id`       | UUID       | Foreign key → Webhook                                                                                                                                                                   |
+| `webhook_id`  | UUID       | Foreign key → Webhook                                                                                                                                                                                                                                                                                                                                       |
-| `name`             | string     | Human-readable name                                                                                                                                                                     |
+| `name`        | string     | Human-readable name                                                                                                                                                                                                                                                                                                                                         |
-| `type`             | TargetType | One of: `http`, `slack`, `database`, `log`                                                                                                                                              |
+| `type`        | TargetType | One of: `http`, `slack`, `database`, `log`                                                                                                                                                                                                                                                                                                                  |
-| `active`           | boolean    | Whether deliveries are enabled (default: true)                                                                                                                                          |
+| `active`      | boolean    | Whether deliveries are enabled (default: true)                                                                                                                                                                                                                                                                                                              |
-| `url`              | string     | Where an `http` or `slack` target sends each event. It is a credential: the target list shows only its scheme and host, and only the target edit form shows it whole                    |
+| `config`      | JSON text  | Type-specific configuration                                                                                                                                                                                                                                                                                                                                 |
-| `headers`          | JSON text  | An `http` target's extra request headers, a JSON object of name to value                                                                                                                |
+| `max_retries` | integer    | Total delivery attempts for `http` and `slack` targets, not retries on top of the first: 0 is a single fire-and-forget attempt with no retries and no circuit breaker, and a value of N makes N attempts in all, with exponential backoff and a per-target circuit breaker. Ignored by `database` and `log` targets. The web UI labels it Delivery attempts |
-| `timeout_seconds`  | integer    | An `http` target's per-request timeout; 0 uses the shared 30-second client timeout                                                                                                      |
-| `forward_query`    | boolean    | Whether an `http` target is sent the query string each event arrived with                                                                                                               |
-| `archive_expiry`   | integer    | How long a `database` target keeps each archived event, as a Go `time.Duration` (nanoseconds); 0 keeps them forever                                                                     |
-| `archive_rotation` | string     | How often a `database` target starts a new archive file: `none`, `monthly`, `daily` or `hourly`                                                                                         |
-| `max_attempts`     | integer    | How many times an `http` or `slack` target attempts each delivery in all: at least 1, and 1 by default. Ignored by `database` and `log` targets. The web UI labels it Delivery attempts |
 
 **Relations:** Belongs to Webhook. Has many Deliveries.
 
 **Target types:**
 
-- **`http`** — Forward the event as an HTTP POST to a configured URL. With
+- **`http`** — Forward the event as an HTTP POST to a configured URL.
-  `max_attempts` at 1 the target makes a single attempt; above 1 it retries a
+  `max_retries` is the total number of delivery attempts, not retries on top of
-  failed delivery with exponential backoff, up to that many attempts in all,
+  the first: when `max_retries` is 0 (the default), the target operates in
-  behind a per-target circuit breaker.
+  fire-and-forget mode, a single attempt with no retries and no circuit breaker;
+  a value of N makes up to N attempts in all, retrying failed deliveries with
+  exponential backoff and protecting them with a per-target circuit breaker.
 - **`slack`** — Post the event as a formatted message to a Slack-compatible
-  incoming webhook URL, its `url`. It is built on the same HTTP core as `http`
+  incoming webhook URL (`webhookUrl` in `config`). It is built on the same HTTP
-  and honours `max_attempts` identically, circuit breaker included. See the
+  core as `http` and honours `max_retries` identically, circuit breaker
-  Slack target section under "Per-Webhook Event Databases" for the message
+  included. See the Slack target section under "Per-Webhook Event Databases" for
-  format.
+  the message format.
 - **`database`** — Archive the full event as a row into the target's own archive
   database (`archive-{webhook_name}-{target_name}-{target_uuid}.db`) for
   long-term retention, with an optional creation-validated expiry (default: keep
@@ -1622,28 +1606,29 @@ should be forwarded.
 - **`log`** — Write the event to the application log (stdout). Useful for
   debugging.
 
-Each type uses only its own settings, and the ones it does not use stay empty:
+The `config` field stores type-specific configuration as JSON (e.g., destination
-`http` uses `url`, `headers`, `timeout_seconds` and `forward_query`; `slack`
+URL, custom headers, timeout settings).
-uses `url`; `database` uses `archive_expiry` and `archive_rotation`; `log` uses
-none. The add target form, the new webhook form and the target edit form check
-every setting before it is saved, and each setting is a column of its own, so
-nothing that reads a target parses its settings or has to handle one it cannot
-read.
 
-An `http` target POSTs the event to its `url`. Its `headers` are applied last,
+**`http` target configuration:**
-so they win over the event's own forwarded headers.
 
-`forward_query` is off by default, and the target URL is then sent exactly as
+| Key            | Type          | Description                                                                               |
+| -------------- | ------------- | ----------------------------------------------------------------------------------------- |
+| `url`          | string        | Destination the event is POSTed to                                                        |
+| `headers`      | object        | Extra request headers, applied last so they win over the event's own forwarded headers    |
+| `timeout`      | integer (sec) | Per-target request timeout; unset (or 0) uses the shared 30-second client timeout         |
+| `forwardQuery` | boolean       | Pass the query string each event arrived with on to the target; unset (or false) does not |
+
+`forwardQuery` is off by default, and the target URL is then sent exactly as
 configured. On, each delivery appends the event's query string to the target
 URL, joined with `&` when the URL already has a query string of its own; a
 replayed delivery and a resubmitted event's deliveries do the same. Both target
 forms offer it as "Pass the query string on to this target", and the target list
 shows it when it is on.
 
-`timeout_seconds` is capped at **300 seconds**, and the form rejects anything
+`timeout` is capped at **300 seconds**, and the form rejects anything above it
-above it rather than substituting the cap. A delivery attempt holds one of the
+rather than substituting the cap. A delivery attempt holds one of the bounded
-bounded pool's workers for its whole duration, so an unbounded timeout would let
+pool's workers for its whole duration, so an unbounded timeout would let a
-a single unresponsive destination stall the queue.
+single unresponsive destination stall the queue.
 
 `headers` rejects the names the delivery path or `net/http` writes regardless of
 what is configured: `Host`, `Content-Length`, `Transfer-Encoding`, `Connection`,
@@ -1717,7 +1702,7 @@ The event log and the event's own page show the query string with the rest of
 the request. The event log leaves out one larger than 32 KiB, as it does request
 headers, and links to the event's page, which shows it whole. The `database` and
 `log` targets carry it with the rest of the event. An `http` target receives it
-only when its `forward_query` setting is on.
+only when its `forwardQuery` setting is on.
 
 #### Delivery
 
@@ -1783,7 +1768,7 @@ is what bounds it.
 #### DeliveryResult
 
 The result of a single delivery attempt. Every attempt (including retries) is
-individually logged, except one cut off by a stop (see Shutdown).
+individually logged for full observability.
 
 | Field           | Type    | Description                               |
 | --------------- | ------- | ----------------------------------------- |
@@ -1869,15 +1854,15 @@ These indexes on the per-webhook event databases are created by
 `internal/db/migrations/events/001_schema.sql`, and declared in the model tags
 to match:
 
-| Table              | Columns                                                            | Serves                                                                                                                                                                                                                                                                                                                                                                             |
+| Table              | Columns                                                            | Serves                                                                                                                                                                                                                                                                                                                                                                                             |
-| ------------------ | ------------------------------------------------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| ------------------ | ------------------------------------------------------------------ | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `deliveries`       | `status`, `deleted_at`, `finished_at`, `target_id`                 | Delivery recovery at start and every 60 seconds and the queue-depth sampler every 30 seconds, which select deliveries by status, the webhook page's statistics and target list and the webhook list, which count each target's deliveries by status and when they finished, and the event log, which lists and counts the events with a failed delivery or one pending or retrying |
+| `deliveries`       | `status`, `deleted_at`, `finished_at`, `target_id`                 | Startup recovery, the retry and pending sweeps every 60 seconds and the queue-depth sampler every 30 seconds, which select deliveries by status, the webhook page's statistics and target list and the webhook list, which count each target's deliveries by status and when they finished, and the event log, which lists and counts the events with a failed delivery or one pending or retrying |
-| `deliveries`       | `event_id`, `deleted_at`                                           | The event log, which loads each event's deliveries, and retention, which counts and deletes the deliveries of expired events                                                                                                                                                                                                                                                       |
+| `deliveries`       | `event_id`, `deleted_at`                                           | The event log, which loads each event's deliveries, and retention, which counts and deletes the deliveries of expired events                                                                                                                                                                                                                                                                       |
-| `delivery_results` | `delivery_id`, `deleted_at`                                        | The event log, which loads the attempts of a page's deliveries, and retention, which deletes the attempts of expired events                                                                                                                                                                                                                                                        |
+| `delivery_results` | `delivery_id`, `deleted_at`                                        | The event log, which loads the attempts of a page's deliveries, and retention, which deletes the attempts of expired events                                                                                                                                                                                                                                                                        |
-| `events`           | `deleted_at`, `created_at`                                         | The webhook page's statistics, which count recent events                                                                                                                                                                                                                                                                                                                           |
+| `events`           | `deleted_at`, `created_at`                                         | The webhook page's statistics, which count recent events                                                                                                                                                                                                                                                                                                                                           |
-| `events`           | `resubmitted_from_id`, `deleted_at`                                | The event log, which counts the events resubmitted from each event on a page                                                                                                                                                                                                                                                                                                       |
+| `events`           | `resubmitted_from_id`, `deleted_at`                                | The event log, which counts the events resubmitted from each event on a page                                                                                                                                                                                                                                                                                                                       |
-| `events`           | `entrypoint_id`, `deleted_at`, `resubmitted_from_id`, `created_at` | The webhook page's entrypoint list, which counts the events that arrived on each entrypoint's URL within the retention period                                                                                                                                                                                                                                                      |
+| `events`           | `entrypoint_id`, `deleted_at`, `resubmitted_from_id`, `created_at` | The webhook page's entrypoint list, which counts the events that arrived on each entrypoint's URL within the retention period                                                                                                                                                                                                                                                                      |
-| `events`           | `created_at`                                                       | Retention, which selects expired events by age                                                                                                                                                                                                                                                                                                                                     |
+| `events`           | `created_at`                                                       | Retention, which selects expired events by age                                                                                                                                                                                                                                                                                                                                                     |
 
 GORM's soft delete adds `deleted_at IS NULL` to these queries; retention leaves
 it out. SQLite keeps no statistics on these tables, and without them it rates
@@ -1996,10 +1981,11 @@ target UUID keeps the file name unique. A webhook named `Orders (EU)` with a
 target named `Long-term archive` archives into
 `archive-orders-eu-long-term-archive-{target_uuid}.db`.
 
-A target's `archive_rotation` is `none`, the default, which keeps the one file,
+An optional `rotation` in the target's config JSON (e.g. `{"rotation":"daily"}`)
-or `monthly`, `daily` or `hourly`. A target that rotates writes each event to a
+is `none`, the default, which keeps the one file, or `monthly`, `daily` or
-file named for the period of the event's receive time, in UTC, put before the
+`hourly`. A target that rotates writes each event to a file named for the period
-`.db`: `archive-orders-eu-long-term-archive-{target_uuid}-2026-10.db` monthly,
+of the event's receive time, in UTC, put before the `.db`:
+`archive-orders-eu-long-term-archive-{target_uuid}-2026-10.db` monthly,
 `…-2026-10-01.db` daily and `…-2026-10-01-19.db` hourly. Each file holds exactly
 its period's events, and the first event of a new period starts the next file,
 so a finished period's file can be moved away like any archive. A changed
@@ -2034,11 +2020,12 @@ archiving without stopping the service; a moved or removed archive file is
 recreated automatically on the next write, from the SQL files in
 `internal/db/migrations/archive/`. A zero-length archive file is written to as a
 new archive: SQLite opens it as an empty database, so it holds nothing to lose.
-A target's `archive_expiry` is checked by the form that saves it — the default,
+An optional `expiry` in the target's config JSON (e.g. `{"expiry":"720h"}`) is
-`never` on the forms and 0 in the column, keeps rows forever — and rows older
+validated when the target is created — the default (unset or the literal
-than the expiry are pruned each time the archive is (re)opened. An archive write
+`never`) keeps rows forever — and rows older than the expiry are pruned each
-failure is never silent success: the delivery records a failed attempt with the
+time the archive is (re)opened. An archive write failure is never silent
-error and is marked failed.
+success: the delivery records a failed attempt with the error and is marked
+failed.
 
 Because reopens only happen on writes, an archive whose target has stopped
 receiving events would never be pruned. A background **archive sweeper** closes
@@ -2049,7 +2036,8 @@ traffic. The sweep never creates an archive — a target whose archive file does
 not yet exist is skipped, not initialised — it takes the same per-target lock
 the write path uses, so it can never interleave with a write, and it leaves the
 archive closed afterwards so the move-the-file-away workflow keeps working.
-Archives with the expiry `never` are not touched by the sweep at all.
+Archives with no expiry, or the expiry `never`, are not touched by the sweep at
+all.
 
 For a target with several files, the write path prunes only the file it writes
 to, and the sweep prunes every one of them, taking the target's lock for one
@@ -2101,15 +2089,15 @@ writes go on meanwhile, since under WAL a reader never blocks a writer. Until
 the open file is closed its `-wal` cannot be checkpointed past what the download
 reads, so a long download lets that `-wal` grow.
 
-Deleting a webhook releases its archives: its cached archive writers are dropped
+Deleting a webhook releases its archives: the delivery engine's cached archive
-and their file handles closed, so nothing lingers after the webhook is gone. The
+writers are dropped and their file handles closed, so nothing lingers after the
-archive **files themselves are deliberately left on disk**. Unlike the event
+webhook is gone. The archive **files themselves are deliberately left on disk**.
-database — per-webhook working storage that is hard-deleted with the webhook —
+Unlike the event database — per-webhook working storage that is hard-deleted
-an archive is long-term storage an operator may still want to keep or move away
+with the webhook — an archive is long-term storage an operator may still want to
-for offline retention, and destroying it as a side effect of deleting a webhook
+keep or move away for offline retention, and destroying it as a side effect of
-would be unrecoverable. Removing an `archive-….db` is the operator's call.
+deleting a webhook would be unrecoverable. Removing an `archive-….db` is the
-Deleting a `database` target releases its writer the same way, and for the same
+operator's call. Deleting a `database` target releases its writer the same way,
-reason leaves its file alone.
+and for the same reason leaves its file alone.
 
 The **Slack target type** sends webhook events as formatted messages to any
 Slack-compatible incoming webhook URL (works with Slack, Mattermost, and other
@@ -2117,11 +2105,14 @@ compatible services). Each message includes event metadata (HTTP method, content
 type, timestamp, body size) and the payload pretty-printed in a code block. JSON
 payloads are automatically formatted with indentation for readability; non-JSON
 payloads are shown as raw text. Large payloads are truncated to keep messages
-reasonable. The target's `url` is the Slack/Mattermost incoming webhook
+reasonable. Config stores `webhookUrl` — the Slack/Mattermost incoming webhook
-endpoint.
+endpoint. That is the JSON key; the error text for a missing one reads
+`webhook_url is required`, which is the message, not the key.
 
 The database uses the
-[modernc.org/sqlite](https://pkg.go.dev/modernc.org/sqlite) driver.
+[modernc.org/sqlite](https://pkg.go.dev/modernc.org/sqlite) driver at runtime,
+though CGO is required at build time due to the transitive `mattn/go-sqlite3`
+dependency from `gorm.io/driver/sqlite`.
 
 #### Schema
 
@@ -2153,8 +2144,12 @@ External Service
                      1. Look up Entrypoint by UUID — 404 if unknown,
                         410 if inactive
                      2. Read the body under the 1 MB cap
-                     3. Hand the full request, as an Event, to
+                     3. Capture full request as Event
-                        Engine.StoreEvent
+                     4. Create Delivery records for each active Target
+                     5. Build self-contained delivery.Task structs
+                        (target config + event data inline for
+                         bodies < 16 KiB)
+                     6. Notify Engine via channel (no DB read needed)
                                                 │
                                                 ▼
                                         ┌──────────────┐
@@ -2163,32 +2158,19 @@ External Service
                                         │  (worker     │
                                         │   pool)      │
                                         └──────┬───────┘
-                     4. Store the Event, a pending Delivery for each
-                        active Target, and the totals, in one
-                        transaction
-                     5. Build a delivery.Task for each Delivery
-                        (target settings + event data, the body
-                         inline when it is under 16 KiB)
-                     6. Queue the tasks on the delivery channel
                                                │
                               ┌── bounded worker pool (N workers) ──┐
                               ▼                ▼                    ▼
                        ┌────────────┐   ┌────────────┐      ┌────────────┐
                        │ HTTP Target│   │ HTTP Target│      │ Log Target │
-                       │max_attempts│   │max_attempts│      │ (stdout)   │
+                       │(max_retries│   │(max_retries│      │ (stdout)   │
-                       │   == 1,    │   │   > 1,     │      └────────────┘
+                       │   == 0)    │   │   > 0,     │      └────────────┘
-                       │ one attempt│   │ backoff +  │
+                       │ fire+forget│   │ backoff +  │
                        └────────────┘   │ circuit    │
-                                        │ breaker    │
+                                        │ breaker)   │
                                         └────────────┘
 ```
 
-A **Resubmit** stores its copy of an event through the same `Engine.StoreEvent`,
-and a **Replay** adds one delivery of a stored event through
-`Engine.CreateReplay`, which writes the delivery and its target's totals in one
-transaction and queues it. Those two methods are the only code that creates a
-delivery; the handlers read and check the request, then make the one call.
-
 ### Bounded Worker Pool
 
 The delivery engine uses a **fixed-size worker pool** (default: 10 workers) to
@@ -2198,9 +2180,8 @@ preventing goroutine explosions regardless of queue depth.
 **Architecture:**
 
 - **Channels as queues:** Two buffered channels serve as bounded queues: a
-  delivery channel (the tasks of newly stored deliveries and of the `pending`
+  delivery channel (new tasks from the webhook handler) and a retry channel
-  deliveries the recovery routine hands back) and a retry channel (tasks from
+  (tasks from backoff timers). Both are buffered to 10,000.
-  backoff timers). Both are buffered to 10,000.
 - **Fan-out via channel, not goroutines:** When an event arrives with multiple
   targets, each `delivery.Task` is sent to the delivery channel. Workers pick
   them up and process them — no goroutine-per-target.
@@ -2209,7 +2190,7 @@ preventing goroutine explosions regardless of queue depth.
   Workers are the ONLY goroutines doing actual HTTP delivery.
 - **Retry backpressure with DB fallback:** When a retry timer fires and the
   retry channel is full, the timer is dropped — the delivery stays in `retrying`
-  status in the database. The sweep (every 60s, see Recovery below) finds these
+  status in the database. A periodic sweep (every 60s) scans for these
   "orphaned" retries and re-queues them. No blocked goroutines, no unbounded
   timer chains.
 - **Bounded concurrency:** At most N deliveries (N = number of workers) are
@@ -2225,47 +2206,31 @@ This means:
   buffer rather than spawning more goroutines.
 - **Independent results** — each worker records its own delivery result in the
   per-webhook database without coordination.
-- **Graceful shutdown** — the stop hook cancels the workers' context. A worker
+- **Graceful shutdown** — cancel the context, workers finish their current task
-  may still take tasks already queued before it exits. An `http` or `slack`
+  and exit. The stop hook waits for the pool via `lifecycle.WaitForShutdown`,
-  request in flight is cut off, and one started after the cancel fails at once.
+  which bounds that wait by fx's stop timeout rather than blocking forever on a
-  Neither is recorded or counted in the metrics, and the next start sends the
+  wedged worker. On timeout it logs at `ERROR` and returns an error, and the
-  delivery again (see Shutdown). A `database` or `log` task runs as normal. The
+  goroutines that did not finish are still running — an unclean shutdown is
-  stop hook waits for the pool via `lifecycle.WaitForShutdown`, which bounds
+  reported rather than hidden.
-  that wait by fx's stop timeout rather than blocking forever on a wedged
-  worker. On timeout it logs at `ERROR` and returns an error, and the goroutines
-  that did not finish are still running — an unclean shutdown is reported rather
-  than hidden.
 
-**Recovery:** one routine finds the deliveries the engine is not working on and
+**Recovery paths:**
-hands them back. It runs once when the engine starts, and then every 60 seconds;
-that periodic run is the sweep. For every webhook it reads the `pending` and
-`retrying` deliveries. One that already has a successful attempt is marked
-`delivered` and not sent again. A `retrying` delivery gets a backoff timer for
-what is left of its backoff, and is queued at once if nothing is left. A
-`pending` delivery is queued on the delivery channel. A delivery the engine has
-queued, is attempting, or holds a backoff timer for is left alone, at start as
-on every sweep. This is what catches "orphaned" retries, whose in-memory timer
-was dropped because the retry channel was full, and deliveries a stop or a crash
-cut off: the database is the durable fallback that ensures no delivery is
-permanently lost, even under extreme backpressure.
 
-The run at start and the sweep differ in two ways:
+1. **Startup recovery:** When the engine starts, it scans all per-webhook
-
+   databases for `pending` and `retrying` deliveries. Pending deliveries are
-- At start every `pending` delivery is taken, however recent, so one a stop cut
+   sent to the delivery channel; retrying deliveries get backoff timers
-  off moments ago is sent again at once (see Shutdown). The sweep takes only
+   scheduled.
-  `pending` deliveries untouched for 15 minutes, at most 500 per webhook each
+2. **Periodic retry sweep (DB-mediated fallback):** Every 60 seconds the engine
-  time, so a delivery whose outcome the database will not record is sent again
+   scans for `retrying` deliveries whose backoff period has elapsed. This
-  every 15 minutes rather than every minute.
+   catches "orphaned" retries — ones whose in-memory timer was dropped because
-- At start every webhook's database is opened, so that a missing one is reported
+   the retry channel was full. The database is the durable fallback that ensures
-  then (see Per-Webhook Event Databases). The sweep skips a webhook whose
+   no retry is permanently lost, even under extreme backpressure.
-  database file is missing rather than create it.
 
 **Changing a target's type does not migrate in-flight deliveries.** Only `http`
 and `slack` targets own durable retries; `database` and `log` targets are
 fire-and-forget and never produce a `retrying` delivery. If a target's `type` is
 edited from a retrying type to a non-retrying (or unknown) one while one of its
-deliveries is still `retrying`, the recovery routine above terminally marks that
+deliveries is still `retrying`, both recovery paths above terminally mark that
-delivery `failed` and records a `DeliveryResult` naming the current target type
+delivery `failed` and record a `DeliveryResult` naming the current target type
 as the reason, logging it at warn level. The delivery is not re-dispatched under
 the new type — the operator never asked for that delivery — and the event itself
 remains stored in the per-webhook event database. Nothing is lost: the delivery
@@ -2275,11 +2240,11 @@ re-inject it to every currently active target.
 
 ### Circuit Breaker (HTTP and Slack Targets with Retries)
 
-`http` and `slack` targets with `max_attempts` > 1 are protected by a
+`http` and `slack` targets with `max_retries` > 0 are protected by a
 **per-target circuit breaker** that prevents hammering a down target with
 repeated failed delivery attempts. The circuit breaker is in-memory only and
-resets on restart (which is fine — the recovery routine rescans the database at
+resets on restart (which is fine — startup recovery rescans the database
-start anyway).
+anyway).
 
 **States:**
 
@@ -2316,10 +2281,10 @@ start anyway).
 - **Cooldown:** 30 seconds in open state before probing
 
 **Scope:** Circuit breakers apply to **`http` and `slack` targets with
-`max_attempts` > 1**. The Slack target is built on the same HTTP core and hands
+`max_retries` > 0**. The Slack target is built on the same HTTP core and hands
-its own `max_attempts` to the same retry path, so it gets a breaker with the
+its own `max_retries` to the same retry path, so it gets a breaker with the same
-same 5-failure / 30-second defaults. Single-attempt targets of either type
+5-failure / 30-second defaults. Fire-and-forget targets of either type
-(`max_attempts` == 1), database targets (local operations), and log targets
+(`max_retries` == 0), database targets (local operations), and log targets
 (stdout) do not use circuit breakers.
 
 When a circuit is open and a new delivery arrives, the engine marks the delivery
@@ -2352,7 +2317,7 @@ getting anywhere.
 | Metric                                 | Type      | Meaning                                                                                                                                                                                                                                                                                                   |
 | -------------------------------------- | --------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | `webhooker_events_received_total`      | counter   | Events received and durably stored. Compare against the delivery counters on one dashboard                                                                                                                                                                                                                |
-| `webhooker_delivery_attempts_total`    | counter   | Delivery attempts actually dispatched to a target. A delivery a circuit breaker refused is not one: it is counted as a retry instead, but only when the refusal moves it into `retrying`. An attempt cut off by a stop is not counted (see Shutdown)                                                      |
+| `webhooker_delivery_attempts_total`    | counter   | Delivery attempts actually dispatched to a target. A delivery a circuit breaker refused is not one: it is counted as a retry instead, but only when the refusal moves it into `retrying`                                                                                                                  |
 | `webhooker_deliveries_succeeded_total` | counter   | Deliveries that reached `delivered`                                                                                                                                                                                                                                                                       |
 | `webhooker_deliveries_failed_total`    | counter   | Deliveries that failed terminally and will not be retried                                                                                                                                                                                                                                                 |
 | `webhooker_delivery_retries_total`     | counter   | Deliveries put back into `retrying`                                                                                                                                                                                                                                                                       |
@@ -2451,32 +2416,27 @@ log volume it caps rather than eliminates. A path that names no entrypoint is
 recorded by the handler at `DEBUG`, and the aggregate limiter logs its own
 rejections at `DEBUG` and without the path, so neither appears at all under the
 default level. The per-entrypoint limiter is the loud one: it logs every
-rejection at `WARN`, naming the route pattern `/h/{uuid}` rather than the
+rejection at `WARN` with the request path, which on this route is
-request path. A client hammering a single invented path is served
+attacker-controlled text. A client hammering a single invented path is served
 `RECEIVER_RATE_LIMIT` requests and has the rest of its aggregate budget rejected
 there, so the aggregate limit is what bounds the _number_ of those `WARN` lines
 — to under ten times `RECEIVER_RATE_LIMIT` per minute per client IP, 1080 at the
-defaults, where before it there was no bound at all. The access log is bounded
+defaults, where before it there was no bound at all. Their _width_ is bounded by
-by neither limit: every request is recorded once at `INFO`, served or rejected
+the field budgets below, the same ones the access log spends. The access log is
-alike.
+bounded by neither limit: every request is recorded once at `INFO`, served or
+rejected alike.
 
-What the access log does bound is the _content_ of those lines. On the receiver
+What the access log does bound is the _content_ of those lines. A 3xx or 4xx
-route it logs the route pattern `/h/{uuid}` whatever the status, because the
+response logs the chi route pattern — `/h/{uuid}`, `/user/{username}//`, or the
-concrete path carries the entrypoint UUID, which is the entrypoint's credential
+literal `(unmatched)` when the request hit no route at all — in place of the
-(see
+concrete URL. Those are the outcomes an unauthenticated client can drive for
-[The entrypoint URL is the authentication secret](#the-entrypoint-url-is-the-authentication-secret)).
+free: 404 and 429 on any invented receiver path, a login redirect on any
-A request chi never routed, because it matched no route or because a middleware
+invented profile path. Logging the URL there would let a flood write text of its
-answered it first, logs the literal `(unmatched)` whatever the status. In the
+own choosing, at a length of its own choosing, into the log. 2xx and 5xx
-`dev` environment the CORS middleware answers a preflight that way, so a
+responses keep the concrete path — a success resolved against a static route or
-preflight to the receiver does not log its UUID either. On every other route, a
+against the operator's own data (on the receiver, against a stored entrypoint
-3xx or 4xx response logs the chi route pattern, such as `/user/{username}//`, in
+UUID), and a 5xx is a bug in this service, where the exact path is the evidence
-place of the concrete URL. Those are the outcomes an unauthenticated client can
+and no client can provoke one at will.
-drive for free: a 404 on any invented path, a login redirect on any invented
-profile path. Logging the URL there would let a flood write text of its own
-choosing, at a length of its own choosing, into the log. 2xx and 5xx responses
-keep the concrete path — a success resolved against a static route or against
-the operator's own data, and a 5xx is a bug in this service, where the exact
-path is the evidence and no client can provoke one at will.
 
 The query string is never logged; it is replaced by the fixed marker
 `?(redacted)`. It is client-chosen on every route, and
@@ -2488,11 +2448,6 @@ to, `notice`, which names the line a page shows after an action, and the event
 log's `show`, which picks the events it lists. A query string sent to an
 entrypoint is not lost either: the event stores it, and the event log shows it.
 
-The `referer` field keeps only the scheme and host of the request's `Referer`,
-and logs `(redacted)` for one without them, because its path can be an
-entrypoint URL: a sender that follows the `http://` to `https://` redirect in
-the nginx example sends the URL it was redirected from.
-
 Client-supplied request content does not leave the host by the other route
 either. The Sentry SDK attaches the request to every event it captures,
 independently of the access log, and `SendDefaultPII=false` does not cover all
@@ -2502,18 +2457,14 @@ are both taken unconditionally, the body precisely because these handlers call
 body with `(redacted)`, drops cookies and the remote-address environment, and
 reduces the headers to a fixed allowlist — `Accept`, `Content-Length`,
 `Content-Type`, `Host`, `Origin`, `Referer`, `User-Agent` and `X-Request-Id`.
-`Referer` is sent as its scheme and host only, because its path can be an
-entrypoint URL; `internal/referer.SchemeAndHost` does that reduction for both
-the access log's `referer` field and this hook.
 
 The same hook rewrites the request URL. The SDK builds it as
 `scheme://host/path` from the concrete path, which on the receiver route is
 `/h/<uuid>` in full — and that UUID is a write capability, not an identifier:
 anyone holding it can post events this service accepts and its targets then
-deliver. What is sent is the chi route pattern instead: `http://host/h/{uuid}`.
+deliver. A tracker has its own retention, access control and deletion policy, so
-A tracker has its own retention, access control and deletion policy, so the
+the rule the access log follows above does not carry across that boundary. What
-pattern is sent on every route, including the 2xx and 5xx responses outside the
+is sent is the chi route pattern instead: `http://host/h/{uuid}`.
-receiver for which the access log keeps the concrete path.
 
 The scheme and the host are kept, and everything else in the URL is discarded
 rather than edited, so a future SDK version that starts appending a query string
@@ -2575,9 +2526,8 @@ receiver route. What survives still names the failing route — scheme, host,
 route pattern, method — and `X-Request-Id` ties the event to the local access
 log line that holds the rest. Nothing dropped is needed for the likeliest use,
 debugging a CSRF rejection. Its three inputs are the TLS decision, `Origin` and
-`Referer`; the latter two are kept (`Referer` as its scheme and host, which is
+`Referer`; the latter two are kept, and the first is the scheme of the retained
-all the check compares), and the first is the scheme of the retained URL,
+URL, because the SDK derives that scheme from
-because the SDK derives that scheme from
 `r.TLS != nil || r.Header.Get("X-Forwarded-Proto") == "https"`. That predicate
 is the SDK's own and is stricter than `internal/reqtls.IsTLS`, which this
 service now uses everywhere it decides transport: the SDK reports `http` for the
@@ -2643,7 +2593,9 @@ than it:
 | ------------------------------------------ | ------- | ------------------- | ------------------------------------------ |
 | `request body exceeds limit` (413)         | `WARN`  | path, method        | yes — `MaxBodySize` precedes `RequireAuth` |
 | `csrf: token validation failed` (403)      | `WARN`  | path, method        | yes — `CSRF` precedes `RequireAuth`        |
+| `... rate limit exceeded` (429)            | `WARN`  | path                | yes, on the receiver                       |
 | `auth middleware: unauthenticated request` | `DEBUG` | path, method        | yes, by definition                         |
+| `entrypoint not found`                     | `DEBUG` | entrypoint UUID     | yes, on the receiver                       |
 | `user not found` / `invalid password`      | `DEBUG` | username            | yes, on the sign-in form                   |
 | `login failure limit exceeded` (429)       | `WARN`  | path                | yes, on the sign-in form                   |
 | `password verification capacity exhausted` | `WARN`  | path                | yes, on the sign-in form                   |
@@ -2671,12 +2623,13 @@ wider of the two handlers spends more on than the client spent sending them.
 Every case holds each line to the 2,560-byte ceiling. That per-line ceiling is
 what the figure above states, and every row establishes it.
 
-Two of the sites go further and bound the whole flood's output — the total bytes
+Three of the sites go further and bound the whole flood's output — the total
-a run of distinct invented values wrote, which is the shape an operator sizing
+bytes a run of distinct invented values wrote, which is the shape an operator
-storage cares about. They are `request body exceeds limit`
+sizing storage cares about. They are `request body exceeds limit`
-(`TestMaxBodySize_FloodOfOversizePathsDoesNotGrowTheLog`) and `user not found`
+(`TestMaxBodySize_FloodOfOversizePathsDoesNotGrowTheLog`),
-(through `assertBoundedFlood`). The other rows carry no aggregate assertion; the
+`entrypoint not found` and `user not found` (the last two through
-per-line ceiling is what they establish.
+`assertBoundedFlood`). The other rows carry no aggregate assertion; the per-line
+ceiling is what they establish.
 
 `internal/logfield/logfield_test.go` measures the per-rune charge against what
 the handlers really emit, over roughly 3,000 code points on each, so an
@@ -2694,7 +2647,7 @@ everything else, so its lines take the level the operator set and the handler
 `internal/logger` selected, and every value it emits is spent through the same
 `internal/logfield` budget. A record-not-found is not logged as an error: it is
 the expected outcome on both of those paths, and each handler already records
-its own miss at `DEBUG`, without the SQL and within the ceiling above. Slow
+its own miss at `DEBUG` — bounded, per the table above — without the SQL. Slow
 statements are kept, at `WARN`, above the same 200 ms threshold GORM used and
 with the statement bounded, because that report is the one thing GORM's logger
 gave an operator that nothing else here does. The adapter orders its cases
@@ -3019,12 +2972,6 @@ webhooker/
 ├── cmd/webhooker/
 │   └── main.go               # Entry point: subcommand dispatch; no args locks DATA_DIR and wires fx
 ├── internal/
-│   ├── archive/
-│   │   ├── archive.go         # The archive writer of each database target, eviction, rename, and the rename lock
-│   │   ├── writer.go          # Archive file lifecycle and pruning
-│   │   ├── rotation.go        # Archive rotation and file names
-│   │   ├── download.go        # Archive download as gzipped JSON
-│   │   └── sweeper.go         # Periodic pruning of idle archives
 │   ├── banner/
 │   │   └── banner.go          # Ruled block for the one credential shown in the clear
 │   ├── resetpw/
@@ -3064,21 +3011,24 @@ webhooker/
 │   │   └── logfield.go        # Encoded-byte budget for client-supplied log values
 │   ├── delivery/
 │   │   ├── engine.go          # Event-driven delivery engine (channel + timer based)
-│   │   ├── store.go           # Storing an event with its deliveries, and a replay, then queueing them
 │   │   ├── circuit_breaker.go # Per-target circuit breaker for http/slack targets with retries
 │   │   ├── target.go          # Target interface, Task, Scheduler
 │   │   ├── target_http.go     # HTTP target (retries, circuit breaker)
 │   │   ├── target_slack.go    # Slack/Mattermost incoming-webhook target
-│   │   ├── target_database.go # Database archive target, writing through internal/archive
+│   │   ├── target_database.go # Database archive target
+│   │   ├── target_database_archive.go  # Archive file lifecycle and pruning
+│   │   ├── target_database_rotation.go # Archive rotation and file names
+│   │   ├── target_database_export.go   # Archive download as gzipped JSON
 │   │   ├── target_log.go      # Log target (stdout)
-│   │   ├── target_config_view.go  # Masked target settings for templates
+│   │   ├── target_config_view.go  # Masked target config for templates
+│   │   ├── archive_sweeper.go # Periodic pruning of idle archives
 │   │   ├── queue_depth.go     # Periodic sampler behind the queue-depth gauges
 │   │   ├── url_mask.go        # Strips credentials from *url.Error
 │   │   └── ssrf.go            # SSRF prevention (IP validation, safe HTTP transport)
 │   ├── handlers/
 │   │   ├── handlers.go        # Base handler struct, JSON helpers, template rendering
 │   │   ├── auth.go            # Login, logout handlers
-│   │   ├── delivery_replay.go # Per-delivery replay: new delivery, current target settings
+│   │   ├── delivery_replay.go # Per-delivery replay: new delivery, current target config
 │   │   ├── event_resubmit.go  # Event resubmit: new event, all currently active targets
 │   │   ├── entrypoint_view.go # Masked entrypoint view for templates
 │   │   ├── event_log_view.go  # Event log projection, byte-capped in SQL
@@ -3093,7 +3043,7 @@ webhooker/
 │   │   ├── webhook_delete.go  # Webhook delete, event database and archive writer removal
 │   │   ├── event_log.go       # Event log page: loaders, filters, delivery views
 │   │   ├── entrypoint.go      # Entrypoint create, edit, delete and toggle
-│   │   ├── target_create.go   # Target create, each type's settings from the form
+│   │   ├── target_create.go   # Target create, per-type config builders
 │   │   ├── target_delete.go   # Target delete
 │   │   ├── target_toggle.go   # Target toggle
 │   │   ├── shared.go          # Helpers shared by several handlers
@@ -3112,8 +3062,6 @@ webhooker/
 │   │   ├── ratelimit.go       # Per-IP rate limiting middleware (go-chi/httprate)
 │   │   ├── loginguard.go      # Login failure counters and the Argon2id verification semaphore
 │   │   └── middlewaretest/    # Test support: a Middleware for tests in other packages
-│   ├── referer/
-│   │   └── referer.go         # SchemeAndHost: cuts a Referer down to its scheme and host, for the access log and the Sentry hook
 │   ├── reqtls/
 │   │   └── reqtls.go          # IsTLS: the one TLS predicate, r.TLS or X-Forwarded-Proto
 │   ├── server/
@@ -3128,8 +3076,8 @@ webhooker/
 │   ├── static.go              # //go:embed directive
 │   ├── css/input.css          # Tailwind input, source for tailwind.css (make css)
 │   ├── css/tailwind.css       # Generated stylesheet the pages load
-│   ├── css/style.css          # Hand-written, loaded after tailwind.css: btn-small, the pointer cursor for input.css's buttons, the webhook list cards' focus outline, the rule hiding x-cloak elements
+│   ├── css/style.css          # Hand-written, loaded after tailwind.css: btn-small, the pointer cursor for input.css's buttons, the webhook list cards' focus outline
-│   ├── js/app.js              # Copy-to-clipboard, the delete prompts, and the Alpine.js components
+│   ├── js/app.js              # Copy-to-clipboard, and the Alpine.js components
 │   └── js/alpine.min.js       # Alpine.js CSP build, extracted from 3p/ by make assets, not committed
 ├── templates/                 # Go HTML templates (base, login, sources, etc.)
 ├── script/                    # Scripts to Rule Them All entrypoints
@@ -3161,26 +3109,21 @@ Components are wired via Uber fx in this order:
 10. `metrics.NewRegistry` — The registry `/metrics` serves
 11. `metrics.New` — The delivery collectors, registered on that registry
 12. `middleware.New` — HTTP middleware
-13. `delivery.New` — Event-driven delivery engine, which also stores each event
+13. `delivery.New` — Event-driven delivery engine
-    with its deliveries and creates replay deliveries
+14. `delivery.NewArchiveSweeper` — Periodic pruning of idle archives
-14. `archive.NewWriters` — The database targets' archive writers, and the lock
+15. `delivery.Engine` → `delivery.Notifier` — interface bridge
-    every rename of their files runs under
+16. `delivery.Engine` → `delivery.Archives` — interface bridge so deleting or
-15. `archive.NewSweeper` — Periodic pruning of idle archives
-16. `archive.Writers` → `archive.Archives` — interface bridge so deleting or
     renaming a webhook or target reaches its archive files
-17. `delivery.Engine` → `delivery.CircuitBreakers` — interface bridge so the
+17. `server.New` — HTTP server and router
-    pages can show a target whose deliveries are paused
-18. `server.New` — HTTP server and router
 
 The server starts via
-`fx.Invoke(func(*server.Server, *delivery.Engine, *database.RetentionReaper, *archive.Sweeper) {})`,
+`fx.Invoke(func(*server.Server, *delivery.Engine, *database.RetentionReaper, *delivery.ArchiveSweeper) {})`,
-which triggers the fx lifecycle hooks in dependency order. The handlers take
+which triggers the fx lifecycle hooks in dependency order. The
-`*delivery.Engine` itself: the receiver and resubmit handlers store an event
+`delivery.Notifier` interface allows the webhook handler to send self-contained
-through `StoreEvent`, and the replay handler adds a delivery through
+`delivery.Task` slices to the engine without a direct package dependency. Each
-`CreateReplay`. Each task the engine queues carries the target's settings and
+task carries all target config and event data inline (for bodies under 16 KiB,
-the event's data, and the body too when it is under 16 KiB
+`delivery.MaxInlineBodySize`), so the engine can deliver without reading from
-(`delivery.MaxInlineBodySize`); a larger body is read from the event row when
+any database — it only writes to record results.
-the attempt runs.
 
 ### Middleware Stack
 
@@ -3188,9 +3131,8 @@ Applied to all routes in this order:
 
 1. **RequestID** — Generate unique request IDs (chi built-in)
 2. **SecurityHeaders** — Production security headers on every response (HSTS
-   unless `HSTS_MAX_AGE` is `0`, X-Content-Type-Options, X-Frame-Options, CSP
+   unless `HSTS_MAX_AGE` is `0`, X-Content-Type-Options, X-Frame-Options, CSP,
-   `default-src 'self'; script-src 'self'; style-src 'self'`, Referrer-Policy,
+   Referrer-Policy, Permissions-Policy)
-   Permissions-Policy)
 3. **Logging** — Structured request logging (method, URL, status, latency,
    remote IP, client IP, user agent, request ID)
 4. **Metrics** — Prometheus HTTP metrics (if `METRICS_USERNAME` and
@@ -3275,12 +3217,6 @@ credential check, see [The login endpoint](#the-login-endpoint).
 - Production security headers on all responses: HSTS (unless `HSTS_MAX_AGE` is
   `0`), X-Content-Type-Options (`nosniff`), X-Frame-Options (`DENY`),
   Content-Security-Policy, Referrer-Policy, and Permissions-Policy
-- The Content-Security-Policy is
-  `default-src 'self'; script-src 'self'; style-src 'self'`: a page takes
-  scripts and styles only from files webhooker serves, and the browser runs no
-  inline script or event handler and ignores any `<style>` element or `style`
-  attribute in a page. The pages need none: their scripts are in `static/js/`
-  and their styles in `static/css/`
 - Request body size limits (1 MB) on all form POST endpoints, enforced by
   middleware that runs before CSRF parses the form
 - **CSRF protection** via [gorilla/csrf](https://github.com/gorilla/csrf) on all
@@ -3343,13 +3279,12 @@ order under a **5 second budget** (`fx.StopTimeout` in `cmd/webhooker/main.go`).
 That budget covers the whole sequence, not each hook. The order, read off the fx
 stop-hook log:
 
-1. `archive.Sweeper`
+1. `ArchiveSweeper`
 2. `RetentionReaper`
 3. `server` — the HTTP drain, bounded by `server.ShutdownTimeout` (**3
    seconds**) and by what the hooks before it left, then a Sentry flush if
    `SENTRY_DSN` is set
-4. `delivery.Engine` — cuts off any `http` or `slack` request in flight, waits
+4. `delivery.Engine` — waits for its workers, then closes the archive databases
-   for its workers, then closes the archive databases
 5. `healthcheck`
 6. `WebhookDBManager`
 7. the database close
@@ -3360,12 +3295,6 @@ by the stop context, so a wedge there consumes the 5 seconds before the HTTP
 server hook is ever entered. The hooks after the server are microsecond-scale in
 normal operation.
 
-The delivery engine cancels a delivery request in flight. That attempt is not
-recorded or counted in the metrics, and the delivery keeps its `pending` or
-`retrying` status, so recovery at the next start sends it again (see Recovery
-under Bounded Worker Pool). If the receiver already had it, it receives it
-twice: the at-least-once duplicate described under Rationale.
-
 The HTTP drain budget is deliberately **shorter** than the sequence budget. Were
 the two equal, a drain that used its whole budget would exhaust the sequence
 budget at the instant it finished, and every later hook — the delivery engine,
@@ -3386,7 +3315,7 @@ skipped when that leaves too little to be worth attempting — so a full-length
 drain means Sentry events are dropped rather than the database close being
 skipped.
 
-This does not make the database close unconditional. A slow `archive.Sweeper` or
+This does not make the database close unconditional. A slow `ArchiveSweeper` or
 `RetentionReaper` is enough to cut the shutdown short, not only one that
 consumes the whole budget: what they spend comes out of the drain first, so
 after 2 seconds of theirs a request still in flight gets 1 second to finish, and
@@ -3488,12 +3417,14 @@ fixed independently of the compiler's:
    a step's log, and then fails. `make test` builds this stage alone.
 6. **Builder stage** (`golang:1.26.1-bookworm`) — depends on the lint and test
    phases and the `css-check` and `markdown-check` stages passing (it copies a
-   file from each), and runs `make build` (which extracts Alpine.js from `3p/`
+   file from each), runs `make build` (which extracts Alpine.js from `3p/`
-   first). `make build` compiles with cgo off, so the binary is statically
+   first), and then rebuilds the binary with `CGO_ENABLED=1` and static linking
-   linked and runs on the Alpine runtime image. The version is the `VERSION`
+   so it runs on musl. Both builds go through `make build`, the relink adding
-   build arg if one is given, otherwise derived from the `.git` in the context,
+   its `-extldflags` via `GO_LDFLAGS`, so neither can drop the `-X` that stamps
-   and the stage fails if a context with `.git` would stamp an empty version,
+   the version. The version is the `VERSION` build arg if one is given,
-   `dev` or `unknown` (see [Version stamping](#version-stamping)).
+   otherwise derived from the `.git` in the context, and the stage fails if a
+   context with `.git` would stamp an empty version, `dev` or `unknown` (see
+   [Version stamping](#version-stamping)).
 7. **Runtime stage** (`alpine:3.21`) — copies the static binary and
    `deploy/docker-entrypoint.sh`, creates the `/var/lib/webhooker` directory for
    all SQLite databases, exposes port 8080, and includes a health check against
@@ -3505,6 +3436,11 @@ The lint and test phases invoke `gofmt`, `golangci-lint` and `go test` directly
 rather than `make fmt-check`, `make lint` and `make test`: those targets build
 docker stages, which would need a docker daemon inside this build.
 
+The lint phase and the Go stages use Debian rather than Alpine because
+`gorm.io/driver/sqlite` pulls in `mattn/go-sqlite3`, which needs CGO and does
+not compile against musl. Only the final binary is statically linked, which is
+what lets it run on the Alpine runtime image.
+
 `script/cibuild` is the CI gate: it runs `script/bootstrap`, then
 `script/check`, then builds the image, whose build runs the lint and test phases
 and the stylesheet and Markdown checks again. A build that succeeds is a repo

cmd/webhooker/main.go

@@ -10,7 +10,6 @@ import (
 
 	"go.uber.org/fx"
 	"go.uber.org/fx/fxevent"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/config"
 	"sneak.berlin/go/webhooker/internal/database"
 	"sneak.berlin/go/webhooker/internal/datadir"
@@ -50,7 +49,7 @@ import (
 // before the server may already have spent.
 //
 // This does not make the database close unconditional: the
-// archive.Sweeper and RetentionReaper hooks run before the server.
+// ArchiveSweeper and RetentionReaper hooks run before the server.
 // What they spend comes out of the drain first, but past 3s it comes
 // out of the reserve, and they can consume the whole budget.
 const stopTimeout = 5 * time.Second
@@ -189,8 +188,8 @@ func newApp() *fx.App {
 		fx.Provide(
 			globals.New,
 			logger.New,
-			// The plain logger the session, the middleware, the
+			// The plain logger the session, the middleware and the
-			// webhook database manager and the archive writers take.
+			// webhook database manager take.
 			func(l *logger.Logger) *slog.Logger { return l.Get() },
 			config.New,
 			database.New,
@@ -209,12 +208,14 @@ func newApp() *fx.App {
 			// disagree about a destination.
 			delivery.NewGuard,
 			delivery.New,
-			archive.NewWriters,
+			delivery.NewArchiveSweeper,
-			archive.NewSweeper,
+			// Wire *delivery.Engine as delivery.Notifier so the
-			// Wire *archive.Writers as archive.Archives so deleting
+			// webhook handler can notify the engine of new deliveries.
+			func(e *delivery.Engine) delivery.Notifier { return e },
+			// Wire *delivery.Engine as delivery.Archives so deleting
 			// or renaming a webhook or target reaches its archive
 			// files.
-			func(w *archive.Writers) archive.Archives { return w },
+			func(e *delivery.Engine) delivery.Archives { return e },
 			// Wire *delivery.Engine as delivery.CircuitBreakers so
 			// the pages can show a target whose deliveries are
 			// paused.
@@ -226,7 +227,7 @@ func newApp() *fx.App {
 				*server.Server,
 				*delivery.Engine,
 				*database.RetentionReaper,
-				*archive.Sweeper,
+				*delivery.ArchiveSweeper,
 			) {
 			},
 		),

cmd/webhooker/main_test.go

@@ -252,7 +252,7 @@ const tailHeadroom = 2 * time.Second
 // can produce, since a shorter drain leaves the flush more room and
 // the worst case is not necessarily at either extreme.
 //
-// Nor does the hook start on a full budget: the archive.Sweeper and
+// Nor does the hook start on a full budget: the ArchiveSweeper and
 // RetentionReaper hooks run before it, and whatever they spent is
 // gone. The outer sweep walks every amount they can spend. Once they
 // have eaten into the headroom themselves, the hook must spend

internal/archive/archive.go

@@ -1,446 +0,0 @@
-// Package archive manages the SQLite archive files the database target
-// writes: how they are named and rotated, the writers that open, write,
-// close and reopen them, pruning the rows past a target's expiry,
-// renaming a target's files and moving them back when that fails, the
-// gzipped JSON export, the idle sweep, and the locks that keep a rename
-// apart from archive writes, from other edits and from exports.
-package archive
-
-import (
-	"fmt"
-	"log/slog"
-	"strings"
-	"sync"
-	"time"
-
-	"go.uber.org/fx"
-	"sneak.berlin/go/webhooker/internal/database"
-)
-
-// archiveNameMaxLen is how many characters of a webhook or target
-// name an archive file name keeps.
-const archiveNameMaxLen = 40
-
-// Archives is how the handlers keep the database targets' archive
-// files in step with the configuration. Deleting a webhook or a
-// target releases the cached archive writers, whose open file
-// handles would otherwise outlive them; renaming one renames the
-// archive files, which are named for the webhook and the target
-// (see FileName). RenameLock returns the lock every rename runs under
-// (see Writers.RenameLock).
-//
-// It is an interface so that the handlers' tests can stand in for
-// Writers.
-//
-// Neither eviction deletes an archive file. Both are idempotent
-// and are no-ops for a webhook or target with no writer.
-type Archives interface {
-	RenameLock() *sync.Mutex
-	EvictWebhook(webhookID string)
-	EvictTarget(targetID string)
-	Rename(targetID, webhookName, targetName string) error
-}
-
-// WritersParams holds the fx dependencies for Writers.
-type WritersParams struct {
-	fx.In
-
-	Database  *database.Database
-	DBManager *database.WebhookDBManager
-	Logger    *slog.Logger
-}
-
-// Writers holds the archive writer of each database target, and the
-// lock every rename of archive files runs under. The database target
-// writes an event through it, the handlers rename and evict through
-// it, the archive sweeper prunes through it, and the delivery engine
-// evicts every writer when it stops. See archiveWriter for the
-// close/reopen, auto-recreate, and expiry semantics.
-type Writers struct {
-	db    *database.Database
-	dbMgr *database.WebhookDBManager
-	log   *slog.Logger
-
-	// writers holds one archive writer per database target, keyed
-	// by target ID.
-	mu      sync.Mutex
-	writers map[string]*archiveWriter
-
-	// renameMu makes the webhook edit, the target edit and target
-	// creation run one at a time, each held from loading the stored
-	// names through the archive rename, the save and any move back.
-	// Interleaved, one could rename an archive between another's
-	// rename and save, leaving the file named for one edit and the
-	// stored names from the other. An archive download holds it while
-	// it reads the stored names and lists the files they give, and
-	// again for each file while it finds the file under the names
-	// stored then and opens it. RenameLock returns it.
-	renameMu sync.Mutex
-}
-
-// NewWriters builds the archive writers. It opens no archive file:
-// each target's writer is made on its first use.
-func NewWriters(params WritersParams) *Writers {
-	return &Writers{
-		db:    params.Database,
-		dbMgr: params.DBManager,
-		log:   params.Logger,
-	}
-}
-
-// RenameLock implements Archives. It returns the lock every rename of
-// archive files runs under: see renameMu for who holds it and for how
-// long. Archive writes and Rename itself do not take it.
-func (ws *Writers) RenameLock() *sync.Mutex {
-	return &ws.renameMu
-}
-
-// FileName returns the file name of a database target's
-// archive: archive-WEBHOOKNAME-TARGETNAME-TARGETID.db, with both
-// names passed through archiveNamePart. The target ID keeps the
-// name unique when two targets' names come out the same.
-func FileName(webhookName, targetName, targetID string) string {
-	return "archive-" + archiveNamePart(webhookName) + "-" +
-		archiveNamePart(targetName) + "-" + targetID + ".db"
-}
-
-// archiveNamePart makes a webhook or target name safe to put in a
-// file name. It is lowercased; ASCII letters and digits are kept,
-// every other run of characters becomes a single "-", and no "-" is
-// left at either end. It is cut to archiveNameMaxLen characters, and
-// a name with nothing left is "unnamed".
-func archiveNamePart(name string) string {
-	var b strings.Builder
-
-	dash := false
-
-	for _, r := range strings.ToLower(name) {
-		if (r < 'a' || r > 'z') && (r < '0' || r > '9') {
-			dash = b.Len() > 0
-
-			continue
-		}
-
-		if dash {
-			b.WriteByte('-')
-
-			dash = false
-		}
-
-		b.WriteRune(r)
-	}
-
-	part := b.String()
-	if len(part) > archiveNameMaxLen {
-		part = strings.TrimRight(part[:archiveNameMaxLen], "-")
-	}
-
-	if part == "" {
-		return "unnamed"
-	}
-
-	return part
-}
-
-// Write writes the full event of a delivery to a database target as
-// a row into the target's archive database, honouring the target's
-// ArchiveExpiry and ArchiveRotation. With rotation, the event goes to
-// the file for the period of its receive time.
-func (ws *Writers) Write(d *database.Delivery) error {
-	webhookID := d.Event.WebhookID
-	if webhookID == "" {
-		return errArchiveMissingWebhookID
-	}
-
-	// An event whose stored row was gone before its delivery ran has
-	// no receive time (see delivery's Engine.hydrateEvent), and goes
-	// to the file for now.
-	receivedAt := d.Event.CreatedAt
-	if receivedAt.IsZero() {
-		receivedAt = time.Now()
-	}
-
-	w, err := ws.writerFor(d.TargetID)
-	if err != nil {
-		return err
-	}
-
-	row := archivedEvent{
-		EventID:      d.Event.ID,
-		WebhookID:    webhookID,
-		EntrypointID: d.Event.EntrypointID,
-		Method:       d.Event.Method,
-		RawQuery:     d.Event.RawQuery,
-		Headers:      d.Event.Headers,
-		Body:         d.Event.Body,
-		ContentType:  d.Event.ContentType,
-	}
-
-	return w.write(
-		row, d.Target.ArchiveExpiry,
-		archivePeriod(d.Target.ArchiveRotation, receivedAt),
-	)
-}
-
-// Rename implements Archives. It renames every one of a database
-// target's archive files to FileName(webhookName, targetName,
-// targetID), each keeping the period in its name. It goes through the
-// target's writer, so the move holds the lock that the target's
-// archive writes and the idle sweep take, and later writes use the
-// new name. It never replaces a file: if one already has a new name,
-// the error is ErrNameTaken.
-//
-// The writer is created if there is none, and it stays cached. The
-// handlers rename before they save the new name, so until the save
-// the main database still has the old one; a delivery in that window
-// must find this writer rather than build one from the old name.
-func (ws *Writers) Rename(
-	targetID, webhookName, targetName string,
-) error {
-	w, err := ws.writerFor(targetID)
-	if err != nil {
-		return err
-	}
-
-	return w.rename(FileName(webhookName, targetName, targetID))
-}
-
-// EvictTarget implements Archives. It drops a database target's
-// archive writer from the registry and closes its handle, so a
-// deleted target does not leave a writer (and an open archive handle
-// within its debounce window) alive for the process lifetime.
-//
-// The map entry is removed under the registry lock, which is
-// then released before the handle is closed under the writer's
-// own lock: that ordering keeps the registry available to other
-// targets while an in-flight write on this one drains, and
-// closing under the writer's lock means eviction can never race
-// a write.
-//
-// Eviction is idempotent and silent for a target with no writer,
-// which is the common case: only a database target that has
-// received an event or been renamed has one. It never deletes the
-// archive file.
-func (ws *Writers) EvictTarget(targetID string) {
-	ws.mu.Lock()
-
-	w, ok := ws.writers[targetID]
-	if ok {
-		delete(ws.writers, targetID)
-	}
-
-	ws.mu.Unlock()
-
-	if !ok {
-		return
-	}
-
-	w.evict()
-
-	ws.log.Info(
-		"evicted archive writer",
-		"target_id", targetID,
-		"path", w.path,
-	)
-}
-
-// EvictWebhook implements Archives. It evicts, exactly as EvictTarget
-// does, the writer of every database target of a webhook. The archive
-// files themselves are left on disk — they are long-term storage the
-// operator owns.
-func (ws *Writers) EvictWebhook(webhookID string) {
-	ws.mu.Lock()
-
-	var gone []*archiveWriter
-
-	for targetID, w := range ws.writers {
-		if w.webhookID == webhookID {
-			delete(ws.writers, targetID)
-
-			gone = append(gone, w)
-		}
-	}
-
-	ws.mu.Unlock()
-
-	for _, w := range gone {
-		w.evict()
-
-		ws.log.Info(
-			"evicted archive writer",
-			"webhook_id", webhookID,
-			"path", w.path,
-		)
-	}
-}
-
-// EvictAll evicts every cached archive writer, exactly as EvictTarget
-// does for one target. The delivery engine calls it at shutdown, once
-// its workers have returned. Closing the last handle on an archive
-// moves the contents of its -wal into the .db and removes the
-// -wal, so a clean stop leaves each archive as a single file.
-func (ws *Writers) EvictAll() {
-	ws.mu.Lock()
-
-	writers := ws.writers
-	ws.writers = nil
-
-	ws.mu.Unlock()
-
-	for _, w := range writers {
-		w.evict()
-	}
-}
-
-// writerFor returns the archive writer for a database target,
-// creating and caching it on first use. Each target has one writer
-// so its close/reopen debounce state is shared across concurrent
-// deliveries, and so a rename and the idle sweep take the same lock
-// as its writes.
-func (ws *Writers) writerFor(
-	targetID string,
-) (*archiveWriter, error) {
-	ws.mu.Lock()
-	defer ws.mu.Unlock()
-
-	w, ok := ws.writers[targetID]
-	if !ok {
-		var err error
-
-		w, err = ws.newWriter(targetID)
-		if err != nil {
-			return nil, err
-		}
-
-		if ws.writers == nil {
-			ws.writers = make(map[string]*archiveWriter)
-		}
-
-		ws.writers[targetID] = w
-	}
-
-	// A delivery claims the entry: even if the idle sweep created
-	// it moments ago, it now belongs to the registry proper and
-	// the sweep must leave it in place when it finishes.
-	w.sweepOwned = false
-
-	return w, nil
-}
-
-// sweepWriterFor returns the archive writer the idle sweep should
-// prune a target's archive through, together with whether the sweep
-// itself created the registry entry.
-//
-// The sweep must route its prune through the registered writer so
-// the writer's mutex orders it against concurrent writes, but it
-// must never leave a registry entry behind: a sweep that ran
-// concurrently with the target's deletion would otherwise
-// re-create an entry that nothing will ever evict again, which is
-// exactly the leak eviction exists to prevent. An entry the sweep
-// creates is therefore marked sweep-owned and handed back to
-// releaseSweepWriter when the sweep is done.
-func (ws *Writers) sweepWriterFor(
-	targetID string,
-) (*archiveWriter, bool, error) {
-	ws.mu.Lock()
-	defer ws.mu.Unlock()
-
-	w, ok := ws.writers[targetID]
-	if ok {
-		return w, false, nil
-	}
-
-	w, err := ws.newWriter(targetID)
-	if err != nil {
-		return nil, false, err
-	}
-
-	if ws.writers == nil {
-		ws.writers = make(map[string]*archiveWriter)
-	}
-
-	w.sweepOwned = true
-	ws.writers[targetID] = w
-
-	return w, true, nil
-}
-
-// releaseSweepWriter drops a registry entry that the idle sweep
-// created, so a sweep leaves the registry exactly as it found it.
-//
-// The entry is removed only if it is still the very writer the
-// sweep installed and no delivery has claimed it in the meantime
-// (writerFor clears sweepOwned when it hands a writer to the
-// write path). Both conditions are evaluated under the registry
-// lock, so an eviction that raced the sweep — which removes the
-// entry outright — simply finds nothing left to do here, and a
-// delivery that adopted the writer keeps a registered, evictable
-// one.
-func (ws *Writers) releaseSweepWriter(
-	targetID string, w *archiveWriter,
-) {
-	ws.mu.Lock()
-	defer ws.mu.Unlock()
-
-	cur, ok := ws.writers[targetID]
-	if !ok || cur != w || !cur.sweepOwned {
-		return
-	}
-
-	delete(ws.writers, targetID)
-}
-
-// newWriter builds the writer for a database target's archive. Its
-// path is the one Path gives for the webhook and the target as
-// the main database names them now; from then on only rename changes
-// the name the writer uses. It does not touch the archive files.
-func (ws *Writers) newWriter(
-	targetID string,
-) (*archiveWriter, error) {
-	if ws.dbMgr == nil {
-		return nil, errArchiveNoDataDir
-	}
-
-	var target database.Target
-
-	err := ws.db.DB().
-		Preload("Webhook").
-		First(&target, "id = ?", targetID).Error
-	if err != nil {
-		return nil, fmt.Errorf(
-			"loading database target %s: %w", targetID, err,
-		)
-	}
-
-	w := newArchiveWriter(
-		Path(ws.dbMgr, &target.Webhook, &target),
-		ws.log,
-	)
-	w.webhookID = target.WebhookID
-
-	return w, nil
-}
-
-// sweepArchive prunes one database target's archive of rows older
-// than expiry, without requiring a write. A missing archive file is
-// left missing (see sweepExpired), so a sweep never creates an
-// archive for a target that has never received an event.
-//
-// It also never leaves a registry entry behind: an entry it had
-// to create to reach the writer's mutex is released again once
-// the prune is done, so a sweep racing a target deletion cannot
-// resurrect the writer the eviction just dropped.
-func (ws *Writers) sweepArchive(
-	targetID string, expiry time.Duration,
-) error {
-	w, created, err := ws.sweepWriterFor(targetID)
-	if err != nil {
-		return err
-	}
-
-	if created {
-		defer ws.releaseSweepWriter(targetID, w)
-	}
-
-	return w.sweepExpired(expiry)
-}

internal/archive/archive_test.go

@@ -1,757 +0,0 @@
-package archive_test
-
-import (
-	"database/sql"
-	"fmt"
-	"io/fs"
-	"log/slog"
-	"net/http"
-	"os"
-	"path/filepath"
-	"strings"
-	"testing"
-	"time"
-
-	"github.com/google/uuid"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"gorm.io/driver/sqlite"
-	"gorm.io/gorm"
-	_ "modernc.org/sqlite" // Pure Go SQLite driver.
-	"sneak.berlin/go/webhooker/internal/archive"
-	"sneak.berlin/go/webhooker/internal/database"
-	"sneak.berlin/go/webhooker/internal/gormlog"
-)
-
-const (
-	// testContentType is the event content type used in tests.
-	testContentType = "application/json"
-
-	// eventQuery is the query string an archived event carries.
-	eventQuery = "a=1&b=2"
-)
-
-func archiveTestLogger() *slog.Logger {
-	return slog.New(slog.NewTextHandler(
-		os.Stderr,
-		&slog.HandlerOptions{Level: slog.LevelDebug},
-	))
-}
-
-// openArchiveDBForRead opens an archive file read-only so a
-// test can inspect the rows the writer persisted.
-func openArchiveDBForRead(
-	t *testing.T, path string,
-) *gorm.DB {
-	t.Helper()
-
-	sqlDB, err := sql.Open(
-		"sqlite",
-		fmt.Sprintf("file:%s?mode=ro", path),
-	)
-	require.NoError(t, err)
-
-	t.Cleanup(func() { _ = sqlDB.Close() })
-
-	gdb, err := gorm.Open(
-		sqlite.Dialector{Conn: sqlDB},
-		&gorm.Config{Logger: gormlog.New(slog.New(slog.DiscardHandler))},
-	)
-	require.NoError(t, err)
-
-	return gdb
-}
-
-// archiveFileSuffixes returns the archive file itself and the
-// SQLite sidecars that accompany an open database. A test that
-// asserts no archive was created has to check all of them.
-func archiveFileSuffixes() []string {
-	return []string{"", "-wal", "-shm"}
-}
-
-// removeArchiveFiles simulates an operator moving the archive
-// away by deleting the SQLite file and its sidecar files.
-func removeArchiveFiles(t *testing.T, path string) {
-	t.Helper()
-
-	for _, suffix := range []string{
-		"", "-wal", "-shm", "-journal",
-	} {
-		err := os.Remove(path + suffix)
-		if err != nil && !os.IsNotExist(err) {
-			t.Fatalf("removing %s%s: %v", path, suffix, err)
-		}
-	}
-}
-
-// assertStoredTime asserts that text, a timestamp as SQLite holds it,
-// is in the form GORM stores created_at in: the layout of
-// time.Time.String, with no " m=+…" monotonic clock reading after it.
-func assertStoredTime(t *testing.T, text string) {
-	t.Helper()
-
-	_, err := time.Parse(
-		"2006-01-02 15:04:05.999999999 -0700 MST", text,
-	)
-	assert.NoError(t, err, "stored as %q", text)
-}
-
-// newEvent returns an event received now with the given body, as the
-// webhook handler stores it.
-func newEvent(body string) database.Event {
-	return database.Event{
-		BaseModel: database.BaseModel{
-			ID:        uuid.New().String(),
-			CreatedAt: time.Now(),
-		},
-		WebhookID:    uuid.New().String(),
-		EntrypointID: uuid.New().String(),
-		Method:       http.MethodPost,
-		Headers:      `{"Content-Type":["application/json"]}`,
-		Body:         body,
-		ContentType:  testContentType,
-	}
-}
-
-// databaseTargetDelivery returns a delivery of event to a database
-// target, as the database target hands it to Writers.Write.
-func databaseTargetDelivery(
-	event database.Event, tgt *database.Target,
-) *database.Delivery {
-	return &database.Delivery{
-		EventID:  event.ID,
-		TargetID: tgt.ID,
-		Event:    event,
-		Target: database.Target{
-			Name:            tgt.Name,
-			Type:            database.TargetTypeDatabase,
-			ArchiveExpiry:   tgt.ArchiveExpiry,
-			ArchiveRotation: tgt.ArchiveRotation,
-		},
-	}
-}
-
-func TestArchiveWriter_WritesRow(t *testing.T) {
-	t.Parallel()
-
-	path := filepath.Join(t.TempDir(), "archive-wh.db")
-	w := archive.NewExportArchiveWriter(
-		path, archiveTestLogger(), 0,
-	)
-
-	row := archive.ExportArchivedEvent{
-		EventID:      "ev-1",
-		WebhookID:    "wh-1",
-		EntrypointID: "ep-1",
-		Method:       "POST",
-		Headers:      `{"X":"Y"}`,
-		Body:         `{"hello":"world"}`,
-		ContentType:  "application/json",
-	}
-
-	require.NoError(t, w.Write(row, 0))
-	assert.FileExists(t, path)
-
-	var got []archive.ExportArchivedEvent
-
-	require.NoError(t, w.DB().Find(&got).Error)
-	require.Len(t, got, 1)
-	assert.Equal(t, "ev-1", got[0].EventID)
-	assert.Equal(t, "wh-1", got[0].WebhookID)
-	assert.Equal(t, "ep-1", got[0].EntrypointID)
-	assert.Equal(t, row.Method, got[0].Method)
-	assert.Equal(t, row.ContentType, got[0].ContentType)
-	assert.JSONEq(t, `{"hello":"world"}`, got[0].Body)
-	assert.False(t, got[0].ArchivedAt.IsZero())
-
-	var archivedAt string
-
-	require.NoError(t, w.DB().Raw(
-		"SELECT CAST(archived_at AS TEXT) FROM archived_events",
-	).Row().Scan(&archivedAt))
-	assertStoredTime(t, archivedAt)
-}
-
-func TestArchiveWriter_RecreatesAfterRemoval(
-	t *testing.T,
-) {
-	t.Parallel()
-
-	path := filepath.Join(t.TempDir(), "archive-wh.db")
-	w := archive.NewExportArchiveWriter(
-		path, archiveTestLogger(), 0,
-	)
-
-	require.NoError(t, w.Write(
-		archive.ExportArchivedEvent{EventID: "a"}, 0,
-	))
-	assert.FileExists(t, path)
-
-	// The operator moves the archive away while the handle is
-	// still open.
-	removeArchiveFiles(t, path)
-	require.NoFileExists(t, path)
-
-	// The next write recreates the file with a fresh schema and
-	// only the new row.
-	require.NoError(t, w.Write(
-		archive.ExportArchivedEvent{EventID: "b"}, 0,
-	))
-	assert.FileExists(t, path)
-
-	var got []archive.ExportArchivedEvent
-
-	require.NoError(t, w.DB().Find(&got).Error)
-	require.Len(t, got, 1)
-	assert.Equal(t, "b", got[0].EventID)
-}
-
-// TestArchiveHandleIsWAL closes the last gap in the durability
-// evidence: the main and per-webhook tiers each assert their journal
-// mode on a live handle, and the archive tier gets its settings from
-// the same code path but nothing checked the running file.
-func TestArchiveHandleIsWAL(t *testing.T) {
-	t.Parallel()
-
-	w := archive.NewExportArchiveWriter(
-		filepath.Join(t.TempDir(), "archive-wal.db"),
-		archiveTestLogger(), 0,
-	)
-
-	require.NoError(t, w.Open(0))
-
-	var mode string
-
-	row := w.DB().Raw("pragma journal_mode").Row()
-	require.NoError(t, row.Scan(&mode))
-	assert.Equal(t, "wal", strings.ToLower(mode))
-
-	var busy string
-
-	row = w.DB().Raw("pragma busy_timeout").Row()
-	require.NoError(t, row.Scan(&busy))
-	assert.Equal(t, "10000", busy)
-}
-
-// TestStatArchive proves Stat finds no file before the first
-// write; after a write still held in the -wal, counts the -wal in the
-// size and takes its later time as the last write; and finds no file
-// again once the file has been moved away.
-func TestStatArchive(t *testing.T) {
-	t.Parallel()
-
-	path := filepath.Join(t.TempDir(), "archive-wh.db")
-
-	_, err := archive.Stat(path)
-	require.ErrorIs(t, err, fs.ErrNotExist)
-
-	// With the clock stopped, the reopen debounce never passes, so
-	// the handle stays open after the write.
-	stopped := time.Now()
-	w := archive.NewExportArchiveWriter(path, archiveTestLogger(), 0)
-	w.SetNow(func() time.Time { return stopped })
-
-	require.NoError(t, w.Write(archive.ExportArchivedEvent{EventID: "a"}, 0))
-
-	written := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
-	earlier := written.Add(-time.Hour)
-	require.NoError(t, os.Chtimes(path, earlier, earlier))
-	require.NoError(t, os.Chtimes(path+"-wal", written, written))
-
-	file, err := os.Stat(path)
-	require.NoError(t, err)
-
-	wal, err := os.Stat(path + "-wal")
-	require.NoError(t, err)
-	require.Positive(t, wal.Size())
-
-	got, err := archive.Stat(path)
-	require.NoError(t, err)
-	assert.Equal(t, 1, got.Files)
-	assert.Equal(t, file.Size()+wal.Size(), got.Size)
-	assert.True(t, written.Equal(got.Written), got.Written)
-
-	removeArchiveFiles(t, path)
-
-	_, err = archive.Stat(path)
-	require.ErrorIs(t, err, fs.ErrNotExist)
-}
-
-func TestArchiveWriter_ReopenDebounce(t *testing.T) {
-	t.Parallel()
-
-	const debounce = 2 * time.Second
-
-	path := filepath.Join(t.TempDir(), "archive-wh.db")
-	w := archive.NewExportArchiveWriter(
-		path, archiveTestLogger(), debounce,
-	)
-
-	// The writer measures its reopen debounce on this clock, which
-	// only the test moves, so how long the host takes between
-	// writes cannot change the result.
-	now := time.Now()
-
-	w.SetNow(func() time.Time { return now })
-
-	require.NoError(t, w.Write(
-		archive.ExportArchivedEvent{EventID: "a"}, 0,
-	))
-	require.NoError(t, w.Write(
-		archive.ExportArchivedEvent{EventID: "b"}, 0,
-	))
-
-	// Two writes inside the debounce window trigger only the
-	// initial open — no extra close/reopen.
-	assert.Equal(t, 1, w.Reopens())
-
-	now = now.Add(debounce)
-
-	require.NoError(t, w.Write(
-		archive.ExportArchivedEvent{EventID: "c"}, 0,
-	))
-
-	// A write after the window elapses closes and reopens once.
-	assert.Equal(t, 2, w.Reopens())
-}
-
-func TestArchiveWriter_ExpiryPrune(t *testing.T) {
-	t.Parallel()
-
-	path := filepath.Join(t.TempDir(), "archive-wh.db")
-	w := archive.NewExportArchiveWriter(
-		path, archiveTestLogger(), 0,
-	)
-
-	require.NoError(t, w.Open(0))
-
-	old := archive.ExportArchivedEvent{
-		EventID:    "old",
-		ArchivedAt: time.Now().Add(-2 * time.Hour),
-	}
-	fresh := archive.ExportArchivedEvent{
-		EventID:    "fresh",
-		ArchivedAt: time.Now(),
-	}
-
-	require.NoError(t, w.DB().Create(&old).Error)
-	require.NoError(t, w.DB().Create(&fresh).Error)
-
-	// Reopening with a one-hour expiry prunes the old row.
-	require.NoError(t, w.Reopen(time.Hour))
-
-	var got []archive.ExportArchivedEvent
-
-	require.NoError(t, w.DB().Find(&got).Error)
-	require.Len(t, got, 1)
-	assert.Equal(t, "fresh", got[0].EventID)
-}
-
-func TestParseArchiveExpiry(t *testing.T) {
-	t.Parallel()
-
-	cases := []struct {
-		name    string
-		in      string
-		want    time.Duration
-		wantErr bool
-	}{
-		{"empty", "", 0, false},
-		{"explicit never", "never", 0, false},
-		{"hour", "1h", time.Hour, false},
-		{"thirty days", "720h", 720 * time.Hour, false},
-		{"minutes", "30m", 30 * time.Minute, false},
-		{"unparseable", "nonsense", 0, true},
-		{"days are not a Go unit", "7d", 0, true},
-		{"zero duration", "0s", 0, true},
-		{"bare zero", "0", 0, true},
-		{"negative duration", "-5h", 0, true},
-	}
-
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			t.Parallel()
-
-			got, err := archive.ParseExpiry(tc.in)
-			if tc.wantErr {
-				require.Error(t, err)
-
-				return
-			}
-
-			require.NoError(t, err)
-			assert.Equal(t, tc.want, got)
-		})
-	}
-}
-
-// TestArchiveFileName pins the archive file name and the rules
-// that make a webhook or target name safe to put in it.
-func TestArchiveFileName(t *testing.T) {
-	t.Parallel()
-
-	const id = "3f2a1c9e-8d4b-4c1a-9e2f-0a1b2c3d4e5f"
-
-	cases := []struct {
-		name    string
-		webhook string
-		target  string
-		want    string
-	}{
-		{
-			"plain names", "orders", "archive",
-			"archive-orders-archive-" + id + ".db",
-		},
-		{
-			"lowercased", "Orders", "Main Archive",
-			"archive-orders-main-archive-" + id + ".db",
-		},
-		{
-			"a run of other characters is one dash",
-			`a  /\..b`, "c__--d",
-			"archive-a-b-c-d-" + id + ".db",
-		},
-		{
-			"no dash at either end", "  --orders!! ", "(archive)",
-			"archive-orders-archive-" + id + ".db",
-		},
-		{
-			"path separators", "../../etc/passwd", "a/b",
-			"archive-etc-passwd-a-b-" + id + ".db",
-		},
-		{
-			"letters outside ASCII are dropped",
-			"Bestellungen Größe", "café",
-			"archive-bestellungen-gr-e-caf-" + id + ".db",
-		},
-		{
-			"nothing left is unnamed", "", "!!!",
-			"archive-unnamed-unnamed-" + id + ".db",
-		},
-		{
-			"cut to 40 characters", strings.Repeat("a", 50), "x",
-			"archive-" + strings.Repeat("a", 40) + "-x-" + id + ".db",
-		},
-		{
-			"no dash left by the cut",
-			strings.Repeat("a", 39) + " b", "x",
-			"archive-" + strings.Repeat("a", 39) + "-x-" + id + ".db",
-		},
-	}
-
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			t.Parallel()
-
-			assert.Equal(
-				t, tc.want,
-				archive.FileName(tc.webhook, tc.target, id),
-			)
-		})
-	}
-}
-
-// TestWrite_EachTargetHasItsOwnArchive proves two
-// database targets of one webhook archive into separate files.
-func TestWrite_EachTargetHasItsOwnArchive(t *testing.T) {
-	t.Parallel()
-
-	env := setupArchiveTest(t)
-	first := env.seedDatabaseTarget(t, 0, "")
-	second := env.addDatabaseTarget(t, first.WebhookID, 0, "")
-
-	event := newEvent(`{"n":1}`)
-
-	for _, tgt := range []*database.Target{first, second} {
-		require.NoError(t, env.writers.Write(
-			databaseTargetDelivery(event, tgt),
-		))
-	}
-
-	require.NotEqual(
-		t, env.archivePath(first), env.archivePath(second),
-	)
-	assert.Equal(
-		t, []string{event.ID},
-		archivedEventIDs(t, env.archivePath(first)),
-	)
-	assert.Equal(
-		t, []string{event.ID},
-		archivedEventIDs(t, env.archivePath(second)),
-	)
-}
-
-// TestRename_MovesTheFile proves a rename moves the archive, rows
-// and all, and that later writes go to the new name.
-func TestRename_MovesTheFile(t *testing.T) {
-	t.Parallel()
-
-	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, "")
-	oldPath := env.archivePath(tgt)
-
-	first := newEvent(`{"n":1}`)
-	require.NoError(t, env.writers.Write(databaseTargetDelivery(first, tgt)))
-	require.FileExists(t, oldPath)
-
-	require.NoError(
-		t, env.writers.Rename(tgt.ID, "Orders", "Long Term"),
-	)
-
-	newPath := filepath.Join(
-		env.dataDir, "archive-orders-long-term-"+tgt.ID+".db",
-	)
-
-	assert.NoFileExists(t, oldPath)
-	assert.Equal(t, []string{first.ID}, archivedEventIDs(t, newPath))
-
-	second := newEvent(`{"n":2}`)
-	require.NoError(t, env.writers.Write(databaseTargetDelivery(second, tgt)))
-
-	assert.ElementsMatch(
-		t, []string{first.ID, second.ID},
-		archivedEventIDs(t, newPath),
-	)
-	assert.NoFileExists(
-		t, oldPath, "a write after the rename must use the new name",
-	)
-}
-
-// TestRename_NeverReplacesAFile plants a file at the new name, once
-// the .db alone, once a lone -wal and once a lone -shm, and proves
-// each time that the rename is refused, the planted file survives,
-// and the archive keeps its name and its rows.
-func TestRename_NeverReplacesAFile(t *testing.T) {
-	t.Parallel()
-
-	for _, suffix := range archiveFileSuffixes() {
-		t.Run("planted .db"+suffix, func(t *testing.T) {
-			t.Parallel()
-
-			env := setupArchiveTest(t)
-			tgt := env.seedDatabaseTarget(t, 0, "")
-			oldPath := env.archivePath(tgt)
-
-			first := newEvent(`{"n":1}`)
-			require.NoError(
-				t, env.writers.Write(databaseTargetDelivery(first, tgt)),
-			)
-
-			newPath := filepath.Join(
-				env.dataDir, "archive-orders-long-term-"+tgt.ID+".db",
-			)
-			plantedPath := newPath + suffix
-			require.NoError(
-				t, os.WriteFile(plantedPath, []byte("planted"), 0o600),
-			)
-
-			require.ErrorIs(
-				t, env.writers.Rename(tgt.ID, "Orders", "Long Term"),
-				archive.ErrNameTaken,
-			)
-
-			//nolint:gosec // reads the file the test planted under t.TempDir()
-			planted, err := os.ReadFile(plantedPath)
-			require.NoError(t, err)
-			assert.Equal(t, "planted", string(planted))
-
-			second := newEvent(`{"n":2}`)
-			require.NoError(
-				t, env.writers.Write(databaseTargetDelivery(second, tgt)),
-			)
-
-			assert.ElementsMatch(
-				t, []string{first.ID, second.ID},
-				archivedEventIDs(t, oldPath),
-			)
-		})
-	}
-}
-
-// TestRename_BeforeTheNameIsSaved covers the order the handlers
-// use: they rename before they save the new name, so a delivery in
-// between must write under the new name although the main database
-// still has the old one. It also shows that renaming an archive that
-// does not exist yet is not an error.
-func TestRename_BeforeTheNameIsSaved(t *testing.T) {
-	t.Parallel()
-
-	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, "")
-
-	require.NoError(
-		t, env.writers.Rename(tgt.ID, "Orders", "Archive"),
-	)
-
-	event := newEvent(`{"n":1}`)
-	require.NoError(t, env.writers.Write(databaseTargetDelivery(event, tgt)))
-
-	assert.FileExists(
-		t,
-		filepath.Join(
-			env.dataDir, "archive-orders-archive-"+tgt.ID+".db",
-		),
-	)
-	assert.NoFileExists(t, env.archivePath(tgt))
-}
-
-// TestArchiveWriter_RenameMovesSidecars proves a rename carries
-// the -wal and -shm a crash can leave beside an archive no handle
-// has opened since. SQLite finds them by name, so a -wal left
-// behind would lose the transactions it holds.
-func TestArchiveWriter_RenameMovesSidecars(t *testing.T) {
-	t.Parallel()
-
-	dir := t.TempDir()
-	oldPath := filepath.Join(dir, "archive-old.db")
-	newPath := filepath.Join(dir, "archive-new.db")
-
-	for _, suffix := range archiveFileSuffixes() {
-		require.NoError(
-			t, os.WriteFile(oldPath+suffix, []byte(suffix), 0o600),
-		)
-	}
-
-	w := archive.NewExportArchiveWriter(
-		oldPath, archiveTestLogger(), 0,
-	)
-
-	require.NoError(t, w.Rename("archive-new.db"))
-
-	for _, suffix := range archiveFileSuffixes() {
-		assert.NoFileExists(t, oldPath+suffix)
-		assert.FileExists(t, newPath+suffix)
-	}
-
-	assert.Equal(t, newPath, w.Path())
-}
-
-// TestArchiveWriter_RenameMovesBackOnFailure makes the -wal fail to
-// move after the .db has moved, and proves the .db is moved back, so
-// the archive is never split across two names. The new name is 255
-// bytes, the longest a file name may be, so the .db can take it but
-// the -wal, four bytes longer, cannot.
-func TestArchiveWriter_RenameMovesBackOnFailure(t *testing.T) {
-	t.Parallel()
-
-	dir := t.TempDir()
-	oldPath := filepath.Join(dir, "archive-old.db")
-	newName := strings.Repeat("a", 252) + ".db"
-
-	for _, suffix := range archiveFileSuffixes() {
-		require.NoError(
-			t, os.WriteFile(oldPath+suffix, []byte(suffix), 0o600),
-		)
-	}
-
-	w := archive.NewExportArchiveWriter(
-		oldPath, archiveTestLogger(), 0,
-	)
-
-	require.Error(t, w.Rename(newName))
-
-	for _, suffix := range archiveFileSuffixes() {
-		assert.FileExists(t, oldPath+suffix)
-	}
-
-	assert.NoFileExists(t, filepath.Join(dir, newName))
-	assert.Equal(t, oldPath, w.Path())
-}
-
-// TestArchiveWriter_RenameMovesBackEveryFile renames a target with a
-// file without a period and a file for a month, and proves that when
-// the month's file fails to move, the file already moved is moved back:
-// both files are under the old name with their rows, and nothing is
-// under the new name. The new name is 251 bytes, so the file without a
-// period, with its -wal and -shm, can take it, but the month's file,
-// eight bytes longer, cannot.
-func TestArchiveWriter_RenameMovesBackEveryFile(t *testing.T) {
-	t.Parallel()
-
-	dir := t.TempDir()
-	oldPath := filepath.Join(dir, "archive-old.db")
-	monthPath := filepath.Join(dir, "archive-old-2026-03.db")
-	w := archive.NewExportArchiveWriter(oldPath, archiveTestLogger(), 0)
-
-	require.NoError(t, w.WritePeriod(
-		archive.ExportArchivedEvent{EventID: "in-none"}, 0, "",
-	))
-	require.NoError(t, w.WritePeriod(
-		archive.ExportArchivedEvent{EventID: "in-month"}, 0, "2026-03",
-	))
-
-	require.Error(t, w.Rename(strings.Repeat("a", 248)+".db"))
-
-	assert.Equal(t, []string{"in-none"}, archivedEventIDs(t, oldPath))
-	assert.Equal(t, []string{"in-month"}, archivedEventIDs(t, monthPath))
-
-	entries, err := os.ReadDir(dir)
-	require.NoError(t, err)
-
-	for _, entry := range entries {
-		assert.True(t, strings.HasPrefix(entry.Name(), "archive-old"),
-			"%s is not under the old name", entry.Name())
-	}
-
-	assert.Equal(t, oldPath, w.Path())
-}
-
-// TestRenameLock_HeldByOneEditAtATime holds the rename lock, as an edit
-// does from loading the stored names until it has saved them. While it
-// is held, the edit's rename and an archive write still finish, since
-// neither takes it, and the event ends up under the new name whichever
-// ran first. A second edit waits for the lock until the first lets go.
-func TestRenameLock_HeldByOneEditAtATime(t *testing.T) {
-	t.Parallel()
-
-	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, "")
-	event := newEvent(`{"n":1}`)
-
-	env.writers.RenameLock().Lock()
-
-	finished := make(chan error, 2)
-
-	go func() {
-		finished <- env.writers.Rename(tgt.ID, "Orders", "Long Term")
-	}()
-	go func() {
-		finished <- env.writers.Write(databaseTargetDelivery(event, tgt))
-	}()
-
-	for range 2 {
-		select {
-		case err := <-finished:
-			require.NoError(t, err)
-		case <-time.After(10 * time.Second):
-			t.Fatal("a rename or a write waited for the rename lock")
-		}
-	}
-
-	newPath := filepath.Join(
-		env.dataDir, "archive-orders-long-term-"+tgt.ID+".db",
-	)
-	assert.Equal(t, []string{event.ID}, archivedEventIDs(t, newPath))
-
-	secondEdit := make(chan struct{})
-
-	go func() {
-		env.writers.RenameLock().Lock()
-		close(secondEdit)
-		env.writers.RenameLock().Unlock()
-	}()
-
-	select {
-	case <-secondEdit:
-		t.Fatal("a second edit took the rename lock while it was held")
-	case <-time.After(100 * time.Millisecond):
-	}
-
-	env.writers.RenameLock().Unlock()
-
-	select {
-	case <-secondEdit:
-	case <-time.After(10 * time.Second):
-		t.Fatal("a second edit did not get the rename lock once released")
-	}
-}

internal/archive/export_test.go

@@ -1,280 +0,0 @@
-package archive
-
-import (
-	"context"
-	"log/slog"
-	"time"
-
-	"go.uber.org/fx"
-	"gorm.io/gorm"
-	"sneak.berlin/go/webhooker/internal/database"
-)
-
-// ErrExportArchiveWriterEvicted exposes the sentinel returned by
-// an evicted archive writer. It carries the Err prefix rather
-// than this file's usual Export one because it is a sentinel
-// error.
-var ErrExportArchiveWriterEvicted = errArchiveWriterEvicted
-
-// ExportArchivedEvent aliases the archive row type so black-box
-// tests can construct and read archive rows.
-type ExportArchivedEvent = archivedEvent
-
-// ExportArchiveWriter wraps an archiveWriter so black-box tests
-// can exercise the archive file mechanics.
-type ExportArchiveWriter struct {
-	w *archiveWriter
-}
-
-// NewExportArchiveWriter builds an archive writer for tests,
-// optionally overriding the reopen debounce (a non-positive
-// debounce keeps the production default).
-func NewExportArchiveWriter(
-	path string, log *slog.Logger, debounce time.Duration,
-) *ExportArchiveWriter {
-	w := newArchiveWriter(path, log)
-	if debounce > 0 {
-		w.debounce = debounce
-	}
-
-	return &ExportArchiveWriter{w: w}
-}
-
-// Write archives a row through the writer, into the file named
-// without a period.
-func (e *ExportArchiveWriter) Write(
-	row ExportArchivedEvent, expiry time.Duration,
-) error {
-	return e.w.write(row, expiry, "")
-}
-
-// WritePeriod archives a row through the writer, into the file for
-// period.
-func (e *ExportArchiveWriter) WritePeriod(
-	row ExportArchivedEvent, expiry time.Duration, period string,
-) error {
-	return e.w.write(row, expiry, period)
-}
-
-// Open opens the archive file, pruning when expiry is positive.
-func (e *ExportArchiveWriter) Open(expiry time.Duration) error {
-	return e.w.open(e.w.path, expiry)
-}
-
-// Reopen closes and reopens the archive file.
-func (e *ExportArchiveWriter) Reopen(
-	expiry time.Duration,
-) error {
-	return e.w.reopen(e.w.path, expiry)
-}
-
-// SetNow replaces the clock the writer measures its reopen
-// debounce on.
-func (e *ExportArchiveWriter) SetNow(now func() time.Time) {
-	e.w.now = now
-}
-
-// Reopens reports how many times the file has been opened.
-func (e *ExportArchiveWriter) Reopens() int {
-	return e.w.reopens
-}
-
-// DB returns the writer's current open handle for row
-// inspection in tests.
-func (e *ExportArchiveWriter) DB() *gorm.DB {
-	return e.w.db
-}
-
-// Path returns the archive file the writer owns.
-func (e *ExportArchiveWriter) Path() string {
-	return e.w.path
-}
-
-// OpenExisting opens the archive without permitting creation,
-// the way the idle sweep does.
-func (e *ExportArchiveWriter) OpenExisting(
-	expiry time.Duration,
-) error {
-	return e.w.openMode(e.w.path, archiveModeExisting, expiry)
-}
-
-// SweepExpired runs an idle sweep of the archive.
-func (e *ExportArchiveWriter) SweepExpired(
-	expiry time.Duration,
-) error {
-	return e.w.sweepExpired(expiry)
-}
-
-// Evict marks the writer evicted and closes its handle, exactly
-// as leaving the registry does.
-func (e *ExportArchiveWriter) Evict() {
-	e.w.evict()
-}
-
-// Rename gives the archive file a new name in the same directory,
-// as a rename of the webhook or target does.
-func (e *ExportArchiveWriter) Rename(name string) error {
-	return e.w.rename(name)
-}
-
-// HandleOpen reports whether the writer currently holds an open
-// archive handle.
-func (e *ExportArchiveWriter) HandleOpen() bool {
-	e.w.mu.Lock()
-	defer e.w.mu.Unlock()
-
-	return e.w.db != nil
-}
-
-// Same reports whether both wrappers refer to the very same
-// underlying archive writer, so a test can prove a registry entry
-// is the writer it was handed rather than a replacement.
-func (e *ExportArchiveWriter) Same(
-	other *ExportArchiveWriter,
-) bool {
-	return other != nil && e.w == other.w
-}
-
-// ExportArchiveWriterFor returns the archive writer the registry
-// currently caches for a database target, or nil when none is
-// cached. It never creates one, so a test can hold a reference to
-// the very writer an eviction is about to detach.
-func (ws *Writers) ExportArchiveWriterFor(
-	targetID string,
-) *ExportArchiveWriter {
-	ws.mu.Lock()
-	defer ws.mu.Unlock()
-
-	w, ok := ws.writers[targetID]
-	if !ok {
-		return nil
-	}
-
-	return &ExportArchiveWriter{w: w}
-}
-
-// ExportHasArchiveWriter reports whether the registry currently
-// caches an archive writer for a target.
-func (ws *Writers) ExportHasArchiveWriter(
-	targetID string,
-) bool {
-	ws.mu.Lock()
-	defer ws.mu.Unlock()
-
-	_, ok := ws.writers[targetID]
-
-	return ok
-}
-
-// ExportArchiveHandleOpen reports whether the cached archive
-// writer for a target holds an open database handle. It
-// returns false when no writer is cached.
-func (ws *Writers) ExportArchiveHandleOpen(
-	targetID string,
-) bool {
-	ws.mu.Lock()
-	w, ok := ws.writers[targetID]
-	ws.mu.Unlock()
-
-	if !ok {
-		return false
-	}
-
-	w.mu.Lock()
-	defer w.mu.Unlock()
-
-	return w.db != nil
-}
-
-// ExportEnsureArchiveWriter creates (if needed) and returns the
-// archive file path of the cached writer for a target, so a
-// test can prime the registry the way a delivery would.
-func (ws *Writers) ExportEnsureArchiveWriter(
-	targetID string,
-) (string, error) {
-	w, err := ws.writerFor(targetID)
-	if err != nil {
-		return "", err
-	}
-
-	return w.path, nil
-}
-
-// ExportSweepWriterFor takes a target's registry writer exactly
-// as the idle sweep does, reporting whether the sweep had to
-// create the entry. It lets a test drive the registry through the
-// sweep's own entry point instead of choreographing goroutines.
-func (ws *Writers) ExportSweepWriterFor(
-	targetID string,
-) (*ExportArchiveWriter, bool, error) {
-	w, created, err := ws.sweepWriterFor(targetID)
-	if err != nil {
-		return nil, false, err
-	}
-
-	return &ExportArchiveWriter{w: w}, created, nil
-}
-
-// ExportReleaseSweepWriter releases a sweep-created registry entry
-// exactly as a finished sweep does.
-func (ws *Writers) ExportReleaseSweepWriter(
-	targetID string, w *ExportArchiveWriter,
-) {
-	ws.releaseSweepWriter(targetID, w.w)
-}
-
-// NewTestSweeper builds a Sweeper backed by the given main
-// database and archive writers, without the fx lifecycle.
-// Intended for tests.
-func NewTestSweeper(
-	db *database.Database,
-	writers *Writers,
-	log *slog.Logger,
-) *Sweeper {
-	return &Sweeper{
-		db:       db,
-		writers:  writers,
-		log:      log,
-		interval: time.Hour,
-	}
-}
-
-// ExportSweep runs a single archive sweep synchronously for
-// tests.
-func (s *Sweeper) ExportSweep(ctx context.Context) {
-	s.sweep(ctx)
-}
-
-// ExportStart starts the sweeper's background loop for tests.
-func (s *Sweeper) ExportStart() {
-	s.start()
-}
-
-// ExportRegisterHooks registers the sweeper's real fx lifecycle
-// hooks on a lifecycle supplied by a test, so a test can drive
-// the exact OnStart/OnStop functions the application runs and
-// hand OnStart the kind of context fx actually supplies.
-func (s *Sweeper) ExportRegisterHooks(lc fx.Lifecycle) {
-	s.registerHooks(lc)
-}
-
-// ExportStop stops the sweeper's background loop for tests.
-func (s *Sweeper) ExportStop(ctx context.Context) error {
-	return s.stop(ctx)
-}
-
-// ExportWedgeLoop adds a goroutine to the sweeper's WaitGroup
-// that never observes cancellation and returns only when release
-// is closed. It stands in for a prune stuck on a locked archive.
-func (s *Sweeper) ExportWedgeLoop(
-	release <-chan struct{},
-) {
-	s.wg.Go(func() {
-		<-release
-	})
-}
-
-// ExportSetInterval overrides the sweep interval for tests.
-func (s *Sweeper) ExportSetInterval(d time.Duration) {
-	s.interval = d
-}

internal/database/event_db_isolation_test.go

@@ -25,11 +25,10 @@ func TestEventDBCreateOmitsAssociations(t *testing.T) {
 	require.NoError(t, err)
 
 	target := database.Target{
-		WebhookID:   webhookID,
+		WebhookID: webhookID,
-		Name:        "leaky-target",
+		Name:      "leaky-target",
-		Type:        database.TargetTypeSlack,
+		Type:      database.TargetTypeSlack,
-		URL:         "https://hooks.example/secret",
+		Config:    `{"webhookUrl":"https://hooks.example/secret"}`,
-		MaxAttempts: 1,
 	}
 	target.ID = uuid.New().String()
 

internal/database/event_tier_indexes_test.go

@@ -79,9 +79,8 @@ func TestEventTierQueriesUseTheirIndexes(t *testing.T) {
 	byStatus := "idx_deliveries_status (status=? AND deleted_at=?)"
 	byEvent := "idx_deliveries_event_id (event_id=? AND deleted_at=?)"
 
-	// The delivery engine: the recovery routine, which reads the
+	// The delivery engine: recovery and the retry sweep, the sweep for
-	// retrying deliveries and, on a tick of the sweep, the pending ones
+	// stranded pending deliveries, and the queue depth count.
-	// untouched for a while; and the queue depth count.
 	assertPlanUses(t, db, dry.Where(
 		"status = ?", database.DeliveryStatusRetrying,
 	).Find(&deliveries), byStatus)

internal/database/model_event.go

@@ -45,7 +45,8 @@ type Event struct {
 
 	// ResubmittedFromID names the event this one was copied from by
 	// an operator resubmit. It is nil for an event that arrived on
-	// the receiver. It is not a foreign key: the source event can be
+	// the receiver, which is every event created before the column
+	// existed. It is not a foreign key: the source event can be
 	// reaped by retention while its copies remain, and the id is
 	// kept as the record of where the copy came from either way.
 	ResubmittedFromID *string `gorm:"type:uuid;index:idx_events_resubmitted_from_id,priority:1;index:idx_events_entrypoint_id,priority:3" json:"resubmittedFromId,omitempty"`

internal/database/model_parent_test.go

@@ -23,9 +23,8 @@ func TestPreloadedModelsMarshalWithoutTheirParent(t *testing.T) {
 		Name:        testWebhookName,
 		Entrypoints: []database.Entrypoint{{Path: uuid.New().String()}},
 		Targets: []database.Target{{
-			Name:        "log",
+			Name: "log",
-			Type:        database.TargetTypeLog,
+			Type: database.TargetTypeLog,
-			MaxAttempts: 1,
 		}},
 	}
 	require.NoError(t, db.Create(&stored).Error)

internal/database/model_secrets_test.go

@@ -29,10 +29,8 @@ func marshalModel(t *testing.T, v any) string {
 // these tags the first handler that marshals a model serialises the
 // secret with it. Each field below is a live credential:
 //
-//   - Target.URL is an incoming-webhook URL whose path segments are
+//   - Target.Config holds an incoming-webhook URL whose path segments
-//     the bearer token.
+//     are the bearer token.
-//   - Target.Headers holds header values, routinely authorization
-//     tokens.
 //   - APIKey.Key is a bearer token outright.
 //   - Setting.Value holds the session encryption key.
 //   - User.Password holds the Argon2 hash, and was already tagged.
@@ -46,21 +44,11 @@ func TestModelsDoNotMarshalTheirSecrets(t *testing.T) {
 		model any
 	}{
 		{
-			name: "target url",
+			name: "target config",
 			model: database.Target{
-				Name:        keptField,
+				Name:   keptField,
-				Type:        database.TargetTypeSlack,
+				Type:   database.TargetTypeSlack,
-				URL:         "https://h/s/" + marker,
+				Config: `{"webhookUrl":"https://h/s/` + marker + `"}`,
-				MaxAttempts: 1,
-			},
-		},
-		{
-			name: "target headers",
-			model: database.Target{
-				Name:        keptField,
-				Type:        database.TargetTypeHTTP,
-				Headers:     map[string]string{"Authorization": marker},
-				MaxAttempts: 1,
 			},
 		},
 		{
@@ -98,10 +86,10 @@ func TestModelsDoNotMarshalTheirSecrets(t *testing.T) {
 	}
 }
 
-// TestWebhookMarshalsNoTargetURL covers the nested case: a webhook
+// TestWebhookMarshalsNoTargetConfig covers the nested case: a webhook
 // marshalled with its targets preloaded must not carry the credential
 // through the association either.
-func TestWebhookMarshalsNoTargetURL(t *testing.T) {
+func TestWebhookMarshalsNoTargetConfig(t *testing.T) {
 	t.Parallel()
 
 	const marker = "QQNESTEDMARKERQQ"
@@ -109,9 +97,8 @@ func TestWebhookMarshalsNoTargetURL(t *testing.T) {
 	encoded := marshalModel(t, database.Webhook{
 		Name: keptField,
 		Targets: []database.Target{{
-			Name:        "slack",
+			Name:   "slack",
-			URL:         "https://h/s/" + marker,
+			Config: `{"webhookUrl":"https://h/s/` + marker + `"}`,
-			MaxAttempts: 1,
 		}},
 	})
 

internal/database/model_target.go

@@ -1,7 +1,5 @@
 package database
 
-import "time"
-
 // TargetType represents the type of delivery target
 type TargetType string
 
@@ -13,9 +11,7 @@ const (
 	TargetTypeSlack    TargetType = "slack"
 )
 
-// Target represents a delivery target for a webhook. Its settings
+// Target represents a delivery target for a webhook
-// are the fields from URL to ArchiveRotation; each type uses some of
-// them, and the ones a type does not use stay empty.
 type Target struct {
 	BaseModel
 
@@ -24,42 +20,18 @@ type Target struct {
 	Type      TargetType `gorm:"not null"           json:"type"`
 	Active    bool       `gorm:"default:true"       json:"active"`
 
-	// URL is where an http or slack target sends each event.
+	// Configuration fields (JSON stored based on type).
 	//
-	// json:"-" because the URL is the target's credential: a Slack
+	// json:"-" because the blob holds the target's credential — a
-	// incoming-webhook URL, or an http destination whose path segments
+	// Slack incoming-webhook URL, or an http destination whose path
-	// are the secret. delivery.TargetView is the masking barrier for
+	// segments are the secret. delivery.TargetView is the masking
-	// the HTML path; this tag is the barrier for any handler that
+	// barrier for the HTML path; this tag is the barrier for any
-	// marshals the model itself.
+	// handler that marshals the model itself.
-	URL string `json:"-"`
+	Config string `gorm:"type:text" json:"-"` // JSON configuration
 
-	// Headers is an http target's extra request headers, name to
+	// For HTTP targets (max_retries=0 means fire-and-forget,
-	// value, stored as JSON text. json:"-" for the same reason as URL:
+	// >0 enables retries with backoff)
-	// a header value is routinely an authorization token.
+	MaxRetries int `json:"maxRetries,omitempty"`
-	Headers map[string]string `gorm:"serializer:json" json:"-"`
-
-	// TimeoutSeconds is an http target's per-request timeout; 0 uses
-	// the delivery engine's shared client timeout.
-	TimeoutSeconds int `json:"timeoutSeconds,omitempty"`
-
-	// ForwardQuery passes each event's query string on to an http
-	// target, appended to URL. Off, URL is sent exactly as stored.
-	ForwardQuery bool `json:"forwardQuery,omitempty"`
-
-	// ArchiveExpiry is how long a database target keeps each archived
-	// event; 0 keeps them forever.
-	ArchiveExpiry time.Duration `json:"archiveExpiry,omitempty"`
-
-	// ArchiveRotation is how often a database target starts a new
-	// archive file: none, monthly, daily or hourly.
-	ArchiveRotation string `json:"archiveRotation,omitempty"`
-
-	// MaxAttempts is how many times an HTTP or Slack target attempts
-	// each delivery in all, at least 1. 1 is a single attempt with no
-	// circuit breaker; above 1, a failed attempt is retried with
-	// backoff behind the breaker. The table's check constraint refuses
-	// a target saved with less than 1, whatever its type.
-	MaxAttempts int `gorm:"not null;check:max_attempts >= 1" json:"maxAttempts,omitempty"`
 
 	// Relations. No model marshals the record it belongs to:
 	// Webhook.Targets leads back here, and the JSON could loop.

internal/database/model_target_test.go

@@ -1,63 +0,0 @@
-package database_test
-
-import (
-	"testing"
-
-	"github.com/google/uuid"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"sneak.berlin/go/webhooker/internal/database"
-)
-
-// newHTTPTarget returns an http target that makes maxAttempts attempts
-// at each delivery.
-func newHTTPTarget(maxAttempts int) *database.Target {
-	return &database.Target{
-		WebhookID:   uuid.New().String(),
-		Name:        "target",
-		Type:        database.TargetTypeHTTP,
-		URL:         "https://example.com/",
-		MaxAttempts: maxAttempts,
-	}
-}
-
-// TestTargetCreate_RefusesZeroAttempts relies on the targets table
-// alone: nothing in the model checks the number, so the check
-// constraint is what keeps a target with 0 attempts out of the
-// database.
-func TestTargetCreate_RefusesZeroAttempts(t *testing.T) {
-	t.Parallel()
-
-	db := startedTestDB(t)
-
-	err := db.Create(newHTTPTarget(0)).Error
-	require.Error(t, err)
-	assert.Contains(t, err.Error(), "CHECK constraint failed")
-}
-
-func TestTargetCreate_AcceptsOneAttempt(t *testing.T) {
-	t.Parallel()
-
-	db := startedTestDB(t)
-
-	require.NoError(t, db.Create(newHTTPTarget(1)).Error)
-}
-
-// TestTargetHeaders_StoredAsJSON reads the headers column back as
-// text, to show it holds the header map as JSON.
-func TestTargetHeaders_StoredAsJSON(t *testing.T) {
-	t.Parallel()
-
-	db := startedTestDB(t)
-
-	target := newHTTPTarget(1)
-	target.Headers = map[string]string{"Authorization": "Bearer x"}
-	require.NoError(t, db.Create(target).Error)
-
-	var headers string
-
-	require.NoError(t, db.Raw(
-		"SELECT headers FROM targets WHERE id = ?", target.ID,
-	).Scan(&headers).Error)
-	assert.JSONEq(t, `{"Authorization":"Bearer x"}`, headers)
-}

internal/database/model_webhook.go

@@ -4,13 +4,27 @@ import (
 	"math"
 	"strconv"
 	"time"
+
+	"gorm.io/gorm"
 )
 
 const (
-	// DefaultRetentionDays is the event retention period the new
+	// DefaultRetentionDays is the event retention period applied to a
-	// webhook form applies when its retention field is left blank.
+	// webhook created without an explicit retention value. It is the
+	// single source of truth for that policy and must stay in sync
+	// with the `gorm:"default:30"` column default on
+	// Webhook.RetentionDays below; a struct tag cannot reference a
+	// constant, so a test asserts the two agree.
 	DefaultRetentionDays = 30
 
+	// RetentionForeverDays is the sentinel RetentionDays value meaning
+	// "retain events forever". Users express that intent as 0, which
+	// Webhook.BeforeSave rewrites to this value: the column default
+	// substitutes DefaultRetentionDays for a zero value at insert
+	// time, so a zero can never survive a round trip to the database.
+	// Nothing outside this file may hardcode the number.
+	RetentionForeverDays = 365 * 1000
+
 	// MaxFiniteRetentionDays is the largest finite retention period the
 	// reaper's cutoff arithmetic can represent, and therefore the
 	// largest one a caller may request. It is derived from that
@@ -24,7 +38,9 @@ const (
 	// turns the cutoff into a timestamp in the far future that matches
 	// every row in the webhook's database. That is why this bound is
 	// enforced on input and why retentionCutoff saturates underneath
-	// it.
+	// it. Note that RetentionForeverDays deliberately sits above this
+	// ceiling: such webhooks are skipped before any cutoff is
+	// computed, and never reach the arithmetic at all.
 	MaxFiniteRetentionDays = int(
 		math.MaxInt64 / int64(time.Hour) / hoursPerDay,
 	)
@@ -32,10 +48,12 @@ const (
 
 // Webhook represents a webhook processing unit that groups entrypoints and targets
 //
-// Every method below takes a pointer receiver, so handlers put a
+// Every method below takes a pointer receiver. BeforeSave has to,
-// *Webhook into template data: html/template cannot call a pointer
+// because it mutates the record and GORM only invokes hooks declared
-// method on a value held in a map, because a map element is not
+// that way; the display helpers follow suit so the receiver kinds do
-// addressable.
+// not mix. Handlers therefore put a *Webhook into template data:
+// html/template cannot call a pointer method on a value held in a map,
+// because a map element is not addressable.
 type Webhook struct {
 	BaseModel
 
@@ -43,9 +61,10 @@ type Webhook struct {
 	Name        string `gorm:"not null"           json:"name"`
 	Description string `json:"description"`
 
-	// RetentionDays is the number of days to retain events, and 0
+	// RetentionDays is the number of days to retain events. A value of
-	// means retain them forever.
+	// RetentionForeverDays means retain forever. The column default
-	RetentionDays int `json:"retentionDays"`
+	// must equal DefaultRetentionDays.
+	RetentionDays int `gorm:"default:30" json:"retentionDays"`
 
 	// Relations. No model marshals the record it belongs to:
 	// User.Webhooks leads back here, and the JSON could loop.
@@ -54,17 +73,36 @@ type Webhook struct {
 	Targets     []Target     `json:"targets,omitempty"`
 }
 
-// retainsForever reports whether a RetentionDays value means "keep
+// BeforeSave normalises RetentionDays on every insert and update. A
-// events indefinitely", which 0 does. It is the single definition of
+// non-positive value is the user's way of asking for "retain forever",
-// that question, shared by Webhook.RetainsForever and by the reaper's
+// which is stored as the RetentionForeverDays sentinel.
+//
+// This has to happen in a hook rather than at the call sites. GORM
+// substitutes the column default (DefaultRetentionDays) for a zero
+// value while building the insert statement, which runs after
+// BeforeSave; rewriting any later than this loses that race and the
+// row lands at 30 days. Living on the model also means a future call
+// site — a REST API, a fixture, a migration — cannot bypass it.
+func (w *Webhook) BeforeSave(_ *gorm.DB) error {
+	if w.RetentionDays <= 0 {
+		w.RetentionDays = RetentionForeverDays
+	}
+
+	return nil
+}
+
+// retainsForever reports whether a stored RetentionDays value means
+// "keep events indefinitely". It is the single definition of that
+// question, shared by Webhook.RetainsForever and by the reaper's
 // cutoff computation so the two cannot disagree about which webhooks
 // are exempt from reaping.
 //
-// A negative value, which the forms refuse, is read the same way: as a
+// It accepts the RetentionForeverDays sentinel written by BeforeSave
-// day count it would put the cutoff in the future, where it matches
+// and, defensively, the non-positive values that rows written before
-// every event the webhook has.
+// the sentinel existed may still carry.
 func retainsForever(retentionDays int) bool {
-	return retentionDays <= 0
+	return retentionDays <= 0 ||
+		retentionDays >= RetentionForeverDays
 }
 
 // RetainsForever reports whether this webhook's events are kept
@@ -81,8 +119,7 @@ func (w *Webhook) RetentionCutoff(now time.Time) (time.Time, bool) {
 }
 
 // RetentionLabel returns the webhook's retention policy as display
-// text: "forever" rather than "0 days" for a webhook that keeps its
+// text, so that no template has to know about the sentinel value.
-// events.
 func (w *Webhook) RetentionLabel() string {
 	if w.RetainsForever() {
 		return "forever"

internal/database/model_webhook_test.go

@@ -2,6 +2,8 @@ package database_test
 
 import (
 	"context"
+	"reflect"
+	"strconv"
 	"testing"
 	"time"
 
@@ -45,7 +47,8 @@ func storedRetention(t *testing.T, db *gorm.DB, id string) int {
 }
 
 // newWebhookWithRetention creates a webhook through the ordinary Create
-// path, as the new webhook form does.
+// path, so the BeforeSave hook and the GORM column default both apply
+// exactly as they do in production.
 func newWebhookWithRetention(
 	t *testing.T,
 	db *gorm.DB,
@@ -64,7 +67,7 @@ func newWebhookWithRetention(
 	return wh.ID
 }
 
-func TestWebhookRetentionDays_ZeroIsStoredAsZero(t *testing.T) {
+func TestWebhookBeforeSave_ZeroBecomesForeverSentinel(t *testing.T) {
 	t.Parallel()
 
 	db := startedTestDB(t)
@@ -72,10 +75,31 @@ func TestWebhookRetentionDays_ZeroIsStoredAsZero(t *testing.T) {
 	wh := &database.Webhook{RetentionDays: 0}
 	id := newWebhookWithRetention(t, db, wh)
 
-	assert.Equal(t, 0, storedRetention(t, db, id))
+	assert.Equal(
+		t,
+		database.RetentionForeverDays,
+		storedRetention(t, db, id),
+		"a zero retention must be stored as the sentinel, "+
+			"not replaced by the column default",
+	)
 }
 
-func TestWebhookRetentionDays_DayCountIsStored(t *testing.T) {
+func TestWebhookBeforeSave_NegativeBecomesForeverSentinel(t *testing.T) {
+	t.Parallel()
+
+	db := startedTestDB(t)
+
+	wh := &database.Webhook{RetentionDays: -5}
+	id := newWebhookWithRetention(t, db, wh)
+
+	assert.Equal(
+		t,
+		database.RetentionForeverDays,
+		storedRetention(t, db, id),
+	)
+}
+
+func TestWebhookBeforeSave_PositiveIsPreserved(t *testing.T) {
 	t.Parallel()
 
 	db := startedTestDB(t)
@@ -86,9 +110,10 @@ func TestWebhookRetentionDays_DayCountIsStored(t *testing.T) {
 	assert.Equal(t, 7, storedRetention(t, db, id))
 }
 
-// TestWebhookRetentionDays_UpdateToZeroIsStoredAsZero changes a day
+// TestWebhookBeforeSave_UpdateToZeroBecomesSentinel proves the hook
-// count to 0 through the same Save call the edit handler makes.
+// fires on update as well as insert, via the same Save call the edit
-func TestWebhookRetentionDays_UpdateToZeroIsStoredAsZero(t *testing.T) {
+// handler makes.
+func TestWebhookBeforeSave_UpdateToZeroBecomesSentinel(t *testing.T) {
 	t.Parallel()
 
 	db := startedTestDB(t)
@@ -100,7 +125,28 @@ func TestWebhookRetentionDays_UpdateToZeroIsStoredAsZero(t *testing.T) {
 	wh.RetentionDays = 0
 	require.NoError(t, db.Omit(clause.Associations).Save(wh).Error)
 
-	assert.Equal(t, 0, storedRetention(t, db, id))
+	assert.Equal(
+		t,
+		database.RetentionForeverDays,
+		storedRetention(t, db, id),
+	)
+}
+
+// TestWebhookRetentionColumnDefaultMatchesConstant guards the one place
+// the default lives twice: a struct tag cannot reference a constant, so
+// this asserts the tag and DefaultRetentionDays agree.
+func TestWebhookRetentionColumnDefaultMatchesConstant(t *testing.T) {
+	t.Parallel()
+
+	field, ok := reflect.TypeFor[database.Webhook]().
+		FieldByName("RetentionDays")
+	require.True(t, ok, "Webhook.RetentionDays must exist")
+
+	assert.Equal(
+		t,
+		"default:"+strconv.Itoa(database.DefaultRetentionDays),
+		field.Tag.Get("gorm"),
+	)
 }
 
 // TestMaxFiniteRetentionDaysIsTheOverflowCeiling asserts that the
@@ -130,6 +176,14 @@ func TestMaxFiniteRetentionDaysIsTheOverflowCeiling(t *testing.T) {
 		time.Duration(overCeiling*hoursPerDay)*time.Hour,
 		"one day past the ceiling must overflow",
 	)
+
+	assert.Less(
+		t,
+		database.MaxFiniteRetentionDays,
+		database.RetentionForeverDays,
+		"the sentinel sits above the ceiling and is only safe "+
+			"because retain-forever webhooks skip the arithmetic",
+	)
 }
 
 func TestWebhookRetainsForeverAndLabel(t *testing.T) {
@@ -141,8 +195,16 @@ func TestWebhookRetainsForeverAndLabel(t *testing.T) {
 		forever bool
 		label   string
 	}{
-		{"zero", 0, true, testForeverLabel},
+		{
-		{"negative", -1, true, testForeverLabel},
+			"sentinel",
+			database.RetentionForeverDays, true, testForeverLabel,
+		},
+		{
+			"above sentinel",
+			database.RetentionForeverDays + 1, true, testForeverLabel,
+		},
+		{"legacy zero", 0, true, testForeverLabel},
+		{"legacy negative", -1, true, testForeverLabel},
 		{"default", database.DefaultRetentionDays, false, "30 days"},
 		{"one day", 1, false, "1 day"},
 	}

internal/database/retention.go

@@ -184,9 +184,8 @@ func (r *RetentionReaper) sweep(ctx context.Context) {
 
 		wh := webhooks[i]
 
-		// A missing database has nothing to reap. The delivery
+		// A missing database has nothing to reap. Restart recovery
-		// engine's recovery routine reports a lost one at start (see
+		// reports a lost one (see WebhookDBManager.GetDB).
-		// WebhookDBManager.GetDB).
 		if !r.dbManager.DBExists(wh.ID) {
 			continue
 		}
@@ -244,8 +243,7 @@ func (r *RetentionReaper) reapWebhook(
 
 // retentionCutoff returns the timestamp before which a webhook's
 // events have expired, and whether any cutoff applies at all. It
-// reports false for a retention of 0, which means retain forever, so
+// reports false for a retain-forever policy, so no DELETE is issued.
-// no DELETE is issued.
 //
 // The day count is clamped to MaxFiniteRetentionDays first. This is
 // defense in depth rather than decoration: a time.Duration is an int64
@@ -255,7 +253,7 @@ func (r *RetentionReaper) reapWebhook(
 // row in the database: the sweep then deletes every event, delivery,
 // and delivery result, including ones created seconds ago. Rejecting
 // out-of-range input at the form is the primary guard; saturating here
-// means a value that reaches the row by any other path cannot turn a
+// means an old row, a migration, or a future call site cannot turn a
 // too-large retention into total data loss.
 func retentionCutoff(
 	now time.Time,

internal/database/retention_test.go

@@ -85,6 +85,41 @@ func createWebhook(
 		db.Omit(clause.Associations).Create(wh).Error,
 	)
 
+	// Webhook.BeforeSave rewrites a non-positive RetentionDays to the
+	// retain-forever sentinel, and the column's GORM default would
+	// otherwise substitute 30. Force the requested value with a
+	// column-level update so tests can plant legacy rows that predate
+	// the sentinel and still carry a literal 0 or negative value.
+	require.NoError(
+		t,
+		db.Model(wh).
+			Update("retention_days", retentionDays).Error,
+	)
+
+	return wh.ID
+}
+
+// createWebhookNormally inserts a webhook through the ordinary Create
+// path, with no column-level forcing, so Webhook.BeforeSave applies
+// exactly as it does in production. Passing 0 therefore yields a row
+// holding the RetentionForeverDays sentinel.
+func createWebhookNormally(
+	t *testing.T,
+	db *gorm.DB,
+	retentionDays int,
+) string {
+	t.Helper()
+
+	wh := &database.Webhook{
+		UserID:        uuid.New().String(),
+		Name:          testWebhookName,
+		RetentionDays: retentionDays,
+	}
+	require.NoError(
+		t,
+		db.Omit(clause.Associations).Create(wh).Error,
+	)
+
 	return wh.ID
 }
 
@@ -246,19 +281,19 @@ func TestRetentionReaper_ReapsExpiredKeepsRecent(t *testing.T) {
 	assertChainPresent(t, db, recent)
 }
 
-// TestRetentionReaper_SkipsZeroReapsFiniteInSameSweep covers the
+// TestRetentionReaper_SkipsSentinelReapsFiniteInSameSweep covers the
-// end-to-end retain-forever path: a webhook created with a retention
+// end-to-end retain-forever path: a webhook created the normal way with
-// of 0 reads back 0, and the reaper leaves its ancient events alone
+// a requested retention of 0 lands on the RetentionForeverDays
-// while still reaping a finite-retention webhook in the very same
+// sentinel, and the reaper leaves its ancient events alone while still
-// sweep.
+// reaping a finite-retention webhook in the very same sweep.
-func TestRetentionReaper_SkipsZeroReapsFiniteInSameSweep(
+func TestRetentionReaper_SkipsSentinelReapsFiniteInSameSweep(
 	t *testing.T,
 ) {
 	t.Parallel()
 
 	env := setupRetentionTest(t)
 
-	foreverID := createWebhook(t, env.mainDB.DB(), 0)
+	foreverID := createWebhookNormally(t, env.mainDB.DB(), 0)
 
 	var stored database.Webhook
 
@@ -267,12 +302,14 @@ func TestRetentionReaper_SkipsZeroReapsFiniteInSameSweep(
 		env.mainDB.DB().Where("id = ?", foreverID).
 			First(&stored).Error,
 	)
-	require.Zero(
+	require.Equal(
-		t, stored.RetentionDays,
+		t,
-		"a retention of 0 must be stored as 0",
+		database.RetentionForeverDays,
+		stored.RetentionDays,
+		"a requested retention of 0 must persist as the sentinel",
 	)
 
-	finiteID := createWebhook(t, env.mainDB.DB(), 30)
+	finiteID := createWebhookNormally(t, env.mainDB.DB(), 30)
 
 	foreverDB, err := env.mgr.GetDB(foreverID)
 	require.NoError(t, err)
@@ -298,10 +335,14 @@ func TestRetentionReaper_SkipsZeroReapsFiniteInSameSweep(
 // negative, so subtracting it moves the cutoff into the far future,
 // where "created_at < cutoff" matches every row: an event created a
 // moment ago, and its delivery and delivery result, were all deleted
-// on the first sweep. 200000 is inside that band.
+// on the first sweep. 200000 is inside that band and below the
+// retain-forever sentinel, so it is treated as a finite policy and
+// really does reach the arithmetic.
 //
-// The form refuses such a value; the point of the test is that a row
+// The row is planted at the column level because such a value can no
-// written by any other path still cannot trigger the wipe.
+// longer be submitted through the form; the point of the test is that
+// a row from an older version, or a future call site, still cannot
+// trigger the wipe.
 func TestRetentionReaper_HugeFiniteRetentionRetainsRecentEvents(
 	t *testing.T,
 ) {
@@ -317,6 +358,12 @@ func TestRetentionReaper_HugeFiniteRetentionRetainsRecentEvents(
 		database.MaxFiniteRetentionDays,
 		"the test value must exceed what the cutoff can represent",
 	)
+	require.Less(
+		t,
+		overflowingRetentionDays,
+		database.RetentionForeverDays,
+		"the test value must not be treated as retain-forever",
+	)
 
 	webhookID := createWebhook(
 		t, env.mainDB.DB(), overflowingRetentionDays,
@@ -332,15 +379,14 @@ func TestRetentionReaper_HugeFiniteRetentionRetainsRecentEvents(
 	assertChainPresent(t, db, fresh)
 }
 
-// TestRetentionReaper_RetainsForeverWhenNegative checks that a negative
+func TestRetentionReaper_RetainsForeverWhenNonPositive(t *testing.T) {
-// retention, which the forms refuse, keeps every event rather than
-// putting the cutoff in the future, where it would match them all.
-func TestRetentionReaper_RetainsForeverWhenNegative(t *testing.T) {
 	t.Parallel()
 
 	env := setupRetentionTest(t)
 
-	webhookID := createWebhook(t, env.mainDB.DB(), -1)
+	// A legacy row written before the sentinel existed still carries a
+	// literal 0; the <= 0 guard must keep honouring it.
+	webhookID := createWebhook(t, env.mainDB.DB(), 0)
 
 	db, err := env.mgr.GetDB(webhookID)
 	require.NoError(t, err)

internal/database/schema_test.go

@@ -87,18 +87,13 @@ func TestMainSchemaHoldsEveryModel(t *testing.T) {
 		Active:      true,
 	})
 	assertRoundTrip(t, db, &database.Target{
-		BaseModel:       newBaseModel(),
+		BaseModel:  newBaseModel(),
-		WebhookID:       uuid.New().String(),
+		WebhookID:  uuid.New().String(),
-		Name:            "target",
+		Name:       "target",
-		Type:            database.TargetTypeHTTP,
+		Type:       database.TargetTypeHTTP,
-		Active:          true,
+		Active:     true,
-		URL:             "https://example.com/",
+		Config:     `{"url":"https://example.com/"}`,
-		Headers:         map[string]string{"X-Api-Key": "key"},
+		MaxRetries: 3,
-		TimeoutSeconds:  30,
-		ForwardQuery:    true,
-		ArchiveExpiry:   720 * time.Hour,
-		ArchiveRotation: "daily",
-		MaxAttempts:     3,
 	})
 }
 

internal/database/sqlite_mode_test.go

@@ -137,7 +137,7 @@ func TestPerWebhookEventDatabaseFilesAreOwnerOnly(t *testing.T) {
 }
 
 // TestArchiveDatabaseFilesAreOwnerOnly covers the archive-*.db tier.
-// internal/archive builds that path and opens it through OpenSQLite,
+// internal/delivery builds that path and opens it through OpenSQLite,
 // the same single open path exercised here, so the mode is settled for
 // all three tiers in one place.
 func TestArchiveDatabaseFilesAreOwnerOnly(t *testing.T) {

internal/database/sqlite_open.go

@@ -118,8 +118,9 @@ const SQLiteFilePerm fs.FileMode = 0o600
 // SQLite still reports the absence rather than this function
 // materializing an empty database the caller asked not to create.
 //
-// The mode is set on every open, whoever created the file, so a
+// Chmod of a file that already exists is what tightens a data
-// database or sidecar found at a wider mode is tightened too.
+// directory an earlier build left at 0644 — including a developer's
+// own scratch directory — without any migration machinery.
 func reserveSQLiteFile(path string, create bool) error {
 	if create {
 		// gosec G304: the path is the database file the caller asked

internal/db/migrations/archive/001_schema.sql

@@ -1,5 +1,5 @@
 -- Migration 001: the schema of a database target's archive file. The
--- archivedEvent model in internal/archive must agree with it.
+-- archivedEvent model in internal/delivery must agree with it.
 
 CREATE TABLE archived_events (
     id integer PRIMARY KEY AUTOINCREMENT,

internal/db/migrations/main/001_schema.sql

@@ -46,7 +46,7 @@ CREATE TABLE webhooks (
     user_id uuid NOT NULL,
     name text NOT NULL,
     description text,
-    retention_days integer,
+    retention_days integer DEFAULT 30,
     PRIMARY KEY (id),
     CONSTRAINT fk_users_webhooks FOREIGN KEY (user_id) REFERENCES users (id)
 );
@@ -79,17 +79,11 @@ CREATE TABLE targets (
     name text NOT NULL,
     type text NOT NULL,
     active numeric DEFAULT true,
-    url text,
+    config text,
-    headers text,
+    max_retries integer,
-    timeout_seconds integer,
-    forward_query numeric,
-    archive_expiry integer,
-    archive_rotation text,
-    max_attempts integer NOT NULL,
     PRIMARY KEY (id),
     CONSTRAINT fk_webhooks_targets
-        FOREIGN KEY (webhook_id) REFERENCES webhooks (id),
+        FOREIGN KEY (webhook_id) REFERENCES webhooks (id)
-    CONSTRAINT chk_targets_max_attempts CHECK (max_attempts >= 1)
 );
 
 CREATE INDEX idx_targets_deleted_at ON targets (deleted_at);

internal/delivery/archive_sweeper.go

@@ -1,4 +1,4 @@
-package archive
+package delivery
 
 import (
 	"context"
@@ -15,18 +15,18 @@ import (
 	"sneak.berlin/go/webhooker/internal/logger"
 )
 
-// SweeperParams holds the fx dependencies for the
+// ArchiveSweeperParams holds the fx dependencies for the
-// Sweeper.
+// ArchiveSweeper.
-type SweeperParams struct {
+type ArchiveSweeperParams struct {
 	fx.In
 
 	Config   *config.Config
 	Database *database.Database
-	Writers  *Writers
+	Engine   *Engine
 	Logger   *logger.Logger
 }
 
-// Sweeper periodically prunes expired rows from the
+// ArchiveSweeper periodically prunes expired rows from the
 // archive databases of database targets that carry a positive
 // expiry.
 //
@@ -40,9 +40,9 @@ type SweeperParams struct {
 // It reuses Config.RetentionSweepInterval rather than
 // introducing a second interval: this is a retention sweep with
 // the same semantics as the event retention reaper.
-type Sweeper struct {
+type ArchiveSweeper struct {
 	db       *database.Database
-	writers  *Writers
+	eng      *Engine
 	log      *slog.Logger
 	interval time.Duration
 
@@ -54,16 +54,16 @@ type Sweeper struct {
 	wg sync.WaitGroup
 }
 
-// NewSweeper creates the archive sweeper and registers
+// NewArchiveSweeper creates the archive sweeper and registers
 // its fx lifecycle hooks. The background sweep loop starts on
 // OnStart and stops cleanly on OnStop via context cancellation.
-func NewSweeper(
+func NewArchiveSweeper(
 	lc fx.Lifecycle,
-	params SweeperParams,
+	params ArchiveSweeperParams,
-) *Sweeper {
+) *ArchiveSweeper {
-	s := &Sweeper{
+	s := &ArchiveSweeper{
 		db:       params.Database,
-		writers:  params.Writers,
+		eng:      params.Engine,
 		log:      params.Logger.Get(),
 		interval: params.Config.RetentionSweepInterval,
 	}
@@ -77,7 +77,7 @@ func NewSweeper(
 // lifecycle. The start hook's context is deliberately ignored
 // (see start for why the background loop must not inherit it);
 // the stop hook's context is honoured (see stop).
-func (s *Sweeper) registerHooks(lc fx.Lifecycle) {
+func (s *ArchiveSweeper) registerHooks(lc fx.Lifecycle) {
 	lc.Append(fx.Hook{
 		//nolint:contextcheck // Not passing the hook context is
 		// the point: see start.
@@ -103,7 +103,7 @@ func (s *Sweeper) registerHooks(lc fx.Lifecycle) {
 // goroutine must outlive the startup phase, so its lifetime is
 // bounded by OnStop instead: stop cancels this context and waits
 // on the WaitGroup.
-func (s *Sweeper) start() {
+func (s *ArchiveSweeper) start() {
 	ctx, cancel := context.WithCancel(context.Background())
 	s.cancel = cancel
 
@@ -121,7 +121,7 @@ func (s *Sweeper) start() {
 // exit, bounded by the stop hook's context: a prune wedged on a
 // locked archive must not hang the process past fx's stop
 // timeout.
-func (s *Sweeper) stop(ctx context.Context) error {
+func (s *ArchiveSweeper) stop(ctx context.Context) error {
 	s.log.Info("archive sweeper stopping")
 
 	if s.cancel != nil {
@@ -140,7 +140,7 @@ func (s *Sweeper) stop(ctx context.Context) error {
 	return nil
 }
 
-func (s *Sweeper) run(ctx context.Context) {
+func (s *ArchiveSweeper) run(ctx context.Context) {
 	defer s.wg.Done()
 
 	ticker := time.NewTicker(s.interval)
@@ -164,7 +164,7 @@ func (s *Sweeper) run(ctx context.Context) {
 // A failure for one target is logged and the sweep continues,
 // matching how the write path already treats a prune error as
 // non-fatal.
-func (s *Sweeper) sweep(ctx context.Context) {
+func (s *ArchiveSweeper) sweep(ctx context.Context) {
 	var targets []database.Target
 
 	err := s.db.DB().
@@ -199,20 +199,32 @@ func (s *Sweeper) sweep(ctx context.Context) {
 	}
 }
 
-// sweepTarget prunes the archive of a single database target. A
+// sweepTarget prunes the archive of a single database target.
-// target with an ArchiveExpiry of 0 keeps its archive forever and is
+// A missing, empty, or "never" expiry parses as a zero duration
-// skipped entirely, so that archive is never pruned.
+// and is skipped entirely, so those archives keep exactly the
-func (s *Sweeper) sweepTarget(target *database.Target) {
+// behaviour they had before the sweep existed.
-	expiry := target.ArchiveExpiry
+func (s *ArchiveSweeper) sweepTarget(target *database.Target) {
+	expiry, err := parseArchiveExpiry(target.Config)
+	if err != nil {
+		s.log.Error(
+			"archive sweep: invalid database target config",
+			"webhook_id", target.WebhookID,
+			"target_id", target.ID,
+			"error", err,
+		)
+
+		return
+	}
+
 	if expiry <= 0 {
 		return
 	}
 
-	if s.writers == nil {
+	if s.eng == nil || s.eng.dbTarget == nil {
 		return
 	}
 
-	err := s.writers.sweepArchive(target.ID, expiry)
+	err = s.eng.dbTarget.sweepArchive(target.ID, expiry)
 	if err == nil {
 		return
 	}

internal/delivery/archive_sweeper_test.go

@@ -1,4 +1,4 @@
-package archive_test
+package delivery_test
 
 import (
 	"bytes"
@@ -16,15 +16,14 @@ import (
 	"github.com/google/uuid"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/fx"
 	"gorm.io/driver/sqlite"
 	"gorm.io/gorm"
 	"gorm.io/gorm/clause"
 	_ "modernc.org/sqlite" // Pure Go SQLite driver.
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
 	"sneak.berlin/go/webhooker/internal/database/databasetest"
 	"sneak.berlin/go/webhooker/internal/db/migrations"
+	"sneak.berlin/go/webhooker/internal/delivery"
 	"sneak.berlin/go/webhooker/internal/gormlog"
 )
 
@@ -38,18 +37,6 @@ const (
 	// sweepConcurrentWrites is how many deliveries the
 	// concurrent write-plus-sweep test races against the sweep.
 	sweepConcurrentWrites = 20
-
-	// hookStopTimeout bounds how long a lifecycle test waits for
-	// the sweeper's OnStop hook to return before declaring the
-	// shutdown hung.
-	hookStopTimeout = 10 * time.Second
-
-	// wedgeStopTimeout is the stop timeout a wedged-shutdown test
-	// hands OnStop, standing in for fx's StopTimeout. The test
-	// asserts only that the hook returns at all, and allows it
-	// hookStopTimeout — forty times this budget — to do so, so no
-	// assertion here races the wall clock.
-	wedgeStopTimeout = 250 * time.Millisecond
 )
 
 // archiveTestWebhookName is the name of every webhook
@@ -58,12 +45,12 @@ const (
 const archiveTestWebhookName = "Sweep Test!"
 
 // archiveEnv bundles the pieces an archive test drives: a main
-// configuration database holding webhooks and targets, the archive
+// configuration database holding webhooks and targets, a delivery
-// writers, the archive sweeper, and the data directory the archive
+// engine owning the archive writer registry, the archive sweeper,
-// files live in.
+// and the data directory the archive files live in.
 type archiveEnv struct {
-	sweeper *archive.Sweeper
+	sweeper *delivery.ArchiveSweeper
-	writers *archive.Writers
+	eng     *delivery.Engine
 	mainDB  *database.Database
 	dataDir string
 }
@@ -79,37 +66,39 @@ func setupArchiveTest(t *testing.T) *archiveEnv {
 
 	t.Cleanup(func() { _ = mainDB.Close() })
 
-	writers := archive.NewWriters(archive.WritersParams{
+	eng := delivery.NewTestEngineWithDB(
-		Database:  mainDB,
+		mainDB,
-		DBManager: databasetest.NewWebhookDBManager(t, dataDir),
+		databasetest.NewWebhookDBManager(t, dataDir),
-		Logger:    log,
+		log,
-	})
+		&http.Client{Timeout: 5 * time.Second},
+		1,
+	)
 
 	return &archiveEnv{
-		sweeper: archive.NewTestSweeper(
+		sweeper: delivery.NewTestArchiveSweeper(
-			mainDB, writers, log,
+			mainDB, eng, log,
 		),
-		writers: writers,
+		eng:     eng,
 		mainDB:  mainDB,
 		dataDir: dataDir,
 	}
 }
 
-// archivePath returns where the writers keep a database target's
+// archivePath returns where the engine keeps a database target's
 // archive file, for the names seedDatabaseTarget gave it.
 func (env *archiveEnv) archivePath(tgt *database.Target) string {
 	return filepath.Join(
 		env.dataDir,
-		archive.FileName(
+		delivery.ArchiveFileName(
 			archiveTestWebhookName, tgt.Name, tgt.ID,
 		),
 	)
 }
 
-// seedDatabaseTarget creates a webhook with one database target with
+// seedDatabaseTarget creates a webhook with one database target
-// the given archive expiry and rotation, and returns the target.
+// carrying the given target config JSON, and returns the target.
 func (env *archiveEnv) seedDatabaseTarget(
-	t *testing.T, expiry time.Duration, rotation string,
+	t *testing.T, configJSON string,
 ) *database.Target {
 	t.Helper()
 
@@ -124,27 +113,22 @@ func (env *archiveEnv) seedDatabaseTarget(
 			Create(wh).Error,
 	)
 
-	return env.addDatabaseTarget(t, wh.ID, expiry, rotation)
+	return env.addDatabaseTarget(t, wh.ID, configJSON)
 }
 
 // addDatabaseTarget creates one more database target on an
 // existing webhook and returns it.
 func (env *archiveEnv) addDatabaseTarget(
-	t *testing.T,
+	t *testing.T, webhookID, configJSON string,
-	webhookID string,
-	expiry time.Duration,
-	rotation string,
 ) *database.Target {
 	t.Helper()
 
 	tgt := &database.Target{
-		WebhookID:       webhookID,
+		WebhookID: webhookID,
-		Name:            "Archive",
+		Name:      "Archive",
-		Type:            database.TargetTypeDatabase,
+		Type:      database.TargetTypeDatabase,
-		Active:          true,
+		Active:    true,
-		ArchiveExpiry:   expiry,
+		Config:    configJSON,
-		ArchiveRotation: rotation,
-		MaxAttempts:     1,
 	}
 	require.NoError(
 		t,
@@ -192,7 +176,7 @@ func seedArchiveFile(
 	require.NoError(t, migrations.Apply(gdb, migrations.Archive))
 
 	for i, at := range archivedAt {
-		row := archive.ExportArchivedEvent{
+		row := delivery.ExportArchivedEvent{
 			EventID:    fmt.Sprintf("ev-%d", i),
 			WebhookID:  webhookID,
 			Method:     http.MethodPost,
@@ -212,7 +196,7 @@ func archivedEventIDs(
 ) []string {
 	t.Helper()
 
-	var rows []archive.ExportArchivedEvent
+	var rows []delivery.ExportArchivedEvent
 
 	rdb := openArchiveDBForRead(t, path)
 	require.NoError(t, rdb.Order("event_id").Find(&rows).Error)
@@ -249,7 +233,7 @@ func countArchivedRows(path string) (int64, error) {
 
 	var count int64
 
-	err = gdb.Model(&archive.ExportArchivedEvent{}).
+	err = gdb.Model(&delivery.ExportArchivedEvent{}).
 		Count(&count).Error
 	if err != nil {
 		return 0, err
@@ -258,55 +242,6 @@ func countArchivedRows(path string) (int64, error) {
 	return count, nil
 }
 
-// recordingLifecycle is a minimal fx.Lifecycle that records the
-// hooks a component registers, so a test can invoke the real
-// OnStart/OnStop functions with a context of its choosing.
-type recordingLifecycle struct {
-	hooks []fx.Hook
-}
-
-func (l *recordingLifecycle) Append(h fx.Hook) {
-	l.hooks = append(l.hooks, h)
-}
-
-// requireStopHookExpires drives hook.OnStop with a stop context
-// that expires while a wedged goroutine is still running, and
-// requires the hook to return the deadline error naming
-// component instead of blocking on the WaitGroup forever.
-func requireStopHookExpires(
-	t *testing.T, hook fx.Hook, component string,
-) {
-	t.Helper()
-
-	stopCtx, cancel := context.WithTimeout(
-		context.Background(), wedgeStopTimeout,
-	)
-	defer cancel()
-
-	var stopErr error
-
-	stopped := make(chan struct{})
-
-	go func() {
-		defer close(stopped)
-
-		stopErr = hook.OnStop(stopCtx)
-	}()
-
-	select {
-	case <-stopped:
-	case <-time.After(hookStopTimeout):
-		t.Fatal(
-			"OnStop did not return: it discarded the stop " +
-				"context and is waiting on a wedged goroutine " +
-				"that will never observe cancellation",
-		)
-	}
-
-	require.ErrorIs(t, stopErr, context.DeadlineExceeded)
-	require.ErrorContains(t, stopErr, component)
-}
-
 // TestArchiveSweeper_LoopOutlivesStartHookContext is the
 // regression test for a sweeper that never swept. fx calls
 // OnStart with a context carrying the application's start
@@ -327,7 +262,7 @@ func TestArchiveSweeper_LoopOutlivesStartHookContext(
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 
 	now := time.Now()
 	path := env.seedArchiveRows(
@@ -381,7 +316,7 @@ func TestArchiveSweep_DoesNotResurrectEvictedWriter(
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	env.seedArchiveRows(
 		t, tgt, time.Now().Add(-48*time.Hour),
 	)
@@ -390,16 +325,16 @@ func TestArchiveSweep_DoesNotResurrectEvictedWriter(
 	// the deletion path does. The target row is deliberately left
 	// in place: this is the tick that listed the target before
 	// the deletion committed.
-	_, err := env.writers.ExportEnsureArchiveWriter(tgt.ID)
+	_, err := env.eng.ExportEnsureArchiveWriter(tgt.ID)
 	require.NoError(t, err)
 
-	env.writers.EvictTarget(tgt.ID)
+	env.eng.EvictTarget(tgt.ID)
-	require.False(t, env.writers.ExportHasArchiveWriter(tgt.ID))
+	require.False(t, env.eng.ExportHasArchiveWriter(tgt.ID))
 
 	env.sweeper.ExportSweep(context.Background())
 
 	assert.False(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"a sweep must never re-register a writer for a target "+
 			"whose registry entry has already been released",
 	)
@@ -415,14 +350,14 @@ func TestArchiveSweep_LeavesNoRegistryEntry(t *testing.T) {
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	path := env.seedArchiveRows(
 		t, tgt,
 		time.Now().Add(-48*time.Hour),
 		time.Now().Add(-time.Minute),
 	)
 
-	require.False(t, env.writers.ExportHasArchiveWriter(tgt.ID))
+	require.False(t, env.eng.ExportHasArchiveWriter(tgt.ID))
 
 	env.sweeper.ExportSweep(context.Background())
 
@@ -431,7 +366,7 @@ func TestArchiveSweep_LeavesNoRegistryEntry(t *testing.T) {
 		"the sweep must still prune an idle archive",
 	)
 	assert.False(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"the sweep must release the registry entry it created",
 	)
 }
@@ -448,27 +383,29 @@ func TestArchiveSweep_KeepsWriterAdoptedByDelivery(
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	env.seedArchiveRows(
 		t, tgt, time.Now().Add(-48*time.Hour),
 	)
 
-	d := databaseTargetDelivery(newEvent(`{"n":1}`), tgt)
+	webhookDB := testWebhookDB(t)
+	event := seedEvent(t, webhookDB, `{"n":1}`)
+	d := seedDatabaseTargetDelivery(t, webhookDB, event, tgt)
 
 	env.sweeper.ExportSweep(context.Background())
-	require.False(t, env.writers.ExportHasArchiveWriter(tgt.ID))
+	require.False(t, env.eng.ExportHasArchiveWriter(tgt.ID))
 
-	require.NoError(t, env.writers.Write(d))
+	env.eng.ExportDeliverDatabase(webhookDB, d)
 
 	assert.True(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"a delivery's writer must stay registered",
 	)
 
 	env.sweeper.ExportSweep(context.Background())
 
 	assert.True(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"a sweep must not drop a writer a delivery owns",
 	)
 }
@@ -502,12 +439,12 @@ func TestArchiveSweep_KeepsWriterAdoptedDuringSweep(
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	env.seedArchiveRows(
 		t, tgt, time.Now().Add(-48*time.Hour),
 	)
 
-	sweepWriter, created, err := env.writers.ExportSweepWriterFor(
+	sweepWriter, created, err := env.eng.ExportSweepWriterFor(
 		tgt.ID,
 	)
 	require.NoError(t, err)
@@ -517,34 +454,36 @@ func TestArchiveSweep_KeepsWriterAdoptedDuringSweep(
 	)
 
 	// The delivery lands mid-sweep and adopts the entry.
-	d := databaseTargetDelivery(newEvent(`{"n":1}`), tgt)
+	webhookDB := testWebhookDB(t)
+	event := seedEvent(t, webhookDB, `{"n":1}`)
+	d := seedDatabaseTargetDelivery(t, webhookDB, event, tgt)
 
-	require.NoError(t, env.writers.Write(d))
+	env.eng.ExportDeliverDatabase(webhookDB, d)
 
-	adopted := env.writers.ExportArchiveWriterFor(tgt.ID)
+	adopted := env.eng.ExportArchiveWriterFor(tgt.ID)
 	require.NotNil(t, adopted)
 	require.True(
 		t, sweepWriter.Same(adopted),
 		"the delivery must have adopted the sweep's writer",
 	)
 	require.True(
-		t, env.writers.ExportArchiveHandleOpen(tgt.ID),
+		t, env.eng.ExportArchiveHandleOpen(tgt.ID),
 		"the delivery leaves the archive handle open",
 	)
 
 	// The sweep finishes.
-	env.writers.ExportReleaseSweepWriter(tgt.ID, sweepWriter)
+	env.eng.ExportReleaseSweepWriter(tgt.ID, sweepWriter)
 
 	require.True(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"a writer adopted by a delivery during a sweep must "+
 			"stay registered, or its open handle is unreachable",
 	)
 
-	env.writers.EvictTarget(tgt.ID)
+	env.eng.EvictTarget(tgt.ID)
 
 	assert.False(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"the adopted writer must still be evictable",
 	)
 	assert.False(
@@ -555,8 +494,8 @@ func TestArchiveSweep_KeepsWriterAdoptedDuringSweep(
 
 // TestArchiveSweep_ContinuesAfterPerTargetFailure proves a
 // failure for one target does not abort the sweep for the
-// others: an unreadable archive has to be logged and stepped
+// others: an unparseable expiry and an unreadable archive both
-// over.
+// have to be logged and stepped over.
 func TestArchiveSweep_ContinuesAfterPerTargetFailure(
 	t *testing.T,
 ) {
@@ -564,16 +503,21 @@ func TestArchiveSweep_ContinuesAfterPerTargetFailure(
 
 	env := setupArchiveTest(t)
 
-	// Seeded first so the sweep reaches it before the healthy
+	// Seeded first so the sweep reaches them before the healthy
 	// target: targets come back in insertion order.
-	corrupt := env.seedDatabaseTarget(t, time.Hour, "")
+	badConfig := env.seedDatabaseTarget(t, `{"expiry":"!!!"}`)
+	env.seedArchiveRows(
+		t, badConfig, time.Now().Add(-48*time.Hour),
+	)
+
+	corrupt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	require.NoError(t, os.WriteFile(
 		env.archivePath(corrupt),
 		[]byte("this is not a sqlite database"),
 		0o600,
 	))
 
-	healthy := env.seedDatabaseTarget(t, time.Hour, "")
+	healthy := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	healthyPath := env.seedArchiveRows(
 		t, healthy,
 		time.Now().Add(-48*time.Hour),
@@ -603,7 +547,7 @@ func TestArchiveSweep_OpenExistingDoesNotCreateFile(
 	dir := t.TempDir()
 	path := filepath.Join(dir, "archive-absent.db")
 
-	w := archive.NewExportArchiveWriter(
+	w := delivery.NewExportArchiveWriter(
 		path, archiveTestLogger(), 0,
 	)
 
@@ -630,7 +574,7 @@ func TestArchiveSweep_PrunesIdleArchive(t *testing.T) {
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 
 	now := time.Now()
 	path := env.seedArchiveRows(
@@ -669,12 +613,12 @@ func TestArchiveSweep_LeavesArchiveClosed(t *testing.T) {
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	path := env.seedArchiveRows(
 		t, tgt, time.Now().Add(-48*time.Hour),
 	)
 
-	w := archive.NewExportArchiveWriter(
+	w := delivery.NewExportArchiveWriter(
 		path, archiveTestLogger(), 0,
 	)
 
@@ -709,28 +653,30 @@ func TestArchiveSweep_ClosesHandleOfRegisteredWriter(
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	env.seedArchiveRows(
 		t, tgt, time.Now().Add(-48*time.Hour),
 	)
 
-	d := databaseTargetDelivery(newEvent(`{"n":1}`), tgt)
+	webhookDB := testWebhookDB(t)
+	event := seedEvent(t, webhookDB, `{"n":1}`)
+	d := seedDatabaseTargetDelivery(t, webhookDB, event, tgt)
 
-	require.NoError(t, env.writers.Write(d))
+	env.eng.ExportDeliverDatabase(webhookDB, d)
 
 	require.True(
-		t, env.writers.ExportArchiveHandleOpen(tgt.ID),
+		t, env.eng.ExportArchiveHandleOpen(tgt.ID),
 		"the delivery must leave the archive handle open",
 	)
 
 	env.sweeper.ExportSweep(context.Background())
 
 	require.True(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"the delivery's registry entry must survive the sweep",
 	)
 	assert.False(
-		t, env.writers.ExportArchiveHandleOpen(tgt.ID),
+		t, env.eng.ExportArchiveHandleOpen(tgt.ID),
 		"the sweep must leave the archive closed",
 	)
 }
@@ -746,7 +692,7 @@ func TestArchiveSweep_ClosesHandleBeforeReopening(t *testing.T) {
 
 	path := filepath.Join(t.TempDir(), "archive.db")
 
-	w := archive.NewExportArchiveWriter(
+	w := delivery.NewExportArchiveWriter(
 		path, archiveTestLogger(), 0,
 	)
 
@@ -774,8 +720,8 @@ func TestArchiveSweep_CancelledSweepLogsNoError(t *testing.T) {
 
 	var errorLines bytes.Buffer
 
-	sweeper := archive.NewTestSweeper(
+	sweeper := delivery.NewTestArchiveSweeper(
-		env.mainDB, env.writers,
+		env.mainDB, env.eng,
 		slog.New(slog.NewTextHandler(
 			&errorLines,
 			&slog.HandlerOptions{Level: slog.LevelError},
@@ -794,29 +740,36 @@ func TestArchiveSweep_CancelledSweepLogsNoError(t *testing.T) {
 }
 
 // TestArchiveSweep_NeverExpiryUntouched proves the sweep is a
-// no-op for the default retention policy, so an archive with an
+// no-op for the default retention policy, so archives with no
-// expiry of 0, which keeps it forever, is left alone.
+// expiry (or the literal "never") behave exactly as before.
 func TestArchiveSweep_NeverExpiryUntouched(t *testing.T) {
 	t.Parallel()
 
-	env := setupArchiveTest(t)
+	for _, configJSON := range []string{
+		`{"expiry":"never"}`,
+		`{"expiry":""}`,
+		"",
+	} {
+		env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, 0, "")
+		tgt := env.seedDatabaseTarget(t, configJSON)
-	path := env.seedArchiveRows(
+		path := env.seedArchiveRows(
-		t, tgt,
+			t, tgt,
-		time.Now().Add(-10000*time.Hour),
+			time.Now().Add(-10000*time.Hour),
-	)
+		)
 
-	env.sweeper.ExportSweep(context.Background())
+		env.sweeper.ExportSweep(context.Background())
 
-	assert.Equal(
+		assert.Equal(
-		t, []string{sweepRowOld}, archivedEventIDs(t, path),
+			t, []string{sweepRowOld}, archivedEventIDs(t, path),
-		"an expiry of 0 must keep rows forever",
+			"config %q must keep rows forever", configJSON,
-	)
+		)
-	assert.False(
+		assert.False(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+			t, env.eng.ExportHasArchiveWriter(tgt.ID),
-		"an expiry of 0 must leave no registry entry behind",
+			"config %q must leave no registry entry behind",
-	)
+			configJSON,
+		)
+	}
 }
 
 // TestArchiveSweep_NeverExpirySkipsBeforeOpening pins the
@@ -837,7 +790,7 @@ func TestArchiveSweep_NeverExpirySkipsBeforeOpening(
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, 0, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"never"}`)
 	path := env.archivePath(tgt)
 
 	seedUnmigratedArchive(t, path)
@@ -877,7 +830,7 @@ func archiveTableExists(t *testing.T, path string) bool {
 
 	return openArchiveDBForRead(t, path).
 		Migrator().
-		HasTable(&archive.ExportArchivedEvent{})
+		HasTable(&delivery.ExportArchivedEvent{})
 }
 
 // TestArchiveSweep_DoesNotCreateArchiveFile proves the sweep
@@ -889,7 +842,7 @@ func TestArchiveSweep_DoesNotCreateArchiveFile(t *testing.T) {
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	path := env.archivePath(tgt)
 
 	require.NoFileExists(t, path)
@@ -904,7 +857,7 @@ func TestArchiveSweep_DoesNotCreateArchiveFile(t *testing.T) {
 	}
 
 	assert.False(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"the sweep must leave no registry entry behind",
 	)
 }
@@ -920,9 +873,9 @@ func TestArchiveSweep_DoesNotCreateAfterWriterExists(
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 
-	path, err := env.writers.ExportEnsureArchiveWriter(tgt.ID)
+	path, err := env.eng.ExportEnsureArchiveWriter(tgt.ID)
 	require.NoError(t, err)
 	require.NoFileExists(t, path)
 
@@ -939,7 +892,7 @@ func TestArchiveSweep_SkipsDeletedWebhookTargets(t *testing.T) {
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	path := env.seedArchiveRows(
 		t, tgt, time.Now().Add(-48*time.Hour),
 	)
@@ -967,16 +920,23 @@ func TestArchiveSweep_ConcurrentWrites(t *testing.T) {
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 
+	webhookDB := testWebhookDB(t)
+
+	// The deliveries are seeded up front, on the test's own
+	// goroutine: the seed helpers assert, and testify assertions
+	// must not run off the test goroutine.
 	deliveries := make(
 		[]*database.Delivery, 0, sweepConcurrentWrites,
 	)
 
 	for range sweepConcurrentWrites {
+		event := seedEvent(t, webhookDB, `{"n":1}`)
+
 		deliveries = append(
 			deliveries,
-			databaseTargetDelivery(newEvent(`{"n":1}`), tgt),
+			seedDatabaseTargetDelivery(t, webhookDB, event, tgt),
 		)
 	}
 
@@ -988,7 +948,7 @@ func TestArchiveSweep_ConcurrentWrites(t *testing.T) {
 		defer wg.Done()
 
 		for _, d := range deliveries {
-			_ = env.writers.Write(d)
+			env.eng.ExportDeliverDatabase(webhookDB, d)
 		}
 	}()
 
@@ -1012,7 +972,7 @@ func TestArchiveSweeper_StopsCleanly(t *testing.T) {
 
 	env := setupArchiveTest(t)
 
-	tgt := env.seedDatabaseTarget(t, time.Hour, "")
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"1h"}`)
 	env.seedArchiveRows(
 		t, tgt, time.Now().Add(-48*time.Hour),
 	)

internal/delivery/client_ssrf_test.go

@@ -46,7 +46,12 @@ func TestClientForRequest_TimeoutKeepsSSRFGuard(t *testing.T) {
 		t.Run(target, func(t *testing.T) {
 			t.Parallel()
 
-			client := engine.ExportClientForRequest(5, nil)
+			cfg := &delivery.HTTPTargetConfig{
+				URL:     target,
+				Timeout: 5,
+			}
+
+			client := engine.ExportClientForRequest(cfg, nil)
 
 			require.NotSame(t, engine.ExportClient(), client,
 				"a per-target timeout must yield a "+
@@ -96,7 +101,11 @@ func TestClientForRequest_NoTimeoutUnchanged(t *testing.T) {
 
 	engine := newSSRFTestEngine()
 
-	client := engine.ExportClientForRequest(0, nil)
+	cfg := &delivery.HTTPTargetConfig{
+		URL: "https://example.com/hook",
+	}
+
+	client := engine.ExportClientForRequest(cfg, nil)
 
 	assert.Same(t, engine.ExportClient(), client,
 		"without a per-target timeout the shared client "+
@@ -114,8 +123,15 @@ func TestClientForRequest_HeadersKeepSSRFGuard(t *testing.T) {
 
 	engine := newSSRFTestEngine()
 
+	cfg := &delivery.HTTPTargetConfig{
+		URL: "https://example.com/with-headers",
+		Headers: map[string]string{
+			"X-Api-Key": "configured",
+		},
+	}
+
 	client := engine.ExportClientForRequest(
-		0, []string{probeHeaderName},
+		cfg, []string{"X-Api-Key"},
 	)
 
 	require.NotNil(t, client.CheckRedirect,

internal/delivery/delivery_totals_test.go

@@ -32,9 +32,8 @@ func targetTotals(
 
 // TestUpdateDeliveryStatus_FinishTimeAndTargetTotals pins what a status
 // write records for the webhook page's statistics: the time a delivery
-// finished, set only when it becomes delivered or failed and stored in
+// finished, set only when it becomes delivered or failed, and one more
-// the same form as created_at, and one more on its target's delivered
+// on its target's delivered or failed total.
-// or failed total.
 func TestUpdateDeliveryStatus_FinishTimeAndTargetTotals(t *testing.T) {
 	t.Parallel()
 
@@ -76,16 +75,6 @@ func TestUpdateDeliveryStatus_FinishTimeAndTargetTotals(t *testing.T) {
 			if tt.finished {
 				require.NotNil(t, stored.FinishedAt)
 				assert.False(t, stored.FinishedAt.Before(before))
-
-				var createdAt, finishedAt string
-
-				require.NoError(t, db.Raw(
-					`SELECT CAST(created_at AS TEXT),
-						CAST(finished_at AS TEXT)
-					FROM deliveries WHERE id = ?`, d.ID,
-				).Row().Scan(&createdAt, &finishedAt))
-				assertStoredTime(t, createdAt)
-				assertStoredTime(t, finishedAt)
 			} else {
 				assert.Nil(t, stored.FinishedAt)
 			}

internal/delivery/engine_integration_test.go

@@ -3,6 +3,7 @@ package delivery_test
 import (
 	"bytes"
 	"context"
+	"encoding/json"
 	"fmt"
 	"io"
 	"log/slog"
@@ -96,6 +97,17 @@ func iSeedWebhookDB(
 	return db
 }
 
+func iHTTPConfig(url string) string {
+	cfg := delivery.HTTPTargetConfig{URL: url}
+
+	data, err := json.Marshal(cfg)
+	if err != nil {
+		panic("failed to marshal HTTPTargetConfig")
+	}
+
+	return string(data)
+}
+
 func iEngine(
 	t *testing.T, workers int,
 ) *delivery.Engine {
@@ -157,24 +169,24 @@ func iSeedDelivery(
 func iTask(
 	d database.Delivery,
 	event database.Event,
-	webhookID, targetID, name, targetURL string,
+	webhookID, targetID, name, config string,
-	maxAttempts, attemptNum int,
+	maxRetries, attemptNum int,
 	body *string,
 ) delivery.Task {
 	return delivery.Task{
-		DeliveryID:  d.ID,
+		DeliveryID:   d.ID,
-		EventID:     event.ID,
+		EventID:      event.ID,
-		WebhookID:   webhookID,
+		WebhookID:    webhookID,
-		TargetID:    targetID,
+		TargetID:     targetID,
-		TargetName:  name,
+		TargetName:   name,
-		TargetType:  database.TargetTypeHTTP,
+		TargetType:   database.TargetTypeHTTP,
-		TargetURL:   targetURL,
+		TargetConfig: config,
-		MaxAttempts: maxAttempts,
+		MaxRetries:   maxRetries,
-		Method:      event.Method,
+		Method:       event.Method,
-		Headers:     event.Headers,
+		Headers:      event.Headers,
-		ContentType: event.ContentType,
+		ContentType:  event.ContentType,
-		Body:        body,
+		Body:         body,
-		AttemptNum:  attemptNum,
+		AttemptNum:   attemptNum,
 	}
 }
 
@@ -227,9 +239,10 @@ func TestProcessNewTask_InlineBody(t *testing.T) {
 	)
 
 	bodyStr := event.Body
+	cfg := iHTTPConfig(ts.URL)
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"test-target", ts.URL, 1, 1, &bodyStr,
+		"test-target", cfg, 0, 1, &bodyStr,
 	)
 
 	s.Engine.ExportProcessNewTask(
@@ -277,9 +290,10 @@ func TestProcessNewTask_LargeBody_FetchFromDB(
 		database.DeliveryStatusPending,
 	)
 
+	cfg := iHTTPConfig(ts.URL)
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"test-large", ts.URL, 1, 1, nil,
+		"test-large", cfg, 0, 1, nil,
 	)
 
 	s.Engine.ExportProcessNewTask(
@@ -299,16 +313,16 @@ func TestProcessNewTask_InvalidWebhookID(t *testing.T) {
 	s := newISetup(t)
 
 	task := delivery.Task{
-		DeliveryID:  uuid.New().String(),
+		DeliveryID:   uuid.New().String(),
-		EventID:     uuid.New().String(),
+		EventID:      uuid.New().String(),
-		WebhookID:   uuid.New().String(),
+		WebhookID:    uuid.New().String(),
-		TargetID:    uuid.New().String(),
+		TargetID:     uuid.New().String(),
-		TargetName:  "test",
+		TargetName:   "test",
-		TargetType:  database.TargetTypeHTTP,
+		TargetType:   database.TargetTypeHTTP,
-		TargetURL:   "http://localhost:9999",
+		TargetConfig: iHTTPConfig("http://localhost:9999"),
-		MaxAttempts: 1,
+		MaxRetries:   0,
-		Body:        nil,
+		Body:         nil,
-		AttemptNum:  1,
+		AttemptNum:   1,
 	}
 
 	s.Engine.ExportProcessNewTask(
@@ -349,6 +363,7 @@ func TestProcessRetryTask_SuccessfulRetry(t *testing.T) {
 	)
 
 	bodyStr := event.Body
+	cfg := iHTTPConfig(ts.URL)
 
 	// The target row exists because the engine confirms a scheduled
 	// retry's target has not been deleted before it runs it. A retry
@@ -357,12 +372,12 @@ func TestProcessRetryTask_SuccessfulRetry(t *testing.T) {
 	// task. See https://git.eeqj.de/sneak/webhooker/issues/107.
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "retry-target",
-		database.TargetTypeHTTP, ts.URL, 5,
+		database.TargetTypeHTTP, cfg, 5,
 	)
 
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"retry-target", ts.URL, 5, 2, &bodyStr,
+		"retry-target", cfg, 5, 2, &bodyStr,
 	)
 
 	s.Engine.ExportProcessRetryTask(
@@ -395,9 +410,10 @@ func TestProcessRetryTask_SkipsNonRetryingDelivery(
 	)
 
 	bodyStr := event.Body
+	cfg := iHTTPConfig("http://localhost:1")
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"skip-target", "http://localhost:1", 5, 2, &bodyStr,
+		"skip-target", cfg, 5, 2, &bodyStr,
 	)
 
 	s.Engine.ExportProcessRetryTask(
@@ -444,14 +460,16 @@ func TestProcessRetryTask_LargeBody_FetchFromDB(
 		database.DeliveryStatusRetrying,
 	)
 
+	cfg := iHTTPConfig(ts.URL)
+
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "retry-large",
-		database.TargetTypeHTTP, ts.URL, 5,
+		database.TargetTypeHTTP, cfg, 5,
 	)
 
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"retry-large", ts.URL, 5, 2, nil,
+		"retry-large", cfg, 5, 2, nil,
 	)
 
 	s.Engine.ExportProcessRetryTask(
@@ -488,11 +506,11 @@ func TestWorkerLifecycle_StartStop(t *testing.T) {
 	task := iTask(
 		d, event, s.WebhookID, targetID,
 		"lifecycle-test", "",
-		1, 1, &bodyStr,
+		0, 1, &bodyStr,
 	)
 	task.TargetType = database.TargetTypeLog
 
-	s.Engine.ExportNotify([]delivery.Task{task})
+	s.Engine.Notify([]delivery.Task{task})
 
 	iWaitForDelivered(t, s.WebhookDB, d.ID)
 
@@ -552,15 +570,16 @@ func TestWorkerLifecycle_ProcessesRetryChannel(
 	s.Engine.ExportStart()
 
 	bodyStr := event.Body
+	cfg := iHTTPConfig(ts.URL)
 
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "retry-chan-test",
-		database.TargetTypeHTTP, ts.URL, 5,
+		database.TargetTypeHTTP, cfg, 5,
 	)
 
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"retry-chan-test", ts.URL, 5, 2, &bodyStr,
+		"retry-chan-test", cfg, 5, 2, &bodyStr,
 	)
 
 	s.Engine.ExportRetryCh() <- task
@@ -626,7 +645,7 @@ func TestRecoverPendingDeliveries(t *testing.T) {
 
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, "recovery-target",
-		database.TargetTypeLog, "", 1,
+		database.TargetTypeLog, "", 0,
 	)
 
 	iSeedPendingDeliveries(
@@ -640,7 +659,7 @@ func TestRecoverPendingDeliveries(t *testing.T) {
 
 	s.Engine.ExportRecoverPendingDeliveries(
 		context.Background(), s.WebhookDB,
-		s.WebhookID, atStart,
+		s.WebhookID,
 	)
 
 	for i := range 3 {
@@ -666,18 +685,18 @@ func iCreateTarget(
 	mainDB *gorm.DB,
 	targetID, webhookID, name string,
 	targetType database.TargetType,
-	targetURL string,
+	config string,
-	maxAttempts int,
+	maxRetries int,
 ) {
 	t.Helper()
 
 	target := database.Target{
-		WebhookID:   webhookID,
+		WebhookID:  webhookID,
-		Name:        name,
+		Name:       name,
-		Type:        targetType,
+		Type:       targetType,
-		Active:      true,
+		Active:     true,
-		URL:         targetURL,
+		Config:     config,
-		MaxAttempts: maxAttempts,
+		MaxRetries: maxRetries,
 	}
 	target.ID = targetID
 
@@ -717,7 +736,7 @@ func TestRecoverWebhookDeliveries_RetryingDeliveries(
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, "retry-recovery",
 		database.TargetTypeHTTP,
-		"http://example.com/hook", 5,
+		iHTTPConfig("http://example.com/hook"), 5,
 	)
 
 	event := iSeedEvent(
@@ -737,7 +756,7 @@ func TestRecoverWebhookDeliveries_RetryingDeliveries(
 	)
 
 	s.Engine.ExportRecoverWebhookDeliveries(
-		context.Background(), s.WebhookID, atStart,
+		context.Background(), s.WebhookID,
 	)
 
 	select {
@@ -777,7 +796,7 @@ func iSeedRetryingWithType(
 
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, "mutated-target", targetType,
-		"http://example.com/hook", 5,
+		iHTTPConfig("http://example.com/hook"), 5,
 	)
 
 	event := iSeedEvent(
@@ -861,7 +880,7 @@ func TestRecoverSingleRetry_TypeNoLongerRetries(
 	)
 
 	s.Engine.ExportRecoverWebhookDeliveries(
-		context.Background(), s.WebhookID, atStart,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertTerminallyFailed(
@@ -869,7 +888,7 @@ func TestRecoverSingleRetry_TypeNoLongerRetries(
 	)
 }
 
-func TestRecoverSingleRetry_OnTick_TypeNoLongerRetries(
+func TestSweepSingleRetry_TypeNoLongerRetries(
 	t *testing.T,
 ) {
 	t.Parallel()
@@ -884,8 +903,8 @@ func TestRecoverSingleRetry_OnTick_TypeNoLongerRetries(
 		t, s, database.TargetTypeDatabase,
 	)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertTerminallyFailed(
@@ -915,14 +934,14 @@ func TestFailUnretryableRetry_WritesNoTargetRow(
 
 	targetID := uuid.New().String()
 
-	// A Slack incoming-webhook URL: the target's URL IS the
+	// A Slack incoming-webhook URL: the target config IS the
 	// credential, which is what makes a leaked target row a
 	// disclosure rather than a curiosity.
 	hookURL := "https://hooks.slack.com/services/T00/B00/x"
 
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, "credential-bearing",
-		database.TargetTypeLog, hookURL, 5,
+		database.TargetTypeLog, iHTTPConfig(hookURL), 5,
 	)
 
 	event := iSeedEvent(
@@ -936,8 +955,8 @@ func TestFailUnretryableRetry_WritesNoTargetRow(
 
 	iSeedFailedResult(t, s.WebhookDB, d.ID)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertStatus(t, s.WebhookDB, d.ID,
@@ -968,13 +987,13 @@ func TestRecoverSingleRetry_UnknownTargetType(
 	deliveryID := iSeedRetryingWithType(t, s, unknown)
 
 	s.Engine.ExportRecoverWebhookDeliveries(
-		context.Background(), s.WebhookID, atStart,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertTerminallyFailed(t, s, deliveryID, unknown)
 }
 
-func TestRecoverSingleRetry_OnTick_UnknownTargetType(
+func TestSweepSingleRetry_UnknownTargetType(
 	t *testing.T,
 ) {
 	t.Parallel()
@@ -989,8 +1008,8 @@ func TestRecoverSingleRetry_OnTick_UnknownTargetType(
 
 	deliveryID := iSeedRetryingWithType(t, s, unknown)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertTerminallyFailed(t, s, deliveryID, unknown)
@@ -1032,19 +1051,19 @@ func iCreateWebhook(
 	require.NoError(t, mainDB.Create(&webhook).Error)
 }
 
-// --- recoverDeliveries Tests ---
+// --- recoverInFlight Tests ---
 
-func TestRecoverDeliveries_NoWebhooks(t *testing.T) {
+func TestRecoverInFlight_NoWebhooks(t *testing.T) {
 	t.Parallel()
 
 	s := newISetup(t)
 
-	s.Engine.ExportRecoverDeliveries(
+	s.Engine.ExportRecoverInFlight(
-		context.Background(), atStart,
+		context.Background(),
 	)
 }
 
-func TestRecoverDeliveries_WithPendingDeliveries(
+func TestRecoverInFlight_WithPendingDeliveries(
 	t *testing.T,
 ) {
 	t.Parallel()
@@ -1058,7 +1077,7 @@ func TestRecoverDeliveries_WithPendingDeliveries(
 
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, "recover-target",
-		database.TargetTypeLog, "", 1,
+		database.TargetTypeLog, "", 0,
 	)
 
 	event := iSeedEvent(
@@ -1071,8 +1090,8 @@ func TestRecoverDeliveries_WithPendingDeliveries(
 		database.DeliveryStatusPending,
 	)
 
-	s.Engine.ExportRecoverDeliveries(
+	s.Engine.ExportRecoverInFlight(
-		context.Background(), atStart,
+		context.Background(),
 	)
 
 	select {
@@ -1083,16 +1102,16 @@ func TestRecoverDeliveries_WithPendingDeliveries(
 			database.TargetTypeLog, task.TargetType,
 		)
 	case <-time.After(2 * time.Second):
-		t.Fatal("expected task from recovery at start")
+		t.Fatal("expected task from recoverInFlight")
 	}
 }
 
-// TestRecoverDeliveries_ReportsAMissingWebhookDatabase covers a webhook
+// TestRecoverInFlight_ReportsAMissingWebhookDatabase covers a webhook
-// whose database file is gone, after a partial restore say. Recovery at
+// whose database file is gone, after a partial restore say. Restart
-// start opens every webhook's database, so the empty one made in its
+// recovery opens every webhook's database, so the empty one made in its
 // place is reported at start, naming the file
 // (https://git.eeqj.de/sneak/webhooker/issues/290).
-func TestRecoverDeliveries_ReportsAMissingWebhookDatabase(t *testing.T) {
+func TestRecoverInFlight_ReportsAMissingWebhookDatabase(t *testing.T) {
 	t.Parallel()
 
 	mainDB := iMainDB(t)
@@ -1112,7 +1131,7 @@ func TestRecoverDeliveries_ReportsAMissingWebhookDatabase(t *testing.T) {
 		&http.Client{Timeout: 5 * time.Second}, 1,
 	)
 
-	engine.ExportRecoverDeliveries(context.Background(), atStart)
+	engine.ExportRecoverInFlight(context.Background())
 
 	assert.Contains(
 		t, logs.String(),
@@ -1121,11 +1140,10 @@ func TestRecoverDeliveries_ReportsAMissingWebhookDatabase(t *testing.T) {
 	)
 }
 
-// TestRecoverDeliveries_SkipsAWebhookDeletedAfterTheListIsRead covers a
+// TestRecoverInFlight_SkipsAWebhookDeletedAfterTheListIsRead covers a
-// webhook deleted from the web interface while the recovery routine
+// webhook deleted from the web interface while restart recovery runs.
-// runs. Its database file is gone, and recovery must not create it
+// Its database file is gone, and recovery must not create it again.
-// again.
+func TestRecoverInFlight_SkipsAWebhookDeletedAfterTheListIsRead(
-func TestRecoverDeliveries_SkipsAWebhookDeletedAfterTheListIsRead(
 	t *testing.T,
 ) {
 	t.Parallel()
@@ -1161,13 +1179,13 @@ func TestRecoverDeliveries_SkipsAWebhookDeletedAfterTheListIsRead(
 		&http.Client{Timeout: 5 * time.Second}, 1,
 	)
 
-	engine.ExportRecoverDeliveries(context.Background(), atStart)
+	engine.ExportRecoverInFlight(context.Background())
 
 	require.True(t, deleted)
 	assert.False(t, dbMgr.DBExists(webhookID))
 }
 
-// --- HTTP target with custom headers ---
+// --- HTTP Config with custom headers ---
 
 func TestDeliverHTTP_CustomTargetHeaders(t *testing.T) {
 	t.Parallel()
@@ -1189,6 +1207,16 @@ func TestDeliverHTTP_CustomTargetHeaders(t *testing.T) {
 	)
 	defer ts.Close()
 
+	cfg := delivery.HTTPTargetConfig{
+		URL: ts.URL,
+		Headers: map[string]string{
+			"Authorization": "Bearer secret-token",
+		},
+	}
+
+	cfgJSON, err := json.Marshal(cfg)
+	require.NoError(t, err)
+
 	event := iSeedEvent(
 		t, s.WebhookDB, s.WebhookID,
 		`{"auth":"test"}`,
@@ -1203,12 +1231,9 @@ func TestDeliverHTTP_CustomTargetHeaders(t *testing.T) {
 	bodyStr := event.Body
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"auth-target", ts.URL,
+		"auth-target", string(cfgJSON),
-		1, 1, &bodyStr,
+		0, 1, &bodyStr,
 	)
-	task.TargetHeaders = map[string]string{
-		headerAuthorization: "Bearer secret-token",
-	}
 
 	s.Engine.ExportProcessNewTask(
 		context.TODO(), &task,
@@ -1221,14 +1246,11 @@ func TestDeliverHTTP_CustomTargetHeaders(t *testing.T) {
 
 // --- HTTP delivery with custom timeout ---
 
-// TestDeliverHTTP_TargetTimeout proves a task's TimeoutSeconds reaches
-// the delivery through the engine. The destination answers after two
-// seconds, inside the engine's own five-second client timeout, so only
-// the task's one second can fail the delivery.
 func TestDeliverHTTP_TargetTimeout(t *testing.T) {
 	t.Parallel()
 
-	s := newISetup(t)
+	db := testWebhookDB(t)
+	e := iEngine(t, 1)
 
 	ts := httptest.NewServer(
 		http.HandlerFunc(
@@ -1240,30 +1262,31 @@ func TestDeliverHTTP_TargetTimeout(t *testing.T) {
 	)
 	defer ts.Close()
 
-	event := iSeedEvent(
+	cfg := delivery.HTTPTargetConfig{
-		t, s.WebhookDB, s.WebhookID, `{"timeout":"test"}`,
+		URL:     ts.URL,
-	)
+		Timeout: 1,
-	targetID := uuid.New().String()
+	}
 
-	d := iSeedDelivery(
+	cfgJSON, err := json.Marshal(cfg)
-		t, s.WebhookDB, event.ID, targetID,
+	require.NoError(t, err)
-		database.DeliveryStatusPending,
+
+	event, del := iSeedEventAndDelivery(
+		t, db, `{"timeout":"test"}`,
+		string(cfgJSON),
 	)
 
-	bodyStr := event.Body
+	task, d := iHTTPTaskAndDelivery(
-	task := iTask(
+		event, del, "timeout-target",
-		d, event, s.WebhookID, targetID,
+		string(cfgJSON), 0, 1,
-		"timeout-target", ts.URL, 1, 1, &bodyStr,
 	)
-	task.TimeoutSeconds = 1
 
-	s.Engine.ExportProcessNewTask(context.TODO(), &task)
+	e.ExportDeliverHTTP(context.TODO(), db, d, task)
 
-	iAssertStatus(t, s.WebhookDB, d.ID,
+	iAssertStatus(t, db, del.ID,
 		database.DeliveryStatusFailed,
 	)
 
-	iAssertResultFailed(t, s.WebhookDB, d.ID)
+	iAssertResultFailed(t, db, del.ID)
 }
 
 // TestDeliverHTTP_CutsStoredResponseAtMaxBodyLog pins the size
@@ -1301,6 +1324,8 @@ func TestDeliverHTTP_CutsStoredResponseAtMaxBodyLog(
 	))
 	defer ts.Close()
 
+	cfgJSON := iHTTPConfig(ts.URL)
+
 	event := iSeedEvent(
 		t, s.WebhookDB, s.WebhookID, `{"cut":"test"}`,
 	)
@@ -1314,7 +1339,7 @@ func TestDeliverHTTP_CutsStoredResponseAtMaxBodyLog(
 	bodyStr := event.Body
 	task := iTask(
 		del, event, s.WebhookID, targetID,
-		"cut-target", ts.URL, 1, 1, &bodyStr,
+		"cut-target", cfgJSON, 0, 1, &bodyStr,
 	)
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &task)
@@ -1346,7 +1371,7 @@ func TestDeliverHTTP_CutsStoredResponseAtMaxBodyLog(
 func iSeedEventAndDelivery(
 	t *testing.T,
 	db *gorm.DB,
-	body string,
+	body, _ string,
 ) (database.Event, database.Delivery) {
 	t.Helper()
 
@@ -1377,19 +1402,19 @@ func iSeedEventAndDelivery(
 func iHTTPTaskAndDelivery(
 	event database.Event,
 	del database.Delivery,
-	name, targetURL string,
+	name, config string,
-	maxAttempts, attemptNum int,
+	maxRetries, attemptNum int,
 ) (*delivery.Task, *database.Delivery) {
 	task := &delivery.Task{
-		DeliveryID:  del.ID,
+		DeliveryID:   del.ID,
-		EventID:     event.ID,
+		EventID:      event.ID,
-		WebhookID:   event.WebhookID,
+		WebhookID:    event.WebhookID,
-		TargetID:    del.TargetID,
+		TargetID:     del.TargetID,
-		TargetName:  name,
+		TargetName:   name,
-		TargetType:  database.TargetTypeHTTP,
+		TargetType:   database.TargetTypeHTTP,
-		TargetURL:   targetURL,
+		TargetConfig: config,
-		MaxAttempts: maxAttempts,
+		MaxRetries:   maxRetries,
-		AttemptNum:  attemptNum,
+		AttemptNum:   attemptNum,
 	}
 
 	d := &database.Delivery{
@@ -1398,10 +1423,9 @@ func iHTTPTaskAndDelivery(
 		Status:   database.DeliveryStatusPending,
 		Event:    event,
 		Target: database.Target{
-			Name:        name,
+			Name:   name,
-			Type:        database.TargetTypeHTTP,
+			Type:   database.TargetTypeHTTP,
-			URL:         targetURL,
+			Config: config,
-			MaxAttempts: maxAttempts,
 		},
 	}
 	d.ID = del.ID
@@ -1429,30 +1453,56 @@ func iAssertResultFailed(
 	assert.NotEmpty(t, result.Error)
 }
 
-// --- HTTP request with no URL ---
+// --- HTTP request with invalid config ---
 
-// TestDeliverHTTP_NoURL proves an http target without a URL, which
+func TestDeliverHTTP_InvalidConfig(t *testing.T) {
-// the forms never store, fails its delivery and records why.
-func TestDeliverHTTP_NoURL(t *testing.T) {
 	t.Parallel()
 
 	db := testWebhookDB(t)
 	e := iEngine(t, 1)
 
-	event, del := iSeedEventAndDelivery(t, db, `{"url":"none"}`)
+	event, del := iSeedEventAndDelivery(
+		t, db, `{"config":"invalid"}`, "",
+	)
 
-	task, d := iHTTPTaskAndDelivery(event, del, "no-url", "", 1, 1)
+	task, d := iHTTPTaskAndDelivery(
+		event, del, "bad-config", `not-json`, 0, 1,
+	)
 
 	e.ExportDeliverHTTP(context.TODO(), db, d, task)
 
 	iAssertStatus(t, db, del.ID,
 		database.DeliveryStatusFailed,
 	)
-
-	iAssertResultFailed(t, db, del.ID)
 }
 
-// --- notify batching ---
+// TestDeliverHTTP_InvalidConfigUnrecordedStaysPending: a delivery is
+// failed for an invalid config only once the reason is recorded.
+// Unrecorded, it stays pending, where the sweep finds it again.
+func TestDeliverHTTP_InvalidConfigUnrecordedStaysPending(t *testing.T) {
+	t.Parallel()
+
+	db := testWebhookDB(t)
+	e := testEngine(t, 1)
+
+	event, del := iSeedEventAndDelivery(
+		t, db, `{"config":"invalid"}`, "",
+	)
+
+	task, d := iHTTPTaskAndDelivery(
+		event, del, "bad-config", `not-json`, 0, 1,
+	)
+
+	require.NoError(t, db.Exec("drop table delivery_results").Error)
+
+	e.ExportDeliverHTTP(context.TODO(), db, d, task)
+
+	iAssertStatus(t, db, del.ID,
+		database.DeliveryStatusPending,
+	)
+}
+
+// --- Notify batching ---
 
 func TestNotify_MultipleTasks(t *testing.T) {
 	t.Parallel()
@@ -1467,7 +1517,7 @@ func TestNotify_MultipleTasks(t *testing.T) {
 		}
 	}
 
-	e.ExportNotify(tasks)
+	e.Notify(tasks)
 
 	for i := range 5 {
 		select {

internal/delivery/engine_lifecycle_test.go

@@ -2,16 +2,11 @@ package delivery_test
 
 import (
 	"context"
-	"io"
-	"net/http"
-	"net/http/httptest"
 	"path/filepath"
-	"sync"
 	"testing"
 	"time"
 
 	"github.com/google/uuid"
-	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"go.uber.org/fx"
 	"gorm.io/gorm/clause"
@@ -29,7 +24,7 @@ const (
 	// OnStart before the caller may enqueue work. A worker pool
 	// wrongly rooted in the already-done hook context has nothing
 	// but ctx.Done() ready in its select, so it is deterministically
-	// gone by the end of this window. Without the wait, notify would
+	// gone by the end of this window. Without the wait, Notify would
 	// race the pool's very first select, in which a ready ctx.Done()
 	// and a ready deliveryCh are chosen between at random and a
 	// doomed pool still delivers.
@@ -99,7 +94,7 @@ func requireStopHookExpires(
 // the caller can drive OnStop too.
 //
 // Callers must not seed pending or retrying deliveries before
-// calling this: the recovery routine's run at start enqueues those,
+// calling this: restart recovery enqueues those during startup,
 // which would put work in the queue while the pool is still
 // racing its first select.
 func startEngineViaHook(
@@ -149,7 +144,7 @@ func seedLogTask(
 	bodyStr := event.Body
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"hook-context-test", "", 1, 1, &bodyStr,
+		"hook-context-test", "", 0, 1, &bodyStr,
 	)
 	task.TargetType = database.TargetTypeLog
 
@@ -178,11 +173,11 @@ func TestEngine_WorkersOutliveStartHookContext(t *testing.T) {
 		_ = lc.hooks[0].OnStop(context.Background())
 	})
 
-	// Seeded only after the pool has settled, so the recovery
+	// Seeded only after the pool has settled, so restart recovery
-	// routine's run at start cannot enqueue it.
+	// cannot enqueue it during startup.
 	deliveryID, task := seedLogTask(t, s)
 
-	s.Engine.ExportNotify([]delivery.Task{task})
+	s.Engine.Notify([]delivery.Task{task})
 
 	iWaitForDelivered(t, s.WebhookDB, deliveryID)
 }
@@ -202,7 +197,7 @@ func TestEngine_StopHookStopsWorkers(t *testing.T) {
 	// Let the pool prove it is running before stopping it, so a
 	// fast OnStop cannot pass by stopping something already dead.
 	firstID, firstTask := seedLogTask(t, s)
-	s.Engine.ExportNotify([]delivery.Task{firstTask})
+	s.Engine.Notify([]delivery.Task{firstTask})
 	iWaitForDelivered(t, s.WebhookDB, firstID)
 
 	var stopErr error
@@ -232,7 +227,7 @@ func TestEngine_StopHookStopsWorkers(t *testing.T) {
 	// With every worker gone, a freshly notified task must sit
 	// untouched in the queue rather than being delivered.
 	secondID, secondTask := seedLogTask(t, s)
-	s.Engine.ExportNotify([]delivery.Task{secondTask})
+	s.Engine.Notify([]delivery.Task{secondTask})
 
 	time.Sleep(200 * time.Millisecond)
 
@@ -277,168 +272,19 @@ func TestEngine_StopHookHonoursStopTimeout(t *testing.T) {
 	requireStopHookExpires(t, lc.hooks[0], "delivery engine")
 }
 
-// seedHeldDelivery gives the setup's webhook an http target with
-// maxAttempts, pointed at a receiver that keeps every request open until
-// the client gives up on it, and seeds one delivery to that target at
-// status. It returns the task that sends attempt attemptNum of the
-// delivery, and a channel that is closed when a request reaches the
-// receiver.
-func seedHeldDelivery(
-	t *testing.T,
-	s iSetup,
-	maxAttempts int,
-	status database.DeliveryStatus,
-	attemptNum int,
-) (delivery.Task, <-chan struct{}) {
-	t.Helper()
-
-	arrived := make(chan struct{})
-
-	var once sync.Once
-
-	ts := httptest.NewServer(http.HandlerFunc(
-		func(_ http.ResponseWriter, r *http.Request) {
-			// The server notices the client hanging up only once the
-			// body has been read; until then r.Context() never ends.
-			_, _ = io.Copy(io.Discard, r.Body)
-
-			once.Do(func() { close(arrived) })
-
-			<-r.Context().Done()
-		},
-	))
-	t.Cleanup(ts.Close)
-
-	targetID := uuid.New().String()
-
-	iCreateWebhook(t, s.MainDB, s.WebhookID, "hook")
-	iCreateTarget(
-		t, s.MainDB, targetID, s.WebhookID, "held",
-		database.TargetTypeHTTP, ts.URL, maxAttempts,
-	)
-
-	event := iSeedEvent(t, s.WebhookDB, s.WebhookID, `{"held":true}`)
-	d := iSeedDelivery(t, s.WebhookDB, event.ID, targetID, status)
-
-	bodyStr := event.Body
-
-	return iTask(
-		d, event, s.WebhookID, targetID, "held", ts.URL,
-		maxAttempts, attemptNum, &bodyStr,
-	), arrived
-}
-
-// stopDuringAttempt waits until the receiver holds an attempt open, then
-// stops the engine through its real stop hook.
-func stopDuringAttempt(
-	t *testing.T, lc *recordingLifecycle, arrived <-chan struct{},
-) {
-	t.Helper()
-
-	select {
-	case <-arrived:
-	case <-time.After(5 * time.Second):
-		t.Fatal("the delivery attempt never reached the receiver")
-	}
-
-	require.NoError(t, lc.hooks[0].OnStop(context.Background()))
-}
-
-// requireRequeued runs the recovery routine as at start on the stopped
-// engine and requires it to queue task's attempt again on ch.
-func requireRequeued(
-	t *testing.T, s iSetup, ch <-chan delivery.Task, task delivery.Task,
-) {
-	t.Helper()
-
-	s.Engine.ExportRecoverWebhookDeliveries(
-		context.Background(), s.WebhookID, atStart,
-	)
-
-	select {
-	case got := <-ch:
-		assert.Equal(t, task.DeliveryID, got.DeliveryID)
-		assert.Equal(t, task.AttemptNum, got.AttemptNum)
-	case <-time.After(5 * time.Second):
-		t.Fatal("recovery at start did not queue the delivery again")
-	}
-}
-
-// TestEngine_StopLeavesFireAndForgetAttemptPending is the regression
-// test for a stop that turned an attempt in flight into a terminal
-// failure. Stopping the engine cancels the request; for a target with
-// no retries that was the delivery's only attempt, recorded as failed
-// with "context canceled", and nothing ever sent it again. The
-// delivery must instead stay pending, with no result and no count in
-// the attempt metrics, for the recovery routine to send at the next
-// start.
-func TestEngine_StopLeavesFireAndForgetAttemptPending(t *testing.T) {
-	t.Parallel()
-
-	s := newISetup(t)
-	reg := mIsolate(t, s)
-	lc := startEngineViaHook(t, s.Engine)
-
-	task, arrived := seedHeldDelivery(
-		t, s, 1, database.DeliveryStatusPending, 1,
-	)
-
-	s.Engine.ExportNotify([]delivery.Task{task})
-	stopDuringAttempt(t, lc, arrived)
-
-	iAssertStatus(
-		t, s.WebhookDB, task.DeliveryID, database.DeliveryStatusPending,
-	)
-	assert.Empty(t, iResults(t, s.WebhookDB, task.DeliveryID))
-	assert.Zero(t, mCounter(t, reg, mAttempts, mTypeHTTP))
-	assert.Zero(t, mHTTPDurations(t, reg))
-
-	requireRequeued(t, s, s.Engine.ExportDeliveryCh(), task)
-}
-
-// TestEngine_StopLeavesLastRetryAttemptRetrying is the same regression
-// for a target with retries, on its last attempt: the cancelled attempt
-// used to exhaust the retries and end the delivery failed. It must stay
-// retrying with only its earlier attempt recorded, and the recovery
-// routine at the next start must send that last attempt again.
-func TestEngine_StopLeavesLastRetryAttemptRetrying(t *testing.T) {
-	t.Parallel()
-
-	const maxAttempts = 2
-
-	s := newISetup(t)
-	lc := startEngineViaHook(t, s.Engine)
-
-	task, arrived := seedHeldDelivery(
-		t, s, maxAttempts, database.DeliveryStatusRetrying, maxAttempts,
-	)
-	iSeedFailedResult(t, s.WebhookDB, task.DeliveryID)
-
-	s.Engine.ExportScheduleRetry(task, 0)
-	stopDuringAttempt(t, lc, arrived)
-
-	iAssertStatus(
-		t, s.WebhookDB, task.DeliveryID, database.DeliveryStatusRetrying,
-	)
-	assert.Len(t, iResults(t, s.WebhookDB, task.DeliveryID), 1)
-
-	requireRequeued(t, s, s.Engine.ExportRetryCh(), task)
-}
-
 // deliverToArchive gives the setup's webhook a database target,
 // runs one delivery to it through the running engine, and returns
-// the target's archive file path. The archive writer holds the file
+// the target's ID and archive file path. The archive writer holds
-// open afterwards.
+// the file open afterwards.
-func deliverToArchive(t *testing.T, s iSetup) string {
+func deliverToArchive(t *testing.T, s iSetup) (string, string) {
 	t.Helper()
 
 	iCreateWebhook(t, s.MainDB, s.WebhookID, "hook")
 
 	tgt := &database.Target{
-		WebhookID:   s.WebhookID,
+		WebhookID: s.WebhookID,
-		Name:        "archive",
+		Name:      "archive",
-		Type:        database.TargetTypeDatabase,
+		Type:      database.TargetTypeDatabase,
-		MaxAttempts: 1,
 	}
 	require.NoError(
 		t, s.MainDB.Omit(clause.Associations).Create(tgt).Error,
@@ -448,11 +294,11 @@ func deliverToArchive(t *testing.T, s iSetup) string {
 	task.TargetID = tgt.ID
 	task.TargetType = database.TargetTypeDatabase
 
-	s.Engine.ExportNotify([]delivery.Task{task})
+	s.Engine.Notify([]delivery.Task{task})
 
 	iWaitForDelivered(t, s.WebhookDB, deliveryID)
 
-	return filepath.Join(
+	return tgt.ID, filepath.Join(
 		filepath.Dir(s.DBMgr.DBPath(s.WebhookID)),
 		"archive-hook-archive-"+tgt.ID+".db",
 	)
@@ -471,7 +317,7 @@ func TestEngine_StopHookClosesArchives(t *testing.T) {
 
 	lc := startEngineViaHook(t, s.Engine)
 
-	path := deliverToArchive(t, s)
+	_, path := deliverToArchive(t, s)
 	require.FileExists(
 		t, path+"-wal",
 		"an open archive should have a -wal for the stop to remove",
@@ -505,23 +351,21 @@ func TestEngine_StopHookTimeoutLeavesArchivesOpen(t *testing.T) {
 
 	lc := startEngineViaHook(t, s.Engine)
 
-	path := deliverToArchive(t, s)
+	targetID, _ := deliverToArchive(t, s)
 
 	release := make(chan struct{})
 
 	t.Cleanup(func() {
 		close(release)
-		s.Engine.ExportArchives().EvictWebhook(s.WebhookID)
+		s.Engine.EvictWebhook(s.WebhookID)
 	})
 
 	s.Engine.ExportWedgeWorker(release)
 
 	requireStopHookExpires(t, lc.hooks[0], "delivery engine")
 
-	// Closing the last handle on an archive removes its -wal, so a
+	require.True(
-	// -wal still there is a writer still open.
+		t, s.Engine.ExportArchiveHandleOpen(targetID),
-	require.FileExists(
-		t, path+"-wal",
 		"a stop that timed out must not close archive writers",
 	)
 }

internal/delivery/engine_test.go

@@ -65,6 +65,20 @@ func testEngine(
 	)
 }
 
+func newHTTPTargetConfig(url string) string {
+	cfg := delivery.HTTPTargetConfig{URL: url}
+
+	data, err := json.Marshal(cfg)
+	if err != nil {
+		panic(
+			"failed to marshal HTTPTargetConfig: " +
+				err.Error(),
+		)
+	}
+
+	return string(data)
+}
+
 func seedEvent(
 	t *testing.T, db *gorm.DB, body string,
 ) database.Event {
@@ -103,18 +117,6 @@ func seedDelivery(
 	return d
 }
 
-// assertStoredTime asserts that text, a timestamp as SQLite holds it,
-// is in the form GORM stores created_at in: the layout of
-// time.Time.String, with no " m=+…" monotonic clock reading after it.
-func assertStoredTime(t *testing.T, text string) {
-	t.Helper()
-
-	_, err := time.Parse(
-		"2006-01-02 15:04:05.999999999 -0700 MST", text,
-	)
-	assert.NoError(t, err, "stored as %q", text)
-}
-
 // httpDeliveryFixture holds the task and delivery needed
 // for HTTP delivery tests.
 type httpDeliveryFixture struct {
@@ -127,19 +129,19 @@ type httpDeliveryFixture struct {
 func buildHTTPFixture(
 	dlv database.Delivery,
 	event database.Event,
-	targetID, name, targetURL string,
+	targetID, name, config string,
-	maxAttempts, attemptNum int,
+	maxRetries, attemptNum int,
 ) httpDeliveryFixture {
 	task := &delivery.Task{
-		DeliveryID:  dlv.ID,
+		DeliveryID:   dlv.ID,
-		EventID:     event.ID,
+		EventID:      event.ID,
-		WebhookID:   event.WebhookID,
+		WebhookID:    event.WebhookID,
-		TargetID:    targetID,
+		TargetID:     targetID,
-		TargetName:  name,
+		TargetName:   name,
-		TargetType:  database.TargetTypeHTTP,
+		TargetType:   database.TargetTypeHTTP,
-		TargetURL:   targetURL,
+		TargetConfig: config,
-		MaxAttempts: maxAttempts,
+		MaxRetries:   maxRetries,
-		AttemptNum:  attemptNum,
+		AttemptNum:   attemptNum,
 	}
 
 	d := &database.Delivery{
@@ -148,10 +150,10 @@ func buildHTTPFixture(
 		Status:   dlv.Status,
 		Event:    event,
 		Target: database.Target{
-			Name:        name,
+			Name:       name,
-			Type:        database.TargetTypeHTTP,
+			Type:       database.TargetTypeHTTP,
-			URL:         targetURL,
+			Config:     config,
-			MaxAttempts: maxAttempts,
+			MaxRetries: maxRetries,
 		},
 	}
 	d.ID = dlv.ID
@@ -218,7 +220,7 @@ func TestNotify_NonBlocking(t *testing.T) {
 	done := make(chan struct{})
 
 	go func() {
-		e.ExportNotify([]delivery.Task{
+		e.Notify([]delivery.Task{
 			{DeliveryID: "overflow-1"},
 			{DeliveryID: "overflow-2"},
 		})
@@ -229,7 +231,7 @@ func TestNotify_NonBlocking(t *testing.T) {
 	case <-done:
 	case <-time.After(2 * time.Second):
 		t.Fatal(
-			"notify blocked when delivery channel was full",
+			"Notify blocked when delivery channel was full",
 		)
 	}
 }
@@ -261,8 +263,9 @@ func TestDeliverHTTP_Success(t *testing.T) {
 		database.DeliveryStatusPending,
 	)
 
+	cfg := newHTTPTargetConfig(ts.URL)
 	fix := buildHTTPFixture(
-		dlv, event, targetID, "test-http", ts.URL, 1, 1,
+		dlv, event, targetID, "test-http", cfg, 0, 1,
 	)
 
 	e.ExportDeliverHTTP(
@@ -306,9 +309,10 @@ func TestDeliverHTTP_Failure(t *testing.T) {
 		database.DeliveryStatusPending,
 	)
 
+	cfg := newHTTPTargetConfig(ts.URL)
 	fix := buildHTTPFixture(
 		dlv, event, targetID,
-		"test-http-fail", ts.URL, 1, 1,
+		"test-http-fail", cfg, 0, 1,
 	)
 
 	e.ExportDeliverHTTP(
@@ -335,7 +339,7 @@ func TestDeliverDatabase_ImmediateSuccess(
 	// The database target archives for real, so the engine needs
 	// the target in the main database and a data directory.
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t)
+	tgt := env.seedDatabaseTarget(t, "")
 
 	event := seedEvent(t, db, `{"db":"target"}`)
 	d := seedDatabaseTargetDelivery(t, db, event, tgt)
@@ -436,9 +440,10 @@ func TestDeliverHTTP_WithRetries_Success(t *testing.T) {
 		database.DeliveryStatusPending,
 	)
 
+	cfg := newHTTPTargetConfig(ts.URL)
 	fix := buildHTTPFixture(
 		dlv, event, targetID,
-		"test-http-retry", ts.URL, 5, 1,
+		"test-http-retry", cfg, 5, 1,
 	)
 
 	e.ExportDeliverHTTP(
@@ -456,23 +461,14 @@ func TestDeliverHTTP_WithRetries_Success(t *testing.T) {
 	)
 }
 
-// TestDeliverHTTP_MaxAttemptsExhausted proves a target with three
+func TestDeliverHTTP_MaxRetriesExhausted(t *testing.T) {
-// delivery attempts makes at most three: the first two failures are
-// retried, the third is final, and each attempt goes through the
-// target's circuit breaker.
-func TestDeliverHTTP_MaxAttemptsExhausted(t *testing.T) {
 	t.Parallel()
 
-	const maxAttempts = 3
-
 	db := testWebhookDB(t)
 
-	var requests atomic.Int32
-
 	ts := httptest.NewServer(
 		http.HandlerFunc(
 			func(w http.ResponseWriter, _ *http.Request) {
-				requests.Add(1)
 				w.WriteHeader(http.StatusBadGateway)
 			},
 		),
@@ -481,101 +477,26 @@ func TestDeliverHTTP_MaxAttemptsExhausted(t *testing.T) {
 
 	e := testEngine(t, 1)
 	targetID := uuid.New().String()
-
-	// It opens on the last failure only if every attempt reached it.
-	cb := delivery.NewTestCircuitBreaker(maxAttempts, time.Minute)
-	e.ExportSetCircuitBreaker(targetID, cb)
-
 	event := seedEvent(t, db, `{"retry":"exhaust"}`)
 
 	dlv := seedDelivery(
 		t, db, event.ID, targetID,
-		database.DeliveryStatusPending,
+		database.DeliveryStatusRetrying,
-	)
-
-	sched := &recordingScheduler{}
-
-	for attempt := 1; attempt <= maxAttempts; attempt++ {
-		fix := buildHTTPFixture(
-			dlv, event, targetID,
-			"test-http-exhaust", ts.URL, maxAttempts, attempt,
-		)
-
-		e.ExportDeliverHTTPWithScheduler(
-			context.TODO(), db, fix.Delivery, fix.Task, sched,
-		)
-	}
-
-	assert.Equal(t, int32(maxAttempts), requests.Load())
-	assert.Len(t, sched.delays, maxAttempts-1,
-		"every failure but the last should be retried",
-	)
-	assertDeliveryStatus(t, db, dlv.ID,
-		database.DeliveryStatusFailed,
-	)
-	assert.Equal(t, delivery.CircuitOpen, cb.State(),
-		"every attempt should be counted by the circuit breaker",
-	)
-}
-
-// TestDeliverHTTP_SingleAttemptSkipsCircuitBreaker proves a target
-// with one delivery attempt makes exactly that attempt, even while
-// its circuit breaker is open, and that a failure is final.
-func TestDeliverHTTP_SingleAttemptSkipsCircuitBreaker(t *testing.T) {
-	t.Parallel()
-
-	db := testWebhookDB(t)
-
-	var requests atomic.Int32
-
-	ts := httptest.NewServer(
-		http.HandlerFunc(
-			func(w http.ResponseWriter, _ *http.Request) {
-				requests.Add(1)
-				w.WriteHeader(http.StatusBadGateway)
-			},
-		),
-	)
-	defer ts.Close()
-
-	e := testEngine(t, 1)
-	targetID := uuid.New().String()
-
-	cb := e.ExportGetCircuitBreaker(targetID)
-
-	for range delivery.ExportDefaultFailureThreshold {
-		cb.RecordFailure()
-	}
-
-	require.Equal(t, delivery.CircuitOpen, cb.State())
-
-	event := seedEvent(t, db, `{"retry":"none"}`)
-
-	dlv := seedDelivery(
-		t, db, event.ID, targetID,
-		database.DeliveryStatusPending,
 	)
 
+	cfg := newHTTPTargetConfig(ts.URL)
 	fix := buildHTTPFixture(
 		dlv, event, targetID,
-		"test-http-single", ts.URL, 1, 1,
+		"test-http-exhaust", cfg, 3, 3,
-	)
-	sched := &recordingScheduler{}
-
-	e.ExportDeliverHTTPWithScheduler(
-		context.TODO(), db, fix.Delivery, fix.Task, sched,
 	)
 
-	assert.Equal(t, int32(1), requests.Load(),
+	e.ExportDeliverHTTP(
-		"the open circuit breaker should not hold the attempt back",
+		context.TODO(), db, fix.Delivery, fix.Task,
 	)
-	assert.Empty(t, sched.delays, "no retry should be scheduled")
+
 	assertDeliveryStatus(t, db, dlv.ID,
 		database.DeliveryStatusFailed,
 	)
-	assertDeliveryResult(
-		t, db, dlv.ID, false, http.StatusBadGateway,
-	)
 }
 
 func TestDeliverHTTP_SchedulesRetryOnFailure(
@@ -605,9 +526,10 @@ func TestDeliverHTTP_SchedulesRetryOnFailure(
 		database.DeliveryStatusPending,
 	)
 
+	cfg := newHTTPTargetConfig(ts.URL)
 	fix := buildHTTPFixture(
 		dlv, event, targetID,
-		"test-http-schedule", ts.URL, 5, 1,
+		"test-http-schedule", cfg, 5, 1,
 	)
 
 	e.ExportDeliverHTTP(
@@ -769,7 +691,7 @@ func seedConcurrencyTasks(
 	t *testing.T,
 	db *gorm.DB,
 	n int,
-	targetURL string,
+	targetCfg string,
 ) ([]database.Delivery, []delivery.Task) {
 	t.Helper()
 
@@ -793,23 +715,22 @@ func seedConcurrencyTasks(
 			Status:   database.DeliveryStatusPending,
 			Event:    event,
 			Target: database.Target{
-				Name:        fmt.Sprintf("task-%d", i),
+				Name:   fmt.Sprintf("task-%d", i),
-				Type:        database.TargetTypeHTTP,
+				Type:   database.TargetTypeHTTP,
-				URL:         targetURL,
+				Config: targetCfg,
-				MaxAttempts: 1,
 			},
 		}
 		tasks[i].ID = dlv.ID
 
 		dtasks[i] = delivery.Task{
-			DeliveryID:  tasks[i].ID,
+			DeliveryID:   tasks[i].ID,
-			EventID:     tasks[i].EventID,
+			EventID:      tasks[i].EventID,
-			TargetID:    tasks[i].TargetID,
+			TargetID:     tasks[i].TargetID,
-			TargetName:  tasks[i].Target.Name,
+			TargetName:   tasks[i].Target.Name,
-			TargetType:  tasks[i].Target.Type,
+			TargetType:   tasks[i].Target.Type,
-			TargetURL:   tasks[i].Target.URL,
+			TargetConfig: tasks[i].Target.Config,
-			MaxAttempts: 1,
+			MaxRetries:   0,
-			AttemptNum:  1,
+			AttemptNum:   1,
 		}
 	}
 
@@ -845,8 +766,9 @@ func TestWorkerPool_BoundedConcurrency(t *testing.T) {
 	defer ts.Close()
 
 	e := testEngine(t, numWorkers)
+	cfg := newHTTPTargetConfig(ts.URL)
 	tasks, dtasks := seedConcurrencyTasks(
-		t, db, numTasks, ts.URL,
+		t, db, numTasks, cfg,
 	)
 
 	runConcurrencyWorkers(
@@ -927,9 +849,12 @@ func TestDeliverHTTP_CircuitBreakerBlocks(t *testing.T) {
 		database.DeliveryStatusPending,
 	)
 
+	cfg := newHTTPTargetConfig(
+		"http://will-not-be-called.invalid",
+	)
 	fix := buildHTTPFixture(
 		dlv, event, targetID,
-		"test-cb-block", "http://will-not-be-called.invalid", 5, 1,
+		"test-cb-block", cfg, 5, 1,
 	)
 
 	e.ExportDeliverHTTP(
@@ -992,8 +917,9 @@ func TestDeliverHTTP_HalfOpenBreakerDelaysQueuedTasks(t *testing.T) {
 	require.True(t, cb.Allow(), "the probe delivery should go through")
 	require.Equal(t, delivery.CircuitHalfOpen, cb.State())
 
-	const targetURL = "http://will-not-be-called.invalid"
+	cfg := newHTTPTargetConfig(
-
+		"http://will-not-be-called.invalid",
+	)
 	sched := &recordingScheduler{}
 
 	const queued, passes = 3, 4
@@ -1015,7 +941,7 @@ func TestDeliverHTTP_HalfOpenBreakerDelaysQueuedTasks(t *testing.T) {
 
 			fix := buildHTTPFixture(
 				row, event, targetID,
-				"test-cb-half-open", targetURL, 5, 1,
+				"test-cb-half-open", cfg, 5, 1,
 			)
 
 			e.ExportDeliverHTTPWithScheduler(
@@ -1130,6 +1056,62 @@ func TestStateAndCooldown_ReadsHTTPAndSlackBreakers(t *testing.T) {
 	assert.Zero(t, cooldown, "half-open")
 }
 
+func TestParseHTTPConfig_Valid(t *testing.T) {
+	t.Parallel()
+
+	e := testEngine(t, 1)
+
+	cfg, err := e.ExportParseHTTPConfig(
+		`{"url":"https://example.com/hook",` +
+			`"headers":{"X-Token":"secret"}}`,
+	)
+
+	require.NoError(t, err)
+	assert.Equal(t, "https://example.com/hook", cfg.URL)
+	assert.Equal(t, "secret", cfg.Headers["X-Token"])
+}
+
+func TestParseHTTPConfig_Empty(t *testing.T) {
+	t.Parallel()
+
+	e := testEngine(t, 1)
+
+	_, err := e.ExportParseHTTPConfig("")
+
+	assert.Error(t, err,
+		"empty config should return error",
+	)
+}
+
+func TestParseHTTPConfig_MissingURL(t *testing.T) {
+	t.Parallel()
+
+	e := testEngine(t, 1)
+
+	_, err := e.ExportParseHTTPConfig(
+		`{"headers":{"X-Token":"secret"}}`,
+	)
+
+	assert.Error(t, err,
+		"config without URL should return error",
+	)
+}
+
+func TestParseHTTPConfig_Undecodable(t *testing.T) {
+	t.Parallel()
+
+	e := testEngine(t, 1)
+
+	_, err := e.ExportParseHTTPConfig(
+		`{"url":"https://example.com/hook","timeout":"soon"}`,
+	)
+
+	assert.Error(t, err,
+		"config that does not decode should return error, "+
+			"even when the part that did names a URL",
+	)
+}
+
 func TestScheduleRetry_SendsToRetryChannel(
 	t *testing.T,
 ) {
@@ -1277,7 +1259,7 @@ func TestDoHTTPRequest_ForwardsHeaders(t *testing.T) {
 
 	e := testEngine(t, 1)
 
-	target := &database.Target{
+	cfg := &delivery.HTTPTargetConfig{
 		URL: ts.URL,
 		Headers: map[string]string{
 			"X-Target-Auth": "bearer xyz",
@@ -1292,7 +1274,7 @@ func TestDoHTTPRequest_ForwardsHeaders(t *testing.T) {
 	}
 
 	statusCode, _, _, err := e.ExportDoHTTPRequest(
-		context.TODO(), target, event,
+		context.TODO(), cfg, event,
 	)
 
 	require.NoError(t, err)
@@ -1334,7 +1316,7 @@ func TestDoHTTPRequest_CutShortResponseIsAnError(t *testing.T) {
 
 	_, body, _, err := e.ExportDoHTTPRequest(
 		context.TODO(),
-		&database.Target{URL: ts.URL},
+		&delivery.HTTPTargetConfig{URL: ts.URL},
 		&database.Event{},
 	)
 
@@ -1386,9 +1368,9 @@ func TestApplyRequestHeaders_SendsOneContentType(t *testing.T) {
 			})
 			require.NoError(t, err)
 
-			var configured map[string]string
+			cfg := &delivery.HTTPTargetConfig{}
 			if tc.configured != "" {
-				configured = map[string]string{
+				cfg.Headers = map[string]string{
 					headerContentType: tc.configured,
 				}
 			}
@@ -1407,7 +1389,7 @@ func TestApplyRequestHeaders_SendsOneContentType(t *testing.T) {
 					Headers:     string(inbound),
 					ContentType: tc.event,
 				},
-				configured,
+				cfg,
 				"webhooker/dev",
 			)
 
@@ -1438,7 +1420,7 @@ func TestApplyRequestHeaders_UndecodableInboundForwardsNothing(
 		&database.Event{
 			Headers: `{"X-Custom":["value1"],"X-Broken":"not a list"}`,
 		},
-		nil,
+		&delivery.HTTPTargetConfig{},
 		"webhooker/dev",
 	)
 
@@ -1456,7 +1438,7 @@ func TestProcessDelivery_RoutesToCorrectHandler(
 	// The database target archives for real, so the engine needs
 	// the target in the main database and a data directory.
 	env := setupArchiveTest(t)
-	archive := env.seedDatabaseTarget(t)
+	archive := env.seedDatabaseTarget(t, "")
 
 	tests := []struct {
 		name       string
@@ -1541,6 +1523,51 @@ func TestMaxInlineBodySize_Constant(t *testing.T) {
 	)
 }
 
+func TestParseSlackConfig_Valid(t *testing.T) {
+	t.Parallel()
+
+	e := testEngine(t, 1)
+
+	cfg, err := e.ExportParseSlackConfig(
+		`{"webhookUrl":"https://hooks.slack.com/services/T00/B00/xxx"}`,
+	)
+
+	require.NoError(t, err)
+
+	assert.Equal(t,
+		"https://hooks.slack.com/services/T00/B00/xxx",
+		cfg.WebhookURL,
+	)
+}
+
+func TestParseSlackConfig_Empty(t *testing.T) {
+	t.Parallel()
+
+	e := testEngine(t, 1)
+
+	_, err := e.ExportParseSlackConfig("")
+
+	assert.Error(t, err,
+		"empty config should return error",
+	)
+}
+
+func TestParseSlackConfig_MissingWebhookURL(
+	t *testing.T,
+) {
+	t.Parallel()
+
+	e := testEngine(t, 1)
+
+	_, err := e.ExportParseSlackConfig(
+		`{"other":"field"}`,
+	)
+
+	assert.Error(t, err,
+		"config without webhook_url should return error",
+	)
+}
+
 func TestFormatSlackMessage_JSONBody(t *testing.T) {
 	t.Parallel()
 
@@ -1637,11 +1664,11 @@ func TestFormatSlackMessage_LargeJSONTruncated(
 }
 
 // buildSlackDelivery creates a database.Delivery
-// to a Slack target with the given webhook URL for testing.
+// with a Slack target config for testing.
 func buildSlackDelivery(
 	dlv database.Delivery,
 	event database.Event,
-	targetID, name, webhookURL string,
+	targetID, name, slackCfg string,
 ) *database.Delivery {
 	d := &database.Delivery{
 		EventID:  event.ID,
@@ -1649,10 +1676,9 @@ func buildSlackDelivery(
 		Status:   dlv.Status,
 		Event:    event,
 		Target: database.Target{
-			Name:        name,
+			Name:   name,
-			Type:        database.TargetTypeSlack,
+			Type:   database.TargetTypeSlack,
-			URL:         webhookURL,
+			Config: slackCfg,
-			MaxAttempts: 1,
 		},
 	}
 	d.ID = dlv.ID
@@ -1689,10 +1715,11 @@ func TestDeliverSlack_Success(t *testing.T) {
 	)
 	defer ts.Close()
 
-	e, targetID, event, dlv := setupSlackTest(t, db)
+	e, targetID, slackCfg, event, dlv :=
+		setupSlackTest(t, db, ts.URL)
 
 	d := buildSlackDelivery(
-		dlv, event, targetID, "test-slack", ts.URL,
+		dlv, event, targetID, "test-slack", slackCfg,
 	)
 
 	e.ExportDeliverSlack(context.TODO(), db, d)
@@ -1711,8 +1738,9 @@ func TestDeliverSlack_Success(t *testing.T) {
 func setupSlackTest(
 	t *testing.T,
 	db *gorm.DB,
+	serverURL string,
 ) (
-	*delivery.Engine, string,
+	*delivery.Engine, string, string,
 	database.Event, database.Delivery,
 ) {
 	t.Helper()
@@ -1720,6 +1748,13 @@ func setupSlackTest(
 	e := testEngine(t, 1)
 	targetID := uuid.New().String()
 
+	cfgBytes, err := json.Marshal(
+		delivery.SlackTargetConfig{
+			WebhookURL: serverURL,
+		},
+	)
+	require.NoError(t, err)
+
 	event := seedEvent(
 		t, db, `{"action":"test","data":"value"}`,
 	)
@@ -1729,7 +1764,7 @@ func setupSlackTest(
 		database.DeliveryStatusPending,
 	)
 
-	return e, targetID, event, dlv
+	return e, targetID, string(cfgBytes), event, dlv
 }
 
 func assertSlackPayload(
@@ -1778,6 +1813,13 @@ func TestDeliverSlack_Failure(t *testing.T) {
 	e := testEngine(t, 1)
 	targetID := uuid.New().String()
 
+	slackCfg, err := json.Marshal(
+		delivery.SlackTargetConfig{
+			WebhookURL: ts.URL,
+		},
+	)
+	require.NoError(t, err)
+
 	event := seedEvent(t, db, `{"test":true}`)
 
 	dlv := seedDelivery(
@@ -1787,7 +1829,7 @@ func TestDeliverSlack_Failure(t *testing.T) {
 
 	d := buildSlackDelivery(
 		dlv, event, targetID,
-		"test-slack-fail", ts.URL,
+		"test-slack-fail", string(slackCfg),
 	)
 
 	e.ExportDeliverSlack(context.TODO(), db, d)
@@ -1801,10 +1843,7 @@ func TestDeliverSlack_Failure(t *testing.T) {
 	)
 }
 
-// TestDeliverSlack_NoURL proves a Slack target without a URL, which
+func TestDeliverSlack_InvalidConfig(t *testing.T) {
-// the forms never store, fails its delivery rather than reporting it
-// delivered.
-func TestDeliverSlack_NoURL(t *testing.T) {
 	t.Parallel()
 
 	db := testWebhookDB(t)
@@ -1823,9 +1862,9 @@ func TestDeliverSlack_NoURL(t *testing.T) {
 		Status:   database.DeliveryStatusPending,
 		Event:    event,
 		Target: database.Target{
-			Name:        "test-slack-bad",
+			Name:   "test-slack-bad",
-			Type:        database.TargetTypeSlack,
+			Type:   database.TargetTypeSlack,
-			MaxAttempts: 1,
+			Config: `{"not_webhook_url":"missing"}`,
 		},
 	}
 	d.ID = dlv.ID
@@ -1862,6 +1901,13 @@ func TestProcessDelivery_RoutesToSlack(t *testing.T) {
 
 	e := testEngine(t, 1)
 
+	slackCfg, err := json.Marshal(
+		delivery.SlackTargetConfig{
+			WebhookURL: ts.URL,
+		},
+	)
+	require.NoError(t, err)
+
 	event := seedEvent(t, db, `{"route":"slack"}`)
 
 	dlv := seedDelivery(
@@ -1871,13 +1917,12 @@ func TestProcessDelivery_RoutesToSlack(t *testing.T) {
 
 	d := buildSlackDelivery(
 		dlv, event, dlv.TargetID,
-		"test-slack-route", ts.URL,
+		"test-slack-route", string(slackCfg),
 	)
 
 	task := &delivery.Task{
-		DeliveryID:  dlv.ID,
+		DeliveryID: dlv.ID,
-		TargetType:  database.TargetTypeSlack,
+		TargetType: database.TargetTypeSlack,
-		MaxAttempts: 1,
 	}
 
 	e.ExportProcessDelivery(
@@ -1986,7 +2031,7 @@ func TestDeliverLog_LogsFullContent(t *testing.T) {
 func buildSlackRetryDelivery(
 	dlv database.Delivery,
 	event database.Event,
-	targetID, webhookURL string,
+	targetID, cfg string,
 ) *database.Delivery {
 	d := &database.Delivery{
 		EventID:  event.ID,
@@ -1994,10 +2039,10 @@ func buildSlackRetryDelivery(
 		Status:   database.DeliveryStatusPending,
 		Event:    event,
 		Target: database.Target{
-			Name:        "test-slack-retry",
+			Name:       "test-slack-retry",
-			Type:        database.TargetTypeSlack,
+			Type:       database.TargetTypeSlack,
-			URL:         webhookURL,
+			Config:     cfg,
-			MaxAttempts: 5,
+			MaxRetries: 5,
 		},
 	}
 	d.ID = dlv.ID
@@ -2015,6 +2060,11 @@ func TestDeliverSlack_WithRetries_SchedulesRetry(
 	e := testEngine(t, 1)
 	targetID := uuid.New().String()
 
+	slackCfg, err := json.Marshal(
+		delivery.SlackTargetConfig{WebhookURL: ts.URL},
+	)
+	require.NoError(t, err)
+
 	event := seedEvent(t, db, `{"slack":"retry"}`)
 
 	dlv := seedDelivery(
@@ -2023,15 +2073,15 @@ func TestDeliverSlack_WithRetries_SchedulesRetry(
 	)
 
 	d := buildSlackRetryDelivery(
-		dlv, event, targetID, ts.URL,
+		dlv, event, targetID, string(slackCfg),
 	)
 
 	task := &delivery.Task{
-		DeliveryID:  dlv.ID,
+		DeliveryID: dlv.ID,
-		TargetID:    targetID,
+		TargetID:   targetID,
-		TargetType:  database.TargetTypeSlack,
+		TargetType: database.TargetTypeSlack,
-		MaxAttempts: 5,
+		MaxRetries: 5,
-		AttemptNum:  1,
+		AttemptNum: 1,
 	}
 
 	e.ExportProcessDelivery(context.TODO(), db, d, task)

internal/delivery/event_db_isolation_test.go

@@ -69,6 +69,7 @@ func TestEventDBHoldsNoTargetRows(t *testing.T) {
 	))
 	defer ts.Close()
 
+	cfg := iHTTPConfig(ts.URL)
 	targetID := uuid.New().String()
 	dbPath := s.DBMgr.DBPath(s.WebhookID)
 
@@ -84,7 +85,7 @@ func TestEventDBHoldsNoTargetRows(t *testing.T) {
 	)
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"leaky-target", ts.URL, 5, 1, &body,
+		"leaky-target", cfg, 5, 1, &body,
 	)
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &task)
@@ -101,7 +102,7 @@ func TestEventDBHoldsNoTargetRows(t *testing.T) {
 	// https://git.eeqj.de/sneak/webhooker/issues/107.
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "leaky-target",
-		database.TargetTypeHTTP, ts.URL, 5,
+		database.TargetTypeHTTP, cfg, 5,
 	)
 
 	rd := iSeedDelivery(
@@ -110,7 +111,7 @@ func TestEventDBHoldsNoTargetRows(t *testing.T) {
 	)
 	rTask := iTask(
 		rd, event, s.WebhookID, targetID,
-		"leaky-target", ts.URL, 5, 2, &body,
+		"leaky-target", cfg, 5, 2, &body,
 	)
 
 	s.Engine.ExportProcessRetryTask(context.TODO(), &rTask)
@@ -137,6 +138,7 @@ func TestEventDBHoldsNoTargetRowsOnFailedDelivery(t *testing.T) {
 	))
 	defer ts.Close()
 
+	cfg := iHTTPConfig(ts.URL)
 	targetID := uuid.New().String()
 
 	event := iSeedEvent(
@@ -150,7 +152,7 @@ func TestEventDBHoldsNoTargetRowsOnFailedDelivery(t *testing.T) {
 	)
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"leaky-target", ts.URL, 1, 1, &body,
+		"leaky-target", cfg, 0, 1, &body,
 	)
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &task)

internal/delivery/event_timestamp_test.go

@@ -93,6 +93,17 @@ func (s *tsSink) text(t *testing.T) string {
 	}
 }
 
+func tsSlackConfig(t *testing.T, url string) string {
+	t.Helper()
+
+	data, err := json.Marshal(
+		delivery.SlackTargetConfig{WebhookURL: url},
+	)
+	require.NoError(t, err)
+
+	return string(data)
+}
+
 // tsSeedEvent writes an event whose CreatedAt is tsEventCreatedAt
 // rather than the write time, so an assertion on the rendered
 // timestamp cannot pass by accident against "roughly now".
@@ -131,17 +142,16 @@ func tsSeedEvent(
 // tsSeedTarget writes the slack target row into the main database.
 // The retry path confirms the target still exists before sending.
 func tsSeedTarget(
-	t *testing.T, mainDB *gorm.DB, webhookID, webhookURL string,
+	t *testing.T, mainDB *gorm.DB, webhookID, config string,
 ) database.Target {
 	t.Helper()
 
 	target := database.Target{
-		WebhookID:   webhookID,
+		WebhookID: webhookID,
-		Name:        "slack-sink",
+		Name:      "slack-sink",
-		Type:        database.TargetTypeSlack,
+		Type:      database.TargetTypeSlack,
-		URL:         webhookURL,
+		Config:    config,
-		Active:      true,
+		Active:    true,
-		MaxAttempts: 1,
 	}
 
 	require.NoError(t, mainDB.Create(&target).Error)
@@ -165,8 +175,8 @@ func tsTask(
 		TargetID:     target.ID,
 		TargetName:   target.Name,
 		TargetType:   database.TargetTypeSlack,
-		TargetURL:    target.URL,
+		TargetConfig: target.Config,
-		MaxAttempts:  1,
+		MaxRetries:   0,
 		Method:       event.Method,
 		Headers:      event.Headers,
 		ContentType:  event.ContentType,
@@ -215,7 +225,8 @@ func (c tsCase) run(t *testing.T) (iSetup, database.Delivery, string) {
 	s := newISetup(t)
 	sink := newTSSink(t)
 
-	target := tsSeedTarget(t, s.MainDB, s.WebhookID, sink.URL)
+	cfg := tsSlackConfig(t, sink.URL)
+	target := tsSeedTarget(t, s.MainDB, s.WebhookID, cfg)
 	event := tsSeedEvent(t, s.WebhookDB, s.WebhookID)
 
 	d := iSeedDelivery(
@@ -326,7 +337,8 @@ func TestFormatSlackMessageOverTaskReconstructedEvent(
 
 	s := newISetup(t)
 
-	target := tsSeedTarget(t, s.MainDB, s.WebhookID, tsUndeliverableHook)
+	cfg := tsSlackConfig(t, tsUndeliverableHook)
+	target := tsSeedTarget(t, s.MainDB, s.WebhookID, cfg)
 	event := tsSeedEvent(t, s.WebhookDB, s.WebhookID)
 
 	d := iSeedDelivery(
@@ -397,7 +409,8 @@ func TestEventReconstructionSurvivesAReapedRow(t *testing.T) {
 
 	s := newISetup(t)
 
-	target := tsSeedTarget(t, s.MainDB, s.WebhookID, tsUndeliverableHook)
+	cfg := tsSlackConfig(t, tsUndeliverableHook)
+	target := tsSeedTarget(t, s.MainDB, s.WebhookID, cfg)
 	event := tsSeedEvent(t, s.WebhookDB, s.WebhookID)
 
 	d := iSeedDelivery(

internal/delivery/export_test.go

@@ -12,11 +12,16 @@ import (
 	"github.com/prometheus/client_golang/prometheus"
 	"go.uber.org/fx"
 	"gorm.io/gorm"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
 	"sneak.berlin/go/webhooker/internal/metrics"
 )
 
+// ErrExportArchiveWriterEvicted exposes the sentinel returned by
+// an evicted archive writer. It carries the Err prefix rather
+// than this file's usual Export one because it is a sentinel
+// error.
+var ErrExportArchiveWriterEvicted = errArchiveWriterEvicted
+
 // Exported constants for test access.
 const (
 	ExportDeliveryChannelSize     = deliveryChannelSize
@@ -77,10 +82,10 @@ func ExportIsForwardableHeader(name string) bool {
 func ExportApplyRequestHeaders(
 	req *http.Request,
 	event *database.Event,
-	configured map[string]string,
+	cfg *HTTPTargetConfig,
 	userAgent string,
 ) []string {
-	return applyRequestHeaders(req, event, configured, userAgent)
+	return applyRequestHeaders(req, event, cfg, userAgent)
 }
 
 // ExportTruncate exposes truncate for testing.
@@ -137,10 +142,9 @@ func (e *Engine) ExportDeliverSlack(
 	d *database.Delivery,
 ) {
 	task := &Task{
-		DeliveryID:  d.ID,
+		DeliveryID: d.ID,
-		TargetID:    d.TargetID,
+		TargetID:   d.TargetID,
-		MaxAttempts: d.Target.MaxAttempts,
+		AttemptNum: 1,
-		AttemptNum:  1,
 	}
 
 	e.targets[database.TargetTypeSlack].Deliver(
@@ -158,11 +162,6 @@ func (e *Engine) ExportUpdateDeliveryStatus(
 	return e.updateDeliveryStatus(webhookDB, d, "", status)
 }
 
-// ExportNotify exposes notify.
-func (e *Engine) ExportNotify(tasks []Task) {
-	e.notify(tasks)
-}
-
 // ExportProcessNewTask exposes processNewTask.
 func (e *Engine) ExportProcessNewTask(
 	ctx context.Context, task *Task,
@@ -221,23 +220,37 @@ func (e *Engine) ExportSetSlackCircuitBreaker(
 	e.slackTarget.circuitBreakers.Store(targetID, cb)
 }
 
+// ExportParseHTTPConfig exposes parseHTTPConfig.
+func (e *Engine) ExportParseHTTPConfig(
+	configJSON string,
+) (*HTTPTargetConfig, error) {
+	return parseHTTPConfig(configJSON)
+}
+
+// ExportParseSlackConfig exposes parseSlackConfig.
+func (e *Engine) ExportParseSlackConfig(
+	configJSON string,
+) (*SlackTargetConfig, error) {
+	return parseSlackConfig(configJSON)
+}
+
 // ExportDoHTTPRequest exposes the http target's
 // doHTTPRequest.
 func (e *Engine) ExportDoHTTPRequest(
 	ctx context.Context,
-	target *database.Target,
+	cfg *HTTPTargetConfig,
 	event *database.Event,
 ) (int, string, int64, error) {
-	return e.httpTarget.doHTTPRequest(ctx, target, event)
+	return e.httpTarget.doHTTPRequest(ctx, cfg, event)
 }
 
 // ExportClientForRequest exposes the http target's
 // clientForRequest.
 func (e *Engine) ExportClientForRequest(
-	timeoutSeconds int,
+	cfg *HTTPTargetConfig,
 	originScoped []string,
 ) *http.Client {
-	return e.httpTarget.clientForRequest(timeoutSeconds, originScoped)
+	return e.httpTarget.clientForRequest(cfg, originScoped)
 }
 
 // ErrExportTooManyRedirects exposes the sentinel the redirect
@@ -272,27 +285,32 @@ func (e *Engine) ExportRecoverPendingDeliveries(
 	ctx context.Context,
 	webhookDB *gorm.DB,
 	webhookID string,
-	atStart bool,
 ) {
 	e.recoverPendingDeliveries(
-		ctx, webhookDB, webhookID, atStart,
+		ctx, webhookDB, webhookID,
 	)
 }
 
 // ExportRecoverWebhookDeliveries exposes
 // recoverWebhookDeliveries.
 func (e *Engine) ExportRecoverWebhookDeliveries(
-	ctx context.Context, webhookID string, atStart bool,
+	ctx context.Context, webhookID string,
 ) {
-	e.recoverWebhookDeliveries(ctx, webhookID, atStart)
+	e.recoverWebhookDeliveries(ctx, webhookID)
 }
 
-// ExportRecoverDeliveries exposes recoverDeliveries, the recovery
+// ExportRecoverInFlight exposes recoverInFlight.
-// routine.
+func (e *Engine) ExportRecoverInFlight(
-func (e *Engine) ExportRecoverDeliveries(
+	ctx context.Context,
-	ctx context.Context, atStart bool,
 ) {
-	e.recoverDeliveries(ctx, atStart)
+	e.recoverInFlight(ctx)
+}
+
+// ExportSweepWebhookRetries exposes sweepWebhookRetries.
+func (e *Engine) ExportSweepWebhookRetries(
+	ctx context.Context, webhookID string,
+) {
+	e.sweepWebhookRetries(ctx, webhookID)
 }
 
 // ExportStart exposes start for testing.
@@ -339,9 +357,9 @@ func (e *Engine) ExportRetainDelivery(deliveryID string) bool {
 
 // ExportRecoverRetryingDeliveries exposes recoverRetryingDeliveries.
 func (e *Engine) ExportRecoverRetryingDeliveries(
-	ctx context.Context, webhookDB *gorm.DB, webhookID string,
+	webhookDB *gorm.DB, webhookID string,
 ) {
-	e.recoverRetryingDeliveries(ctx, webhookDB, webhookID)
+	e.recoverRetryingDeliveries(webhookDB, webhookID)
 }
 
 // ExportFailMissingTarget exposes failMissingTarget, so a test can hand
@@ -380,8 +398,7 @@ func (e *Engine) ExportRetryCh() chan Task {
 }
 
 // NewTestEngine creates an Engine for unit tests without
-// database dependencies. Its archive writers have no data
+// database dependencies.
-// directory, so a delivery to a database target fails.
 func NewTestEngine(
 	log *slog.Logger,
 	client *http.Client,
@@ -393,7 +410,6 @@ func NewTestEngine(
 		retryCh:    make(chan Task, retryChannelSize),
 		workers:    workers,
 		mtr:        metrics.New(prometheus.NewRegistry()),
-		archives:   archive.NewWriters(archive.WritersParams{Logger: log}),
 	}
 	e.initTargets(client)
 
@@ -406,10 +422,9 @@ func NewTestEngineSmallRetry(
 	log *slog.Logger,
 ) *Engine {
 	e := &Engine{
-		log:      log,
+		log:     log,
-		retryCh:  make(chan Task, 1),
+		retryCh: make(chan Task, 1),
-		mtr:      metrics.New(prometheus.NewRegistry()),
+		mtr:     metrics.New(prometheus.NewRegistry()),
-		archives: archive.NewWriters(archive.WritersParams{Logger: log}),
 	}
 	e.initTargets(nil)
 
@@ -417,8 +432,7 @@ func NewTestEngineSmallRetry(
 }
 
 // NewTestEngineWithDB creates an Engine with a real
-// database and dbManager for integration tests, and archive
+// database and dbManager for integration tests.
-// writers of its own over the same two.
 func NewTestEngineWithDB(
 	db *database.Database,
 	dbMgr *database.WebhookDBManager,
@@ -434,22 +448,12 @@ func NewTestEngineWithDB(
 		retryCh:    make(chan Task, retryChannelSize),
 		workers:    workers,
 		mtr:        metrics.New(prometheus.NewRegistry()),
-		archives: archive.NewWriters(archive.WritersParams{
-			Database:  db,
-			DBManager: dbMgr,
-			Logger:    log,
-		}),
 	}
 	e.initTargets(client)
 
 	return e
 }
 
-// ExportArchives returns the engine's archive writers.
-func (e *Engine) ExportArchives() *archive.Writers {
-	return e.archives
-}
-
 // ExportSetMetrics substitutes the engine's metric set, so a test can
 // assert on collectors registered on a registry it holds.
 func (e *Engine) ExportSetMetrics(mtr *metrics.Set) {
@@ -472,3 +476,273 @@ func NewTestCircuitBreaker(
 		cooldown:  cooldown,
 	}
 }
+
+// ExportArchivedEvent aliases the archive row type so black-box
+// tests can construct and read archive rows.
+type ExportArchivedEvent = archivedEvent
+
+// ExportArchiveWriter wraps an archiveWriter so black-box tests
+// can exercise the archive file mechanics.
+type ExportArchiveWriter struct {
+	w *archiveWriter
+}
+
+// NewExportArchiveWriter builds an archive writer for tests,
+// optionally overriding the reopen debounce (a non-positive
+// debounce keeps the production default).
+func NewExportArchiveWriter(
+	path string, log *slog.Logger, debounce time.Duration,
+) *ExportArchiveWriter {
+	w := newArchiveWriter(path, log)
+	if debounce > 0 {
+		w.debounce = debounce
+	}
+
+	return &ExportArchiveWriter{w: w}
+}
+
+// Write archives a row through the writer, into the file named
+// without a period.
+func (e *ExportArchiveWriter) Write(
+	row ExportArchivedEvent, expiry time.Duration,
+) error {
+	return e.w.write(row, expiry, "")
+}
+
+// WritePeriod archives a row through the writer, into the file for
+// period.
+func (e *ExportArchiveWriter) WritePeriod(
+	row ExportArchivedEvent, expiry time.Duration, period string,
+) error {
+	return e.w.write(row, expiry, period)
+}
+
+// Open opens the archive file, pruning when expiry is positive.
+func (e *ExportArchiveWriter) Open(expiry time.Duration) error {
+	return e.w.open(e.w.path, expiry)
+}
+
+// Reopen closes and reopens the archive file.
+func (e *ExportArchiveWriter) Reopen(
+	expiry time.Duration,
+) error {
+	return e.w.reopen(e.w.path, expiry)
+}
+
+// SetNow replaces the clock the writer measures its reopen
+// debounce on.
+func (e *ExportArchiveWriter) SetNow(now func() time.Time) {
+	e.w.now = now
+}
+
+// Reopens reports how many times the file has been opened.
+func (e *ExportArchiveWriter) Reopens() int {
+	return e.w.reopens
+}
+
+// DB returns the writer's current open handle for row
+// inspection in tests.
+func (e *ExportArchiveWriter) DB() *gorm.DB {
+	return e.w.db
+}
+
+// Path returns the archive file the writer owns.
+func (e *ExportArchiveWriter) Path() string {
+	return e.w.path
+}
+
+// OpenExisting opens the archive without permitting creation,
+// the way the idle sweep does.
+func (e *ExportArchiveWriter) OpenExisting(
+	expiry time.Duration,
+) error {
+	return e.w.openMode(e.w.path, archiveModeExisting, expiry)
+}
+
+// SweepExpired runs an idle sweep of the archive.
+func (e *ExportArchiveWriter) SweepExpired(
+	expiry time.Duration,
+) error {
+	return e.w.sweepExpired(expiry)
+}
+
+// Evict marks the writer evicted and closes its handle, exactly
+// as leaving the registry does.
+func (e *ExportArchiveWriter) Evict() {
+	e.w.evict()
+}
+
+// Rename gives the archive file a new name in the same directory,
+// as a rename of the webhook or target does.
+func (e *ExportArchiveWriter) Rename(name string) error {
+	return e.w.rename(name)
+}
+
+// HandleOpen reports whether the writer currently holds an open
+// archive handle.
+func (e *ExportArchiveWriter) HandleOpen() bool {
+	e.w.mu.Lock()
+	defer e.w.mu.Unlock()
+
+	return e.w.db != nil
+}
+
+// Same reports whether both wrappers refer to the very same
+// underlying archive writer, so a test can prove a registry entry
+// is the writer it was handed rather than a replacement.
+func (e *ExportArchiveWriter) Same(
+	other *ExportArchiveWriter,
+) bool {
+	return other != nil && e.w == other.w
+}
+
+// ExportArchiveWriterFor returns the archive writer the registry
+// currently caches for a database target, or nil when none is
+// cached. It never creates one, so a test can hold a reference to
+// the very writer an eviction is about to detach.
+func (e *Engine) ExportArchiveWriterFor(
+	targetID string,
+) *ExportArchiveWriter {
+	e.dbTarget.mu.Lock()
+	defer e.dbTarget.mu.Unlock()
+
+	w, ok := e.dbTarget.writers[targetID]
+	if !ok {
+		return nil
+	}
+
+	return &ExportArchiveWriter{w: w}
+}
+
+// ExportHasArchiveWriter reports whether the database target
+// type currently caches an archive writer for a target.
+func (e *Engine) ExportHasArchiveWriter(
+	targetID string,
+) bool {
+	e.dbTarget.mu.Lock()
+	defer e.dbTarget.mu.Unlock()
+
+	_, ok := e.dbTarget.writers[targetID]
+
+	return ok
+}
+
+// ExportArchiveHandleOpen reports whether the cached archive
+// writer for a target holds an open database handle. It
+// returns false when no writer is cached.
+func (e *Engine) ExportArchiveHandleOpen(
+	targetID string,
+) bool {
+	e.dbTarget.mu.Lock()
+	w, ok := e.dbTarget.writers[targetID]
+	e.dbTarget.mu.Unlock()
+
+	if !ok {
+		return false
+	}
+
+	w.mu.Lock()
+	defer w.mu.Unlock()
+
+	return w.db != nil
+}
+
+// ExportEnsureArchiveWriter creates (if needed) and returns the
+// archive file path of the cached writer for a target, so a
+// test can prime the registry the way a delivery would.
+func (e *Engine) ExportEnsureArchiveWriter(
+	targetID string,
+) (string, error) {
+	w, err := e.dbTarget.writerFor(targetID)
+	if err != nil {
+		return "", err
+	}
+
+	return w.path, nil
+}
+
+// ExportSweepWriterFor takes a target's registry writer exactly
+// as the idle sweep does, reporting whether the sweep had to
+// create the entry. It lets a test drive the registry through the
+// sweep's own entry point instead of choreographing goroutines.
+func (e *Engine) ExportSweepWriterFor(
+	targetID string,
+) (*ExportArchiveWriter, bool, error) {
+	w, created, err := e.dbTarget.sweepWriterFor(targetID)
+	if err != nil {
+		return nil, false, err
+	}
+
+	return &ExportArchiveWriter{w: w}, created, nil
+}
+
+// ExportReleaseSweepWriter releases a sweep-created registry entry
+// exactly as a finished sweep does.
+func (e *Engine) ExportReleaseSweepWriter(
+	targetID string, w *ExportArchiveWriter,
+) {
+	e.dbTarget.releaseSweepWriter(targetID, w.w)
+}
+
+// NewTestArchiveSweeper builds an ArchiveSweeper backed by the
+// given main database and engine, without the fx lifecycle.
+// Intended for tests.
+func NewTestArchiveSweeper(
+	db *database.Database,
+	eng *Engine,
+	log *slog.Logger,
+) *ArchiveSweeper {
+	return &ArchiveSweeper{
+		db:       db,
+		eng:      eng,
+		log:      log,
+		interval: time.Hour,
+	}
+}
+
+// ExportSweep runs a single archive sweep synchronously for
+// tests.
+func (s *ArchiveSweeper) ExportSweep(ctx context.Context) {
+	s.sweep(ctx)
+}
+
+// ExportStart starts the sweeper's background loop for tests.
+func (s *ArchiveSweeper) ExportStart() {
+	s.start()
+}
+
+// ExportRegisterHooks registers the sweeper's real fx lifecycle
+// hooks on a lifecycle supplied by a test, so a test can drive
+// the exact OnStart/OnStop functions the application runs and
+// hand OnStart the kind of context fx actually supplies.
+func (s *ArchiveSweeper) ExportRegisterHooks(lc fx.Lifecycle) {
+	s.registerHooks(lc)
+}
+
+// ExportStop stops the sweeper's background loop for tests.
+func (s *ArchiveSweeper) ExportStop(ctx context.Context) error {
+	return s.stop(ctx)
+}
+
+// ExportWedgeLoop adds a goroutine to the sweeper's WaitGroup
+// that never observes cancellation and returns only when release
+// is closed. It stands in for a prune stuck on a locked archive.
+func (s *ArchiveSweeper) ExportWedgeLoop(
+	release <-chan struct{},
+) {
+	s.wg.Go(func() {
+		<-release
+	})
+}
+
+// ExportSetInterval overrides the sweep interval for tests.
+func (s *ArchiveSweeper) ExportSetInterval(d time.Duration) {
+	s.interval = d
+}
+
+// ExportParseArchiveExpiry exposes parseArchiveExpiry.
+func ExportParseArchiveExpiry(
+	configJSON string,
+) (time.Duration, error) {
+	return parseArchiveExpiry(configJSON)
+}

internal/delivery/inflight.go

@@ -6,10 +6,10 @@ import "sync"
 //
 // A delivery is owned from the moment a task for it is handed to a
 // channel or to a retry timer until the engine has no further plan for
-// it in memory. The recovery routine, at start and on every tick of the
+// it in memory. Restart recovery and both arms of the periodic sweep
-// sweep, re-dispatches only deliveries the set does not hold, which is
+// re-dispatch only deliveries the set does not hold, which is what
-// what makes it exact rather than a guess about how long a row has sat
+// makes them exact rather than a guess about how long a row has sat at
-// at pending.
+// pending.
 //
 // This replaces reasoning from timestamps. A delivery's row says
 // pending from creation until its outcome is written, which covers
@@ -25,8 +25,8 @@ import "sync"
 // In-memory state is sufficient because a data directory admits one
 // process: internal/datadir takes an flock on it at startup and a
 // second instance refuses to run. Deliveries owned by a process that
-// died are not in any successor's set, and the recovery routine's run
+// died are not in any successor's set, and restart recovery is what
-// at start is what picks those up.
+// picks those up.
 //
 // References are counted rather than held as a plain set because
 // ownership outlives the worker that took it. A target that schedules
@@ -61,9 +61,9 @@ func (s *inflightSet) retain(deliveryID string) {
 
 // retainIdle takes the first reference on a delivery, and reports
 // whether it got it. It fails when the engine already owns the
-// delivery, which is what makes two claimants — notify and the
+// delivery, which is what makes two claimants — restart recovery and
-// recovery routine, say — mutually exclusive rather than merely
+// the sweep run concurrently, or two sweep arms — mutually exclusive
-// atomic.
+// rather than merely atomic.
 func (s *inflightSet) retainIdle(deliveryID string) bool {
 	s.mu.Lock()
 	defer s.mu.Unlock()

internal/delivery/inflight_test.go

@@ -2,6 +2,8 @@ package delivery_test
 
 import (
 	"context"
+	"path/filepath"
+	"strings"
 	"sync"
 	"testing"
 	"time"
@@ -30,7 +32,7 @@ func fSweepSetup(
 
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, name,
-		database.TargetTypeLog, "", 1,
+		database.TargetTypeLog, "", 0,
 	)
 
 	require.NoError(t, s.MainDB.Create(&database.Webhook{
@@ -64,6 +66,33 @@ func fDrain(e *delivery.Engine) []delivery.Task {
 	}
 }
 
+// TestArchiveHandleIsWAL closes the last gap in the durability
+// evidence: the main and per-webhook tiers each assert their journal
+// mode on a live handle, and the archive tier gets its settings from
+// the same code path but nothing checked the running file.
+func TestArchiveHandleIsWAL(t *testing.T) {
+	t.Parallel()
+
+	w := delivery.NewExportArchiveWriter(
+		filepath.Join(t.TempDir(), "archive-wal.db"),
+		archiveTestLogger(), 0,
+	)
+
+	require.NoError(t, w.Open(0))
+
+	var mode string
+
+	row := w.DB().Raw("pragma journal_mode").Row()
+	require.NoError(t, row.Scan(&mode))
+	assert.Equal(t, "wal", strings.ToLower(mode))
+
+	var busy string
+
+	row = w.DB().Raw("pragma busy_timeout").Row()
+	require.NoError(t, row.Scan(&busy))
+	assert.Equal(t, "10000", busy)
+}
+
 // TestSweepLeavesAQueuedDeliveryAlone is the case the age bound cannot
 // see. The delivery is queued and untouched, so its row is arbitrarily
 // old and still perfectly healthy; only ownership distinguishes it
@@ -84,9 +113,9 @@ func TestSweepLeavesAQueuedDeliveryAlone(t *testing.T) {
 	)
 	rAgePending(t, s.WebhookDB, d.ID)
 
-	// Queued exactly as StoreEvent queues it, and never dequeued:
+	// Queued exactly as the receiver queues it, and never dequeued:
 	// no workers are running in this engine.
-	s.Engine.ExportNotify([]delivery.Task{{
+	s.Engine.Notify([]delivery.Task{{
 		DeliveryID: d.ID,
 		EventID:    event.ID,
 		WebhookID:  s.WebhookID,
@@ -95,8 +124,8 @@ func TestSweepLeavesAQueuedDeliveryAlone(t *testing.T) {
 
 	require.Equal(t, 1, s.Engine.ExportInflightHeld())
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	tasks := fDrain(s.Engine)
@@ -107,11 +136,9 @@ func TestSweepLeavesAQueuedDeliveryAlone(t *testing.T) {
 	)
 }
 
-// TestRecoveryAndSweepDoNotDoubleDispatch drives the recovery routine's
+// TestRecoveryAndSweepDoNotDoubleDispatch drives the two entry points
-// run at start and a tick of the sweep at once against one aged pending
+// the engine starts concurrently against one aged pending row. Before
-// row. The engine runs them one after the other, but notify can race
+// ownership they both dispatched it.
-// either, and ownership is what keeps any two claimants from both
-// sending. Before ownership the two runs both dispatched the row.
 func TestRecoveryAndSweepDoNotDoubleDispatch(t *testing.T) {
 	t.Parallel()
 
@@ -135,12 +162,12 @@ func TestRecoveryAndSweepDoNotDoubleDispatch(t *testing.T) {
 
 		wg.Go(func() {
 			s.Engine.ExportRecoverPendingDeliveries(
-				ctx, s.WebhookDB, s.WebhookID, atStart,
+				ctx, s.WebhookDB, s.WebhookID,
 			)
 		})
 		wg.Go(func() {
-			s.Engine.ExportRecoverWebhookDeliveries(
+			s.Engine.ExportSweepWebhookRetries(
-				ctx, s.WebhookID, onTick,
+				ctx, s.WebhookID,
 			)
 		})
 		wg.Wait()
@@ -202,7 +229,7 @@ func TestOwnershipIsReleasedAfterDelivery(t *testing.T) {
 
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, "released",
-		database.TargetTypeLog, "", 1,
+		database.TargetTypeLog, "", 0,
 	)
 
 	event := iSeedEvent(
@@ -224,7 +251,7 @@ func TestOwnershipIsReleasedAfterDelivery(t *testing.T) {
 
 	body := `{"released":true}`
 
-	s.Engine.ExportNotify([]delivery.Task{{
+	s.Engine.Notify([]delivery.Task{{
 		DeliveryID:   d.ID,
 		EventID:      event.ID,
 		WebhookID:    s.WebhookID,
@@ -248,11 +275,10 @@ func TestOwnershipIsReleasedAfterDelivery(t *testing.T) {
 }
 
 // TestNotifyAfterRecoveryDoesNotSendAgain is the startup race of
-// https://git.eeqj.de/sneak/webhooker/issues/299. StoreEvent has
+// https://git.eeqj.de/sneak/webhooker/issues/299. The receiver has
-// written a delivery, the recovery routine's run at start finds it
+// written a delivery, restart recovery finds it pending, sends it and
-// pending, sends it and releases it, and only then does StoreEvent's
+// releases it, and only then does the receiver's Notify for it arrive.
-// notify for it arrive. Nothing owns the delivery by then, so notify
+// Nothing owns the delivery by then, so Notify takes it.
-// takes it.
 func TestNotifyAfterRecoveryDoesNotSendAgain(t *testing.T) {
 	t.Parallel()
 
@@ -276,8 +302,7 @@ func TestNotifyAfterRecoveryDoesNotSendAgain(t *testing.T) {
 		)
 	}()
 
-	// The recovery routine's run at start sends the delivery and lets
+	// Restart recovery sends the delivery and lets it go.
-	// it go.
 	iWaitForDelivered(t, s.WebhookDB, d.ID)
 	require.Eventually(
 		t,
@@ -289,7 +314,7 @@ func TestNotifyAfterRecoveryDoesNotSendAgain(t *testing.T) {
 
 	body := event.Body
 
-	s.Engine.ExportNotify([]delivery.Task{{
+	s.Engine.Notify([]delivery.Task{{
 		DeliveryID:   d.ID,
 		EventID:      event.ID,
 		WebhookID:    s.WebhookID,
@@ -300,7 +325,7 @@ func TestNotifyAfterRecoveryDoesNotSendAgain(t *testing.T) {
 		EntrypointID: event.EntrypointID,
 	}})
 
-	// notify took the delivery, and a worker releases it once it has
+	// Notify took the delivery, and a worker releases it once it has
 	// run the task.
 	require.Eventually(
 		t,
@@ -338,7 +363,7 @@ func TestRetryingRecoverySkipsASuccessfulResult(t *testing.T) {
 	rSeedResult(t, s.WebhookDB, d.ID, 2, true)
 
 	s.Engine.ExportRecoverRetryingDeliveries(
-		context.Background(), s.WebhookDB, s.WebhookID,
+		s.WebhookDB, s.WebhookID,
 	)
 
 	assert.Empty(
@@ -353,8 +378,8 @@ func TestRetryingRecoverySkipsASuccessfulResult(t *testing.T) {
 	)
 }
 
-// TestRetryingSweepSkipsASuccessfulResult is the same rule on a tick of
+// TestRetryingSweepSkipsASuccessfulResult is the same rule on the
-// the sweep.
+// periodic sweep's retrying arm.
 func TestRetryingSweepSkipsASuccessfulResult(t *testing.T) {
 	t.Parallel()
 
@@ -372,8 +397,8 @@ func TestRetryingSweepSkipsASuccessfulResult(t *testing.T) {
 	rSeedResult(t, s.WebhookDB, d.ID, 1, false)
 	rSeedResult(t, s.WebhookDB, d.ID, 2, true)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	assert.Empty(t, fDrain(s.Engine))
@@ -424,8 +449,8 @@ func TestScheduledRetryIsNotSweptDuringBackoff(t *testing.T) {
 
 	require.Equal(t, 1, s.Engine.ExportInflightHeld())
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	assert.Empty(
@@ -437,8 +462,7 @@ func TestScheduledRetryIsNotSweptDuringBackoff(t *testing.T) {
 
 // TestRedispatchStampsTheRow pins the cadence control: a stranded
 // delivery that has just been handed out is not selected again by the
-// next tick a minute later. The stamp is stored in the same form as
+// next tick a minute later.
-// created_at.
 func TestRedispatchStampsTheRow(t *testing.T) {
 	t.Parallel()
 
@@ -457,7 +481,7 @@ func TestRedispatchStampsTheRow(t *testing.T) {
 
 	ctx := context.Background()
 
-	s.Engine.ExportRecoverWebhookDeliveries(ctx, s.WebhookID, onTick)
+	s.Engine.ExportSweepWebhookRetries(ctx, s.WebhookID)
 	require.Len(t, fDrain(s.Engine), 1)
 
 	var row database.Delivery
@@ -469,13 +493,4 @@ func TestRedispatchStampsTheRow(t *testing.T) {
 		"a re-dispatched delivery must be stamped so the "+
 			"next tick does not select it again",
 	)
-
-	var createdAt, updatedAt string
-
-	require.NoError(t, s.WebhookDB.Raw(
-		`SELECT CAST(created_at AS TEXT), CAST(updated_at AS TEXT)
-		FROM deliveries WHERE id = ?`, d.ID,
-	).Row().Scan(&createdAt, &updatedAt))
-	assertStoredTime(t, createdAt)
-	assertStoredTime(t, updatedAt)
 }

internal/delivery/metrics_test.go

@@ -192,7 +192,7 @@ func mDeliverOK(t *testing.T, s iSetup) {
 	body := event.Body
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"metrics-ok", ts.URL, 3, 1, &body,
+		"metrics-ok", iHTTPConfig(ts.URL), 3, 1, &body,
 	)
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &task)
@@ -226,17 +226,18 @@ func mExhaustRetries(t *testing.T, s iSetup) {
 	)
 
 	body := event.Body
+	cfg := iHTTPConfig(ts.URL)
 
 	// The retry below is only run if its target still exists; see
 	// https://git.eeqj.de/sneak/webhooker/issues/107.
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "metrics-fail",
-		database.TargetTypeHTTP, ts.URL, 2,
+		database.TargetTypeHTTP, cfg, 2,
 	)
 
 	first := iTask(
 		d, event, s.WebhookID, targetID,
-		"metrics-fail", ts.URL, 2, 1, &body,
+		"metrics-fail", cfg, 2, 1, &body,
 	)
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &first)
@@ -250,7 +251,7 @@ func mExhaustRetries(t *testing.T, s iSetup) {
 	// deterministic and off the wall clock.
 	second := iTask(
 		d, event, s.WebhookID, targetID,
-		"metrics-fail", ts.URL, 2, 2, &body,
+		"metrics-fail", cfg, 2, 2, &body,
 	)
 
 	s.Engine.ExportProcessRetryTask(
@@ -288,21 +289,22 @@ func TestDeliveryMetrics_CircuitBreakerGauge(t *testing.T) {
 	)
 
 	body := event.Body
+	cfg := iHTTPConfig(ts.URL)
 
-	// An attempt budget above the failure threshold, so the breaker
+	// A retry budget above the failure threshold, so the breaker
 	// rather than the budget is what stops the delivery.
-	maxAttempts := delivery.ExportDefaultFailureThreshold + 5
+	maxRetries := delivery.ExportDefaultFailureThreshold + 5
 
 	// The retries below are only run if their target still exists;
 	// see https://git.eeqj.de/sneak/webhooker/issues/107.
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "metrics-trip",
-		database.TargetTypeHTTP, ts.URL, maxAttempts,
+		database.TargetTypeHTTP, cfg, maxRetries,
 	)
 
 	first := iTask(
 		d, event, s.WebhookID, targetID,
-		"metrics-trip", ts.URL, maxAttempts, 1, &body,
+		"metrics-trip", cfg, maxRetries, 1, &body,
 	)
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &first)
@@ -314,7 +316,7 @@ func TestDeliveryMetrics_CircuitBreakerGauge(t *testing.T) {
 		ExportDefaultFailureThreshold; attempt++ {
 		task := iTask(
 			d, event, s.WebhookID, targetID,
-			"metrics-trip", ts.URL, maxAttempts, attempt, &body,
+			"metrics-trip", cfg, maxRetries, attempt, &body,
 		)
 
 		s.Engine.ExportProcessRetryTask(
@@ -361,16 +363,17 @@ func TestDeliveryMetrics_BreakerBlockedIsNotAnAttempt(
 	)
 
 	body := event.Body
-	maxAttempts := delivery.ExportDefaultFailureThreshold + 5
+	cfg := iHTTPConfig(ts.URL)
+	maxRetries := delivery.ExportDefaultFailureThreshold + 5
 
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "metrics-blocked",
-		database.TargetTypeHTTP, ts.URL, maxAttempts,
+		database.TargetTypeHTTP, cfg, maxRetries,
 	)
 
 	first := iTask(
 		d, event, s.WebhookID, targetID,
-		"metrics-blocked", ts.URL, maxAttempts, 1, &body,
+		"metrics-blocked", cfg, maxRetries, 1, &body,
 	)
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &first)
@@ -379,7 +382,7 @@ func TestDeliveryMetrics_BreakerBlockedIsNotAnAttempt(
 		ExportDefaultFailureThreshold; attempt++ {
 		task := iTask(
 			d, event, s.WebhookID, targetID,
-			"metrics-blocked", ts.URL, maxAttempts, attempt, &body,
+			"metrics-blocked", cfg, maxRetries, attempt, &body,
 		)
 
 		s.Engine.ExportProcessRetryTask(context.TODO(), &task)
@@ -402,7 +405,7 @@ func TestDeliveryMetrics_BreakerBlockedIsNotAnAttempt(
 
 	blocked := iTask(
 		d, event, s.WebhookID, targetID,
-		"metrics-blocked", ts.URL, maxAttempts,
+		"metrics-blocked", cfg, maxRetries,
 		delivery.ExportDefaultFailureThreshold+1, &body,
 	)
 
@@ -441,8 +444,8 @@ func TestDeliveryMetrics_OrphanedRetryFailureLabelled(
 		t, s, database.TargetTypeLog,
 	)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertStatus(t, s.WebhookDB, deliveryID,
@@ -471,7 +474,7 @@ func TestDeliveryMetrics_QueueDepthGauges(t *testing.T) {
 
 	iCreateTarget(t, s.MainDB, targetID, s.WebhookID,
 		"queue-depth-target", database.TargetTypeHTTP,
-		"https://example.com/hook", 3,
+		iHTTPConfig("https://example.com/hook"), 3,
 	)
 
 	event := iSeedEvent(

internal/delivery/queue_depth.go

@@ -20,8 +20,7 @@ const queueDepthSampleInterval = 30 * time.Second
 // to be seeded correctly at startup from rows written by a previous
 // process, and would drift permanently on any transition that failed
 // to persist. Counting is the measurement that cannot go wrong, and
-// it is the same whole-database walk each tick of the sweep already
+// it is the same whole-database walk the retry sweep already makes.
-// makes.
 func (e *Engine) queueDepthSampler(ctx context.Context) {
 	defer e.wg.Done()
 

internal/delivery/queue_depth_gormlog_test.go

@@ -102,7 +102,7 @@ func TestQueueDepthSample_LogsNoBoundValue(t *testing.T) {
 
 	iCreateTarget(t, mainDB.DB(), targetID, webhookID,
 		"queue-depth-gormlog-target", database.TargetTypeHTTP,
-		"https://example.com/hook", 3,
+		iHTTPConfig("https://example.com/hook"), 3,
 	)
 
 	event := iSeedEvent(

internal/delivery/recovery_durability_test.go

@@ -66,7 +66,7 @@ func TestRecoverySkipsPendingWithSuccessfulResult(
 
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, "already-delivered",
-		database.TargetTypeLog, "", 1,
+		database.TargetTypeLog, "", 0,
 	)
 
 	event := iSeedEvent(
@@ -88,7 +88,7 @@ func TestRecoverySkipsPendingWithSuccessfulResult(
 	)
 
 	s.Engine.ExportRecoverPendingDeliveries(
-		context.Background(), s.WebhookDB, s.WebhookID, atStart,
+		context.Background(), s.WebhookDB, s.WebhookID,
 	)
 
 	select {
@@ -129,7 +129,7 @@ func TestRecoveryContinuesTheAttemptNumbering(t *testing.T) {
 
 	iCreateTarget(t, s.MainDB, targetID,
 		s.WebhookID, "numbering",
-		database.TargetTypeLog, "", 1,
+		database.TargetTypeLog, "", 0,
 	)
 
 	event := iSeedEvent(
@@ -145,7 +145,7 @@ func TestRecoveryContinuesTheAttemptNumbering(t *testing.T) {
 	rSeedResult(t, s.WebhookDB, d.ID, 2, false)
 
 	s.Engine.ExportRecoverPendingDeliveries(
-		context.Background(), s.WebhookDB, s.WebhookID, atStart,
+		context.Background(), s.WebhookDB, s.WebhookID,
 	)
 
 	select {
@@ -183,8 +183,8 @@ func TestSweepRecoversStrandedPending(t *testing.T) {
 		database.DeliveryStatusPending,
 	)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	select {
@@ -230,7 +230,7 @@ func TestSweepClaimsAStrandedDeliveryOnlyOnce(t *testing.T) {
 
 	ctx := context.Background()
 
-	s.Engine.ExportRecoverWebhookDeliveries(ctx, s.WebhookID, onTick)
+	s.Engine.ExportSweepWebhookRetries(ctx, s.WebhookID)
 
 	select {
 	case task := <-s.Engine.ExportDeliveryCh():
@@ -246,7 +246,7 @@ func TestSweepClaimsAStrandedDeliveryOnlyOnce(t *testing.T) {
 		database.DeliveryStatusPending,
 	)
 
-	s.Engine.ExportRecoverWebhookDeliveries(ctx, s.WebhookID, onTick)
+	s.Engine.ExportSweepWebhookRetries(ctx, s.WebhookID)
 
 	select {
 	case task := <-s.Engine.ExportDeliveryCh():
@@ -258,9 +258,9 @@ func TestSweepClaimsAStrandedDeliveryOnlyOnce(t *testing.T) {
 	}
 }
 
-// TestSweepSettlesStrandedPendingWithoutResending is the reconcile on a
+// TestSweepSettlesStrandedPendingWithoutResending is the sweep's own
-// tick of the sweep: a stranded delivery holding a successful result is
+// version of the reconcile: a stranded delivery holding a successful
-// settled where it stands, and the receiver hears nothing.
+// result is settled where it stands, and the receiver hears nothing.
 func TestSweepSettlesStrandedPendingWithoutResending(
 	t *testing.T,
 ) {
@@ -280,8 +280,8 @@ func TestSweepSettlesStrandedPendingWithoutResending(
 	rSeedResult(t, s.WebhookDB, d.ID, 1, true)
 	rAgePending(t, s.WebhookDB, d.ID)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	select {
@@ -312,9 +312,8 @@ func TestSweepSettlesStrandedPendingWithoutResending(
 
 // TestFailedResultWriteLeavesDeliveryRecoverable is the rule the
 // targets now follow: a bookkeeping write that fails must not advance
-// the status, because pending and retrying are the states the recovery
+// the status, because pending and retrying are the states the sweeps
-// routine recovers and delivered is a claim the database refused to
+// recover and delivered is a claim the database refused to record.
-// record.
 func TestFailedResultWriteLeavesDeliveryRecoverable(
 	t *testing.T,
 ) {
@@ -355,17 +354,16 @@ func TestFailedResultWriteLeavesDeliveryRecoverable(
 		Status:   database.DeliveryStatusPending,
 		Event:    event,
 		Target: database.Target{
-			Name:        "unwritable",
+			Name:   "unwritable",
-			Type:        database.TargetTypeHTTP,
+			Type:   database.TargetTypeHTTP,
-			URL:         ts.URL,
+			Config: iHTTPConfig(ts.URL),
-			MaxAttempts: 1,
 		},
 	}
 	full.ID = d.ID
 
 	s.Engine.ExportDeliverHTTP(
 		context.Background(), s.WebhookDB, full,
-		&delivery.Task{DeliveryID: d.ID, MaxAttempts: 1, AttemptNum: 1},
+		&delivery.Task{DeliveryID: d.ID, AttemptNum: 1},
 	)
 
 	assert.Equal(
@@ -446,10 +444,10 @@ func TestFailedResultWriteWithRetriesLeavesDeliveryRecoverable(
 				Status:   database.DeliveryStatusPending,
 				Event:    event,
 				Target: database.Target{
-					Name:        "unwritable",
+					Name:       "unwritable",
-					Type:        database.TargetTypeHTTP,
+					Type:       database.TargetTypeHTTP,
-					URL:         ts.URL,
+					Config:     iHTTPConfig(ts.URL),
-					MaxAttempts: 3,
+					MaxRetries: 3,
 				},
 			}
 			full.ID = d.ID
@@ -459,8 +457,9 @@ func TestFailedResultWriteWithRetriesLeavesDeliveryRecoverable(
 			s.Engine.ExportDeliverHTTPWithScheduler(
 				context.Background(), s.WebhookDB, full,
 				&delivery.Task{
-					DeliveryID: d.ID, TargetID: targetID,
+					DeliveryID: d.ID,
-					MaxAttempts: 3, AttemptNum: 1,
+					TargetID:   targetID,
+					AttemptNum: 1,
 				},
 				sched,
 			)

internal/delivery/recovery_test.go

@@ -1,389 +0,0 @@
-package delivery_test
-
-import (
-	"context"
-	"log/slog"
-	"net/http"
-	"testing"
-	"time"
-
-	"github.com/google/uuid"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"sneak.berlin/go/webhooker/internal/database"
-	"sneak.berlin/go/webhooker/internal/database/databasetest"
-	"sneak.berlin/go/webhooker/internal/delivery"
-)
-
-// These tests cover the recovery routine, which the engine runs once
-// when it starts and then on every tick of the sweep
-// (https://git.eeqj.de/sneak/webhooker/issues/542). Every case runs it
-// both ways, each on a webhook of its own.
-
-// atStart and onTick are the two values of the recovery routine's
-// atStart parameter: its run when the engine starts, and a tick of the
-// sweep.
-const (
-	atStart = true
-	onTick  = false
-)
-
-// recoveryRun names one of the two runs of the recovery routine.
-type recoveryRun struct {
-	name    string
-	atStart bool
-}
-
-// recoveryRuns returns the routine's run at start and a tick.
-func recoveryRuns() []recoveryRun {
-	return []recoveryRun{
-		{"at start", atStart},
-		{"on a tick", onTick},
-	}
-}
-
-// recoverySetup gives a fresh webhook its main-database row and an http
-// target with retries, and returns the setup and the target's ID. No
-// worker runs, so whatever the routine queues stays in the channels for
-// the test to read, and nothing is sent to the target.
-func recoverySetup(t *testing.T) (iSetup, string) {
-	t.Helper()
-
-	s := newISetup(t)
-	targetID := uuid.New().String()
-
-	iCreateWebhook(t, s.MainDB, s.WebhookID, "recovery")
-	iCreateTarget(
-		t, s.MainDB, targetID, s.WebhookID, "recovery",
-		database.TargetTypeHTTP,
-		"http://example.com/hook", 20,
-	)
-
-	return s, targetID
-}
-
-// seedRecoveryDelivery seeds a delivery at status with the given
-// recorded attempts, failed but for the last when lastSucceeded is set,
-// all recorded now.
-func seedRecoveryDelivery(
-	t *testing.T,
-	s iSetup,
-	targetID string,
-	status database.DeliveryStatus,
-	attempts int,
-	lastSucceeded bool,
-) string {
-	t.Helper()
-
-	event := iSeedEvent(t, s.WebhookDB, s.WebhookID, `{"recovery":true}`)
-	d := iSeedDelivery(t, s.WebhookDB, event.ID, targetID, status)
-
-	for n := 1; n <= attempts; n++ {
-		rSeedResult(
-			t, s.WebhookDB, d.ID, n, lastSucceeded && n == attempts,
-		)
-	}
-
-	return d.ID
-}
-
-// backdateAttempts moves every recorded attempt of a delivery an hour
-// into the past, long past the backoff after its first attempt.
-func backdateAttempts(t *testing.T, s iSetup, deliveryID string) {
-	t.Helper()
-
-	require.NoError(t, s.WebhookDB.Model(&database.DeliveryResult{}).
-		Where("delivery_id = ?", deliveryID).
-		UpdateColumn("created_at", s.WebhookDB.NowFunc().Add(-time.Hour)).
-		Error)
-}
-
-// requireQueued waits for a task on ch. A retrying delivery reaches the
-// retry channel through a timer, even one due now, so it is waited for.
-func requireQueued(
-	t *testing.T, ch <-chan delivery.Task,
-) delivery.Task {
-	t.Helper()
-
-	select {
-	case task := <-ch:
-		return task
-	case <-time.After(5 * time.Second):
-		t.Fatal("the recovery routine queued nothing")
-
-		return delivery.Task{}
-	}
-}
-
-// assertNothingQueued asserts the engine queues nothing, giving a retry
-// timer that is due now the moment it needs to fire.
-func assertNothingQueued(t *testing.T, e *delivery.Engine) {
-	t.Helper()
-
-	select {
-	case task := <-e.ExportDeliveryCh():
-		t.Errorf("queued pending delivery %s", task.DeliveryID)
-	case task := <-e.ExportRetryCh():
-		t.Errorf("queued retrying delivery %s", task.DeliveryID)
-	case <-time.After(200 * time.Millisecond):
-	}
-}
-
-// TestRecovery_RetryingBackoffPassed: a retrying delivery whose backoff
-// is over is queued for its next attempt at once.
-func TestRecovery_RetryingBackoffPassed(t *testing.T) {
-	t.Parallel()
-
-	for _, run := range recoveryRuns() {
-		t.Run(run.name, func(t *testing.T) {
-			t.Parallel()
-
-			s, targetID := recoverySetup(t)
-			id := seedRecoveryDelivery(
-				t, s, targetID, database.DeliveryStatusRetrying, 1, false,
-			)
-			backdateAttempts(t, s, id)
-
-			s.Engine.ExportRecoverDeliveries(context.Background(), run.atStart)
-
-			task := requireQueued(t, s.Engine.ExportRetryCh())
-			assert.Equal(t, id, task.DeliveryID)
-			assert.Equal(t, 2, task.AttemptNum)
-			iAssertStatus(t, s.WebhookDB, id, database.DeliveryStatusRetrying)
-		})
-	}
-}
-
-// TestRecovery_RetryingBackoffNotPassed: a retrying delivery whose last
-// attempt was just now waits out the rest of its backoff, ten attempts
-// in, eight and a half minutes. It is not sent now, and the engine holds
-// it, so a later tick leaves it to the timer.
-func TestRecovery_RetryingBackoffNotPassed(t *testing.T) {
-	t.Parallel()
-
-	for _, run := range recoveryRuns() {
-		t.Run(run.name, func(t *testing.T) {
-			t.Parallel()
-
-			s, targetID := recoverySetup(t)
-			id := seedRecoveryDelivery(
-				t, s, targetID, database.DeliveryStatusRetrying, 10, false,
-			)
-
-			s.Engine.ExportRecoverDeliveries(context.Background(), run.atStart)
-
-			assertNothingQueued(t, s.Engine)
-			iAssertStatus(t, s.WebhookDB, id, database.DeliveryStatusRetrying)
-			assert.Equal(t, 1, s.Engine.ExportInflightHeld(),
-				"no retry timer holds the delivery",
-			)
-		})
-	}
-}
-
-// TestRecovery_PendingOlderThanTheAgeBound: a pending delivery untouched
-// for longer than the sweep's age bound is sent by either run.
-func TestRecovery_PendingOlderThanTheAgeBound(t *testing.T) {
-	t.Parallel()
-
-	for _, run := range recoveryRuns() {
-		t.Run(run.name, func(t *testing.T) {
-			t.Parallel()
-
-			s, targetID := recoverySetup(t)
-			id := seedRecoveryDelivery(
-				t, s, targetID, database.DeliveryStatusPending, 0, false,
-			)
-			rAgePending(t, s.WebhookDB, id)
-
-			s.Engine.ExportRecoverDeliveries(context.Background(), run.atStart)
-
-			task := requireQueued(t, s.Engine.ExportDeliveryCh())
-			assert.Equal(t, id, task.DeliveryID)
-			assert.Equal(t, 1, task.AttemptNum)
-		})
-	}
-}
-
-// TestRecovery_TaskCarriesEveryTargetSetting: the task the recovery
-// routine queues carries every one of the target's settings, all six
-// set here.
-// They are copied into the task one field at a time, and a field left
-// out is sent empty without any error.
-func TestRecovery_TaskCarriesEveryTargetSetting(t *testing.T) {
-	t.Parallel()
-
-	for _, run := range recoveryRuns() {
-		t.Run(run.name, func(t *testing.T) {
-			t.Parallel()
-
-			s := newISetup(t)
-			iCreateWebhook(t, s.MainDB, s.WebhookID, "recovery")
-
-			target := database.Target{
-				WebhookID:       s.WebhookID,
-				Name:            "recovery",
-				Type:            database.TargetTypeHTTP,
-				Active:          true,
-				URL:             "http://example.com/hook",
-				Headers:         map[string]string{headerAuthorization: "Bearer t"},
-				TimeoutSeconds:  7,
-				ForwardQuery:    true,
-				ArchiveExpiry:   time.Hour,
-				ArchiveRotation: "daily",
-				MaxAttempts:     1,
-			}
-			require.NoError(t, s.MainDB.Create(&target).Error)
-
-			id := seedRecoveryDelivery(
-				t, s, target.ID, database.DeliveryStatusPending, 0, false,
-			)
-			rAgePending(t, s.WebhookDB, id)
-
-			s.Engine.ExportRecoverDeliveries(context.Background(), run.atStart)
-
-			task := requireQueued(t, s.Engine.ExportDeliveryCh())
-			assert.Equal(t, target.ID, task.TargetID)
-			assert.Equal(t, target.URL, task.TargetURL)
-			assert.Equal(t, target.Headers, task.TargetHeaders)
-			assert.Equal(t, target.TimeoutSeconds, task.TimeoutSeconds)
-			assert.Equal(t, target.ForwardQuery, task.ForwardQuery)
-			assert.Equal(t, target.ArchiveExpiry, task.ArchiveExpiry)
-			assert.Equal(t, target.ArchiveRotation, task.ArchiveRotation)
-		})
-	}
-}
-
-// TestRecovery_PendingYoungerThanTheAgeBound: a pending delivery touched
-// a moment ago, as one a stop cut off is, is sent at start, which is how
-// it reaches its target on the next start
-// (https://git.eeqj.de/sneak/webhooker/issues/527). A tick leaves it.
-func TestRecovery_PendingYoungerThanTheAgeBound(t *testing.T) {
-	t.Parallel()
-
-	for _, run := range recoveryRuns() {
-		t.Run(run.name, func(t *testing.T) {
-			t.Parallel()
-
-			s, targetID := recoverySetup(t)
-			id := seedRecoveryDelivery(
-				t, s, targetID, database.DeliveryStatusPending, 0, false,
-			)
-
-			s.Engine.ExportRecoverDeliveries(context.Background(), run.atStart)
-
-			if run.atStart {
-				task := requireQueued(t, s.Engine.ExportDeliveryCh())
-				assert.Equal(t, id, task.DeliveryID)
-
-				return
-			}
-
-			assertNothingQueued(t, s.Engine)
-			iAssertStatus(t, s.WebhookDB, id, database.DeliveryStatusPending)
-			assert.Zero(t, s.Engine.ExportInflightHeld())
-		})
-	}
-}
-
-// TestRecovery_AlreadySucceeded: a pending or retrying delivery whose
-// success is recorded but whose status write was lost is marked
-// delivered where it stands, and not sent again.
-func TestRecovery_AlreadySucceeded(t *testing.T) {
-	t.Parallel()
-
-	for _, run := range recoveryRuns() {
-		t.Run(run.name, func(t *testing.T) {
-			t.Parallel()
-
-			s, targetID := recoverySetup(t)
-			pending := seedRecoveryDelivery(
-				t, s, targetID, database.DeliveryStatusPending, 1, true,
-			)
-			rAgePending(t, s.WebhookDB, pending)
-
-			retrying := seedRecoveryDelivery(
-				t, s, targetID, database.DeliveryStatusRetrying, 2, true,
-			)
-			backdateAttempts(t, s, retrying)
-
-			s.Engine.ExportRecoverDeliveries(context.Background(), run.atStart)
-
-			assertNothingQueued(t, s.Engine)
-
-			for id, attempts := range map[string]int{pending: 1, retrying: 2} {
-				iAssertStatus(
-					t, s.WebhookDB, id, database.DeliveryStatusDelivered,
-				)
-				assert.Len(t, iResults(t, s.WebhookDB, id), attempts,
-					"marking the delivery delivered recorded an attempt",
-				)
-			}
-		})
-	}
-}
-
-// TestRecovery_MissingDatabase: a tick leaves a webhook whose database
-// file is missing alone, and the run at start opens it, which creates an
-// empty one and reports the loss (see
-// TestRecoverDeliveries_ReportsAMissingWebhookDatabase).
-func TestRecovery_MissingDatabase(t *testing.T) {
-	t.Parallel()
-
-	mainDB := iMainDB(t)
-	webhookID := uuid.New().String()
-	iCreateWebhook(t, mainDB.DB(), webhookID, "missing-database")
-
-	dbMgr := databasetest.NewWebhookDBManager(t, t.TempDir())
-	t.Cleanup(func() { _ = dbMgr.CloseAll() })
-
-	engine := delivery.NewTestEngineWithDB(
-		mainDB, dbMgr,
-		slog.New(slog.DiscardHandler),
-		&http.Client{Timeout: 5 * time.Second}, 1,
-	)
-
-	engine.ExportRecoverDeliveries(context.Background(), onTick)
-	assert.False(t, dbMgr.DBExists(webhookID),
-		"a tick created the missing database",
-	)
-
-	engine.ExportRecoverDeliveries(context.Background(), atStart)
-	assert.True(t, dbMgr.DBExists(webhookID),
-		"the run at start did not open the missing database",
-	)
-}
-
-// TestRecovery_LeavesADeliveryTheEngineHolds: a delivery the engine is
-// working on, has queued, or holds a retry timer for is left alone by
-// either run, pending and retrying alike, however old.
-func TestRecovery_LeavesADeliveryTheEngineHolds(t *testing.T) {
-	t.Parallel()
-
-	for _, run := range recoveryRuns() {
-		t.Run(run.name, func(t *testing.T) {
-			t.Parallel()
-
-			s, targetID := recoverySetup(t)
-			pending := seedRecoveryDelivery(
-				t, s, targetID, database.DeliveryStatusPending, 0, false,
-			)
-			rAgePending(t, s.WebhookDB, pending)
-
-			retrying := seedRecoveryDelivery(
-				t, s, targetID, database.DeliveryStatusRetrying, 1, false,
-			)
-			backdateAttempts(t, s, retrying)
-
-			require.True(t, s.Engine.ExportRetainDelivery(pending))
-			require.True(t, s.Engine.ExportRetainDelivery(retrying))
-
-			s.Engine.ExportRecoverDeliveries(context.Background(), run.atStart)
-
-			assertNothingQueued(t, s.Engine)
-			iAssertStatus(t, s.WebhookDB, pending, database.DeliveryStatusPending)
-			iAssertStatus(t, s.WebhookDB, retrying, database.DeliveryStatusRetrying)
-			assert.Equal(t, 2, s.Engine.ExportInflightHeld())
-		})
-	}
-}

internal/delivery/redirect_test.go

@@ -85,14 +85,19 @@ func deliverWithProbeHeaders(
 		database.DeliveryStatusPending,
 	)
 
+	cfg, err := json.Marshal(delivery.HTTPTargetConfig{
+		URL: targetURL,
+		Headers: map[string]string{
+			probeHeaderName: probeHeaderValue,
+		},
+	})
+	require.NoError(t, err)
+
 	body := event.Body
 	task := iTask(
 		d, event, s.WebhookID, targetID,
-		"redirect-target", targetURL, 1, 1, &body,
+		"redirect-target", string(cfg), 0, 1, &body,
 	)
-	task.TargetHeaders = map[string]string{
-		probeHeaderName: probeHeaderValue,
-	}
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &task)
 
@@ -304,7 +309,8 @@ func TestRedirectPolicy_StopsAtHopCap(t *testing.T) {
 	)
 
 	client := engine.ExportClientForRequest(
-		0, []string{probeHeaderName},
+		&delivery.HTTPTargetConfig{URL: srv.URL},
+		[]string{probeHeaderName},
 	)
 	require.NotNil(t, client.CheckRedirect)
 
@@ -344,7 +350,7 @@ func TestApplyRequestHeaders_ReportsOriginScopedNames(t *testing.T) {
 	inbound, err := json.Marshal(map[string][]string{
 		inboundHeaderName: {inboundHeaderValue},
 		"Content-Type":    {testContentType},
-		headerUserAgent:   {"curl/8.7.1"},
+		"User-Agent":      {"curl/8.7.1"},
 		"Host":            {"inbound.example.com"},
 	})
 	require.NoError(t, err)
@@ -363,9 +369,11 @@ func TestApplyRequestHeaders_ReportsOriginScopedNames(t *testing.T) {
 			Headers:     string(inbound),
 			ContentType: testContentType,
 		},
-		map[string]string{
+		&delivery.HTTPTargetConfig{
-			probeHeaderName: probeHeaderValue,
+			Headers: map[string]string{
-			"Content-Type":  testContentType,
+				probeHeaderName: probeHeaderValue,
+				"Content-Type":  testContentType,
+			},
 		},
 		"webhooker/dev",
 	)

internal/delivery/store.go

@@ -1,164 +0,0 @@
-package delivery
-
-import (
-	"fmt"
-
-	"gorm.io/gorm"
-	"sneak.berlin/go/webhooker/internal/database"
-)
-
-// StoreEvent stores event with one pending delivery for each of its
-// webhook's active targets, and adds them to the totals, in one
-// transaction, then queues the deliveries. It returns how many
-// deliveries it created.
-//
-// The receiver stores every event it accepts through here, and a
-// resubmit stores its copy of a stored event, so every event is
-// stored, retried, SSRF-guarded and circuit-broken the same way however
-// it entered the system. CreateReplay is the only other place a
-// delivery is created.
-//
-// The targets are the webhook's active ones as they stand now: a
-// target created after a resubmitted event first arrived is included,
-// and an inactive one is skipped. An event with no active target is
-// stored with no deliveries.
-func (e *Engine) StoreEvent(event *database.Event) (int, error) {
-	var targets []database.Target
-
-	err := e.database.DB().Where(
-		"webhook_id = ? AND active = ?", event.WebhookID, true,
-	).Find(&targets).Error
-	if err != nil {
-		return 0, fmt.Errorf("loading active targets: %w", err)
-	}
-
-	webhookDB, err := e.dbManager.GetDB(event.WebhookID)
-	if err != nil {
-		return 0, fmt.Errorf("getting webhook database: %w", err)
-	}
-
-	event.BodyBytes = int64(len(event.Body))
-	tasks := make([]Task, 0, len(targets))
-
-	err = webhookDB.Transaction(func(tx *gorm.DB) error {
-		err := tx.Create(event).Error
-		if err != nil {
-			return fmt.Errorf("creating event: %w", err)
-		}
-
-		for i := range targets {
-			dlv, err := createDelivery(tx, event.ID, targets[i].ID, false)
-			if err != nil {
-				return err
-			}
-
-			tasks = append(tasks, buildTask(
-				dlv, event.WebhookID, event, &targets[i], 1,
-			))
-		}
-
-		err = database.AddEventTotals(tx, database.EventTotals{
-			Events: 1, LastEventAt: &event.CreatedAt,
-		})
-		if err != nil {
-			return err
-		}
-
-		// A resubmitted copy did not arrive on its entrypoint's URL, so
-		// it leaves the entrypoint's last event as it is.
-		if event.ResubmittedFromID != nil {
-			return nil
-		}
-
-		return database.AddEntrypointTotals(tx, database.EntrypointTotals{
-			EntrypointID: event.EntrypointID, LastEventAt: event.CreatedAt,
-		})
-	})
-	if err != nil {
-		return 0, err
-	}
-
-	// Counted here, after the commit: an event exists once it is
-	// durably stored, which is what the delivery counters are compared
-	// against on a dashboard. A resubmitted event counts too, because
-	// it produces deliveries that the delivery side counts; the
-	// resubmit counter is what separates the two.
-	e.mtr.EventReceived()
-
-	e.notify(tasks)
-
-	return len(tasks), nil
-}
-
-// CreateReplay creates one more pending delivery of the stored event
-// eventID to target, marked as a replay, adds it to the target's totals
-// in the same transaction, and queues it. It returns the new
-// delivery's id.
-//
-// The caller passes the target as it stands now and has already
-// decided the replay may go ahead. The delivery being replayed is not
-// touched.
-func (e *Engine) CreateReplay(
-	webhookID, eventID string, target *database.Target,
-) (string, error) {
-	webhookDB, err := e.dbManager.GetDB(webhookID)
-	if err != nil {
-		return "", fmt.Errorf("getting webhook database: %w", err)
-	}
-
-	event, err := e.loadEvent(webhookDB, eventID)
-	if err != nil {
-		return "", err
-	}
-
-	var dlv *database.Delivery
-
-	err = webhookDB.Transaction(func(tx *gorm.DB) error {
-		var err error
-
-		dlv, err = createDelivery(tx, event.ID, target.ID, true)
-
-		return err
-	})
-	if err != nil {
-		return "", err
-	}
-
-	e.notify([]Task{buildTask(dlv, webhookID, &event, target, 1)})
-
-	return dlv.ID, nil
-}
-
-// createDelivery writes a pending delivery of the event to the target
-// on the caller's transaction, and adds it to the target's totals.
-//
-// Neither Event nor Target is set on the row, and the per-webhook
-// database omits associations on every write in any case (see
-// internal/database/event_db_isolation.go), so the target's settings
-// are never copied into the event database.
-func createDelivery(
-	tx *gorm.DB, eventID, targetID string, replay bool,
-) (*database.Delivery, error) {
-	dlv := &database.Delivery{
-		EventID:  eventID,
-		TargetID: targetID,
-		Status:   database.DeliveryStatusPending,
-		Replay:   replay,
-	}
-
-	err := tx.Create(dlv).Error
-	if err != nil {
-		return nil, fmt.Errorf(
-			"creating delivery for target %s: %w", targetID, err,
-		)
-	}
-
-	err = database.AddTargetTotals(tx, database.TargetTotals{
-		TargetID: targetID, Deliveries: 1,
-	})
-	if err != nil {
-		return nil, err
-	}
-
-	return dlv, nil
-}

internal/delivery/store_test.go

@@ -1,386 +0,0 @@
-package delivery_test
-
-import (
-	"net/http"
-	"strings"
-	"testing"
-	"time"
-
-	"github.com/google/uuid"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"gorm.io/gorm"
-	"sneak.berlin/go/webhooker/internal/database"
-	"sneak.berlin/go/webhooker/internal/delivery"
-)
-
-// storeTestTarget creates an active http target of the setup's webhook
-// with every one of a target's settings set, so a task that drops one
-// of them differs from the target.
-func storeTestTarget(
-	t *testing.T, s iSetup, name string,
-) database.Target {
-	t.Helper()
-
-	target := database.Target{
-		WebhookID:       s.WebhookID,
-		Name:            name,
-		Type:            database.TargetTypeHTTP,
-		Active:          true,
-		URL:             "http://93.184.216.34/" + name,
-		Headers:         map[string]string{"X-Api-Key": "k"},
-		TimeoutSeconds:  7,
-		ForwardQuery:    true,
-		ArchiveExpiry:   time.Hour,
-		ArchiveRotation: rotationDaily,
-		MaxAttempts:     3,
-	}
-
-	require.NoError(t, s.MainDB.Create(&target).Error)
-
-	return target
-}
-
-// newStoreTestEvent returns an event of the setup's webhook as the
-// receiver builds one, not yet stored.
-func newStoreTestEvent(s iSetup, body string) *database.Event {
-	return &database.Event{
-		WebhookID:    s.WebhookID,
-		EntrypointID: uuid.New().String(),
-		Method:       http.MethodPost,
-		RawQuery:     "a=1&b=2",
-		Headers:      `{"X-Test":["yes"]}`,
-		ContentType:  testContentType,
-		Body:         body,
-	}
-}
-
-// queuedTasks takes every task the engine has queued so far. The
-// engine in these tests is never started, so nothing else takes them.
-func queuedTasks(e *delivery.Engine) []delivery.Task {
-	var tasks []delivery.Task
-
-	for {
-		select {
-		case task := <-e.ExportDeliveryCh():
-			tasks = append(tasks, task)
-		default:
-			return tasks
-		}
-	}
-}
-
-// assertTaskFor proves task carries delivery deliveryID of event to
-// target: every one of the target's settings and every event field.
-// They are copied into the task one field at a time, and a field left
-// out is sent empty without any error.
-func assertTaskFor(
-	t *testing.T,
-	task delivery.Task,
-	deliveryID string,
-	event *database.Event,
-	target *database.Target,
-) {
-	t.Helper()
-
-	assert.Equal(t, deliveryID, task.DeliveryID)
-	assert.Equal(t, event.ID, task.EventID)
-	assert.Equal(t, event.WebhookID, task.WebhookID)
-	assert.Equal(t, event.EntrypointID, task.EntrypointID)
-
-	assert.Equal(t, target.ID, task.TargetID)
-	assert.Equal(t, target.Name, task.TargetName)
-	assert.Equal(t, target.Type, task.TargetType)
-	assert.Equal(t, target.URL, task.TargetURL)
-	assert.Equal(t, target.Headers, task.TargetHeaders)
-	assert.Equal(t, target.TimeoutSeconds, task.TimeoutSeconds)
-	assert.Equal(t, target.ForwardQuery, task.ForwardQuery)
-	assert.Equal(t, target.ArchiveExpiry, task.ArchiveExpiry)
-	assert.Equal(t, target.ArchiveRotation, task.ArchiveRotation)
-	assert.Equal(t, target.MaxAttempts, task.MaxAttempts)
-
-	assert.Equal(t, event.Method, task.Method)
-	assert.Equal(t, event.RawQuery, task.RawQuery)
-	assert.Equal(t, event.Headers, task.Headers)
-	assert.Equal(t, event.ContentType, task.ContentType)
-	require.NotNil(t, task.Body)
-	assert.Equal(t, event.Body, *task.Body)
-
-	assert.Equal(t, 1, task.AttemptNum)
-}
-
-// storedDeliveries reads every delivery of an event.
-func storedDeliveries(
-	t *testing.T, db *gorm.DB, eventID string,
-) []database.Delivery {
-	t.Helper()
-
-	var deliveries []database.Delivery
-
-	require.NoError(t, db.Where("event_id = ?", eventID).
-		Find(&deliveries).Error)
-
-	return deliveries
-}
-
-// storedEventTotals reads the webhook's event totals.
-func storedEventTotals(t *testing.T, db *gorm.DB) database.EventTotals {
-	t.Helper()
-
-	var totals database.EventTotals
-
-	require.NoError(t, db.First(&totals).Error)
-
-	return totals
-}
-
-// countRows counts the rows of model in db.
-func countRows(t *testing.T, db *gorm.DB, model any) int64 {
-	t.Helper()
-
-	var n int64
-
-	require.NoError(t, db.Model(model).Count(&n).Error)
-
-	return n
-}
-
-// TestStoreEvent_StoresDeliveriesToActiveTargets proves StoreEvent
-// stores the event with one pending delivery to each active target and
-// none to an inactive one, adds them to the totals, and queues one task
-// per delivery.
-func TestStoreEvent_StoresDeliveriesToActiveTargets(t *testing.T) {
-	t.Parallel()
-
-	s := newISetup(t)
-	targets := []database.Target{
-		storeTestTarget(t, s, "first"),
-		storeTestTarget(t, s, "second"),
-	}
-	off := storeTestTarget(t, s, "off")
-
-	require.NoError(t, s.MainDB.Model(&database.Target{}).
-		Where("id = ?", off.ID).Update("active", false).Error)
-
-	event := newStoreTestEvent(s, `{"hello":"world"}`)
-
-	created, err := s.Engine.StoreEvent(event)
-	require.NoError(t, err)
-	assert.Equal(t, 2, created)
-
-	var stored database.Event
-
-	require.NoError(t, s.WebhookDB.First(&stored, "id = ?", event.ID).Error)
-	assert.Equal(t, event.Body, stored.Body)
-	assert.Equal(t, int64(len(event.Body)), stored.BodyBytes)
-
-	rows := storedDeliveries(t, s.WebhookDB, event.ID)
-	queued := queuedTasks(s.Engine)
-
-	require.Len(t, rows, 2)
-	require.Len(t, queued, 2)
-
-	deliveries := map[string]database.Delivery{}
-	for _, dlv := range rows {
-		deliveries[dlv.TargetID] = dlv
-	}
-
-	tasks := map[string]delivery.Task{}
-	for _, task := range queued {
-		tasks[task.TargetID] = task
-	}
-
-	for i := range targets {
-		dlv, ok := deliveries[targets[i].ID]
-		require.True(t, ok, "no delivery to %s", targets[i].Name)
-		assert.Equal(t, database.DeliveryStatusPending, dlv.Status)
-		assert.False(t, dlv.Replay)
-		assert.Equal(t, int64(1),
-			targetTotals(t, s.WebhookDB, targets[i].ID).Deliveries)
-
-		assertTaskFor(t, tasks[targets[i].ID], dlv.ID, event, &targets[i])
-	}
-
-	totals := storedEventTotals(t, s.WebhookDB)
-	assert.Equal(t, int64(1), totals.Events)
-	require.NotNil(t, totals.LastEventAt)
-	assert.True(t, totals.LastEventAt.Equal(stored.CreatedAt))
-
-	var entrypoint database.EntrypointTotals
-
-	require.NoError(t, s.WebhookDB.First(
-		&entrypoint, "entrypoint_id = ?", event.EntrypointID,
-	).Error)
-	assert.True(t, entrypoint.LastEventAt.Equal(stored.CreatedAt))
-}
-
-// TestStoreEvent_ResubmittedCopyLeavesTheEntrypoint proves a
-// resubmitted copy is counted among the webhook's events but leaves its
-// entrypoint's last event as it is: it did not arrive on that URL.
-func TestStoreEvent_ResubmittedCopyLeavesTheEntrypoint(t *testing.T) {
-	t.Parallel()
-
-	s := newISetup(t)
-	storeTestTarget(t, s, "only")
-
-	sourceID := uuid.New().String()
-	event := newStoreTestEvent(s, `{"copy":true}`)
-	event.ResubmittedFromID = &sourceID
-
-	created, err := s.Engine.StoreEvent(event)
-	require.NoError(t, err)
-	assert.Equal(t, 1, created)
-	assert.Len(t, queuedTasks(s.Engine), 1)
-
-	assert.Equal(t, int64(1), storedEventTotals(t, s.WebhookDB).Events)
-	assert.Zero(t, countRows(t, s.WebhookDB, &database.EntrypointTotals{}))
-}
-
-// TestStoreEvent_NoActiveTarget proves an event of a webhook with no
-// active target is stored with no delivery and nothing queued.
-func TestStoreEvent_NoActiveTarget(t *testing.T) {
-	t.Parallel()
-
-	s := newISetup(t)
-	event := newStoreTestEvent(s, `{"to":"nobody"}`)
-
-	created, err := s.Engine.StoreEvent(event)
-	require.NoError(t, err)
-	assert.Zero(t, created)
-
-	assert.Equal(t, int64(1), countRows(t, s.WebhookDB, &database.Event{}))
-	assert.Empty(t, storedDeliveries(t, s.WebhookDB, event.ID))
-	assert.Empty(t, queuedTasks(s.Engine))
-}
-
-// TestStoreEvent_LargeBodyIsNotCarried proves a body at the inline
-// limit is stored whole but left off the task, for the attempt to read
-// from the event row.
-func TestStoreEvent_LargeBodyIsNotCarried(t *testing.T) {
-	t.Parallel()
-
-	s := newISetup(t)
-	storeTestTarget(t, s, "only")
-
-	event := newStoreTestEvent(
-		s, strings.Repeat("x", delivery.MaxInlineBodySize),
-	)
-
-	_, err := s.Engine.StoreEvent(event)
-	require.NoError(t, err)
-
-	tasks := queuedTasks(s.Engine)
-	require.Len(t, tasks, 1)
-	assert.Nil(t, tasks[0].Body)
-
-	var stored database.Event
-
-	require.NoError(t, s.WebhookDB.First(&stored, "id = ?", event.ID).Error)
-	assert.Equal(t, event.Body, stored.Body)
-}
-
-// TestStoreEvent_RollsBackWhenAWriteFails proves the event, its
-// deliveries and its totals are one transaction: when the entrypoint
-// totals write fails, the last one, after the event, its delivery, the
-// target totals and the event totals were written, none of them is left
-// and nothing is queued.
-func TestStoreEvent_RollsBackWhenAWriteFails(t *testing.T) {
-	t.Parallel()
-
-	s := newISetup(t)
-	storeTestTarget(t, s, "only")
-
-	require.NoError(t,
-		s.WebhookDB.Migrator().DropTable(&database.EntrypointTotals{}))
-
-	_, err := s.Engine.StoreEvent(newStoreTestEvent(s, `{"lost":true}`))
-	require.Error(t, err)
-
-	assert.Zero(t, countRows(t, s.WebhookDB, &database.Event{}))
-	assert.Zero(t, countRows(t, s.WebhookDB, &database.Delivery{}))
-	assert.Zero(t, countRows(t, s.WebhookDB, &database.TargetTotals{}))
-
-	totals := storedEventTotals(t, s.WebhookDB)
-	assert.Zero(t, totals.Events)
-	assert.Nil(t, totals.LastEventAt)
-
-	assert.Empty(t, queuedTasks(s.Engine))
-	assert.Zero(t, s.Engine.ExportInflightHeld())
-}
-
-// TestCreateReplay_CreatesAndQueuesAReplay proves CreateReplay adds a
-// new pending delivery marked as a replay, counts it in the target's
-// totals, queues its task built from the target it was given and the
-// stored event, and leaves the delivery it repeats as it was. The
-// stored event has every event field set, so a task that drops one of
-// them differs from the event.
-func TestCreateReplay_CreatesAndQueuesAReplay(t *testing.T) {
-	t.Parallel()
-
-	s := newISetup(t)
-	target := storeTestTarget(t, s, "replayed")
-	event := newStoreTestEvent(s, `{"replay":"me"}`)
-	require.NoError(t, s.WebhookDB.Create(event).Error)
-
-	original := iSeedDelivery(
-		t, s.WebhookDB, event.ID, target.ID,
-		database.DeliveryStatusFailed,
-	)
-
-	deliveryID, err := s.Engine.CreateReplay(s.WebhookID, event.ID, &target)
-	require.NoError(t, err)
-
-	replay := storedDelivery(t, s.WebhookDB, deliveryID)
-	assert.Equal(t, event.ID, replay.EventID)
-	assert.Equal(t, target.ID, replay.TargetID)
-	assert.Equal(t, database.DeliveryStatusPending, replay.Status)
-	assert.True(t, replay.Replay)
-
-	assert.Equal(t, database.DeliveryStatusFailed,
-		storedDelivery(t, s.WebhookDB, original.ID).Status)
-	assert.Equal(t, int64(1),
-		targetTotals(t, s.WebhookDB, target.ID).Deliveries)
-
-	tasks := queuedTasks(s.Engine)
-	require.Len(t, tasks, 1)
-	assertTaskFor(t, tasks[0], deliveryID, event, &target)
-}
-
-// TestCreateReplay_RollsBackWhenAWriteFails proves the replay delivery
-// and its target totals are one transaction: when the totals write
-// fails, after the delivery was written, no new delivery is left and
-// nothing is queued.
-func TestCreateReplay_RollsBackWhenAWriteFails(t *testing.T) {
-	t.Parallel()
-
-	s := newISetup(t)
-	target := storeTestTarget(t, s, "replayed")
-	event := iSeedEvent(t, s.WebhookDB, s.WebhookID, `{"replay":"me"}`)
-	iSeedDelivery(
-		t, s.WebhookDB, event.ID, target.ID,
-		database.DeliveryStatusFailed,
-	)
-
-	require.NoError(t,
-		s.WebhookDB.Migrator().DropTable(&database.TargetTotals{}))
-
-	_, err := s.Engine.CreateReplay(s.WebhookID, event.ID, &target)
-	require.Error(t, err)
-
-	assert.Len(t, storedDeliveries(t, s.WebhookDB, event.ID), 1)
-	assert.Empty(t, queuedTasks(s.Engine))
-	assert.Zero(t, s.Engine.ExportInflightHeld())
-}
-
-// storedDelivery reads one delivery back.
-func storedDelivery(
-	t *testing.T, db *gorm.DB, deliveryID string,
-) database.Delivery {
-	t.Helper()
-
-	var dlv database.Delivery
-
-	require.NoError(t, db.First(&dlv, "id = ?", deliveryID).Error)
-
-	return dlv
-}

internal/delivery/target.go

@@ -13,8 +13,8 @@ import (
 // The engine provides one to each target so a target can own
 // its retries durably: it records the attempt, marks the
 // delivery retrying, and asks the Scheduler to deliver the
-// next attempt after delay — exactly what the engine's
+// next attempt after delay — exactly what the engine does for
-// recovery routine does for a retrying delivery.
+// its own restart recovery.
 type Scheduler interface {
 	ScheduleRetry(task Task, delay time.Duration)
 }
@@ -32,8 +32,7 @@ type Scheduler interface {
 // Engine.observeAttempt, alongside the DeliveryResult it records for
 // it. Deliver is also entered for attempts that never happen — an
 // open circuit breaker refuses one — so the count cannot be taken
-// from around this call. An attempt cut off by a stop is neither
+// from around this call.
-// counted nor recorded.
 type Target interface {
 	Deliver(
 		ctx context.Context,
@@ -45,20 +44,29 @@ type Target interface {
 }
 
 // rescheduler is implemented by targets that own durable
-// retries. The engine's recovery routine uses it to let the
+// retries. The engine's restart recovery and periodic sweep
-// target recompute the schedule for an orphaned retrying
+// use it to let the target recompute the schedule for an
-// delivery, keeping the retry schedule target-owned.
+// orphaned retrying delivery, keeping the retry schedule
-// Fire-and-forget targets do not implement it, and a retrying
+// target-owned. Fire-and-forget targets do not implement it
-// delivery found for one is terminally failed.
+// and their (never-occurring) retrying deliveries are
+// skipped.
 type rescheduler interface {
 	// remainingBackoff returns how long to wait before the
-	// next attempt of a recovered retrying delivery: zero once
+	// next attempt of a recovered retrying delivery.
-	// its backoff has passed.
 	remainingBackoff(
 		webhookDB *gorm.DB,
 		deliveryID string,
 		attemptNum int,
 	) time.Duration
+
+	// backoffElapsed reports whether the backoff window for
+	// the last attempt has already passed, so the periodic
+	// sweep can re-enqueue the delivery now.
+	backoffElapsed(
+		webhookDB *gorm.DB,
+		deliveryID string,
+		attemptNum int,
+	) bool
 }
 
 // attemptResult is the outcome of a single delivery attempt,
@@ -94,13 +102,16 @@ func (e *Engine) initTargets(client *http.Client) {
 		client:   client,
 	}
 
+	dbT := &databaseTarget{eng: e}
+
 	e.httpTarget = httpT
 	e.slackTarget = slackT
+	e.dbTarget = dbT
 
 	e.targets = map[database.TargetType]Target{
 		database.TargetTypeHTTP:     httpT,
 		database.TargetTypeSlack:    slackT,
-		database.TargetTypeDatabase: &databaseTarget{eng: e},
+		database.TargetTypeDatabase: dbT,
 		database.TargetTypeLog:      &logTarget{eng: e},
 	}
 }

internal/delivery/target_config_edit.go

@@ -0,0 +1,136 @@
+package delivery
+
+import (
+	"encoding/json"
+	"errors"
+	"fmt"
+
+	"sneak.berlin/go/webhooker/internal/database"
+)
+
+// errUnknownTargetTypeForEdit is returned when a stored target has a
+// type the edit form has no field set for.
+var errUnknownTargetTypeForEdit = errors.New(
+	"unknown target type",
+)
+
+// TargetConfigForm is the UNMASKED projection of a target's stored
+// configuration, for pre-filling the target edit form.
+//
+// It is the deliberate exception to the rule TargetView enforces
+// everywhere else: TargetView exists so that no template can render
+// a target's stored blob, because a destination URL's path segments
+// and a header value are both routinely the credential. An operator
+// cannot correct a value they cannot see, so the edit form — and
+// only the edit form — is shown the full value.
+//
+// Everything that keeps that exception narrow lives at the call
+// site: the route is behind RequireAuth and the webhook's ownership
+// check, and its group sets NoCache so the rendered secret is not
+// written to a shared cache. Do not reach for this type from any
+// other page.
+type TargetConfigForm struct {
+	// URL is the destination for an HTTP target and the webhook
+	// URL for a Slack target.
+	URL string
+	// Headers is the HTTP target's configured headers in the
+	// textarea representation, one "Name: value" per line.
+	Headers string
+	// Timeout is the HTTP target's per-request timeout in seconds,
+	// empty when unset.
+	Timeout string
+	// ForwardQuery is the HTTP target's setting that passes each
+	// event's query string on to it.
+	ForwardQuery bool
+	// Expiry is the database (archive) target's row expiry.
+	Expiry string
+	// Rotation is the database (archive) target's rotation.
+	Rotation string
+}
+
+// NewTargetConfigForm parses a target's stored configuration into
+// the edit form's fields.
+//
+// A configuration that does not parse is an error rather than a
+// zero-valued form that silently looks like a target with no
+// settings. The caller shows the operator that the stored value
+// could not be read, so that saving the form is understood as
+// replacing it rather than preserving it.
+func NewTargetConfigForm(
+	t *database.Target,
+) (TargetConfigForm, error) {
+	switch t.Type {
+	case database.TargetTypeHTTP:
+		cfg, err := parseHTTPConfig(t.Config)
+		if err != nil {
+			return TargetConfigForm{}, err
+		}
+
+		return TargetConfigForm{
+			URL:          cfg.URL,
+			Headers:      FormatTargetHeaders(cfg.Headers),
+			Timeout:      FormatTargetTimeout(cfg.Timeout),
+			ForwardQuery: cfg.ForwardQuery,
+		}, nil
+	case database.TargetTypeSlack:
+		cfg, err := parseSlackConfig(t.Config)
+		if err != nil {
+			return TargetConfigForm{}, err
+		}
+
+		return TargetConfigForm{URL: cfg.WebhookURL}, nil
+	case database.TargetTypeDatabase:
+		return databaseConfigForm(t.Config)
+	case database.TargetTypeLog:
+		// The log target takes no configuration.
+		return TargetConfigForm{}, nil
+	default:
+		return TargetConfigForm{}, fmt.Errorf(
+			"%w: %q", errUnknownTargetTypeForEdit, t.Type,
+		)
+	}
+}
+
+// databaseConfigForm parses an archive target's optional expiry and
+// rotation. An absent, empty or never expiry yields an empty expiry,
+// on which the edit form starts at never; saving it unchanged stores
+// never, which means the same as an empty expiry. An absent rotation
+// is empty too, and the form starts at none. An expiry that is set
+// but not a valid duration, or a rotation that is not one of the
+// four, is an error, not a blank field.
+func databaseConfigForm(
+	configJSON string,
+) (TargetConfigForm, error) {
+	if configJSON == "" {
+		return TargetConfigForm{}, nil
+	}
+
+	var cfg databaseTargetConfig
+
+	err := json.Unmarshal([]byte(configJSON), &cfg)
+	if err != nil {
+		return TargetConfigForm{}, fmt.Errorf(
+			"parsing config JSON: %w", err,
+		)
+	}
+
+	err = ValidateArchiveRotation(cfg.Rotation)
+	if err != nil {
+		return TargetConfigForm{}, err
+	}
+
+	form := TargetConfigForm{Rotation: cfg.Rotation}
+
+	if cfg.Expiry == "" || cfg.Expiry == archiveExpiryNever {
+		return form, nil
+	}
+
+	err = ValidateArchiveExpiry(cfg.Expiry)
+	if err != nil {
+		return TargetConfigForm{}, err
+	}
+
+	form.Expiry = cfg.Expiry
+
+	return form, nil
+}

internal/delivery/target_config_view.go

@@ -5,21 +5,19 @@ import (
 	"strconv"
 	"time"
 
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
 )
 
-// configUnavailable is what a target's settings render as when
+// configUnavailable is what a target's configuration renders
-// the target is of an unknown type, and what its URL renders as
+// as when it is absent, of an unknown type, or does not
-// when it does not parse into a scheme and host. The stored URL is
+// parse. The stored blob is never shown as a fallback: it can
-// never shown as a fallback: it can be a credential (a Slack
+// hold a credential (a Slack incoming webhook URL is a bearer
-// incoming webhook URL is a bearer token) and a UI that prints it
+// token) and a UI that prints it leaks that credential into
-// leaks that credential into browser history, screenshots and
+// browser history, screenshots and screen shares.
-// screen shares.
 const configUnavailable = "(unavailable)"
 
 // ConfigField is one labelled, display-safe value derived
-// from a target's settings.
+// from a target's stored configuration.
 type ConfigField struct {
 	Label string
 	Value string
@@ -33,9 +31,9 @@ type ConfigField struct {
 const deletedNameSuffix = " (deleted)"
 
 // TargetView is the display-safe projection of a target for
-// the UI. It deliberately has no URL or header field, so no
+// the UI. It deliberately has no raw configuration field, so
-// template — present or future — can render the stored
+// no template — present or future — can render the stored
-// credential.
+// blob.
 type TargetView struct {
 	ID   string
 	Name string
@@ -62,7 +60,8 @@ func (v TargetView) DisplayName() string {
 }
 
 // NewTargetViews projects targets for rendering, replacing
-// each target's settings with named, display-safe fields.
+// each stored configuration blob with named, display-safe
+// fields.
 //
 // A soft-deleted row projects exactly as a live one does, minus
 // the deleted marker on its name: masking is a property of the
@@ -91,8 +90,8 @@ func NewTargetViews(
 }
 
 // targetConfigFields returns the display-safe fields for a
-// target's settings. A target of an unknown type gets the
+// target's configuration. Anything it cannot parse becomes
-// neutral placeholder.
+// the neutral placeholder.
 func targetConfigFields(
 	t *database.Target,
 ) []ConfigField {
@@ -102,26 +101,37 @@ func targetConfigFields(
 	case database.TargetTypeHTTP:
 		return httpConfigFields(t)
 	case database.TargetTypeDatabase:
-		return databaseConfigFields(t)
+		return databaseConfigFields(t.Config)
 	case database.TargetTypeLog:
-		// The log target takes no settings.
+		// The log target takes no configuration.
 		return nil
 	default:
-		return []ConfigField{{
+		return unavailableConfigFields()
-			Label: "Configuration",
-			Value: configUnavailable,
-		}}
 	}
 }
 
+// unavailableConfigFields is the neutral placeholder shown
+// for a configuration that could not be presented.
+func unavailableConfigFields() []ConfigField {
+	return []ConfigField{{
+		Label: "Configuration",
+		Value: configUnavailable,
+	}}
+}
+
 // slackConfigFields describes a Slack target: its masked
-// webhook URL and its number of delivery attempts. Only the
+// webhook URL and its retry count. Only the masked URL is
-// masked URL is shown; the full URL is the credential.
+// shown; the full URL is the credential.
 func slackConfigFields(t *database.Target) []ConfigField {
+	cfg, err := parseSlackConfig(t.Config)
+	if err != nil {
+		return unavailableConfigFields()
+	}
+
 	return []ConfigField{{
 		Label: "Webhook URL",
-		Value: MaskURL(t.URL),
+		Value: cfg.MaskedWebhookURL(),
-	}, maxAttemptsField(t)}
+	}, maxRetriesField(t)}
 }
 
 // httpConfigFields describes an HTTP target: its destination
@@ -135,55 +145,79 @@ func slackConfigFields(t *database.Target) []ConfigField {
 // whose path segments are the credential, and the field takes
 // an arbitrary URL, so no segment can be assumed non-secret.
 func httpConfigFields(t *database.Target) []ConfigField {
+	cfg, err := parseHTTPConfig(t.Config)
+	if err != nil {
+		return unavailableConfigFields()
+	}
+
 	fields := []ConfigField{{
 		Label: "Destination URL",
-		Value: MaskURL(t.URL),
+		Value: MaskURL(cfg.URL),
 	}}
 
-	if t.TimeoutSeconds > 0 {
+	if cfg.Timeout > 0 {
 		fields = append(fields, ConfigField{
 			Label: "Timeout",
-			Value: strconv.Itoa(t.TimeoutSeconds) + "s",
+			Value: strconv.Itoa(cfg.Timeout) + "s",
 		})
 	}
 
-	if len(t.Headers) > 0 {
+	if len(cfg.Headers) > 0 {
 		fields = append(fields, ConfigField{
 			Label: "Headers",
 			Value: fmt.Sprintf(
-				"%d configured", len(t.Headers),
+				"%d configured", len(cfg.Headers),
 			),
 		})
 	}
 
-	if t.ForwardQuery {
+	if cfg.ForwardQuery {
 		fields = append(fields, ConfigField{
 			Label: "Query string",
 			Value: "passed on to this target",
 		})
 	}
 
-	fields = append(fields, maxAttemptsField(t))
+	fields = append(fields, maxRetriesField(t))
 
 	return fields
 }
 
-// maxAttemptsField describes a target's number of delivery
+// maxRetriesField describes a target's retry count, which lives
-// attempts.
+// on the target row rather than in its configuration blob. A
-func maxAttemptsField(t *database.Target) ConfigField {
+// stored 0 makes a single attempt, so it is shown as 1.
+func maxRetriesField(t *database.Target) ConfigField {
+	attempts := strconv.Itoa(t.MaxRetries)
+	if t.MaxRetries == 0 {
+		attempts = "1 (fire-and-forget: no retries, no circuit breaker)"
+	}
+
 	return ConfigField{
 		Label: "Delivery attempts",
-		Value: strconv.Itoa(t.MaxAttempts),
+		Value: attempts,
 	}
 }
 
 // databaseConfigFields describes an archive target by its
 // expiry in plain units, such as "30 days", or "never" when
-// the archive is kept forever, and by its rotation.
+// the archive is kept forever, and by its rotation. An expiry
-func databaseConfigFields(t *database.Target) []ConfigField {
+// that is set but not a valid duration, or a rotation that is
-	value := archive.ExpiryNever
+// not one of the four, is reported as unavailable rather than
-	if t.ArchiveExpiry > 0 {
+// echoed back.
-		value = plainDuration(t.ArchiveExpiry)
+func databaseConfigFields(configJSON string) []ConfigField {
+	expiry, err := parseArchiveExpiry(configJSON)
+	if err != nil {
+		return unavailableConfigFields()
+	}
+
+	rotation, err := parseArchiveRotation(configJSON)
+	if err != nil {
+		return unavailableConfigFields()
+	}
+
+	value := archiveExpiryNever
+	if expiry > 0 {
+		value = plainDuration(expiry)
 	}
 
 	return []ConfigField{{
@@ -191,7 +225,7 @@ func databaseConfigFields(t *database.Target) []ConfigField {
 		Value: value,
 	}, {
 		Label: "Archive rotation",
-		Value: t.ArchiveRotation,
+		Value: rotation,
 	}}
 }
 
@@ -227,3 +261,14 @@ func plainDuration(d time.Duration) string {
 
 	return d.String()
 }
+
+// MaskedWebhookURL returns the Slack webhook URL reduced to
+// its scheme and host, with the path, query and any userinfo
+// elided. The path segments are the credential, so none of
+// them is shown: the field accepts an arbitrary URL, so no
+// segment can be assumed non-secret. A URL that does not
+// parse into a scheme and host yields the neutral
+// placeholder, never the raw string.
+func (c *SlackTargetConfig) MaskedWebhookURL() string {
+	return MaskURL(c.WebhookURL)
+}

internal/delivery/target_config_view_test.go

@@ -32,20 +32,10 @@ const (
 	viewMaskedOrigin  = viewExampleOrigin + "/..."
 	viewUnavailable   = "(unavailable)"
 	viewExpiryNever   = "never"
-	viewMaxAttempts   = "Delivery attempts"
+	viewMaxRetries    = "Delivery attempts"
 )
 
-// The archive rotations a database target's settings can name.
+func TestMaskedWebhookURL(t *testing.T) {
-const (
-	rotationNone    = "none"
-	rotationMonthly = "monthly"
-	rotationDaily   = "daily"
-	rotationHourly  = "hourly"
-)
-
-// TestNewTargetViews_SlackMasksWebhookURL shows what a Slack target's
-// URL renders as on the target list.
-func TestNewTargetViews_SlackMasksWebhookURL(t *testing.T) {
 	t.Parallel()
 
 	tests := map[string]struct {
@@ -89,24 +79,28 @@ func TestNewTargetViews_SlackMasksWebhookURL(t *testing.T) {
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
-			target := slackTarget()
+			cfg := &delivery.SlackTargetConfig{
-			target.URL = tc.url
+				WebhookURL: tc.url,
+			}
 
 			assert.Equal(
-				t, tc.want,
+				t, tc.want, cfg.MaskedWebhookURL(),
-				fieldMap(viewFor(t, target).Config)["Webhook URL"],
 			)
 		})
 	}
 }
 
-// TestNewTargetViews_SlackNeverLeaksPath is the direct
+// TestMaskedWebhookURL_NeverLeaksPath is the direct
 // expression of the rule: whatever the input, the masked
 // value never contains a path segment of it.
-func TestNewTargetViews_SlackNeverLeaksPath(t *testing.T) {
+func TestMaskedWebhookURL_NeverLeaksPath(t *testing.T) {
 	t.Parallel()
 
-	masked := fieldMap(viewFor(t, slackTarget()).Config)["Webhook URL"]
+	cfg := &delivery.SlackTargetConfig{
+		WebhookURL: slackWebhookURL,
+	}
+
+	masked := cfg.MaskedWebhookURL()
 
 	assert.NotContains(t, masked, "T00000000")
 	assert.NotContains(t, masked, "B00000000")
@@ -172,11 +166,11 @@ func TestNewTargetViews_DeletedTarget(t *testing.T) {
 // share.
 func slackTarget() database.Target {
 	return database.Target{
-		Name:        slackTargetName,
+		Name:   slackTargetName,
-		Type:        database.TargetTypeSlack,
+		Type:   database.TargetTypeSlack,
-		Active:      true,
+		Active: true,
-		URL:         slackWebhookURL,
+		Config: `{"webhookUrl":"` +
-		MaxAttempts: 1,
+			slackWebhookURL + `"}`,
 	}
 }
 
@@ -195,29 +189,28 @@ func TestNewTargetViews_Slack(t *testing.T) {
 	assert.Equal(
 		t,
 		map[string]string{
-			"Webhook URL":   slackMaskedURL,
+			"Webhook URL":  slackMaskedURL,
-			viewMaxAttempts: "1",
+			viewMaxRetries: "1 (fire-and-forget: no retries, no circuit breaker)",
 		},
 		fieldMap(view.Config),
 	)
 }
 
-// TestNewTargetViews_SlackAttempts proves a Slack target shows
+// TestNewTargetViews_SlackRetries proves a Slack target shows
-// its number of delivery attempts the same way an HTTP target
+// its retry count the same way an HTTP target does.
-// does.
+func TestNewTargetViews_SlackRetries(t *testing.T) {
-func TestNewTargetViews_SlackAttempts(t *testing.T) {
 	t.Parallel()
 
 	target := slackTarget()
-	target.MaxAttempts = 2
+	target.MaxRetries = 2
 
 	view := viewFor(t, target)
 
 	assert.Equal(
 		t,
 		map[string]string{
-			"Webhook URL":   slackMaskedURL,
+			"Webhook URL":  slackMaskedURL,
-			viewMaxAttempts: "2",
+			viewMaxRetries: "2",
 		},
 		fieldMap(view.Config),
 	)
@@ -227,12 +220,12 @@ func TestNewTargetViews_HTTP(t *testing.T) {
 	t.Parallel()
 
 	view := viewFor(t, database.Target{
-		Type:           database.TargetTypeHTTP,
+		Type: database.TargetTypeHTTP,
-		URL:            viewExampleHook,
+		Config: `{"url":"` + viewExampleHook + `",` +
-		TimeoutSeconds: 30,
+			`"timeout":30,` +
-		Headers:        map[string]string{headerAuthorization: "Bearer sekrit"},
+			`"headers":{"Authorization":"Bearer sekrit"},` +
-		ForwardQuery:   true,
+			`"forwardQuery":true}`,
-		MaxAttempts:    5,
+		MaxRetries: 5,
 	})
 
 	fields := fieldMap(view.Config)
@@ -244,7 +237,7 @@ func TestNewTargetViews_HTTP(t *testing.T) {
 			"Timeout":         "30s",
 			"Headers":         "1 configured",
 			"Query string":    "passed on to this target",
-			viewMaxAttempts:   "5",
+			viewMaxRetries:    "5",
 		},
 		fields,
 	)
@@ -255,22 +248,19 @@ func TestNewTargetViews_HTTP(t *testing.T) {
 	}
 }
 
-// TestNewTargetViews_HTTPSingleAttempt proves a single attempt is
+func TestNewTargetViews_HTTPFireAndForget(t *testing.T) {
-// shown as the plain number, like any other.
-func TestNewTargetViews_HTTPSingleAttempt(t *testing.T) {
 	t.Parallel()
 
 	view := viewFor(t, database.Target{
-		Type:        database.TargetTypeHTTP,
+		Type:   database.TargetTypeHTTP,
-		URL:         viewExampleHook,
+		Config: `{"url":"` + viewExampleHook + `"}`,
-		MaxAttempts: 1,
 	})
 
 	assert.Equal(
 		t,
 		map[string]string{
 			"Destination URL": viewMaskedOrigin,
-			viewMaxAttempts:   "1",
+			viewMaxRetries:    "1 (fire-and-forget: no retries, no circuit breaker)",
 		},
 		fieldMap(view.Config),
 	)
@@ -284,9 +274,8 @@ func TestNewTargetViews_HTTPMasksDestinationURL(t *testing.T) {
 	t.Parallel()
 
 	view := viewFor(t, database.Target{
-		Type:        database.TargetTypeHTTP,
+		Type:   database.TargetTypeHTTP,
-		URL:         slackWebhookURL,
+		Config: `{"url":"` + slackWebhookURL + `"}`,
-		MaxAttempts: 1,
 	})
 
 	fields := fieldMap(view.Config)
@@ -309,20 +298,25 @@ func TestNewTargetViews_Database(t *testing.T) {
 	t.Parallel()
 
 	tests := map[string]struct {
-		expiry time.Duration
+		config string
 		want   string
 	}{
-		"never": {expiry: 0, want: viewExpiryNever},
+		"empty config": {config: "", want: viewExpiryNever},
-		"1h":    {expiry: time.Hour, want: "1 hour"},
+		"empty expiry": {config: `{}`, want: viewExpiryNever},
-		"12h":   {expiry: 12 * time.Hour, want: "12 hours"},
+		"never literal": {
-		"24h":   {expiry: 24 * time.Hour, want: "1 day"},
+			config: `{"expiry":"` + viewExpiryNever + `"}`,
-		"720h":  {expiry: 720 * time.Hour, want: "30 days"},
+			want:   viewExpiryNever,
-		"2160h": {expiry: 2160 * time.Hour, want: "90 days"},
+		},
-		"8760h": {expiry: 8760 * time.Hour, want: "365 days"},
+		"1h":    {config: `{"expiry":"1h"}`, want: "1 hour"},
-		"36h":   {expiry: 36 * time.Hour, want: "36 hours"},
+		"12h":   {config: `{"expiry":"12h"}`, want: "12 hours"},
-		"1h30m": {expiry: 90 * time.Minute, want: "90 minutes"},
+		"24h":   {config: `{"expiry":"24h"}`, want: "1 day"},
-		"45s":   {expiry: 45 * time.Second, want: "45 seconds"},
+		"720h":  {config: `{"expiry":"720h"}`, want: "30 days"},
-		"1.5s":  {expiry: 1500 * time.Millisecond, want: "1.5s"},
+		"2160h": {config: `{"expiry":"2160h"}`, want: "90 days"},
+		"8760h": {config: `{"expiry":"8760h"}`, want: "365 days"},
+		"36h":   {config: `{"expiry":"36h"}`, want: "36 hours"},
+		"1h30m": {config: `{"expiry":"1h30m"}`, want: "90 minutes"},
+		"45s":   {config: `{"expiry":"45s"}`, want: "45 seconds"},
+		"1.5s":  {config: `{"expiry":"1.5s"}`, want: "1.5s"},
 	}
 
 	for name, tc := range tests {
@@ -330,9 +324,8 @@ func TestNewTargetViews_Database(t *testing.T) {
 			t.Parallel()
 
 			view := viewFor(t, database.Target{
-				Type:            database.TargetTypeDatabase,
+				Type:   database.TargetTypeDatabase,
-				ArchiveExpiry:   tc.expiry,
+				Config: tc.config,
-				ArchiveRotation: rotationNone,
 			})
 
 			assert.Equal(
@@ -348,23 +341,33 @@ func TestNewTargetViews_Database(t *testing.T) {
 }
 
 // TestNewTargetViews_DatabaseRotation proves the target list shows a
-// database target's rotation.
+// database target's rotation, none when it has none stored.
 func TestNewTargetViews_DatabaseRotation(t *testing.T) {
 	t.Parallel()
 
+	// Each stored config, and the rotation the list shows for it.
+	tests := map[string]string{
+		"":                rotationNone,
+		`{"rotation":""}`: rotationNone,
+	}
+
 	for _, rotation := range []string{
 		rotationNone, rotationMonthly, rotationDaily, rotationHourly,
 	} {
-		t.Run(rotation, func(t *testing.T) {
+		tests[`{"rotation":"`+rotation+`"}`] = rotation
+	}
+
+	for config, want := range tests {
+		t.Run(config, func(t *testing.T) {
 			t.Parallel()
 
 			view := viewFor(t, database.Target{
-				Type:            database.TargetTypeDatabase,
+				Type:   database.TargetTypeDatabase,
-				ArchiveRotation: rotation,
+				Config: config,
 			})
 
 			assert.Equal(
-				t, rotation, fieldMap(view.Config)["Archive rotation"],
+				t, want, fieldMap(view.Config)["Archive rotation"],
 			)
 		})
 	}
@@ -374,28 +377,68 @@ func TestNewTargetViews_Log(t *testing.T) {
 	t.Parallel()
 
 	view := viewFor(t, database.Target{
-		Type: database.TargetTypeLog,
+		Type:   database.TargetTypeLog,
+		Config: "",
 	})
 
 	assert.Empty(t, view.Config)
 }
 
-// TestNewTargetViews_UnknownType proves that a target of a type the
+// TestNewTargetViews_Unpresentable proves that no config the
-// view does not know shows the neutral placeholder, and never its
+// view cannot present falls back to the stored blob.
-// URL.
+func TestNewTargetViews_Unpresentable(t *testing.T) {
-func TestNewTargetViews_UnknownType(t *testing.T) {
 	t.Parallel()
 
-	view := viewFor(t, database.Target{
+	const blob = `{"webhookUrl":"https://hooks.slack.com` +
-		Type: database.TargetType("carrier-pigeon"),
+		slackSecretPath + `"`
-		URL:  slackWebhookURL,
-	})
 
-	assert.Equal(
+	tests := map[string]database.Target{
-		t,
+		"unknown target type": {
-		map[string]string{
+			Type:   database.TargetType("carrier-pigeon"),
-			"Configuration": viewUnavailable,
+			Config: blob,
 		},
-		fieldMap(view.Config),
+		"unparseable json": {
-	)
+			Type:   database.TargetTypeSlack,
+			Config: blob,
+		},
+		"empty slack config": {
+			Type: database.TargetTypeSlack,
+		},
+		"slack config without url": {
+			Type:   database.TargetTypeSlack,
+			Config: `{}`,
+		},
+		"unparseable http json": {
+			Type:   database.TargetTypeHTTP,
+			Config: `{"url":`,
+		},
+		"unparseable archive json": {
+			Type:   database.TargetTypeDatabase,
+			Config: `{"expiry":`,
+		},
+		"invalid archive expiry": {
+			Type:   database.TargetTypeDatabase,
+			Config: `{"expiry":"a fortnight"}`,
+		},
+		"invalid archive rotation": {
+			Type:   database.TargetTypeDatabase,
+			Config: weeklyConfig,
+		},
+	}
+
+	for name, target := range tests {
+		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
+			view := viewFor(t, target)
+
+			assert.Equal(
+				t,
+				map[string]string{
+					"Configuration": viewUnavailable,
+				},
+				fieldMap(view.Config),
+			)
+		})
+	}
 }

internal/delivery/target_database.go

@@ -2,23 +2,83 @@ package delivery
 
 import (
 	"context"
+	"fmt"
+	"strings"
+	"sync"
 	"time"
 
 	"gorm.io/gorm"
 	"sneak.berlin/go/webhooker/internal/database"
 )
 
+// archiveNameMaxLen is how many characters of a webhook or target
+// name an archive file name keeps.
+const archiveNameMaxLen = 40
+
 // databaseTarget is a no-retry target that archives the full
 // inbound event into the target's own archive SQLite file, separate
 // from the per-webhook event database. The event is already
 // persisted in the per-webhook event DB by the time delivery runs;
 // the database target additionally writes a durable long-term copy
-// through the engine's archive.Writers, and then records a single
+// into the file ArchiveFileName names, with a period added when the
+// target rotates (see archivePeriodPath), and then records a single
 // attempt whose outcome reflects whether the archive write
-// succeeded. Package archive holds everything about the files
+// succeeded. See archiveWriter for the close/reopen, auto-recreate,
-// themselves.
+// and expiry semantics.
 type databaseTarget struct {
 	eng *Engine
+
+	// writers holds one archive writer per database target, keyed
+	// by target ID.
+	mu      sync.Mutex
+	writers map[string]*archiveWriter
+}
+
+// ArchiveFileName returns the file name of a database target's
+// archive: archive-WEBHOOKNAME-TARGETNAME-TARGETID.db, with both
+// names passed through archiveNamePart. The target ID keeps the
+// name unique when two targets' names come out the same.
+func ArchiveFileName(webhookName, targetName, targetID string) string {
+	return "archive-" + archiveNamePart(webhookName) + "-" +
+		archiveNamePart(targetName) + "-" + targetID + ".db"
+}
+
+// archiveNamePart makes a webhook or target name safe to put in a
+// file name. It is lowercased; ASCII letters and digits are kept,
+// every other run of characters becomes a single "-", and no "-" is
+// left at either end. It is cut to archiveNameMaxLen characters, and
+// a name with nothing left is "unnamed".
+func archiveNamePart(name string) string {
+	var b strings.Builder
+
+	dash := false
+
+	for _, r := range strings.ToLower(name) {
+		if (r < 'a' || r > 'z') && (r < '0' || r > '9') {
+			dash = b.Len() > 0
+
+			continue
+		}
+
+		if dash {
+			b.WriteByte('-')
+
+			dash = false
+		}
+
+		b.WriteRune(r)
+	}
+
+	part := b.String()
+	if len(part) > archiveNameMaxLen {
+		part = strings.TrimRight(part[:archiveNameMaxLen], "-")
+	}
+
+	if part == "" {
+		return "unnamed"
+	}
+
+	return part
 }
 
 // Deliver implements Target. It archives the event, then
@@ -38,7 +98,7 @@ func (t *databaseTarget) Deliver(
 ) {
 	start := time.Now()
 
-	err := t.eng.archives.Write(d)
+	err := t.archive(d)
 
 	elapsed := time.Since(start)
 
@@ -85,3 +145,308 @@ func (t *databaseTarget) Deliver(
 		database.DeliveryStatusDelivered,
 	)
 }
+
+// archive writes the full event as a row into the target's
+// archive database, honouring the optional per-target expiry and
+// rotation parsed from the target config JSON. With rotation, the
+// event goes to the file for the period of its receive time.
+func (t *databaseTarget) archive(d *database.Delivery) error {
+	webhookID := d.Event.WebhookID
+	if webhookID == "" {
+		return errArchiveMissingWebhookID
+	}
+
+	expiry, err := parseArchiveExpiry(d.Target.Config)
+	if err != nil {
+		return err
+	}
+
+	rotation, err := parseArchiveRotation(d.Target.Config)
+	if err != nil {
+		return err
+	}
+
+	// An event whose stored row was gone before its delivery ran has
+	// no receive time (see Engine.hydrateEvent), and goes to the
+	// file for now.
+	receivedAt := d.Event.CreatedAt
+	if receivedAt.IsZero() {
+		receivedAt = time.Now()
+	}
+
+	w, err := t.writerFor(d.TargetID)
+	if err != nil {
+		return err
+	}
+
+	row := archivedEvent{
+		EventID:      d.Event.ID,
+		WebhookID:    webhookID,
+		EntrypointID: d.Event.EntrypointID,
+		Method:       d.Event.Method,
+		RawQuery:     d.Event.RawQuery,
+		Headers:      d.Event.Headers,
+		Body:         d.Event.Body,
+		ContentType:  d.Event.ContentType,
+	}
+
+	return w.write(row, expiry, archivePeriod(rotation, receivedAt))
+}
+
+// writerFor returns the archive writer for a database target,
+// creating and caching it on first use. Each target has one writer
+// so its close/reopen debounce state is shared across concurrent
+// deliveries, and so a rename and the idle sweep take the same lock
+// as its writes.
+func (t *databaseTarget) writerFor(
+	targetID string,
+) (*archiveWriter, error) {
+	t.mu.Lock()
+	defer t.mu.Unlock()
+
+	w, ok := t.writers[targetID]
+	if !ok {
+		var err error
+
+		w, err = t.newWriter(targetID)
+		if err != nil {
+			return nil, err
+		}
+
+		if t.writers == nil {
+			t.writers = make(map[string]*archiveWriter)
+		}
+
+		t.writers[targetID] = w
+	}
+
+	// A delivery claims the entry: even if the idle sweep created
+	// it moments ago, it now belongs to the registry proper and
+	// the sweep must leave it in place when it finishes.
+	w.sweepOwned = false
+
+	return w, nil
+}
+
+// sweepWriterFor returns the archive writer the idle sweep should
+// prune a target's archive through, together with whether the sweep
+// itself created the registry entry.
+//
+// The sweep must route its prune through the registered writer so
+// the writer's mutex orders it against concurrent writes, but it
+// must never leave a registry entry behind: a sweep that ran
+// concurrently with the target's deletion would otherwise
+// re-create an entry that nothing will ever evict again, which is
+// exactly the leak eviction exists to prevent. An entry the sweep
+// creates is therefore marked sweep-owned and handed back to
+// releaseSweepWriter when the sweep is done.
+func (t *databaseTarget) sweepWriterFor(
+	targetID string,
+) (*archiveWriter, bool, error) {
+	t.mu.Lock()
+	defer t.mu.Unlock()
+
+	w, ok := t.writers[targetID]
+	if ok {
+		return w, false, nil
+	}
+
+	w, err := t.newWriter(targetID)
+	if err != nil {
+		return nil, false, err
+	}
+
+	if t.writers == nil {
+		t.writers = make(map[string]*archiveWriter)
+	}
+
+	w.sweepOwned = true
+	t.writers[targetID] = w
+
+	return w, true, nil
+}
+
+// releaseSweepWriter drops a registry entry that the idle sweep
+// created, so a sweep leaves the registry exactly as it found it.
+//
+// The entry is removed only if it is still the very writer the
+// sweep installed and no delivery has claimed it in the meantime
+// (writerFor clears sweepOwned when it hands a writer to the
+// write path). Both conditions are evaluated under the registry
+// lock, so an eviction that raced the sweep — which removes the
+// entry outright — simply finds nothing left to do here, and a
+// delivery that adopted the writer keeps a registered, evictable
+// one.
+func (t *databaseTarget) releaseSweepWriter(
+	targetID string, w *archiveWriter,
+) {
+	t.mu.Lock()
+	defer t.mu.Unlock()
+
+	cur, ok := t.writers[targetID]
+	if !ok || cur != w || !cur.sweepOwned {
+		return
+	}
+
+	delete(t.writers, targetID)
+}
+
+// newWriter builds the writer for a database target's archive. Its
+// path is the one ArchivePath gives for the webhook and the target as
+// the main database names them now; from then on only rename changes
+// the name the writer uses. It does not touch the archive files.
+func (t *databaseTarget) newWriter(
+	targetID string,
+) (*archiveWriter, error) {
+	if t.eng.dbManager == nil {
+		return nil, errArchiveNoDataDir
+	}
+
+	var target database.Target
+
+	err := t.eng.database.DB().
+		Preload("Webhook").
+		First(&target, "id = ?", targetID).Error
+	if err != nil {
+		return nil, fmt.Errorf(
+			"loading database target %s: %w", targetID, err,
+		)
+	}
+
+	w := newArchiveWriter(
+		ArchivePath(t.eng.dbManager, &target.Webhook, &target),
+		t.eng.log,
+	)
+	w.webhookID = target.WebhookID
+
+	return w, nil
+}
+
+// rename moves every one of a database target's archive files to the
+// name for webhookName and targetName. It goes through the target's
+// writer, so the move holds the lock that writes and the idle sweep
+// take, and later writes use the new name.
+//
+// The writer is created if there is none, and it stays cached. The
+// handlers rename before they save the new name, so until the save
+// the main database still has the old one; a delivery in that window
+// must find this writer rather than build one from the old name.
+func (t *databaseTarget) rename(
+	targetID, webhookName, targetName string,
+) error {
+	w, err := t.writerFor(targetID)
+	if err != nil {
+		return err
+	}
+
+	return w.rename(ArchiveFileName(webhookName, targetName, targetID))
+}
+
+// evict drops a database target's archive writer from the registry
+// and closes its handle, so a deleted target does not leave a
+// writer (and an open archive handle within its debounce window)
+// alive for the process lifetime.
+//
+// The map entry is removed under the registry lock, which is
+// then released before the handle is closed under the writer's
+// own lock: that ordering keeps the registry available to other
+// targets while an in-flight write on this one drains, and
+// closing under the writer's lock means eviction can never race
+// a write.
+//
+// Eviction is idempotent and silent for a target with no writer,
+// which is the common case: only a database target that has
+// received an event or been renamed has one. It never deletes the
+// archive file.
+func (t *databaseTarget) evict(targetID string) {
+	t.mu.Lock()
+
+	w, ok := t.writers[targetID]
+	if ok {
+		delete(t.writers, targetID)
+	}
+
+	t.mu.Unlock()
+
+	if !ok {
+		return
+	}
+
+	w.evict()
+
+	t.eng.log.Info(
+		"evicted archive writer",
+		"target_id", targetID,
+		"path", w.path,
+	)
+}
+
+// evictWebhook evicts, exactly as evict does, the writer of every
+// database target of a webhook.
+func (t *databaseTarget) evictWebhook(webhookID string) {
+	t.mu.Lock()
+
+	var gone []*archiveWriter
+
+	for targetID, w := range t.writers {
+		if w.webhookID == webhookID {
+			delete(t.writers, targetID)
+
+			gone = append(gone, w)
+		}
+	}
+
+	t.mu.Unlock()
+
+	for _, w := range gone {
+		w.evict()
+
+		t.eng.log.Info(
+			"evicted archive writer",
+			"webhook_id", webhookID,
+			"path", w.path,
+		)
+	}
+}
+
+// evictAll evicts every cached archive writer, exactly as evict
+// does for one target. The engine calls it at shutdown, once its
+// workers have returned. Closing the last handle on an archive
+// moves the contents of its -wal into the .db and removes the
+// -wal, so a clean stop leaves each archive as a single file.
+func (t *databaseTarget) evictAll() {
+	t.mu.Lock()
+
+	writers := t.writers
+	t.writers = nil
+
+	t.mu.Unlock()
+
+	for _, w := range writers {
+		w.evict()
+	}
+}
+
+// sweepArchive prunes one database target's archive of rows older
+// than expiry, without requiring a write. A missing archive file is
+// left missing (see sweepExpired), so a sweep never creates an
+// archive for a target that has never received an event.
+//
+// It also never leaves a registry entry behind: an entry it had
+// to create to reach the writer's mutex is released again once
+// the prune is done, so a sweep racing a target deletion cannot
+// resurrect the writer the eviction just dropped.
+func (t *databaseTarget) sweepArchive(
+	targetID string, expiry time.Duration,
+) error {
+	w, created, err := t.sweepWriterFor(targetID)
+	if err != nil {
+		return err
+	}
+
+	if created {
+		defer t.releaseSweepWriter(targetID, w)
+	}
+
+	return w.sweepExpired(expiry)
+}

internal/delivery/target_database_archive.go

@@ -1,6 +1,7 @@
-package archive
+package delivery
 
 import (
+	"encoding/json"
 	"errors"
 	"fmt"
 	"io/fs"
@@ -17,10 +18,9 @@ import (
 	"sneak.berlin/go/webhooker/internal/gormlog"
 )
 
-// ExpiryNever is the archive expiry, as the target forms take it,
+// archiveExpiryNever is the expiry sentinel (and default) that
-// that disables pruning so archived rows are kept forever. It is
+// disables pruning so archived rows are kept forever.
-// stored as an ArchiveExpiry of 0.
+const archiveExpiryNever = "never"
-const ExpiryNever = "never"
 
 // archiveReopenDebounce bounds how often an archive file is
 // closed and reopened. After each write the handle is closed
@@ -71,14 +71,27 @@ var (
 		"archive writer has been evicted",
 	)
 
-	// ErrNameTaken is returned when an archive cannot be
+	// ErrArchiveNameTaken is returned when an archive cannot be
 	// renamed because a file already has the new name. That file may
 	// be an archive with rows of its own, so it is never replaced.
-	ErrNameTaken = errors.New(
+	ErrArchiveNameTaken = errors.New(
 		"a file already has the archive's new name",
 	)
 )
 
+// databaseTargetConfig is the optional per-target JSON config
+// for a database (archive) target.
+type databaseTargetConfig struct {
+	// Expiry is a Go duration (e.g. "720h") after which
+	// archived rows are pruned, or "never" (the default) to
+	// keep them forever.
+	Expiry string `json:"expiry"`
+
+	// Rotation is none (the default), monthly, daily or hourly: see
+	// archivePeriod.
+	Rotation string `json:"rotation"`
+}
+
 // archivedEvent is one fully captured webhook event stored in a
 // database target's archive for long-term retention. It is a
 // self-contained copy — independent of the per-webhook event
@@ -99,35 +112,78 @@ type archivedEvent struct {
 	ArchivedAt time.Time `gorm:"index"`
 }
 
-// ParseExpiry reads a user-supplied archive expiry for a database
+// parseArchiveExpiry reads the optional expiry from a database
-// target, as the target forms submit it, into the ArchiveExpiry the
+// target's config JSON. An empty config, an empty expiry, or
-// target stores. Empty and "never" both mean keep forever, which is
+// the literal "never" all mean keep forever, returned as a zero
-// 0; anything else must be a positive Go duration such as "720h". Any
+// duration. Any other value must parse as a positive Go
-// other value is an error, so a bad expiry is refused at the form
+// duration; a set-but-invalid value (unparseable, zero, or
-// rather than stored.
+// negative) is an error rather than a silent default, matching
-func ParseExpiry(expiry string) (time.Duration, error) {
+// ValidateArchiveExpiry at target creation.
-	if expiry == "" || expiry == ExpiryNever {
+func parseArchiveExpiry(
+	configJSON string,
+) (time.Duration, error) {
+	if configJSON == "" {
 		return 0, nil
 	}
 
-	dur, err := time.ParseDuration(expiry)
+	var cfg databaseTargetConfig
+
+	err := json.Unmarshal([]byte(configJSON), &cfg)
 	if err != nil {
 		return 0, fmt.Errorf(
-			"expiry must be %q or a Go duration "+
+			"parsing database target config: %w", err,
-				"such as \"720h\": %w",
+		)
-			ExpiryNever, err,
+	}
+
+	if cfg.Expiry == "" || cfg.Expiry == archiveExpiryNever {
+		return 0, nil
+	}
+
+	dur, err := time.ParseDuration(cfg.Expiry)
+	if err != nil {
+		return 0, fmt.Errorf(
+			"parsing archive expiry %q: %w", cfg.Expiry, err,
 		)
 	}
 
 	if dur <= 0 {
 		return 0, fmt.Errorf(
-			"%w: %q", errArchiveExpiryNotPositive, expiry,
+			"%w: %q", errArchiveExpiryNotPositive, cfg.Expiry,
 		)
 	}
 
 	return dur, nil
 }
 
+// ValidateArchiveExpiry checks a user-supplied archive expiry
+// for a database target at configuration time. Valid values are
+// empty, "never" (both meaning keep forever), or a positive Go
+// duration such as "720h". Anything else is an error, so a bad
+// expiry is rejected when the target is created rather than
+// failing every subsequent delivery.
+func ValidateArchiveExpiry(expiry string) error {
+	if expiry == "" || expiry == archiveExpiryNever {
+		return nil
+	}
+
+	dur, err := time.ParseDuration(expiry)
+	if err != nil {
+		return fmt.Errorf(
+			"expiry must be %q or a Go duration "+
+				"such as \"720h\": %w",
+			archiveExpiryNever, err,
+		)
+	}
+
+	if dur <= 0 {
+		return fmt.Errorf(
+			"%w: %q", errArchiveExpiryNotPositive, expiry,
+		)
+	}
+
+	return nil
+}
+
 // archiveWriter owns one database target's archive SQLite files.
 // It serialises writes, and after each write closes and reopens
 // the file (debounced to at most once per debounce window) so
@@ -138,7 +194,7 @@ func ParseExpiry(expiry string) (time.Duration, error) {
 type archiveWriter struct {
 	mu sync.Mutex
 
-	// path is the target's archive file as Path names it. A
+	// path is the target's archive file as ArchivePath names it. A
 	// target that rotates writes to the files archivePeriodPath names
 	// for path and a period instead.
 	path string
@@ -176,7 +232,7 @@ type archiveWriter struct {
 	// registry proper.
 	//
 	// Unlike every other field here it is guarded by
-	// Writers.mu, not by this writer's mu: it describes the
+	// databaseTarget.mu, not by this writer's mu: it describes the
 	// registry entry rather than the file.
 	sweepOwned bool
 }
@@ -221,11 +277,7 @@ func (w *archiveWriter) write(
 		}
 	}
 
-	// GORM's clock, the one that stamps created_at in the other
+	row.ArchivedAt = time.Now()
-	// databases, so this is stored in the same form. A bare time.Now()
-	// carries a monotonic clock reading, which the driver would store
-	// as an " m=+…" suffix.
-	row.ArchivedAt = w.db.NowFunc()
 
 	err := w.db.Create(&row).Error
 	if err != nil {
@@ -443,7 +495,7 @@ func (w *archiveWriter) sweepFile(
 // the next write creates its file under the new name.
 //
 // If a file already has one of the new names, nothing is moved and
-// the error is ErrNameTaken. If one file fails to move, those
+// the error is ErrArchiveNameTaken. If one file fails to move, those
 // already moved are moved back before the error is returned, so the
 // archive is never split across two names.
 func (w *archiveWriter) rename(name string) error {
@@ -481,7 +533,7 @@ func (w *archiveWriter) rename(name string) error {
 	for _, taken := range to {
 		if fileExists(taken) {
 			return fmt.Errorf(
-				"%w: %s", ErrNameTaken, filepath.Base(taken),
+				"%w: %s", ErrArchiveNameTaken, filepath.Base(taken),
 			)
 		}
 	}
@@ -534,7 +586,7 @@ func (w *archiveWriter) evict() {
 // each row's archived time. It runs on every (re)open, so a
 // steadily written archive is swept by its own write traffic. An
 // archive that goes idle receives no further reopens, which is
-// why Sweeper exists to drive sweepExpired on a timer.
+// why ArchiveSweeper exists to drive sweepExpired on a timer.
 // Failures are logged, not fatal: a prune error must not stop
 // archiving.
 func (w *archiveWriter) prune(expiry time.Duration) {
@@ -561,9 +613,9 @@ func (w *archiveWriter) prune(expiry time.Duration) {
 	}
 }
 
-// FileInfo is what the metadata of a database target's archive
+// ArchiveFileInfo is what the metadata of a database target's archive
 // files says about them.
-type FileInfo struct {
+type ArchiveFileInfo struct {
 	// Files counts the files.
 	Files int
 
@@ -575,18 +627,18 @@ type FileInfo struct {
 	Written time.Time
 }
 
-// Stat reads the metadata of a database target's archive
+// StatArchive reads the metadata of a database target's archive
-// files, given the path Path gives it (see archiveFiles), and
+// files, given the path ArchivePath gives it (see archiveFiles), and
 // of their -wal, without opening them. With no files, which is so
 // before the first write and after the operator moved them away, the
 // error wraps fs.ErrNotExist.
-func Stat(path string) (FileInfo, error) {
+func StatArchive(path string) (ArchiveFileInfo, error) {
 	files, err := archiveFiles(path)
 	if err != nil {
-		return FileInfo{}, err
+		return ArchiveFileInfo{}, err
 	}
 
-	var info FileInfo
+	var info ArchiveFileInfo
 
 	for _, file := range files {
 		db, err := os.Stat(file.path)
@@ -595,7 +647,7 @@ func Stat(path string) (FileInfo, error) {
 		}
 
 		if err != nil {
-			return FileInfo{}, err
+			return ArchiveFileInfo{}, err
 		}
 
 		info.Files++
@@ -611,7 +663,7 @@ func Stat(path string) (FileInfo, error) {
 		}
 
 		if err != nil {
-			return FileInfo{}, err
+			return ArchiveFileInfo{}, err
 		}
 
 		info.Size += wal.Size()
@@ -622,7 +674,7 @@ func Stat(path string) (FileInfo, error) {
 	}
 
 	if info.Files == 0 {
-		return FileInfo{}, fmt.Errorf(
+		return ArchiveFileInfo{}, fmt.Errorf(
 			"no archive file for %s: %w", path, fs.ErrNotExist,
 		)
 	}

internal/delivery/target_database_archive_gormlog_test.go

@@ -1,4 +1,4 @@
-package archive_test
+package delivery_test
 
 import (
 	"bytes"
@@ -14,7 +14,7 @@ import (
 	"github.com/stretchr/testify/require"
 	"gorm.io/gorm"
 	gormlogger "gorm.io/gorm/logger"
-	"sneak.berlin/go/webhooker/internal/archive"
+	"sneak.berlin/go/webhooker/internal/delivery"
 	"sneak.berlin/go/webhooker/internal/middleware"
 )
 
@@ -57,7 +57,7 @@ func (g *gormDefaultBuf) String() string {
 // without exporting production code to carry it, and a logging
 // detector is not worth a production symbol. What it detects is the
 // third gorm.Open in this service, at
-// internal/archive/writer.go — the archive writer,
+// internal/delivery/target_database_archive.go — the archive writer,
 // whose type is unexported, so nothing outside this package can drive
 // it.
 func captureArchiveGORMDefault(t *testing.T) *gormDefaultBuf {
@@ -85,7 +85,7 @@ func captureArchiveGORMDefault(t *testing.T) *gormDefaultBuf {
 // writer's gorm.Open to the adapter.
 //
 // Restore a bare &gorm.Config{} at
-// internal/archive/writer.go and this fails: the
+// internal/delivery/target_database_archive.go and this fails: the
 // default logger prints the fully interpolated SELECT on every
 // ErrRecordNotFound, so the client-chosen event id below arrives whole
 // and unbounded on stdout, answering to no level the operator set.
@@ -100,7 +100,7 @@ func TestArchiveWriter_NeverUsesGORMsDefaultLogger(t *testing.T) {
 
 	gormDefault := captureArchiveGORMDefault(t)
 
-	w := archive.NewExportArchiveWriter(
+	w := delivery.NewExportArchiveWriter(
 		filepath.Join(t.TempDir(), "archive.db"),
 		slog.New(slog.NewTextHandler(
 			&captured, &slog.HandlerOptions{Level: slog.LevelDebug},
@@ -118,7 +118,7 @@ func TestArchiveWriter_NeverUsesGORMsDefaultLogger(t *testing.T) {
 	value := strings.Repeat("\x01", archiveGORMFillBytes) +
 		archiveGORMTailMarker
 
-	var row archive.ExportArchivedEvent
+	var row delivery.ExportArchivedEvent
 
 	err := w.DB().Where("event_id = ?", value).First(&row).Error
 	require.ErrorIs(t, err, gorm.ErrRecordNotFound)

internal/delivery/target_database_evict_test.go

@@ -1,6 +1,7 @@
-package archive_test
+package delivery_test
 
 import (
+	"context"
 	"errors"
 	"fmt"
 	"net/http"
@@ -12,8 +13,8 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
+	"sneak.berlin/go/webhooker/internal/delivery"
 )
 
 // deliverTo archives one event to a database target, leaving the
@@ -23,9 +24,12 @@ func deliverTo(
 ) {
 	t.Helper()
 
-	event := newEvent(`{"archived":true}`)
+	webhookDB := testWebhookDB(t)
+	event := seedEvent(t, webhookDB, `{"archived":true}`)
 
-	require.NoError(t, env.writers.Write(databaseTargetDelivery(event, tgt)))
+	env.eng.ExportDeliverDatabase(
+		webhookDB, seedDatabaseTargetDelivery(t, webhookDB, event, tgt),
+	)
 }
 
 // TestEvictWebhook_ClosesAndRemovesWriter proves that evicting
@@ -37,28 +41,28 @@ func TestEvictWebhook_ClosesAndRemovesWriter(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	first := env.seedDatabaseTarget(t, 0, "")
+	first := env.seedDatabaseTarget(t, "")
-	second := env.addDatabaseTarget(t, first.WebhookID, 0, "")
+	second := env.addDatabaseTarget(t, first.WebhookID, "")
-	other := env.seedDatabaseTarget(t, 0, "")
+	other := env.seedDatabaseTarget(t, "")
 
 	for _, tgt := range []*database.Target{first, second, other} {
 		deliverTo(t, env, tgt)
 
 		require.True(
-			t, env.writers.ExportArchiveHandleOpen(tgt.ID),
+			t, env.eng.ExportArchiveHandleOpen(tgt.ID),
 			"the writer should hold an open handle after a write",
 		)
 	}
 
-	env.writers.EvictWebhook(first.WebhookID)
+	env.eng.EvictWebhook(first.WebhookID)
 
 	for _, tgt := range []*database.Target{first, second} {
 		assert.False(
-			t, env.writers.ExportHasArchiveWriter(tgt.ID),
+			t, env.eng.ExportHasArchiveWriter(tgt.ID),
 			"eviction should remove the registry entry",
 		)
 		assert.False(
-			t, env.writers.ExportArchiveHandleOpen(tgt.ID),
+			t, env.eng.ExportArchiveHandleOpen(tgt.ID),
 			"eviction should close the archive handle",
 		)
 		assert.FileExists(
@@ -68,7 +72,7 @@ func TestEvictWebhook_ClosesAndRemovesWriter(t *testing.T) {
 	}
 
 	assert.True(
-		t, env.writers.ExportArchiveHandleOpen(other.ID),
+		t, env.eng.ExportArchiveHandleOpen(other.ID),
 		"another webhook's writer must be left alone",
 	)
 }
@@ -80,21 +84,21 @@ func TestEvictTarget_LeavesOtherTargets(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	doomed := env.seedDatabaseTarget(t, 0, "")
+	doomed := env.seedDatabaseTarget(t, "")
-	kept := env.addDatabaseTarget(t, doomed.WebhookID, 0, "")
+	kept := env.addDatabaseTarget(t, doomed.WebhookID, "")
 
 	deliverTo(t, env, doomed)
 	deliverTo(t, env, kept)
 
-	env.writers.EvictTarget(doomed.ID)
+	env.eng.EvictTarget(doomed.ID)
 
-	assert.False(t, env.writers.ExportHasArchiveWriter(doomed.ID))
+	assert.False(t, env.eng.ExportHasArchiveWriter(doomed.ID))
 	assert.FileExists(
 		t, env.archivePath(doomed),
 		"eviction must not delete the archive file",
 	)
 	assert.True(
-		t, env.writers.ExportArchiveHandleOpen(kept.ID),
+		t, env.eng.ExportArchiveHandleOpen(kept.ID),
 		"the other target's writer must be left alone",
 	)
 }
@@ -108,21 +112,21 @@ func TestEvictWebhook_UnknownWebhookIsNoOp(t *testing.T) {
 	env := setupArchiveTest(t)
 
 	assert.NotPanics(t, func() {
-		env.writers.EvictWebhook("no-such-webhook")
+		env.eng.EvictWebhook("no-such-webhook")
-		env.writers.EvictWebhook("no-such-webhook")
+		env.eng.EvictWebhook("no-such-webhook")
-		env.writers.EvictTarget("no-such-target")
+		env.eng.EvictTarget("no-such-target")
-		env.writers.EvictTarget("no-such-target")
+		env.eng.EvictTarget("no-such-target")
 	})
 
 	assert.False(
-		t, env.writers.ExportHasArchiveWriter("no-such-target"),
+		t, env.eng.ExportHasArchiveWriter("no-such-target"),
 		"eviction must not create a writer",
 	)
 }
 
 // evictTestRow builds an archive row for the eviction tests.
-func evictTestRow(eventID string) archive.ExportArchivedEvent {
+func evictTestRow(eventID string) delivery.ExportArchivedEvent {
-	return archive.ExportArchivedEvent{
+	return delivery.ExportArchivedEvent{
 		EventID:   eventID,
 		WebhookID: "wh-evict",
 		Method:    http.MethodPost,
@@ -143,7 +147,7 @@ func TestEvictedWriter_WriteDoesNotReopenFile(t *testing.T) {
 
 	path := filepath.Join(t.TempDir(), "archive-evicted.db")
 
-	w := archive.NewExportArchiveWriter(
+	w := delivery.NewExportArchiveWriter(
 		path, archiveTestLogger(), 0,
 	)
 
@@ -160,7 +164,7 @@ func TestEvictedWriter_WriteDoesNotReopenFile(t *testing.T) {
 	err := w.Write(evictTestRow("ev-2"), 0)
 
 	require.ErrorIs(
-		t, err, archive.ErrExportArchiveWriterEvicted,
+		t, err, delivery.ErrExportArchiveWriterEvicted,
 		"an evicted writer must refuse writes",
 	)
 	assert.NoFileExists(
@@ -183,7 +187,7 @@ func TestEvictedWriter_SweepDoesNotReopenFile(t *testing.T) {
 
 	path := filepath.Join(t.TempDir(), "archive-evicted.db")
 
-	w := archive.NewExportArchiveWriter(
+	w := delivery.NewExportArchiveWriter(
 		path, archiveTestLogger(), 0,
 	)
 
@@ -195,7 +199,7 @@ func TestEvictedWriter_SweepDoesNotReopenFile(t *testing.T) {
 	err := w.SweepExpired(time.Hour)
 
 	require.ErrorIs(
-		t, err, archive.ErrExportArchiveWriterEvicted,
+		t, err, delivery.ErrExportArchiveWriterEvicted,
 		"an evicted writer must refuse an idle sweep",
 	)
 	assert.False(
@@ -226,7 +230,7 @@ const racingWriteGoroutines = 4
 // against a hang, not a timing assumption: the first write after
 // the eviction is refused.
 func startRacingWrites(
-	w *archive.ExportArchiveWriter,
+	w *delivery.ExportArchiveWriter,
 ) *racingWrites {
 	r := &racingWrites{
 		started: make(chan struct{}, racingWriteGoroutines),
@@ -272,7 +276,7 @@ func (r *racingWrites) record(err error) {
 	r.mu.Lock()
 	defer r.mu.Unlock()
 
-	if errors.Is(err, archive.ErrExportArchiveWriterEvicted) {
+	if errors.Is(err, delivery.ErrExportArchiveWriterEvicted) {
 		r.sawEvicted = true
 
 		return
@@ -310,13 +314,13 @@ func TestEvictWebhook_RacingWriteDoesNotReopenHandle(
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, "")
+	tgt := env.seedDatabaseTarget(t, "")
 
 	// Prime the registry so the test can hold the very writer the
 	// eviction is about to detach.
 	deliverTo(t, env, tgt)
 
-	w := env.writers.ExportArchiveWriterFor(tgt.ID)
+	w := env.eng.ExportArchiveWriterFor(tgt.ID)
 	require.NotNil(t, w)
 	require.True(t, w.HandleOpen())
 
@@ -326,7 +330,7 @@ func TestEvictWebhook_RacingWriteDoesNotReopenHandle(
 	// eviction has to contend for the writer's mutex.
 	race.awaitFirstWrite()
 
-	env.writers.EvictWebhook(tgt.WebhookID)
+	env.eng.EvictWebhook(tgt.WebhookID)
 
 	sawEvicted, otherErr := race.wait()
 
@@ -341,7 +345,7 @@ func TestEvictWebhook_RacingWriteDoesNotReopenHandle(
 			"been evicted",
 	)
 	assert.False(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"the registry entry must stay gone",
 	)
 }
@@ -355,45 +359,45 @@ func TestEvictWebhook_LaterDeliveryRecreatesWriter(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, "")
+	tgt := env.seedDatabaseTarget(t, "")
 
 	deliverTo(t, env, tgt)
-	require.True(t, env.writers.ExportHasArchiveWriter(tgt.ID))
+	require.True(t, env.eng.ExportHasArchiveWriter(tgt.ID))
 
-	env.writers.EvictWebhook(tgt.WebhookID)
+	env.eng.EvictWebhook(tgt.WebhookID)
 
 	// A fresh delivery for the same target gets a brand new
 	// writer from the registry, so archiving keeps working.
 	deliverTo(t, env, tgt)
 
 	assert.True(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"a later delivery should recreate the writer",
 	)
 }
 
-// TestEvictAll_WriteAfterIsRefused proves that EvictAll, which the
+// TestEngineStop_WriteAfterStopIsRefused proves the engine's stop
-// delivery engine calls when it stops, closes each archive writer the
+// closes each archive writer the way deleting its webhook does: a
-// way deleting its webhook does: a write that reaches a writer after
+// write that reaches a writer after the stop is refused, reopens
-// it is refused, reopens nothing and adds no row.
+// nothing and adds no row.
-func TestEvictAll_WriteAfterIsRefused(t *testing.T) {
+func TestEngineStop_WriteAfterStopIsRefused(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, "")
+	tgt := env.seedDatabaseTarget(t, "")
 
 	deliverTo(t, env, tgt)
 
-	w := env.writers.ExportArchiveWriterFor(tgt.ID)
+	w := env.eng.ExportArchiveWriterFor(tgt.ID)
 	require.NotNil(t, w)
 	require.True(t, w.HandleOpen())
 
-	env.writers.EvictAll()
+	require.NoError(t, env.eng.ExportStop(context.Background()))
 
 	err := w.Write(evictTestRow("ev-after-stop"), 0)
 
 	require.ErrorIs(
-		t, err, archive.ErrExportArchiveWriterEvicted,
+		t, err, delivery.ErrExportArchiveWriterEvicted,
 		"a write after the stop must be refused",
 	)
 	assert.False(
@@ -401,7 +405,7 @@ func TestEvictAll_WriteAfterIsRefused(t *testing.T) {
 		"a refused write must not reopen the archive",
 	)
 	assert.False(
-		t, env.writers.ExportHasArchiveWriter(tgt.ID),
+		t, env.eng.ExportHasArchiveWriter(tgt.ID),
 		"the stop should empty the registry",
 	)
 

internal/delivery/target_database_export.go

@@ -1,4 +1,4 @@
-package archive
+package delivery
 
 import (
 	"compress/gzip"
@@ -28,25 +28,25 @@ import (
 const archiveTableQuery = "SELECT count(*) FROM sqlite_master " +
 	"WHERE type = 'table' AND name = 'archived_events'"
 
-// Path returns where a database target's archive file is: in
+// ArchivePath returns where a database target's archive file is: in
 // the data directory, beside the webhook's event database, under the
-// name FileName gives it.
+// name ArchiveFileName gives it.
-func Path(
+func ArchivePath(
 	dbMgr *database.WebhookDBManager,
 	webhook *database.Webhook,
 	target *database.Target,
 ) string {
 	return filepath.Join(
 		filepath.Dir(dbMgr.DBPath(webhook.ID)),
-		FileName(webhook.Name, target.Name, target.ID),
+		ArchiveFileName(webhook.Name, target.Name, target.ID),
 	)
 }
 
-// ExportFileName returns the name a database target's archive
+// ArchiveExportFileName returns the name a database target's archive
 // downloads under:
 // archive-WEBHOOKNAME-TARGETNAME-YYYYMMDDTHHMMSSZ.json.gz, the names
-// made safe as in FileName and the time in UTC.
+// made safe as in ArchiveFileName and the time in UTC.
-func ExportFileName(
+func ArchiveExportFileName(
 	webhookName, targetName string, at time.Time,
 ) string {
 	return "archive-" + archiveNamePart(webhookName) + "-" +
@@ -54,7 +54,7 @@ func ExportFileName(
 		at.UTC().Format("20060102T150405Z") + ".json.gz"
 }
 
-// Export is a database target's archive listed for download. It
+// ArchiveExport is a database target's archive listed for download. It
 // opens one of the target's files at a time, only when its rows are
 // about to be written out, and closes it before it opens the next, so
 // an export holds at most one file open however many the target has.
@@ -66,7 +66,7 @@ func ExportFileName(
 // is open, and the export does not see them. SQLite cannot checkpoint
 // a -wal past an open snapshot, so the open file's -wal grows until the
 // export has written that file out.
-type Export struct {
+type ArchiveExport struct {
 	// periods are the periods of the target's files when the export
 	// was listed, "" for the file without one, in the order
 	// archiveFiles lists them.
@@ -77,7 +77,7 @@ type Export struct {
 	// between.
 	lock sync.Locker
 
-	// currentPath returns the path Path gives the target under
+	// currentPath returns the path ArchivePath gives the target under
 	// the names stored for it now, which a rename may have changed since
 	// the export was listed.
 	currentPath func() (string, error)
@@ -103,12 +103,11 @@ type exportedName struct {
 	Name string `json:"name"`
 }
 
-// NewExport lists a database target's archive files for export,
+// NewArchiveExport lists a database target's archive files for export,
-// given the path Path gives it (see archiveFiles). It opens none
+// given the path ArchivePath gives it (see archiveFiles). It opens none
 // of them. Its caller holds lock, which every rename of the target's
-// files runs under (Writers.RenameLock returns it), from reading the names
+// files runs under, from reading the names path is made of until it
-// path is made of until it returns, so the files it lists are the ones
+// returns, so the files it lists are the ones those names give.
-// those names give.
 //
 // WriteGzipJSON, called without lock held, finds each file again by its
 // period under the path currentPath gives, holding lock while it does
@@ -116,18 +115,18 @@ type exportedName struct {
 // file. A file that is gone by then, emptied by the sweep or moved
 // away, is skipped. The export never creates a file: with no files, it
 // has no rows.
-func NewExport(
+func NewArchiveExport(
 	path string,
 	lock sync.Locker,
 	currentPath func() (string, error),
 	log *slog.Logger,
-) (*Export, error) {
+) (*ArchiveExport, error) {
 	files, err := archiveFiles(path)
 	if err != nil {
 		return nil, err
 	}
 
-	x := &Export{lock: lock, currentPath: currentPath, log: log}
+	x := &ArchiveExport{lock: lock, currentPath: currentPath, log: log}
 
 	for _, file := range files {
 		x.periods = append(x.periods, file.period)
@@ -200,7 +199,7 @@ func openExportFile(
 // closed once its rows are written, before the next is opened. When it
 // returns, no file is open. After an error the gzip stream is left
 // unfinished, so what was written does not decompress as a whole file.
-func (x *Export) WriteGzipJSON(
+func (x *ArchiveExport) WriteGzipJSON(
 	ctx context.Context,
 	w io.Writer,
 	webhook *database.Webhook,
@@ -229,7 +228,7 @@ func (x *Export) WriteGzipJSON(
 // openFile finds the target's archive file for period under the path
 // currentPath gives now, and opens it for the export, holding x.lock
 // for both. For a file that is gone, the error wraps fs.ErrNotExist.
-func (x *Export) openFile(
+func (x *ArchiveExport) openFile(
 	ctx context.Context, period string,
 ) (*exportFile, error) {
 	x.lock.Lock()
@@ -259,7 +258,7 @@ func (f *exportFile) close() error {
 
 // writeJSON writes head with archived_events added as its last key,
 // the rows going into it one at a time.
-func (x *Export) writeJSON(
+func (x *ArchiveExport) writeJSON(
 	ctx context.Context, w io.Writer, head []byte,
 ) error {
 	// head goes out without its closing brace, so that
@@ -287,7 +286,7 @@ func (x *Export) writeJSON(
 // writeRows writes the archived rows of each file to w, one per line,
 // separated by commas, opening each file in turn and closing it once
 // its rows are written.
-func (x *Export) writeRows(ctx context.Context, w io.Writer) error {
+func (x *ArchiveExport) writeRows(ctx context.Context, w io.Writer) error {
 	sep := "\n"
 
 	for _, period := range x.periods {

internal/delivery/target_database_export_test.go

@@ -1,4 +1,4 @@
-package archive_test
+package delivery_test
 
 import (
 	"bufio"
@@ -19,8 +19,8 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
+	"sneak.berlin/go/webhooker/internal/delivery"
 )
 
 // The webhook and the target the export tests' archives belong to.
@@ -37,7 +37,7 @@ const binaryBody = "\xff\xfe\x00\x01binary\x80"
 // writeExportTo writes export to w as the archive of the export tests'
 // webhook and target, exported at 2026-10-02T12:03:04Z.
 func writeExportTo(
-	t *testing.T, export *archive.Export, w io.Writer,
+	t *testing.T, export *delivery.ArchiveExport, w io.Writer,
 ) error {
 	t.Helper()
 
@@ -57,7 +57,7 @@ func writeExportTo(
 
 // listExport lists the archive at path for export, as the archive of a
 // target whose names do not change.
-func listExport(t *testing.T, path string) *archive.Export {
+func listExport(t *testing.T, path string) *delivery.ArchiveExport {
 	t.Helper()
 
 	return newExport(t, path, &sync.Mutex{}, func() (string, error) {
@@ -73,10 +73,10 @@ func newExport(
 	path string,
 	lock sync.Locker,
 	currentPath func() (string, error),
-) *archive.Export {
+) *delivery.ArchiveExport {
 	t.Helper()
 
-	export, err := archive.NewExport(
+	export, err := delivery.NewArchiveExport(
 		path, lock, currentPath, archiveTestLogger(),
 	)
 	require.NoError(t, err)
@@ -96,7 +96,7 @@ func exportArchive(t *testing.T, path string) map[string]any {
 // decompressed and parsed. Reading to the end makes the gzip reader
 // check that the stream was finished.
 func writeExport(
-	t *testing.T, export *archive.Export,
+	t *testing.T, export *delivery.ArchiveExport,
 ) map[string]any {
 	t.Helper()
 
@@ -157,11 +157,11 @@ func TestArchiveExport_MatchesStoredRows(t *testing.T) {
 	t.Parallel()
 
 	path := filepath.Join(t.TempDir(), "archive.db")
-	w := archive.NewExportArchiveWriter(path, archiveTestLogger(), 0)
+	w := delivery.NewExportArchiveWriter(path, archiveTestLogger(), 0)
 	bodies := []string{`{"order":1}`, "plain text", "", binaryBody}
 
 	for i, body := range bodies {
-		require.NoError(t, w.Write(archive.ExportArchivedEvent{
+		require.NoError(t, w.Write(delivery.ExportArchivedEvent{
 			EventID:      fmt.Sprintf("ev-%d", i),
 			WebhookID:    exportWebhookID,
 			EntrypointID: "ep-1",
@@ -173,7 +173,7 @@ func TestArchiveExport_MatchesStoredRows(t *testing.T) {
 		}, 0))
 	}
 
-	var stored []archive.ExportArchivedEvent
+	var stored []delivery.ExportArchivedEvent
 
 	require.NoError(t, openArchiveDBForRead(t, path).
 		Order("id").Find(&stored).Error)
@@ -201,7 +201,7 @@ func TestArchiveExport_MatchesStoredRows(t *testing.T) {
 // assertExportedRow checks that ev, from an export, holds every column
 // of the stored row.
 func assertExportedRow(
-	t *testing.T, row archive.ExportArchivedEvent, ev map[string]any,
+	t *testing.T, row delivery.ExportArchivedEvent, ev map[string]any,
 ) {
 	t.Helper()
 
@@ -248,7 +248,7 @@ func TestArchiveExport_Empty(t *testing.T) {
 
 	require.NoError(t, os.WriteFile(noTable, nil, 0o600))
 	require.NoError(t,
-		archive.NewExportArchiveWriter(noRows, archiveTestLogger(), 0).
+		delivery.NewExportArchiveWriter(noRows, archiveTestLogger(), 0).
 			Open(0),
 	)
 
@@ -284,18 +284,18 @@ func TestArchiveExport_ReadsOneSnapshot(t *testing.T) {
 	t.Parallel()
 
 	path := filepath.Join(t.TempDir(), "archive.db")
-	w := archive.NewExportArchiveWriter(path, archiveTestLogger(), 0)
+	w := delivery.NewExportArchiveWriter(path, archiveTestLogger(), 0)
 
-	require.NoError(t, w.Write(archive.ExportArchivedEvent{EventID: "listed"}, 0))
+	require.NoError(t, w.Write(delivery.ExportArchivedEvent{EventID: "listed"}, 0))
 
 	opened := &unlockHook{fn: func() {
-		require.NoError(t, w.Write(archive.ExportArchivedEvent{EventID: "during"}, 0))
+		require.NoError(t, w.Write(delivery.ExportArchivedEvent{EventID: "during"}, 0))
 	}}
 	export := newExport(t, path, opened, func() (string, error) {
 		return path, nil
 	})
 
-	require.NoError(t, w.Write(archive.ExportArchivedEvent{EventID: "before-open"}, 0))
+	require.NoError(t, w.Write(delivery.ExportArchivedEvent{EventID: "before-open"}, 0))
 
 	assert.Equal(t,
 		[]string{"listed", "before-open"},
@@ -305,7 +305,7 @@ func TestArchiveExport_ReadsOneSnapshot(t *testing.T) {
 	var stored int64
 
 	require.NoError(t, openArchiveDBForRead(t, path).
-		Model(&archive.ExportArchivedEvent{}).Count(&stored).Error)
+		Model(&delivery.ExportArchivedEvent{}).Count(&stored).Error)
 	assert.Equal(t, int64(3), stored)
 }
 
@@ -318,11 +318,11 @@ func TestArchiveExport_FindsFilesAfterRename(t *testing.T) {
 
 	dir := t.TempDir()
 	path := filepath.Join(dir, "archive-old.db")
-	w := archive.NewExportArchiveWriter(path, archiveTestLogger(), 0)
+	w := delivery.NewExportArchiveWriter(path, archiveTestLogger(), 0)
 
 	for _, period := range []string{"", dayPeriod, hourPeriod} {
 		require.NoError(t, w.WritePeriod(
-			archive.ExportArchivedEvent{EventID: "in-" + period}, 0, period,
+			delivery.ExportArchivedEvent{EventID: "in-" + period}, 0, period,
 		))
 	}
 
@@ -353,19 +353,19 @@ func TestArchiveExport_EveryFileOldestFirst(t *testing.T) {
 	t.Parallel()
 
 	path := filepath.Join(t.TempDir(), "archive-wh.db")
-	w := archive.NewExportArchiveWriter(path, archiveTestLogger(), 0)
+	w := delivery.NewExportArchiveWriter(path, archiveTestLogger(), 0)
 
 	// Written in an order that is not the export's.
 	for _, period := range []string{nextDayPeriod, "", hourPeriod, "2026-03"} {
 		require.NoError(t, w.WritePeriod(
-			archive.ExportArchivedEvent{EventID: "in-" + period}, 0, period,
+			delivery.ExportArchivedEvent{EventID: "in-" + period}, 0, period,
 		))
 	}
 
 	export := listExport(t, path)
 
 	require.NoError(t, w.WritePeriod(
-		archive.ExportArchivedEvent{EventID: "later"}, 0, "2026-03-06",
+		delivery.ExportArchivedEvent{EventID: "later"}, 0, "2026-03-06",
 	))
 
 	events := exportedEvents(t, writeExport(t, export))
@@ -434,13 +434,13 @@ func TestArchiveExport_OneFileOpenAtATime(t *testing.T) {
 	require.NoError(t, err)
 
 	path := filepath.Join(dir, "archive-wh.db")
-	w := archive.NewExportArchiveWriter(path, archiveTestLogger(), 0)
+	w := delivery.NewExportArchiveWriter(path, archiveTestLogger(), 0)
 	random := make([]byte, 36<<10)
 
 	for hour := range 24 {
 		_, _ = rand.Read(random)
 
-		require.NoError(t, w.WritePeriod(archive.ExportArchivedEvent{
+		require.NoError(t, w.WritePeriod(delivery.ExportArchivedEvent{
 			Body: base64.StdEncoding.EncodeToString(random),
 		}, 0, fmt.Sprintf("2026-10-01-%02d", hour)))
 	}
@@ -489,7 +489,7 @@ func exportHeapGrowth(t *testing.T, rows, bodySize int) uint64 {
 	t.Helper()
 
 	path := filepath.Join(t.TempDir(), "archive.db")
-	w := archive.NewExportArchiveWriter(path, archiveTestLogger(), 0)
+	w := delivery.NewExportArchiveWriter(path, archiveTestLogger(), 0)
 
 	// Base64 makes four characters of every three bytes.
 	random := make([]byte, bodySize/4*3)
@@ -497,7 +497,7 @@ func exportHeapGrowth(t *testing.T, rows, bodySize int) uint64 {
 	for range rows {
 		_, _ = rand.Read(random)
 
-		require.NoError(t, w.Write(archive.ExportArchivedEvent{
+		require.NoError(t, w.Write(delivery.ExportArchivedEvent{
 			Body: base64.StdEncoding.EncodeToString(random),
 		}, 0))
 	}
@@ -565,7 +565,7 @@ func TestArchiveExportFileName(t *testing.T) {
 
 	assert.Equal(t,
 		"archive-orders-eu-long-term-archive-20261002T120304Z.json.gz",
-		archive.ExportFileName(
+		delivery.ArchiveExportFileName(
 			exportWebhookName, exportTargetName,
 			time.Date(2026, 10, 2, 14, 3, 4, 0, cest),
 		),

internal/delivery/target_database_rotation.go

@@ -1,6 +1,7 @@
-package archive
+package delivery
 
 import (
+	"encoding/json"
 	"errors"
 	"fmt"
 	"os"
@@ -40,10 +41,10 @@ type archiveFile struct {
 	period string
 }
 
-// ValidateRotation checks a user-supplied archive rotation for
+// ValidateArchiveRotation checks a user-supplied archive rotation for
 // a database target: empty or none (both meaning one file), monthly,
 // daily or hourly.
-func ValidateRotation(rotation string) error {
+func ValidateArchiveRotation(rotation string) error {
 	switch rotation {
 	case "", archiveRotationNone, archiveRotationMonthly,
 		archiveRotationDaily, archiveRotationHourly:
@@ -53,10 +54,35 @@ func ValidateRotation(rotation string) error {
 	}
 }
 
+// parseArchiveRotation reads the rotation from a database target's
+// config JSON. An empty config or an empty rotation is none.
+func parseArchiveRotation(configJSON string) (string, error) {
+	if configJSON == "" {
+		return archiveRotationNone, nil
+	}
+
+	var cfg databaseTargetConfig
+
+	err := json.Unmarshal([]byte(configJSON), &cfg)
+	if err != nil {
+		return "", fmt.Errorf("parsing database target config: %w", err)
+	}
+
+	err = ValidateArchiveRotation(cfg.Rotation)
+	if err != nil {
+		return "", err
+	}
+
+	if cfg.Rotation == "" {
+		return archiveRotationNone, nil
+	}
+
+	return cfg.Rotation, nil
+}
+
 // archivePeriod returns the period, in UTC, that a rotation puts an
 // event received at receivedAt in: "2026-10" for monthly,
-// "2026-10-01" for daily, "2026-10-01-19" for hourly, and "" for none
+// "2026-10-01" for daily, "2026-10-01-19" for hourly, and "" for none.
-// or an empty rotation.
 func archivePeriod(rotation string, receivedAt time.Time) string {
 	switch rotation {
 	case archiveRotationMonthly:
@@ -71,7 +97,7 @@ func archivePeriod(rotation string, receivedAt time.Time) string {
 }
 
 // archivePeriodPath returns the path of a database target's archive
-// file for a period: path, as Path gives it, with "-" and the
+// file for a period: path, as ArchivePath gives it, with "-" and the
 // period put before its ".db". The period "" gives path itself.
 func archivePeriodPath(path, period string) string {
 	if period == "" {
@@ -81,23 +107,28 @@ func archivePeriodPath(path, period string) string {
 	return strings.TrimSuffix(path, ".db") + "-" + period + ".db"
 }
 
-// PathAt returns the archive file a database target writes an
+// ArchivePathAt returns the archive file a database target writes an
-// event received at receivedAt to: Path's file, with the
+// event received at receivedAt to: ArchivePath's file, with the
 // period in its name when the target rotates.
-func PathAt(
+func ArchivePathAt(
 	dbMgr *database.WebhookDBManager,
 	webhook *database.Webhook,
 	target *database.Target,
 	receivedAt time.Time,
-) string {
+) (string, error) {
+	rotation, err := parseArchiveRotation(target.Config)
+	if err != nil {
+		return "", err
+	}
+
 	return archivePeriodPath(
-		Path(dbMgr, webhook, target),
+		ArchivePath(dbMgr, webhook, target),
-		archivePeriod(target.ArchiveRotation, receivedAt),
+		archivePeriod(rotation, receivedAt),
-	)
+	), nil
 }
 
 // archiveFiles lists the database target's archive files that exist,
-// given the path Path gives it: the file at path, then each
+// given the path ArchivePath gives it: the file at path, then each
 // file archivePeriodPath names for path and a period, oldest period
 // first. Which rotation wrote a file does not matter, so the files of
 // an earlier rotation setting are listed too.

internal/delivery/target_database_rotation_test.go

@@ -1,4 +1,4 @@
-package archive_test
+package delivery_test
 
 import (
 	"os"
@@ -9,17 +9,21 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
 	"sneak.berlin/go/webhooker/internal/database/databasetest"
+	"sneak.berlin/go/webhooker/internal/delivery"
 )
 
-// The archive rotations.
+// The archive rotations, and the configs of a daily target and of one
+// whose rotation is not one of the four.
 const (
 	rotationNone    = "none"
 	rotationMonthly = "monthly"
 	rotationDaily   = "daily"
 	rotationHourly  = "hourly"
+
+	dailyConfig  = `{"rotation":"daily"}`
+	weeklyConfig = `{"rotation":"weekly"}`
 )
 
 // The periods the tests archive into most: two days, and an hour of
@@ -36,30 +40,32 @@ func periodPath(path, period string) string {
 	return strings.TrimSuffix(path, ".db") + "-" + period + ".db"
 }
 
-// deliverReceivedAt archives, as a delivery to a database target
+// deliverReceivedAt delivers to a database target an event whose
-// does, an event whose receive time is receivedAt, and returns the
+// receive time is receivedAt, and returns the event's id. The receive
-// event's id. The receive time is what decides a rotated archive's
+// time is what decides a rotated archive's file, so setting it is how
-// file, so setting it is how these tests move the clock across a
+// these tests move the clock across a period boundary.
-// period boundary.
 func (env *archiveEnv) deliverReceivedAt(
 	t *testing.T, tgt *database.Target, receivedAt time.Time,
 ) string {
 	t.Helper()
 
-	event := newEvent(`{"n":1}`)
+	webhookDB := testWebhookDB(t)
+	event := seedEvent(t, webhookDB, `{"n":1}`)
 	event.CreatedAt = receivedAt
 
-	require.NoError(t, env.writers.Write(databaseTargetDelivery(event, tgt)))
+	env.eng.ExportDeliverDatabase(
+		webhookDB, seedDatabaseTargetDelivery(t, webhookDB, event, tgt),
+	)
 
 	return event.ID
 }
 
-// TestWrite_RotatesAtEachPeriodBoundary writes, for each
+// TestDeliverDatabase_RotatesAtEachPeriodBoundary delivers, for each
 // rotation, an event received in the last second of a period and one
 // received in the first second of the next, and checks each lands in
 // the file named for its own period, in UTC. Rotation none keeps both
 // in the one file.
-func TestWrite_RotatesAtEachPeriodBoundary(t *testing.T) {
+func TestDeliverDatabase_RotatesAtEachPeriodBoundary(t *testing.T) {
 	t.Parallel()
 
 	berlin := time.FixedZone("CEST", 2*60*60)
@@ -104,7 +110,7 @@ func TestWrite_RotatesAtEachPeriodBoundary(t *testing.T) {
 			t.Parallel()
 
 			env := setupArchiveTest(t)
-			tgt := env.seedDatabaseTarget(t, 0, tc.rotation)
+			tgt := env.seedDatabaseTarget(t, `{"rotation":"`+tc.rotation+`"}`)
 			path := env.archivePath(tgt)
 
 			first := env.deliverReceivedAt(t, tgt, tc.before)
@@ -123,7 +129,7 @@ func TestWrite_RotatesAtEachPeriodBoundary(t *testing.T) {
 		t.Parallel()
 
 		env := setupArchiveTest(t)
-		tgt := env.seedDatabaseTarget(t, 0, rotationNone)
+		tgt := env.seedDatabaseTarget(t, `{"rotation":"`+rotationNone+`"}`)
 
 		first := env.deliverReceivedAt(t, tgt, cases[0].before)
 		second := env.deliverReceivedAt(t, tgt, cases[0].after)
@@ -133,14 +139,14 @@ func TestWrite_RotatesAtEachPeriodBoundary(t *testing.T) {
 	})
 }
 
-// TestWrite_EventWithoutReceiveTime proves an event whose
+// TestDeliverDatabase_EventWithoutReceiveTime proves an event whose
 // receive time is not known goes to the file for the time it is
 // archived, rather than to one for the year 1.
-func TestWrite_EventWithoutReceiveTime(t *testing.T) {
+func TestDeliverDatabase_EventWithoutReceiveTime(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, rotationMonthly)
+	tgt := env.seedDatabaseTarget(t, `{"rotation":"`+rotationMonthly+`"}`)
 	path := env.archivePath(tgt)
 
 	before := time.Now().UTC().Format("2006-01")
@@ -158,20 +164,20 @@ func TestWrite_EventWithoutReceiveTime(t *testing.T) {
 	assert.NoFileExists(t, periodPath(path, "0001-01"))
 }
 
-// TestWrite_RotationChangeKeepsOldFiles changes a target's
+// TestDeliverDatabase_RotationChangeKeepsOldFiles changes a target's
 // rotation from none to daily between two events, and checks the
 // second goes to the daily file while the first stays where it was.
-func TestWrite_RotationChangeKeepsOldFiles(t *testing.T) {
+func TestDeliverDatabase_RotationChangeKeepsOldFiles(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, rotationNone)
+	tgt := env.seedDatabaseTarget(t, "")
 	path := env.archivePath(tgt)
 	at := time.Date(2026, 3, 4, 12, 0, 0, 0, time.UTC)
 
 	first := env.deliverReceivedAt(t, tgt, at)
 
-	tgt.ArchiveRotation = rotationDaily
+	tgt.Config = dailyConfig
 	second := env.deliverReceivedAt(t, tgt, at)
 
 	assert.Equal(t, []string{first}, archivedEventIDs(t, path))
@@ -189,7 +195,9 @@ func TestArchiveSweep_PrunesEveryFile(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, time.Hour, rotationDaily)
+	tgt := env.seedDatabaseTarget(
+		t, `{"expiry":"1h","rotation":"`+rotationDaily+`"}`,
+	)
 	path := env.archivePath(tgt)
 	emptied := periodPath(path, dayPeriod)
 	kept := periodPath(path, nextDayPeriod)
@@ -219,17 +227,17 @@ func TestRename_MovesEveryFile(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, rotationNone)
+	tgt := env.seedDatabaseTarget(t, "")
 	oldPath := env.archivePath(tgt)
 	day := time.Date(2026, 3, 4, 12, 0, 0, 0, time.UTC)
 
 	unrotated := env.deliverReceivedAt(t, tgt, day)
 
-	tgt.ArchiveRotation = rotationDaily
+	tgt.Config = dailyConfig
 	first := env.deliverReceivedAt(t, tgt, day)
 	second := env.deliverReceivedAt(t, tgt, day.Add(24*time.Hour))
 
-	require.NoError(t, env.writers.Rename(tgt.ID, "Orders", "Long Term"))
+	require.NoError(t, env.eng.Rename(tgt.ID, "Orders", "Long Term"))
 
 	newPath := filepath.Join(
 		env.dataDir, "archive-orders-long-term-"+tgt.ID+".db",
@@ -261,7 +269,7 @@ func TestRename_NeverReplacesARotatedFile(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t, 0, rotationDaily)
+	tgt := env.seedDatabaseTarget(t, dailyConfig)
 	oldPath := env.archivePath(tgt)
 	day := time.Date(2026, 3, 4, 12, 0, 0, 0, time.UTC)
 
@@ -275,8 +283,8 @@ func TestRename_NeverReplacesARotatedFile(t *testing.T) {
 	require.NoError(t, os.WriteFile(planted, []byte("planted"), 0o600))
 
 	require.ErrorIs(
-		t, env.writers.Rename(tgt.ID, "Orders", "Long Term"),
+		t, env.eng.Rename(tgt.ID, "Orders", "Long Term"),
-		archive.ErrNameTaken,
+		delivery.ErrArchiveNameTaken,
 	)
 
 	assert.FileExists(t, periodPath(oldPath, dayPeriod))
@@ -284,7 +292,7 @@ func TestRename_NeverReplacesARotatedFile(t *testing.T) {
 	assert.NoFileExists(t, periodPath(newPath, dayPeriod))
 }
 
-// TestStatArchive_EveryFile proves Stat counts and adds up every
+// TestStatArchive_EveryFile proves StatArchive counts and adds up every
 // one of a target's files, takes the latest write of any of them, and
 // leaves out files whose names only look like the target's.
 func TestStatArchive_EveryFile(t *testing.T) {
@@ -316,7 +324,7 @@ func TestStatArchive_EveryFile(t *testing.T) {
 			os.WriteFile(filepath.Join(dir, other), []byte("x"), 0o600))
 	}
 
-	got, err := archive.Stat(path)
+	got, err := delivery.StatArchive(path)
 	require.NoError(t, err)
 	assert.Equal(t, len(files), got.Files)
 	assert.Equal(t, size, got.Size)
@@ -335,27 +343,34 @@ func TestArchivePathAt(t *testing.T) {
 	at := time.Date(2026, 10, 1, 19, 30, 0, 0, time.UTC)
 
 	cases := map[string]string{
-		"":              "",
+		"":                                       "",
-		rotationNone:    "",
+		`{"rotation":"` + rotationNone + `"}`:    "",
-		rotationMonthly: "-2026-10",
+		`{"rotation":"` + rotationMonthly + `"}`: "-2026-10",
-		rotationDaily:   "-2026-10-01",
+		dailyConfig:                              "-2026-10-01",
-		rotationHourly:  "-2026-10-01-19",
+		`{"rotation":"` + rotationHourly + `"}`:  "-2026-10-01-19",
 	}
 
-	for rotation, period := range cases {
+	for config, period := range cases {
 		target := &database.Target{
-			BaseModel:       database.BaseModel{ID: "tgt-id"},
+			BaseModel: database.BaseModel{ID: "tgt-id"},
-			Name:            "Archive",
+			Name:      "Archive",
-			ArchiveRotation: rotation,
+			Config:    config,
 		}
 
+		got, err := delivery.ArchivePathAt(dbMgr, webhook, target, at)
+		require.NoError(t, err, config)
 		assert.Equal(t,
 			filepath.Join(
 				dataDir, "archive-orders-archive-tgt-id"+period+".db",
 			),
-			archive.PathAt(dbMgr, webhook, target, at), rotation,
+			got, config,
 		)
 	}
+
+	_, err := delivery.ArchivePathAt(dbMgr, webhook, &database.Target{
+		Config: weeklyConfig,
+	}, at)
+	require.Error(t, err)
 }
 
 // TestValidateArchiveRotation accepts the four rotations, and empty,
@@ -366,10 +381,10 @@ func TestValidateArchiveRotation(t *testing.T) {
 	for _, ok := range []string{
 		"", rotationNone, rotationMonthly, rotationDaily, rotationHourly,
 	} {
-		require.NoError(t, archive.ValidateRotation(ok), ok)
+		require.NoError(t, delivery.ValidateArchiveRotation(ok), ok)
 	}
 
 	for _, bad := range []string{"weekly", "Daily", "hourly "} {
-		require.Error(t, archive.ValidateRotation(bad), bad)
+		require.Error(t, delivery.ValidateArchiveRotation(bad), bad)
 	}
 }

internal/delivery/target_database_test.go

@@ -1,69 +1,26 @@
 package delivery_test
 
 import (
-	"context"
 	"database/sql"
 	"fmt"
+	"io/fs"
 	"log/slog"
-	"net/http"
 	"os"
 	"path/filepath"
+	"strings"
 	"testing"
 	"time"
 
-	"github.com/google/uuid"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"gorm.io/driver/sqlite"
 	"gorm.io/gorm"
-	"gorm.io/gorm/clause"
 	_ "modernc.org/sqlite" // Pure Go SQLite driver.
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
-	"sneak.berlin/go/webhooker/internal/database/databasetest"
-	"sneak.berlin/go/webhooker/internal/db/migrations"
 	"sneak.berlin/go/webhooker/internal/delivery"
 	"sneak.berlin/go/webhooker/internal/gormlog"
 )
 
-// archiveTestWebhookName is the name of every webhook
-// seedDatabaseTarget creates. It is not safe in a file name as it
-// stands, so every archive file name made from it is made safe first.
-const archiveTestWebhookName = "Sweep Test!"
-
-// archiveEnv bundles the pieces a database target test drives: a main
-// configuration database holding webhooks and targets, a delivery
-// engine whose archive writers write into the data directory, and that
-// directory.
-type archiveEnv struct {
-	eng     *delivery.Engine
-	mainDB  *database.Database
-	dataDir string
-}
-
-func setupArchiveTest(t *testing.T) *archiveEnv {
-	t.Helper()
-
-	dataDir := t.TempDir()
-
-	mainDB, err := database.Open(dataDir, slog.New(slog.DiscardHandler))
-	require.NoError(t, err)
-
-	t.Cleanup(func() { _ = mainDB.Close() })
-
-	return &archiveEnv{
-		eng: delivery.NewTestEngineWithDB(
-			mainDB,
-			databasetest.NewWebhookDBManager(t, dataDir),
-			archiveTestLogger(),
-			&http.Client{Timeout: 5 * time.Second},
-			1,
-		),
-		mainDB:  mainDB,
-		dataDir: dataDir,
-	}
-}
-
 func archiveTestLogger() *slog.Logger {
 	return slog.New(slog.NewTextHandler(
 		os.Stderr,
@@ -71,87 +28,8 @@ func archiveTestLogger() *slog.Logger {
 	))
 }
 
-// archivePath returns where the engine keeps a database target's
-// archive file, for the names seedDatabaseTarget gave it.
-func (env *archiveEnv) archivePath(tgt *database.Target) string {
-	return filepath.Join(
-		env.dataDir,
-		archive.FileName(archiveTestWebhookName, tgt.Name, tgt.ID),
-	)
-}
-
-// seedDatabaseTarget creates a webhook with one database target,
-// which keeps its archive forever in one file, and returns the
-// target.
-func (env *archiveEnv) seedDatabaseTarget(
-	t *testing.T,
-) *database.Target {
-	t.Helper()
-
-	wh := &database.Webhook{
-		UserID: uuid.New().String(),
-		Name:   archiveTestWebhookName,
-	}
-	require.NoError(
-		t,
-		env.mainDB.DB().
-			Omit(clause.Associations).
-			Create(wh).Error,
-	)
-
-	tgt := &database.Target{
-		WebhookID:       wh.ID,
-		Name:            "Archive",
-		Type:            database.TargetTypeDatabase,
-		Active:          true,
-		ArchiveRotation: "none",
-		MaxAttempts:     1,
-	}
-	require.NoError(
-		t,
-		env.mainDB.DB().
-			Omit(clause.Associations).
-			Create(tgt).Error,
-	)
-
-	return tgt
-}
-
-// seedDatabaseTargetDelivery seeds a pending delivery of an event
-// to a database target and returns the in-memory delivery the
-// target handler is invoked with.
-func seedDatabaseTargetDelivery(
-	t *testing.T,
-	webhookDB *gorm.DB,
-	event database.Event,
-	tgt *database.Target,
-) *database.Delivery {
-	t.Helper()
-
-	dlv := seedDelivery(
-		t, webhookDB, event.ID, tgt.ID,
-		database.DeliveryStatusPending,
-	)
-
-	d := &database.Delivery{
-		EventID:  event.ID,
-		TargetID: tgt.ID,
-		Status:   database.DeliveryStatusPending,
-		Event:    event,
-		Target: database.Target{
-			Name:            tgt.Name,
-			Type:            database.TargetTypeDatabase,
-			ArchiveExpiry:   tgt.ArchiveExpiry,
-			ArchiveRotation: tgt.ArchiveRotation,
-		},
-	}
-	d.ID = dlv.ID
-
-	return d
-}
-
 // openArchiveDBForRead opens an archive file read-only so a
-// test can inspect the rows the database target archived.
+// test can inspect the rows the writer persisted.
 func openArchiveDBForRead(
 	t *testing.T, path string,
 ) *gorm.DB {
@@ -174,45 +52,26 @@ func openArchiveDBForRead(
 	return gdb
 }
 
-// countArchivedRows counts the rows in an archive file without
+// archiveFileSuffixes returns the archive file itself and the
-// asserting anything, so it is safe to poll from an
+// SQLite sidecars that accompany an open database. A test that
-// assert.Eventually condition (which runs off the test
+// asserts no archive was created has to check all of them.
-// goroutine, where testify assertions must not be used).
+func archiveFileSuffixes() []string {
-func countArchivedRows(path string) (int64, error) {
+	return []string{"", "-wal", "-shm"}
-	sqlDB, err := sql.Open(
-		"sqlite", fmt.Sprintf("file:%s?mode=ro", path),
-	)
-	if err != nil {
-		return 0, err
-	}
-
-	defer func() { _ = sqlDB.Close() }()
-
-	gdb, err := gorm.Open(
-		sqlite.Dialector{Conn: sqlDB},
-		&gorm.Config{Logger: gormlog.New(slog.New(slog.DiscardHandler))},
-	)
-	if err != nil {
-		return 0, err
-	}
-
-	var count int64
-
-	err = gdb.Table("archived_events").Count(&count).Error
-	if err != nil {
-		return 0, err
-	}
-
-	return count, nil
 }
 
-// archivedRow is the columns of an archive row these tests read.
+// removeArchiveFiles simulates an operator moving the archive
-type archivedRow struct {
+// away by deleting the SQLite file and its sidecar files.
-	EventID   string
+func removeArchiveFiles(t *testing.T, path string) {
-	WebhookID string
+	t.Helper()
-	Method    string
+
-	RawQuery  string
+	for _, suffix := range []string{
-	Body      string
+		"", "-wal", "-shm", "-journal",
+	} {
+		err := os.Remove(path + suffix)
+		if err != nil && !os.IsNotExist(err) {
+			t.Fatalf("removing %s%s: %v", path, suffix, err)
+		}
+	}
 }
 
 // TestDeliverDatabase_ArchivesEvent verifies that delivering to
@@ -222,7 +81,7 @@ func TestDeliverDatabase_ArchivesEvent(t *testing.T) {
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t)
+	tgt := env.seedDatabaseTarget(t, "")
 
 	webhookDB := testWebhookDB(t)
 	event := seedEvent(t, webhookDB, `{"archived":true}`)
@@ -248,9 +107,9 @@ func TestDeliverDatabase_ArchivesEvent(t *testing.T) {
 
 	rdb := openArchiveDBForRead(t, archivePath)
 
-	var rows []archivedRow
+	var rows []delivery.ExportArchivedEvent
 
-	require.NoError(t, rdb.Table("archived_events").Find(&rows).Error)
+	require.NoError(t, rdb.Find(&rows).Error)
 	require.Len(t, rows, 1)
 	assert.Equal(t, event.ID, rows[0].EventID)
 	assert.Equal(t, event.WebhookID, rows[0].WebhookID)
@@ -259,10 +118,259 @@ func TestDeliverDatabase_ArchivesEvent(t *testing.T) {
 	assert.JSONEq(t, `{"archived":true}`, rows[0].Body)
 }
 
+func TestArchiveWriter_WritesRow(t *testing.T) {
+	t.Parallel()
+
+	path := filepath.Join(t.TempDir(), "archive-wh.db")
+	w := delivery.NewExportArchiveWriter(
+		path, archiveTestLogger(), 0,
+	)
+
+	row := delivery.ExportArchivedEvent{
+		EventID:      "ev-1",
+		WebhookID:    "wh-1",
+		EntrypointID: "ep-1",
+		Method:       "POST",
+		Headers:      `{"X":"Y"}`,
+		Body:         `{"hello":"world"}`,
+		ContentType:  "application/json",
+	}
+
+	require.NoError(t, w.Write(row, 0))
+	assert.FileExists(t, path)
+
+	var got []delivery.ExportArchivedEvent
+
+	require.NoError(t, w.DB().Find(&got).Error)
+	require.Len(t, got, 1)
+	assert.Equal(t, "ev-1", got[0].EventID)
+	assert.Equal(t, "wh-1", got[0].WebhookID)
+	assert.Equal(t, "ep-1", got[0].EntrypointID)
+	assert.Equal(t, row.Method, got[0].Method)
+	assert.Equal(t, row.ContentType, got[0].ContentType)
+	assert.JSONEq(t, `{"hello":"world"}`, got[0].Body)
+	assert.False(t, got[0].ArchivedAt.IsZero())
+}
+
+func TestArchiveWriter_RecreatesAfterRemoval(
+	t *testing.T,
+) {
+	t.Parallel()
+
+	path := filepath.Join(t.TempDir(), "archive-wh.db")
+	w := delivery.NewExportArchiveWriter(
+		path, archiveTestLogger(), 0,
+	)
+
+	require.NoError(t, w.Write(
+		delivery.ExportArchivedEvent{EventID: "a"}, 0,
+	))
+	assert.FileExists(t, path)
+
+	// The operator moves the archive away while the handle is
+	// still open.
+	removeArchiveFiles(t, path)
+	require.NoFileExists(t, path)
+
+	// The next write recreates the file with a fresh schema and
+	// only the new row.
+	require.NoError(t, w.Write(
+		delivery.ExportArchivedEvent{EventID: "b"}, 0,
+	))
+	assert.FileExists(t, path)
+
+	var got []delivery.ExportArchivedEvent
+
+	require.NoError(t, w.DB().Find(&got).Error)
+	require.Len(t, got, 1)
+	assert.Equal(t, "b", got[0].EventID)
+}
+
+// TestStatArchive proves StatArchive finds no file before the first
+// write; after a write still held in the -wal, counts the -wal in the
+// size and takes its later time as the last write; and finds no file
+// again once the file has been moved away.
+func TestStatArchive(t *testing.T) {
+	t.Parallel()
+
+	path := filepath.Join(t.TempDir(), "archive-wh.db")
+
+	_, err := delivery.StatArchive(path)
+	require.ErrorIs(t, err, fs.ErrNotExist)
+
+	// With the clock stopped, the reopen debounce never passes, so
+	// the handle stays open after the write.
+	stopped := time.Now()
+	w := delivery.NewExportArchiveWriter(path, archiveTestLogger(), 0)
+	w.SetNow(func() time.Time { return stopped })
+
+	require.NoError(t, w.Write(delivery.ExportArchivedEvent{EventID: "a"}, 0))
+
+	written := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
+	earlier := written.Add(-time.Hour)
+	require.NoError(t, os.Chtimes(path, earlier, earlier))
+	require.NoError(t, os.Chtimes(path+"-wal", written, written))
+
+	file, err := os.Stat(path)
+	require.NoError(t, err)
+
+	wal, err := os.Stat(path + "-wal")
+	require.NoError(t, err)
+	require.Positive(t, wal.Size())
+
+	got, err := delivery.StatArchive(path)
+	require.NoError(t, err)
+	assert.Equal(t, 1, got.Files)
+	assert.Equal(t, file.Size()+wal.Size(), got.Size)
+	assert.True(t, written.Equal(got.Written), got.Written)
+
+	removeArchiveFiles(t, path)
+
+	_, err = delivery.StatArchive(path)
+	require.ErrorIs(t, err, fs.ErrNotExist)
+}
+
+func TestArchiveWriter_ReopenDebounce(t *testing.T) {
+	t.Parallel()
+
+	const debounce = 2 * time.Second
+
+	path := filepath.Join(t.TempDir(), "archive-wh.db")
+	w := delivery.NewExportArchiveWriter(
+		path, archiveTestLogger(), debounce,
+	)
+
+	// The writer measures its reopen debounce on this clock, which
+	// only the test moves, so how long the host takes between
+	// writes cannot change the result.
+	now := time.Now()
+
+	w.SetNow(func() time.Time { return now })
+
+	require.NoError(t, w.Write(
+		delivery.ExportArchivedEvent{EventID: "a"}, 0,
+	))
+	require.NoError(t, w.Write(
+		delivery.ExportArchivedEvent{EventID: "b"}, 0,
+	))
+
+	// Two writes inside the debounce window trigger only the
+	// initial open — no extra close/reopen.
+	assert.Equal(t, 1, w.Reopens())
+
+	now = now.Add(debounce)
+
+	require.NoError(t, w.Write(
+		delivery.ExportArchivedEvent{EventID: "c"}, 0,
+	))
+
+	// A write after the window elapses closes and reopens once.
+	assert.Equal(t, 2, w.Reopens())
+}
+
+func TestArchiveWriter_ExpiryPrune(t *testing.T) {
+	t.Parallel()
+
+	path := filepath.Join(t.TempDir(), "archive-wh.db")
+	w := delivery.NewExportArchiveWriter(
+		path, archiveTestLogger(), 0,
+	)
+
+	require.NoError(t, w.Open(0))
+
+	old := delivery.ExportArchivedEvent{
+		EventID:    "old",
+		ArchivedAt: time.Now().Add(-2 * time.Hour),
+	}
+	fresh := delivery.ExportArchivedEvent{
+		EventID:    "fresh",
+		ArchivedAt: time.Now(),
+	}
+
+	require.NoError(t, w.DB().Create(&old).Error)
+	require.NoError(t, w.DB().Create(&fresh).Error)
+
+	// Reopening with a one-hour expiry prunes the old row.
+	require.NoError(t, w.Reopen(time.Hour))
+
+	var got []delivery.ExportArchivedEvent
+
+	require.NoError(t, w.DB().Find(&got).Error)
+	require.Len(t, got, 1)
+	assert.Equal(t, "fresh", got[0].EventID)
+}
+
+func TestParseArchiveExpiry(t *testing.T) {
+	t.Parallel()
+
+	cases := []struct {
+		name    string
+		in      string
+		want    time.Duration
+		wantErr bool
+	}{
+		{"empty config", "", 0, false},
+		{"explicit never", `{"expiry":"never"}`, 0, false},
+		{"empty expiry", `{"expiry":""}`, 0, false},
+		{"duration", `{"expiry":"1h"}`, time.Hour, false},
+		{"unparseable", `{"expiry":"nonsense"}`, 0, true},
+		{"zero duration", `{"expiry":"0s"}`, 0, true},
+		{"negative duration", `{"expiry":"-5h"}`, 0, true},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+
+			got, err := delivery.ExportParseArchiveExpiry(tc.in)
+			if tc.wantErr {
+				require.Error(t, err)
+
+				return
+			}
+
+			require.NoError(t, err)
+			assert.Equal(t, tc.want, got)
+		})
+	}
+}
+
+// seedDatabaseTargetDelivery seeds a pending delivery of an event
+// to a database target and returns the in-memory delivery the
+// target handler is invoked with.
+func seedDatabaseTargetDelivery(
+	t *testing.T,
+	webhookDB *gorm.DB,
+	event database.Event,
+	tgt *database.Target,
+) *database.Delivery {
+	t.Helper()
+
+	dlv := seedDelivery(
+		t, webhookDB, event.ID, tgt.ID,
+		database.DeliveryStatusPending,
+	)
+
+	d := &database.Delivery{
+		EventID:  event.ID,
+		TargetID: tgt.ID,
+		Status:   database.DeliveryStatusPending,
+		Event:    event,
+		Target: database.Target{
+			Name:   tgt.Name,
+			Type:   database.TargetTypeDatabase,
+			Config: tgt.Config,
+		},
+	}
+	d.ID = dlv.ID
+
+	return d
+}
+
 // TestDeliverDatabase_ArchiveFailureFailsDelivery verifies that
-// an archive error (here: an event with no webhook id to record)
+// an archive error (here: an unparseable expiry in the target
-// fails the delivery loudly: the attempt is recorded as failed
+// config) fails the delivery loudly: the attempt is recorded as
-// with the error and the delivery is marked failed, not
+// failed with the error and the delivery is marked failed, not
 // delivered.
 func TestDeliverDatabase_ArchiveFailureFailsDelivery(
 	t *testing.T,
@@ -270,12 +378,11 @@ func TestDeliverDatabase_ArchiveFailureFailsDelivery(
 	t.Parallel()
 
 	env := setupArchiveTest(t)
-	tgt := env.seedDatabaseTarget(t)
+	tgt := env.seedDatabaseTarget(t, `{"expiry":"nonsense"}`)
 
 	webhookDB := testWebhookDB(t)
 	event := seedEvent(t, webhookDB, `{"archived":false}`)
 	d := seedDatabaseTargetDelivery(t, webhookDB, event, tgt)
-	d.Event.WebhookID = ""
 
 	env.eng.ExportDeliverDatabase(webhookDB, d)
 
@@ -300,96 +407,357 @@ func TestDeliverDatabase_ArchiveFailureFailsDelivery(
 		"the attempt must be recorded as failed",
 	)
 	assert.Contains(t,
-		results[0].Error, "without a webhook id",
+		results[0].Error, "nonsense",
 		"the archive error must be recorded on the attempt",
 	)
 
 	assert.NoFileExists(t,
 		env.archivePath(tgt),
-		"no archive file should exist for a failed write",
+		"no archive file should exist for a failed config",
 	)
 }
 
-// seedArchivedRow creates the archive file at path holding one row, for
+func TestValidateArchiveExpiry(t *testing.T) {
-// eventID, archived at archivedAt.
-func seedArchivedRow(
-	t *testing.T, path, eventID string, archivedAt time.Time,
-) {
-	t.Helper()
-
-	sqlDB, err := sql.Open(
-		"sqlite", fmt.Sprintf("file:%s?mode=rwc", path),
-	)
-	require.NoError(t, err)
-
-	defer func() { _ = sqlDB.Close() }()
-
-	gdb, err := gorm.Open(
-		sqlite.Dialector{Conn: sqlDB},
-		&gorm.Config{Logger: gormlog.New(slog.New(slog.DiscardHandler))},
-	)
-	require.NoError(t, err)
-
-	require.NoError(t, migrations.Apply(gdb, migrations.Archive))
-	require.NoError(t, gdb.Exec(
-		"INSERT INTO archived_events (event_id, archived_at) VALUES (?, ?)",
-		eventID, archivedAt,
-	).Error)
-}
-
-// TestDeliverDatabase_TaskArchiveSettings proves a task's ArchiveExpiry
-// and ArchiveRotation reach the archive through the engine. The
-// target's row has neither, so only the task can bring them: with daily
-// rotation the event goes to the file for its day, and opening that
-// file with a one-hour expiry prunes the row it already held, archived
-// two hours ago.
-func TestDeliverDatabase_TaskArchiveSettings(t *testing.T) {
 	t.Parallel()
 
-	s := newISetup(t)
+	valid := []string{"", "never", "1h", "720h", "30m"}
-
+	for _, in := range valid {
-	webhook := database.Webhook{UserID: uuid.NewString(), Name: "settings"}
+		require.NoError(t,
-	webhook.ID = s.WebhookID
+			delivery.ValidateArchiveExpiry(in),
-	require.NoError(t, s.MainDB.Create(&webhook).Error)
+			"expiry %q should be accepted", in,
-
+		)
-	target := database.Target{
-		WebhookID:   s.WebhookID,
-		Name:        "archive",
-		Type:        database.TargetTypeDatabase,
-		Active:      true,
-		MaxAttempts: 1,
 	}
-	require.NoError(t, s.MainDB.Create(&target).Error)
 
-	event := iSeedEvent(t, s.WebhookDB, s.WebhookID, `{"archived":true}`)
+	invalid := []string{"nonsense", "7d", "-5h", "0s", "0"}
-	d := iSeedDelivery(
+	for _, in := range invalid {
-		t, s.WebhookDB, event.ID, target.ID,
+		require.Error(t,
-		database.DeliveryStatusPending,
+			delivery.ValidateArchiveExpiry(in),
+			"expiry %q should be rejected", in,
+		)
+	}
+}
+
+// TestArchiveFileName pins the archive file name and the rules
+// that make a webhook or target name safe to put in it.
+func TestArchiveFileName(t *testing.T) {
+	t.Parallel()
+
+	const id = "3f2a1c9e-8d4b-4c1a-9e2f-0a1b2c3d4e5f"
+
+	cases := []struct {
+		name    string
+		webhook string
+		target  string
+		want    string
+	}{
+		{
+			"plain names", "orders", "archive",
+			"archive-orders-archive-" + id + ".db",
+		},
+		{
+			"lowercased", "Orders", "Main Archive",
+			"archive-orders-main-archive-" + id + ".db",
+		},
+		{
+			"a run of other characters is one dash",
+			`a  /\..b`, "c__--d",
+			"archive-a-b-c-d-" + id + ".db",
+		},
+		{
+			"no dash at either end", "  --orders!! ", "(archive)",
+			"archive-orders-archive-" + id + ".db",
+		},
+		{
+			"path separators", "../../etc/passwd", "a/b",
+			"archive-etc-passwd-a-b-" + id + ".db",
+		},
+		{
+			"letters outside ASCII are dropped",
+			"Bestellungen Größe", "café",
+			"archive-bestellungen-gr-e-caf-" + id + ".db",
+		},
+		{
+			"nothing left is unnamed", "", "!!!",
+			"archive-unnamed-unnamed-" + id + ".db",
+		},
+		{
+			"cut to 40 characters", strings.Repeat("a", 50), "x",
+			"archive-" + strings.Repeat("a", 40) + "-x-" + id + ".db",
+		},
+		{
+			"no dash left by the cut",
+			strings.Repeat("a", 39) + " b", "x",
+			"archive-" + strings.Repeat("a", 39) + "-x-" + id + ".db",
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+
+			assert.Equal(
+				t, tc.want,
+				delivery.ArchiveFileName(tc.webhook, tc.target, id),
+			)
+		})
+	}
+}
+
+// TestDeliverDatabase_EachTargetHasItsOwnArchive proves two
+// database targets of one webhook archive into separate files.
+func TestDeliverDatabase_EachTargetHasItsOwnArchive(t *testing.T) {
+	t.Parallel()
+
+	env := setupArchiveTest(t)
+	first := env.seedDatabaseTarget(t, "")
+	second := env.addDatabaseTarget(t, first.WebhookID, "")
+
+	webhookDB := testWebhookDB(t)
+	event := seedEvent(t, webhookDB, `{"n":1}`)
+
+	for _, tgt := range []*database.Target{first, second} {
+		env.eng.ExportDeliverDatabase(
+			webhookDB,
+			seedDatabaseTargetDelivery(t, webhookDB, event, tgt),
+		)
+	}
+
+	require.NotEqual(
+		t, env.archivePath(first), env.archivePath(second),
 	)
-
+	assert.Equal(
-	task := iTask(
+		t, []string{event.ID},
-		d, event, s.WebhookID, target.ID, target.Name, "", 1, 1,
+		archivedEventIDs(t, env.archivePath(first)),
-		&event.Body,
 	)
-	task.TargetType = database.TargetTypeDatabase
+	assert.Equal(
-	task.ArchiveExpiry = time.Hour
+		t, []string{event.ID},
-	task.ArchiveRotation = "daily"
+		archivedEventIDs(t, env.archivePath(second)),
-
-	daily := target
-	daily.ArchiveRotation = task.ArchiveRotation
-	dailyFile := archive.PathAt(s.DBMgr, &webhook, &daily, event.CreatedAt)
-	seedArchivedRow(t, dailyFile, "expired", time.Now().Add(-2*time.Hour))
-
-	s.Engine.ExportProcessNewTask(context.TODO(), &task)
-
-	iAssertStatus(t, s.WebhookDB, d.ID, database.DeliveryStatusDelivered)
-
-	var rows []archivedRow
-
-	require.NoError(t, openArchiveDBForRead(t, dailyFile).
-		Table("archived_events").Find(&rows).Error)
-	require.Len(t, rows, 1)
-	assert.Equal(t, event.ID, rows[0].EventID,
-		"the event goes to its day's file and the expired row is pruned",
 	)
 }
+
+// TestRename_MovesTheFile proves a rename moves the archive, rows
+// and all, and that later writes go to the new name.
+func TestRename_MovesTheFile(t *testing.T) {
+	t.Parallel()
+
+	env := setupArchiveTest(t)
+	tgt := env.seedDatabaseTarget(t, "")
+	oldPath := env.archivePath(tgt)
+
+	webhookDB := testWebhookDB(t)
+	first := seedEvent(t, webhookDB, `{"n":1}`)
+	env.eng.ExportDeliverDatabase(
+		webhookDB, seedDatabaseTargetDelivery(t, webhookDB, first, tgt),
+	)
+	require.FileExists(t, oldPath)
+
+	require.NoError(
+		t, env.eng.Rename(tgt.ID, "Orders", "Long Term"),
+	)
+
+	newPath := filepath.Join(
+		env.dataDir, "archive-orders-long-term-"+tgt.ID+".db",
+	)
+
+	assert.NoFileExists(t, oldPath)
+	assert.Equal(t, []string{first.ID}, archivedEventIDs(t, newPath))
+
+	second := seedEvent(t, webhookDB, `{"n":2}`)
+	env.eng.ExportDeliverDatabase(
+		webhookDB,
+		seedDatabaseTargetDelivery(t, webhookDB, second, tgt),
+	)
+
+	assert.ElementsMatch(
+		t, []string{first.ID, second.ID},
+		archivedEventIDs(t, newPath),
+	)
+	assert.NoFileExists(
+		t, oldPath, "a write after the rename must use the new name",
+	)
+}
+
+// TestRename_NeverReplacesAFile plants a file at the new name, once
+// the .db alone, once a lone -wal and once a lone -shm, and proves
+// each time that the rename is refused, the planted file survives,
+// and the archive keeps its name and its rows.
+func TestRename_NeverReplacesAFile(t *testing.T) {
+	t.Parallel()
+
+	for _, suffix := range archiveFileSuffixes() {
+		t.Run("planted .db"+suffix, func(t *testing.T) {
+			t.Parallel()
+
+			env := setupArchiveTest(t)
+			tgt := env.seedDatabaseTarget(t, "")
+			oldPath := env.archivePath(tgt)
+
+			webhookDB := testWebhookDB(t)
+			first := seedEvent(t, webhookDB, `{"n":1}`)
+			env.eng.ExportDeliverDatabase(
+				webhookDB,
+				seedDatabaseTargetDelivery(t, webhookDB, first, tgt),
+			)
+
+			newPath := filepath.Join(
+				env.dataDir, "archive-orders-long-term-"+tgt.ID+".db",
+			)
+			plantedPath := newPath + suffix
+			require.NoError(
+				t, os.WriteFile(plantedPath, []byte("planted"), 0o600),
+			)
+
+			require.ErrorIs(
+				t, env.eng.Rename(tgt.ID, "Orders", "Long Term"),
+				delivery.ErrArchiveNameTaken,
+			)
+
+			//nolint:gosec // reads the file the test planted under t.TempDir()
+			planted, err := os.ReadFile(plantedPath)
+			require.NoError(t, err)
+			assert.Equal(t, "planted", string(planted))
+
+			second := seedEvent(t, webhookDB, `{"n":2}`)
+			env.eng.ExportDeliverDatabase(
+				webhookDB,
+				seedDatabaseTargetDelivery(t, webhookDB, second, tgt),
+			)
+
+			assert.ElementsMatch(
+				t, []string{first.ID, second.ID},
+				archivedEventIDs(t, oldPath),
+			)
+		})
+	}
+}
+
+// TestRename_BeforeTheNameIsSaved covers the order the handlers
+// use: they rename before they save the new name, so a delivery in
+// between must write under the new name although the main database
+// still has the old one. It also shows that renaming an archive that
+// does not exist yet is not an error.
+func TestRename_BeforeTheNameIsSaved(t *testing.T) {
+	t.Parallel()
+
+	env := setupArchiveTest(t)
+	tgt := env.seedDatabaseTarget(t, "")
+
+	require.NoError(
+		t, env.eng.Rename(tgt.ID, "Orders", "Archive"),
+	)
+
+	webhookDB := testWebhookDB(t)
+	event := seedEvent(t, webhookDB, `{"n":1}`)
+	env.eng.ExportDeliverDatabase(
+		webhookDB, seedDatabaseTargetDelivery(t, webhookDB, event, tgt),
+	)
+
+	assert.FileExists(
+		t,
+		filepath.Join(
+			env.dataDir, "archive-orders-archive-"+tgt.ID+".db",
+		),
+	)
+	assert.NoFileExists(t, env.archivePath(tgt))
+}
+
+// TestArchiveWriter_RenameMovesSidecars proves a rename carries
+// the -wal and -shm a crash can leave beside an archive no handle
+// has opened since. SQLite finds them by name, so a -wal left
+// behind would lose the transactions it holds.
+func TestArchiveWriter_RenameMovesSidecars(t *testing.T) {
+	t.Parallel()
+
+	dir := t.TempDir()
+	oldPath := filepath.Join(dir, "archive-old.db")
+	newPath := filepath.Join(dir, "archive-new.db")
+
+	for _, suffix := range archiveFileSuffixes() {
+		require.NoError(
+			t, os.WriteFile(oldPath+suffix, []byte(suffix), 0o600),
+		)
+	}
+
+	w := delivery.NewExportArchiveWriter(
+		oldPath, archiveTestLogger(), 0,
+	)
+
+	require.NoError(t, w.Rename("archive-new.db"))
+
+	for _, suffix := range archiveFileSuffixes() {
+		assert.NoFileExists(t, oldPath+suffix)
+		assert.FileExists(t, newPath+suffix)
+	}
+
+	assert.Equal(t, newPath, w.Path())
+}
+
+// TestArchiveWriter_RenameMovesBackOnFailure makes the -wal fail to
+// move after the .db has moved, and proves the .db is moved back, so
+// the archive is never split across two names. The new name is 255
+// bytes, the longest a file name may be, so the .db can take it but
+// the -wal, four bytes longer, cannot.
+func TestArchiveWriter_RenameMovesBackOnFailure(t *testing.T) {
+	t.Parallel()
+
+	dir := t.TempDir()
+	oldPath := filepath.Join(dir, "archive-old.db")
+	newName := strings.Repeat("a", 252) + ".db"
+
+	for _, suffix := range archiveFileSuffixes() {
+		require.NoError(
+			t, os.WriteFile(oldPath+suffix, []byte(suffix), 0o600),
+		)
+	}
+
+	w := delivery.NewExportArchiveWriter(
+		oldPath, archiveTestLogger(), 0,
+	)
+
+	require.Error(t, w.Rename(newName))
+
+	for _, suffix := range archiveFileSuffixes() {
+		assert.FileExists(t, oldPath+suffix)
+	}
+
+	assert.NoFileExists(t, filepath.Join(dir, newName))
+	assert.Equal(t, oldPath, w.Path())
+}
+
+// TestArchiveWriter_RenameMovesBackEveryFile renames a target with a
+// file without a period and a file for a month, and proves that when
+// the month's file fails to move, the file already moved is moved back:
+// both files are under the old name with their rows, and nothing is
+// under the new name. The new name is 251 bytes, so the file without a
+// period, with its -wal and -shm, can take it, but the month's file,
+// eight bytes longer, cannot.
+func TestArchiveWriter_RenameMovesBackEveryFile(t *testing.T) {
+	t.Parallel()
+
+	dir := t.TempDir()
+	oldPath := filepath.Join(dir, "archive-old.db")
+	monthPath := filepath.Join(dir, "archive-old-2026-03.db")
+	w := delivery.NewExportArchiveWriter(oldPath, archiveTestLogger(), 0)
+
+	require.NoError(t, w.WritePeriod(
+		delivery.ExportArchivedEvent{EventID: "in-none"}, 0, "",
+	))
+	require.NoError(t, w.WritePeriod(
+		delivery.ExportArchivedEvent{EventID: "in-month"}, 0, "2026-03",
+	))
+
+	require.Error(t, w.Rename(strings.Repeat("a", 248)+".db"))
+
+	assert.Equal(t, []string{"in-none"}, archivedEventIDs(t, oldPath))
+	assert.Equal(t, []string{"in-month"}, archivedEventIDs(t, monthPath))
+
+	entries, err := os.ReadDir(dir)
+	require.NoError(t, err)
+
+	for _, entry := range entries {
+		assert.True(t, strings.HasPrefix(entry.Name(), "archive-old"),
+			"%s is not under the old name", entry.Name())
+	}
+
+	assert.Equal(t, oldPath, w.Path())
+}

internal/delivery/target_headers.go

@@ -17,7 +17,7 @@ import (
 const MaxTargetTimeoutSeconds = 300
 
 // Errors returned when a target's header or timeout form input
-// cannot be turned into the target's setting.
+// cannot be turned into a configuration.
 //
 // None of these ever quotes a header VALUE. A target header value
 // is routinely an authorization token, and these messages are shown
@@ -48,8 +48,8 @@ var (
 )
 
 // isReservedTargetHeader reports whether name (canonicalised) is a
-// header a target may not set, because the delivery path or
+// header a target configuration may not set, because the delivery
-// net/http itself writes it regardless.
+// path or net/http itself writes it regardless.
 //
 // These are rejected rather than accepted-and-ignored. Storing a
 // header that provably never reaches the wire tells the operator
@@ -77,11 +77,13 @@ func isReservedTargetHeader(name string) bool {
 
 // ParseTargetHeaders turns the target form's headers field — one
 // "Name: value" pair per line, blank lines ignored — into the map
-// stored in database.Target.Headers. Names are canonicalised, so a
+// stored in HTTPTargetConfig.Headers. Names are canonicalised, so a
 // name repeated in a different case is still a duplicate rather than
 // one pair silently overwriting the other.
 //
-// An input with no pairs yields an empty map.
+// An input with no pairs yields an empty map, which omitempty drops
+// from the stored config: a target configured with no headers keeps
+// the same config JSON it had before this field existed.
 func ParseTargetHeaders(raw string) (map[string]string, error) {
 	headers := make(map[string]string)
 
@@ -221,8 +223,8 @@ func FormatTargetHeaders(headers map[string]string) string {
 
 // ParseTargetTimeout interprets the target form's timeout field as
 // a whole number of seconds. An empty field means "unset" and yields
-// 0, which the delivery path reads as "use the shared client's
+// 0, which omitempty drops from the stored config and which the
-// timeout".
+// delivery path reads as "use the shared client's timeout".
 //
 // Anything else that is not a whole number in range is an error, not
 // a silently substituted default: a target whose timeout was typed

internal/delivery/target_headers_test.go

@@ -1,21 +1,23 @@
 package delivery_test
 
 import (
+	"encoding/json"
 	"strconv"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"sneak.berlin/go/webhooker/internal/database"
 	"sneak.berlin/go/webhooker/internal/delivery"
 )
 
-// Literals these tests repeat, named so that each header name has one
+// Literals these tests repeat, named so that the header names and the
-// definition.
+// keep-forever archive config each have one definition.
 const (
 	headerAuthorization = "Authorization"
 	headerContentType   = "Content-Type"
-	headerUserAgent     = "User-Agent"
 	bearerValue         = "Bearer abc"
+	archiveConfigNever  = "{\"expiry\":\"never\"}"
 )
 
 func TestParseTargetHeaders_AcceptsPairs(t *testing.T) {
@@ -39,13 +41,23 @@ func TestParseTargetHeaders_AcceptsPairs(t *testing.T) {
 	)
 }
 
-// An input of blank lines is no headers, not an error.
+// A configuration with no headers must stay indistinguishable from
+// one written before the field existed, so omitempty drops the key.
 func TestParseTargetHeaders_EmptyInputYieldsNoHeaders(t *testing.T) {
 	t.Parallel()
 
 	got, err := delivery.ParseTargetHeaders("\n  \n")
 	require.NoError(t, err)
 	assert.Empty(t, got)
+
+	encoded, err := json.Marshal(delivery.HTTPTargetConfig{
+		URL:     "https://example.com/h",
+		Headers: got,
+	})
+	require.NoError(t, err)
+	assert.JSONEq(
+		t, `{"url":"https://example.com/h"}`, string(encoded),
+	)
 }
 
 func TestParseTargetHeaders_Rejects(t *testing.T) {
@@ -169,6 +181,87 @@ func TestFormatTargetTimeout(t *testing.T) {
 	assert.Empty(t, delivery.FormatTargetTimeout(-1))
 }
 
+func TestNewTargetConfigForm(t *testing.T) {
+	t.Parallel()
+
+	form, err := delivery.NewTargetConfigForm(&database.Target{
+		Type: database.TargetTypeHTTP,
+		Config: `{"url":"https://example.com/h",` +
+			`"headers":{"Authorization":"Bearer abc"},` +
+			`"timeout":9}`,
+	})
+	require.NoError(t, err)
+	assert.Equal(t, "https://example.com/h", form.URL)
+	assert.Equal(t, "Authorization: Bearer abc\n", form.Headers)
+	assert.Equal(t, "9", form.Timeout)
+
+	form, err = delivery.NewTargetConfigForm(&database.Target{
+		Type:   database.TargetTypeSlack,
+		Config: `{"webhookUrl":"https://hooks.example/s"}`,
+	})
+	require.NoError(t, err)
+	assert.Equal(t, "https://hooks.example/s", form.URL)
+
+	form, err = delivery.NewTargetConfigForm(&database.Target{
+		Type:   database.TargetTypeDatabase,
+		Config: `{"expiry":"720h","rotation":"daily"}`,
+	})
+	require.NoError(t, err)
+	assert.Equal(t, "720h", form.Expiry)
+	assert.Equal(t, rotationDaily, form.Rotation)
+
+	form, err = delivery.NewTargetConfigForm(&database.Target{
+		Type: database.TargetTypeLog,
+	})
+	require.NoError(t, err)
+	assert.Empty(t, form.URL)
+}
+
+// A keep-forever archive target yields an empty expiry, so the edit
+// form starts on never; saving it unchanged stores never, which means
+// the same as an empty expiry.
+func TestNewTargetConfigForm_DatabaseNeverIsBlank(t *testing.T) {
+	t.Parallel()
+
+	for _, cfg := range []string{"", `{}`, archiveConfigNever} {
+		form, err := delivery.NewTargetConfigForm(
+			&database.Target{
+				Type:   database.TargetTypeDatabase,
+				Config: cfg,
+			},
+		)
+		require.NoError(t, err, cfg)
+		assert.Empty(t, form.Expiry, cfg)
+	}
+}
+
+// An unreadable stored config is an error rather than a blank form
+// that looks like a target with no settings, so the caller can tell
+// the operator that saving replaces the stored value.
+func TestNewTargetConfigForm_UnreadableConfigErrors(t *testing.T) {
+	t.Parallel()
+
+	cases := []*database.Target{
+		{Type: database.TargetTypeHTTP, Config: "not json"},
+		{Type: database.TargetTypeHTTP, Config: `{}`},
+		{Type: database.TargetTypeSlack, Config: ""},
+		{
+			Type:   database.TargetTypeDatabase,
+			Config: `{"expiry":"soon"}`,
+		},
+		{
+			Type:   database.TargetTypeDatabase,
+			Config: weeklyConfig,
+		},
+		{Type: database.TargetType("nope")},
+	}
+
+	for _, target := range cases {
+		_, err := delivery.NewTargetConfigForm(target)
+		require.Error(t, err, target.Type)
+	}
+}
+
 // The ceiling exists so one misconfigured target cannot hold a
 // delivery worker indefinitely, and it is inclusive.
 func TestParseTargetTimeout_CeilingIsInclusive(t *testing.T) {

internal/delivery/target_http.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -16,6 +17,29 @@ import (
 	"sneak.berlin/go/webhooker/internal/database"
 )
 
+// Sentinel errors returned by the config parsers.
+var (
+	errEmptyTargetConfig = errors.New(
+		"empty target config",
+	)
+	errMissingTargetURL = errors.New(
+		"target URL is required",
+	)
+)
+
+// HTTPTargetConfig holds configuration for http target
+// types.
+type HTTPTargetConfig struct {
+	URL     string            `json:"url"`
+	Headers map[string]string `json:"headers,omitempty"`
+	Timeout int               `json:"timeout,omitempty"`
+
+	// ForwardQuery passes each event's query string on to the target,
+	// appended to URL. Off, the target URL is sent exactly as
+	// configured.
+	ForwardQuery bool `json:"forwardQuery,omitempty"`
+}
+
 // httpCore holds the retry, backoff, and circuit-breaker
 // machinery shared by the HTTP and Slack targets. Each of
 // those targets owns its own httpCore instance (and thus its
@@ -29,72 +53,34 @@ type httpCore struct {
 }
 
 // deliver runs one delivery attempt through the retry core.
-// A maxAttempts of 1 is a single attempt, recorded without
+// A maxRetries of 0 is fire-and-forget: a single attempt is
-// consulting a circuit breaker. A higher maxAttempts gates the
+// recorded and no circuit breaker is consulted. A positive
-// attempt on the circuit breaker and schedules a backed-off retry
+// maxRetries gates the attempt on the circuit breaker and
-// on failure, until maxAttempts attempts have been made.
+// schedules a backed-off retry on failure.
-//
-// ctx is the context attempt sends its request with. Stopping the
-// engine cancels it; see interruptedByStop.
 func (c *httpCore) deliver(
-	ctx context.Context,
 	webhookDB *gorm.DB,
 	d *database.Delivery,
 	task *Task,
 	sched Scheduler,
-	maxAttempts int,
+	maxRetries int,
 	attempt func() attemptResult,
 ) {
-	if maxAttempts == 1 {
+	if maxRetries == 0 {
-		c.fireAndForget(ctx, webhookDB, d, attempt())
+		c.fireAndForget(webhookDB, d, attempt())
 
 		return
 	}
 
 	c.withRetry(
-		ctx, webhookDB, d, task, sched, maxAttempts, attempt,
+		webhookDB, d, task, sched, maxRetries, attempt,
 	)
 }
 
-// interruptedByStop reports whether an attempt failed because the
-// engine is stopping, which cancels the context its request is made
-// with. Such an attempt is not recorded: no DeliveryResult, no circuit
-// breaker outcome, no status change, no count in the attempt metrics.
-// The delivery stays pending or retrying, and the recovery routine
-// sends it again on the next start.
-//
-// A target's own timeout leaves that context alone, so its attempt is
-// still recorded as the failure it is.
-func (c *httpCore) interruptedByStop(
-	ctx context.Context,
-	d *database.Delivery,
-	res attemptResult,
-) bool {
-	if res.success || ctx.Err() == nil {
-		return false
-	}
-
-	c.eng.log.Warn(
-		"delivery attempt interrupted by shutdown; not recorded, "+
-			"it is sent again on the next start",
-		"delivery_id", d.ID,
-		"event_id", d.EventID,
-		"target_id", d.TargetID,
-	)
-
-	return true
-}
-
 func (c *httpCore) fireAndForget(
-	ctx context.Context,
 	webhookDB *gorm.DB,
 	d *database.Delivery,
 	res attemptResult,
 ) {
-	if c.interruptedByStop(ctx, d, res) {
-		return
-	}
-
 	c.eng.observeAttempt(d.Target.Type, res.elapsed())
 
 	err := c.eng.recordResult(
@@ -124,12 +110,11 @@ func (c *httpCore) fireAndForget(
 }
 
 func (c *httpCore) withRetry(
-	ctx context.Context,
 	webhookDB *gorm.DB,
 	d *database.Delivery,
 	task *Task,
 	sched Scheduler,
-	maxAttempts int,
+	maxRetries int,
 	attempt func() attemptResult,
 ) {
 	cb := c.getCircuitBreaker(task.TargetID)
@@ -146,10 +131,6 @@ func (c *httpCore) withRetry(
 
 	res := attempt()
 
-	if c.interruptedByStop(ctx, d, res) {
-		return
-	}
-
 	c.eng.observeAttempt(d.Target.Type, res.elapsed())
 
 	err := c.eng.recordResult(
@@ -181,7 +162,7 @@ func (c *httpCore) withRetry(
 	cb.RecordFailure()
 
 	c.handleRetry(
-		webhookDB, d, task, sched, maxAttempts, attemptNum,
+		webhookDB, d, task, sched, maxRetries, attemptNum,
 	)
 }
 
@@ -242,10 +223,10 @@ func (c *httpCore) handleRetry(
 	d *database.Delivery,
 	task *Task,
 	sched Scheduler,
-	maxAttempts int,
+	maxRetries int,
 	attemptNum int,
 ) {
-	if attemptNum >= maxAttempts {
+	if attemptNum >= maxRetries {
 		c.eng.settleStatus(
 			webhookDB, d, d.Target.Type,
 			database.DeliveryStatusFailed,
@@ -310,8 +291,7 @@ func (c *httpCore) publishCircuitState(
 
 // remainingBackoff returns how long remains of the backoff
 // window for the last attempt of a recovered retrying
-// delivery: zero once it has passed, or when the last attempt
+// delivery. It implements rescheduler.
-// cannot be read. It implements rescheduler.
 func (c *httpCore) remainingBackoff(
 	webhookDB *gorm.DB,
 	deliveryID string,
@@ -334,6 +314,29 @@ func (c *httpCore) remainingBackoff(
 	return max(remaining, 0)
 }
 
+// backoffElapsed reports whether the backoff window for the
+// last attempt of a retrying delivery has passed. It
+// implements rescheduler.
+func (c *httpCore) backoffElapsed(
+	webhookDB *gorm.DB,
+	deliveryID string,
+	attemptNum int,
+) bool {
+	var lastResult database.DeliveryResult
+
+	err := webhookDB.
+		Where("delivery_id = ?", deliveryID).
+		Order("created_at DESC").
+		First(&lastResult).Error
+	if err != nil {
+		return true
+	}
+
+	backoff := Backoff(attemptNum)
+
+	return time.Since(lastResult.CreatedAt) >= backoff
+}
+
 // Backoff is how long an http or slack target with retries waits after
 // a delivery's failed attempt attemptNum before trying it again.
 func Backoff(attemptNum int) time.Duration {
@@ -361,13 +364,39 @@ func (t *httpTarget) Deliver(
 	task *Task,
 	sched Scheduler,
 ) {
+	cfg, err := parseHTTPConfig(d.Target.Config)
+	if err != nil {
+		t.eng.log.Error(
+			"invalid HTTP target config",
+			"target_id", d.TargetID,
+			"error", err,
+		)
+
+		recErr := t.eng.recordResult(
+			webhookDB, d, task.AttemptNum,
+			false, 0, "", err.Error(), 0,
+		)
+		if recErr != nil {
+			t.eng.bookkeepingFailed(d, recErr)
+
+			return
+		}
+
+		t.eng.settleStatus(
+			webhookDB, d, d.Target.Type,
+			database.DeliveryStatusFailed,
+		)
+
+		return
+	}
+
 	attempt := func() attemptResult {
-		return t.attempt(ctx, &d.Target, &d.Event)
+		return t.attempt(ctx, cfg, &d.Event)
 	}
 
 	t.deliver(
-		ctx, webhookDB, d, task, sched,
+		webhookDB, d, task, sched,
-		d.Target.MaxAttempts, attempt,
+		d.Target.MaxRetries, attempt,
 	)
 }
 
@@ -377,11 +406,11 @@ func (t *httpTarget) Deliver(
 // string; only a transport-level error does.
 func (t *httpTarget) attempt(
 	ctx context.Context,
-	target *database.Target,
+	cfg *HTTPTargetConfig,
 	event *database.Event,
 ) attemptResult {
 	statusCode, respBody, duration, reqErr :=
-		t.doHTTPRequest(ctx, target, event)
+		t.doHTTPRequest(ctx, cfg, event)
 
 	success := reqErr == nil &&
 		statusCode >= httpSuccessMin &&
@@ -403,7 +432,7 @@ func (t *httpTarget) attempt(
 
 func (t *httpTarget) doHTTPRequest(
 	ctx context.Context,
-	target *database.Target,
+	cfg *HTTPTargetConfig,
 	event *database.Event,
 ) (int, string, int64, error) {
 	start := time.Now()
@@ -411,7 +440,7 @@ func (t *httpTarget) doHTTPRequest(
 	req, reqErr := http.NewRequestWithContext(
 		ctx,
 		http.MethodPost,
-		target.URL,
+		cfg.URL,
 		bytes.NewReader([]byte(event.Body)),
 	)
 	if reqErr != nil {
@@ -421,15 +450,15 @@ func (t *httpTarget) doHTTPRequest(
 		)
 	}
 
-	if target.ForwardQuery {
+	if cfg.ForwardQuery {
 		appendQuery(req.URL, event.RawQuery)
 	}
 
 	originScoped := applyRequestHeaders(
-		req, event, target.Headers, t.eng.userAgent(),
+		req, event, cfg, t.eng.userAgent(),
 	)
 
-	client := t.clientForRequest(target.TimeoutSeconds, originScoped)
+	client := t.clientForRequest(cfg, originScoped)
 
 	resp, doErr := executeHTTPRequest(client, req)
 
@@ -469,17 +498,17 @@ func appendQuery(u *url.URL, rawQuery string) {
 }
 
 // clientForRequest returns the client for one delivery attempt.
-// timeoutSeconds is the target's TimeoutSeconds, and originScoped is
+// originScoped is the header set applyRequestHeaders built for that
-// the header set applyRequestHeaders built for that attempt; a
+// attempt; a request with neither a per-target timeout nor an
-// request with neither a per-target timeout nor an origin-scoped
+// origin-scoped header gets the shared client, because there is
-// header gets the shared client, because there is then nothing for
+// then nothing for the redirect policy to strip and net/http's
-// the redirect policy to strip and net/http's default policy already
+// default policy already withholds Authorization and Cookie across
-// withholds Authorization and Cookie across hosts.
+// hosts.
 func (t *httpTarget) clientForRequest(
-	timeoutSeconds int,
+	cfg *HTTPTargetConfig,
 	originScoped []string,
 ) *http.Client {
-	if timeoutSeconds <= 0 && len(originScoped) == 0 {
+	if cfg.Timeout <= 0 && len(originScoped) == 0 {
 		return t.client
 	}
 
@@ -492,9 +521,9 @@ func (t *httpTarget) clientForRequest(
 		Transport: t.client.Transport,
 	}
 
-	if timeoutSeconds > 0 {
+	if cfg.Timeout > 0 {
 		client.Timeout = time.Duration(
-			timeoutSeconds,
+			cfg.Timeout,
 		) * time.Second
 	}
 
@@ -505,6 +534,31 @@ func (t *httpTarget) clientForRequest(
 	return client
 }
 
+func parseHTTPConfig(
+	configJSON string,
+) (*HTTPTargetConfig, error) {
+	if configJSON == "" {
+		return nil, errEmptyTargetConfig
+	}
+
+	var cfg HTTPTargetConfig
+
+	err := json.Unmarshal(
+		[]byte(configJSON), &cfg,
+	)
+	if err != nil {
+		return nil, fmt.Errorf(
+			"parsing config JSON: %w", err,
+		)
+	}
+
+	if cfg.URL == "" {
+		return nil, errMissingTargetURL
+	}
+
+	return &cfg, nil
+}
+
 // isForwardableHeader returns true if the header should
 // be forwarded to targets.
 func isForwardableHeader(name string) bool {
@@ -536,12 +590,11 @@ func isForwardableHeader(name string) bool {
 // wins, otherwise the event's ContentType, otherwise none. The inbound
 // Content-Type in the event's headers is never forwarded.
 //
-// configured is the target's Headers. userAgent is set last, over
+// userAgent is set last, over any configured or inbound User-Agent.
-// any configured or inbound User-Agent.
 func applyRequestHeaders(
 	req *http.Request,
 	event *database.Event,
-	configured map[string]string,
+	cfg *HTTPTargetConfig,
 	userAgent string,
 ) []string {
 	if event.ContentType != "" {
@@ -552,7 +605,7 @@ func applyRequestHeaders(
 
 	originScoped := forwardEventHeaders(req, event)
 
-	for k, v := range configured {
+	for k, v := range cfg.Headers {
 		req.Header.Set(k, v)
 		originScoped[http.CanonicalHeaderKey(k)] = struct{}{}
 	}
@@ -617,7 +670,7 @@ func forwardEventHeaders(
 }
 
 // executeHTTPRequest sends an HTTP request using the provided
-// client. URLs are validated by the target forms and the
+// client. URLs are validated by the config parsers and the
 // SSRF-safe transport before reaching here.
 //
 // Transport failures are masked here, at the single point

internal/delivery/target_http_query_test.go

@@ -2,6 +2,7 @@ package delivery_test
 
 import (
 	"context"
+	"encoding/json"
 	"net/http"
 	"net/http/httptest"
 	"testing"
@@ -17,13 +18,25 @@ import (
 // with.
 const eventQuery = "a=1&b=2"
 
-// deliverWithQuery sends one event that arrived with eventQuery to an
+// httpTargetConfig is the stored configuration of an HTTP target at
-// HTTP target at targetURL, with its ForwardQuery setting as given,
+// targetURL.
-// through the path a received event's delivery takes, and returns the
+func httpTargetConfig(
-// attempt it recorded.
-func deliverWithQuery(
 	t *testing.T, targetURL string, forwardQuery bool,
-) database.DeliveryResult {
+) string {
+	t.Helper()
+
+	cfg, err := json.Marshal(delivery.HTTPTargetConfig{
+		URL: targetURL, ForwardQuery: forwardQuery,
+	})
+	require.NoError(t, err)
+
+	return string(cfg)
+}
+
+// deliverWithQuery sends one event that arrived with eventQuery to an
+// HTTP target configured with cfg, through the path a received event's
+// delivery takes, and returns the attempt it recorded.
+func deliverWithQuery(t *testing.T, cfg string) database.DeliveryResult {
 	t.Helper()
 
 	s := newISetup(t)
@@ -34,10 +47,8 @@ func deliverWithQuery(
 		database.DeliveryStatusPending,
 	)
 	task := iTask(
-		d, event, s.WebhookID, d.TargetID, "query", targetURL, 1, 1,
+		d, event, s.WebhookID, d.TargetID, "query", cfg, 0, 1, &event.Body,
-		&event.Body,
 	)
-	task.ForwardQuery = forwardQuery
 	task.RawQuery = eventQuery
 
 	s.Engine.ExportProcessNewTask(context.TODO(), &task)
@@ -100,9 +111,9 @@ func TestDeliverHTTP_ForwardQuery(t *testing.T) {
 			))
 			t.Cleanup(ts.Close)
 
-			result := deliverWithQuery(
+			result := deliverWithQuery(t, httpTargetConfig(
 				t, ts.URL+tc.path, tc.forwardQuery,
-			)
+			))
 
 			assert.True(t, result.Success)
 			require.Len(t, received, 1)
@@ -133,13 +144,11 @@ func TestDeliverHTTP_ForwardedQueryKeepsTheTargetURLMasked(t *testing.T) {
 	t.Cleanup(ts.Close)
 
 	target := &database.Target{
-		Type:         database.TargetTypeHTTP,
+		Type:   database.TargetTypeHTTP,
-		URL:          ts.URL + "/in?token=" + secret,
+		Config: httpTargetConfig(t, ts.URL+"/in?token="+secret, true),
-		ForwardQuery: true,
-		MaxAttempts:  1,
 	}
 
-	deliverWithQuery(t, target.URL, target.ForwardQuery)
+	deliverWithQuery(t, target.Config)
 	require.Len(t, received, 1)
 
 	sent := <-received
@@ -154,9 +163,9 @@ func TestDeliverHTTP_ForwardedQueryKeepsTheTargetURLMasked(t *testing.T) {
 	}
 
 	// Nothing listens on port 1.
-	failed := deliverWithQuery(
+	failed := deliverWithQuery(t, httpTargetConfig(
 		t, "http://127.0.0.1:1/in?token="+secret, true,
-	)
+	))
 	require.NotEmpty(t, failed.Error)
 	assert.NotContains(t, failed.Error, secret)
 	assert.NotContains(t, failed.Error, eventQuery)

internal/delivery/target_redact.go

@@ -13,12 +13,12 @@ import (
 const RedactionMarker = "(redacted)"
 
 // Redactor removes one target's own credential material from
-// a delivery response body, whose text the target's remote
+// text that target's remote peer chose: a delivery response
-// peer chose, and from a stored delivery error as a second
+// body, or a delivery error stored before the delivery path
-// line behind the delivery path's own URL masking.
+// learned to mask the URLs it embeds.
 //
 // It removes byte-identical echoes of strings taken from the
-// target's URL and headers, and nothing else. Anything
+// target's stored configuration, and nothing else. Anything
 // the remote re-encodes survives: JSON "\/" escaping (what
 // PHP's json_encode emits by default), percent-encoding, HTML
 // entities, and an echo of only part of a path. It cannot
@@ -115,7 +115,7 @@ func (r Redactor) secretPrefixSuffix(s string) int {
 }
 
 // targetSecrets returns the credential-bearing strings a
-// target's settings carry.
+// target's configuration carries.
 //
 // The destination URL contributes. Its path, query and
 // userinfo are the credential for both target types that have
@@ -129,15 +129,36 @@ func (r Redactor) secretPrefixSuffix(s string) int {
 // picks out. That is the same class-based rule applied to
 // URLs: an echoed Accept or User-Agent still renders, an
 // echoed Authorization does not.
-//
-// A setting a type does not use is empty and contributes
-// nothing, so a database or log target has nothing to redact.
 func targetSecrets(t *database.Target) []string {
 	if t == nil {
 		return nil
 	}
 
-	return append(urlSecrets(t.URL), headerSecrets(t.Headers)...)
+	switch t.Type {
+	case database.TargetTypeSlack:
+		cfg, err := parseSlackConfig(t.Config)
+		if err != nil {
+			return nil
+		}
+
+		return urlSecrets(cfg.WebhookURL)
+	case database.TargetTypeHTTP:
+		cfg, err := parseHTTPConfig(t.Config)
+		if err != nil {
+			return nil
+		}
+
+		return append(
+			urlSecrets(cfg.URL),
+			headerSecrets(cfg.Headers)...,
+		)
+	case database.TargetTypeDatabase, database.TargetTypeLog:
+		// Neither has a destination URL, so neither has
+		// anything to redact.
+		return nil
+	default:
+		return nil
+	}
 }
 
 // urlSecrets returns the substrings of a destination URL that

internal/delivery/target_redact_test.go

@@ -22,9 +22,8 @@ func TestRedactor_RemovesSlackWebhookURL(t *testing.T) {
 	t.Parallel()
 
 	r := delivery.NewRedactor(&database.Target{
-		Type:        database.TargetTypeSlack,
+		Type:   database.TargetTypeSlack,
-		URL:         redactWebhookURL,
+		Config: `{"webhookUrl":"` + redactWebhookURL + `"}`,
-		MaxAttempts: 1,
 	})
 
 	got := r.Redact("no_service for " + redactWebhookURL)
@@ -53,9 +52,8 @@ func TestRedactor_RemovesSecretSeveredByACut(t *testing.T) {
 	t.Parallel()
 
 	r := delivery.NewRedactor(&database.Target{
-		Type:        database.TargetTypeSlack,
+		Type:   database.TargetTypeSlack,
-		URL:         redactWebhookURL,
+		Config: `{"webhookUrl":"` + redactWebhookURL + `"}`,
-		MaxAttempts: 1,
 	})
 
 	// Every cut position inside the credential, not just a
@@ -86,20 +84,18 @@ func TestRedactor_RedactsCredentialShapedHeaderValues(
 
 	r := delivery.NewRedactor(&database.Target{
 		Type: database.TargetTypeHTTP,
-		URL:  "https://example.com/in",
+		Config: `{"url":"https://example.com/in",` +
-		Headers: map[string]string{
+			`"headers":{` +
-			headerAuthorization: "Bearer AAAAAAAAAAAA",
+			`"Authorization":"Bearer AAAAAAAAAAAA",` +
-			"Cookie":            "session=BBBBBBBBBBBB",
+			`"Cookie":"session=BBBBBBBBBBBB",` +
-			probeHeaderName:     "CCCCCCCCCCCC",
+			`"X-Api-Key":"CCCCCCCCCCCC",` +
-			"X-Hub-Signature":   "sha256=DDDDDDDDDDDD",
+			`"X-Hub-Signature":"sha256=DDDDDDDDDDDD",` +
-			"X-Sig":             "EEEEEEEEEEEE",
+			`"X-Sig":"EEEEEEEEEEEE",` +
-			"X-Pass":            "FFFFFFFFFFFF",
+			`"X-Pass":"FFFFFFFFFFFF",` +
-			"X-HMAC":            "GGGGGGGGGGGG",
+			`"X-HMAC":"GGGGGGGGGGGG",` +
-			"X-Credential":      "HHHHHHHHHHHH",
+			`"X-Credential":"HHHHHHHHHHHH",` +
-			"Accept":            "application/json",
+			`"Accept":"application/json",` +
-			headerUserAgent:     "webhooker/1.0",
+			`"User-Agent":"webhooker/1.0"}}`,
-		},
-		MaxAttempts: 1,
 	})
 
 	for _, secret := range []string{
@@ -137,10 +133,9 @@ func TestRedactor_IgnoresVeryShortHeaderValues(t *testing.T) {
 	t.Parallel()
 
 	r := delivery.NewRedactor(&database.Target{
-		Type:        database.TargetTypeHTTP,
+		Type: database.TargetTypeHTTP,
-		URL:         "https://example.com/in",
+		Config: `{"url":"https://example.com/in",` +
-		Headers:     map[string]string{probeHeaderName: "ab"},
+			`"headers":{"X-Api-Key":"ab"}}`,
-		MaxAttempts: 1,
 	})
 
 	const response = "rabbit"
@@ -155,9 +150,8 @@ func TestRedactor_RemovesBarePath(t *testing.T) {
 	t.Parallel()
 
 	r := delivery.NewRedactor(&database.Target{
-		Type:        database.TargetTypeSlack,
+		Type:   database.TargetTypeSlack,
-		URL:         redactWebhookURL,
+		Config: `{"webhookUrl":"` + redactWebhookURL + `"}`,
-		MaxAttempts: 1,
 	})
 
 	got := r.Redact("POST " + redactSecretPath + " 404")
@@ -189,9 +183,8 @@ func TestRedactor_RemovesHTTPURLQueryAndUserinfo(t *testing.T) {
 	raw := dest.String()
 
 	r := delivery.NewRedactor(&database.Target{
-		Type:        database.TargetTypeHTTP,
+		Type:   database.TargetTypeHTTP,
-		URL:         raw,
+		Config: `{"url":"` + raw + `"}`,
-		MaxAttempts: 1,
 	})
 
 	for _, echoed := range []string{
@@ -239,9 +232,8 @@ func TestRedactor_RemovesEchoedQueryOfURLWithoutPath(t *testing.T) {
 		"https://example.com?token=" + secret,
 	} {
 		r := delivery.NewRedactor(&database.Target{
-			Type:        database.TargetTypeHTTP,
+			Type:   database.TargetTypeHTTP,
-			URL:         dest,
+			Config: `{"url":"` + dest + `"}`,
-			MaxAttempts: 1,
 		})
 
 		for echoed, want := range echoes {
@@ -261,9 +253,8 @@ func TestRedactor_LeavesUnrelatedTextAlone(t *testing.T) {
 	const response = "ok=false error=channel_not_found"
 
 	r := delivery.NewRedactor(&database.Target{
-		Type:        database.TargetTypeSlack,
+		Type:   database.TargetTypeSlack,
-		URL:         redactWebhookURL,
+		Config: `{"webhookUrl":"` + redactWebhookURL + `"}`,
-		MaxAttempts: 1,
 	})
 
 	assert.Equal(t, response, r.Redact(response))
@@ -288,9 +279,8 @@ func TestRedactor_EmptyUserinfoDoesNotShredTheBody(t *testing.T) {
 	require.Empty(t, parsed.User.String())
 
 	r := delivery.NewRedactor(&database.Target{
-		Type:        database.TargetTypeHTTP,
+		Type:   database.TargetTypeHTTP,
-		URL:         dest,
+		Config: `{"url":"` + dest + `"}`,
-		MaxAttempts: 1,
 	})
 
 	const body = "ok=false error=channel_not_found"
@@ -307,10 +297,11 @@ func TestRedactor_EmptyUserinfoDoesNotShredTheBody(t *testing.T) {
 	)
 }
 
-// TestRedactor_ZeroValueAndURLlessTargets pins that a caller
+// TestRedactor_ZeroValueAndConfiglessTargets pins that a
-// with no target, or a target with no destination URL, gets a
+// caller with no target, an unparseable config, or a target
-// redactor that changes nothing rather than one that panics.
+// type with no destination URL gets a redactor that changes
-func TestRedactor_ZeroValueAndURLlessTargets(t *testing.T) {
+// nothing rather than one that panics.
+func TestRedactor_ZeroValueAndConfiglessTargets(t *testing.T) {
 	t.Parallel()
 
 	const text = "some response body"
@@ -323,8 +314,8 @@ func TestRedactor_ZeroValueAndURLlessTargets(t *testing.T) {
 	for _, tgt := range []database.Target{
 		{Type: database.TargetTypeLog},
 		{Type: database.TargetTypeDatabase},
-		{Type: database.TargetTypeSlack, MaxAttempts: 1},
+		{Type: database.TargetTypeSlack, Config: "not json"},
-		{Type: database.TargetTypeHTTP, MaxAttempts: 1},
+		{Type: database.TargetTypeHTTP, Config: ""},
 	} {
 		assert.Equal(
 			t, text,

internal/delivery/target_slack.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -14,11 +15,24 @@ import (
 	"sneak.berlin/go/webhooker/internal/database"
 )
 
+// errMissingWebhookURL is returned when a Slack target config
+// omits its webhook URL.
+var errMissingWebhookURL = errors.New(
+	"webhook_url is required",
+)
+
+// SlackTargetConfig holds configuration for slack target
+// types.
+type SlackTargetConfig struct {
+	WebhookURL string `json:"webhookUrl"`
+}
+
 // slackTarget delivers events to Slack incoming webhooks. It
 // formats the event into a Slack message and posts it as
 // JSON. It shares the retry core with the HTTP target: a
-// MaxAttempts of 1 is a single attempt, while a higher one
+// MaxRetries of 0 stays single-attempt fire-and-forget
-// adds backoff and circuit breaking.
+// (preserving existing Slack targets), while a positive
+// MaxRetries adds backoff and circuit breaking.
 type slackTarget struct {
 	*httpCore
 
@@ -33,6 +47,19 @@ func (t *slackTarget) Deliver(
 	task *Task,
 	sched Scheduler,
 ) {
+	cfg, err := parseSlackConfig(d.Target.Config)
+	if err != nil {
+		t.eng.log.Error(
+			"invalid Slack target config",
+			"target_id", d.TargetID,
+			"error", err,
+		)
+
+		t.failConfig(webhookDB, d, err)
+
+		return
+	}
+
 	msg := FormatSlackMessage(&d.Event)
 
 	payload, err := json.Marshal(
@@ -45,41 +72,52 @@ func (t *slackTarget) Deliver(
 			"error", err,
 		)
 
-		recErr := t.eng.recordResult(
+		t.failConfig(webhookDB, d, err)
-			webhookDB, d, 1,
-			false, 0, "", err.Error(), 0,
-		)
-		if recErr != nil {
-			t.eng.bookkeepingFailed(d, recErr)
-
-			return
-		}
-
-		t.eng.settleStatus(
-			webhookDB, d, d.Target.Type,
-			database.DeliveryStatusFailed,
-		)
 
 		return
 	}
 
 	attempt := func() attemptResult {
-		return t.attempt(ctx, d.Target.URL, payload)
+		return t.attempt(ctx, cfg, payload)
 	}
 
 	t.deliver(
-		ctx, webhookDB, d, task, sched,
+		webhookDB, d, task, sched,
-		d.Target.MaxAttempts, attempt,
+		d.Target.MaxRetries, attempt,
 	)
 }
 
-// attempt performs a single Slack POST to targetURL and derives
+// failConfig records a first-attempt failure for a delivery
-// its outcome, preserving the engine's original semantics: a
+// that could not be prepared (bad config or unmarshalable
+// payload) and marks it failed.
+func (t *slackTarget) failConfig(
+	webhookDB *gorm.DB,
+	d *database.Delivery,
+	err error,
+) {
+	recErr := t.eng.recordResult(
+		webhookDB, d, 1,
+		false, 0, "", err.Error(), 0,
+	)
+	if recErr != nil {
+		t.eng.bookkeepingFailed(d, recErr)
+
+		return
+	}
+
+	t.eng.settleStatus(
+		webhookDB, d, d.Target.Type,
+		database.DeliveryStatusFailed,
+	)
+}
+
+// attempt performs a single Slack POST and derives its
+// outcome, preserving the engine's original semantics: a
 // non-2xx response records an "HTTP <code>" error string and
 // a transport error records a "sending request" error.
 func (t *slackTarget) attempt(
 	ctx context.Context,
-	targetURL string,
+	cfg *SlackTargetConfig,
 	payload []byte,
 ) attemptResult {
 	start := time.Now()
@@ -87,7 +125,7 @@ func (t *slackTarget) attempt(
 	req, err := http.NewRequestWithContext(
 		ctx,
 		http.MethodPost,
-		targetURL,
+		cfg.WebhookURL,
 		bytes.NewReader(payload),
 	)
 	if err != nil {
@@ -149,6 +187,31 @@ func (t *slackTarget) readSlackResponse(
 	}
 }
 
+func parseSlackConfig(
+	configJSON string,
+) (*SlackTargetConfig, error) {
+	if configJSON == "" {
+		return nil, errEmptyTargetConfig
+	}
+
+	var cfg SlackTargetConfig
+
+	err := json.Unmarshal(
+		[]byte(configJSON), &cfg,
+	)
+	if err != nil {
+		return nil, fmt.Errorf(
+			"parsing config JSON: %w", err,
+		)
+	}
+
+	if cfg.WebhookURL == "" {
+		return nil, errMissingWebhookURL
+	}
+
+	return &cfg, nil
+}
+
 // FormatSlackMessage builds a Slack-compatible message
 // string from a webhook event.
 func FormatSlackMessage(

internal/delivery/terminal_state_test.go

@@ -45,7 +45,7 @@ func tSeedDeletedTarget(
 
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, name,
-		database.TargetTypeHTTP, url, 5,
+		database.TargetTypeHTTP, iHTTPConfig(url), 5,
 	)
 
 	event := iSeedEvent(
@@ -122,9 +122,9 @@ func TestProcessDelivery_UnknownTargetType_RecordsWhy(
 	)
 
 	target := database.Target{
-		Name: "mystery",
+		Name:   "mystery",
-		Type: tUnknownType,
+		Type:   tUnknownType,
-		URL:  "http://example.com/hook",
+		Config: iHTTPConfig("http://example.com/hook"),
 	}
 	target.ID = targetID
 
@@ -140,7 +140,7 @@ func TestProcessDelivery_UnknownTargetType_RecordsWhy(
 	body := event.Body
 	task := iTask(
 		seeded, event, s.WebhookID, targetID, "mystery",
-		target.URL, 0, 1, &body,
+		target.Config, 0, 1, &body,
 	)
 	task.TargetType = tUnknownType
 
@@ -178,7 +178,7 @@ func TestRecoverSingleRetry_TargetDeleted(t *testing.T) {
 	)
 
 	s.Engine.ExportRecoverWebhookDeliveries(
-		context.Background(), s.WebhookID, atStart,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertStatus(
@@ -201,7 +201,7 @@ func TestRecoverSingleRetry_TargetDeleted(t *testing.T) {
 	)
 }
 
-func TestRecoverSingleRetry_OnTick_TargetDeleted(t *testing.T) {
+func TestSweepSingleRetry_TargetDeleted(t *testing.T) {
 	t.Parallel()
 
 	s := newISetup(t)
@@ -218,11 +218,11 @@ func TestRecoverSingleRetry_OnTick_TargetDeleted(t *testing.T) {
 	// Twice, because the bug was an error the sweep repeated every
 	// minute for the life of the database: the second sweep must
 	// find nothing left to do.
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertStatus(
@@ -239,11 +239,10 @@ func TestRecoverSingleRetry_OnTick_TargetDeleted(t *testing.T) {
 	assert.Zero(t, s.Engine.ExportInflightHeld())
 }
 
-// TestRecoverSingleRetry_OnTick_TargetNeverExisted covers the other
+// TestSweepSingleRetry_TargetNeverExisted covers the other half of the
-// half of the soft-delete distinction: an id with no row at all,
+// soft-delete distinction: an id with no row at all, deleted or
-// deleted or otherwise, must not be reported as something the operator
+// otherwise, must not be reported as something the operator deleted.
-// deleted.
+func TestSweepSingleRetry_TargetNeverExisted(t *testing.T) {
-func TestRecoverSingleRetry_OnTick_TargetNeverExisted(t *testing.T) {
 	t.Parallel()
 
 	s := newISetup(t)
@@ -265,8 +264,8 @@ func TestRecoverSingleRetry_OnTick_TargetNeverExisted(t *testing.T) {
 
 	iSeedFailedResult(t, s.WebhookDB, d.ID)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertStatus(
@@ -304,8 +303,8 @@ func TestFailMissingTarget_WritesNoTargetRow(
 		database.DeliveryStatusRetrying,
 	)
 
-	s.Engine.ExportRecoverWebhookDeliveries(
+	s.Engine.ExportSweepWebhookRetries(
-		context.Background(), s.WebhookID, onTick,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertStatus(
@@ -346,10 +345,11 @@ func tRetryChainSetup(
 	iCreateWebhook(t, s.MainDB, s.WebhookID, name)
 
 	targetID := uuid.New().String()
+	cfg := iHTTPConfig(ts.URL)
 
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, name,
-		database.TargetTypeHTTP, ts.URL, 5,
+		database.TargetTypeHTTP, cfg, 5,
 	)
 
 	event := iSeedEvent(
@@ -366,7 +366,7 @@ func tRetryChainSetup(
 	body := event.Body
 
 	return iTask(
-		d, event, s.WebhookID, targetID, name, ts.URL, 5, 2, &body,
+		d, event, s.WebhookID, targetID, name, cfg, 5, 2, &body,
 	), targetID
 }
 
@@ -527,7 +527,7 @@ func TestRecoverSingleRetry_TargetUnreadable_LeavesDeliveryAlone(
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "healthy",
 		database.TargetTypeHTTP,
-		"http://example.com/hook", 5,
+		iHTTPConfig("http://example.com/hook"), 5,
 	)
 
 	event := iSeedEvent(
@@ -546,7 +546,7 @@ func TestRecoverSingleRetry_TargetUnreadable_LeavesDeliveryAlone(
 	require.NoError(t, sqlDB.Close())
 
 	s.Engine.ExportRecoverRetryingDeliveries(
-		context.Background(), s.WebhookDB, s.WebhookID,
+		s.WebhookDB, s.WebhookID,
 	)
 
 	iAssertStatus(
@@ -564,7 +564,7 @@ func TestRecoverSingleRetry_TargetUnreadable_LeavesDeliveryAlone(
 
 // --- 4. A pending delivery whose target is gone ---
 
-func TestRecoverPendingDeliveries_TargetDeleted(t *testing.T) {
+func TestRecoverPending_TargetDeleted(t *testing.T) {
 	t.Parallel()
 
 	s := newISetup(t)
@@ -577,7 +577,7 @@ func TestRecoverPendingDeliveries_TargetDeleted(t *testing.T) {
 	)
 
 	s.Engine.ExportRecoverWebhookDeliveries(
-		context.Background(), s.WebhookID, atStart,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertStatus(
@@ -600,10 +600,10 @@ func TestRecoverPendingDeliveries_TargetDeleted(t *testing.T) {
 	)
 }
 
-// TestRecoverPendingDeliveries_TargetDeleted_LeavesAnOwnedDeliveryAlone:
+// TestRecoverPending_TargetDeleted_LeavesAnOwnedDeliveryAlone: the
-// the terminal write takes ownership like every other recovery write, so
+// terminal write takes ownership like every other recovery write, so a
-// a delivery the engine still holds is not failed underneath its worker.
+// delivery the engine still holds is not failed underneath its worker.
-func TestRecoverPendingDeliveries_TargetDeleted_LeavesAnOwnedDeliveryAlone(
+func TestRecoverPending_TargetDeleted_LeavesAnOwnedDeliveryAlone(
 	t *testing.T,
 ) {
 	t.Parallel()
@@ -620,7 +620,7 @@ func TestRecoverPendingDeliveries_TargetDeleted_LeavesAnOwnedDeliveryAlone(
 	require.True(t, s.Engine.ExportRetainDelivery(deliveryID))
 
 	s.Engine.ExportRecoverWebhookDeliveries(
-		context.Background(), s.WebhookID, atStart,
+		context.Background(), s.WebhookID,
 	)
 
 	iAssertStatus(
@@ -675,18 +675,18 @@ func TestFailMissingTarget_LeavesASettledDeliveryAlone(
 	assert.Zero(t, s.Engine.ExportInflightHeld())
 }
 
-// TestRecoverPendingDeliveries_OnTick_TargetDeleted sweeps twice over a
+// TestSweepPending_TargetDeleted sweeps twice over a batch that also
-// batch that also holds a healthy stranded delivery. The one whose
+// holds a healthy stranded delivery. The one whose target is gone is
-// target is gone is failed once and then left alone; the healthy one is
+// failed once and then left alone; the healthy one is queued by the
-// queued by the first sweep and not again by the second.
+// first sweep and not again by the second.
-func TestRecoverPendingDeliveries_OnTick_TargetDeleted(t *testing.T) {
+func TestSweepPending_TargetDeleted(t *testing.T) {
 	t.Parallel()
 
 	liveTargetID := uuid.New().String()
 	s := fSweepSetup(t, liveTargetID, "still-there")
 
 	deliveryID := tSeedDeletedTarget(
-		t, s, "gone-while-pending-on-tick", "http://example.com/hook",
+		t, s, "gone-on-pending-sweep", "http://example.com/hook",
 		database.DeliveryStatusPending,
 	)
 	rAgePending(t, s.WebhookDB, deliveryID)
@@ -703,7 +703,7 @@ func TestRecoverPendingDeliveries_OnTick_TargetDeleted(t *testing.T) {
 
 	ctx := context.Background()
 
-	s.Engine.ExportRecoverWebhookDeliveries(ctx, s.WebhookID, onTick)
+	s.Engine.ExportSweepWebhookRetries(ctx, s.WebhookID)
 
 	tasks := fDrain(s.Engine)
 	require.Len(t, tasks, 1,
@@ -711,7 +711,7 @@ func TestRecoverPendingDeliveries_OnTick_TargetDeleted(t *testing.T) {
 	)
 	assert.Equal(t, healthy.ID, tasks[0].DeliveryID)
 
-	s.Engine.ExportRecoverWebhookDeliveries(ctx, s.WebhookID, onTick)
+	s.Engine.ExportSweepWebhookRetries(ctx, s.WebhookID)
 
 	assert.Empty(t, fDrain(s.Engine),
 		"the second sweep queued a delivery again",
@@ -724,7 +724,7 @@ func TestRecoverPendingDeliveries_OnTick_TargetDeleted(t *testing.T) {
 
 	last := tLastResult(t, s, deliveryID, 2)
 
-	assert.Contains(t, last.Error, "gone-while-pending-on-tick")
+	assert.Contains(t, last.Error, "gone-on-pending-sweep")
 	assert.Contains(t, last.Error, "was deleted")
 }
 
@@ -743,7 +743,7 @@ func TestSendRecoveredDeliveries_TargetMissingFromMap(
 
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "found-on-lookup",
-		database.TargetTypeLog, "", 1,
+		database.TargetTypeLog, "", 0,
 	)
 
 	event := iSeedEvent(
@@ -775,11 +775,11 @@ func TestSendRecoveredDeliveries_TargetMissingFromMap(
 	)
 }
 
-// TestRecoverPendingDeliveries_TargetUnreadable_LeavesDeliveryAlone: a
+// TestRecoverPending_TargetUnreadable_LeavesDeliveryAlone: a failed
-// failed read of the main database is not a deleted target. At start the
+// read of the main database is not a deleted target. Restart recovery
-// recovery routine holds every pending delivery of the webhook in one
+// holds every pending delivery of the webhook in one batch, so failing
-// batch, so failing on this would fail all of them.
+// on this would fail all of them.
-func TestRecoverPendingDeliveries_TargetUnreadable_LeavesDeliveryAlone(
+func TestRecoverPending_TargetUnreadable_LeavesDeliveryAlone(
 	t *testing.T,
 ) {
 	t.Parallel()
@@ -790,7 +790,7 @@ func TestRecoverPendingDeliveries_TargetUnreadable_LeavesDeliveryAlone(
 
 	iCreateTarget(
 		t, s.MainDB, targetID, s.WebhookID, "healthy",
-		database.TargetTypeLog, "", 1,
+		database.TargetTypeLog, "", 0,
 	)
 
 	event := iSeedEvent(
@@ -807,7 +807,7 @@ func TestRecoverPendingDeliveries_TargetUnreadable_LeavesDeliveryAlone(
 	require.NoError(t, sqlDB.Close())
 
 	s.Engine.ExportRecoverPendingDeliveries(
-		context.Background(), s.WebhookDB, s.WebhookID, atStart,
+		context.Background(), s.WebhookDB, s.WebhookID,
 	)
 
 	iAssertStatus(

internal/delivery/url_mask_test.go

@@ -2,6 +2,7 @@ package delivery_test
 
 import (
 	"context"
+	"encoding/json"
 	"net/http"
 	"net/http/httptest"
 	"testing"
@@ -70,6 +71,13 @@ func deliverSlackTo(
 	e := testEngine(t, 1)
 	targetID := uuid.New().String()
 
+	slackCfg, err := json.Marshal(
+		delivery.SlackTargetConfig{
+			WebhookURL: webhookURL,
+		},
+	)
+	require.NoError(t, err)
+
 	event := seedEvent(t, db, `{"test":true}`)
 
 	dlv := seedDelivery(
@@ -79,7 +87,7 @@ func deliverSlackTo(
 
 	d := buildSlackDelivery(
 		dlv, event, targetID,
-		"test-slack-mask", webhookURL,
+		"test-slack-mask", string(slackCfg),
 	)
 
 	e.ExportDeliverSlack(context.TODO(), db, d)
@@ -152,9 +160,13 @@ func TestDoHTTPRequest_TransportErrorMasksURL(t *testing.T) {
 
 	e := testEngine(t, 1)
 
+	cfg, err := e.ExportParseHTTPConfig(
+		newHTTPTargetConfig(host + maskSecretPath),
+	)
+	require.NoError(t, err)
+
 	statusCode, _, _, reqErr := e.ExportDoHTTPRequest(
-		context.TODO(),
+		context.TODO(), cfg,
-		&database.Target{URL: host + maskSecretPath},
 		&database.Event{Body: `{"test":true}`},
 	)
 	require.Error(t, reqErr)
@@ -176,7 +188,7 @@ func TestDoHTTPRequest_UnparsableURLIsMasked(t *testing.T) {
 
 	statusCode, _, _, reqErr := e.ExportDoHTTPRequest(
 		context.TODO(),
-		&database.Target{
+		&delivery.HTTPTargetConfig{
 			URL: "https://hooks.example.com" + maskSecretPath + "\n",
 		},
 		&database.Event{},

internal/delivery/user_agent_test.go

@@ -2,6 +2,7 @@ package delivery_test
 
 import (
 	"context"
+	"encoding/json"
 	"net/http"
 	"net/http/httptest"
 	"net/netip"
@@ -58,9 +59,9 @@ func TestUserAgent_IsTheBuildVersion(t *testing.T) {
 
 	statusCode, _, _, err := e.ExportDoHTTPRequest(
 		context.Background(),
-		&database.Target{
+		&delivery.HTTPTargetConfig{
 			URL:     ts.URL,
-			Headers: map[string]string{headerUserAgent: "configured/1"},
+			Headers: map[string]string{"User-Agent": "configured/1"},
 		},
 		&database.Event{Headers: `{"User-Agent":["curl/8"]}`},
 	)
@@ -72,13 +73,18 @@ func TestUserAgent_IsTheBuildVersion(t *testing.T) {
 	db := testWebhookDB(t)
 	targetID := uuid.New().String()
 
+	slackCfg, err := json.Marshal(
+		delivery.SlackTargetConfig{WebhookURL: ts.URL},
+	)
+	require.NoError(t, err)
+
 	event := seedEvent(t, db, `{"action":"test"}`)
 	dlv := seedDelivery(
 		t, db, event.ID, targetID, database.DeliveryStatusPending,
 	)
 
 	e.ExportDeliverSlack(context.Background(), db, buildSlackDelivery(
-		dlv, event, targetID, "test-slack", ts.URL,
+		dlv, event, targetID, "test-slack", string(slackCfg),
 	))
 	require.Len(t, userAgents, 1, "the slack target sent no request")
 	assert.Equal(t, want, <-userAgents, "slack target")

internal/gormlog/gormlog_test.go

@@ -146,7 +146,7 @@ func openDB(
 }
 
 // assertBounded holds every line the adapter wrote to the stated
-// ceiling and proves no line carried a whole client value.
+// ceiling and proves each was cut rather than merely short.
 func assertBounded(t *testing.T, out string) {
 	t.Helper()
 

internal/handlers/archive_expiry.go

@@ -1,14 +1,8 @@
 package handlers
 
-import (
-	"strconv"
-	"time"
-)
-
 const (
 	// archiveExpiryNever is the archive expiry that keeps archived
-	// events forever. It is stored as an ArchiveExpiry of 0, and an
+	// events forever. A stored empty expiry means the same.
-	// empty expiry on a form means the same.
 	archiveExpiryNever = "never"
 
 	// tmplKeyArchiveExpiryChoices is the template data key for the
@@ -62,19 +56,3 @@ func archiveExpiryOptions(expiry string) []archiveChoice {
 
 	return append([]archiveChoice{own}, options...)
 }
-
-// formatArchiveExpiry writes a stored ArchiveExpiry the way the
-// expiry select spells its values, so the target edit form starts on
-// the stored choice: never for 0, a whole number of hours as "720h",
-// and anything else as Go writes a duration, which the form accepts
-// back unchanged.
-func formatArchiveExpiry(expiry time.Duration) string {
-	switch {
-	case expiry == 0:
-		return archiveExpiryNever
-	case expiry%time.Hour == 0:
-		return strconv.FormatInt(int64(expiry/time.Hour), 10) + "h"
-	default:
-		return expiry.String()
-	}
-}

internal/handlers/archive_expiry_test.go

@@ -7,7 +7,6 @@ import (
 	"regexp"
 	"strings"
 	"testing"
-	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -95,18 +94,14 @@ func TestArchiveExpiryChoices(t *testing.T) {
 
 	env := setupSourceTest(t)
 
-	choices := []struct {
+	choices := []struct{ value, shown string }{
-		value  string
+		{expiryNever, expiryNever},
-		stored time.Duration
+		{"1h", "1 hour"},
-		shown  string
+		{"12h", "12 hours"},
-	}{
+		{"24h", "1 day"},
-		{expiryNever, 0, expiryNever},
+		{"720h", "30 days"},
-		{"1h", time.Hour, "1 hour"},
+		{"2160h", "90 days"},
-		{"12h", 12 * time.Hour, "12 hours"},
+		{"8760h", "365 days"},
-		{"24h", 24 * time.Hour, "1 day"},
-		{"720h", 720 * time.Hour, "30 days"},
-		{"2160h", 2160 * time.Hour, "90 days"},
-		{"8760h", 8760 * time.Hour, "365 days"},
 	}
 
 	for _, choice := range choices {
@@ -127,7 +122,9 @@ func TestArchiveExpiryChoices(t *testing.T) {
 
 			targets := targetsForWebhook(t, env.db, webhook.ID)
 			require.Len(t, targets, 1)
-			assert.Equal(t, choice.stored, targets[0].ArchiveExpiry)
+			assert.JSONEq(
+				t, `{"expiry":"`+choice.value+`"}`, targets[0].Config,
+			)
 
 			assert.Equal(
 				t, []string{choice.shown},
@@ -141,7 +138,7 @@ func TestArchiveExpiryChoices(t *testing.T) {
 }
 
 // TestArchiveExpiryEditStartsOnStoredValue checks the edit form of a
-// database target whose stored expiry is 0, which selects never,
+// database target whose stored expiry is empty, which selects never,
 // and of one whose expiry is not one of the choices, which is listed
 // first as its own selected entry and saved unchanged.
 func TestArchiveExpiryEditStartsOnStoredValue(t *testing.T) {
@@ -151,8 +148,7 @@ func TestArchiveExpiryEditStartsOnStoredValue(t *testing.T) {
 
 	webhook := seedWebhookWithRetention(t, env.db, 30)
 	empty := seedConfiguredTarget(
-		t, env.db, webhook.ID, database.TargetTypeDatabase,
+		t, env.db, webhook.ID, database.TargetTypeDatabase, "",
-		database.Target{},
 	)
 
 	_, selected := expirySelected(t, env, webhook.ID, empty.ID)
@@ -161,7 +157,7 @@ func TestArchiveExpiryEditStartsOnStoredValue(t *testing.T) {
 	webhook = seedWebhookWithRetention(t, env.db, 30)
 	unlisted := seedConfiguredTarget(
 		t, env.db, webhook.ID, database.TargetTypeDatabase,
-		database.Target{ArchiveExpiry: 36 * time.Hour},
+		`{"expiry":"36h"}`,
 	)
 
 	assert.Equal(t, []string{"36 hours"}, expiryShown(t, env, webhook.ID))
@@ -183,7 +179,7 @@ func TestArchiveExpiryEditStartsOnStoredValue(t *testing.T) {
 
 	w := submitTargetEdit(env, webhook.ID, unlisted.ID, form)
 	require.Equal(t, http.StatusSeeOther, w.Code, w.Body.String())
-	assert.Equal(
+	assert.JSONEq(
-		t, 36*time.Hour, storedTarget(t, env, unlisted.ID).ArchiveExpiry,
+		t, `{"expiry":"36h"}`, storedTarget(t, env, unlisted.ID).Config,
 	)
 }

internal/handlers/archive_rotation_test.go

@@ -12,16 +12,12 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
+	"sneak.berlin/go/webhooker/internal/delivery"
 )
 
-// The archive rotations these tests store: none keeps one file.
+// rotationNone is the archive rotation that keeps one file.
-const (
+const rotationNone = "none"
-	rotationNone   = "none"
-	rotationDaily  = "daily"
-	rotationHourly = "hourly"
-)
 
 // rotationShown returns the archive rotations the webhook page's
 // target list shows.
@@ -45,9 +41,7 @@ func TestArchiveRotationChoices(t *testing.T) {
 
 	env := setupSourceTest(t)
 
-	for _, rotation := range []string{
+	for _, rotation := range []string{rotationNone, "monthly", "daily", "hourly"} {
-		rotationNone, "monthly", rotationDaily, rotationHourly,
-	} {
 		t.Run(rotation, func(t *testing.T) {
 			t.Parallel()
 
@@ -66,8 +60,10 @@ func TestArchiveRotationChoices(t *testing.T) {
 
 			targets := targetsForWebhook(t, env.db, webhook.ID)
 			require.Len(t, targets, 1)
-			assert.Equal(t, 720*time.Hour, targets[0].ArchiveExpiry)
+			assert.JSONEq(t,
-			assert.Equal(t, rotation, targets[0].ArchiveRotation)
+				`{"expiry":"720h","rotation":"`+rotation+`"}`,
+				targets[0].Config,
+			)
 
 			assert.Equal(t,
 				[]string{rotation}, rotationShown(t, env, webhook.ID))
@@ -82,37 +78,26 @@ func TestArchiveRotationChoices(t *testing.T) {
 
 			w = submitTargetEdit(env, webhook.ID, targets[0].ID, form)
 			require.Equal(t, http.StatusSeeOther, w.Code, w.Body.String())
-
+			assert.JSONEq(t,
-			stored := storedTarget(t, env, targets[0].ID)
+				`{"expiry":"720h","rotation":"hourly"}`,
-			assert.Equal(t, 720*time.Hour, stored.ArchiveExpiry)
+				storedTarget(t, env, targets[0].ID).Config,
-			assert.Equal(t, rotationHourly, stored.ArchiveRotation)
+			)
 		})
 	}
 }
 
-// TestArchiveRotationEditStartsOnNone checks that a database target
+// TestArchiveRotationEditStartsOnNone checks the edit form of a
-// added with no rotation is stored with none and shown with none, and
+// database target with no rotation stored starts on none.
-// that its edit form starts on none.
 func TestArchiveRotationEditStartsOnNone(t *testing.T) {
 	t.Parallel()
 
 	env := setupSourceTest(t)
 	webhook := seedWebhookWithRetention(t, env.db, 30)
-
+	target := seedConfiguredTarget(
-	form := url.Values{}
+		t, env.db, webhook.ID, database.TargetTypeDatabase, "",
-	form.Set("name", "archive")
-	form.Set("type", string(database.TargetTypeDatabase))
-
-	w := serveTarget(
-		env, http.MethodPost, "/hook/"+webhook.ID+"/targets", form,
 	)
-	require.Equal(t, http.StatusSeeOther, w.Code, w.Body.String())
 
-	targets := targetsForWebhook(t, env.db, webhook.ID)
+	page := targetEditPage(t, env, webhook.ID, target.ID)
-	require.Len(t, targets, 1)
-	assert.Equal(t, rotationNone, targets[0].ArchiveRotation)
-
-	page := targetEditPage(t, env, webhook.ID, targets[0].ID)
 	assert.Equal(t, []string{rotationNone}, selectedIn(page, "rotation"))
 	assert.Equal(t, []string{rotationNone}, rotationShown(t, env, webhook.ID))
 }
@@ -140,7 +125,7 @@ func TestArchiveRotationRefused(t *testing.T) {
 
 	target := seedConfiguredTarget(
 		t, env.db, webhook.ID, database.TargetTypeDatabase,
-		database.Target{ArchiveRotation: rotationDaily},
+		`{"rotation":"daily"}`,
 	)
 
 	form.Del("type")
@@ -148,8 +133,8 @@ func TestArchiveRotationRefused(t *testing.T) {
 	w = submitTargetEdit(env, webhook.ID, target.ID, form)
 	assert.Equal(t, http.StatusBadRequest, w.Code)
 	assert.Contains(t, w.Body.String(), "Invalid archive rotation")
-	assert.Equal(
+	assert.JSONEq(t,
-		t, rotationDaily, storedTarget(t, env, target.ID).ArchiveRotation,
+		`{"rotation":"daily"}`, storedTarget(t, env, target.ID).Config,
 	)
 }
 
@@ -176,8 +161,9 @@ func TestHandleSourceCreateSubmit_ArchiveRotation(t *testing.T) {
 
 	targets := targetsForWebhook(t, env.db, webhook.ID)
 	require.Len(t, targets, 1)
-	assert.Equal(t, 720*time.Hour, targets[0].ArchiveExpiry)
+	assert.JSONEq(t,
-	assert.Equal(t, rotationDaily, targets[0].ArchiveRotation)
+		`{"expiry":"720h","rotation":"daily"}`, targets[0].Config,
+	)
 }
 
 // TestArchiveFileView_Rotated describes a daily target's archive files
@@ -192,10 +178,10 @@ func TestArchiveFileView_Rotated(t *testing.T) {
 	webhook := seedWebhookWithRetention(t, env.db, 30)
 	target := seedConfiguredTarget(
 		t, env.db, webhook.ID, database.TargetTypeDatabase,
-		database.Target{ArchiveRotation: rotationDaily},
+		`{"rotation":"daily"}`,
 	)
 
-	path := archive.Path(env.dbMgr, &webhook, target)
+	path := delivery.ArchivePath(env.dbMgr, &webhook, target)
 	stem := strings.TrimSuffix(path, ".db")
 	written := time.Date(2026, 10, 2, 9, 0, 0, 0, time.UTC)
 

internal/handlers/delivery_replay.go

@@ -5,7 +5,9 @@ import (
 
 	"github.com/go-chi/chi"
 	"gorm.io/gorm"
+	"gorm.io/gorm/clause"
 	"sneak.berlin/go/webhooker/internal/database"
+	"sneak.berlin/go/webhooker/internal/delivery"
 )
 
 // The outcomes of a replay POST, as the notice codes its redirect
@@ -44,12 +46,12 @@ const (
 // HandleDeliveryReplay re-sends a finished delivery's event to its
 // target.
 //
-// A replay never touches the delivery it repeats. The delivery engine
+// A replay never touches the delivery it repeats. It creates a NEW
-// creates a NEW pending delivery row for the same event and target and
+// pending delivery row for the same event and target and hands it to
-// queues it as it queues the receiver's, so the original's status,
+// the delivery engine through the same Notifier the receiver uses, so
-// attempts and timestamps stand as the record of what actually
+// the original's status, attempts and timestamps stand as the record
-// happened, and the replay is retried, SSRF-guarded and circuit-broken
+// of what actually happened, and the replay is retried, SSRF-guarded
-// exactly as a first attempt is.
+// and circuit-broken exactly as a first attempt is.
 //
 // What is re-sent is the stored EVENT body, never the response the
 // original delivery received.
@@ -143,8 +145,7 @@ func (h *Handlers) loadReplaySource(
 	return &original, true
 }
 
-// queueReplay has the delivery engine create and queue the new
+// queueReplay writes the new delivery and hands it to the engine.
-// delivery, unless an earlier replay is still in flight.
 func (h *Handlers) queueReplay(
 	w http.ResponseWriter,
 	r *http.Request,
@@ -170,8 +171,18 @@ func (h *Handlers) queueReplay(
 		return
 	}
 
-	deliveryID, err := h.engine.CreateReplay(
+	var event database.Event
-		webhook.ID, original.EventID, target,
+
+	err = webhookDB.
+		First(&event, "id = ?", original.EventID).Error
+	if err != nil {
+		h.serverError(w, r, "failed to load event for replay", err)
+
+		return
+	}
+
+	task, err := createReplayDelivery(
+		webhookDB, webhook.ID, &event, target,
 	)
 	if err != nil {
 		h.serverError(
@@ -182,14 +193,15 @@ func (h *Handlers) queueReplay(
 	}
 
 	h.mtr.DeliveryReplayed(target.Type)
+	h.notifier.Notify([]delivery.Task{task})
 
 	h.log.Info(
 		"delivery replay queued",
 		"webhook_id", webhook.ID,
-		"event_id", original.EventID,
+		"event_id", event.ID,
 		"target_id", target.ID,
 		"replayed_delivery_id", original.ID,
-		"delivery_id", deliveryID,
+		"delivery_id", task.DeliveryID,
 	)
 
 	redirectToEventLog(w, r, webhook, replayQueued)
@@ -251,6 +263,72 @@ func countInFlightDeliveries(
 	return count, err
 }
 
+// createReplayDelivery writes the new pending delivery row, adds it to
+// its target's totals in the same transaction, and returns the task
+// that carries it to the delivery engine.
+//
+// The row is written with associations omitted, and neither Event nor
+// Target is populated on it: GORM's SaveBeforeAssociations would
+// otherwise upsert the whole target row — plaintext config, which for a
+// Slack target is the credential — into the per-webhook event database.
+// See https://git.eeqj.de/sneak/webhooker/issues/206.
+func createReplayDelivery(
+	webhookDB *gorm.DB,
+	webhookID string,
+	event *database.Event,
+	target *database.Target,
+) (delivery.Task, error) {
+	dlv := &database.Delivery{
+		EventID:  event.ID,
+		TargetID: target.ID,
+		Status:   database.DeliveryStatusPending,
+		Replay:   true,
+	}
+
+	err := webhookDB.Transaction(func(tx *gorm.DB) error {
+		err := tx.Omit(clause.Associations).Create(dlv).Error
+		if err != nil {
+			return err
+		}
+
+		return database.AddTargetTotals(tx, database.TargetTotals{
+			TargetID: dlv.TargetID, Deliveries: 1,
+		})
+	})
+	if err != nil {
+		return delivery.Task{}, err
+	}
+
+	return delivery.Task{
+		DeliveryID:   dlv.ID,
+		EventID:      event.ID,
+		WebhookID:    webhookID,
+		EntrypointID: event.EntrypointID,
+		TargetID:     target.ID,
+		TargetName:   target.Name,
+		TargetType:   target.Type,
+		TargetConfig: target.Config,
+		MaxRetries:   target.MaxRetries,
+		Method:       event.Method,
+		RawQuery:     event.RawQuery,
+		Headers:      event.Headers,
+		ContentType:  event.ContentType,
+		Body:         replayBody(event.Body),
+		AttemptNum:   1,
+	}, nil
+}
+
+// replayBody returns the stored event body for a replay task to carry
+// inline, or nil when it is large enough that the engine should fetch
+// it from the per-webhook database instead.
+func replayBody(body string) *string {
+	if len(body) >= delivery.MaxInlineBodySize {
+		return nil
+	}
+
+	return &body
+}
+
 // redirectToEventLog redirects a replay or resubmit back to the event
 // log it was triggered from, carrying the outcome as its notice. A
 // Replay form carries the list it was pressed in as show, so a replay

internal/handlers/delivery_replay_test.go

@@ -12,6 +12,7 @@ import (
 	"gorm.io/gorm"
 	"gorm.io/gorm/clause"
 	"sneak.berlin/go/webhooker/internal/database"
+	"sneak.berlin/go/webhooker/internal/delivery"
 	"sneak.berlin/go/webhooker/internal/handlers"
 	"sneak.berlin/go/webhooker/internal/session"
 )
@@ -22,7 +23,7 @@ const paramDeliveryID = "deliveryID"
 
 // replayTargetURL is a public destination, so a target configured with
 // it is one the SSRF guard would accept. Nothing in these tests
-// dispatches to it: the delivery engine is never started.
+// dispatches to it: the notifier is recorded, not run.
 const replayTargetURL = "http://93.184.216.34/hook"
 
 // replayEventQuery is the query string a seeded event arrived with.
@@ -162,8 +163,14 @@ func postReplay(
 
 // TestHandleDeliveryReplay_AppendsDeliveryAndLeavesOriginal is the
 // core requirement: replaying a failed delivery succeeds, appends a
-// new delivery marked as a replay, and leaves the original row and its
+// new delivery, and leaves the original row and its recorded attempt
-// recorded attempt exactly as they were.
+// exactly as they were.
+//
+// It also pins the two things a replay would be wrong to get from the
+// original: the task carries the target's CURRENT configuration, which
+// this test changes between the failure and the replay, and it carries
+// the stored EVENT body rather than anything the failed attempt
+// received back.
 func TestHandleDeliveryReplay_AppendsDeliveryAndLeavesOriginal(
 	t *testing.T,
 ) {
@@ -174,9 +181,10 @@ func TestHandleDeliveryReplay_AppendsDeliveryAndLeavesOriginal(
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -184,7 +192,7 @@ func TestHandleDeliveryReplay_AppendsDeliveryAndLeavesOriginal(
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: replayTargetURL},
+		`{"url":"`+replayTargetURL+`"}`,
 	)
 
 	event, original := seedFailedDelivery(
@@ -196,6 +204,15 @@ func TestHandleDeliveryReplay_AppendsDeliveryAndLeavesOriginal(
 
 	before := loadDelivery(t, webhookDB, original.ID)
 
+	// The operator fixes the destination, which is the whole reason
+	// to replay. The replay must use this, not the config the
+	// original delivery ran against.
+	const fixedConfig = `{"url":"http://93.184.216.34/fixed"}`
+
+	require.NoError(t, db.DB().Model(&database.Target{}).
+		Where("id = ?", tgt.ID).
+		Update("config", fixedConfig).Error)
+
 	w := postReplay(t, h, sess, wh.ID, original.ID)
 
 	require.Equal(t, http.StatusSeeOther, w.Code)
@@ -217,9 +234,14 @@ func TestHandleDeliveryReplay_AppendsDeliveryAndLeavesOriginal(
 	assert.Equal(
 		t, database.DeliveryStatusPending, replayed.Status,
 	)
-	assert.True(t, replayed.Replay)
 
 	assertDeliveryUntouched(t, webhookDB, before)
+
+	tasks := notif.Tasks()
+	require.Len(t, tasks, 1)
+	assertReplayTask(
+		t, tasks[0], wh.ID, event, tgt, replayed.ID, fixedConfig,
+	)
 	assertNoLeakedTarget(t, webhookDB)
 }
 
@@ -253,6 +275,45 @@ func assertDeliveryUntouched(
 	)
 }
 
+// assertReplayTask proves the task handed to the delivery engine is
+// the one the receiver would build for this event and this target, and
+// that it carries wantConfig — the target's configuration as it stands
+// now rather than as the original delivery ran against it.
+func assertReplayTask(
+	t *testing.T,
+	task delivery.Task,
+	webhookID string,
+	event *database.Event,
+	target *database.Target,
+	wantDeliveryID, wantConfig string,
+) {
+	t.Helper()
+
+	assert.Equal(t, wantDeliveryID, task.DeliveryID)
+	assert.Equal(t, event.ID, task.EventID)
+	assert.Equal(t, webhookID, task.WebhookID)
+	assert.Equal(t, event.EntrypointID, task.EntrypointID)
+	assert.Equal(t, target.ID, task.TargetID)
+	assert.Equal(t, target.Type, task.TargetType)
+	assert.JSONEq(
+		t, wantConfig, task.TargetConfig,
+		"replay must use the target's current configuration",
+	)
+	assert.Equal(t, event.Method, task.Method)
+	assert.Equal(
+		t, replayEventQuery, task.RawQuery,
+		"replay re-sends the stored query string",
+	)
+	assert.Equal(t, event.Headers, task.Headers)
+	assert.Equal(t, event.ContentType, task.ContentType)
+	assert.Equal(t, 1, task.AttemptNum)
+	require.NotNil(t, task.Body)
+	assert.Equal(
+		t, event.Body, *task.Body,
+		"replay re-sends the stored event body",
+	)
+}
+
 // assertNoLeakedTarget proves the per-webhook database holds no
 // target: an association write would have upserted the whole target,
 // plaintext config and all, into the event database. See
@@ -266,49 +327,9 @@ func assertNoLeakedTarget(t *testing.T, webhookDB *gorm.DB) {
 	)
 }
 
-// TestHandleDeliveryReplay_FailedStoreIsAnError proves a replay the
-// engine cannot store answers with the 500 error page and adds no
-// delivery.
-func TestHandleDeliveryReplay_FailedStoreIsAnError(t *testing.T) {
-	t.Parallel()
-
-	var (
-		h     *handlers.Handlers
-		sess  *session.Session
-		db    *database.Database
-		dbMgr *database.WebhookDBManager
-	)
-
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
-	app.RequireStart()
-
-	t.Cleanup(app.RequireStop)
-
-	wh := seedWebhook(t, db)
-	tgt := seedConfiguredTarget(
-		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: replayTargetURL},
-	)
-
-	event, original := seedFailedDelivery(t, dbMgr, wh.ID, tgt.ID)
-
-	// Without its target totals table the webhook's database refuses
-	// the totals write, which comes after the delivery row.
-	webhookDB, err := dbMgr.GetDB(wh.ID)
-	require.NoError(t, err)
-	require.NoError(t,
-		webhookDB.Migrator().DropTable(&database.TargetTotals{}))
-
-	w := postReplay(t, h, sess, wh.ID, original.ID)
-
-	assert.Equal(t, http.StatusInternalServerError, w.Code)
-	assert.Contains(t, w.Body.String(), "500 Internal Server Error")
-	assert.Len(t, listDeliveries(t, webhookDB, event.ID), 1)
-}
-
 // TestHandleDeliveryReplay_RefusesDeletedTarget proves the required
 // refusal: a target deleted since the delivery ran is reported as
-// deleted rather than erroring, and nothing is created.
+// deleted rather than erroring, and nothing is created or queued.
 func TestHandleDeliveryReplay_RefusesDeletedTarget(t *testing.T) {
 	t.Parallel()
 
@@ -317,9 +338,10 @@ func TestHandleDeliveryReplay_RefusesDeletedTarget(t *testing.T) {
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -327,7 +349,7 @@ func TestHandleDeliveryReplay_RefusesDeletedTarget(t *testing.T) {
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: replayTargetURL},
+		`{"url":"`+replayTargetURL+`"}`,
 	)
 
 	event, original := seedFailedDelivery(
@@ -355,6 +377,10 @@ func TestHandleDeliveryReplay_RefusesDeletedTarget(t *testing.T) {
 		t, listDeliveries(t, webhookDB, event.ID), 1,
 		"a refused replay must create no delivery",
 	)
+	assert.Empty(
+		t, notif.Tasks(),
+		"a refused replay must queue nothing",
+	)
 
 	// The refusal is specific, which is why the target is looked up
 	// including soft-deleted rows: an id that never named a target
@@ -387,9 +413,10 @@ func TestHandleDeliveryReplay_RefusesWhileEarlierReplayInFlight(
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -397,7 +424,7 @@ func TestHandleDeliveryReplay_RefusesWhileEarlierReplayInFlight(
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: replayTargetURL},
+		`{"url":"`+replayTargetURL+`"}`,
 	)
 
 	event, original := seedFailedDelivery(
@@ -427,6 +454,10 @@ func TestHandleDeliveryReplay_RefusesWhileEarlierReplayInFlight(
 		t, listDeliveries(t, webhookDB, event.ID), 2,
 		"the refused second replay must add nothing",
 	)
+	assert.Len(
+		t, notif.Tasks(), 1,
+		"only the first replay reaches the delivery engine",
+	)
 
 	// A delivery the engine has not finished is not replayable
 	// either, which is the same rule seen from the other side.
@@ -467,7 +498,7 @@ func TestHandleDeliveryReplay_ReturnsToTheListItWasPressedIn(
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: replayTargetURL},
+		`{"url":"`+replayTargetURL+`"}`,
 	)
 
 	_, original := seedFailedDelivery(t, dbMgr, wh.ID, tgt.ID)
@@ -525,7 +556,7 @@ func TestHandleSourceLogs_RendersReplayControlAndBanner(t *testing.T) {
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: replayTargetURL},
+		`{"url":"`+replayTargetURL+`"}`,
 	)
 
 	_, original := seedFailedDelivery(t, dbMgr, wh.ID, tgt.ID)
@@ -584,7 +615,7 @@ func TestHandleDeliveryReplay_LabelsTheReplay(t *testing.T) {
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: replayTargetURL},
+		`{"url":"`+replayTargetURL+`"}`,
 	)
 
 	event, original := seedFailedDelivery(t, dbMgr, wh.ID, tgt.ID)

internal/handlers/delivery_result_view.go

@@ -12,12 +12,13 @@ import (
 //
 // The bound is enforced here and in SQL, because this page's
 // memory profile must not depend on a constant in another
-// package staying where it is, or on every stored row having
+// package staying where it is, and because rows predating the
-// been written by the delivery engine under its own cap.
+// delivery engine's own cap or restored from an archive are
+// not covered by it at all.
 //
 // It happens to equal that engine cap, so a row written by the
-// engine reaches this one exactly and is never cut twice.
+// current engine reaches this one exactly and is never cut
-// Nothing here may assume the two differ: see view.
+// twice. Nothing here may assume the two differ: see view.
 const maxRenderedResponseBytes = 4096
 
 // deliveryResultColumns is the delivery attempt projection.
@@ -39,8 +40,9 @@ const deliveryResultColumns = "delivery_id, attempt_num, created_at, " +
 //
 // Both Error and ResponseBody have been through the target's
 // Redactor. The engine already masks the URL out of the
-// errors it stores, so for errors this is a second line; for
+// errors it stores, so for errors this is a second line
-// response bodies it is the only line, and its reach is what
+// covering rows written before it did; for response bodies it
+// is the only line, and its reach is what
 // delivery.Redactor documents.
 type DeliveryResultView struct {
 	AttemptNum int

internal/handlers/delivery_result_view_test.go

@@ -86,12 +86,12 @@ func seedFailedDeliveryWithResponse(
 }
 
 // seedFailureAndRender seeds a failed delivery against a
-// target of the given type and URL, and returns the
+// target of the given type and config, and returns the
 // rendered event log page.
 func seedFailureAndRender(
 	t *testing.T,
 	targetType database.TargetType,
-	targetURL, responseBody string,
+	config, responseBody string,
 ) string {
 	t.Helper()
 
@@ -109,7 +109,7 @@ func seedFailureAndRender(
 
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
-		t, db, wh.ID, targetType, database.Target{URL: targetURL},
+		t, db, wh.ID, targetType, config,
 	)
 
 	seedFailedDeliveryWithResponse(
@@ -129,7 +129,7 @@ func TestHandleSourceLogs_RendersFailedAttempt(t *testing.T) {
 	body := seedFailureAndRender(
 		t,
 		database.TargetTypeHTTP,
-		"https://example.com/hook/abc",
+		`{"url":"https://example.com/hook/abc"}`,
 		"upstream exploded",
 	)
 
@@ -158,7 +158,8 @@ func TestHandleSourceLogs_RendersFailedAttempt(t *testing.T) {
 // TestHandleSourceLogs_EscapesResponseBody proves the
 // response body is treated as the untrusted remote content it
 // is. The remote chooses these bytes and the page is rendered
-// inside the operator's authenticated origin.
+// inside the operator's authenticated origin, where the
+// application's own CSP allows inline script from 'self'.
 func TestHandleSourceLogs_EscapesResponseBody(t *testing.T) {
 	t.Parallel()
 
@@ -167,7 +168,7 @@ func TestHandleSourceLogs_EscapesResponseBody(t *testing.T) {
 	body := seedFailureAndRender(
 		t,
 		database.TargetTypeHTTP,
-		"https://example.com/hook/abc",
+		`{"url":"https://example.com/hook/abc"}`,
 		payload,
 	)
 
@@ -189,7 +190,7 @@ func TestHandleSourceLogs_RedactsCredentialEchoedInResponse(
 	body := seedFailureAndRender(
 		t,
 		database.TargetTypeSlack,
-		slackWebhookURL,
+		`{"webhookUrl":"`+slackWebhookURL+`"}`,
 		"no_service: "+slackWebhookURL,
 	)
 
@@ -228,7 +229,7 @@ func TestHandleSourceLogs_RedactsCredentialEchoedInError(
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID,
 		database.TargetTypeSlack,
-		database.Target{URL: slackWebhookURL},
+		`{"webhookUrl":"`+slackWebhookURL+`"}`,
 	)
 
 	dlv := seedFailedDeliveryWithResponse(t, dbMgr, wh.ID, tgt.ID, "")
@@ -300,7 +301,7 @@ func TestHandleSourceLogs_RedactsCredentialSeveredByTheEngineCut(
 	body := seedFailureAndRender(
 		t,
 		database.TargetTypeSlack,
-		slackWebhookURL,
+		`{"webhookUrl":"`+slackWebhookURL+`"}`,
 		stored,
 	)
 
@@ -335,7 +336,7 @@ func TestHandleSourceLogs_RedactsCredentialSeveredBySQLCut(
 	body := seedFailureAndRender(
 		t,
 		database.TargetTypeSlack,
-		slackWebhookURL,
+		`{"webhookUrl":"`+slackWebhookURL+`"}`,
 		stored,
 	)
 
@@ -373,7 +374,7 @@ func TestHandleSourceLogs_RedactsForSoftDeletedTarget(
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID,
 		database.TargetTypeSlack,
-		database.Target{URL: slackWebhookURL},
+		`{"webhookUrl":"`+slackWebhookURL+`"}`,
 	)
 
 	seedFailedDeliveryWithResponse(
@@ -413,7 +414,7 @@ func TestHandleSourceLogs_BoundsRenderedAttempts(t *testing.T) {
 
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
-		t, db, wh.ID, database.TargetTypeLog, database.Target{},
+		t, db, wh.ID, database.TargetTypeLog, "",
 	)
 
 	dlv := seedFailedDeliveryWithResponse(t, dbMgr, wh.ID, tgt.ID, "")
@@ -480,7 +481,7 @@ func TestHandleSourceLogs_BoundsOversizeResponse(t *testing.T) {
 
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
-		t, db, wh.ID, database.TargetTypeLog, database.Target{},
+		t, db, wh.ID, database.TargetTypeLog, "",
 	)
 
 	stored := strings.Repeat("A", responseCap*4) + tail

internal/handlers/event_body.go

@@ -35,10 +35,11 @@ const eventBodyQuery = "SELECT cast(body as blob) " +
 // response is deliberately not renderable. Content-Disposition
 // makes the browser download rather than display it, and the
 // octet-stream type plus nosniff stop it being interpreted as
-// HTML or script. Without those a stored payload would be shown
+// HTML or script. Without those a stored payload would execute
-// as a page of the operator's own origin. The application's CSP
+// as the logged-in operator. The application's CSP does not
-// is a second defence behind them: it allows no inline script,
+// help here: script-src allows 'unsafe-inline' from 'self', so
-// so such a page could not run script of its own.
+// a document served from this origin could run its own inline
+// script.
 func (h *Handlers) HandleEventBodyDownload() http.HandlerFunc {
 	return func(w http.ResponseWriter, r *http.Request) {
 		webhook, ok := h.ownedWebhook(w, r)

internal/handlers/event_detail_test.go

@@ -84,7 +84,7 @@ func TestHandleEventDetail_ShowsEventWholeWithDeliveries(t *testing.T) {
 	assert.Contains(t, page, strconv.Itoa(len(body))+" bytes")
 	assert.Contains(t, page, "{\n  "pad": "xxx")
 	assert.Contains(t, page, ""tail": ""+sentinel+""\n}")
-	assert.Contains(t, page, `break-all max-h-[32rem] overflow-y-auto"`)
+	assert.Contains(t, page, `style="max-height: 32rem; overflow-y: auto"`)
 	assert.NotContains(t, page, "Showing the first")
 	assert.Contains(t, page, target.Name)
 	assert.Contains(t, page, ">failed</span>")

internal/handlers/event_log.go

@@ -13,8 +13,8 @@ import (
 
 // DeliveryView is the display-safe projection of a delivery
 // for the event log page. Its target is a TargetView, so the
-// target's URL and headers — which hold the target's
+// stored configuration blob — which holds the target's
-// credential — have no path to the template.
+// credential — has no path to the template.
 type DeliveryView struct {
 	ID     string
 	Status database.DeliveryStatus
@@ -126,7 +126,7 @@ func (h *Handlers) HandleSourceLogs() http.HandlerFunc {
 // loadTargetMap loads targets into a map of display-safe
 // views keyed by target ID, each paired with its redactor.
 // The projection happens here so that no caller can hand a
-// raw target, URL and headers and all, to a template: the
+// raw target, configuration blob and all, to a template: the
 // raw rows do not leave this function.
 //
 // The load is Unscoped because deleting a target only soft
@@ -496,7 +496,7 @@ const deliveryIDChunkSize = 500
 //
 // Each response body is cut by SQLite rather than in Go, for
 // the reason deliveryResultColumns gives. How many attempts a
-// delivery has is bounded by the target's MaxAttempts, which the
+// delivery has is the target's MaxRetries, which the
 // authenticated operator sets; how many of them reach the page
 // is bounded again by maxRenderedAttempts.
 func (h *Handlers) loadDeliveryResults(

internal/handlers/event_resubmit.go

@@ -171,29 +171,37 @@ func loadResubmitSource(
 	return src, true, nil
 }
 
-// queueResubmit has the delivery engine store the copy, with a delivery
+// queueResubmit stores the copy and fans it out to the webhook's
-// for each of the webhook's active targets as they stand now, through
+// active targets.
-// the same StoreEvent the receiver uses. The one difference is that the
-// copy leaves its entrypoint's last event as it is, since it did not
-// arrive on that URL.
 func (h *Handlers) queueResubmit(
 	w http.ResponseWriter,
 	r *http.Request,
 	webhook database.Webhook,
 	src resubmitSource,
 ) {
-	event := &database.Event{
+	// The receiver's own query, run now: an active target created
-		WebhookID:         webhook.ID,
+	// after the original event arrived is included, and an
-		EntrypointID:      src.EntrypointID,
+	// inactive one is skipped rather than refused.
-		Method:            src.Method,
+	targets, err := h.loadActiveTargets(webhook.ID)
-		RawQuery:          src.RawQuery,
+	if err != nil {
-		Headers:           src.Headers,
+		h.serverError(w, r, "failed to query targets", err)
-		ContentType:       src.ContentType,
+
-		Body:              string(src.Body),
+		return
-		ResubmittedFromID: &src.ID,
 	}
 
-	deliveries, err := h.engine.StoreEvent(event)
+	event, tasks, err := h.createAndFanOut(
+		eventSource{
+			WebhookID:         webhook.ID,
+			EntrypointID:      src.EntrypointID,
+			Method:            src.Method,
+			RawQuery:          src.RawQuery,
+			HeadersJSON:       src.Headers,
+			ContentType:       src.ContentType,
+			Body:              src.Body,
+			ResubmittedFromID: &src.ID,
+		},
+		targets,
+	)
 	if err != nil {
 		h.serverError(w, r, "failed to store resubmitted event", err)
 
@@ -207,11 +215,11 @@ func (h *Handlers) queueResubmit(
 		"webhook_id", webhook.ID,
 		"event_id", event.ID,
 		"resubmitted_from_id", src.ID,
-		"target_count", deliveries,
+		"target_count", len(tasks),
 	)
 
 	code := resubmitQueued
-	if deliveries == 0 {
+	if len(tasks) == 0 {
 		code = resubmitNoTargets
 	}
 

internal/handlers/event_resubmit_test.go

@@ -19,7 +19,7 @@ import (
 
 // resubmitTargetURL is a public destination, so a target configured
 // with it is one the SSRF guard would accept. Nothing in these tests
-// dispatches to it: the delivery engine is never started.
+// dispatches to it: the notifier is recorded, not run.
 const resubmitTargetURL = "http://93.184.216.34/hook"
 
 // resubmitEventHeaders and resubmitEventQuery are the stored header
@@ -134,9 +134,10 @@ func TestHandleEventResubmit_DeliversToTargetCreatedAfterTheEvent(
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -150,7 +151,7 @@ func TestHandleEventResubmit_DeliversToTargetCreatedAfterTheEvent(
 	// captured. It has no prior delivery of anything.
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: resubmitTargetURL},
+		`{"url":"`+resubmitTargetURL+`"}`,
 	)
 
 	w := postResubmit(t, h, sess, wh.ID, original.ID)
@@ -188,6 +189,11 @@ func TestHandleEventResubmit_DeliversToTargetCreatedAfterTheEvent(
 		t, database.DeliveryStatusPending, deliveries[0].Status,
 	)
 
+	tasks := notif.Tasks()
+	require.Len(t, tasks, 1)
+	assert.Equal(t, deliveries[0].ID, tasks[0].DeliveryID)
+	assertResubmitTask(t, tasks[0], wh.ID, &fresh, tgt)
+
 	assertNoLeakedTarget(t, webhookDB)
 }
 
@@ -219,6 +225,32 @@ func assertEventCopy(
 	)
 }
 
+// assertResubmitTask proves the task handed to the delivery engine is
+// the one the receiver would build for the NEW event and this target.
+func assertResubmitTask(
+	t *testing.T,
+	task delivery.Task,
+	webhookID string,
+	fresh *database.Event,
+	target *database.Target,
+) {
+	t.Helper()
+
+	assert.Equal(t, fresh.ID, task.EventID)
+	assert.Equal(t, webhookID, task.WebhookID)
+	assert.Equal(t, fresh.EntrypointID, task.EntrypointID)
+	assert.Equal(t, target.ID, task.TargetID)
+	assert.Equal(t, target.Type, task.TargetType)
+	assert.Equal(t, fresh.Method, task.Method)
+	assert.Equal(t, fresh.RawQuery, task.RawQuery)
+	assert.Equal(t, fresh.Headers, task.Headers)
+	assert.Equal(t, fresh.ContentType, task.ContentType)
+	assert.Equal(t, 1, task.AttemptNum)
+
+	require.NotNil(t, task.Body)
+	assert.Equal(t, fresh.Body, *task.Body)
+}
+
 // TestHandleEventResubmit_IsRepeatable proves the requirement replay
 // deliberately does not meet: firing the same captured event at a
 // backend over and over must work, with no in-flight refusal, and each
@@ -231,9 +263,10 @@ func TestHandleEventResubmit_IsRepeatable(t *testing.T) {
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -241,7 +274,7 @@ func TestHandleEventResubmit_IsRepeatable(t *testing.T) {
 	wh := seedWebhook(t, db)
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: resubmitTargetURL},
+		`{"url":"`+resubmitTargetURL+`"}`,
 	)
 	original := seedStoredEvent(t, dbMgr, wh.ID, `{"fire":"again"}`)
 
@@ -267,18 +300,30 @@ func TestHandleEventResubmit_IsRepeatable(t *testing.T) {
 	require.NoError(t, err)
 
 	events := listEvents(t, webhookDB)
-	require.Len(
+	require.Len(t, events, presses+1)
-		t, events, presses+1, "each resubmit creates its own event",
-	)
 
-	assert.Empty(
+	tasks := notif.Tasks()
-		t, listDeliveries(t, webhookDB, original.ID),
+	require.Len(t, tasks, presses)
-		"each resubmit delivers its own new event",
-	)
 
-	// Every copy has its own delivery, and names the same source
+	seen := make(map[string]struct{}, presses)
-	// event, so twenty presses stay traceable to the one captured
+
-	// request.
+	for _, task := range tasks {
+		assert.Equal(t, tgt.ID, task.TargetID)
+		assert.NotEqual(
+			t, original.ID, task.EventID,
+			"each resubmit delivers its own new event",
+		)
+
+		_, dup := seen[task.EventID]
+		assert.False(t, dup, "each resubmit creates its own event")
+
+		seen[task.EventID] = struct{}{}
+
+		require.Len(t, listDeliveries(t, webhookDB, task.EventID), 1)
+	}
+
+	// Every copy names the same source event, so twenty presses stay
+	// traceable to the one captured request.
 	for _, e := range events {
 		if e.ID == original.ID {
 			continue
@@ -286,10 +331,6 @@ func TestHandleEventResubmit_IsRepeatable(t *testing.T) {
 
 		require.NotNil(t, e.ResubmittedFromID)
 		assert.Equal(t, original.ID, *e.ResubmittedFromID)
-
-		deliveries := listDeliveries(t, webhookDB, e.ID)
-		require.Len(t, deliveries, 1)
-		assert.Equal(t, tgt.ID, deliveries[0].TargetID)
 	}
 }
 
@@ -305,9 +346,10 @@ func TestHandleEventResubmit_OversizeBodySurvivesIntact(t *testing.T) {
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -326,7 +368,7 @@ func TestHandleEventResubmit_OversizeBodySurvivesIntact(t *testing.T) {
 	wh := seedWebhook(t, db)
 	seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: resubmitTargetURL},
+		`{"url":"`+resubmitTargetURL+`"}`,
 	)
 	original := seedStoredEvent(t, dbMgr, wh.ID, stored)
 
@@ -343,7 +385,22 @@ func TestHandleEventResubmit_OversizeBodySurvivesIntact(t *testing.T) {
 		t, stored, fresh.Body,
 		"the stored body must be copied byte for byte",
 	)
-	assert.Len(t, listDeliveries(t, webhookDB, fresh.ID), 1)
+
+	tasks := notif.Tasks()
+	require.Len(t, tasks, 1)
+	assert.Nil(
+		t, tasks[0].Body,
+		"a body over the inline limit is fetched from the new "+
+			"event row rather than carried on the task",
+	)
+
+	// The engine's own read of the body, against the new event id:
+	// what it would send is what was stored.
+	var loaded database.Event
+
+	require.NoError(t, webhookDB.Select("body").
+		First(&loaded, "id = ?", tasks[0].EventID).Error)
+	assert.Equal(t, stored, loaded.Body)
 }
 
 // TestHandleEventResubmit_SkipsInactiveTarget proves a deactivated
@@ -357,9 +414,10 @@ func TestHandleEventResubmit_SkipsInactiveTarget(t *testing.T) {
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -367,11 +425,11 @@ func TestHandleEventResubmit_SkipsInactiveTarget(t *testing.T) {
 	wh := seedWebhook(t, db)
 	active := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: resubmitTargetURL},
+		`{"url":"`+resubmitTargetURL+`"}`,
 	)
 	off := seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: resubmitTargetURL + "/off"},
+		`{"url":"`+resubmitTargetURL+`/off"}`,
 	)
 
 	require.NoError(t, db.DB().Model(&database.Target{}).
@@ -390,19 +448,21 @@ func TestHandleEventResubmit_SkipsInactiveTarget(t *testing.T) {
 		"an inactive target is skipped, not an error",
 	)
 
+	tasks := notif.Tasks()
+	require.Len(t, tasks, 1)
+	assert.Equal(t, active.ID, tasks[0].TargetID)
+
 	webhookDB, err := dbMgr.GetDB(wh.ID)
 	require.NoError(t, err)
 
 	fresh := theOtherEvent(t, listEvents(t, webhookDB), original.ID)
-	deliveries := listDeliveries(t, webhookDB, fresh.ID)
+	require.Len(t, listDeliveries(t, webhookDB, fresh.ID), 1)
-	require.Len(t, deliveries, 1)
-	assert.Equal(t, active.ID, deliveries[0].TargetID)
 }
 
 // TestHandleEventResubmit_NoActiveTargetsStillStoresEvent proves a
 // source with nothing to deliver to behaves as the receiver does: the
-// event is stored with no delivery, and the operator is told so rather
+// event is stored, nothing is queued, and the operator is told so
-// than being shown an error.
+// rather than being shown an error.
 func TestHandleEventResubmit_NoActiveTargetsStillStoresEvent(
 	t *testing.T,
 ) {
@@ -413,9 +473,10 @@ func TestHandleEventResubmit_NoActiveTargetsStillStoresEvent(
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -432,14 +493,12 @@ func TestHandleEventResubmit_NoActiveTargetsStillStoresEvent(
 		w.Header().Get("Location"),
 	)
 
+	assert.Empty(t, notif.Tasks())
+
 	webhookDB, err := dbMgr.GetDB(wh.ID)
 	require.NoError(t, err)
 
-	events := listEvents(t, webhookDB)
+	assert.Len(t, listEvents(t, webhookDB), 2)
-	assert.Len(t, events, 2)
-
-	fresh := theOtherEvent(t, events, original.ID)
-	assert.Empty(t, listDeliveries(t, webhookDB, fresh.ID))
 }
 
 // TestHandleEventResubmit_RefusesEventOfAnotherWebhook proves the
@@ -455,9 +514,10 @@ func TestHandleEventResubmit_RefusesEventOfAnotherWebhook(
 		sess  *session.Session
 		db    *database.Database
 		dbMgr *database.WebhookDBManager
+		notif *recordingNotifier
 	)
 
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
+	app := newTestApp(t, &h, &sess, &db, &dbMgr, &notif)
 	app.RequireStart()
 
 	t.Cleanup(app.RequireStop)
@@ -468,7 +528,7 @@ func TestHandleEventResubmit_RefusesEventOfAnotherWebhook(
 	mine := seedWebhook(t, db)
 	seedConfiguredTarget(
 		t, db, mine.ID, database.TargetTypeHTTP,
-		database.Target{URL: resubmitTargetURL},
+		`{"url":"`+resubmitTargetURL+`"}`,
 	)
 	seedStoredEvent(t, dbMgr, mine.ID, `{"mine":true}`)
 
@@ -488,49 +548,10 @@ func TestHandleEventResubmit_RefusesEventOfAnotherWebhook(
 	w = postResubmit(t, h, sess, mine.ID, "not-a-uuid")
 	assert.Equal(t, http.StatusNotFound, w.Code)
 
-	for _, webhookID := range []string{theirs.ID, mine.ID} {
+	assert.Empty(
-		webhookDB, err := dbMgr.GetDB(webhookID)
+		t, notif.Tasks(),
-		require.NoError(t, err)
+		"a refused resubmit must queue nothing",
-
-		assert.Len(
-			t, listEvents(t, webhookDB), 1,
-			"a refused resubmit must store nothing",
-		)
-	}
-}
-
-// TestHandleEventResubmit_FailedStoreIsAnError proves a copy the engine
-// cannot store answers with the 500 error page and leaves no new event.
-func TestHandleEventResubmit_FailedStoreIsAnError(t *testing.T) {
-	t.Parallel()
-
-	var (
-		h     *handlers.Handlers
-		sess  *session.Session
-		db    *database.Database
-		dbMgr *database.WebhookDBManager
 	)
-
-	app := newTestApp(t, &h, &sess, &db, &dbMgr)
-	app.RequireStart()
-
-	t.Cleanup(app.RequireStop)
-
-	wh := seedWebhook(t, db)
-	original := seedStoredEvent(t, dbMgr, wh.ID, `{"not":"stored"}`)
-
-	// Without its event totals table the webhook's database refuses
-	// the totals write, which comes after the event row.
-	webhookDB, err := dbMgr.GetDB(wh.ID)
-	require.NoError(t, err)
-	require.NoError(t,
-		webhookDB.Migrator().DropTable(&database.EventTotals{}))
-
-	w := postResubmit(t, h, sess, wh.ID, original.ID)
-
-	assert.Equal(t, http.StatusInternalServerError, w.Code)
-	assert.Contains(t, w.Body.String(), "500 Internal Server Error")
-	assert.Len(t, listEvents(t, webhookDB), 1)
 }
 
 // TestHandleSourceLogs_ShowsResubmitProvenance proves the event log
@@ -554,7 +575,7 @@ func TestHandleSourceLogs_ShowsResubmitProvenance(t *testing.T) {
 	wh := seedWebhook(t, db)
 	seedConfiguredTarget(
 		t, db, wh.ID, database.TargetTypeHTTP,
-		database.Target{URL: resubmitTargetURL},
+		`{"url":"`+resubmitTargetURL+`"}`,
 	)
 	original := seedStoredEvent(t, dbMgr, wh.ID, `{"trace":"me"}`)
 

internal/handlers/export_test.go

@@ -37,10 +37,10 @@ const MaxRenderedResponseBytesForTest = maxRenderedResponseBytes
 // per-delivery attempt ceiling to the handlers_test package.
 const MaxRenderedAttemptsForTest = maxRenderedAttempts
 
-// MaxTargetAttemptsForTest exposes the target max_attempts ceiling to
+// MaxTargetRetriesForTest exposes the target max_retries ceiling to
 // the handlers_test package, so the tests assert against the constant
 // the handlers enforce rather than a number copied beside it.
-const MaxTargetAttemptsForTest = maxTargetAttempts
+const MaxTargetRetriesForTest = maxTargetRetries
 
 // EventDBLeftMsgForTest and SidecarLeftMsgForTest expose the two
 // messages the webhook delete handler logs when a file of the event
@@ -133,28 +133,36 @@ func (s *Handlers) RenderTemplateForTest(
 	s.renderTemplate(w, r, pageTemplate, data)
 }
 
-// SetSlackTargetSettingsForTest exposes setSlackTargetSettings for use
+// BuildSlackTargetConfigForTest exposes
-// in the handlers_test package.
+// buildSlackTargetConfig for use in the handlers_test package.
-func (s *Handlers) SetSlackTargetSettingsForTest(
+func (s *Handlers) BuildSlackTargetConfigForTest(
 	ctx context.Context,
-	target *database.Target,
 	targetURL string,
-) string {
+) (string, string, error) {
-	return s.setSlackTargetSettings(ctx, target, targetURL)
+	return s.buildSlackTargetConfig(ctx, targetURL)
 }
 
-// SetDatabaseTargetSettingsForTest exposes setDatabaseTargetSettings
+// BuildHTTPTargetConfigForTest exposes buildHTTPTargetConfig
-// for use in the handlers_test package.
+// for use in the handlers_test package, taking the form fields
-func SetDatabaseTargetSettingsForTest(
+// an HTTP target's configuration is built from.
-	target *database.Target,
+func (s *Handlers) BuildHTTPTargetConfigForTest(
+	ctx context.Context,
+	targetURL, headers, timeout string,
+) (string, string, error) {
+	return s.buildHTTPTargetConfig(ctx, targetFormInput{
+		URL:     targetURL,
+		Headers: headers,
+		Timeout: timeout,
+	})
+}
+
+// BuildDatabaseTargetConfigForTest exposes
+// buildDatabaseTargetConfig for use in the handlers_test
+// package.
+func BuildDatabaseTargetConfigForTest(
 	expiry, rotation string,
-) string {
+) (string, string, error) {
-	return setDatabaseTargetSettings(target, expiry, rotation)
+	return buildDatabaseTargetConfig(expiry, rotation)
-}
-
-// FormatArchiveExpiryForTest exposes formatArchiveExpiry.
-func FormatArchiveExpiryForTest(expiry time.Duration) string {
-	return formatArchiveExpiry(expiry)
 }
 
 // ArchiveFileViewForTest exposes archiveFileView, which describes a

internal/handlers/gormlogbound_test.go

@@ -374,7 +374,7 @@ func assertFloodBounded(t *testing.T, label, out string) {
 // this service's three gorm.Open sites: the main database behind the
 // two unauthenticated lookups, and the per-webhook database the
 // WebhookDBManager opens. The third, the archive writer, is pinned in
-// internal/archive, where its type lives.
+// internal/delivery, where its type lives.
 //
 // What each assertion is worth, since two of the three would pass
 // against a service that had never been fixed if the capture were set

internal/handlers/handlers.go

@@ -10,11 +10,11 @@ import (
 	"html/template"
 	"log/slog"
 	"net/http"
+	"sync"
 	"sync/atomic"
 
 	"github.com/prometheus/client_golang/prometheus"
 	"go.uber.org/fx"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/config"
 	"sneak.berlin/go/webhooker/internal/database"
 	"sneak.berlin/go/webhooker/internal/delivery"
@@ -64,8 +64,8 @@ type HandlersParams struct {
 	Healthcheck     *healthcheck.Healthcheck
 	Session         *session.Session
 	Middleware      *middleware.Middleware
-	Engine          *delivery.Engine
+	Notifier        delivery.Notifier
-	Archives        archive.Archives
+	Archives        delivery.Archives
 	CircuitBreakers delivery.CircuitBreakers
 	SSRFGuard       *delivery.Guard
 	Metrics         *metrics.Set
@@ -82,8 +82,8 @@ type Handlers struct {
 	dbMgr     *database.WebhookDBManager
 	session   *session.Session
 	mw        *middleware.Middleware
-	engine    *delivery.Engine
+	notifier  delivery.Notifier
-	archives  archive.Archives
+	archives  delivery.Archives
 	breakers  delivery.CircuitBreakers
 	mtr       *metrics.Set
 	templates map[string]*template.Template
@@ -93,6 +93,17 @@ type Handlers struct {
 	// is one delivery will actually attempt.
 	ssrf *delivery.Guard
 
+	// renameMu makes the webhook edit, the target edit and target
+	// creation run one at a time, each held from loading the stored
+	// names through the archive rename, the save and any move back.
+	// Interleaved, one could rename an archive between another's
+	// rename and save, leaving the file named for one edit and the
+	// stored names from the other. An archive download holds it while
+	// it reads the stored names and lists the files they give, and
+	// again for each file while it finds the file under the names
+	// stored then and opens it.
+	renameMu sync.Mutex
+
 	// dummyVerifications counts the equivalent-cost verifications
 	// charged for usernames that do not exist. It exists so a test
 	// can prove that path runs without measuring wall-clock time.
@@ -138,7 +149,7 @@ func New(
 	s.dbMgr = params.WebhookDBMgr
 	s.session = params.Session
 	s.mw = params.Middleware
-	s.engine = params.Engine
+	s.notifier = params.Notifier
 	s.archives = params.Archives
 	s.breakers = params.CircuitBreakers
 	s.mtr = params.Metrics

internal/handlers/handlers_test.go

@@ -8,7 +8,6 @@ import (
 	"log/slog"
 	"net/http"
 	"net/http/httptest"
-	"strconv"
 	"sync"
 	"testing"
 	"time"
@@ -17,7 +16,6 @@ import (
 	"github.com/stretchr/testify/require"
 	"go.uber.org/fx"
 	"go.uber.org/fx/fxtest"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/config"
 	"sneak.berlin/go/webhooker/internal/database"
 	"sneak.berlin/go/webhooker/internal/delivery"
@@ -30,14 +28,39 @@ import (
 	"sneak.berlin/go/webhooker/internal/session"
 )
 
-// recordingArchives is an archive.Archives that records what it
+// recordingNotifier is a delivery.Notifier that records the tasks it
+// was handed, so a test can prove a handler queued the delivery it
+// claims to have queued — and, on the refusal paths, that it queued
+// nothing.
+type recordingNotifier struct {
+	mu    sync.Mutex
+	tasks []delivery.Task
+}
+
+func (n *recordingNotifier) Notify(tasks []delivery.Task) {
+	n.mu.Lock()
+	defer n.mu.Unlock()
+
+	n.tasks = append(n.tasks, tasks...)
+}
+
+// Tasks returns a copy of the recorded tasks.
+func (n *recordingNotifier) Tasks() []delivery.Task {
+	n.mu.Lock()
+	defer n.mu.Unlock()
+
+	out := make([]delivery.Task, len(n.tasks))
+	copy(out, n.tasks)
+
+	return out
+}
+
+// recordingArchives is a delivery.Archives that records what it
 // was asked to do, so a test can prove that a deletion or rename
-// path reached the archive writers. After FailRenames, every
+// path reached the delivery engine. After FailRenames, every
 // rename of that target fails with the given error. After
 // BlockNextRename, the next rename is recorded and then waits.
-// RenameLock returns a plain mutex, as in archive.Writers.
 type recordingArchives struct {
-	renameMu       sync.Mutex
 	mu             sync.Mutex
 	evicted        []string
 	evictedTargets []string
@@ -50,10 +73,10 @@ type recordingArchives struct {
 // errInjectedRename is the failure a test hands FailRenames.
 var errInjectedRename = errors.New("injected rename failure")
 
-// errNameTaken is what the archive writers return when a file
+// errNameTaken is what the delivery engine returns when a file
 // already has an archive's new name, here archive-taken.db.
 var errNameTaken = fmt.Errorf(
-	"%w: archive-taken.db", archive.ErrNameTaken,
+	"%w: archive-taken.db", delivery.ErrArchiveNameTaken,
 )
 
 // archiveRename is one recorded Rename call.
@@ -63,10 +86,6 @@ type archiveRename struct {
 	TargetName  string
 }
 
-func (r *recordingArchives) RenameLock() *sync.Mutex {
-	return &r.renameMu
-}
-
 func (r *recordingArchives) EvictWebhook(webhookID string) {
 	r.mu.Lock()
 	defer r.mu.Unlock()
@@ -237,17 +256,16 @@ func newTestAppWithConfig(
 			database.NewWebhookDBManager,
 			healthcheck.New,
 			session.New,
-			archive.NewWriters,
+			func() *recordingNotifier {
-			// The engine is built on a lifecycle that is never started,
+				return &recordingNotifier{}
-			// so no worker runs: every delivery the engine creates for a
+			},
-			// handler stays pending, where the test can read it.
+			func(n *recordingNotifier) delivery.Notifier {
-			func(p delivery.EngineParams) *delivery.Engine {
+				return n
-				return delivery.New(fxtest.NewLifecycle(t), p)
 			},
 			func() *recordingArchives {
 				return &recordingArchives{}
 			},
-			func(r *recordingArchives) archive.Archives {
+			func(r *recordingArchives) delivery.Archives {
 				return r
 			},
 			func() *testCircuitBreakers {
@@ -329,7 +347,7 @@ func TestHandleIndex_Authenticated(t *testing.T) {
 	)
 }
 
-func TestSetSlackTargetSettings_AcceptsPublicURL(t *testing.T) {
+func TestBuildSlackTargetConfig_AcceptsPublicURL(t *testing.T) {
 	t.Parallel()
 
 	var h *handlers.Handlers
@@ -339,34 +357,32 @@ func TestSetSlackTargetSettings_AcceptsPublicURL(t *testing.T) {
 
 	t.Cleanup(app.RequireStop)
 
-	const hookURL = "http://93.184.216.34/services/T00/B00/xxx"
+	cfg, errMsg, err := h.BuildSlackTargetConfigForTest(
-
+		t.Context(), "http://93.184.216.34/services/T00/B00/xxx",
-	var target database.Target
-
-	errMsg := h.SetSlackTargetSettingsForTest(t.Context(), &target, hookURL)
-
-	assert.Empty(t, errMsg)
-	assert.Equal(t, hookURL, target.URL)
-}
-
-func TestSetSlackTargetSettings_RejectsReservedURL(t *testing.T) {
-	t.Parallel()
-
-	var h *handlers.Handlers
-
-	app := newTestApp(t, &h)
-	app.RequireStart()
-
-	t.Cleanup(app.RequireStop)
-
-	var target database.Target
-
-	errMsg := h.SetSlackTargetSettingsForTest(
-		t.Context(), &target, "http://169.254.169.254/latest/meta-data/",
 	)
 
+	require.NoError(t, err)
+	assert.Empty(t, errMsg)
+	assert.Contains(t, cfg, "webhookUrl")
+}
+
+func TestBuildSlackTargetConfig_RejectsReservedURL(t *testing.T) {
+	t.Parallel()
+
+	var h *handlers.Handlers
+
+	app := newTestApp(t, &h)
+	app.RequireStart()
+
+	t.Cleanup(app.RequireStop)
+
+	cfg, errMsg, err := h.BuildSlackTargetConfigForTest(
+		t.Context(), "http://169.254.169.254/latest/meta-data/",
+	)
+
+	require.NoError(t, err)
 	assert.Contains(t, errMsg, "Invalid target URL")
-	assert.Empty(t, target.URL)
+	assert.Empty(t, cfg)
 }
 
 func TestRenderTemplate(t *testing.T) {
@@ -460,100 +476,72 @@ func TestRenderTemplateMidRenderErrorSendsNoPartialBody(t *testing.T) {
 	)
 }
 
-func TestSetDatabaseTargetSettings_Valid(t *testing.T) {
+func TestBuildDatabaseTargetConfig_Valid(t *testing.T) {
 	t.Parallel()
 
-	cases := []struct {
+	// Empty expiry and rotation: the keep-forever, one-file default,
-		expiry, rotation string
+	// empty config.
-		wantExpiry       time.Duration
+	cfg, errMsg, err := handlers.BuildDatabaseTargetConfigForTest("", "")
-		wantRotation     string
+	require.NoError(t, err)
-	}{
+	assert.Empty(t, errMsg)
-		// Empty expiry and rotation: the keep-forever, one-file
+	assert.Empty(t, cfg)
-		// default.
-		{"", "", 0, rotationNone},
-		{expiryNever, "", 0, rotationNone},
-		{" 36h ", "", 36 * time.Hour, rotationNone},
-		{"", rotationDaily, 0, rotationDaily},
-		{"90m", rotationHourly, 90 * time.Minute, rotationHourly},
-	}
 
-	for _, tc := range cases {
+	// Explicit never is stored as config.
-		var target database.Target
+	cfg, errMsg, err = handlers.BuildDatabaseTargetConfigForTest("never", "")
+	require.NoError(t, err)
+	assert.Empty(t, errMsg)
+	assert.JSONEq(t, `{"expiry":"never"}`, cfg)
 
-		errMsg := handlers.SetDatabaseTargetSettingsForTest(
+	// A positive duration is stored as config.
-			&target, tc.expiry, tc.rotation,
+	cfg, errMsg, err = handlers.BuildDatabaseTargetConfigForTest("720h", "")
-		)
+	require.NoError(t, err)
+	assert.Empty(t, errMsg)
+	assert.JSONEq(t, `{"expiry":"720h"}`, cfg)
 
-		assert.Empty(t, errMsg, tc)
+	// A rotation is stored as config, with or without an expiry.
-		assert.Equal(t, tc.wantExpiry, target.ArchiveExpiry, tc)
+	cfg, errMsg, err = handlers.BuildDatabaseTargetConfigForTest("", "daily")
-		assert.Equal(t, tc.wantRotation, target.ArchiveRotation, tc)
+	require.NoError(t, err)
-	}
+	assert.Empty(t, errMsg)
+	assert.JSONEq(t, `{"rotation":"daily"}`, cfg)
+
+	cfg, errMsg, err = handlers.BuildDatabaseTargetConfigForTest(
+		"720h", "hourly",
+	)
+	require.NoError(t, err)
+	assert.Empty(t, errMsg)
+	assert.JSONEq(t, `{"expiry":"720h","rotation":"hourly"}`, cfg)
 }
 
-// TestSetDatabaseTargetSettings_RejectsBadExpiry pins each refusal's
+func TestBuildDatabaseTargetConfig_RejectsBadExpiry(
-// whole message, as the form shows it.
-func TestSetDatabaseTargetSettings_RejectsBadExpiry(
 	t *testing.T,
 ) {
 	t.Parallel()
 
-	cases := map[string]string{
+	for _, bad := range []string{"nonsense", "7d", "-5h"} {
-		"nonsense": `Invalid archive expiry: expiry must be "never" or ` +
+		cfg, errMsg, err := handlers.BuildDatabaseTargetConfigForTest(bad, "")
-			`a Go duration such as "720h": time: invalid duration ` +
-			`"nonsense"`,
-		"7d": `Invalid archive expiry: expiry must be "never" or a Go ` +
-			`duration such as "720h": time: unknown unit "d" in ` +
-			`duration "7d"`,
-		"-5h": `Invalid archive expiry: expiry must be a positive ` +
-			`duration or "never": "-5h"`,
-	}
 
-	for bad, want := range cases {
+		require.NoError(t, err)
-		var target database.Target
+		assert.Contains(
-
+			t, errMsg, "Invalid archive expiry",
-		errMsg := handlers.SetDatabaseTargetSettingsForTest(
+			"expiry %q should be refused", bad,
-			&target, bad, "",
 		)
-
+		assert.Empty(t, cfg)
-		assert.Equal(t, want, errMsg, "expiry %q", bad)
 	}
 }
 
-func TestSetDatabaseTargetSettings_RejectsBadRotation(
+func TestBuildDatabaseTargetConfig_RejectsBadRotation(
 	t *testing.T,
 ) {
 	t.Parallel()
 
 	for _, bad := range []string{"weekly", "Daily", " none"} {
-		var target database.Target
+		cfg, errMsg, err := handlers.BuildDatabaseTargetConfigForTest("", bad)
 
-		errMsg := handlers.SetDatabaseTargetSettingsForTest(
+		require.NoError(t, err)
-			&target, "", bad,
+		assert.Contains(
-		)
+			t, errMsg, "Invalid archive rotation",
-
+			"rotation %q should be refused", bad,
-		assert.Equal(
-			t,
-			"Invalid archive rotation: rotation must be none, "+
-				"monthly, daily or hourly: "+strconv.Quote(bad),
-			errMsg,
 		)
-	}
+		assert.Empty(t, cfg)
-}
-
-// TestFormatArchiveExpiry covers the expiries the expiry choices do
-// not: TestArchiveExpiryChoices shows the edit form starting on each
-// choice. An expiry in whole hours is written in hours, and any other
-// as Go writes it, which the form accepts back unchanged.
-func TestFormatArchiveExpiry(t *testing.T) {
-	t.Parallel()
-
-	cases := map[time.Duration]string{
-		0:                expiryNever,
-		36 * time.Hour:   "36h",
-		90 * time.Minute: "1h30m0s",
-	}
-
-	for expiry, want := range cases {
-		assert.Equal(t, want, handlers.FormatArchiveExpiryForTest(expiry))
 	}
 }

internal/handlers/logbound_test.go

@@ -1,15 +1,19 @@
 package handlers_test
 
-// The handler-side half of the log-field audit. The slog calls in
+// The handler-side half of the log-field audit. Two slog calls in
-// this package that reach a value an UNAUTHENTICATED client picks
+// this package reach a value an UNAUTHENTICATED client picks outright
-// outright, and of a length it picks outright, are the failed-login
+// and of a length it picks outright:
-// DEBUG lines, whose username is a form field.
 //
-// They are at DEBUG, which is off in production by default. That is
+//   - the unknown-entrypoint DEBUG line on /h/{uuid}, whose
+//     path segment matched no stored entrypoint and so is bounded by
+//     nothing;
+//   - the failed-login DEBUG lines, whose username is a form field.
+//
+// Both are at DEBUG, which is off in production by default. That is
 // not a bound: an operator turning DEBUG on to diagnose a flood must
-// not thereby hand the flood an unbounded write. They spend the same
+// not thereby hand the flood an unbounded write. Both spend the same
-// internal/logfield budget as the access log, and are held here to
+// internal/logfield budget as the access log, and both are held here
-// middleware.MaxAccessLogLineBytes.
+// to middleware.MaxAccessLogLineBytes.
 //
 // The two login lines past the username lookup — "invalid password"
 // and "user logged in" — carry the same cap without needing it, since
@@ -191,12 +195,13 @@ func receiverRouter(h *handlers.Handlers) *chi.Mux {
 	return router
 }
 
-// postReceiver sends one POST with an empty body at /h/<segment>
+// postReceiver sends one POST at /h/<segment>.
-// through router and returns the response status.
 //
 // RawPath is cleared after parsing so chi routes on the decoded path
 // and the handler sees the raw bytes rather than their percent-escaped
-// spelling.
+// spelling. That is the harder case for the budget: the escaped
+// spelling is plain ASCII, which costs one byte per byte, while the
+// decoded bytes are what the log handler has to escape.
 func postReceiver(
 	t *testing.T, router *chi.Mux, segment string,
 ) int {
@@ -255,6 +260,43 @@ func postLoginWithPassword(
 	return w.Code
 }
 
+// TestUnknownEntrypoint_LogLineDoesNotTrackPathSize drives 8 KB of
+// client-chosen path at the unauthenticated receiver's
+// unknown-entrypoint DEBUG line and holds it to the same ceiling the
+// access log states.
+func TestUnknownEntrypoint_LogLineDoesNotTrackPathSize(t *testing.T) {
+	t.Parallel()
+
+	for handlerName, newHandler := range logHandlers() {
+		for fillName, fill := range escapeFills() {
+			t.Run(handlerName+"/"+fillName, func(t *testing.T) {
+				t.Parallel()
+
+				h, buf := capturingHandlers(t, newHandler)
+				router := receiverRouter(h)
+
+				for i := range floodRequests {
+					assert.Equal(
+						t,
+						http.StatusNotFound,
+						postReceiver(
+							t, router,
+							oversizedFill(fill)+
+								strings.Repeat("y", i),
+						),
+					)
+				}
+
+				lines := logLines(t, buf)
+				require.Len(t, lines, floodRequests)
+				assertNoClientText(t, buf)
+
+				assertBoundedFlood(t, buf.Len())
+			})
+		}
+	}
+}
+
 // TestFailedLogin_LogLineDoesNotTrackUsernameSize drives 8 KB of
 // client-chosen username at the unauthenticated login endpoint's
 // DEBUG line and holds it to the same ceiling.

internal/handlers/shared.go

@@ -16,16 +16,21 @@ import (
 //
 // An empty value yields fallback, which lets the create path apply the
 // default and the edit path leave the stored value unchanged. A value
-// of 0 means retain events forever and is returned as it is. Anything
+// of 0 is returned as 0 and is rewritten to the retain-forever
-// unparseable or negative is refused rather than silently given a
+// sentinel by database.Webhook's BeforeSave hook. Anything unparseable
-// default.
+// or negative is refused rather than silently given a default.
 //
 // The upper bound is not cosmetic. The reaper computes its cutoff as a
 // time.Duration, an int64 nanosecond count, so a day count above
 // database.MaxFiniteRetentionDays overflows, puts the cutoff in the
-// future, and deletes every event the webhook has. A value above that
+// future, and deletes every event the webhook has. A finite value
-// ceiling is therefore refused, and the message names the ceiling
+// above that ceiling is therefore refused, and the message names the
-// rather than implying the input was not a number.
+// ceiling rather than implying the input was not a number.
+//
+// A value at or above the retain-forever sentinel is not out of range:
+// it is what the edit form pre-fills for a retain-forever webhook, so
+// submitting the form back unchanged has to keep meaning "forever"
+// rather than being rejected.
 func parseRetentionDays(raw string, fallback int) (int, string) {
 	raw = strings.TrimSpace(raw)
 	if raw == "" {
@@ -38,6 +43,10 @@ func parseRetentionDays(raw string, fallback int) (int, string) {
 			"retain events forever."
 	}
 
+	if v >= database.RetentionForeverDays {
+		return database.RetentionForeverDays, ""
+	}
+
 	if v > database.MaxFiniteRetentionDays {
 		return 0, "Retention must be at most " +
 			strconv.Itoa(database.MaxFiniteRetentionDays) +

internal/handlers/source_create_targets_test.go

@@ -7,7 +7,6 @@ import (
 	"net/http/httptest"
 	"net/url"
 	"testing"
-	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -55,26 +54,15 @@ func TestHandleSourceCreateSubmit_CreatesRequestedTargets(t *testing.T) {
 
 	env := setupSourceTest(t)
 
-	// Each value the archive pruning choice submits and the expiry it
+	// Each value the archive pruning choice submits, after an empty
-	// stores, after an empty one that stands for the archive checkbox
+	// one that stands for the archive checkbox left off.
-	// left off.
+	expiries := []string{
-	expiries := []struct {
+		"", "never", "1h", "12h", "24h", "720h", "2160h", "8760h",
-		value  string
-		stored time.Duration
-	}{
-		{"", 0},
-		{expiryNever, 0},
-		{"1h", time.Hour},
-		{"12h", 12 * time.Hour},
-		{"24h", 24 * time.Hour},
-		{"720h", 720 * time.Hour},
-		{"2160h", 2160 * time.Hour},
-		{"8760h", 8760 * time.Hour},
 	}
 
 	for _, httpURL := range []string{"", editOriginalURL} {
 		for _, expiry := range expiries {
-			name := "url=" + httpURL + " archive=" + expiry.value
+			name := "url=" + httpURL + " archive=" + expiry
 
 			t.Run(name, func(t *testing.T) {
 				t.Parallel()
@@ -84,9 +72,9 @@ func TestHandleSourceCreateSubmit_CreatesRequestedTargets(t *testing.T) {
 				form.Set("http_url", httpURL)
 				form.Set("archive_expiry", "720h")
 
-				if expiry.value != "" {
+				if expiry != "" {
 					form.Set("archive", "on")
-					form.Set("archive_expiry", expiry.value)
+					form.Set("archive_expiry", expiry)
 				}
 
 				w := submitCreateForm(env, form)
@@ -108,16 +96,17 @@ func TestHandleSourceCreateSubmit_CreatesRequestedTargets(t *testing.T) {
 					wantCount++
 
 					assert.Equal(t, "HTTP", byType[database.TargetTypeHTTP].Name)
-					assert.Equal(t, httpURL, byType[database.TargetTypeHTTP].URL)
+					assert.JSONEq(t, `{"url":"`+httpURL+`"}`,
+						byType[database.TargetTypeHTTP].Config)
 				}
 
-				if expiry.value != "" {
+				if expiry != "" {
 					wantCount++
 
 					assert.Equal(t, "Archive",
 						byType[database.TargetTypeDatabase].Name)
-					assert.Equal(t, expiry.stored,
+					assert.JSONEq(t, `{"expiry":"`+expiry+`"}`,
-						byType[database.TargetTypeDatabase].ArchiveExpiry)
+						byType[database.TargetTypeDatabase].Config)
 				}
 
 				assert.Len(t, byType, wantCount)

internal/handlers/source_delete_test.go

@@ -16,8 +16,8 @@ import (
 	"github.com/stretchr/testify/require"
 	"gorm.io/gorm"
 	"gorm.io/gorm/clause"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
+	"sneak.berlin/go/webhooker/internal/delivery"
 	"sneak.berlin/go/webhooker/internal/handlers"
 	"sneak.berlin/go/webhooker/internal/session"
 )
@@ -64,11 +64,10 @@ func seedTarget(
 	t.Helper()
 
 	tgt := &database.Target{
-		WebhookID:   webhookID,
+		WebhookID: webhookID,
-		Name:        "t-" + string(targetType),
+		Name:      "t-" + string(targetType),
-		Type:        targetType,
+		Type:      targetType,
-		Active:      true,
+		Active:    true,
-		MaxAttempts: 1,
 	}
 
 	require.NoError(
@@ -180,7 +179,7 @@ func failSaveOnTable(
 }
 
 // archivePathFor returns the archive database path the
-// archive writers would use for a database target: beside the
+// delivery engine would use for a database target: beside the
 // webhook's event database in the data directory.
 func archivePathFor(
 	t *testing.T,
@@ -192,7 +191,7 @@ func archivePathFor(
 
 	return filepath.Join(
 		filepath.Dir(mgr.DBPath(wh.ID)),
-		archive.FileName(wh.Name, tgt.Name, tgt.ID),
+		delivery.ArchiveFileName(wh.Name, tgt.Name, tgt.ID),
 	)
 }
 
@@ -228,9 +227,9 @@ func postRequest(
 }
 
 // TestHandleSourceDelete_EvictsArchiveWriter proves that
-// deleting a webhook releases the webhook's archive writers,
+// deleting a webhook reaches the delivery engine and releases
-// exercised through the real deletion handler rather than by
+// the webhook's archive writers, exercised through the real
-// calling the archive writers directly.
+// deletion handler rather than by calling the engine directly.
 func TestHandleSourceDelete_EvictsArchiveWriter(t *testing.T) {
 	t.Parallel()
 
@@ -290,7 +289,7 @@ func TestHandleSourceDelete_KeepsArchiveFile(t *testing.T) {
 	wh := seedWebhook(t, db)
 	tgt := seedTarget(t, db, wh.ID, database.TargetTypeDatabase)
 
-	// Place an archive file where the archive writers would.
+	// Place an archive file where the delivery engine would.
 	archivePath := archivePathFor(t, mgr, wh, tgt)
 	require.NoError(
 		t,

internal/handlers/source_detail_test.go

@@ -5,7 +5,6 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"testing"
-	"time"
 
 	"github.com/go-chi/chi"
 	"github.com/stretchr/testify/assert"
@@ -26,24 +25,24 @@ const (
 		slackSecretPath
 )
 
-// seedConfiguredTarget inserts an active target of targetType with
+// seedConfiguredTarget inserts a target with a stored config
-// the settings (URL to ArchiveRotation) that settings carries, and
+// blob and returns it.
-// returns it.
 func seedConfiguredTarget(
 	t *testing.T,
 	db *database.Database,
 	webhookID string,
 	targetType database.TargetType,
-	settings database.Target,
+	config string,
 ) *database.Target {
 	t.Helper()
 
-	tgt := &settings
+	tgt := &database.Target{
-	tgt.WebhookID = webhookID
+		WebhookID: webhookID,
-	tgt.Name = "t-" + string(targetType)
+		Name:      "t-" + string(targetType),
-	tgt.Type = targetType
+		Type:      targetType,
-	tgt.Active = true
+		Active:    true,
-	tgt.MaxAttempts = 1
+		Config:    config,
+	}
 
 	require.NoError(
 		t,
@@ -108,59 +107,89 @@ func serveSourceDetailPage(
 	return w
 }
 
-// TestHandleSourceDetail_MasksTargetURL is the load-bearing
+// TestHandleSourceDetail_MasksSlackWebhookURL is the
-// regression test for the credential leak: the rendered page must
+// load-bearing regression test for the credential leak: the
-// show a Slack target, and an http target, without any of the secret
+// rendered page must show the Slack target without any of the
-// path segments of its URL. An http target's destination is routinely
+// secret path segments of its webhook URL.
-// an incoming-webhook endpoint too, so the same Slack URL serves for
+func TestHandleSourceDetail_MasksSlackWebhookURL(t *testing.T) {
-// both.
-func TestHandleSourceDetail_MasksTargetURL(t *testing.T) {
 	t.Parallel()
 
-	labels := map[database.TargetType]string{
+	var (
-		database.TargetTypeSlack: "Webhook URL",
+		h    *handlers.Handlers
-		database.TargetTypeHTTP:  "Destination URL",
+		sess *session.Session
-	}
+		db   *database.Database
+	)
 
-	for targetType, label := range labels {
+	app := newTestApp(t, &h, &sess, &db)
-		t.Run(string(targetType), func(t *testing.T) {
+	app.RequireStart()
-			t.Parallel()
 
-			var (
+	t.Cleanup(app.RequireStop)
-				h    *handlers.Handlers
-				sess *session.Session
-				db   *database.Database
-			)
 
-			app := newTestApp(t, &h, &sess, &db)
+	wh := seedWebhook(t, db)
-			app.RequireStart()
+	seedConfiguredTarget(
+		t, db, wh.ID,
+		database.TargetTypeSlack,
+		`{"webhookUrl":"`+slackWebhookURL+`"}`,
+	)
 
-			t.Cleanup(app.RequireStop)
+	body := renderSourceDetailPage(t, h, sess, wh.ID)
 
-			wh := seedWebhook(t, db)
+	assert.NotContains(t, body, slackSecretPath)
-			seedConfiguredTarget(
+	assert.NotContains(t, body, "T00000000")
-				t, db, wh.ID, targetType,
+	assert.NotContains(t, body, "B00000000")
-				database.Target{URL: slackWebhookURL},
+	assert.NotContains(
-			)
+		t, body, "XXXXXXXXXXXXXXXXXXXXXXXX",
+	)
+	assert.NotContains(t, body, "webhookUrl")
 
-			body := renderSourceDetailPage(t, h, sess, wh.ID)
+	assert.Contains(t, body, "Webhook URL")
+	assert.Contains(t, body, "https://hooks.slack.com/...")
+}
 
-			assert.NotContains(t, body, slackSecretPath)
+// TestHandleSourceDetail_MasksHTTPDestinationURL is the
-			assert.NotContains(t, body, "T00000000")
+// regression test for the same leak reached through the http
-			assert.NotContains(t, body, "B00000000")
+// target: its destination is routinely an incoming-webhook
-			assert.NotContains(
+// endpoint whose path segments are the credential, so the
-				t, body, "XXXXXXXXXXXXXXXXXXXXXXXX",
+// rendered page must not contain them.
-			)
+func TestHandleSourceDetail_MasksHTTPDestinationURL(
+	t *testing.T,
+) {
+	t.Parallel()
 
-			assert.Contains(t, body, label)
+	var (
-			assert.Contains(t, body, "https://hooks.slack.com/...")
+		h    *handlers.Handlers
-		})
+		sess *session.Session
-	}
+		db   *database.Database
+	)
+
+	app := newTestApp(t, &h, &sess, &db)
+	app.RequireStart()
+
+	t.Cleanup(app.RequireStop)
+
+	wh := seedWebhook(t, db)
+	seedConfiguredTarget(
+		t, db, wh.ID,
+		database.TargetTypeHTTP,
+		`{"url":"`+slackWebhookURL+`"}`,
+	)
+
+	body := renderSourceDetailPage(t, h, sess, wh.ID)
+
+	assert.NotContains(t, body, slackSecretPath)
+	assert.NotContains(t, body, "T00000000")
+	assert.NotContains(t, body, "B00000000")
+	assert.NotContains(
+		t, body, "XXXXXXXXXXXXXXXXXXXXXXXX",
+	)
+
+	assert.Contains(t, body, "Destination URL")
+	assert.Contains(t, body, "https://hooks.slack.com/...")
 }
 
 // TestHandleSourceDetail_RendersNamedTargetFields proves the
 // other target types render labelled fields rather than the
-// stored values.
+// stored blob.
 func TestHandleSourceDetail_RendersNamedTargetFields(
 	t *testing.T,
 ) {
@@ -182,24 +211,18 @@ func TestHandleSourceDetail_RendersNamedTargetFields(
 	seedConfiguredTarget(
 		t, db, wh.ID,
 		database.TargetTypeHTTP,
-		database.Target{
+		`{"url":"https://example.com/hook","timeout":30,`+
-			URL:            "https://example.com/hook",
+			`"headers":{"Authorization":"Bearer sekrit"}}`,
-			TimeoutSeconds: 30,
-			Headers:        map[string]string{"X-Api-Key": "sekrit"},
-		},
 	)
 	seedConfiguredTarget(
 		t, db, wh.ID,
 		database.TargetTypeDatabase,
-		database.Target{
+		`{"expiry":"720h"}`,
-			ArchiveExpiry:   720 * time.Hour,
-			ArchiveRotation: rotationNone,
-		},
 	)
 	seedConfiguredTarget(
 		t, db, wh.ID,
 		database.TargetType("carrier-pigeon"),
-		database.Target{URL: "https://pigeon.example/beak"},
+		`{"beak":"sharp"}`,
 	)
 
 	body := renderSourceDetailPage(t, h, sess, wh.ID)
@@ -218,8 +241,8 @@ func TestHandleSourceDetail_RendersNamedTargetFields(
 	assert.Contains(t, list, "Archive rotation: none")
 	assert.Contains(t, body, `<option value="database">Archive</option>`)
 
-	// An unknown type gets the neutral placeholder, never its
+	// An unknown type gets the neutral placeholder, never the
-	// stored URL.
+	// stored blob.
 	assert.Contains(t, body, "(unavailable)")
 	assert.NotContains(t, body, "beak")
 }
@@ -250,7 +273,7 @@ func TestHandleSourceDetail_FitsWideAndNarrowWindows(t *testing.T) {
 
 	assert.Contains(
 		t, body,
-		`<div class="max-w-[108rem] mx-auto px-6 py-8">`,
+		`<div class="mx-auto px-6 py-8" style="max-width: 108rem"`,
 	)
 	assert.Contains(
 		t, body,
@@ -263,8 +286,8 @@ func TestHandleSourceDetail_FitsWideAndNarrowWindows(t *testing.T) {
 // target and says what deleting it loses, that the webhook's gives its
 // number of stored events (5 received, 2 removed by retention, so 3,
 // the statistics pane's "Within retention" figure), and that an
-// entrypoint with no description is named by its URL. Each prompt is
+// entrypoint with no description is named by its URL. The template
-// its form's data-confirm attribute, where &#10; is a line break.
+// writes the slashes after http: as \/, which the browser reads as /.
 func TestHandleSourceDetail_DeletePromptsNameWhatIsLost(t *testing.T) {
 	t.Parallel()
 
@@ -302,28 +325,29 @@ func TestHandleSourceDetail_DeletePromptsNameWhatIsLost(t *testing.T) {
 	body := renderSourceDetailPage(t, h, sess, wh.ID)
 
 	assert.Contains(t, body,
-		`data-confirm="Delete webhook &quot;delete-me&quot;?&#10;&#10;`+
+		`Delete webhook &quot;delete-me&quot;?\n\n`+
 			`This deletes its stored events (3) and their deliveries. `+
-			`Any archive files it wrote are kept."`)
+			`Any archive files it wrote are kept.`)
 	assert.Contains(t, body,
-		`data-confirm="Delete entrypoint &quot;Stripe&quot;?&#10;&#10;`+
+		`Delete entrypoint &quot;Stripe&quot;?\n\n`+
 			`Senders using its URL get an error from now on, `+
-			`and the URL cannot be restored."`)
+			`and the URL cannot be restored.`)
 	assert.Contains(t, body,
-		`data-confirm="Delete entrypoint &quot;http://example.com/h/`+
+		`Delete entrypoint &quot;http:\/\/example.com/h/`+
-			unnamed.Path+`&quot;?&#10;&#10;`)
+			unnamed.Path+`&quot;?`)
 	assert.Contains(t, body,
-		`data-confirm="Delete target &quot;t-log&quot;?&#10;&#10;`+
+		`Delete target &quot;t-log&quot;?\n\n`+
 			`Nothing more is delivered to it. `+
-			`Its past deliveries stay in the event log."`)
+			`Its past deliveries stay in the event log.`)
 }
 
 // TestHandleSourceDetail_DeletePromptKeepsQuotesInName checks that a
 // webhook name with quotes, a backslash, a closing script tag and a
-// newline reaches its delete prompt escaped for the attribute, which
+// newline reaches its delete prompt escaped for the script, which the
-// the browser reads back as the name typed: each quote and angle
+// browser reads back as the name typed: each quote and angle bracket
-// bracket as a character reference, the rest as typed. An unescaped
+// as a \u escape, the slash as \/, the newline as \n and the backslash
-// double quote would end the attribute and cut the prompt short.
+// doubled. An unescaped newline would break the prompt's script, and
+// the form would then submit without asking.
 func TestHandleSourceDetail_DeletePromptKeepsQuotesInName(t *testing.T) {
 	t.Parallel()
 
@@ -349,6 +373,6 @@ func TestHandleSourceDetail_DeletePromptKeepsQuotesInName(t *testing.T) {
 	body := renderSourceDetailPage(t, h, sess, wh.ID)
 
 	assert.Contains(t, body,
-		"Delete webhook &quot;Bob&#39;s &#34;best&#34; \\ hook"+
+		"Delete webhook &quot;Bob\\u0027s \\u0022best\\u0022 \\\\ hook"+
-			"&lt;/script&gt;\nline two&quot;?")
+			"\\u003c\\/script\\u003e\\nline two&quot;?")
 }

internal/handlers/source_logs_deleted_target_test.go

@@ -161,7 +161,7 @@ func TestHandleSourceLogs_MasksDeletedTargetConfig(t *testing.T) {
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID,
 		database.TargetTypeSlack,
-		database.Target{URL: slackWebhookURL},
+		`{"webhookUrl":"`+slackWebhookURL+`"}`,
 	)
 
 	seedDeliveredEvent(t, dbMgr, wh.ID, tgt.ID)
@@ -175,6 +175,7 @@ func TestHandleSourceLogs_MasksDeletedTargetConfig(t *testing.T) {
 	assert.NotContains(
 		t, body, "XXXXXXXXXXXXXXXXXXXXXXXX",
 	)
+	assert.NotContains(t, body, "webhookUrl")
 
 	// The name is there; only the credential is not.
 	assert.Contains(t, body, tgt.Name+deletedMarker)

internal/handlers/source_logs_test.go

@@ -138,7 +138,7 @@ func TestHandleSourceLogs_MasksSlackWebhookURL(t *testing.T) {
 	tgt := seedConfiguredTarget(
 		t, db, wh.ID,
 		database.TargetTypeSlack,
-		database.Target{URL: slackWebhookURL},
+		`{"webhookUrl":"`+slackWebhookURL+`"}`,
 	)
 
 	seedDeliveredEvent(t, dbMgr, wh.ID, tgt.ID)
@@ -151,6 +151,7 @@ func TestHandleSourceLogs_MasksSlackWebhookURL(t *testing.T) {
 	assert.NotContains(
 		t, body, "XXXXXXXXXXXXXXXXXXXXXXXX",
 	)
+	assert.NotContains(t, body, "webhookUrl")
 
 	// The page still identifies the delivery's target.
 	assert.Contains(t, body, tgt.Name)

internal/handlers/source_management_test.go

@@ -137,7 +137,8 @@ func onlyWebhook(
 }
 
 // seedWebhookWithRetention inserts a webhook owned by the test user
-// with the given retention.
+// with an exact stored retention value, bypassing Webhook.BeforeSave
+// via a column-level update so that legacy rows can be planted too.
 func seedWebhookWithRetention(
 	t *testing.T,
 	db *database.Database,
@@ -154,6 +155,13 @@ func seedWebhookWithRetention(
 		t,
 		db.DB().Omit(clause.Associations).Create(wh).Error,
 	)
+	require.NoError(
+		t,
+		db.DB().Model(wh).
+			Update("retention_days", retentionDays).Error,
+	)
+
+	wh.RetentionDays = retentionDays
 
 	return *wh
 }
@@ -217,9 +225,10 @@ func setupSourceTest(t *testing.T) *sourceTestEnv {
 	}
 }
 
-// TestHandleSourceCreateSubmit_ZeroRetentionPersistsForever checks
+// TestHandleSourceCreateSubmit_ZeroRetentionPersistsForever is the core
-// that the create form's 0 reaches the database as 0, which means
+// regression test for the bug: the create form's 0 must reach the
-// retain forever.
+// database as the retain-forever sentinel rather than being replaced by
+// the column's default of 30.
 func TestHandleSourceCreateSubmit_ZeroRetentionPersistsForever(
 	t *testing.T,
 ) {
@@ -232,60 +241,35 @@ func TestHandleSourceCreateSubmit_ZeroRetentionPersistsForever(
 	require.Equal(t, http.StatusSeeOther, w.Code)
 
 	wh := onlyWebhook(t, env.db)
-	assert.Equal(t, 0, storedRetentionDays(t, env.db, wh.ID))
+	assert.Equal(
+		t,
+		database.RetentionForeverDays,
+		storedRetentionDays(t, env.db, wh.ID),
+	)
 	assert.True(t, wh.RetainsForever())
 }
 
-func TestHandleSourceCreateSubmit_DayCountIsStored(t *testing.T) {
+func TestHandleSourceCreateSubmit_OmittedRetentionUsesDefault(
-	t.Parallel()
-
-	env := setupSourceTest(t)
-	days := "45"
-
-	w := submitCreate(t, env.handlers, env.cookies, "finite", &days)
-	require.Equal(t, http.StatusSeeOther, w.Code)
-
-	wh := onlyWebhook(t, env.db)
-	assert.Equal(t, 45, storedRetentionDays(t, env.db, wh.ID))
-}
-
-// TestHandleSourceCreateSubmit_BlankRetentionUsesDefault covers a
-// retention field left empty and one missing from the form: both
-// give the default, not forever.
-func TestHandleSourceCreateSubmit_BlankRetentionUsesDefault(
 	t *testing.T,
 ) {
 	t.Parallel()
 
-	blank := ""
+	env := setupSourceTest(t)
 
-	for name, retention := range map[string]*string{
+	w := submitCreate(t, env.handlers, env.cookies, "defaulted", nil)
-		"blank":   &blank,
+	require.Equal(t, http.StatusSeeOther, w.Code)
-		"omitted": nil,
-	} {
-		t.Run(name, func(t *testing.T) {
-			t.Parallel()
 
-			env := setupSourceTest(t)
+	wh := onlyWebhook(t, env.db)
-
+	assert.Equal(
-			w := submitCreate(
+		t,
-				t, env.handlers, env.cookies, "defaulted", retention,
+		database.DefaultRetentionDays,
-			)
+		storedRetentionDays(t, env.db, wh.ID),
-			require.Equal(t, http.StatusSeeOther, w.Code)
+	)
-
-			wh := onlyWebhook(t, env.db)
-			assert.Equal(
-				t,
-				database.DefaultRetentionDays,
-				storedRetentionDays(t, env.db, wh.ID),
-			)
-		})
-	}
 }
 
-// TestHandleSourceCreate_PrefillsDefaultFromConstant checks that the
+// TestHandleSourceCreate_PrefillsDefaultFromConstant keeps the create
-// create form pre-fills its retention from database.DefaultRetentionDays
+// form's pre-filled retention from becoming a third hardcoded copy of
-// rather than from a hardcoded 30.
+// the 30-day policy.
 func TestHandleSourceCreate_PrefillsDefaultFromConstant(t *testing.T) {
 	t.Parallel()
 
@@ -306,7 +290,7 @@ func TestHandleSourceCreate_PrefillsDefaultFromConstant(t *testing.T) {
 	)
 	assert.NotContains(
 		t, body, `max="365"`,
-		"a max of 365 would block any longer retention",
+		"a max below the sentinel would block retain-forever",
 	)
 	assert.Contains(t, body, `min="0"`)
 }
@@ -384,6 +368,40 @@ func TestHandleSourceCreateSubmit_OverflowingRetentionIsRejected(
 	)
 }
 
+// TestHandleSourceCreateSubmit_SentinelIsAcceptedAsForever guards the
+// boundary between "too large to represent" and "retain forever": the
+// sentinel is above MaxFiniteRetentionDays, but it is the value the
+// edit form pre-fills, so it must be accepted rather than rejected as
+// out of range. A value above the sentinel is stored as the sentinel.
+func TestHandleSourceCreateSubmit_SentinelIsAcceptedAsForever(
+	t *testing.T,
+) {
+	t.Parallel()
+
+	for _, days := range []int{
+		database.RetentionForeverDays,
+		database.RetentionForeverDays + 1,
+	} {
+		raw := strconv.Itoa(days)
+
+		t.Run(raw, func(t *testing.T) {
+			t.Parallel()
+
+			env := setupSourceTest(t)
+
+			w := submitCreate(t, env.handlers, env.cookies, "forever", &raw)
+			require.Equal(t, http.StatusSeeOther, w.Code)
+
+			wh := onlyWebhook(t, env.db)
+			assert.Equal(
+				t,
+				database.RetentionForeverDays,
+				storedRetentionDays(t, env.db, wh.ID),
+			)
+		})
+	}
+}
+
 // TestHandleSourceCreateSubmit_RejectedFormKeepsUserInput checks that a
 // validation failure hands the user's typing back, matching what the
 // edit form already does. Losing a long description to a mistyped
@@ -462,7 +480,11 @@ func TestHandleSourceEditSubmit_ZeroRetentionPersistsForever(
 	w := submitEdit(t, env, wh, "0")
 	require.Equal(t, http.StatusSeeOther, w.Code)
 
-	assert.Equal(t, 0, storedRetentionDays(t, env.db, wh.ID))
+	assert.Equal(
+		t,
+		database.RetentionForeverDays,
+		storedRetentionDays(t, env.db, wh.ID),
+	)
 }
 
 func TestHandleSourceEditSubmit_InvalidRetentionIsRejected(
@@ -845,15 +867,18 @@ func TestHandleSourceEditSubmit_ArchiveNameTaken(t *testing.T) {
 	assert.Equal(t, oldName, stored.Name)
 }
 
-// TestSourceEditForm_ForeverWebhookRoundTrips renders the edit form for
+// TestSourceEditForm_ForeverWebhookRoundTrips walks the exact path that
-// a retain-forever webhook, confirms it pre-fills 0, then submits that
+// the removed max="365" cap used to break: render the edit form for a
-// pre-filled value straight back and confirms the retention policy
+// retain-forever webhook, confirm the pre-filled sentinel is not capped
-// survives untouched.
+// by browser validation, then submit that pre-filled value straight
+// back and confirm the retention policy survives untouched.
 func TestSourceEditForm_ForeverWebhookRoundTrips(t *testing.T) {
 	t.Parallel()
 
 	env := setupSourceTest(t)
-	wh := seedWebhookWithRetention(t, env.db, 0)
+	wh := seedWebhookWithRetention(
+		t, env.db, database.RetentionForeverDays,
+	)
 
 	req := getRequest(
 		t, "/hook/"+wh.ID+"/edit", env.cookies,
@@ -864,12 +889,17 @@ func TestSourceEditForm_ForeverWebhookRoundTrips(t *testing.T) {
 
 	require.Equal(t, http.StatusOK, w.Code)
 
+	sentinel := strconv.Itoa(database.RetentionForeverDays)
 	body := w.Body.String()
 
 	assert.Contains(
-		t, body, `name="retention_days" value="0"`,
+		t, body, `value="`+sentinel+`"`,
 		"the edit form pre-fills the stored retention",
 	)
+	assert.NotContains(
+		t, body, `max="365"`,
+		"a max below the sentinel would block saving any edit",
+	)
 	// "Currently forever." is the rendered RetentionLabel, not the
 	// static hint below the input, which says "Enter 0 to retain events
 	// forever." A bare Contains of "forever" would pass for any
@@ -880,20 +910,29 @@ func TestSourceEditForm_ForeverWebhookRoundTrips(t *testing.T) {
 	)
 
 	// Submit the pre-filled value back, exactly as a browser would.
-	post := submitEdit(t, env, wh, "0")
+	post := submitEdit(t, env, wh, sentinel)
 	require.Equal(t, http.StatusSeeOther, post.Code)
 
-	assert.Equal(t, 0, storedRetentionDays(t, env.db, wh.ID))
+	assert.Equal(
+		t,
+		database.RetentionForeverDays,
+		storedRetentionDays(t, env.db, wh.ID),
+	)
 }
 
-// TestSourceListAndDetail_ShowForeverNotZeroDays checks that a
+// TestSourceListAndDetail_ShowForeverNotTheSentinelNumber checks that
-// retention of 0 is shown as forever, never as a day count, on either
+// the retain-forever value is never rendered to the user as a raw day
-// read-only view.
+// count on either read-only view.
-func TestSourceListAndDetail_ShowForeverNotZeroDays(t *testing.T) {
+func TestSourceListAndDetail_ShowForeverNotTheSentinelNumber(
+	t *testing.T,
+) {
 	t.Parallel()
 
 	env := setupSourceTest(t)
-	wh := seedWebhookWithRetention(t, env.db, 0)
+	wh := seedWebhookWithRetention(
+		t, env.db, database.RetentionForeverDays,
+	)
+	sentinel := strconv.Itoa(database.RetentionForeverDays)
 
 	listW := httptest.NewRecorder()
 	env.handlers.HandleSourceList().ServeHTTP(
@@ -902,7 +941,7 @@ func TestSourceListAndDetail_ShowForeverNotZeroDays(t *testing.T) {
 
 	require.Equal(t, http.StatusOK, listW.Code)
 	assert.Contains(t, listW.Body.String(), "Retention: forever")
-	assert.NotContains(t, listW.Body.String(), "Retention: 0 days")
+	assert.NotContains(t, listW.Body.String(), sentinel)
 
 	detailW := httptest.NewRecorder()
 	env.handlers.HandleSourceDetail().ServeHTTP(
@@ -915,5 +954,5 @@ func TestSourceListAndDetail_ShowForeverNotZeroDays(t *testing.T) {
 
 	require.Equal(t, http.StatusOK, detailW.Code)
 	assert.Contains(t, detailW.Body.String(), "Retention: forever")
-	assert.NotContains(t, detailW.Body.String(), "Retention: 0 days")
+	assert.NotContains(t, detailW.Body.String(), sentinel)
 }

internal/handlers/target_attempts.go

@@ -1,81 +0,0 @@
-package handlers
-
-import (
-	"errors"
-	"strconv"
-	"strings"
-)
-
-// maxTargetAttempts bounds a target's max_attempts.
-//
-// Both target forms already declare max="20" on the input, so this
-// enforces server-side what the UI has always advertised rather than
-// introducing a new limit.
-//
-// The number is not cosmetic. Every attempt writes a delivery_results
-// row that the event log then loads and renders, and the engine backs
-// off by 2^(n-1) seconds, so attempt 20 is already about six days
-// after the first. A value beyond this buys no additional durability
-// and only costs rows.
-const maxTargetAttempts = 20
-
-// Errors returned when a max_attempts form value cannot be turned into
-// a number of attempts.
-var (
-	// errAttemptsInvalid signals a max_attempts form value that is not
-	// a whole number of at least 1.
-	errAttemptsInvalid = errors.New(
-		"must be a whole number, at least 1",
-	)
-
-	// errAttemptsTooLarge signals a max_attempts form value that is a
-	// whole number but above maxTargetAttempts. It is distinguished
-	// from errAttemptsInvalid so the message can name the ceiling
-	// instead of implying the input was not a number.
-	errAttemptsTooLarge = errors.New("out of range")
-)
-
-// parseMaxAttempts interprets a max_attempts form value.
-//
-// An ABSENT value — the field empty or not submitted — yields
-// fallback, which lets the create path apply its default and the edit
-// path leave the stored value alone. A value that is SET BUT INVALID
-// is an error: unparseable, below 1, or above maxTargetAttempts.
-//
-// The distinction is the whole point of this function. Returning a
-// default for input the operator typed but that did not parse would
-// silently turn retries off on a store-and-forward proxy — and on the
-// edit path destroy a working configuration over a typo. A default
-// answers a question that was not asked; it never answers one that
-// was asked badly.
-func parseMaxAttempts(raw string, fallback int) (int, error) {
-	raw = strings.TrimSpace(raw)
-	if raw == "" {
-		return fallback, nil
-	}
-
-	v, err := strconv.Atoi(raw)
-	if err != nil || v < 1 {
-		return 0, errAttemptsInvalid
-	}
-
-	if v > maxTargetAttempts {
-		return 0, errAttemptsTooLarge
-	}
-
-	return v, nil
-}
-
-// attemptsErrorMessage returns the message the create and edit forms
-// show for a rejected max_attempts value. Any error other than
-// errAttemptsTooLarge falls back to the generic wording, so an
-// unrecognised parse failure still produces a sensible 400.
-func attemptsErrorMessage(err error) string {
-	if errors.Is(err, errAttemptsTooLarge) {
-		return errAttemptsTooLarge.Error() +
-			": at most " + strconv.Itoa(maxTargetAttempts) +
-			" attempts"
-	}
-
-	return errAttemptsInvalid.Error()
-}

internal/handlers/target_attempts_test.go

@@ -1,429 +0,0 @@
-package handlers_test
-
-import (
-	"net/http"
-	"net/url"
-	"strconv"
-	"testing"
-
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"sneak.berlin/go/webhooker/internal/database"
-	"sneak.berlin/go/webhooker/internal/handlers"
-)
-
-// attemptsTargetURL is the destination the attempts-validation targets
-// point at. It is a literal public address rather than a hostname so
-// the SSRF check resolves nothing and a sandbox without DNS cannot
-// make these cases pass or fail for the wrong reason.
-const attemptsTargetURL = "https://93.184.216.34/hooks/attempts"
-
-const (
-	// wayAboveCeiling is the typo'd-extra-zero case from the report.
-	wayAboveCeiling = "999999999"
-
-	// notANumber is the plainest garbage an operator can type, and
-	// the value the report submitted on the edit form.
-	notANumber = "abc"
-
-	// workingAttempts is the number of attempts a seeded target is
-	// already delivering with, which a rejected submission must not
-	// disturb.
-	workingAttempts = 2
-)
-
-// aboveCeiling is the smallest rejected whole number.
-func aboveCeiling() string {
-	return strconv.Itoa(handlers.MaxTargetAttemptsForTest + 1)
-}
-
-// overCeilingAttempts is whole-number input past the limit, which is
-// rejected with the limit named.
-func overCeilingAttempts() []string {
-	return []string{aboveCeiling(), wayAboveCeiling}
-}
-
-// belowOneAttempts is whole-number input under the floor of one
-// attempt, which is rejected with the floor named.
-func belowOneAttempts() []string {
-	return []string{"0", "-5"}
-}
-
-// unparseableAttempts is input an operator can type into the field
-// that is not a number of attempts. Each must be REJECTED: silently
-// reading any of them as a default turns retries off on a
-// store-and-forward proxy without saying so.
-//
-// The twenty-digit case is here because it parses as digits but
-// overflows int, which is the one failure the field's own min/max
-// attributes cannot describe.
-func unparseableAttempts() []string {
-	return []string{
-		notANumber,
-		"2.7",
-		"12345678901234567890",
-		"1e3",
-	}
-}
-
-// createAttemptsForm is a complete, otherwise-valid HTTP target
-// creation, so the only thing any case below varies is max_attempts.
-func createAttemptsForm(attempts string) url.Values {
-	form := url.Values{}
-	form.Set("name", "attempts-target")
-	form.Set("type", string(database.TargetTypeHTTP))
-	form.Set("url", attemptsTargetURL)
-
-	if attempts != absentField {
-		form.Set("max_attempts", attempts)
-	}
-
-	return form
-}
-
-// absentField marks a field the form does not submit at all, which is
-// the case that legitimately takes a default and must stay distinct
-// from a field submitted with garbage in it.
-const absentField = "\x00absent"
-
-// absentAttempts is every way of saying "the operator did not set
-// this", each of which takes the default rather than a 400. Blank and
-// whitespace-only count as absent here because they do in the timeout
-// and retention controls on the same forms; a rule the fields do not
-// share would be its own surprise.
-func absentAttempts() []string {
-	return []string{absentField, "", "  "}
-}
-
-// createWithAttempts posts the target create form for a fresh webhook
-// and returns the webhook and the response.
-func createWithAttempts(
-	t *testing.T,
-	env *sourceTestEnv,
-	attempts string,
-) (database.Webhook, int, string) {
-	t.Helper()
-
-	webhook := seedWebhookWithRetention(t, env.db, 30)
-
-	w := serveTarget(
-		env, http.MethodPost,
-		"/hook/"+webhook.ID+"/targets",
-		createAttemptsForm(attempts),
-	)
-
-	return webhook, w.Code, w.Body.String()
-}
-
-// TestTargetCreate_AttemptsAboveCeilingRejected proves the create form
-// enforces a ceiling at all, and that the 400 names it — a rejection
-// that does not say what the limit is leaves the operator guessing.
-func TestTargetCreate_AttemptsAboveCeilingRejected(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-	ceiling := strconv.Itoa(handlers.MaxTargetAttemptsForTest)
-
-	for _, attempts := range overCeilingAttempts() {
-		webhook, code, body := createWithAttempts(t, env, attempts)
-
-		assert.Equal(t, http.StatusBadRequest, code,
-			"max_attempts=%s should be rejected", attempts)
-		assert.Contains(t, body, ceiling,
-			"the rejection for %s should name the ceiling",
-			attempts)
-		assert.Empty(t,
-			targetsForWebhook(t, env.db, webhook.ID),
-			"no target should be created for %s", attempts)
-	}
-}
-
-// TestTargetCreate_AttemptsBelowOneRejected proves the create form
-// refuses 0 and less, naming the floor: every delivery is attempted
-// at least once.
-func TestTargetCreate_AttemptsBelowOneRejected(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	for _, attempts := range belowOneAttempts() {
-		webhook, code, body := createWithAttempts(t, env, attempts)
-
-		assert.Equal(t, http.StatusBadRequest, code,
-			"max_attempts=%s should be rejected", attempts)
-		assert.Contains(t, body, "at least 1",
-			"the rejection for %s should name the floor",
-			attempts)
-		assert.Empty(t,
-			targetsForWebhook(t, env.db, webhook.ID),
-			"no target should be created for %s", attempts)
-	}
-}
-
-// TestTargetCreate_UnparseableAttemptsRejected is the core of the
-// defect: each of these was accepted with HTTP 200 and stored as a
-// default.
-func TestTargetCreate_UnparseableAttemptsRejected(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	for _, attempts := range unparseableAttempts() {
-		webhook, code, body := createWithAttempts(t, env, attempts)
-
-		assert.Equal(t, http.StatusBadRequest, code,
-			"max_attempts=%q should be rejected, not coerced",
-			attempts)
-		assert.Contains(t, body, "whole number",
-			"the rejection for %q should say why", attempts)
-		assert.Empty(t,
-			targetsForWebhook(t, env.db, webhook.ID),
-			"no target should be created for %q", attempts)
-	}
-}
-
-// TestTargetCreate_ValidAttemptsStored covers the accepting half,
-// including both bounds: a bound that rejects its own limit would
-// make the advertised range unreachable.
-func TestTargetCreate_ValidAttemptsStored(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	for _, want := range []int{1, 3, handlers.MaxTargetAttemptsForTest} {
-		webhook, code, body := createWithAttempts(
-			t, env, strconv.Itoa(want),
-		)
-
-		require.Equal(t, http.StatusSeeOther, code, body)
-
-		targets := targetsForWebhook(t, env.db, webhook.ID)
-		require.Len(t, targets, 1)
-		assert.Equal(t, want, targets[0].MaxAttempts)
-	}
-}
-
-// TestTargetCreate_AbsentAttemptsTakesDefault keeps the two cases
-// distinct. An omitted field is not an operator asking for something
-// invalid, so it still gets the default of one attempt rather than a
-// 400 — otherwise the fix above would make the form unusable.
-func TestTargetCreate_AbsentAttemptsTakesDefault(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	for _, attempts := range absentAttempts() {
-		webhook, code, body := createWithAttempts(t, env, attempts)
-
-		require.Equal(t, http.StatusSeeOther, code, body)
-
-		targets := targetsForWebhook(t, env.db, webhook.ID)
-		require.Len(t, targets, 1)
-		assert.Equal(t, 1, targets[0].MaxAttempts,
-			"an absent max_attempts should take the default")
-	}
-}
-
-// seedAttemptsTarget creates an HTTP target already delivering with
-// workingAttempts attempts, through the real create handler.
-func seedAttemptsTarget(
-	t *testing.T,
-	env *sourceTestEnv,
-) (database.Webhook, database.Target) {
-	t.Helper()
-
-	webhook, code, body := createWithAttempts(
-		t, env, strconv.Itoa(workingAttempts),
-	)
-	require.Equal(t, http.StatusSeeOther, code, body)
-
-	targets := targetsForWebhook(t, env.db, webhook.ID)
-	require.Len(t, targets, 1)
-	require.Equal(t, workingAttempts, targets[0].MaxAttempts)
-
-	return webhook, targets[0]
-}
-
-// editAttemptsForm is a complete edit submission that changes the
-// target's name as well, so a rejected submission can be shown to
-// have written nothing at all rather than merely to have left
-// max_attempts alone.
-func editAttemptsForm(attempts string) url.Values {
-	form := url.Values{}
-	form.Set("name", "renamed-by-edit")
-	form.Set("url", attemptsTargetURL)
-
-	if attempts != absentField {
-		form.Set("max_attempts", attempts)
-	}
-
-	return form
-}
-
-// assertEditRejectedAndUnchanged submits an edit expected to fail and
-// checks both halves of the requirement: the 400 explains itself, and
-// the target it was submitted against is untouched.
-func assertEditRejectedAndUnchanged(
-	t *testing.T,
-	env *sourceTestEnv,
-	attempts, wantReason string,
-) {
-	t.Helper()
-
-	webhook, target := seedAttemptsTarget(t, env)
-
-	w := submitTargetEdit(
-		env, webhook.ID, target.ID, editAttemptsForm(attempts),
-	)
-
-	assert.Equal(t, http.StatusBadRequest, w.Code,
-		"max_attempts=%q should be rejected on edit", attempts)
-	assert.Contains(t, w.Body.String(), wantReason,
-		"the rejection for %q should say why", attempts)
-
-	stored := storedTarget(t, env, target.ID)
-	assert.Equal(t, workingAttempts, stored.MaxAttempts,
-		"a rejected edit must not destroy the working number "+
-			"of attempts with %q", attempts)
-	assert.Equal(t, "attempts-target", stored.Name,
-		"a rejected edit must write nothing at all")
-}
-
-// TestTargetEdit_UnparseableAttemptsRejected is the damaging half of
-// the defect. A target delivering with retries, re-saved with a typo
-// in the field, returned 200 and was left with retries disabled and
-// nothing said.
-func TestTargetEdit_UnparseableAttemptsRejected(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	for _, attempts := range unparseableAttempts() {
-		assertEditRejectedAndUnchanged(
-			t, env, attempts, "whole number",
-		)
-	}
-}
-
-// TestTargetEdit_AttemptsBelowOneRejected proves the floor applies
-// to the edit path too.
-func TestTargetEdit_AttemptsBelowOneRejected(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	for _, attempts := range belowOneAttempts() {
-		assertEditRejectedAndUnchanged(t, env, attempts, "at least 1")
-	}
-}
-
-// TestTargetEdit_AttemptsAboveCeilingRejected proves the ceiling
-// applies to the edit path too, naming itself, so the two paths
-// cannot disagree about what is storable.
-func TestTargetEdit_AttemptsAboveCeilingRejected(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-	ceiling := strconv.Itoa(handlers.MaxTargetAttemptsForTest)
-
-	for _, attempts := range overCeilingAttempts() {
-		assertEditRejectedAndUnchanged(t, env, attempts, ceiling)
-	}
-}
-
-// TestTargetEdit_ValidAttemptsStored covers the accepting half of the
-// edit path, so the bounds cannot be enforced by simply refusing
-// every submission.
-func TestTargetEdit_ValidAttemptsStored(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	for _, want := range []int{1, 9, handlers.MaxTargetAttemptsForTest} {
-		webhook, target := seedAttemptsTarget(t, env)
-
-		w := submitTargetEdit(
-			env, webhook.ID, target.ID,
-			editAttemptsForm(strconv.Itoa(want)),
-		)
-		require.Equal(t,
-			http.StatusSeeOther, w.Code, w.Body.String(),
-		)
-
-		assert.Equal(t, want,
-			storedTarget(t, env, target.ID).MaxAttempts)
-	}
-}
-
-// TestTargetEdit_AbsentAttemptsLeavesStoredValue is the edit path's
-// absent-versus-invalid case. The field is only offered by the forms
-// for types that retry, so a submission without it must leave the
-// stored count alone rather than be rejected or reset.
-func TestTargetEdit_AbsentAttemptsLeavesStoredValue(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	for _, attempts := range absentAttempts() {
-		webhook, target := seedAttemptsTarget(t, env)
-
-		w := submitTargetEdit(
-			env, webhook.ID, target.ID,
-			editAttemptsForm(attempts),
-		)
-		require.Equal(t,
-			http.StatusSeeOther, w.Code, w.Body.String(),
-		)
-
-		assert.Equal(t, workingAttempts,
-			storedTarget(t, env, target.ID).MaxAttempts,
-			"an absent max_attempts must leave the stored "+
-				"count alone (%q)", attempts)
-	}
-}
-
-// TestTargetAttempts_CreateAndEditAgreeOnEveryCase proves the two
-// paths cannot disagree, which is what let the create form and the
-// edit form drift apart in the first place. Every input is submitted
-// to both and the accept/reject verdicts are compared.
-func TestTargetAttempts_CreateAndEditAgreeOnEveryCase(t *testing.T) {
-	t.Parallel()
-
-	env := setupSourceTest(t)
-
-	accepted := []string{
-		"1", "2",
-		strconv.Itoa(handlers.MaxTargetAttemptsForTest),
-	}
-	overCeiling := overCeilingAttempts()
-	belowOne := belowOneAttempts()
-	unparseable := unparseableAttempts()
-
-	cases := make(
-		[]string, 0,
-		len(accepted)+len(overCeiling)+len(belowOne)+
-			len(unparseable),
-	)
-	cases = append(cases, accepted...)
-	cases = append(cases, overCeiling...)
-	cases = append(cases, belowOne...)
-	cases = append(cases, unparseable...)
-
-	for _, attempts := range cases {
-		_, createCode, _ := createWithAttempts(t, env, attempts)
-
-		webhook, target := seedAttemptsTarget(t, env)
-		editCode := submitTargetEdit(
-			env, webhook.ID, target.ID,
-			editAttemptsForm(attempts),
-		).Code
-
-		assert.Equal(t,
-			createCode == http.StatusBadRequest,
-			editCode == http.StatusBadRequest,
-			"create and edit must agree on max_attempts=%q "+
-				"(create %d, edit %d)",
-			attempts, createCode, editCode,
-		)
-	}
-}

internal/handlers/target_create.go

@@ -2,13 +2,13 @@ package handlers
 
 import (
 	"context"
+	"encoding/json"
 	"errors"
 	"fmt"
 	"net/http"
 	"strings"
 
 	"github.com/go-chi/chi"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
 	"sneak.berlin/go/webhooker/internal/delivery"
 )
@@ -27,8 +27,8 @@ func (h *Handlers) HandleTargetCreate() http.HandlerFunc {
 
 		sourceID := chi.URLParam(r, "sourceID")
 
-		h.archives.RenameLock().Lock()
+		h.renameMu.Lock()
-		defer h.archives.RenameLock().Unlock()
+		defer h.renameMu.Unlock()
 
 		var webhook database.Webhook
 
@@ -64,14 +64,20 @@ func (h *Handlers) processTargetCreate(
 ) {
 	in := targetFormInputFrom(r)
 
-	target, errMsg := h.newTarget(r.Context(), webhook.ID, in)
+	target, errMsg, err := h.newTarget(r.Context(), webhook.ID, in)
+	if err != nil {
+		h.serverError(w, r, "failed to encode target config", err)
+
+		return
+	}
+
 	if errMsg != "" {
 		h.renderSourceDetail(w, r, webhook, in, errMsg)
 
 		return
 	}
 
-	err := h.db.DB().Create(target).Error
+	err = h.db.DB().Create(target).Error
 	if err != nil {
 		h.serverError(w, r, "failed to create target", err)
 
@@ -86,64 +92,66 @@ func (h *Handlers) processTargetCreate(
 
 // newTarget validates a new target for a webhook and returns the row
 // to create, or, when it refuses the target, the message the form
-// shows. Every form that creates a target goes through here, so they
+// shows. An error is the server's fault, not a refusal: the accepted
-// all accept and refuse the same things.
+// configuration could not be encoded. Every form that creates a
+// target goes through here, so they all accept and refuse the same
+// things.
 func (h *Handlers) newTarget(
 	ctx context.Context,
 	webhookID string,
 	in targetFormInput,
-) (*database.Target, string) {
+) (*database.Target, string, error) {
 	target := &database.Target{
-		WebhookID:   webhookID,
+		WebhookID: webhookID,
-		Type:        in.Type,
+		Type:      in.Type,
-		Active:      true,
+		Active:    true,
-		MaxAttempts: 1,
 	}
 
-	errMsg := h.setTargetFromForm(ctx, target, in)
+	errMsg, err := h.setTargetFromForm(ctx, target, in)
-	if errMsg != "" {
+	if err != nil || errMsg != "" {
-		return nil, errMsg
+		return nil, errMsg, err
 	}
 
-	return target, ""
+	return target, "", nil
 }
 
 // setTargetFromForm validates a target form against the target's type
-// and sets the target's name, settings and number of delivery attempts
+// and, when it accepts it, sets the target's name, configuration and
-// from it. It returns the message the form shows for anything it
+// retry count from it. It returns the message the form shows for
-// refuses, an unknown type among them; the caller then discards the
+// anything it refuses, an unknown type among them, and then leaves the
-// target, which may be partly set.
+// target unchanged; an error is the server's fault, as for newTarget.
 // The add target form and the target edit form both go through here,
 // so the two cannot come to disagree about what a target may be.
 func (h *Handlers) setTargetFromForm(
 	ctx context.Context,
 	target *database.Target,
 	in targetFormInput,
-) string {
+) (string, error) {
 	if in.Name == "" {
-		return "Name is required"
+		return "Name is required", nil
 	}
 
-	errMsg := h.setTargetSettings(ctx, target, in)
+	configJSON, errMsg, err := h.buildTargetConfig(ctx, target.Type, in)
-	if errMsg != "" {
+	if err != nil || errMsg != "" {
-		return errMsg
+		return errMsg, err
 	}
 
-	// An empty max_attempts keeps the target's count: the default of
+	// An empty max_retries keeps the target's count: the
-	// 1 for a new target, and the stored count for an edited one,
+	// fire-and-forget default of 0 for a new target, and the stored
-	// since the forms for target types that do not retry have no such
+	// count for an edited one, since the forms for target types that
-	// field. A value that is filled in but invalid is refused rather
+	// do not retry have no such field. A value that is filled in but
-	// than becoming that count, so a typo cannot destroy the count a
+	// invalid is refused rather than becoming that count, so a typo
-	// target is delivering with.
+	// cannot destroy the count a target is delivering with.
-	maxAttempts, err := parseMaxAttempts(in.MaxAttempts, target.MaxAttempts)
+	maxRetries, err := parseMaxRetries(in.MaxRetries, target.MaxRetries)
 	if err != nil {
-		return "Invalid delivery attempts: " + attemptsErrorMessage(err)
+		return "Invalid delivery attempts: " + retriesErrorMessage(err), nil
 	}
 
 	target.Name = in.Name
-	target.MaxAttempts = maxAttempts
+	target.Config = configJSON
+	target.MaxRetries = maxRetries
 
-	return ""
+	return "", nil
 }
 
 // targetFormInput carries the raw values of a target form. Both the
@@ -168,8 +176,8 @@ type targetFormInput struct {
 	// ForwardQuery is an HTTP target's checkbox that passes each
 	// event's query string on to it.
 	ForwardQuery bool
-	// MaxAttempts is an HTTP or Slack target's max_attempts.
+	// MaxRetries is an HTTP or Slack target's max_retries.
-	MaxAttempts string
+	MaxRetries string
 	// Expiry is a database (archive) target's row expiry.
 	Expiry string
 	// Rotation is a database (archive) target's rotation.
@@ -196,87 +204,90 @@ func targetFormInputFrom(r *http.Request) targetFormInput {
 		Headers:      r.PostFormValue("headers"),
 		Timeout:      r.PostFormValue("timeout"),
 		ForwardQuery: r.PostFormValue("forward_query") != "",
-		MaxAttempts:  r.PostFormValue("max_attempts"),
+		MaxRetries:   r.PostFormValue("max_retries"),
 		Expiry:       r.PostFormValue("expiry"),
 		Rotation:     r.PostFormValue("rotation"),
 	}
 }
 
-// setTargetSettings sets a target's settings from the submitted form
+// buildTargetConfig builds the JSON config string for a target from
-// values, or returns the message the form shows for a value it
+// the submitted form values, or returns the message the form shows
-// refuses. Which fields of in apply depends on the target type; a
+// for a value it refuses. An error is the server's fault, not a
-// type without a URL ignores any URL submitted, and the settings a
+// refusal: the accepted configuration could not be encoded. Which
-// type does not use are left empty.
+// fields of in apply depends on the target type; a type without a URL
-func (h *Handlers) setTargetSettings(
+// ignores any URL submitted.
+func (h *Handlers) buildTargetConfig(
 	ctx context.Context,
-	target *database.Target,
+	targetType database.TargetType,
 	in targetFormInput,
-) string {
+) (string, string, error) {
-	switch target.Type {
+	switch targetType {
 	case database.TargetTypeHTTP:
-		return h.setHTTPTargetSettings(ctx, target, in)
+		return h.buildHTTPTargetConfig(ctx, in)
 	case database.TargetTypeSlack:
-		return h.setSlackTargetSettings(ctx, target, in.URL)
+		return h.buildSlackTargetConfig(ctx, in.URL)
 	case database.TargetTypeDatabase:
-		return setDatabaseTargetSettings(target, in.Expiry, in.Rotation)
+		return buildDatabaseTargetConfig(in.Expiry, in.Rotation)
 	case database.TargetTypeLog:
-		return ""
+		return "", "", nil
 	default:
-		return "Invalid target type"
+		return "", "Invalid target type", nil
 	}
 }
 
-// setHTTPTargetSettings sets an HTTP target's SSRF-validated
+// buildHTTPTargetConfig builds config JSON for an HTTP target: an
-// destination plus the optional headers, timeout and query string
+// SSRF-validated destination plus the optional headers, timeout and
-// setting the delivery path honours.
+// query string setting the delivery path honours.
-func (h *Handlers) setHTTPTargetSettings(
+func (h *Handlers) buildHTTPTargetConfig(
 	ctx context.Context,
-	target *database.Target,
 	in targetFormInput,
-) string {
+) (string, string, error) {
 	errMsg := h.validateTargetURL(
 		ctx, in.URL, "URL is required for HTTP targets",
 	)
 	if errMsg != "" {
-		return errMsg
+		return "", errMsg, nil
 	}
 
 	headers, err := delivery.ParseTargetHeaders(in.Headers)
 	if err != nil {
-		return fmt.Sprintf("Invalid headers: %v", err)
+		return "", fmt.Sprintf("Invalid headers: %v", err), nil
 	}
 
 	timeout, err := delivery.ParseTargetTimeout(in.Timeout)
 	if err != nil {
-		return fmt.Sprintf("Invalid timeout: %v", err)
+		return "", fmt.Sprintf("Invalid timeout: %v", err), nil
 	}
 
-	target.URL = in.URL
+	configJSON, err := marshalTargetConfig(delivery.HTTPTargetConfig{
-	target.Headers = headers
+		URL:          in.URL,
-	target.TimeoutSeconds = timeout
+		Headers:      headers,
-	target.ForwardQuery = in.ForwardQuery
+		Timeout:      timeout,
+		ForwardQuery: in.ForwardQuery,
+	})
 
-	return ""
+	return configJSON, "", err
 }
 
-// setSlackTargetSettings sets a Slack target's one setting, its
+// buildSlackTargetConfig builds config JSON for a Slack target,
-// SSRF-validated webhook URL.
+// whose whole configuration is one SSRF-validated webhook URL.
-func (h *Handlers) setSlackTargetSettings(
+func (h *Handlers) buildSlackTargetConfig(
 	ctx context.Context,
-	target *database.Target,
 	targetURL string,
-) string {
+) (string, string, error) {
 	errMsg := h.validateTargetURL(
 		ctx, targetURL,
 		"Webhook URL is required for Slack targets",
 	)
 	if errMsg != "" {
-		return errMsg
+		return "", errMsg, nil
 	}
 
-	target.URL = targetURL
+	configJSON, err := marshalTargetConfig(delivery.SlackTargetConfig{
+		WebhookURL: targetURL,
+	})
 
-	return ""
+	return configJSON, "", err
 }
 
 // validateTargetURL refuses an empty or SSRF-blocked destination,
@@ -327,31 +338,52 @@ func (h *Handlers) validateTargetURL(
 	return ""
 }
 
-// setDatabaseTargetSettings sets a database (archive) target's
+// marshalTargetConfig serialises a target configuration for storage.
-// expiry and rotation. Both are optional: an empty or never expiry
+func marshalTargetConfig(cfg any) (string, error) {
-// keeps the archive forever, and an empty rotation is stored as none,
+	configBytes, err := json.Marshal(cfg)
-// one file. A bad value is refused here, at the form, instead of
-// being stored.
-func setDatabaseTargetSettings(
-	target *database.Target,
-	expiry, rotation string,
-) string {
-	archiveExpiry, err := archive.ParseExpiry(strings.TrimSpace(expiry))
 	if err != nil {
-		return fmt.Sprintf("Invalid archive expiry: %v", err)
+		return "", err
 	}
 
-	err = archive.ValidateRotation(rotation)
+	return string(configBytes), nil
+}
+
+// buildDatabaseTargetConfig builds config JSON for a database
+// (archive) target. The optional expiry and rotation are validated
+// here, at creation time, so a bad value is refused instead of
+// failing every subsequent delivery. Each is stored only when set,
+// and with neither the config is empty (the keep-forever, one-file
+// default).
+func buildDatabaseTargetConfig(
+	expiry, rotation string,
+) (string, string, error) {
+	expiry = strings.TrimSpace(expiry)
+
+	err := delivery.ValidateArchiveExpiry(expiry)
+	if err != nil {
+		return "", fmt.Sprintf("Invalid archive expiry: %v", err), nil
+	}
+
+	err = delivery.ValidateArchiveRotation(rotation)
 	if err != nil {
-		return fmt.Sprintf("Invalid archive rotation: %v", err)
+		return "", fmt.Sprintf("Invalid archive rotation: %v", err), nil
+	}
+
+	cfg := map[string]any{}
+
+	if expiry != "" {
+		cfg["expiry"] = expiry
+	}
+
+	if rotation != "" {
+		cfg["rotation"] = rotation
 	}
 
-	if rotation == "" {
+	if len(cfg) == 0 {
-		rotation = archiveRotationNone
+		return "", "", nil
 	}
 
-	target.ArchiveExpiry = archiveExpiry
+	configJSON, err := marshalTargetConfig(cfg)
-	target.ArchiveRotation = rotation
 
-	return ""
+	return configJSON, "", err
 }

internal/handlers/target_create_query_test.go

@@ -176,7 +176,7 @@ func TestHandleTargetCreate_BodyURLStillCreatesTheTarget(t *testing.T) {
 
 	targets := targetsForWebhook(t, env.db, webhook.ID)
 	require.Len(t, targets, 1)
-	assert.Equal(t, targetSecretURL, targets[0].URL)
+	assert.Contains(t, targets[0].Config, targetSecretSegments)
 
 	// The body carried the credential, so the access log must still
 	// not have it: the log records the request line only.
@@ -196,7 +196,7 @@ func TestHandleTargetCreate_QueryStringCannotSupplyNameOrType(
 
 	w, _ := postTargetCreate(
 		t, env, webhook.ID,
-		"name=leaky&type=slack&max_attempts=9&expiry=30d&url="+
+		"name=leaky&type=slack&max_retries=9&expiry=30d&url="+
 			url.QueryEscape(targetSecretURL),
 		url.Values{},
 	)

internal/handlers/target_create_test.go

@@ -6,114 +6,73 @@ import (
 	"net/url"
 	"strings"
 	"testing"
-	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"sneak.berlin/go/webhooker/internal/database"
 )
 
-// TestHandleTargetCreate_EveryType adds a target of each type and
+// TestHandleTargetCreate_EveryType adds a target of each type. Each
-// checks the settings it stores. Each submission carries a url and an
+// submission carries a url: only the http and slack types store one.
-// expiry: only the http and slack types store the url, only the
-// database type the expiry, and every setting a type does not use
-// stays empty.
 func TestHandleTargetCreate_EveryType(t *testing.T) {
 	t.Parallel()
 
 	env := setupSourceTest(t)
 
-	// fields is the rest of each submission, as a query string, and
+	// fields is the rest of each submission, as a query string.
-	// want holds the settings stored.
 	cases := []struct {
-		targetType   database.TargetType
+		targetType  database.TargetType
-		fields       string
+		fields      string
-		want         database.Target
+		wantConfig  string
-		wantAttempts int
+		wantRetries int
 	}{
 		{
-			database.TargetTypeHTTP,
+			database.TargetTypeHTTP, "timeout=12&max_retries=3",
-			"timeout=12&max_attempts=3&forward_query=on",
+			`{"url":"` + editOriginalURL + `","timeout":12}`, 3,
-			database.Target{
-				URL:            editOriginalURL,
-				Headers:        map[string]string{},
-				TimeoutSeconds: 12,
-				ForwardQuery:   true,
-			}, 3,
 		},
 		{
-			database.TargetTypeSlack, "max_attempts=4",
+			database.TargetTypeSlack, "max_retries=4",
-			database.Target{URL: editOriginalURL}, 4,
+			`{"webhookUrl":"` + editOriginalURL + `"}`, 4,
 		},
 		{
-			database.TargetTypeDatabase, "rotation=daily",
+			database.TargetTypeDatabase, "expiry=720h",
-			database.Target{
+			`{"expiry":"720h"}`, 0,
-				ArchiveExpiry:   720 * time.Hour,
-				ArchiveRotation: rotationDaily,
-			}, 1,
 		},
-		{database.TargetTypeLog, "", database.Target{}, 1},
+		{database.TargetTypeLog, "", "", 0},
 	}
 
 	for _, tc := range cases {
 		t.Run(string(tc.targetType), func(t *testing.T) {
 			t.Parallel()
 
-			_, got := addTargetThroughForm(
+			webhook := seedWebhookWithRetention(t, env.db, 30)
-				t, env, tc.targetType,
+
-				"url="+editOriginalURL+"&expiry=720h&"+tc.fields,
+			form, err := url.ParseQuery(tc.fields)
+			require.NoError(t, err)
+			form.Set("name", "every-type")
+			form.Set("type", string(tc.targetType))
+			form.Set("url", editOriginalURL)
+
+			w := serveTarget(
+				env, http.MethodPost,
+				"/hook/"+webhook.ID+"/targets", form,
 			)
-			assert.Equal(t, tc.targetType, got.Type)
+			require.Equal(t, http.StatusSeeOther, w.Code, w.Body.String())
-			assert.Equal(t, tc.wantAttempts, got.MaxAttempts)
+
-			assert.Equal(t, tc.want, targetSettingsOf(got))
+			targets := targetsForWebhook(t, env.db, webhook.ID)
+			require.Len(t, targets, 1)
+			assert.Equal(t, tc.targetType, targets[0].Type)
+			assert.Equal(t, tc.wantRetries, targets[0].MaxRetries)
+
+			if tc.wantConfig == "" {
+				assert.Empty(t, targets[0].Config)
+			} else {
+				assert.JSONEq(t, tc.wantConfig, targets[0].Config)
+			}
 		})
 	}
 }
 
-// addTargetThroughForm adds a target of targetType named every-type to
-// a new webhook through the add target form, with the rest of the form
-// given as a query string, and returns the webhook and the target the
-// form stored.
-func addTargetThroughForm(
-	t *testing.T,
-	env *sourceTestEnv,
-	targetType database.TargetType,
-	fields string,
-) (database.Webhook, database.Target) {
-	t.Helper()
-
-	webhook := seedWebhookWithRetention(t, env.db, 30)
-
-	form, err := url.ParseQuery(fields)
-	require.NoError(t, err)
-	form.Set("name", "every-type")
-	form.Set("type", string(targetType))
-
-	w := serveTarget(
-		env, http.MethodPost, "/hook/"+webhook.ID+"/targets", form,
-	)
-	require.Equal(t, http.StatusSeeOther, w.Code, w.Body.String())
-
-	targets := targetsForWebhook(t, env.db, webhook.ID)
-	require.Len(t, targets, 1)
-
-	return webhook, targets[0]
-}
-
-// targetSettingsOf returns a target's settings, URL to
-// ArchiveRotation, and nothing else, for comparing with the settings a
-// test expects.
-func targetSettingsOf(target database.Target) database.Target {
-	return database.Target{
-		URL:             target.URL,
-		Headers:         target.Headers,
-		TimeoutSeconds:  target.TimeoutSeconds,
-		ForwardQuery:    target.ForwardQuery,
-		ArchiveExpiry:   target.ArchiveExpiry,
-		ArchiveRotation: target.ArchiveRotation,
-	}
-}
-
 // TestHandleTargetCreate_RefusedFormComesBack refuses a target of each
 // type and checks that the webhook page comes back with the add target
 // form open on that type, the values entered, and the reason.
@@ -131,11 +90,11 @@ func TestHandleTargetCreate_RefusedFormComesBack(t *testing.T) {
 		{
 			database.TargetTypeHTTP,
 			"name=private&url=" + editBlockedURL +
-				"&timeout=12&max_attempts=3",
+				"&timeout=12&max_retries=3",
 			"Invalid target URL",
 		},
 		{
-			database.TargetTypeSlack, "name=no-url&max_attempts=4",
+			database.TargetTypeSlack, "name=no-url&max_retries=4",
 			"Webhook URL is required for Slack targets",
 		},
 		{
@@ -174,8 +133,8 @@ func TestHandleTargetCreate_RefusedFormComesBack(t *testing.T) {
 			assert.Contains(t, page, html.EscapeString(tc.reason))
 
 			// Each value comes back in a data attribute of the targets
-			// section named after its field (max_attempts as
+			// section named after its field (max_retries as
-			// data-max-attempts), except url, which comes back in
+			// data-max-retries), except url, which comes back in
 			// data-destination; templates/source_detail.html says why.
 			for field := range typed {
 				attr := "data-" + strings.ReplaceAll(field, "_", "-")

internal/handlers/target_download.go

@@ -6,8 +6,8 @@ import (
 	"net/http"
 	"time"
 
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/database"
+	"sneak.berlin/go/webhooker/internal/delivery"
 )
 
 // downloadWriteTimeout is how long one write of a download may wait
@@ -16,7 +16,7 @@ const downloadWriteTimeout = 60 * time.Second
 
 // HandleTargetDownload serves a database target's archive as one
 // gzipped JSON file, named for the webhook, the target and the time;
-// see archive.Export.WriteGzipJSON for what it holds. Other
+// see delivery.ArchiveExport.WriteGzipJSON for what it holds. Other
 // target types have no archive and are a 404.
 //
 // A download runs for as long as the client keeps reading: it reads
@@ -37,7 +37,7 @@ func (h *Handlers) HandleTargetDownload() http.HandlerFunc {
 		w.Header().Set("Content-Type", "application/gzip")
 		w.Header().Set(
 			"Content-Disposition",
-			`attachment; filename="`+archive.ExportFileName(
+			`attachment; filename="`+delivery.ArchiveExportFileName(
 				webhook.Name, target.Name, now,
 			)+`"`,
 		)
@@ -82,17 +82,17 @@ func (d downloadWriter) Write(b []byte) (int, error) {
 // listTargetArchive lists the archive files of the request's database
 // target for export. It reports false once it has written the response.
 //
-// It holds the rename lock, which every archive rename runs under,
+// It holds renameMu, which every archive rename runs under, while it
-// while it reads the stored names and lists the files, so the files it
+// reads the stored names and lists the files, so the files it lists
-// lists are the ones those names give. It lets go before the export is
+// are the ones those names give. It lets go before the export is
-// streamed, which takes the lock again for each file only while it
+// streamed, which takes renameMu again for each file only while it
 // finds the file under the names stored then and opens it.
 func (h *Handlers) listTargetArchive(
 	w http.ResponseWriter,
 	r *http.Request,
-) (database.Webhook, *database.Target, *archive.Export, bool) {
+) (database.Webhook, *database.Target, *delivery.ArchiveExport, bool) {
-	h.archives.RenameLock().Lock()
+	h.renameMu.Lock()
-	defer h.archives.RenameLock().Unlock()
+	defer h.renameMu.Unlock()
 
 	webhook, target, ok := h.ownedTarget(w, r)
 	if !ok {
@@ -105,9 +105,9 @@ func (h *Handlers) listTargetArchive(
 		return database.Webhook{}, nil, nil, false
 	}
 
-	export, err := archive.NewExport(
+	export, err := delivery.NewArchiveExport(
-		archive.Path(h.dbMgr, &webhook, target),
+		delivery.ArchivePath(h.dbMgr, &webhook, target),
-		h.archives.RenameLock(),
+		&h.renameMu,
 		func() (string, error) {
 			return h.storedArchivePath(webhook.ID, target.ID)
 		},
@@ -122,9 +122,9 @@ func (h *Handlers) listTargetArchive(
 	return webhook, target, export, true
 }
 
-// storedArchivePath returns the path archive.Path gives a
+// storedArchivePath returns the path delivery.ArchivePath gives a
 // database target under the names stored for it and its webhook now.
-// Its caller holds the rename lock. A webhook or target deleted since is still
+// Its caller holds renameMu. A webhook or target deleted since is still
 // found, since deleting one leaves its archive files under their names.
 func (h *Handlers) storedArchivePath(
 	webhookID, targetID string,
@@ -143,5 +143,5 @@ func (h *Handlers) storedArchivePath(
 		return "", err
 	}
 
-	return archive.Path(h.dbMgr, &webhook, &target), nil
+	return delivery.ArchivePath(h.dbMgr, &webhook, &target), nil
 }

internal/handlers/target_download_test.go

@@ -21,9 +21,9 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"sneak.berlin/go/webhooker/internal/archive"
 	"sneak.berlin/go/webhooker/internal/config"
 	"sneak.berlin/go/webhooker/internal/database"
+	"sneak.berlin/go/webhooker/internal/delivery"
 	"sneak.berlin/go/webhooker/internal/middleware/middlewaretest"
 )
 
@@ -223,8 +223,8 @@ func TestHandleTargetDownload_FindsFilesAfterRename(t *testing.T) {
 
 	env := setupSourceTest(t)
 	wh := seedWebhookWithRetention(t, env.db, 7)
-	target := seedTarget(t, env.db, wh.ID, database.TargetTypeDatabase)
+	archive := seedTarget(t, env.db, wh.ID, database.TargetTypeDatabase)
-	oldPath := archive.Path(env.dbMgr, &wh, target)
+	oldPath := delivery.ArchivePath(env.dbMgr, &wh, archive)
 
 	month := func(path string) string {
 		return strings.TrimSuffix(path, ".db") + "-2026-10.db"
@@ -233,19 +233,19 @@ func TestHandleTargetDownload_FindsFilesAfterRename(t *testing.T) {
 	seedArchive(t, oldPath, 1, 16)
 	seedArchive(t, month(oldPath), 1, 16)
 
-	sw, downloaded := startStalledDownload(t, env, wh.ID, target.ID)
+	sw, downloaded := startStalledDownload(t, env, wh.ID, archive.ID)
 
 	require.Equal(t,
-		http.StatusSeeOther, renameTarget(env, wh.ID, target.ID).Code,
+		http.StatusSeeOther, renameTarget(env, wh.ID, archive.ID).Code,
 	)
 
 	// The test's archives record a rename without moving any file, so
-	// the files are moved here, as the archive writers move them.
+	// the files are moved here, as the delivery engine moves them.
 	var renamed database.Target
 
-	require.NoError(t, env.db.DB().First(&renamed, "id = ?", target.ID).Error)
+	require.NoError(t, env.db.DB().First(&renamed, "id = ?", archive.ID).Error)
 
-	newPath := archive.Path(env.dbMgr, &wh, &renamed)
+	newPath := delivery.ArchivePath(env.dbMgr, &wh, &renamed)
 
 	require.NoError(t, os.Rename(oldPath, newPath))
 	require.NoError(t, os.Rename(month(oldPath), month(newPath)))
@@ -355,16 +355,16 @@ func TestHandleTargetDownload_OutlastsTheRequestLimit(t *testing.T) {
 
 	env := setupSourceTest(t)
 	wh := seedWebhookWithRetention(t, env.db, 7)
-	target := seedTarget(t, env.db, wh.ID, database.TargetTypeDatabase)
+	archive := seedTarget(t, env.db, wh.ID, database.TargetTypeDatabase)
 	seedArchive(
-		t, archive.Path(env.dbMgr, &wh, target), rows, bodySize,
+		t, delivery.ArchivePath(env.dbMgr, &wh, archive), rows, bodySize,
 	)
 
 	srv, accessLog := limitedServer(t, env, limit)
 
 	req, err := http.NewRequestWithContext(
 		t.Context(), http.MethodGet,
-		srv.URL+downloadPath(wh.ID, target.ID), nil,
+		srv.URL+downloadPath(wh.ID, archive.ID), nil,
 	)
 	require.NoError(t, err)