4 Commits

Include renames

Author	SHA1	Message	Date
clawbot	128eb1b644	Keep test helpers out of the shipped binary (closes #506) ... The test helpers lived in ordinary `testing.go` files inside the config, database, middleware and session packages, so they were built into the binary and the shared `test-support` lint rule could not see them. The four files are gone: the session's helpers move into its own `_test.go` file, and the rest into `configtest`, `databasetest` and `middlewaretest`, which the `depguard` deny list now names, so a non-test file importing them fails lint. The test-support packages build through the production constructors. Judgement call: the session, the middleware and the webhook database manager now take the plain logger they log through, which the application wiring provides. Judgement call: two idle-expiry tests move the stored timestamps back instead of advancing a fake clock. Model: opus-5-5	2026-10-06 14:29:47 +02:00
clawbot	4958a6f2e4	Isolate config tests from the shell; any out-of-range PORT is ErrInvalidPort (closes #94) ... The config tests unset variables without restoring them and read whatever the developer's shell exported, so results could differ from one machine to the next. config.ClearEnvForTest, in internal/config/testing.go, unsets every variable in the process environment and, when the test ends, leaves it exactly as it found it; every config test and the first-boot test call it before setting their own. TestEnvPositiveInt and TestEnvPort share one table runner, and the port errors name the bad value. A PORT of zero, below zero, or too large to parse now matches ErrInvalidPort, as one above 65535 already did. The README and the Settings page say an unparseable or non-positive RETENTION_SWEEP_INTERVAL stops startup. Model: opus-5-5	2026-10-02 17:44:30 +02:00
clawbot	2bb4683512	Discard fx's own log in tests that build an fx app (closes #230) ... Every test that builds an fx app with fxtest.New (handlers, server, resetpw, gormlog, config) now passes fx.NopLogger, so fx's own log no longer goes to t.Logf. A hook still running after a start or stop timeout can then no longer write to a test that has already returned, which the race detector reported as a data race. What the tests assert is unchanged, and nothing about the race detector is suppressed. Model: opus-5-5	2026-10-02 11:08:38 +02:00
clawbot	5af161ef60	Log SQL with placeholders, never bound values (closes #207) (#222)	2026-08-20 07:20:59 +02:00