Use one name for each thing the UI shows (closes #399)
check / check (push) Successful in 3m15s
check / check (push) Successful in 3m15s
The database target type is called an archive on its badge, in the add target form's type list and on its edit page, and its settings read "Archive expiry" and "Archive rotation" everywhere, the new webhook page included. The retry field is labelled "Delivery attempts", with its help text and error messages to match, on both target forms and in the target list. The navbar says "Sign out" and the sign-in page "Sign in". The resubmit notice says "webhook". The stored values (`database`, `max_retries`) and their meaning are unchanged. Model: opus-5-5
This commit is contained in:
@@ -914,6 +914,26 @@ func TestPagesLogout_SaysSignedOut(t *testing.T) {
|
||||
env.requireNotice(t, w, "/pages/login", "signed-out", "Signed out.", nil)
|
||||
}
|
||||
|
||||
// TestSignInAndSignOutWording pins one wording for both: the sign-in
|
||||
// page's button reads "Sign in" and the navbar's buttons "Sign out", as
|
||||
// the sign-in page's heading, the error page's link and the notice
|
||||
// after signing out do.
|
||||
func TestSignInAndSignOutWording(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
env := newTestEnv(t)
|
||||
|
||||
assert.Contains(
|
||||
t, env.get("/pages/login", nil).Body.String(), ">Sign in</button>",
|
||||
)
|
||||
|
||||
userID, _ := env.seedUser(t, "reader", "somepassword")
|
||||
page := env.get("/hooks", env.authCookies(t, userID, "reader")).Body.String()
|
||||
|
||||
assert.Equal(t, 2, strings.Count(page, ">Sign out</button>"),
|
||||
"the desktop and the mobile navbar each say Sign out")
|
||||
}
|
||||
|
||||
// --- /user/{username} group ---
|
||||
|
||||
// TestPasswordChange_OversizeBody_RejectedAndPasswordUnchanged
|
||||
@@ -1363,7 +1383,7 @@ func TestHook_ResubmitFromEventLog(t *testing.T) {
|
||||
)
|
||||
env.requireNotice(
|
||||
t, w, logsPath, "resubmit-no-targets",
|
||||
"this source has no active targets", cookies,
|
||||
"this webhook has no active targets", cookies,
|
||||
)
|
||||
|
||||
webhookDB, err := env.dbMgr.GetDB(wh.ID)
|
||||
|
||||
Reference in New Issue
Block a user