Resubmit a stored event as a new undelivered event (closes #250)
All checks were successful
check / check (push) Successful in 3m3s
All checks were successful
check / check (push) Successful in 3m3s
Capturing real webhook traffic and firing it repeatedly at a backend under development is a primary function of this service, and per-delivery replay cannot do it: it only ever resolves the delivery's own original target, so a target created for a dev backend has no prior delivery and nothing can be replayed to it. The event log now offers a per-event Resubmit action. It stores a NEW event copying the stored one's method, headers, body and content type verbatim, and fans it out to the webhook's currently ACTIVE targets, resolved fresh by the query the receiver uses -- so a target created long after the original event arrived receives it. The original event's deliveries have no bearing on where the copy goes, inactive targets are skipped as the receiver skips them, and the action is repeatable: replay's in-flight refusal is deliberately not ported, because firing one captured event over and over is the point. The receiver and the resubmit path share one construction and one fan-out site. An eventSource value carries where the fields came from, live request or stored event, and createAndFanOut writes the event and its pending deliveries in one transaction and hands the tasks to the same Notifier, so a resubmitted delivery is retried, SSRF-guarded and circuit-broken exactly as a first one is. buildDeliveryTasks returns an error instead of writing a response, which is what lets both callers share it. The stored event is read once, before the write transaction, with a cast to blob, so a body over delivery.MaxInlineBodySize is copied byte for byte and the engine loads it from the new event row. A nullable resubmitted_from_id records provenance -- empty for an event that arrived on the receiver -- and the event log reports the relationship in both directions, without which the log is unreadable after a few resubmits of one event. The route sits in the owned-source group, so auth, CSRF and the body cap apply, with its own rate limit bucket and an events_resubmitted_total counter. Inbound signature verification is not re-run: there is no inbound signature to check on a copy an authenticated, CSRF-protected operator action submits. Per-delivery replay is unchanged; it serves recovery, which resubmit does not replace. The README claimed in four places that replay was unimplemented, one of them telling the operator that a delivery stranded by a target type change was lost; all four are corrected and resubmit is documented beside replay.
This commit is contained in:
@@ -44,6 +44,18 @@ const (
|
||||
// replayRateInterval is the time window for the replay limit.
|
||||
replayRateInterval = 1 * time.Minute
|
||||
|
||||
// resubmitRateLimit is the maximum number of event resubmits one
|
||||
// client may queue per interval. A resubmit stores an event and
|
||||
// queues one delivery per active target, so it costs more
|
||||
// outbound work per press than a replay does. Firing a captured
|
||||
// event repeatedly at a backend under development is the point of
|
||||
// the action, so the ceiling stays well above the rate a person
|
||||
// iterates at.
|
||||
resubmitRateLimit = 30
|
||||
|
||||
// resubmitRateInterval is the time window for the resubmit limit.
|
||||
resubmitRateInterval = 1 * time.Minute
|
||||
|
||||
// receiverRateInterval is the time window for the webhook
|
||||
// receiver rate limit. The configured limit is expressed in
|
||||
// requests per minute.
|
||||
@@ -315,6 +327,22 @@ func (m *Middleware) ReplayRateLimit() func(http.Handler) http.Handler {
|
||||
)
|
||||
}
|
||||
|
||||
// ResubmitRateLimit returns middleware that enforces per-IP rate
|
||||
// limiting on event resubmits.
|
||||
//
|
||||
// It is a separate bucket from the replay limit so that exhausting one
|
||||
// does not take the other away: replay is a recovery action and
|
||||
// resubmit is a testing action, and an operator iterating on a backend
|
||||
// must not lose the ability to re-send a failed delivery.
|
||||
func (m *Middleware) ResubmitRateLimit() func(http.Handler) http.Handler {
|
||||
return m.postRateLimit(
|
||||
resubmitRateLimit,
|
||||
resubmitRateInterval,
|
||||
"event resubmit rate limit exceeded",
|
||||
"Too many resubmits. Please try again later.",
|
||||
)
|
||||
}
|
||||
|
||||
// postRateLimit builds middleware that enforces a per-IP rate
|
||||
// limit on POST requests only; all other methods pass through
|
||||
// unaffected. Requests over the limit receive a 429 with the
|
||||
|
||||
Reference in New Issue
Block a user