State the UUID-is-the-credential rule as a rule (closes #301)
All checks were successful
check / check (push) Successful in 3m35s
All checks were successful
check / check (push) Successful in 3m35s
The receiver has authenticated on the entrypoint UUID alone since inbound signature verification was removed in #279. The README described that as the current state; it did not say it is the decision. Restate it as the rule, so a proposal to add HMAC, a shared secret or a bearer token to the receiver is contradicted by the docs rather than merely unimplemented. The rule now appears in the intro, in its own section, and in the Authentication and Security lists, and carries the two consequences an operator has to act on: the URL is a capability to be kept out of logs and tickets, and rotation means minting a new entrypoint rather than changing a key. Also corrects one stale comment: a redirect test said the inbound signature was one "the receiver verifies", which in this repo's vocabulary names webhooker's own receiver. The endpoint that verifies it is the delivery target's.
This commit is contained in:
@@ -170,7 +170,8 @@ func TestDelivery_CrossOriginRedirectDropsOriginScopedHeaders(
|
||||
// Stripping must not fire within the configured origin, or every
|
||||
// destination that redirects its own path would lose its
|
||||
// credential and start answering 401 — and would lose the inbound
|
||||
// signature the receiver verifies.
|
||||
// signature header the target endpoint verifies. webhooker's own
|
||||
// receiver verifies no signature; it only forwards the header.
|
||||
func TestDelivery_SameOriginRedirectKeepsOriginScopedHeaders(
|
||||
t *testing.T,
|
||||
) {
|
||||
|
||||
Reference in New Issue
Block a user