Store a target's settings as columns (closes #543)

A target's settings move from the per-type JSON string in
targets.config to columns: url, headers, timeout_seconds,
forward_query, archive_expiry and archive_rotation. A column a type
does not use stays empty. headers holds the header map as JSON text
through GORM's JSON serializer, and archive_expiry holds a
time.Duration, 0 meaning never. The forms check each setting once,
with the same refusals and messages, and the edit form is filled from
the columns, so the per-type config structs, their parsers and the
"could not be read" branches are gone. A delivery task carries the
six settings in place of the JSON string; tests check that each copy
into a task, and back out of one, keeps all six.

Model: opus-5-5

internal/handlers/archive_expiry_test.go

@@ -7,6 +7,7 @@ import (
 	"regexp"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -94,14 +95,18 @@ func TestArchiveExpiryChoices(t *testing.T) {
 
 	env := setupSourceTest(t)
 
-	choices := []struct{ value, shown string }{
-		{expiryNever, expiryNever},
-		{"1h", "1 hour"},
-		{"12h", "12 hours"},
-		{"24h", "1 day"},
-		{"720h", "30 days"},
-		{"2160h", "90 days"},
-		{"8760h", "365 days"},
+	choices := []struct {
+		value  string
+		stored time.Duration
+		shown  string
+	}{
+		{expiryNever, 0, expiryNever},
+		{"1h", time.Hour, "1 hour"},
+		{"12h", 12 * time.Hour, "12 hours"},
+		{"24h", 24 * time.Hour, "1 day"},
+		{"720h", 720 * time.Hour, "30 days"},
+		{"2160h", 2160 * time.Hour, "90 days"},
+		{"8760h", 8760 * time.Hour, "365 days"},
 	}
 
 	for _, choice := range choices {
@@ -122,9 +127,7 @@ func TestArchiveExpiryChoices(t *testing.T) {
 
 			targets := targetsForWebhook(t, env.db, webhook.ID)
 			require.Len(t, targets, 1)
-			assert.JSONEq(
-				t, `{"expiry":"`+choice.value+`"}`, targets[0].Config,
-			)
+			assert.Equal(t, choice.stored, targets[0].ArchiveExpiry)
 
 			assert.Equal(
 				t, []string{choice.shown},
@@ -138,7 +141,7 @@ func TestArchiveExpiryChoices(t *testing.T) {
 }
 
 // TestArchiveExpiryEditStartsOnStoredValue checks the edit form of a
-// database target whose stored expiry is empty, which selects never,
+// database target whose stored expiry is 0, which selects never,
 // and of one whose expiry is not one of the choices, which is listed
 // first as its own selected entry and saved unchanged.
 func TestArchiveExpiryEditStartsOnStoredValue(t *testing.T) {
@@ -148,7 +151,8 @@ func TestArchiveExpiryEditStartsOnStoredValue(t *testing.T) {
 
 	webhook := seedWebhookWithRetention(t, env.db, 30)
 	empty := seedConfiguredTarget(
-		t, env.db, webhook.ID, database.TargetTypeDatabase, "",
+		t, env.db, webhook.ID, database.TargetTypeDatabase,
+		database.Target{},
 	)
 
 	_, selected := expirySelected(t, env, webhook.ID, empty.ID)
@@ -157,7 +161,7 @@ func TestArchiveExpiryEditStartsOnStoredValue(t *testing.T) {
 	webhook = seedWebhookWithRetention(t, env.db, 30)
 	unlisted := seedConfiguredTarget(
 		t, env.db, webhook.ID, database.TargetTypeDatabase,
-		`{"expiry":"36h"}`,
+		database.Target{ArchiveExpiry: 36 * time.Hour},
 	)
 
 	assert.Equal(t, []string{"36 hours"}, expiryShown(t, env, webhook.ID))
@@ -179,7 +183,7 @@ func TestArchiveExpiryEditStartsOnStoredValue(t *testing.T) {
 
 	w := submitTargetEdit(env, webhook.ID, unlisted.ID, form)
 	require.Equal(t, http.StatusSeeOther, w.Code, w.Body.String())
-	assert.JSONEq(
-		t, `{"expiry":"36h"}`, storedTarget(t, env, unlisted.ID).Config,
+	assert.Equal(
+		t, 36*time.Hour, storedTarget(t, env, unlisted.ID).ArchiveExpiry,
 	)
 }