Raise HTTP WriteTimeout above the request middleware timeout (closes #62) (#72)
All checks were successful
check / check (push) Successful in 4s
All checks were successful
check / check (push) Successful in 4s
Raise `httpWriteTimeout` in `internal/server/http.go` from 10s to `65 * time.Second` so it comfortably exceeds the router's 60s `requestTimeout`. This makes the `middleware.Timeout(60s)` the effective request limit — a slow response now returns a clean 503 from the middleware instead of being cut at the socket write deadline by the transport. `httpReadTimeout` stays at 10s. A comment on `httpWriteTimeout` documents that it must remain above the 60s request timeout. Change is confined to `internal/server/http.go`; `routes.go` is untouched. Closes #62 Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #72 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
This commit was merged in pull request #72.
This commit is contained in:
@@ -13,8 +13,11 @@ const (
|
|||||||
httpReadTimeout = 10 * time.Second
|
httpReadTimeout = 10 * time.Second
|
||||||
|
|
||||||
// httpWriteTimeout is the maximum duration before timing out
|
// httpWriteTimeout is the maximum duration before timing out
|
||||||
// writes of the response.
|
// writes of the response. It must stay above the router's
|
||||||
httpWriteTimeout = 10 * time.Second
|
// requestTimeout (60s, in routes.go) so the middleware timeout
|
||||||
|
// fires first and returns a clean 503, rather than the transport
|
||||||
|
// cutting the connection at the socket write deadline.
|
||||||
|
httpWriteTimeout = 65 * time.Second
|
||||||
|
|
||||||
// httpMaxHeaderBytes is the maximum number of bytes the
|
// httpMaxHeaderBytes is the maximum number of bytes the
|
||||||
// server will read parsing the request headers.
|
// server will read parsing the request headers.
|
||||||
|
|||||||
Reference in New Issue
Block a user