All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
225 lines
4.8 KiB
Go
225 lines
4.8 KiB
Go
package database_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"sneak.berlin/go/vaultik/internal/database"
|
|
"sneak.berlin/go/vaultik/internal/types"
|
|
)
|
|
|
|
func TestFileChunkRepository(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
db, cleanup := setupTestDB(t)
|
|
defer cleanup()
|
|
|
|
ctx := context.Background()
|
|
repo := database.NewFileChunkRepository(db)
|
|
fileRepo := database.NewFileRepository(db)
|
|
repos := database.NewRepositories(db)
|
|
|
|
// Create test file first
|
|
testTime := time.Now().Truncate(time.Second)
|
|
file := &database.File{
|
|
Path: testFileTxt,
|
|
MTime: testTime,
|
|
Size: 3072,
|
|
Mode: 0644,
|
|
UID: 1000,
|
|
GID: 1000,
|
|
LinkTarget: "",
|
|
}
|
|
|
|
mustCreateFile(t, fileRepo, file)
|
|
mustCreateChunks(t, repos, chunk1Hash, chunk2Hash, chunk3Hash)
|
|
|
|
// Test Create
|
|
fc1 := &database.FileChunk{
|
|
FileID: file.ID,
|
|
Idx: 0,
|
|
ChunkHash: types.ChunkHash(chunk1Hash),
|
|
}
|
|
|
|
err := repo.Create(ctx, nil, fc1)
|
|
if err != nil {
|
|
t.Fatalf("failed to create file chunk: %v", err)
|
|
}
|
|
|
|
// Add more chunks for the same file
|
|
fc2 := &database.FileChunk{
|
|
FileID: file.ID,
|
|
Idx: 1,
|
|
ChunkHash: types.ChunkHash(chunk2Hash),
|
|
}
|
|
|
|
err = repo.Create(ctx, nil, fc2)
|
|
if err != nil {
|
|
t.Fatalf("failed to create second file chunk: %v", err)
|
|
}
|
|
|
|
fc3 := &database.FileChunk{
|
|
FileID: file.ID,
|
|
Idx: 2,
|
|
ChunkHash: types.ChunkHash(chunk3Hash),
|
|
}
|
|
|
|
err = repo.Create(ctx, nil, fc3)
|
|
if err != nil {
|
|
t.Fatalf("failed to create third file chunk: %v", err)
|
|
}
|
|
|
|
// Test GetByFile
|
|
fileChunks, err := repo.GetByFile(ctx, testFileTxt)
|
|
if err != nil {
|
|
t.Fatalf("failed to get file chunks: %v", err)
|
|
}
|
|
|
|
if len(fileChunks) != 3 {
|
|
t.Errorf("expected 3 chunks, got %d", len(fileChunks))
|
|
}
|
|
|
|
// Verify order
|
|
for i, chunk := range fileChunks {
|
|
if chunk.Idx != i {
|
|
t.Errorf("wrong chunk order: expected idx %d, got %d", i, chunk.Idx)
|
|
}
|
|
}
|
|
|
|
// Test duplicate insert (should be idempotent)
|
|
err = repo.Create(ctx, nil, fc1)
|
|
if err != nil {
|
|
t.Fatalf("failed to create duplicate file chunk: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestFileChunkRepositoryDeleteByFileID(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
db, cleanup := setupTestDB(t)
|
|
defer cleanup()
|
|
|
|
ctx := context.Background()
|
|
repo := database.NewFileChunkRepository(db)
|
|
fileRepo := database.NewFileRepository(db)
|
|
repos := database.NewRepositories(db)
|
|
|
|
file := &database.File{
|
|
Path: testFileTxt,
|
|
MTime: time.Now().Truncate(time.Second),
|
|
Size: 1024,
|
|
Mode: 0644,
|
|
UID: 1000,
|
|
GID: 1000,
|
|
}
|
|
|
|
mustCreateFile(t, fileRepo, file)
|
|
mustCreateChunks(t, repos, chunk1Hash)
|
|
|
|
fc := &database.FileChunk{
|
|
FileID: file.ID,
|
|
Idx: 0,
|
|
ChunkHash: types.ChunkHash(chunk1Hash),
|
|
}
|
|
|
|
err := repo.Create(ctx, nil, fc)
|
|
if err != nil {
|
|
t.Fatalf("failed to create file chunk: %v", err)
|
|
}
|
|
|
|
// Test DeleteByFileID
|
|
err = repo.DeleteByFileID(ctx, nil, file.ID)
|
|
if err != nil {
|
|
t.Fatalf("failed to delete file chunks: %v", err)
|
|
}
|
|
|
|
fileChunks, err := repo.GetByFileID(ctx, file.ID)
|
|
if err != nil {
|
|
t.Fatalf("failed to get deleted file chunks: %v", err)
|
|
}
|
|
|
|
if len(fileChunks) != 0 {
|
|
t.Errorf("expected 0 chunks after delete, got %d", len(fileChunks))
|
|
}
|
|
}
|
|
|
|
func TestFileChunkRepositoryMultipleFiles(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
db, cleanup := setupTestDB(t)
|
|
defer cleanup()
|
|
|
|
ctx := context.Background()
|
|
repo := database.NewFileChunkRepository(db)
|
|
fileRepo := database.NewFileRepository(db)
|
|
|
|
// Create test files
|
|
testTime := time.Now().Truncate(time.Second)
|
|
filePaths := []string{testFilePath1, testFilePath2, "/file3.txt"}
|
|
files := make([]*database.File, len(filePaths))
|
|
|
|
for i, path := range filePaths {
|
|
file := &database.File{
|
|
Path: types.FilePath(path),
|
|
MTime: testTime,
|
|
Size: 2048,
|
|
Mode: 0644,
|
|
UID: 1000,
|
|
GID: 1000,
|
|
LinkTarget: "",
|
|
}
|
|
|
|
mustCreateFile(t, fileRepo, file)
|
|
|
|
files[i] = file
|
|
}
|
|
|
|
// Create all chunks first
|
|
chunkRepo := database.NewChunkRepository(db)
|
|
|
|
for i := range files {
|
|
for j := range 2 {
|
|
chunkHash := types.ChunkHash(fmt.Sprintf("file%d_chunk%d", i, j))
|
|
chunk := &database.Chunk{
|
|
ChunkHash: chunkHash,
|
|
Size: 1024,
|
|
}
|
|
|
|
err := chunkRepo.Create(ctx, nil, chunk)
|
|
if err != nil {
|
|
t.Fatalf("failed to create chunk %s: %v", chunkHash, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Create chunks for multiple files
|
|
for i, file := range files {
|
|
for j := range 2 {
|
|
fc := &database.FileChunk{
|
|
FileID: file.ID,
|
|
Idx: j,
|
|
ChunkHash: types.ChunkHash(fmt.Sprintf("file%d_chunk%d", i, j)),
|
|
}
|
|
|
|
err := repo.Create(ctx, nil, fc)
|
|
if err != nil {
|
|
t.Fatalf("failed to create file chunk: %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Verify each file has correct chunks
|
|
for i, file := range files {
|
|
chunks, err := repo.GetByFileID(ctx, file.ID)
|
|
if err != nil {
|
|
t.Fatalf("failed to get chunks for file %d: %v", i, err)
|
|
}
|
|
|
|
if len(chunks) != 2 {
|
|
t.Errorf("expected 2 chunks for file %d, got %d", i, len(chunks))
|
|
}
|
|
}
|
|
}
|