The ten sqlclosecheck findings were not leaks: every one of these queries already deferred a close through the package-local CloseRows helper. sqlclosecheck only recognises a Close call on the rows value in the function that produced it (directly deferred, or inside a deferred closure), so a call that hands rows to a helper reads as unhandled. Rather than keep a helper the linter cannot see through, drop CloseRows and defer a closure that calls rows.Close() directly at each of the eighteen call sites, keeping the existing fatal-on-close-error behaviour byte for byte. The close still runs exactly once, on function exit, after the rows have been read. Fatalf stays; it is still used by the transaction helpers.
196 lines
4.4 KiB
Go
196 lines
4.4 KiB
Go
package database
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
)
|
|
|
|
// BlobChunkRepository provides access to the blob_chunks table, which maps
|
|
// blobs to the chunks they contain (with offset and length).
|
|
type BlobChunkRepository struct {
|
|
db *DB
|
|
}
|
|
|
|
// NewBlobChunkRepository creates a BlobChunkRepository backed by db.
|
|
func NewBlobChunkRepository(db *DB) *BlobChunkRepository {
|
|
return &BlobChunkRepository{db: db}
|
|
}
|
|
|
|
// Create inserts a blob_chunks row, using tx when non-nil.
|
|
func (r *BlobChunkRepository) Create(
|
|
ctx context.Context, tx *sql.Tx, bc *BlobChunk,
|
|
) error {
|
|
query := `
|
|
INSERT INTO blob_chunks (blob_id, chunk_hash, offset, length)
|
|
VALUES (?, ?, ?, ?)
|
|
`
|
|
|
|
var err error
|
|
if tx != nil {
|
|
_, err = tx.ExecContext(ctx, query, bc.BlobID, bc.ChunkHash, bc.Offset, bc.Length)
|
|
} else {
|
|
_, err = r.db.ExecWithLog(ctx, query, bc.BlobID, bc.ChunkHash, bc.Offset, bc.Length)
|
|
}
|
|
|
|
if err != nil {
|
|
return fmt.Errorf("inserting blob_chunk: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// GetByBlobID returns all chunks contained in the given blob, ordered by
|
|
// their offset within the blob.
|
|
func (r *BlobChunkRepository) GetByBlobID(
|
|
ctx context.Context, blobID string,
|
|
) ([]*BlobChunk, error) {
|
|
query := `
|
|
SELECT blob_id, chunk_hash, offset, length
|
|
FROM blob_chunks
|
|
WHERE blob_id = ?
|
|
ORDER BY offset
|
|
`
|
|
|
|
rows, err := r.db.conn.QueryContext(ctx, query, blobID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("querying blob chunks: %w", err)
|
|
}
|
|
|
|
defer func() {
|
|
err := rows.Close()
|
|
if err != nil {
|
|
Fatalf("failed to close rows: %v", err)
|
|
}
|
|
}()
|
|
|
|
var blobChunks []*BlobChunk
|
|
|
|
for rows.Next() {
|
|
var bc BlobChunk
|
|
|
|
err := rows.Scan(&bc.BlobID, &bc.ChunkHash, &bc.Offset, &bc.Length)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("scanning blob chunk: %w", err)
|
|
}
|
|
|
|
blobChunks = append(blobChunks, &bc)
|
|
}
|
|
|
|
return blobChunks, rows.Err()
|
|
}
|
|
|
|
// GetByChunkHash returns one blob_chunks row containing the given chunk,
|
|
// or nil if the chunk is not packed in any blob.
|
|
func (r *BlobChunkRepository) GetByChunkHash(
|
|
ctx context.Context, chunkHash string,
|
|
) (*BlobChunk, error) {
|
|
query := `
|
|
SELECT blob_id, chunk_hash, offset, length
|
|
FROM blob_chunks
|
|
WHERE chunk_hash = ?
|
|
LIMIT 1
|
|
`
|
|
|
|
LogSQL("GetByChunkHash", query, chunkHash)
|
|
|
|
var bc BlobChunk
|
|
|
|
err := r.db.conn.QueryRowContext(ctx, query, chunkHash).Scan(
|
|
&bc.BlobID,
|
|
&bc.ChunkHash,
|
|
&bc.Offset,
|
|
&bc.Length,
|
|
)
|
|
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
LogSQL("GetByChunkHash", "No rows found", chunkHash)
|
|
|
|
return nil, nil //nolint:nilnil // nil,nil signals not-found; callers check nil
|
|
}
|
|
|
|
if err != nil {
|
|
LogSQL("GetByChunkHash", "Error", chunkHash, err)
|
|
|
|
return nil, fmt.Errorf("querying blob chunk: %w", err)
|
|
}
|
|
|
|
LogSQL("GetByChunkHash", "Found blob", chunkHash, "blob", bc.BlobID)
|
|
|
|
return &bc, nil
|
|
}
|
|
|
|
// GetByChunkHashTx retrieves a blob chunk within a transaction
|
|
func (r *BlobChunkRepository) GetByChunkHashTx(
|
|
ctx context.Context, tx *sql.Tx, chunkHash string,
|
|
) (*BlobChunk, error) {
|
|
query := `
|
|
SELECT blob_id, chunk_hash, offset, length
|
|
FROM blob_chunks
|
|
WHERE chunk_hash = ?
|
|
LIMIT 1
|
|
`
|
|
|
|
LogSQL("GetByChunkHashTx", query, chunkHash)
|
|
|
|
var bc BlobChunk
|
|
|
|
err := tx.QueryRowContext(ctx, query, chunkHash).Scan(
|
|
&bc.BlobID,
|
|
&bc.ChunkHash,
|
|
&bc.Offset,
|
|
&bc.Length,
|
|
)
|
|
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
LogSQL("GetByChunkHashTx", "No rows found", chunkHash)
|
|
|
|
return nil, nil //nolint:nilnil // nil,nil signals not-found; callers check nil
|
|
}
|
|
|
|
if err != nil {
|
|
LogSQL("GetByChunkHashTx", "Error", chunkHash, err)
|
|
|
|
return nil, fmt.Errorf("querying blob chunk: %w", err)
|
|
}
|
|
|
|
LogSQL("GetByChunkHashTx", "Found blob", chunkHash, "blob", bc.BlobID)
|
|
|
|
return &bc, nil
|
|
}
|
|
|
|
// DeleteOrphaned deletes blob_chunks entries where either the blob or the
|
|
// chunk no longer exists.
|
|
func (r *BlobChunkRepository) DeleteOrphaned(ctx context.Context) error {
|
|
// Delete blob_chunks where the blob doesn't exist
|
|
query1 := `
|
|
DELETE FROM blob_chunks
|
|
WHERE NOT EXISTS (
|
|
SELECT 1 FROM blobs
|
|
WHERE blobs.id = blob_chunks.blob_id
|
|
)
|
|
`
|
|
|
|
_, err := r.db.ExecWithLog(ctx, query1)
|
|
if err != nil {
|
|
return fmt.Errorf("deleting blob_chunks with missing blobs: %w", err)
|
|
}
|
|
|
|
// Delete blob_chunks where the chunk doesn't exist
|
|
query2 := `
|
|
DELETE FROM blob_chunks
|
|
WHERE NOT EXISTS (
|
|
SELECT 1 FROM chunks
|
|
WHERE chunks.chunk_hash = blob_chunks.chunk_hash
|
|
)
|
|
`
|
|
|
|
_, err = r.db.ExecWithLog(ctx, query2)
|
|
if err != nil {
|
|
return fmt.Errorf("deleting blob_chunks with missing chunks: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|