clawbot
cc58583130
All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
81 lines
2.5 KiB
Go
81 lines
2.5 KiB
Go
package blobgen_test
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/rand"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"sneak.berlin/go/vaultik/internal/blobgen"
|
|
)
|
|
|
|
// testRecipient is a static age recipient for tests.
|
|
const testRecipient = "age1cplgrwj77ta54dnmydvvmzn64ltk83ankxl5sww04mrtmu62kv3s89gmvv"
|
|
|
|
// TestCompressStreamNoDoubleClose is a regression test for issue #28.
|
|
// It verifies that CompressStream does not panic or return an error due to
|
|
// double-closing the underlying blobgen.Writer. Before the fix in PR #33,
|
|
// the explicit Close() on the happy path combined with defer Close() would
|
|
// cause a double close.
|
|
func TestCompressStreamNoDoubleClose(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
input := []byte("regression test data for issue #28 double-close fix")
|
|
|
|
var buf bytes.Buffer
|
|
|
|
written, hash, err := blobgen.CompressStream(
|
|
&buf, bytes.NewReader(input), 3, []string{testRecipient})
|
|
require.NoError(t, err, "CompressStream should not return an error")
|
|
assert.Positive(t, written, "expected bytes written > 0")
|
|
assert.NotEmpty(t, hash, "expected non-empty hash")
|
|
assert.Positive(t, buf.Len(), "expected non-empty output")
|
|
}
|
|
|
|
// TestCompressStreamLargeInput exercises CompressStream with a larger payload
|
|
// to ensure no double-close issues surface under heavier I/O.
|
|
func TestCompressStreamLargeInput(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
data := make([]byte, 512*1024) // 512 KB
|
|
_, err := rand.Read(data)
|
|
require.NoError(t, err)
|
|
|
|
var buf bytes.Buffer
|
|
|
|
written, hash, err := blobgen.CompressStream(
|
|
&buf, bytes.NewReader(data), 3, []string{testRecipient})
|
|
require.NoError(t, err)
|
|
assert.Positive(t, written)
|
|
assert.NotEmpty(t, hash)
|
|
}
|
|
|
|
// TestCompressStreamEmptyInput verifies CompressStream handles empty input
|
|
// without double-close issues.
|
|
func TestCompressStreamEmptyInput(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
var buf bytes.Buffer
|
|
|
|
_, hash, err := blobgen.CompressStream(
|
|
&buf, strings.NewReader(""), 3, []string{testRecipient})
|
|
require.NoError(t, err)
|
|
assert.NotEmpty(t, hash)
|
|
}
|
|
|
|
// TestCompressDataNoDoubleClose mirrors the stream test for CompressData,
|
|
// ensuring the explicit Close + error-path Close pattern is also safe.
|
|
func TestCompressDataNoDoubleClose(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
input := []byte("CompressData regression test for double-close")
|
|
|
|
result, err := blobgen.CompressData(input, 3, []string{testRecipient})
|
|
require.NoError(t, err)
|
|
assert.Positive(t, result.CompressedSize)
|
|
assert.Equal(t, result.UncompressedSize, int64(len(input)))
|
|
assert.NotEmpty(t, result.SHA256)
|
|
}
|