This commit represents a significant architectural overhaul of vaultik: Database Schema Changes: - Switch files table to use UUID primary keys instead of path-based keys - Add UUID primary keys to blobs table for immediate chunk association - Update all foreign key relationships to use UUIDs - Add comprehensive schema documentation in DATAMODEL.md - Add SQLite busy timeout handling for concurrent operations Streaming and Performance Improvements: - Implement true streaming blob packing without intermediate storage - Add streaming chunk processing to reduce memory usage - Improve progress reporting with real-time metrics - Add upload metrics tracking in new uploads table CLI Refactoring: - Restructure CLI to use subcommands: snapshot create/list/purge/verify - Add store info command for S3 configuration display - Add custom duration parser supporting days/weeks/months/years - Remove old backup.go in favor of enhanced snapshot.go - Add --cron flag for silent operation Configuration Changes: - Remove unused index_prefix configuration option - Add support for snapshot pruning retention policies - Improve configuration validation and error messages Testing Improvements: - Add comprehensive repository tests with edge cases - Add cascade delete debugging tests - Fix concurrent operation tests to use SQLite busy timeout - Remove tolerance for SQLITE_BUSY errors in tests Documentation: - Add MIT LICENSE file - Update README with new command structure - Add comprehensive DATAMODEL.md explaining database schema - Update DESIGN.md with UUID-based architecture Other Changes: - Add test-config.yml for testing - Update Makefile with better test output formatting - Fix various race conditions in concurrent operations - Improve error handling throughout
264 lines
5.4 KiB
Go
264 lines
5.4 KiB
Go
package cli
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestParseDuration(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
input string
|
|
expected time.Duration
|
|
wantErr bool
|
|
}{
|
|
// Standard Go durations
|
|
{
|
|
name: "standard seconds",
|
|
input: "30s",
|
|
expected: 30 * time.Second,
|
|
},
|
|
{
|
|
name: "standard minutes",
|
|
input: "45m",
|
|
expected: 45 * time.Minute,
|
|
},
|
|
{
|
|
name: "standard hours",
|
|
input: "2h",
|
|
expected: 2 * time.Hour,
|
|
},
|
|
{
|
|
name: "standard combined",
|
|
input: "3h30m",
|
|
expected: 3*time.Hour + 30*time.Minute,
|
|
},
|
|
{
|
|
name: "standard complex",
|
|
input: "1h45m30s",
|
|
expected: 1*time.Hour + 45*time.Minute + 30*time.Second,
|
|
},
|
|
{
|
|
name: "standard with milliseconds",
|
|
input: "1s500ms",
|
|
expected: 1*time.Second + 500*time.Millisecond,
|
|
},
|
|
// Extended units - days
|
|
{
|
|
name: "single day",
|
|
input: "1d",
|
|
expected: 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "multiple days",
|
|
input: "7d",
|
|
expected: 7 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "fractional days",
|
|
input: "1.5d",
|
|
expected: 36 * time.Hour,
|
|
},
|
|
{
|
|
name: "days spelled out",
|
|
input: "3days",
|
|
expected: 3 * 24 * time.Hour,
|
|
},
|
|
// Extended units - weeks
|
|
{
|
|
name: "single week",
|
|
input: "1w",
|
|
expected: 7 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "multiple weeks",
|
|
input: "4w",
|
|
expected: 4 * 7 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "weeks spelled out",
|
|
input: "2weeks",
|
|
expected: 2 * 7 * 24 * time.Hour,
|
|
},
|
|
// Extended units - months
|
|
{
|
|
name: "single month",
|
|
input: "1mo",
|
|
expected: 30 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "multiple months",
|
|
input: "6mo",
|
|
expected: 6 * 30 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "months spelled out",
|
|
input: "3months",
|
|
expected: 3 * 30 * 24 * time.Hour,
|
|
},
|
|
// Extended units - years
|
|
{
|
|
name: "single year",
|
|
input: "1y",
|
|
expected: 365 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "multiple years",
|
|
input: "2y",
|
|
expected: 2 * 365 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "years spelled out",
|
|
input: "1year",
|
|
expected: 365 * 24 * time.Hour,
|
|
},
|
|
// Combined extended units
|
|
{
|
|
name: "weeks and days",
|
|
input: "2w3d",
|
|
expected: 2*7*24*time.Hour + 3*24*time.Hour,
|
|
},
|
|
{
|
|
name: "years and months",
|
|
input: "1y6mo",
|
|
expected: 365*24*time.Hour + 6*30*24*time.Hour,
|
|
},
|
|
{
|
|
name: "days and hours",
|
|
input: "1d12h",
|
|
expected: 24*time.Hour + 12*time.Hour,
|
|
},
|
|
{
|
|
name: "complex combination",
|
|
input: "1y2mo3w4d5h6m7s",
|
|
expected: 365*24*time.Hour + 2*30*24*time.Hour + 3*7*24*time.Hour + 4*24*time.Hour + 5*time.Hour + 6*time.Minute + 7*time.Second,
|
|
},
|
|
{
|
|
name: "with spaces",
|
|
input: "1d 12h 30m",
|
|
expected: 24*time.Hour + 12*time.Hour + 30*time.Minute,
|
|
},
|
|
// Edge cases
|
|
{
|
|
name: "zero duration",
|
|
input: "0s",
|
|
expected: 0,
|
|
},
|
|
{
|
|
name: "large duration",
|
|
input: "10y",
|
|
expected: 10 * 365 * 24 * time.Hour,
|
|
},
|
|
// Error cases
|
|
{
|
|
name: "empty string",
|
|
input: "",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "invalid format",
|
|
input: "abc",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "unknown unit",
|
|
input: "5x",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "invalid number",
|
|
input: "xyzd",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "negative not supported",
|
|
input: "-5d",
|
|
wantErr: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, err := parseDuration(tt.input)
|
|
|
|
if tt.wantErr {
|
|
assert.Error(t, err, "expected error for input %q", tt.input)
|
|
return
|
|
}
|
|
|
|
assert.NoError(t, err, "unexpected error for input %q", tt.input)
|
|
assert.Equal(t, tt.expected, got, "duration mismatch for input %q", tt.input)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseDurationSpecialCases(t *testing.T) {
|
|
// Test that standard Go durations work exactly as expected
|
|
standardDurations := []string{
|
|
"300ms",
|
|
"1.5h",
|
|
"2h45m",
|
|
"72h",
|
|
"1us",
|
|
"1µs",
|
|
"1ns",
|
|
}
|
|
|
|
for _, d := range standardDurations {
|
|
expected, err := time.ParseDuration(d)
|
|
assert.NoError(t, err)
|
|
|
|
got, err := parseDuration(d)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, expected, got, "standard duration %q should parse identically", d)
|
|
}
|
|
}
|
|
|
|
func TestParseDurationRealWorldExamples(t *testing.T) {
|
|
// Test real-world snapshot purge scenarios
|
|
tests := []struct {
|
|
description string
|
|
input string
|
|
olderThan time.Duration
|
|
}{
|
|
{
|
|
description: "keep snapshots from last 30 days",
|
|
input: "30d",
|
|
olderThan: 30 * 24 * time.Hour,
|
|
},
|
|
{
|
|
description: "keep snapshots from last 6 months",
|
|
input: "6mo",
|
|
olderThan: 6 * 30 * 24 * time.Hour,
|
|
},
|
|
{
|
|
description: "keep snapshots from last year",
|
|
input: "1y",
|
|
olderThan: 365 * 24 * time.Hour,
|
|
},
|
|
{
|
|
description: "keep snapshots from last week and a half",
|
|
input: "1w3d",
|
|
olderThan: 10 * 24 * time.Hour,
|
|
},
|
|
{
|
|
description: "keep snapshots from last 90 days",
|
|
input: "90d",
|
|
olderThan: 90 * 24 * time.Hour,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.description, func(t *testing.T) {
|
|
got, err := parseDuration(tt.input)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, tt.olderThan, got)
|
|
|
|
// Verify the duration makes sense for snapshot purging
|
|
assert.Greater(t, got, time.Hour, "snapshot purge duration should be at least an hour")
|
|
})
|
|
}
|
|
}
|