All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
127 lines
3.4 KiB
Go
127 lines
3.4 KiB
Go
package database
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
)
|
|
|
|
// Repositories provides access to all database repositories.
|
|
// It serves as a centralized access point for all database operations
|
|
// and manages transaction coordination across repositories.
|
|
type Repositories struct {
|
|
db *DB
|
|
Files *FileRepository
|
|
Chunks *ChunkRepository
|
|
Blobs *BlobRepository
|
|
FileChunks *FileChunkRepository
|
|
BlobChunks *BlobChunkRepository
|
|
ChunkFiles *ChunkFileRepository
|
|
Snapshots *SnapshotRepository
|
|
Uploads *UploadRepository
|
|
LocalMeta *LocalMetaRepository
|
|
}
|
|
|
|
// NewRepositories creates a new Repositories instance with all repository types.
|
|
// Each repository shares the same database connection for coordinated transactions.
|
|
func NewRepositories(db *DB) *Repositories {
|
|
return &Repositories{
|
|
db: db,
|
|
Files: NewFileRepository(db),
|
|
Chunks: NewChunkRepository(db),
|
|
Blobs: NewBlobRepository(db),
|
|
FileChunks: NewFileChunkRepository(db),
|
|
BlobChunks: NewBlobChunkRepository(db),
|
|
ChunkFiles: NewChunkFileRepository(db),
|
|
Snapshots: NewSnapshotRepository(db),
|
|
Uploads: NewUploadRepository(db.conn),
|
|
LocalMeta: NewLocalMetaRepository(db),
|
|
}
|
|
}
|
|
|
|
// TxFunc is a function that executes within a database transaction.
|
|
// The transaction is automatically committed if the function returns nil,
|
|
// or rolled back if it returns an error.
|
|
type TxFunc func(ctx context.Context, tx *sql.Tx) error
|
|
|
|
// WithTx executes a function within a write transaction.
|
|
// SQLite handles its own locking internally, so no explicit locking is needed.
|
|
// The transaction is automatically committed on success or rolled back on error.
|
|
// This method should be used for all write operations to ensure atomicity.
|
|
func (r *Repositories) WithTx(ctx context.Context, fn TxFunc) error {
|
|
LogSQL("WithTx", "Beginning transaction", "")
|
|
|
|
tx, err := r.db.BeginTx(ctx, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("beginning transaction: %w", err)
|
|
}
|
|
|
|
LogSQL("WithTx", "Transaction started", "")
|
|
|
|
defer func() {
|
|
if p := recover(); p != nil {
|
|
rollbackErr := tx.Rollback()
|
|
if rollbackErr != nil {
|
|
Fatalf("failed to rollback transaction: %v", rollbackErr)
|
|
}
|
|
|
|
panic(p)
|
|
} else if err != nil {
|
|
rollbackErr := tx.Rollback()
|
|
if rollbackErr != nil {
|
|
Fatalf("failed to rollback transaction: %v", rollbackErr)
|
|
}
|
|
}
|
|
}()
|
|
|
|
err = fn(ctx, tx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return tx.Commit()
|
|
}
|
|
|
|
// DB returns the underlying database for direct queries
|
|
func (r *Repositories) DB() *DB {
|
|
return r.db
|
|
}
|
|
|
|
// WithReadTx executes a function within a read-only transaction.
|
|
// Read transactions can run concurrently with other read transactions
|
|
// but will be blocked by write transactions. The transaction is
|
|
// automatically committed on success or rolled back on error.
|
|
func (r *Repositories) WithReadTx(ctx context.Context, fn TxFunc) error {
|
|
opts := &sql.TxOptions{
|
|
ReadOnly: true,
|
|
}
|
|
|
|
tx, err := r.db.BeginTx(ctx, opts)
|
|
if err != nil {
|
|
return fmt.Errorf("beginning read transaction: %w", err)
|
|
}
|
|
|
|
defer func() {
|
|
if p := recover(); p != nil {
|
|
rollbackErr := tx.Rollback()
|
|
if rollbackErr != nil {
|
|
Fatalf("failed to rollback transaction: %v", rollbackErr)
|
|
}
|
|
|
|
panic(p)
|
|
} else if err != nil {
|
|
rollbackErr := tx.Rollback()
|
|
if rollbackErr != nil {
|
|
Fatalf("failed to rollback transaction: %v", rollbackErr)
|
|
}
|
|
}
|
|
}()
|
|
|
|
err = fn(ctx, tx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return tx.Commit()
|
|
}
|