All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
190 lines
4.3 KiB
Go
190 lines
4.3 KiB
Go
package database
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
)
|
|
|
|
// BlobChunkRepository provides access to the blob_chunks table, which maps
|
|
// blobs to the chunks they contain (with offset and length).
|
|
type BlobChunkRepository struct {
|
|
db *DB
|
|
}
|
|
|
|
// NewBlobChunkRepository creates a BlobChunkRepository backed by db.
|
|
func NewBlobChunkRepository(db *DB) *BlobChunkRepository {
|
|
return &BlobChunkRepository{db: db}
|
|
}
|
|
|
|
// Create inserts a blob_chunks row, using tx when non-nil.
|
|
func (r *BlobChunkRepository) Create(
|
|
ctx context.Context, tx *sql.Tx, bc *BlobChunk,
|
|
) error {
|
|
query := `
|
|
INSERT INTO blob_chunks (blob_id, chunk_hash, offset, length)
|
|
VALUES (?, ?, ?, ?)
|
|
`
|
|
|
|
var err error
|
|
if tx != nil {
|
|
_, err = tx.ExecContext(ctx, query, bc.BlobID, bc.ChunkHash, bc.Offset, bc.Length)
|
|
} else {
|
|
_, err = r.db.ExecWithLog(ctx, query, bc.BlobID, bc.ChunkHash, bc.Offset, bc.Length)
|
|
}
|
|
|
|
if err != nil {
|
|
return fmt.Errorf("inserting blob_chunk: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// GetByBlobID returns all chunks contained in the given blob, ordered by
|
|
// their offset within the blob.
|
|
func (r *BlobChunkRepository) GetByBlobID(
|
|
ctx context.Context, blobID string,
|
|
) ([]*BlobChunk, error) {
|
|
query := `
|
|
SELECT blob_id, chunk_hash, offset, length
|
|
FROM blob_chunks
|
|
WHERE blob_id = ?
|
|
ORDER BY offset
|
|
`
|
|
|
|
rows, err := r.db.conn.QueryContext(ctx, query, blobID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("querying blob chunks: %w", err)
|
|
}
|
|
defer CloseRows(rows)
|
|
|
|
var blobChunks []*BlobChunk
|
|
|
|
for rows.Next() {
|
|
var bc BlobChunk
|
|
|
|
err := rows.Scan(&bc.BlobID, &bc.ChunkHash, &bc.Offset, &bc.Length)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("scanning blob chunk: %w", err)
|
|
}
|
|
|
|
blobChunks = append(blobChunks, &bc)
|
|
}
|
|
|
|
return blobChunks, rows.Err()
|
|
}
|
|
|
|
// GetByChunkHash returns one blob_chunks row containing the given chunk,
|
|
// or nil if the chunk is not packed in any blob.
|
|
func (r *BlobChunkRepository) GetByChunkHash(
|
|
ctx context.Context, chunkHash string,
|
|
) (*BlobChunk, error) {
|
|
query := `
|
|
SELECT blob_id, chunk_hash, offset, length
|
|
FROM blob_chunks
|
|
WHERE chunk_hash = ?
|
|
LIMIT 1
|
|
`
|
|
|
|
LogSQL("GetByChunkHash", query, chunkHash)
|
|
|
|
var bc BlobChunk
|
|
|
|
err := r.db.conn.QueryRowContext(ctx, query, chunkHash).Scan(
|
|
&bc.BlobID,
|
|
&bc.ChunkHash,
|
|
&bc.Offset,
|
|
&bc.Length,
|
|
)
|
|
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
LogSQL("GetByChunkHash", "No rows found", chunkHash)
|
|
|
|
return nil, nil //nolint:nilnil // nil,nil signals not-found; callers check nil
|
|
}
|
|
|
|
if err != nil {
|
|
LogSQL("GetByChunkHash", "Error", chunkHash, err)
|
|
|
|
return nil, fmt.Errorf("querying blob chunk: %w", err)
|
|
}
|
|
|
|
LogSQL("GetByChunkHash", "Found blob", chunkHash, "blob", bc.BlobID)
|
|
|
|
return &bc, nil
|
|
}
|
|
|
|
// GetByChunkHashTx retrieves a blob chunk within a transaction
|
|
func (r *BlobChunkRepository) GetByChunkHashTx(
|
|
ctx context.Context, tx *sql.Tx, chunkHash string,
|
|
) (*BlobChunk, error) {
|
|
query := `
|
|
SELECT blob_id, chunk_hash, offset, length
|
|
FROM blob_chunks
|
|
WHERE chunk_hash = ?
|
|
LIMIT 1
|
|
`
|
|
|
|
LogSQL("GetByChunkHashTx", query, chunkHash)
|
|
|
|
var bc BlobChunk
|
|
|
|
err := tx.QueryRowContext(ctx, query, chunkHash).Scan(
|
|
&bc.BlobID,
|
|
&bc.ChunkHash,
|
|
&bc.Offset,
|
|
&bc.Length,
|
|
)
|
|
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
LogSQL("GetByChunkHashTx", "No rows found", chunkHash)
|
|
|
|
return nil, nil //nolint:nilnil // nil,nil signals not-found; callers check nil
|
|
}
|
|
|
|
if err != nil {
|
|
LogSQL("GetByChunkHashTx", "Error", chunkHash, err)
|
|
|
|
return nil, fmt.Errorf("querying blob chunk: %w", err)
|
|
}
|
|
|
|
LogSQL("GetByChunkHashTx", "Found blob", chunkHash, "blob", bc.BlobID)
|
|
|
|
return &bc, nil
|
|
}
|
|
|
|
// DeleteOrphaned deletes blob_chunks entries where either the blob or the
|
|
// chunk no longer exists.
|
|
func (r *BlobChunkRepository) DeleteOrphaned(ctx context.Context) error {
|
|
// Delete blob_chunks where the blob doesn't exist
|
|
query1 := `
|
|
DELETE FROM blob_chunks
|
|
WHERE NOT EXISTS (
|
|
SELECT 1 FROM blobs
|
|
WHERE blobs.id = blob_chunks.blob_id
|
|
)
|
|
`
|
|
|
|
_, err := r.db.ExecWithLog(ctx, query1)
|
|
if err != nil {
|
|
return fmt.Errorf("deleting blob_chunks with missing blobs: %w", err)
|
|
}
|
|
|
|
// Delete blob_chunks where the chunk doesn't exist
|
|
query2 := `
|
|
DELETE FROM blob_chunks
|
|
WHERE NOT EXISTS (
|
|
SELECT 1 FROM chunks
|
|
WHERE chunks.chunk_hash = blob_chunks.chunk_hash
|
|
)
|
|
`
|
|
|
|
_, err = r.db.ExecWithLog(ctx, query2)
|
|
if err != nil {
|
|
return fmt.Errorf("deleting blob_chunks with missing chunks: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|