All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
300 lines
6.0 KiB
Go
300 lines
6.0 KiB
Go
package cli //nolint:testpackage // needs access to unexported parseDuration
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type parseDurationCase struct {
|
|
name string
|
|
input string
|
|
expected time.Duration
|
|
wantErr bool
|
|
}
|
|
|
|
// runParseDurationCases executes a table of parseDuration cases as
|
|
// parallel subtests.
|
|
func runParseDurationCases(t *testing.T, tests []parseDurationCase) {
|
|
t.Helper()
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
got, err := parseDuration(tt.input)
|
|
|
|
if tt.wantErr {
|
|
require.Error(t, err, "expected error for input %q", tt.input)
|
|
|
|
return
|
|
}
|
|
|
|
require.NoError(t, err, "unexpected error for input %q", tt.input)
|
|
assert.Equal(t, tt.expected, got, "duration mismatch for input %q", tt.input)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseDurationStandard(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
runParseDurationCases(t, []parseDurationCase{
|
|
{
|
|
name: "standard seconds",
|
|
input: "30s",
|
|
expected: 30 * time.Second,
|
|
},
|
|
{
|
|
name: "standard minutes",
|
|
input: "45m",
|
|
expected: 45 * time.Minute,
|
|
},
|
|
{
|
|
name: "standard hours",
|
|
input: "2h",
|
|
expected: 2 * time.Hour,
|
|
},
|
|
{
|
|
name: "standard combined",
|
|
input: "3h30m",
|
|
expected: 3*time.Hour + 30*time.Minute,
|
|
},
|
|
{
|
|
name: "standard complex",
|
|
input: "1h45m30s",
|
|
expected: 1*time.Hour + 45*time.Minute + 30*time.Second,
|
|
},
|
|
{
|
|
name: "standard with milliseconds",
|
|
input: "1s500ms",
|
|
expected: 1*time.Second + 500*time.Millisecond,
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestParseDurationExtendedUnits(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
runParseDurationCases(t, []parseDurationCase{
|
|
// Extended units - days
|
|
{
|
|
name: "single day",
|
|
input: "1d",
|
|
expected: 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "multiple days",
|
|
input: "7d",
|
|
expected: 7 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "fractional days",
|
|
input: "1.5d",
|
|
expected: 36 * time.Hour,
|
|
},
|
|
{
|
|
name: "days spelled out",
|
|
input: "3days",
|
|
expected: 3 * 24 * time.Hour,
|
|
},
|
|
// Extended units - weeks
|
|
{
|
|
name: "single week",
|
|
input: "1w",
|
|
expected: 7 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "multiple weeks",
|
|
input: "4w",
|
|
expected: 4 * 7 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "weeks spelled out",
|
|
input: "2weeks",
|
|
expected: 2 * 7 * 24 * time.Hour,
|
|
},
|
|
// Extended units - months
|
|
{
|
|
name: "single month",
|
|
input: "1mo",
|
|
expected: 30 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "multiple months",
|
|
input: "6mo",
|
|
expected: 6 * 30 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "months spelled out",
|
|
input: "3months",
|
|
expected: 3 * 30 * 24 * time.Hour,
|
|
},
|
|
// Extended units - years
|
|
{
|
|
name: "single year",
|
|
input: "1y",
|
|
expected: 365 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "multiple years",
|
|
input: "2y",
|
|
expected: 2 * 365 * 24 * time.Hour,
|
|
},
|
|
{
|
|
name: "years spelled out",
|
|
input: "1year",
|
|
expected: 365 * 24 * time.Hour,
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestParseDurationCombinedAndErrors(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
runParseDurationCases(t, []parseDurationCase{
|
|
// Combined extended units
|
|
{
|
|
name: "weeks and days",
|
|
input: "2w3d",
|
|
expected: 2*7*24*time.Hour + 3*24*time.Hour,
|
|
},
|
|
{
|
|
name: "years and months",
|
|
input: "1y6mo",
|
|
expected: 365*24*time.Hour + 6*30*24*time.Hour,
|
|
},
|
|
{
|
|
name: "days and hours",
|
|
input: "1d12h",
|
|
expected: 24*time.Hour + 12*time.Hour,
|
|
},
|
|
{
|
|
name: "complex combination",
|
|
input: "1y2mo3w4d5h6m7s",
|
|
expected: 365*24*time.Hour + 2*30*24*time.Hour +
|
|
3*7*24*time.Hour + 4*24*time.Hour +
|
|
5*time.Hour + 6*time.Minute + 7*time.Second,
|
|
},
|
|
{
|
|
name: "with spaces",
|
|
input: "1d 12h 30m",
|
|
expected: 24*time.Hour + 12*time.Hour + 30*time.Minute,
|
|
},
|
|
// Edge cases
|
|
{
|
|
name: "zero duration",
|
|
input: "0s",
|
|
expected: 0,
|
|
},
|
|
{
|
|
name: "large duration",
|
|
input: "10y",
|
|
expected: 10 * 365 * 24 * time.Hour,
|
|
},
|
|
// Error cases
|
|
{
|
|
name: "empty string",
|
|
input: "",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "invalid format",
|
|
input: "abc",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "unknown unit",
|
|
input: "5x",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "invalid number",
|
|
input: "xyzd",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "negative not supported",
|
|
input: "-5d",
|
|
wantErr: true,
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestParseDurationSpecialCases(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Test that standard Go durations work exactly as expected
|
|
standardDurations := []string{
|
|
"300ms",
|
|
"1.5h",
|
|
"2h45m",
|
|
"72h",
|
|
"1us",
|
|
"1µs",
|
|
"1ns",
|
|
}
|
|
|
|
for _, d := range standardDurations {
|
|
expected, err := time.ParseDuration(d)
|
|
require.NoError(t, err)
|
|
|
|
got, err := parseDuration(d)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expected, got, "standard duration %q should parse identically", d)
|
|
}
|
|
}
|
|
|
|
func TestParseDurationRealWorldExamples(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Test real-world snapshot purge scenarios
|
|
tests := []struct {
|
|
description string
|
|
input string
|
|
olderThan time.Duration
|
|
}{
|
|
{
|
|
description: "keep snapshots from last 30 days",
|
|
input: "30d",
|
|
olderThan: 30 * 24 * time.Hour,
|
|
},
|
|
{
|
|
description: "keep snapshots from last 6 months",
|
|
input: "6mo",
|
|
olderThan: 6 * 30 * 24 * time.Hour,
|
|
},
|
|
{
|
|
description: "keep snapshots from last year",
|
|
input: "1y",
|
|
olderThan: 365 * 24 * time.Hour,
|
|
},
|
|
{
|
|
description: "keep snapshots from last week and a half",
|
|
input: "1w3d",
|
|
olderThan: 10 * 24 * time.Hour,
|
|
},
|
|
{
|
|
description: "keep snapshots from last 90 days",
|
|
input: "90d",
|
|
olderThan: 90 * 24 * time.Hour,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.description, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
got, err := parseDuration(tt.input)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, tt.olderThan, got)
|
|
|
|
// Verify the duration makes sense for snapshot purging
|
|
assert.Greater(t, got, time.Hour,
|
|
"snapshot purge duration should be at least an hour")
|
|
})
|
|
}
|
|
}
|