All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
150 lines
3.4 KiB
Go
150 lines
3.4 KiB
Go
package chunker_test
|
|
|
|
import (
|
|
"bytes"
|
|
"crypto/rand"
|
|
"testing"
|
|
|
|
"sneak.berlin/go/vaultik/internal/chunker"
|
|
)
|
|
|
|
func TestChunkerSmallFileSingleChunk(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
c := chunker.NewChunker(1024 * 1024) // 1MB average
|
|
data := bytes.Repeat([]byte("hello"), 100) // 500 bytes
|
|
|
|
chunks, err := c.ChunkReader(bytes.NewReader(data))
|
|
if err != nil {
|
|
t.Fatalf("chunking failed: %v", err)
|
|
}
|
|
|
|
if len(chunks) != 1 {
|
|
t.Errorf("expected 1 chunk, got %d", len(chunks))
|
|
}
|
|
|
|
if chunks[0].Size != int64(len(data)) {
|
|
t.Errorf("expected chunk size %d, got %d", len(data), chunks[0].Size)
|
|
}
|
|
}
|
|
|
|
func TestChunkerLargeFileMultipleChunks(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
c := chunker.NewChunker(256 * 1024) // 256KB average chunk size
|
|
|
|
// Generate 2MB of random data
|
|
data := make([]byte, 2*1024*1024)
|
|
|
|
_, err := rand.Read(data)
|
|
if err != nil {
|
|
t.Fatalf("failed to generate random data: %v", err)
|
|
}
|
|
|
|
chunks, err := c.ChunkReader(bytes.NewReader(data))
|
|
if err != nil {
|
|
t.Fatalf("chunking failed: %v", err)
|
|
}
|
|
|
|
// Should produce multiple chunks - with FastCDC we expect around 8
|
|
// chunks for 2MB with 256KB average
|
|
if len(chunks) < 4 || len(chunks) > 16 {
|
|
t.Errorf("expected 4-16 chunks, got %d", len(chunks))
|
|
}
|
|
|
|
// Verify chunks reconstruct original data
|
|
var reconstructed []byte
|
|
for _, chunk := range chunks {
|
|
reconstructed = append(reconstructed, chunk.Data...)
|
|
}
|
|
|
|
if !bytes.Equal(data, reconstructed) {
|
|
t.Error("reconstructed data doesn't match original")
|
|
}
|
|
|
|
// Verify offsets
|
|
var expectedOffset int64
|
|
|
|
for i, chunk := range chunks {
|
|
if chunk.Offset != expectedOffset {
|
|
t.Errorf("chunk %d: expected offset %d, got %d",
|
|
i, expectedOffset, chunk.Offset)
|
|
}
|
|
|
|
expectedOffset += chunk.Size
|
|
}
|
|
}
|
|
|
|
func TestChunkerDeterministic(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
chunker1 := chunker.NewChunker(256 * 1024)
|
|
chunker2 := chunker.NewChunker(256 * 1024)
|
|
|
|
// Use deterministic data
|
|
data := bytes.Repeat([]byte("abcdefghijklmnopqrstuvwxyz"), 20000) // ~520KB
|
|
|
|
chunks1, err := chunker1.ChunkReader(bytes.NewReader(data))
|
|
if err != nil {
|
|
t.Fatalf("chunking failed: %v", err)
|
|
}
|
|
|
|
chunks2, err := chunker2.ChunkReader(bytes.NewReader(data))
|
|
if err != nil {
|
|
t.Fatalf("chunking failed: %v", err)
|
|
}
|
|
|
|
// Should produce same chunks
|
|
if len(chunks1) != len(chunks2) {
|
|
t.Fatalf("different number of chunks: %d vs %d",
|
|
len(chunks1), len(chunks2))
|
|
}
|
|
|
|
for i := range chunks1 {
|
|
if chunks1[i].Hash != chunks2[i].Hash {
|
|
t.Errorf("chunk %d: different hashes", i)
|
|
}
|
|
|
|
if chunks1[i].Size != chunks2[i].Size {
|
|
t.Errorf("chunk %d: different sizes", i)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestChunkBoundaries(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
c := chunker.NewChunker(256 * 1024) // 256KB average
|
|
|
|
// FastCDC uses avg/4 for min and avg*4 for max
|
|
avgSize := int64(256 * 1024)
|
|
minSize := avgSize / 4
|
|
maxSize := avgSize * 4
|
|
|
|
// Test that minimum chunk size is respected
|
|
data := make([]byte, minSize+1024)
|
|
|
|
_, err := rand.Read(data)
|
|
if err != nil {
|
|
t.Fatalf("failed to generate random data: %v", err)
|
|
}
|
|
|
|
chunks, err := c.ChunkReader(bytes.NewReader(data))
|
|
if err != nil {
|
|
t.Fatalf("chunking failed: %v", err)
|
|
}
|
|
|
|
for i, chunk := range chunks {
|
|
// Last chunk can be smaller than minimum
|
|
if i < len(chunks)-1 && chunk.Size < minSize {
|
|
t.Errorf("chunk %d size %d is below minimum %d",
|
|
i, chunk.Size, minSize)
|
|
}
|
|
|
|
if chunk.Size > maxSize {
|
|
t.Errorf("chunk %d size %d exceeds maximum %d",
|
|
i, chunk.Size, maxSize)
|
|
}
|
|
}
|
|
}
|