All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
87 lines
2.1 KiB
Go
87 lines
2.1 KiB
Go
package chunker_test
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
|
|
"sneak.berlin/go/vaultik/internal/chunker"
|
|
)
|
|
|
|
func TestChunkerExpectedChunkCount(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
fileSize int
|
|
avgChunkSize int64
|
|
minExpected int
|
|
maxExpected int
|
|
}{
|
|
{
|
|
name: "1MB file with 64KB average",
|
|
fileSize: 1024 * 1024,
|
|
avgChunkSize: 64 * 1024,
|
|
minExpected: 8, // At least half the expected count
|
|
maxExpected: 32, // At most double the expected count
|
|
},
|
|
{
|
|
name: "10MB file with 256KB average",
|
|
fileSize: 10 * 1024 * 1024,
|
|
avgChunkSize: 256 * 1024,
|
|
minExpected: 10, // FastCDC may produce larger chunks
|
|
maxExpected: 80,
|
|
},
|
|
{
|
|
name: "512KB file with 64KB average",
|
|
fileSize: 512 * 1024,
|
|
avgChunkSize: 64 * 1024,
|
|
minExpected: 4, // ~8 expected
|
|
maxExpected: 16,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
c := chunker.NewChunker(tt.avgChunkSize)
|
|
|
|
// Create data with some variation to trigger chunk boundaries
|
|
data := make([]byte, tt.fileSize)
|
|
for i := range data {
|
|
// Use a pattern that should create boundaries
|
|
//nolint:gosec // G115: intentional byte truncation
|
|
data[i] = byte((i * 17) ^ (i >> 5))
|
|
}
|
|
|
|
chunks, err := c.ChunkReader(bytes.NewReader(data))
|
|
if err != nil {
|
|
t.Fatalf("chunking failed: %v", err)
|
|
}
|
|
|
|
t.Logf("Created %d chunks for %d bytes with %d average chunk size",
|
|
len(chunks), tt.fileSize, tt.avgChunkSize)
|
|
|
|
if len(chunks) < tt.minExpected {
|
|
t.Errorf("too few chunks: got %d, expected at least %d",
|
|
len(chunks), tt.minExpected)
|
|
}
|
|
|
|
if len(chunks) > tt.maxExpected {
|
|
t.Errorf("too many chunks: got %d, expected at most %d",
|
|
len(chunks), tt.maxExpected)
|
|
}
|
|
|
|
// Verify chunks reconstruct to original
|
|
var reconstructed []byte
|
|
for _, chunk := range chunks {
|
|
reconstructed = append(reconstructed, chunk.Data...)
|
|
}
|
|
|
|
if !bytes.Equal(data, reconstructed) {
|
|
t.Error("reconstructed data doesn't match original")
|
|
}
|
|
})
|
|
}
|
|
}
|