All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
176 lines
5.5 KiB
Go
176 lines
5.5 KiB
Go
// Package chunker splits input data into content-defined chunks using the
|
|
// FastCDC algorithm so that identical data sequences produce identical
|
|
// chunks regardless of their position in the file.
|
|
package chunker
|
|
|
|
import (
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
)
|
|
|
|
// Chunk represents a single chunk of data produced by the content-defined
|
|
// chunking algorithm. Each chunk is identified by its SHA256 hash and
|
|
// contains the raw data along with its position and size information from
|
|
// the original file.
|
|
type Chunk struct {
|
|
Hash string // Content hash of the chunk
|
|
Data []byte // Chunk data
|
|
Offset int64 // Offset in the original file
|
|
Size int64 // Size of the chunk
|
|
}
|
|
|
|
// Chunker provides content-defined chunking using the FastCDC algorithm.
|
|
// It splits data into variable-sized chunks based on content patterns, ensuring
|
|
// that identical data sequences produce identical chunks regardless of their
|
|
// position in the file. This enables efficient deduplication.
|
|
type Chunker struct {
|
|
avgChunkSize int
|
|
minChunkSize int
|
|
maxChunkSize int
|
|
}
|
|
|
|
// chunkSizeSpread is the FastCDC-recommended factor between the average
|
|
// chunk size and the minimum (avg/spread) and maximum (avg*spread) sizes.
|
|
const chunkSizeSpread = 4
|
|
|
|
// NewChunker creates a new chunker with the specified average chunk size.
|
|
// The actual chunk sizes will vary between avgChunkSize/4 and avgChunkSize*4
|
|
// as recommended by the FastCDC algorithm. Typical values for avgChunkSize
|
|
// are 64KB (65536), 256KB (262144), or 1MB (1048576).
|
|
func NewChunker(avgChunkSize int64) *Chunker {
|
|
// FastCDC recommends min = avg/4 and max = avg*4
|
|
return &Chunker{
|
|
avgChunkSize: int(avgChunkSize),
|
|
minChunkSize: int(avgChunkSize / chunkSizeSpread),
|
|
maxChunkSize: int(avgChunkSize * chunkSizeSpread),
|
|
}
|
|
}
|
|
|
|
// ChunkReader splits the reader into content-defined chunks and returns all
|
|
// chunks at once. This method loads all chunk data into memory, so it should
|
|
// only be used for reasonably sized inputs. For large files or streams, use
|
|
// ChunkReaderStreaming instead.
|
|
// Returns an error if chunking fails or if reading from the input fails.
|
|
func (c *Chunker) ChunkReader(r io.Reader) ([]Chunk, error) {
|
|
chunker := AcquireReusableChunker(
|
|
r, c.minChunkSize, c.avgChunkSize, c.maxChunkSize)
|
|
defer chunker.Release()
|
|
|
|
var chunks []Chunk
|
|
|
|
offset := int64(0)
|
|
|
|
for {
|
|
chunk, err := chunker.Next()
|
|
if errors.Is(err, io.EOF) {
|
|
break
|
|
}
|
|
|
|
if err != nil {
|
|
return nil, fmt.Errorf("reading chunk: %w", err)
|
|
}
|
|
|
|
// Calculate hash
|
|
hash := sha256.Sum256(chunk.Data)
|
|
|
|
// Make a copy of the data since the chunker reuses the buffer
|
|
chunkData := make([]byte, len(chunk.Data))
|
|
copy(chunkData, chunk.Data)
|
|
|
|
chunks = append(chunks, Chunk{
|
|
Hash: hex.EncodeToString(hash[:]),
|
|
Data: chunkData,
|
|
Offset: offset,
|
|
Size: int64(len(chunk.Data)),
|
|
})
|
|
|
|
offset += int64(len(chunk.Data))
|
|
}
|
|
|
|
return chunks, nil
|
|
}
|
|
|
|
// ChunkCallback is a function called for each chunk as it's processed.
|
|
// The callback receives a Chunk containing the hash, data, offset, and size.
|
|
// If the callback returns an error, chunk processing stops and the error is
|
|
// propagated.
|
|
type ChunkCallback func(chunk Chunk) error
|
|
|
|
// ChunkReaderStreaming splits the reader into chunks and calls the callback
|
|
// for each chunk. This is the preferred method for processing large files or
|
|
// streams as it doesn't accumulate all chunks in memory. The callback is
|
|
// invoked for each chunk as it's produced, allowing for streaming processing
|
|
// and immediate storage or transmission.
|
|
// Returns the SHA256 hash of the entire file content and an error if
|
|
// chunking fails, reading fails, or if the callback returns an error.
|
|
func (c *Chunker) ChunkReaderStreaming(
|
|
r io.Reader, callback ChunkCallback,
|
|
) (string, error) {
|
|
// Create a tee reader to calculate full file hash while chunking
|
|
fileHasher := sha256.New()
|
|
teeReader := io.TeeReader(r, fileHasher)
|
|
|
|
chunker := AcquireReusableChunker(
|
|
teeReader, c.minChunkSize, c.avgChunkSize, c.maxChunkSize)
|
|
defer chunker.Release()
|
|
|
|
offset := int64(0)
|
|
|
|
for {
|
|
chunk, err := chunker.Next()
|
|
if errors.Is(err, io.EOF) {
|
|
break
|
|
}
|
|
|
|
if err != nil {
|
|
return "", fmt.Errorf("reading chunk: %w", err)
|
|
}
|
|
|
|
// Calculate chunk hash
|
|
hash := sha256.Sum256(chunk.Data)
|
|
|
|
// Pass the data directly - caller must process it before we call
|
|
// Next() again (chunker reuses its internal buffer, but since we
|
|
// process synchronously and completely before continuing, no copy
|
|
// is needed)
|
|
err = callback(Chunk{
|
|
Hash: hex.EncodeToString(hash[:]),
|
|
Data: chunk.Data,
|
|
Offset: offset,
|
|
Size: int64(len(chunk.Data)),
|
|
})
|
|
if err != nil {
|
|
return "", fmt.Errorf("callback error: %w", err)
|
|
}
|
|
|
|
offset += int64(len(chunk.Data))
|
|
}
|
|
|
|
// Return the full file hash
|
|
return hex.EncodeToString(fileHasher.Sum(nil)), nil
|
|
}
|
|
|
|
// ChunkFile splits a file into content-defined chunks by reading the entire file.
|
|
// This is a convenience method that opens the file and passes it to ChunkReader.
|
|
// For large files, consider using ChunkReaderStreaming with a file handle instead.
|
|
// Returns an error if the file cannot be opened or if chunking fails.
|
|
func (c *Chunker) ChunkFile(path string) ([]Chunk, error) {
|
|
file, err := os.Open(path) //nolint:gosec // G304: path is caller-supplied by design
|
|
if err != nil {
|
|
return nil, fmt.Errorf("opening file: %w", err)
|
|
}
|
|
defer func() {
|
|
err := file.Close()
|
|
if err != nil && err.Error() != "invalid argument" {
|
|
// Log error or handle as needed
|
|
_ = err
|
|
}
|
|
}()
|
|
|
|
return c.ChunkReader(file)
|
|
}
|