clawbot
ad7941c215
check / check (push) Waiting to run
List and ListStream walked the destination with afero.Walk, which uses Lstat and so reported a symlinked metadata/ or blobs/ directory as one file, while Put, Get and Stat follow the link. The store then listed as empty, and prune removed the local snapshot records and deleted every blob. Both listings now walk a view of the filesystem without its Lstat method, so afero falls back to Stat and enters the link. A listed prefix that is a symlink whose target is missing, such as a link to a volume that is not mounted, fails the listing, as a missing destination directory does. A symlink loop is not detected: it is followed until the system refuses the path for too many levels of links, and the listing fails. Model: opus-5-5
122 lines
3.8 KiB
Go
122 lines
3.8 KiB
Go
package vaultik_test
|
|
|
|
import (
|
|
"context"
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"sneak.berlin/go/vaultik/internal/log"
|
|
"sneak.berlin/go/vaultik/internal/vaultik"
|
|
)
|
|
|
|
// TestPruneDeletesNothingThroughSymlinkedDirectory checks that prune keeps
|
|
// every blob and the local snapshot record when the metadata/ or blobs/
|
|
// directory of a file:// destination is a symlink to a directory elsewhere
|
|
// (https://git.eeqj.de/sneak/vaultik/issues/296). A backup writes through
|
|
// such a link, so prune has to list through it too.
|
|
func TestPruneDeletesNothingThroughSymlinkedDirectory(t *testing.T) {
|
|
log.Initialize(log.Config{})
|
|
t.Parallel()
|
|
|
|
for _, dir := range []string{"metadata", "blobs"} {
|
|
t.Run(dir, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := context.Background()
|
|
storeDir := filepath.Join(t.TempDir(), "store")
|
|
v, repos, _ := backUpToFileDestination(ctx, t, storeDir)
|
|
blobFiles := blobFilesIn(t, storeDir)
|
|
moveBehindSymlink(t, storeDir, dir)
|
|
|
|
require.NoError(t, v.Prune(&vaultik.PruneOptions{Force: true}))
|
|
|
|
// When blobs/ is the link, these paths run through it.
|
|
for _, blobFile := range blobFiles {
|
|
assert.FileExists(t, blobFile, "prune must delete no blob")
|
|
}
|
|
|
|
snapshots, err := repos.Snapshots.ListRecent(ctx, listRecentTestLimit)
|
|
require.NoError(t, err)
|
|
assert.Len(t, snapshots, 1, "prune must delete no local snapshot record")
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestPruneFailsOnSymlinkedDirectoryWithMissingTarget checks that prune
|
|
// fails, deleting no blob and keeping the local snapshot record, when the
|
|
// metadata/ or blobs/ directory of a file:// destination is a symlink
|
|
// whose target is missing, as a link to a volume that is not mounted is.
|
|
func TestPruneFailsOnSymlinkedDirectoryWithMissingTarget(t *testing.T) {
|
|
log.Initialize(log.Config{})
|
|
t.Parallel()
|
|
|
|
for _, dir := range []string{"metadata", "blobs"} {
|
|
t.Run(dir, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := context.Background()
|
|
storeDir := filepath.Join(t.TempDir(), "store")
|
|
v, repos, _ := backUpToFileDestination(ctx, t, storeDir)
|
|
blobFiles := blobFilesIn(t, storeDir)
|
|
targetPath := moveBehindSymlink(t, storeDir, dir)
|
|
|
|
// Unmount the volume the link points to, and mount it again
|
|
// once prune has run.
|
|
unmountedPath := targetPath + "-unmounted"
|
|
require.NoError(t, os.Rename(targetPath, unmountedPath))
|
|
|
|
err := v.Prune(&vaultik.PruneOptions{Force: true})
|
|
require.ErrorIs(t, err, fs.ErrNotExist)
|
|
|
|
require.NoError(t, os.Rename(unmountedPath, targetPath))
|
|
|
|
// When blobs/ is the link, these paths run through it.
|
|
for _, blobFile := range blobFiles {
|
|
assert.FileExists(t, blobFile, "prune must delete no blob")
|
|
}
|
|
|
|
snapshots, err := repos.Snapshots.ListRecent(ctx, listRecentTestLimit)
|
|
require.NoError(t, err)
|
|
assert.Len(t, snapshots, 1, "prune must delete no local snapshot record")
|
|
})
|
|
}
|
|
}
|
|
|
|
// blobFilesIn returns the paths of the blob files under storeDir/blobs, and
|
|
// fails the test when there are none.
|
|
func blobFilesIn(t *testing.T, storeDir string) []string {
|
|
t.Helper()
|
|
|
|
var blobFiles []string
|
|
|
|
err := filepath.WalkDir(filepath.Join(storeDir, "blobs"),
|
|
func(path string, entry fs.DirEntry, err error) error {
|
|
if err == nil && !entry.IsDir() {
|
|
blobFiles = append(blobFiles, path)
|
|
}
|
|
|
|
return err
|
|
})
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, blobFiles)
|
|
|
|
return blobFiles
|
|
}
|
|
|
|
// moveBehindSymlink moves storeDir/dir to a directory elsewhere, puts a
|
|
// symlink to it in its place, and returns where it went.
|
|
func moveBehindSymlink(t *testing.T, storeDir, dir string) string {
|
|
t.Helper()
|
|
|
|
linkPath := filepath.Join(storeDir, dir)
|
|
targetPath := filepath.Join(t.TempDir(), dir)
|
|
require.NoError(t, os.Rename(linkPath, targetPath))
|
|
require.NoError(t, os.Symlink(targetPath, linkPath))
|
|
|
|
return targetPath
|
|
}
|